rjmccall added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:944
+ /// \brief Whether target supports variable-length arrays.
+ bool isVLASupported() const { return VLASupported; }
+
Hahnfeld wrote:
> rjmccall wrote:
> > ABataev wrote:
> > > ABa
rjmccall added a comment.
We don't want this to become a long-term feature; we just want to switch the
implementation over to the new format. Is there a good reason not to do that
in one patch? If so, adding an option is acceptable, but it should be a -cc1
option only, because it is purely a
Author: chandlerc
Date: Mon Nov 13 21:20:03 2017
New Revision: 318137
URL: http://llvm.org/viewvc/llvm-project?rev=318137&view=rev
Log:
[PM] Require a registered x86 target for this test which uses the x86
triple.
Modified:
cfe/trunk/test/CodeGen/bounds-checking.c
Modified: cfe/trunk/test/Co
ahatanak added a comment.
Is it not necessary to print a diagnostic when a non-member function
declaration is missing an availability attribute?
void foo1();
__attribute__((availability(macos, introduced=10.1)))
void foo1() {
}
Repository:
rL LLVM
https://reviews.llvm.org/D39913
Author: chandlerc
Date: Mon Nov 13 17:59:18 2017
New Revision: 318131
URL: http://llvm.org/viewvc/llvm-project?rev=318131&view=rev
Log:
[PM] Wire up support for the bounds checking sanitizer with the new PM.
Not much interesting here. Mostly wiring things together.
One thing worth noting is that
dmajor created this revision.
Herald added subscribers: kristof.beyls, aemerson.
Mozilla's build machines are currently applying this patch locally, but I
thought I'd offer it upstream because it should be pretty harmless.
clang-cl has some sanity checks to make sure that the cl.exe it finds is
Author: chandlerc
Date: Mon Nov 13 17:47:24 2017
New Revision: 318130
URL: http://llvm.org/viewvc/llvm-project?rev=318130&view=rev
Log:
[PM] Add a missing header that I had in the next commit but was needed
in r318128. Should fix the build.
Modified:
cfe/trunk/lib/CodeGen/BackendUtil.cpp
Mod
Author: arphaman
Date: Mon Nov 13 17:46:24 2017
New Revision: 318129
URL: http://llvm.org/viewvc/llvm-project?rev=318129&view=rev
Log:
[completion] complete ObjC interface names in an expression
Objective-C interfaces can be used in a class property expression.
rdar://26982192
Modified:
cfe
lichray added a comment.
In https://reviews.llvm.org/D38216#923580, @rsmith wrote:
> That's almost right, but not all `extern` declarations are disallowed. (An
> `extern` declaration is still a defining declaration if it has an
> initializer.)
Good to know, thanks.
So gcc got this wrong?
ht
Author: chandlerc
Date: Mon Nov 13 17:30:04 2017
New Revision: 318128
URL: http://llvm.org/viewvc/llvm-project?rev=318128&view=rev
Log:
[PM] Port BoundsChecking to the new PM.
Registers it and everything, updates all the references, etc.
Next patch will add support to Clang's `-fexperimental-new
Author: marshall
Date: Mon Nov 13 17:18:36 2017
New Revision: 318126
URL: http://llvm.org/viewvc/llvm-project?rev=318126&view=rev
Log:
Another test for LWG2952
Added:
libcxx/trunk/test/std/iterators/iterator.primitives/iterator.traits/const_volatile_pointer.pass.cpp
Added:
libcxx/trunk/tes
Author: marshall
Date: Mon Nov 13 17:14:53 2017
New Revision: 318125
URL: http://llvm.org/viewvc/llvm-project?rev=318125&view=rev
Log:
Implement LWG2950: std::byte operations are misspecified
Modified:
libcxx/trunk/include/cstddef
libcxx/trunk/include/type_traits
libcxx/trunk/www/cxx2
martell added a comment.
Ping :)
Repository:
rL LLVM
https://reviews.llvm.org/D39673
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgrang added a comment.
In https://reviews.llvm.org/D39947#922987, @rjmccall wrote:
> In https://reviews.llvm.org/D39947#922922, @mgrang wrote:
>
> > In https://reviews.llvm.org/D39947#922889, @rjmccall wrote:
> >
> > > In https://reviews.llvm.org/D39947#922870, @mgrang wrote:
> > >
> > > > Altho
mgrang updated this revision to Diff 122751.
mgrang added a comment.
Fixed the sorting order for stable_sort.
Repository:
rL LLVM
https://reviews.llvm.org/D39947
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
Index: lib/CodeGen/CGOpenMPRuntime.cpp
Hello everyone,
Below are some buildbot numbers for the week of 10/29/2017 - 11/4/2017.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to
Hello everyone,
Below are some buildbot numbers for the week of 10/22/2017 - 10/28/2017.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to
Hello everyone,
Below are some buildbot numbers for the last week of 11/5/2017 - 11/11/2017.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from gree
apazos added inline comments.
Comment at: lib/Driver/ToolChains/RISCV.cpp:86
+CmdArgs.push_back("-lc");
+CmdArgs.push_back("-lgloss");
+CmdArgs.push_back("--end-group");
mgrang wrote:
> How about if our sysroot is linux (as opposed to elf)? There won'
mgrang added inline comments.
Comment at: lib/Driver/ToolChains/RISCV.cpp:86
+CmdArgs.push_back("-lc");
+CmdArgs.push_back("-lgloss");
+CmdArgs.push_back("--end-group");
How about if our sysroot is linux (as opposed to elf)? There won't be any
libglo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL318121: [Sema] Stable sort OverloadCandidates to remove
non-deterministic ordering (authored by mgrang).
Changed prior to commit:
https://reviews.llvm.org/D39944?vs=122598&id=122744#toc
Repository:
r
Author: mgrang
Date: Mon Nov 13 16:22:24 2017
New Revision: 318121
URL: http://llvm.org/viewvc/llvm-project?rev=318121&view=rev
Log:
[Sema] Stable sort OverloadCandidates to remove non-deterministic ordering
Summary: This fixes failure in Misc/diag-template-diffing.cpp uncovered by
D39245.
Revi
Author: marshall
Date: Mon Nov 13 16:03:10 2017
New Revision: 318119
URL: http://llvm.org/viewvc/llvm-project?rev=318119&view=rev
Log:
Implement LWG2952: iterator_traits should work for pointers to cv T
Added:
libcxx/trunk/test/std/iterators/iterator.primitives/iterator.traits/volatile_poin
This revision was automatically updated to reflect the committed changes.
Closed by commit rL318117: add new check for property declaration (authored by
benhamilton).
Repository:
rL LLVM
https://reviews.llvm.org/D39829
Files:
clang-tools-extra/trunk/clang-tidy/objc/CMakeLists.txt
clang-to
Author: benhamilton
Date: Mon Nov 13 15:54:31 2017
New Revision: 318117
URL: http://llvm.org/viewvc/llvm-project?rev=318117&view=rev
Log:
add new check for property declaration
Summary:
This check finds property declarations in Objective-C files that do not follow
the pattern of property names i
Wizard added a comment.
LGTM
https://reviews.llvm.org/D39829
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:2300
+ };
+
+ llvm::SmallPtrSet MissingPlatformAttributes;
erik.pilkington wrote:
> I hate to rewrite your function, but have you considered just doing the
> second loop over the attrs inlin
arphaman updated this revision to Diff 122740.
arphaman added a comment.
- formatting
- simplify checks
- support c++
Repository:
rL LLVM
https://reviews.llvm.org/D39913
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/Sema/SemaDecl.cpp
lib/Sema/SemaDec
Author: zturner
Date: Mon Nov 13 15:33:29 2017
New Revision: 318112
URL: http://llvm.org/viewvc/llvm-project?rev=318112&view=rev
Log:
Revert "Update test_debuginfo.pl script to point to new tree location."
This reverts the aforementioned patch and 2 subsequent follow-ups,
as some buildbots are st
Author: hans
Date: Mon Nov 13 15:27:53 2017
New Revision: 318108
URL: http://llvm.org/viewvc/llvm-project?rev=318108&view=rev
Log:
Update link to the Chromium Clang page
Modified:
cfe/trunk/www/related.html
Modified: cfe/trunk/www/related.html
URL:
http://llvm.org/viewvc/llvm-project/cfe/tr
Author: hans
Date: Mon Nov 13 15:27:54 2017
New Revision: 318109
URL: http://llvm.org/viewvc/llvm-project?rev=318109&view=rev
Log:
Update a link to the old code.google.com bug tracker
Modified:
cfe/trunk/lib/Driver/SanitizerArgs.cpp
Modified: cfe/trunk/lib/Driver/SanitizerArgs.cpp
URL:
http
Author: hans
Date: Mon Nov 13 15:27:55 2017
New Revision: 318110
URL: http://llvm.org/viewvc/llvm-project?rev=318110&view=rev
Log:
Update link to protobuf
Modified:
cfe/trunk/lib/Format/TokenAnnotator.cpp
Modified: cfe/trunk/lib/Format/TokenAnnotator.cpp
URL:
http://llvm.org/viewvc/llvm-pro
benhamilton added a comment.
OK, I updated this diff with the suggested changes. @Wizard, want to take a
look before I land?
https://reviews.llvm.org/D39829
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
benhamilton updated this revision to Diff 122739.
benhamilton added a comment.
- Use regex to match acronym prefixes, update tests
https://reviews.llvm.org/D39829
Files:
clang-tidy/objc/CMakeLists.txt
clang-tidy/objc/ObjCTidyModule.cpp
clang-tidy/objc/PropertyDeclarationCheck.cpp
clang-
Author: eugenezelenko
Date: Mon Nov 13 15:01:27 2017
New Revision: 318101
URL: http://llvm.org/viewvc/llvm-project?rev=318101&view=rev
Log:
[AST] Fix some Clang-tidy modernize and Include What You Use warnings; other
minor fixes (NFC).
Modified:
cfe/trunk/include/clang/AST/Decl.h
cfe/tru
On Sun, Nov 12, 2017 at 12:53 PM Anton via Phabricator <
revi...@reviews.llvm.org> wrote:
> xgsa added a comment.
>
> In https://reviews.llvm.org/D39622#919579, @aprantl wrote:
>
> > For clarification: what is the "symbols table" you are referring to in
> the description?
>
>
> I meant the data du
smeenai added a comment.
It wasn't automatically closed because the commit
(https://reviews.llvm.org/rL317960) referenced the wrong differential in its
Differential Revision field. Not sure how that happened.
Repository:
rL LLVM
https://reviews.llvm.org/D39821
___
arsenm closed this revision.
arsenm added a comment.
r318098
https://reviews.llvm.org/D39784
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: arsenm
Date: Mon Nov 13 14:40:55 2017
New Revision: 318098
URL: http://llvm.org/viewvc/llvm-project?rev=318098&view=rev
Log:
OpenCL: Assume inline asm is convergent
Already done for CUDA.
Modified:
cfe/trunk/lib/CodeGen/CGStmt.cpp
cfe/trunk/test/CodeGenOpenCL/convergent.cl
Modif
On Tue, Nov 14, 2017 at 1:27 AM, Hans Wennborg wrote:
> On Sat, Nov 11, 2017 at 4:18 AM, Roman Lebedev wrote:
>> On Fri, Nov 10, 2017 at 9:14 PM, Hans Wennborg wrote:
>>> On Thu, Oct 12, 2017 at 2:33 PM, Roman Lebedev via cfe-commits
>>> wrote:
On Fri, Oct 13, 2017 at 12:12 AM, Nico Weber
jakehehrlich closed this revision.
jakehehrlich added a comment.
This has already landed, I'm not sure why it wasn't automatically closed.
Repository:
rL LLVM
https://reviews.llvm.org/D39821
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
On Sat, Nov 11, 2017 at 4:18 AM, Roman Lebedev wrote:
> On Fri, Nov 10, 2017 at 9:14 PM, Hans Wennborg wrote:
>> On Thu, Oct 12, 2017 at 2:33 PM, Roman Lebedev via cfe-commits
>> wrote:
>>> On Fri, Oct 13, 2017 at 12:12 AM, Nico Weber wrote:
Huh, I consider clang not warning on this a feat
This revision was automatically updated to reflect the committed changes.
Closed by commit rL318093: [CodeGen] fix const-ness of cbrt and fma (authored
by spatel).
Changed prior to commit:
https://reviews.llvm.org/D39641?vs=122584&id=122727#toc
Repository:
rL LLVM
https://reviews.llvm.org/D
Author: spatel
Date: Mon Nov 13 14:11:49 2017
New Revision: 318093
URL: http://llvm.org/viewvc/llvm-project?rev=318093&view=rev
Log:
[CodeGen] fix const-ness of cbrt and fma
cbrt() is always constant because it can't overflow or underflow. Therefore, it
can't set errno.
fma() is not always cons
hans added inline comments.
Comment at: include/clang/Driver/Options.td:1032
+def fno_instrument_functions_inline : Flag<["-"],
"fno-instrument-functions-inline">, Group, Flags<[CC1Option]>,
+ HelpText<"When using -finstrument-functions, insert the calls after
inlining">;
--
benhamilton added inline comments.
Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:89
+ assert(MatchedDecl->getName().size() > 0);
+ // Skip the check of lowerCamelCase if the name has prefix of special
acronyms
+ if (startsWithSpecialAcronyms(MatchedDecl->getName(),
Author: tstellar
Date: Mon Nov 13 13:27:53 2017
New Revision: 318088
URL: http://llvm.org/viewvc/llvm-project?rev=318088&view=rev
Log:
Merging r312693:
r312693 | marshall | 2017-09-06 21:19:32 -0700 (Wed, 06 Sep 2017) | 1 li
Wizard updated this revision to Diff 122714.
Wizard marked 2 inline comments as done.
Wizard added a comment.
address nits
https://reviews.llvm.org/D39829
Files:
clang-tidy/objc/CMakeLists.txt
clang-tidy/objc/ObjCTidyModule.cpp
clang-tidy/objc/PropertyDeclarationCheck.cpp
clang-tidy/obj
jroelofs accepted this revision.
jroelofs added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D39793
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
johnrusso added inline comments.
Comment at: lib/Driver/ToolChains/RISCV.h:42
+ : GnuTool("RISCV::Linker",
+TC.getTriple().isArch64Bit() ? "riscv64-ld" : "riscv32-ld",
+TC) {}
I wonder if we should construct the linker name ba
vries added a comment.
Committed.
https://reviews.llvm.org/D39793
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Rakete updated this revision to Diff 122708.
Rakete added a comment.
Made `DeduceInits` empty instead of a workaround somewhere else. Is it still
ok, @rsmith ?
https://reviews.llvm.org/D38216
Files:
lib/Sema/SemaDecl.cpp
test/CXX/dcl.dcl/dcl.spec/dcl.type/dcl.type.class.deduct/p1.c
efriedma accepted this revision.
efriedma added a comment.
LGTM
https://reviews.llvm.org/D39641
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith added a comment.
In https://reviews.llvm.org/D38216#922768, @lichray wrote:
> So deducing from default initialization is indeed allowed, but `extern`
> could be interpreted as outlawed because similar to the case of non-
> inline static data member, where the declaration doesn't give **t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL318074: [clang] Remove redundant return [NFC] (authored by
mgrang).
Changed prior to commit:
https://reviews.llvm.org/D39915?vs=122494&id=122693#toc
Repository:
rL LLVM
https://reviews.llvm.org/D39
Author: mgrang
Date: Mon Nov 13 11:29:31 2017
New Revision: 318074
URL: http://llvm.org/viewvc/llvm-project?rev=318074&view=rev
Log:
[clang] Remove redundant return [NFC]
Reviewers: rsmith, sfantao, mcrosier
Reviewed By: mcrosier
Subscribers: jholewinski, cfe-commits
Tags: #clang
Differentia
wmi added a comment.
I think it may be hard to fix the problem in backend. It will face the same
issue of store-to-load forwarding if at some places the transformation happens
but at some other places somehow it doesn't.
But I am not sure whether it is acceptable to add more finegrain bitfield
rnk added inline comments.
Comment at: include/clang/Driver/Options.td:1032
+def fno_instrument_functions_inline : Flag<["-"],
"fno-instrument-functions-inline">, Group, Flags<[CC1Option]>,
+ HelpText<"When using -finstrument-functions, insert the calls after
inlining">;
---
rjmccall added inline comments.
Comment at: lib/CodeGen/CodeGenTBAA.cpp:267
+ if (N)
return N;
The main danger with persisting this kind of reference is that DenseMap doesn't
actually guarantee stability, so if there are recursive calls that can grow the
Author: jvesely
Date: Mon Nov 13 10:28:51 2017
New Revision: 318065
URL: http://llvm.org/viewvc/llvm-project?rev=318065&view=rev
Log:
native_rsqrt: Switch implementation to 1 / native_sqrt
Reviewer: Jeroen Ketema
Signed-off-by: Jan Vesely
Added:
libclc/trunk/generic/lib/math/native_rsqrt.cl
Author: jvesely
Date: Mon Nov 13 10:28:53 2017
New Revision: 318066
URL: http://llvm.org/viewvc/llvm-project?rev=318066&view=rev
Log:
native_recip: provide function implementation instead of macro
Reviewer: Jeroen Ketema
Signed-off-by: Jan Vesely
Added:
libclc/trunk/generic/lib/math/native_
Author: jvesely
Date: Mon Nov 13 10:28:48 2017
New Revision: 318064
URL: http://llvm.org/viewvc/llvm-project?rev=318064&view=rev
Log:
native_tan: Switch implementation to use native_sin/native_cos
Reviewer: Jeroen Ketema
Signed-off-by: Jan Vesely
Added:
libclc/trunk/generic/lib/math/native_
Author: jvesely
Date: Mon Nov 13 10:28:45 2017
New Revision: 318063
URL: http://llvm.org/viewvc/llvm-project?rev=318063&view=rev
Log:
math: Use precomputed constant for log2(10.0)
exp10 CTS fails with or without this change
Reviewer: Jeroen Ketema
Signed-off-by: Jan Vesely
Modified:
libclc
Author: jvesely
Date: Mon Nov 13 10:28:56 2017
New Revision: 318067
URL: http://llvm.org/viewvc/llvm-project?rev=318067&view=rev
Log:
native_divide: provide function implementation instead of macro
Reviewer: Jeroen Ketema
Signed-off-by: Jan Vesely
Added:
libclc/trunk/generic/include/clc/mat
zaks.anna created this revision.
I've sent the email to cfg-dev and the community is supportive of this change.
https://reviews.llvm.org/D39964
Files:
CODE_OWNERS.TXT
Index: CODE_OWNERS.TXT
===
--- CODE_OWNERS.TXT
+++ CODE_OWNE
a.sidorin added a comment.
Hi Peter,
Thank you for the patch. You can find some comments inline.
Comment at: lib/AST/ASTImporter.cpp:5476
+
+ for (unsigned ai = 0, ae = NumArgs; ai != ae; ++ai) {
+Expr *FromArg = CE->getArg(ai);
xazax.hun wrote:
> Use upp
koldaniel added inline comments.
Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:382
+DescFile<"CheckSecuritySyntaxOnly.cpp">;
+ def DeprecatedBufferHandling : Checker<"DeprecatedBufferHandling">,
+HelpText<"Warn on uses of deprecated buffer manipulating fu
a.sidorin added a comment.
Hello Peter,
Patch is almost OK but there are some minor issues.
Comment at: lib/AST/ASTImporter.cpp:5549
+ Expr *BaseE = Importer.Import(E->getBase());
+ if (!BaseE)
+return nullptr;
szepet wrote:
> xazax.hun wrote:
> > Does `
asb created this revision.
Herald added subscribers: jordy.potman.lists, simoncook, johnrusso, rbar,
mgorny.
I'm marking this as an RFC as I'd initially like to get feedback on the testing
approach and structure of this patch (is this about the right granularity or
would you prefer to start wit
halyavin created this revision.
Take extra copies in current_exception() into account.
https://reviews.llvm.org/D39962
Files:
test/std/language.support/support.exception/propagation/current_exception.pass.cpp
Index: test/std/language.support/support.exception/propagation/current_exception.p
halyavin created this revision.
Stack overflow is caused by B copy constructor invoking default constructor of
std::nested_exception which tries to capture current exception. Capturing
current exception copies it and since our current exception is B, we call B's
copy constructor and cause infin
a.sidorin added a comment.
I like this refactoring. I wrote some things that are not clear for me inline.
Comment at: lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp:107
+ void TryXNULock(const CallEvent &Call, CheckerContext &C) const;
+ void AcquireLockAux(const CallEven
Author: sberg
Date: Mon Nov 13 07:40:31 2017
New Revision: 318043
URL: http://llvm.org/viewvc/llvm-project?rev=318043&view=rev
Log:
Remove excess whitespace from syslog message; NFC
Modified:
libcxxabi/trunk/src/private_typeinfo.cpp
Modified: libcxxabi/trunk/src/private_typeinfo.cpp
URL:
ht
Author: tejohnson
Date: Mon Nov 13 07:38:33 2017
New Revision: 318042
URL: http://llvm.org/viewvc/llvm-project?rev=318042&view=rev
Log:
[ThinLTO] Handle -fdebug-pass-manager for backend invocations via clang
Recommit of r317951 and r317951 along with what I believe should fix
the remaining buildb
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D39948
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
a.sidorin added a comment.
Hi Artem. The patch looks mostly good, but I have an inline question.
Comment at: lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp:588
+if (Call->isInSystemHeader())
+ IsLibraryFunction = true;
+ }
Do we think that only sy
a.sidorin added a comment.
Hi Artem,
Sorry for long delay for reviews. Unfortunately, hospital is a bad place to do
a code review and broken hand is a bad review assistant. This patch looks good
to me, I have just a minor comment nit.
Comment at: lib/StaticAnalyzer/Checkers/
a.sidorin added a comment.
Hello Peter,
Looks mostly good, but there are some minor comments.
Comment at: lib/AST/ASTImporter.cpp:5500
+
+ TemplateArgumentListInfo ToTAInfo;
+ TemplateArgumentListInfo *ResInfo = nullptr;
xazax.hun wrote:
> szepet wrote:
> >
Anastasia added a comment.
In https://reviews.llvm.org/D39129#902848, @bader wrote:
> @Anastasia, during the discussion of similar fix
> (https://reviews.llvm.org/D34342).
>
> I found another bug in the CodeGen library. Do you have time to fix it too?
> Here is the reproducer from the old revie
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D39784
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
Anastasia added inline comments.
Comment at: lib/Headers/opencl-c.h:16128
+#define intel_sub_group_block_read_uiintel_sub_group_block_read
+#define intel_sub_group_block_read_ui2 intel_sub_group_block_read2
+#define intel_sub_group_block_read_ui4 intel_sub_group_block_rea
klimek added a comment.
In https://reviews.llvm.org/D32478#920345, @Typz wrote:
> > Unless I'm missing something, I'd agree with Daniel; this is not a rule
> > that's widely used, and I'd say reformatting a code base to the
> > clang-formatted variant will not regress readability.
>
> Unfortuna
tk1012 added a comment.
Hallo Aleksei and Gábor,
Thank you for your response.
> 1. Are import conflicts for anonymous structures resolved correctly?
In fact, this patch only fixes the unnamed structures that are not anonymous.
In https://reviews.llvm.org/D39886#923188, @tk1012 wrote:
>
I ad
kosarev created this revision.
kosarev added a project: clang.
This patch starts a series of changes to add support for the new TBAA metadata
format proposed in this llvm-dev thread:
http://lists.llvm.org/pipermail/llvm-dev/2017-November/118748.html
Repository:
rL LLVM
https://reviews.llvm.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL318035: [X86] test/testn intrinsics lowering to IR. clang
side (authored by uriel.k).
Changed prior to commit:
https://reviews.llvm.org/D38737?vs=122082&id=122639#toc
Repository:
rL LLVM
https://rev
Author: uriel.k
Date: Mon Nov 13 04:50:52 2017
New Revision: 318035
URL: http://llvm.org/viewvc/llvm-project?rev=318035&view=rev
Log:
[X86] test/testn intrinsics lowering to IR. clang side
Change Header files of the intrinsics for lowering test and testn intrinsics to
IR code.
Removed test and t
tk1012 added a comment.
Comment at: lib/AST/ASTImporter.cpp:1634
RecordDecl *PrevDecl = nullptr;
- if (!DC->isFunctionOrMethod()) {
+ if (!DC->isFunctionOrMethod() && SearchName.getAsString() != "") {
SmallVector ConflictingDecls;
According to includ
a.sidorin added a comment.
Hello Takafumi,
Thank you for this patch! I feel positive about it. You can find my comments
inline.
Comment at: lib/AST/ASTImporter.cpp:5540
+ for(auto FromArg : E->getArgs()) {
+TypeSourceInfo *ToTI = Importer.Import(FromArg);
+ToArgVec.p
a.sidorin added a comment.
Hello Takafumi,
Thank you for this patch. Looks like you're trying to disable lookup for
similar structures if the structure is anonymous but there are two things I'm
worrying about this solution.
1. Are import conflicts for anonymous structures resolved correctly?
2
Author: jina.nahias
Date: Mon Nov 13 03:41:41 2017
New Revision: 318031
URL: http://llvm.org/viewvc/llvm-project?rev=318031&view=rev
Log:
Change
// CHECK: shufflevector <8 x double> %0, <8 x double> %{{.*}}, <8 x i32>
To
// CHECK: shufflevector <8 x double> %{{.*}}, <8 x double> %{{.*}}, <8 x i32
ro added a comment.
Could someone please commit this for me? I've no commit access.
Thanks.
https://reviews.llvm.org/D39640
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xazax.hun accepted this revision.
xazax.hun added a comment.
LGTM!
https://reviews.llvm.org/D39800
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xazax.hun accepted this revision.
xazax.hun added a comment.
LGTM!
https://reviews.llvm.org/D39803
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL318030: [analyzer] Document the issue hash debugging
facility (authored by xazax).
Changed prior to commit:
https://reviews.llvm.org/D39543?vs=121290&id=122630#toc
Repository:
rL LLVM
https://review
Author: xazax
Date: Mon Nov 13 03:13:02 2017
New Revision: 318030
URL: http://llvm.org/viewvc/llvm-project?rev=318030&view=rev
Log:
[analyzer] Document the issue hash debugging facility
Differential Revision: https://reviews.llvm.org/D39543
Modified:
cfe/trunk/docs/analyzer/DebugChecks.rst
xazax.hun added a comment.
I agree it might be useful to expose this matcher to everybody.
https://reviews.llvm.org/D38921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D39372
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D39711
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
mstorsjo added a comment.
In https://reviews.llvm.org/D39918#923070, @ruiu wrote:
> Actually I don't have a strong opinion on that topic. It seems like just
> truncating the section name to ".eh_fram" at the linker is good enough, but
> how much important is the compatibility with GNU ld?
It'
ruiu added a comment.
Actually I don't have a strong opinion on that topic. It seems like just
truncating the section name to ".eh_fram" at the linker is good enough, but how
much important is the compatibility with GNU ld?
https://reviews.llvm.org/D39918
___
1 - 100 of 109 matches
Mail list logo
