a.sidorin added a comment. Hi Artem. The patch looks mostly good, but I have an inline question.
================ Comment at: lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp:588 + if (Call->isInSystemHeader()) + IsLibraryFunction = true; + } ---------------- Do we think that only system headers contain library functions? Shouldn't we use `CheckerContext::isCLibraryFunction()` instead? https://reviews.llvm.org/D37812 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
