a.sidorin added a comment.

Hi Artem,

Sorry for long delay for reviews. Unfortunately, hospital is a bad place to do 
a code review and broken hand is a bad review assistant. This patch looks good 
to me, I have just a minor comment nit.



================
Comment at: lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp:282
+    }
+    // We might want to handle the case when the mutex lock function was 
inlined
+    // and returned an Unknown or Undefined value.
----------------
TODO?


https://reviews.llvm.org/D37806



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to