rjmccall added inline comments.
================
Comment at: lib/CodeGen/CodeGenTBAA.cpp:267
+ if (N)
return N;
----------------
The main danger with persisting this kind of reference is that DenseMap doesn't
actually guarantee stability, so if there are recursive calls that can grow the
data structure, the reference will become dangling. I think your patch is okay
for the previous two functions, although I'd like you to check that, but in
this function I'm confident that it's wrong, because you definitely recursively
call getBaseTypeInfo below.
Repository:
rL LLVM
https://reviews.llvm.org/D39953
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
