On Fri, 18 Oct 2024 09:14:06 GMT, Nizar Benalla wrote:
>> Nizar Benalla has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> use existing DOCS_JDK_IMAGE_DIR to be consistent.
>>
>> no ifneq check before assigning the env variable because
On Fri, 18 Oct 2024 08:39:49 GMT, Nizar Benalla wrote:
>> Please review this change that adds a new test root `docs` dedicated to
>> testing the documentation, which has been a work in progress for a while.
>> Tests for links, encoding, HTML, accessibility will be later added in
>> following P
On Fri, 18 Oct 2024 08:39:49 GMT, Nizar Benalla wrote:
>> Please review this change that adds a new test root `docs` dedicated to
>> testing the documentation, which has been a work in progress for a while.
>> Tests for links, encoding, HTML, accessibility will be later added in
>> following P
On Fri, 18 Oct 2024 12:46:36 GMT, Nizar Benalla wrote:
> I'd like to avoid integrating this right before the weekend, and I still want
> to add copyright headers to the other TEST.ROOT files if I can find out when
> they were added. I roughly know how to do it.
I would say fixing copyrights in
On Fri, 18 Oct 2024 12:51:46 GMT, Nizar Benalla wrote:
>> Please review this change that adds a new test root `docs` dedicated to
>> testing the documentation, which has been a work in progress for a while.
>> Tests for links, encoding, HTML, accessibility will be later added in
>> following P
On Fri, 18 Oct 2024 12:21:33 GMT, Erik Joelsson wrote:
>> make/RunTests.gmk line 872:
>>
>>> 870: $1_JTREG_BASIC_OPTIONS += -e:TEST_IMAGE_DIR=$(TEST_IMAGE_DIR)
>>> 871:
>>> 872: $1_JTREG_BASIC_OPTIONS +=
>>> -e:DOCS_JDK_IMAGE_DIR=$$(DOCS_JDK_IMAGE_DIR)
>>
>> I didn't include a null check
On Wed, 7 Aug 2024 10:40:09 GMT, Fei Gao wrote:
> This patch enables BTI branch protection for runtime part on Linux/aarch64
> platform.
>
> Motivation
>
> 1. Since Fedora 33, glibc+kernel are PAC/BTI enabled by default. User-level
> packages can gain additional hardening by compiling with th
On Thu, 15 Aug 2024 15:32:28 GMT, Fei Gao wrote:
>> This patch enables BTI branch protection for runtime part on Linux/aarch64
>> platform.
>>
>> Motivation
>>
>> 1. Since Fedora 33, glibc+kernel are PAC/BTI enabled by default. User-level
>> packages can gain additional hardening by compiling
> This is the implementation of JEP 486: Permanently Disable the Security
> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
> main changes in the JEP and also includes an apidiff of the specif
On Fri, 18 Oct 2024 01:33:18 GMT, Fei Yang wrote:
> In JDK-8339548, we switched to use Debian snapshot
> (https://snapshot.debian.org/archive/debian/20240228T034848Z/) for bootstrap.
> The reason is that we don't have a stable Debian release for RISC-V yet and
> Debian "sid" (https://httpredir
On Fri, 18 Oct 2024 01:33:18 GMT, Fei Yang wrote:
> In JDK-8339548, we switched to use Debian snapshot
> (https://snapshot.debian.org/archive/debian/20240228T034848Z/) for bootstrap.
> The reason is that we don't have a stable Debian release for RISC-V yet and
> Debian "sid" (https://httpredir
On Fri, 18 Oct 2024 08:47:31 GMT, Nizar Benalla wrote:
>> Can I get a review for this patch that adds the necessary changes for local
>> support of the `tidy` library.
>>
>> The dependency can be retrieved by running `make/devkit/createTidyBundle.sh`
>> on Linux and MacOs systems.
>>
>> This
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Thu, 17 Oct 2024 05:54:24 GMT, Alan Bateman wrote:
>> Ok, I'll also add an API note to `getClassContext()` to use `StackWalker`
>> instead.
>
> Okay, it already has `@see StackWalker`. My guess is that anything extending
> SM to call getClassContext is very old code. If that old code is comp
On Fri, 18 Oct 2024 12:26:13 GMT, Erik Joelsson wrote:
>> Nizar Benalla has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 15 additional
>> commits
On Fri, 18 Oct 2024 12:44:36 GMT, Nizar Benalla wrote:
>> Can I get a review for this patch that adds the necessary changes for local
>> support of the `tidy` library.
>>
>> The dependency can be retrieved by running `make/devkit/createTidyBundle.sh`
>> on Linux and MacOs systems.
>>
>> This
On Tue, 15 Oct 2024 20:22:52 GMT, Magnus Ihse Bursie wrote:
>> As a prerequisite for Hermetic Java, we need a statically linked `java`
>> launcher. It should behave like the normal, dynamically linked `java`
>> launcher, except that all JDK native libraries should be statically, not
>> dynamic
> Please review this change that adds a new test root `docs` dedicated to
> testing the documentation, which has been a work in progress for a while.
> Tests for links, encoding, HTML, accessibility will be later added in
> following PRs.
>
> We also define a new make target `test-docs` meant
On Fri, 18 Oct 2024 08:39:49 GMT, Nizar Benalla wrote:
>> Please review this change that adds a new test root `docs` dedicated to
>> testing the documentation, which has been a work in progress for a while.
>> Tests for links, encoding, HTML, accessibility will be later added in
>> following P
On Fri, 18 Oct 2024 12:29:30 GMT, Magnus Ihse Bursie wrote:
>> It's fine to leave out the conditional, but the double `$$` isn't needed and
>> I'm surprised if it actually works. That must be some lucky double
>> evaluation somewhere in that case.
>>
>> Suggestion:
>>
>> $1_JTREG_BASIC_OPT
On Wed, 16 Oct 2024 20:42:11 GMT, Sean Mullan wrote:
>> The description for the SecurityException thrown by these methods were
>> adjusted to "if access to the screen is denied by desktop environment". If
>> you bring back the paragraphs that were removed then you might have to
>> adjust the w
On Tue, 15 Oct 2024 17:01:59 GMT, Sean Mullan wrote:
>>> While making `LogManager.checkAccess` be a no-op might be more convenient,
>>> it could unconditionally permit operations that formerly required a
>>> permission check: clearly a bad idea. Always throwing a `SecurityException`
>>> is the
On Tue, 15 Oct 2024 14:50:54 GMT, Daniel Fuchs wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 97 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Change apiNote to d
On Thu, 17 Oct 2024 17:59:20 GMT, Sean Mullan wrote:
>> All JGSS permission classes follow the same style:
>>
>> In `javax.security.auth.kerberos.DelegationPermission`:
>>
>> * This class is used to restrict the usage of the Kerberos
>> * delegation model, ie: forwardable and proxiable ticket
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Tue, 15 Oct 2024 22:14:00 GMT, Sean Mullan wrote:
>> src/java.management/share/classes/javax/management/remote/JMXConnectorFactory.java
>> line 225:
>>
>>> 223: */
>>> 224: public static JMXConnector connect(JMXServiceURL serviceURL)
>>> 225: throws IOException {
>>
>>
> Can I get a review for this patch that adds the necessary changes for local
> support of the `tidy` library.
>
> The dependency can be retrieved by running `make/devkit/createTidyBundle.sh`
> on Linux and MacOs systems.
>
> This dependency is primarily going to be used to test the generated
> This is the implementation task for `JEP 490: ZGC: Remove the
> Non-Generational Mode`. See the JEP for details.
> [JDK-8335850](https://bugs.openjdk.org/browse/JDK-8335850)
Axel Boldt-Christmas has updated the pull request with a new target base due to
a merge or a rebase. The pull request n
On Fri, 18 Oct 2024 06:46:22 GMT, Axel Boldt-Christmas
wrote:
>> This is the implementation task for `JEP 490: ZGC: Remove the
>> Non-Generational Mode`. See the JEP for details.
>> [JDK-8335850](https://bugs.openjdk.org/browse/JDK-8335850)
>
> Axel Boldt-Christmas has updated the pull request
> Please review this change that adds a new test root `docs` dedicated to
> testing the documentation, which has been a work in progress for a while.
> Tests for links, encoding, HTML, accessibility will be later added in
> following PRs.
>
> We also define a new make target `test-docs` meant
> Can I get a review for this patch that adds the necessary changes for local
> support of the `tidy` library.
>
> The dependency can be retrieved by running `make/devkit/createTidyBundle.sh`
> on Linux and MacOs systems.
>
> This dependency is primarily going to be used to test the generated
On Wed, 16 Oct 2024 18:36:14 GMT, Mikael Vidstedt wrote:
>> Nizar Benalla has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> revert changes to RunTestsPrebuiltSpec.gmk
>
> make/devkit/createTidyBundle.sh line 79:
>
>> 77:
>> 78: cd "$SCRI
On Thu, 17 Oct 2024 15:10:29 GMT, Magnus Ihse Bursie wrote:
>> make/autoconf/lib-tests.m4 line 330:
>>
>>> 328: AC_MSG_RESULT([yes])
>>> 329: AC_MSG_CHECKING([for tidy version])
>>> 330: TIDY_VERSION=`$ECHO $tidy_output | $SED -e 's/.*version //g'`
>>
>> Looks like `TIDY_VERSI
> Can I get a review for this patch that adds the necessary changes for local
> support of the `tidy` library.
>
> The dependency can be retrieved by running `make/devkit/createTidyBundle.sh`
> on Linux and MacOs systems.
>
> This dependency is primarily going to be used to test the generated
On Fri, 18 Oct 2024 08:39:49 GMT, Nizar Benalla wrote:
>> Please review this change that adds a new test root `docs` dedicated to
>> testing the documentation, which has been a work in progress for a while.
>> Tests for links, encoding, HTML, accessibility will be later added in
>> following P
On Wed, 16 Oct 2024 17:37:45 GMT, Erik Joelsson wrote:
>> Nizar Benalla has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> ADD TEST_DEPS when calling tests using test-$1
>>
>> drop docs/req.flg
>
> make/RunTests.gmk line 877:
>
>> 875
36 matches
Mail list logo
