On Thu, 17 Oct 2024 15:10:29 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> make/autoconf/lib-tests.m4 line 330: >> >>> 328: AC_MSG_RESULT([yes]) >>> 329: AC_MSG_CHECKING([for tidy version]) >>> 330: TIDY_VERSION=`$ECHO $tidy_output | $SED -e 's/.*version //g'` >> >> Looks like `TIDY_VERSION` isn't "exported", should it be lower-case? > > We're not really consistant on that usage. In fact, I'd say that most > variables are upper case, regardless of how "local" their use is, and the > lower case variant is a minority. So I'd say it's up to Nizar; if he wants to > change this he can, otherwise it can stay upper case. I lowercased it just to be safe. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21341#discussion_r1806186836
