> Can I get a review for this patch that adds the necessary changes for local > support of the `tidy` library. > > The dependency can be retrieved by running `make/devkit/createTidyBundle.sh` > on Linux and MacOs systems. > > This dependency is primarily going to be used to test the generated > documentation. > > This patch is meant to be integrated before #21272. > > Note: we need to be a very specific revision of `tidy` and cannot use any of > the available artifacts, as older versions do not recognize some HTML 5 > elements. > > TIA
Nizar Benalla has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 15 additional commits since the last revision: - Merge remote-tracking branch 'upstream/master' into tidy-local-build-support - - lower case TIDY_VERSION in lib-tests.m4 - add a few double quotes in createTidyBundle.sh - revert changes to RunTestsPrebuiltSpec.gmk - Whitespace - Slightly cleaner code in `RunTestsPrebuiltSpec.gmk` - Remove check in RunTests.gmk, different approach. Remove environment_name TIDY_HOME - Merge remote-tracking branch 'upstream/master' into tidy-local-build-support - - provide tidy to linux-aarch64. - add condition to module name for tidy - add new condition when passing the path to tidy - Add small comment to `createTidyBundle` - revert fd95431e and remove `tidy` as a dependency for linux-aarch64. Not needed currently - ... and 5 more: https://git.openjdk.org/jdk/compare/d84c0a33...a71aab92 ------------- Changes: - all: https://git.openjdk.org/jdk/pull/21341/files - new: https://git.openjdk.org/jdk/pull/21341/files/47a67f2e..a71aab92 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=21341&range=12 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21341&range=11-12 Stats: 19228 lines in 596 files changed: 14986 ins; 2014 del; 2228 mod Patch: https://git.openjdk.org/jdk/pull/21341.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/21341/head:pull/21341 PR: https://git.openjdk.org/jdk/pull/21341
