On Fri, 18 Oct 2024 08:47:31 GMT, Nizar Benalla <nbena...@openjdk.org> wrote:
>> Can I get a review for this patch that adds the necessary changes for local >> support of the `tidy` library. >> >> The dependency can be retrieved by running `make/devkit/createTidyBundle.sh` >> on Linux and MacOs systems. >> >> This dependency is primarily going to be used to test the generated >> documentation. >> >> This patch is meant to be integrated before #21272. >> >> Note: we need to be a very specific revision of `tidy` and cannot use any of >> the available artifacts, as older versions do not recognize some HTML 5 >> elements. >> >> TIA > > Nizar Benalla has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains 15 additional > commits since the last revision: > > - Merge remote-tracking branch 'upstream/master' into > tidy-local-build-support > - - lower case TIDY_VERSION in lib-tests.m4 > > - add a few double quotes in createTidyBundle.sh > - revert changes to RunTestsPrebuiltSpec.gmk > - Whitespace > - Slightly cleaner code in `RunTestsPrebuiltSpec.gmk` > - Remove check in RunTests.gmk, different approach. > Remove environment_name TIDY_HOME > - Merge remote-tracking branch 'upstream/master' into > tidy-local-build-support > - - provide tidy to linux-aarch64. > - add condition to module name for tidy > - add new condition when passing the path to tidy > - Add small comment to `createTidyBundle` > - revert fd95431e and remove `tidy` as a dependency for linux-aarch64. Not > needed currently > - ... and 5 more: https://git.openjdk.org/jdk/compare/ef9e8c00...a71aab92 make/autoconf/lib-tests.m4 line 331: > 329: AC_MSG_CHECKING([for tidy version]) > 330: tidy_version=`$ECHO $tidy_output | $SED -e 's/.*version //g'` > 331: AC_MSG_RESULT([$TIDY_VERSION]) You missed lower casing the reference here. Suggestion: AC_MSG_RESULT([$tidy_version]) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21341#discussion_r1806410203
