On Wed, 16 Oct 2024 17:37:45 GMT, Erik Joelsson <er...@openjdk.org> wrote:
>> Nizar Benalla has updated the pull request incrementally with one additional >> commit since the last revision: >> >> ADD TEST_DEPS when calling tests using test-$1 >> >> drop docs/req.flg > > make/RunTests.gmk line 877: > >> 875: DOCS_PATH := $$(OUTPUTDIR)/images/docs >> 876: endif >> 877: $1_JTREG_BASIC_OPTIONS += -e:DOCS_IMAGE_DIR=$$(DOCS_PATH) > > Looking at this again, I just realized we do have this path defined in > spec.gmk already, but with a different name: `DOCS_JDK_IMAGE_DIR` (along with > `DOCS_JAVASE_IMAGE_DIR` and `DOCS_REFERENCE_IMAGE_DIR`). I think we should > stick with this existing name instead of introducing a new one, so it's > consistent across the whole build system. Then we don't need this fallback to > $(OUTPUTDIR) anymore. `DOCS_JDK_IMAGE_DIR` will either be defined in spec.gmk > from configure or from jib-profiles when running `run-tests-prebuilt-docs`. Thanks, I hadn't seen this ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21272#discussion_r1806168688
