Re: [I] add toInputStream to ByteString [incubator-pekko]
pjfanning commented on issue #995: URL: https://github.com/apache/incubator-pekko/issues/995#issuecomment-1935605593 #1085 merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] Update sbt-paradox-apidoc to 1.1.0 [incubator-pekko]
raboof commented on PR #1099: URL: https://github.com/apache/incubator-pekko/pull/1099#issuecomment-1935621168 The error is `java.lang.UnsupportedClassVersionError: org/parboiled/trees/GraphNode has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0` in `sbt validatePullRequest`. We should probably run `validatePullRequest` with jdk11 as that's what we're using to build the releases as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] Update sbt-paradox-apidoc to 1.1.0 [incubator-pekko]
mkurz commented on PR #1099: URL: https://github.com/apache/incubator-pekko/pull/1099#issuecomment-1935623968 @raboof See conversation starting with https://github.com/apache/incubator-pekko/pull/1061#issuecomment-1913598078 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[PR] run prValidation on Java 11 [incubator-pekko]
raboof opened a new pull request, #1107: URL: https://github.com/apache/incubator-pekko/pull/1107 As that's what we're using to release as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] Update sbt-paradox-apidoc to 1.1.0 [incubator-pekko]
pjfanning commented on PR #1099: URL: https://github.com/apache/incubator-pekko/pull/1099#issuecomment-1935626680 We have a discussion at https://lists.apache.org/thread/ro3rz6s8mvj7j9dp39oszf7rnr6hn19d - I might take it to a vote. My preference is to upgrade and use java 11 for doc building in our CI builds. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] Update sbt-paradox-apidoc to 1.1.0 [incubator-pekko]
raboof commented on PR #1099: URL: https://github.com/apache/incubator-pekko/pull/1099#issuecomment-1935655639 Thanks for the references! We release Pekko itself with Java 11 already, but indeed if we want to keep supporting development under Java 8, and be consistent with other Pekko projects still building with Java 8, it might make sense to keep building the Pekko docs with Java 8 as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] run prValidation on Java 11 [incubator-pekko]
raboof commented on PR #1107: URL: https://github.com/apache/incubator-pekko/pull/1107#issuecomment-1935713448 Moving this to 'draft' since this change would increase the chance that we inadvertently accept a change that would break developing Pekko on Java 8. Discussion around this is ongoing at https://lists.apache.org/thread/ro3rz6s8mvj7j9dp39oszf7rnr6hn19d -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] [scala3] Enable scala3_sources [incubator-pekko-grpc]
kczulko commented on PR #222: URL: https://github.com/apache/incubator-pekko-grpc/pull/222#issuecomment-1935714480 @pjfanning @mdedetrich Please let me know if there's anything you want from me to push it forward. Thanks in advance, Karol -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] fix Kafka flaky test [incubator-pekko-projection]
Roiocam commented on PR #105: URL: https://github.com/apache/incubator-pekko-projection/pull/105#issuecomment-1935793124 > TBH I'm not convinced this change fixes the root cause of the instability: because of the assertion `records.count(_.partition() == tp0.partition()) shouldBe 5` AFAICS it should be guaranteed that `tp0TestCount` would always be 5, so this change should not have an effect other than timing differences - or did I miss something? The producer produces a total of 20 elements, and each partition has 10 evenly. Then Sink consumes 10 elements from two partitions. There is no assertion that each partition consumes 5 evenly. If it is not consumed evenly, it will lead to problems with subsequent assertions, because partition 0 may consume 6 records in the previous step. This PR does not force the assertion that Sink consumes evenly from all partitions. If Kafka Consumer is not balanced consume from partitions, I don't think this is the responsibility of this test or should be added a new test to assert. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] fix Kafka flaky test [incubator-pekko-projection]
raboof commented on PR #105: URL: https://github.com/apache/incubator-pekko-projection/pull/105#issuecomment-1935811477 > > TBH I'm not convinced this change fixes the root cause of the instability: because of the assertion `records.count(_.partition() == tp0.partition()) shouldBe 5` AFAICS it should be guaranteed that `tp0TestCount` would always be 5, so this change should not have an effect other than timing differences - or did I miss something? > > The producer produces a total of 20 elements, and each partition has 10 evenly. > > Then Sink consumes 10 elements from two partitions. There is no assertion that each partition consumes 5 evenly. Isn't that asserted by https://github.com/apache/incubator-pekko-projection/pull/105/files#diff-fdbaabc373547fac2368cc881beaa945f8d0225553d3e964dbe09eaf792592adR108-R112 ? > If it is not consumed evenly, it will lead to problems with subsequent assertions, because partition 0 may consume 6 records in the previous step. > > This PR does not force the assertion that Sink consumes evenly from all partitions. If Kafka Consumer is not balanced consume from partitions, I don't think this is the responsibility of this test or should be added a new test to assert. That makes sense to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[PR] Remove Scala 3 type inference workaround [incubator-pekko-connectors]
mdedetrich opened a new pull request, #464: URL: https://github.com/apache/incubator-pekko-connectors/pull/464 Issue was fixed in Scala 3.3.1, see https://github.com/lampepfl/dotty/issues/18438 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] upgrade commons-net to 3.10.0 due to cve [incubator-pekko-connectors]
pjfanning merged PR #171: URL: https://github.com/apache/incubator-pekko-connectors/pull/171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[I] uptake commons-net 3.11.0 (when released) and rewrite the LegacyFtpsClient [incubator-pekko-connectors]
pjfanning opened a new issue, #465: URL: https://github.com/apache/incubator-pekko-connectors/issues/465 Follow up to https://github.com/apache/incubator-pekko-connectors/pull/171 With https://github.com/apache/commons-net/pull/204 - it will be possible to rewrite LegacyFtpsClient to subclass commons-net FTPSClient and only keep `_openDataConnection_`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] upgrade commons-net to 3.10.0 due to cve [incubator-pekko-connectors]
pjfanning commented on PR #171: URL: https://github.com/apache/incubator-pekko-connectors/pull/171#issuecomment-1935946048 I logged https://github.com/apache/incubator-pekko-connectors/issues/465 as a follow up -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] Remove Scala 3 type inference workaround [incubator-pekko-connectors]
mdedetrich merged PR #464: URL: https://github.com/apache/incubator-pekko-connectors/pull/464 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[PR] Remove Scala 3 type inference workaround [incubator-pekko-connectors]
mdedetrich opened a new pull request, #466: URL: https://github.com/apache/incubator-pekko-connectors/pull/466 (cherry picked from commit 71141e1294410871e15e579ed05291a0296077c1) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[PR] Rename akka reference to pekko [incubator-pekko-connectors]
mdedetrich opened a new pull request, #467: URL: https://github.com/apache/incubator-pekko-connectors/pull/467 Self explanatory -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] Remove Scala 3 type inference workaround [incubator-pekko-connectors]
mdedetrich commented on PR #466: URL: https://github.com/apache/incubator-pekko-connectors/pull/466#issuecomment-1935968119 > I'm not opposed to this change, so LGTM, but I'm not sure it is useful to backport so aggressively. Point taken, for me its more about making sure the branches are clean for the versions of Pekko we still support but I can see how it can be considered excessive. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] Rework filter clause before join on eventsByTag [incubator-pekko-persistence-jdbc]
pjfanning commented on PR #106: URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/106#issuecomment-1935969690 @wjohnsonbynder would you be able to try to get some performance numbers? https://github.com/apache/incubator-pekko-persistence-jdbc/blob/main/core/src/test/scala/org/apache/pekko/persistence/jdbc/query/EventsByTagTest.scala#L396 "show the configured performance characteristics" looks like a test could demo a perf improvement. We have integration tests and this CI script gives you an idea of how to run them with postgres but there are other files for other databases if you prefer another database. https://github.com/apache/incubator-pekko-persistence-jdbc/blob/main/.github/workflows/postgres-tests.yml -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[PR] don't fully specify scala versions [incubator-pekko-persistence-jdbc]
pjfanning opened a new pull request, #107: URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/107 * shouldn't be needed with latest versions of sbt * makes for easier maintenance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[I] docs.javadsl.MqttFlowTest: leaks actors [incubator-pekko-connectors]
raboof opened a new issue, #468: URL: https://github.com/apache/incubator-pekko-connectors/issues/468 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] Rename akka reference to pekko [incubator-pekko-connectors]
raboof commented on PR #467: URL: https://github.com/apache/incubator-pekko-connectors/pull/467#issuecomment-1936024702 > lgtm - the mqtt-streaming tests are failing again but otherwise things look ok it's a different one than the two that I fixed, luckily. Let's make sure to file issues and add references to them when they happen, so we can see which are the most urgent to fix next. Added #468 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] Rework filter clause before join on eventsByTag [incubator-pekko-persistence-jdbc]
pjfanning commented on PR #106: URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/106#issuecomment-1936029324 @wjohnsonbynder I had a look at the postgres integration times from the CI build for your PR and the time taken by the "show the configured performance characteristics" test takes a similar amount of time as for runs without your change. Would you be able to have a look at the "show the configured performance characteristics" test to see if it is a useful test for your change? If it is, we could increase the iterations to see if makes the perf changes more obvious. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] Remove Scala 3 type inference workaround [incubator-pekko-connectors]
raboof commented on PR #466: URL: https://github.com/apache/incubator-pekko-connectors/pull/466#issuecomment-1936031874 Re-opening #458 :/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [I] MqttSessionSpec: MQTT client connector should unsubscribe a client session test flaky [incubator-pekko-connectors]
raboof closed issue #458: MqttSessionSpec: MQTT client connector should unsubscribe a client session test flaky URL: https://github.com/apache/incubator-pekko-connectors/issues/458 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] Remove Scala 3 type inference workaround [incubator-pekko-connectors]
raboof merged PR #466: URL: https://github.com/apache/incubator-pekko-connectors/pull/466 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] Rename akka reference to pekko [incubator-pekko-connectors]
raboof merged PR #467: URL: https://github.com/apache/incubator-pekko-connectors/pull/467 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] don't fully specify scala versions [incubator-pekko-persistence-jdbc]
raboof merged PR #107: URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] scalatest 3.2.18 [incubator-pekko-grpc]
raboof merged PR #226: URL: https://github.com/apache/incubator-pekko-grpc/pull/226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[PR] Update docker-compose.yml [incubator-pekko-persistence-jdbc]
pjfanning opened a new pull request, #108: URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/108 I am having trouble starting the docker containers using `docker-compose`. I looked at the docker-compose.yml in pekko-connectors and that works fine (for me). I copied in these changes and now docker-compose works fine for me with this repo too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] Update docker-compose.yml [incubator-pekko-persistence-jdbc]
raboof merged PR #108: URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] Update action in link-validator.yml [incubator-pekko-persistence-cassandra]
pjfanning merged PR #132: URL: https://github.com/apache/incubator-pekko-persistence-cassandra/pull/132 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[PR] pekko-http 1.0.1 [incubator-pekko-management]
pjfanning opened a new pull request, #160: URL: https://github.com/apache/incubator-pekko-management/pull/160 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[PR] pekko-http 1.0.1 / scalatest 3.2.18 [incubator-pekko-samples]
pjfanning opened a new pull request, #99: URL: https://github.com/apache/incubator-pekko-samples/pull/99 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] pekko-http 1.0.1 [incubator-pekko-management]
raboof merged PR #160: URL: https://github.com/apache/incubator-pekko-management/pull/160 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[PR] pekko-http 1.0.1 [incubator-pekko-http-quickstart-java.g8]
pjfanning opened a new pull request, #7: URL: https://github.com/apache/incubator-pekko-http-quickstart-java.g8/pull/7 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[PR] pekko-http 1.0.1 [incubator-pekko-http-quickstart-scala.g8]
pjfanning opened a new pull request, #4: URL: https://github.com/apache/incubator-pekko-http-quickstart-scala.g8/pull/4 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] pekko-http 1.0.1 / scalatest 3.2.18 [incubator-pekko-samples]
raboof commented on code in PR #99: URL: https://github.com/apache/incubator-pekko-samples/pull/99#discussion_r1484631453 ## pekko-sample-persistence-dc-java/pom.xml: ## @@ -20,7 +20,7 @@ UTF-8 1.0.2 1.0.0 -1.0.0 +1.0.2 Review Comment: ```suggestion 1.0.1 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[PR] chore: fix typo: ContentNegotation -> ContentNegotiation [incubator-pekko-http]
raboof opened a new pull request, #477: URL: https://github.com/apache/incubator-pekko-http/pull/477 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] missing bracket in markdown (#474) [incubator-pekko-http]
raboof merged PR #475: URL: https://github.com/apache/incubator-pekko-http/pull/475 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] pekko-http 1.0.1 [incubator-pekko-http-quickstart-scala.g8]
raboof merged PR #4: URL: https://github.com/apache/incubator-pekko-http-quickstart-scala.g8/pull/4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] pekko-http 1.0.1 [incubator-pekko-http-quickstart-java.g8]
raboof merged PR #7: URL: https://github.com/apache/incubator-pekko-http-quickstart-java.g8/pull/7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[PR] pekko-http 1.0.1 [incubator-pekko-platform-guide]
pjfanning opened a new pull request, #73: URL: https://github.com/apache/incubator-pekko-platform-guide/pull/73 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[PR] pekko-http 1.0.1 [incubator-pekko-connectors-samples]
pjfanning opened a new pull request, #30: URL: https://github.com/apache/incubator-pekko-connectors-samples/pull/30 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[PR] Rename akka reference to pekko (#467) [incubator-pekko-connectors]
mdedetrich opened a new pull request, #469: URL: https://github.com/apache/incubator-pekko-connectors/pull/469 (cherry picked from commit 43ee6b702cc1ecbbf23a78d0acd3de957b21add4) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] Allow producing JDK8 bytecode on newer JDK's [incubator-pekko-grpc]
mdedetrich commented on PR #101: URL: https://github.com/apache/incubator-pekko-grpc/pull/101#issuecomment-1936661428 Thanks, completely forgot about this PR. Will check it out later -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] kinesis: use stage materializer with IODispatcher instead of injected EC [incubator-pekko-connectors]
mdedetrich commented on code in PR #226:
URL:
https://github.com/apache/incubator-pekko-connectors/pull/226#discussion_r1484856491
##
kinesis/src/main/scala/org/apache/pekko/stream/connectors/kinesis/impl/KinesisSchedulerSourceStage.scala:
##
@@ -111,6 +112,23 @@ private[kinesis] class KinesisSchedulerSourceStage(
failStage(SchedulerUnexpectedShutdown(e))
}
override def postStop(): Unit =
- schedulerOpt.foreach(scheduler => Future(if
(!scheduler.shutdownComplete()) scheduler.shutdown()))
+ schedulerOpt.foreach(scheduler =>
+if (!scheduler.shutdownComplete()) scheduler.shutdown()
+ )
+
+protected def executionContext(attributes: Attributes): ExecutionContext =
{
+ val dispatcherId =
(attributes.get[ActorAttributes.Dispatcher](ActorAttributes.IODispatcher) match
{
+case ActorAttributes.Dispatcher("") =>
Review Comment:
Should this just be any strict rather than just `""`?
##
kinesis/src/main/scala/org/apache/pekko/stream/connectors/kinesis/impl/KinesisSchedulerSourceStage.scala:
##
@@ -111,6 +112,23 @@ private[kinesis] class KinesisSchedulerSourceStage(
failStage(SchedulerUnexpectedShutdown(e))
}
override def postStop(): Unit =
- schedulerOpt.foreach(scheduler => Future(if
(!scheduler.shutdownComplete()) scheduler.shutdown()))
+ schedulerOpt.foreach(scheduler =>
+if (!scheduler.shutdownComplete()) scheduler.shutdown()
+ )
+
+protected def executionContext(attributes: Attributes): ExecutionContext =
{
+ val dispatcherId =
(attributes.get[ActorAttributes.Dispatcher](ActorAttributes.IODispatcher) match
{
+case ActorAttributes.Dispatcher("") =>
Review Comment:
Should this just be any string rather than just `""`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] kinesis: use stage materializer with IODispatcher instead of injected EC [incubator-pekko-connectors]
mdedetrich commented on PR #226: URL: https://github.com/apache/incubator-pekko-connectors/pull/226#issuecomment-1936681246 @raboof You want to have a quick look at this incase anything was missed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] Rename akka reference to pekko (#467) [incubator-pekko-connectors]
mdedetrich merged PR #469: URL: https://github.com/apache/incubator-pekko-connectors/pull/469 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] kinesis: use stage materializer with IODispatcher instead of injected EC [incubator-pekko-connectors]
mdedetrich commented on code in PR #226:
URL:
https://github.com/apache/incubator-pekko-connectors/pull/226#discussion_r1484856491
##
kinesis/src/main/scala/org/apache/pekko/stream/connectors/kinesis/impl/KinesisSchedulerSourceStage.scala:
##
@@ -111,6 +112,23 @@ private[kinesis] class KinesisSchedulerSourceStage(
failStage(SchedulerUnexpectedShutdown(e))
}
override def postStop(): Unit =
- schedulerOpt.foreach(scheduler => Future(if
(!scheduler.shutdownComplete()) scheduler.shutdown()))
+ schedulerOpt.foreach(scheduler =>
+if (!scheduler.shutdownComplete()) scheduler.shutdown()
+ )
+
+protected def executionContext(attributes: Attributes): ExecutionContext =
{
+ val dispatcherId =
(attributes.get[ActorAttributes.Dispatcher](ActorAttributes.IODispatcher) match
{
+case ActorAttributes.Dispatcher("") =>
Review Comment:
Should this just be matching against any string rather than just `""`, i.e.
is there a case we can having something aside from `""`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] kinesis: use stage materializer with IODispatcher instead of injected EC [incubator-pekko-connectors]
jtjeferreira commented on code in PR #226:
URL:
https://github.com/apache/incubator-pekko-connectors/pull/226#discussion_r1484871296
##
kinesis/src/main/scala/org/apache/pekko/stream/connectors/kinesis/impl/KinesisSchedulerSourceStage.scala:
##
@@ -111,6 +112,23 @@ private[kinesis] class KinesisSchedulerSourceStage(
failStage(SchedulerUnexpectedShutdown(e))
}
override def postStop(): Unit =
- schedulerOpt.foreach(scheduler => Future(if
(!scheduler.shutdownComplete()) scheduler.shutdown()))
+ schedulerOpt.foreach(scheduler =>
+if (!scheduler.shutdownComplete()) scheduler.shutdown()
+ )
+
+protected def executionContext(attributes: Attributes): ExecutionContext =
{
+ val dispatcherId =
(attributes.get[ActorAttributes.Dispatcher](ActorAttributes.IODispatcher) match
{
+case ActorAttributes.Dispatcher("") =>
Review Comment:
this was copied from JMSConnector as per your
[comment](https://github.com/apache/incubator-pekko-connectors/pull/226#issuecomment-1686461378)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
[PR] [DRAFT] upgrade paradox plugins [incubator-pekko-http]
pjfanning opened a new pull request, #478: URL: https://github.com/apache/incubator-pekko-http/pull/478 * might fail due to java 8 build issues * passed on my laptop - which surprised me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] [DRAFT] upgrade paradox plugins [incubator-pekko-http]
mdedetrich commented on PR #478: URL: https://github.com/apache/incubator-pekko-http/pull/478#issuecomment-1936736735 > * might fail due to java 8 build issues > * passed on my laptop - which surprised me We need to be careful with this. The core issue is not that it would fail to compile but rather it links against the wrong JDK which means the generated api docs would t be correct since the lowest JDK version we support is 8. I am trying to suggest that sbt-paradox maintains maintenance of its 0.9.x branch which supports JDK 8 with backports of from future paradox versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] [DRAFT] upgrade paradox plugins [incubator-pekko-http]
pjfanning commented on PR #478: URL: https://github.com/apache/incubator-pekko-http/pull/478#issuecomment-1936739605 * today we are dependent on a non-standard maven repo to get these old versions of plugins * this is bad * we need to use maven central * we need a proper control over our builds to avoid supply chain injection attacks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] [DRAFT] upgrade paradox plugins [incubator-pekko-http]
mdedetrich commented on PR #478: URL: https://github.com/apache/incubator-pekko-http/pull/478#issuecomment-1936750375 > * today we are dependent on a non-standard maven repo to get these old versions of plugins > * this is bad > * we need to use maven central > * we need a proper control over our builds to avoid supply chain injection attacks Yes and the whole point of that ticket is to re-release current sbt-paradox 0.9.2 on maven -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] kinesis: use stage materializer with IODispatcher instead of injected EC [incubator-pekko-connectors]
mdedetrich commented on code in PR #226:
URL:
https://github.com/apache/incubator-pekko-connectors/pull/226#discussion_r1484927141
##
kinesis/src/main/scala/org/apache/pekko/stream/connectors/kinesis/impl/KinesisSchedulerSourceStage.scala:
##
@@ -111,6 +112,23 @@ private[kinesis] class KinesisSchedulerSourceStage(
failStage(SchedulerUnexpectedShutdown(e))
}
override def postStop(): Unit =
- schedulerOpt.foreach(scheduler => Future(if
(!scheduler.shutdownComplete()) scheduler.shutdown()))
+ schedulerOpt.foreach(scheduler =>
+if (!scheduler.shutdownComplete()) scheduler.shutdown()
+ )
+
+protected def executionContext(attributes: Attributes): ExecutionContext =
{
+ val dispatcherId =
(attributes.get[ActorAttributes.Dispatcher](ActorAttributes.IODispatcher) match
{
+case ActorAttributes.Dispatcher("") =>
Review Comment:
Hmm, I guess its okay then but we should probably make a ticket to have a
look at this separately since its code smell.
##
kinesis/src/main/scala/org/apache/pekko/stream/connectors/kinesis/impl/KinesisSchedulerSourceStage.scala:
##
@@ -111,6 +112,23 @@ private[kinesis] class KinesisSchedulerSourceStage(
failStage(SchedulerUnexpectedShutdown(e))
}
override def postStop(): Unit =
- schedulerOpt.foreach(scheduler => Future(if
(!scheduler.shutdownComplete()) scheduler.shutdown()))
+ schedulerOpt.foreach(scheduler =>
+if (!scheduler.shutdownComplete()) scheduler.shutdown()
+ )
+
+protected def executionContext(attributes: Attributes): ExecutionContext =
{
+ val dispatcherId =
(attributes.get[ActorAttributes.Dispatcher](ActorAttributes.IODispatcher) match
{
+case ActorAttributes.Dispatcher("") =>
Review Comment:
Hmm, I guess its okay then but we should probably make a ticket to have a
look at this separately since it looks like code smell.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
[PR] mem settings for link-validator.yml [incubator-pekko-http]
pjfanning opened a new pull request, #479: URL: https://github.com/apache/incubator-pekko-http/pull/479 Job is running into GC issues because it is running with constrained heap memory -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] pekko-http 1.0.1 [incubator-pekko-connectors-samples]
pjfanning merged PR #30: URL: https://github.com/apache/incubator-pekko-connectors-samples/pull/30 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] mem settings for link-validator.yml [incubator-pekko-http]
pjfanning merged PR #479: URL: https://github.com/apache/incubator-pekko-http/pull/479 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[PR] chore: Add Scala 3.3 to build matrix. [incubator-pekko]
pjfanning opened a new pull request, #1108: URL: https://github.com/apache/incubator-pekko/pull/1108 cherry pick cfff9c53df859bb0f4407caf4821e7831dabeb19 due to #1081 and #1082 - want to see if the issues are new -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] chore: Add Scala 3.3 to build matrix. [incubator-pekko]
raboof merged PR #1108: URL: https://github.com/apache/incubator-pekko/pull/1108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [I] 1.0.x branch has an empty `publish-1.0-nightly` workflow [incubator-pekko]
pjfanning commented on issue #1109: URL: https://github.com/apache/incubator-pekko/issues/1109#issuecomment-1936955214 We should just delete the empty file. We run the job from the main branch - the yml has a `ref: 1.0.x` in its checkout. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [I] 1.0.x branch has an empty `publish-1.0-nightly` workflow [incubator-pekko]
mdedetrich commented on issue #1109: URL: https://github.com/apache/incubator-pekko/issues/1109#issuecomment-1936955494 Yeah that appears to be an accident -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[PR] Remove publish-1.0 workflow [incubator-pekko]
raboof opened a new pull request, #1110: URL: https://github.com/apache/incubator-pekko/pull/1110 Since 1.0 is published from the main branch. Fixes #1109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[I] very verbose logging for missing property [incubator-pekko]
pjfanning opened a new issue, #: URL: https://github.com/apache/incubator-pekko/issues/ An optional property in #765 is leading to lots of logging like this ``` 12-489: No configuration setting found for key 'pekko.cluster.akka' com.typesafe.config.ConfigException$Missing: merge of String: 2-7,system properties,reference.conf @ file:/home/runner/work/incubator-pekko/incubator-pekko/cluster/target/scala-2.13/classes/reference.conf: 12-489: No configuration setting found for key 'pekko.cluster.akka' at com.typesafe.config.impl.SimpleConfig.findKeyOrNull(SimpleConfig.java:157) at com.typesafe.config.impl.SimpleConfig.findKey(SimpleConfig.java:150) at com.typesafe.config.impl.SimpleConfig.findOrNull(SimpleConfig.java:177) at com.typesafe.config.impl.SimpleConfig.findOrNull(SimpleConfig.java:181) at com.typesafe.config.impl.SimpleConfig.findOrNull(SimpleConfig.java:181) at com.typesafe.config.impl.SimpleConfig.find(SimpleConfig.java:189) at com.typesafe.config.impl.SimpleConfig.find(SimpleConfig.java:194) at com.typesafe.config.impl.SimpleConfig.getString(SimpleConfig.java:251) at org.apache.pekko.cluster.SeedNodeProcess.akkaVersion$lzycompute(SeedNodeProcess.scala:61) at org.apache.pekko.cluster.SeedNodeProcess.akkaVersion(SeedNodeProcess.scala:56) at org.apache.pekko.cluster.SeedNodeProcess.receiveJoinSeedNode(SeedNodeProcess.scala:84) at org.apache.pekko.cluster.JoinSeedNodeProcess$$anonfun$receive$2.applyOrElse(SeedNodeProcess.sc ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[PR] add default for pekko.cluster.akka.version [incubator-pekko]
pjfanning opened a new pull request, #1112: URL: https://github.com/apache/incubator-pekko/pull/1112 This property is only needed if you have pekko.remote.accept-protocol-names set up to include "akka". This is the case in the test config for pekko-remote and we get a lot of logging about pekko.cluster.akka.version as a result. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] pekko-http 1.0.1 / scalatest 3.2.18 [incubator-pekko-samples]
raboof merged PR #99: URL: https://github.com/apache/incubator-pekko-samples/pull/99 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] add default for pekko.cluster.akka.version [incubator-pekko]
mdedetrich commented on code in PR #1112:
URL: https://github.com/apache/incubator-pekko/pull/1112#discussion_r1485065506
##
cluster/src/main/scala/org/apache/pekko/cluster/SeedNodeProcess.scala:
##
@@ -57,8 +57,10 @@ private[cluster] abstract class
SeedNodeProcess(joinConfigCompatChecker: JoinCon
val cfg = context.system.settings.config
if (cfg.hasPath("akka.version")) {
cfg.getString("akka.version")
-} else {
+} else if (cfg.hasPath("pekko.cluster.akka.version")) {
cfg.getString("pekko.cluster.akka.version")
+} else {
+ "2.6.21"
Review Comment:
Should this be configurable as well or is that taking things too far?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] add default for pekko.cluster.akka.version [incubator-pekko]
pjfanning commented on code in PR #1112:
URL: https://github.com/apache/incubator-pekko/pull/1112#discussion_r1485066347
##
cluster/src/main/scala/org/apache/pekko/cluster/SeedNodeProcess.scala:
##
@@ -57,8 +57,10 @@ private[cluster] abstract class
SeedNodeProcess(joinConfigCompatChecker: JoinCon
val cfg = context.system.settings.config
if (cfg.hasPath("akka.version")) {
cfg.getString("akka.version")
-} else {
+} else if (cfg.hasPath("pekko.cluster.akka.version")) {
cfg.getString("pekko.cluster.akka.version")
+} else {
+ "2.6.21"
Review Comment:
I could set it in pekko-remote test conf too. Should I just then throw an
exception if it isn't set. This code path only happens when
pekko.remote.accept-protocol-names is set up to include "akka".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] add default for pekko.cluster.akka.version [incubator-pekko]
pjfanning commented on code in PR #1112:
URL: https://github.com/apache/incubator-pekko/pull/1112#discussion_r1485066414
##
cluster/src/main/scala/org/apache/pekko/cluster/SeedNodeProcess.scala:
##
@@ -57,8 +57,10 @@ private[cluster] abstract class
SeedNodeProcess(joinConfigCompatChecker: JoinCon
val cfg = context.system.settings.config
if (cfg.hasPath("akka.version")) {
cfg.getString("akka.version")
-} else {
+} else if (cfg.hasPath("pekko.cluster.akka.version")) {
cfg.getString("pekko.cluster.akka.version")
+} else {
+ "2.6.21"
Review Comment:
I definitely don't think another config setting improves this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] add default for pekko.cluster.akka.version [incubator-pekko]
pjfanning commented on code in PR #1112:
URL: https://github.com/apache/incubator-pekko/pull/1112#discussion_r1485067235
##
cluster/src/main/scala/org/apache/pekko/cluster/SeedNodeProcess.scala:
##
@@ -57,8 +57,10 @@ private[cluster] abstract class
SeedNodeProcess(joinConfigCompatChecker: JoinCon
val cfg = context.system.settings.config
if (cfg.hasPath("akka.version")) {
cfg.getString("akka.version")
-} else {
+} else if (cfg.hasPath("pekko.cluster.akka.version")) {
cfg.getString("pekko.cluster.akka.version")
+} else {
+ "2.6.21"
Review Comment:
actually - I think this could be worse than I thought
This is in our main pekko-remote reference.conf. I don't think this should
be in the reference.conf - fine for tests but not set up as our actual default.
I think users should enable it in their confs.
```
# When receiving requests from other remote actors, what are the valid
# prefix's to check against. Useful for when dealing with rolling cluster
# migrations with compatible systems such as Lightbend's Akka.
accept-protocol-names = ["pekko", "akka"]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] add default for pekko.cluster.akka.version [incubator-pekko]
mdedetrich commented on code in PR #1112:
URL: https://github.com/apache/incubator-pekko/pull/1112#discussion_r1485067542
##
cluster/src/main/scala/org/apache/pekko/cluster/SeedNodeProcess.scala:
##
@@ -57,8 +57,10 @@ private[cluster] abstract class
SeedNodeProcess(joinConfigCompatChecker: JoinCon
val cfg = context.system.settings.config
if (cfg.hasPath("akka.version")) {
cfg.getString("akka.version")
-} else {
+} else if (cfg.hasPath("pekko.cluster.akka.version")) {
cfg.getString("pekko.cluster.akka.version")
+} else {
+ "2.6.21"
Review Comment:
I guess fundamentally to me it just feels weird that we have a hardcoded
akka constant version in the source code considering that the general premise
behind all of these "pekko spoofing itself so it looks like akka" values are
configurable via typesafe config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] add default for pekko.cluster.akka.version [incubator-pekko]
mdedetrich commented on code in PR #1112:
URL: https://github.com/apache/incubator-pekko/pull/1112#discussion_r1485067542
##
cluster/src/main/scala/org/apache/pekko/cluster/SeedNodeProcess.scala:
##
@@ -57,8 +57,10 @@ private[cluster] abstract class
SeedNodeProcess(joinConfigCompatChecker: JoinCon
val cfg = context.system.settings.config
if (cfg.hasPath("akka.version")) {
cfg.getString("akka.version")
-} else {
+} else if (cfg.hasPath("pekko.cluster.akka.version")) {
cfg.getString("pekko.cluster.akka.version")
+} else {
+ "2.6.21"
Review Comment:
I guess fundamentally to me it just feels weird that we have a hardcoded
akka constant version in the source code considering that the general premise
behind all of these "pekko spoofing itself so it looks like akka" values are
configurable via typesafe config.
It may also be a stretch but I guess someone could come up with some
convoluted scenarios where they don't want the 2.6.21 but something else (tbh I
am not that familiar with this code path so ignore it if its a stupid concern).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] add default for pekko.cluster.akka.version [incubator-pekko]
mdedetrich commented on code in PR #1112:
URL: https://github.com/apache/incubator-pekko/pull/1112#discussion_r1485068520
##
cluster/src/main/scala/org/apache/pekko/cluster/SeedNodeProcess.scala:
##
@@ -57,8 +57,10 @@ private[cluster] abstract class
SeedNodeProcess(joinConfigCompatChecker: JoinCon
val cfg = context.system.settings.config
if (cfg.hasPath("akka.version")) {
cfg.getString("akka.version")
-} else {
+} else if (cfg.hasPath("pekko.cluster.akka.version")) {
cfg.getString("pekko.cluster.akka.version")
+} else {
+ "2.6.21"
Review Comment:
> This is in our main pekko-remote reference.conf. I don't think this should
be in the reference.conf - fine for tests but not set up as our actual default.
I think users should enable it in their confs.
>
> ```
> # When receiving requests from other remote actors, what are the valid
> # prefix's to check against. Useful for when dealing with rolling
cluster
> # migrations with compatible systems such as Lightbend's Akka.
> accept-protocol-names = ["pekko", "akka"]
> ```
Whats the problem with having this as a default, seems sensible to me or am
I missing something wild?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] add default for pekko.cluster.akka.version [incubator-pekko]
mdedetrich commented on code in PR #1112:
URL: https://github.com/apache/incubator-pekko/pull/1112#discussion_r1485068520
##
cluster/src/main/scala/org/apache/pekko/cluster/SeedNodeProcess.scala:
##
@@ -57,8 +57,10 @@ private[cluster] abstract class
SeedNodeProcess(joinConfigCompatChecker: JoinCon
val cfg = context.system.settings.config
if (cfg.hasPath("akka.version")) {
cfg.getString("akka.version")
-} else {
+} else if (cfg.hasPath("pekko.cluster.akka.version")) {
cfg.getString("pekko.cluster.akka.version")
+} else {
+ "2.6.21"
Review Comment:
> This is in our main pekko-remote reference.conf. I don't think this should
be in the reference.conf - fine for tests but not set up as our actual default.
I think users should enable it in their confs.
>
> ```
> # When receiving requests from other remote actors, what are the valid
> # prefix's to check against. Useful for when dealing with rolling
cluster
> # migrations with compatible systems such as Lightbend's Akka.
> accept-protocol-names = ["pekko", "akka"]
> ```
Whats the problem with having this as a default, seems sensible to me or am
I missing something wild? Or are you suggesting just having
`accept-protocol-names = ["pekko"]` (which is something I can get behind) but
it still doesn't solve the akka version string issue which is a bit of a gotcha
(at minimum it should be documented).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] add default for pekko.cluster.akka.version [incubator-pekko]
mdedetrich commented on code in PR #1112:
URL: https://github.com/apache/incubator-pekko/pull/1112#discussion_r1485068520
##
cluster/src/main/scala/org/apache/pekko/cluster/SeedNodeProcess.scala:
##
@@ -57,8 +57,10 @@ private[cluster] abstract class
SeedNodeProcess(joinConfigCompatChecker: JoinCon
val cfg = context.system.settings.config
if (cfg.hasPath("akka.version")) {
cfg.getString("akka.version")
-} else {
+} else if (cfg.hasPath("pekko.cluster.akka.version")) {
cfg.getString("pekko.cluster.akka.version")
+} else {
+ "2.6.21"
Review Comment:
> This is in our main pekko-remote reference.conf. I don't think this should
be in the reference.conf - fine for tests but not set up as our actual default.
I think users should enable it in their confs.
>
> ```
> # When receiving requests from other remote actors, what are the valid
> # prefix's to check against. Useful for when dealing with rolling
cluster
> # migrations with compatible systems such as Lightbend's Akka.
> accept-protocol-names = ["pekko", "akka"]
> ```
Whats the problem with having this as a default, seems sensible to me or am
I missing something wild? Or are you suggesting just having
`accept-protocol-names = ["pekko"]` (which is something I can get behind)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] add default for pekko.cluster.akka.version [incubator-pekko]
pjfanning commented on code in PR #1112:
URL: https://github.com/apache/incubator-pekko/pull/1112#discussion_r1485069325
##
cluster/src/main/scala/org/apache/pekko/cluster/SeedNodeProcess.scala:
##
@@ -57,8 +57,10 @@ private[cluster] abstract class
SeedNodeProcess(joinConfigCompatChecker: JoinCon
val cfg = context.system.settings.config
if (cfg.hasPath("akka.version")) {
cfg.getString("akka.version")
-} else {
+} else if (cfg.hasPath("pekko.cluster.akka.version")) {
cfg.getString("pekko.cluster.akka.version")
+} else {
+ "2.6.21"
Review Comment:
@mdedetrich I might be able to remove this PR if we can agree to change
pekko-remote main reference.conf to
```
# When receiving requests from other remote actors, what are the valid
# prefixes to check against. Useful for when dealing with rolling cluster
# migrations with compatible systems such as Lightbend's Akka.
# By default, we only support "pekko" protocol. If you want to also
support Akka, change this config to:
# pekko.remote.accept-protocol-names = ["pekko", "akka"]
accept-protocol-names = ["pekko"]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] add default for pekko.cluster.akka.version [incubator-pekko]
pjfanning commented on code in PR #1112:
URL: https://github.com/apache/incubator-pekko/pull/1112#discussion_r1485069325
##
cluster/src/main/scala/org/apache/pekko/cluster/SeedNodeProcess.scala:
##
@@ -57,8 +57,10 @@ private[cluster] abstract class
SeedNodeProcess(joinConfigCompatChecker: JoinCon
val cfg = context.system.settings.config
if (cfg.hasPath("akka.version")) {
cfg.getString("akka.version")
-} else {
+} else if (cfg.hasPath("pekko.cluster.akka.version")) {
cfg.getString("pekko.cluster.akka.version")
+} else {
+ "2.6.21"
Review Comment:
@mdedetrich I might be able to remove this PR if we can agree to change
pekko-remote main reference.conf to
```
# When receiving requests from other remote actors, what are the valid
# prefixes to check against. Useful for when dealing with rolling cluster
# migrations with compatible systems such as Lightbend's Akka.
# By default, we only support "pekko" protocol.
# If you want to also support Akka, change this config to:
# pekko.remote.accept-protocol-names = ["pekko", "akka"]
accept-protocol-names = ["pekko"]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] add default for pekko.cluster.akka.version [incubator-pekko]
pjfanning commented on code in PR #1112:
URL: https://github.com/apache/incubator-pekko/pull/1112#discussion_r1485070192
##
cluster/src/main/scala/org/apache/pekko/cluster/SeedNodeProcess.scala:
##
@@ -57,8 +57,10 @@ private[cluster] abstract class
SeedNodeProcess(joinConfigCompatChecker: JoinCon
val cfg = context.system.settings.config
if (cfg.hasPath("akka.version")) {
cfg.getString("akka.version")
-} else {
+} else if (cfg.hasPath("pekko.cluster.akka.version")) {
cfg.getString("pekko.cluster.akka.version")
+} else {
+ "2.6.21"
Review Comment:
> > This is in our main pekko-remote reference.conf. I don't think this
should be in the reference.conf - fine for tests but not set up as our actual
default. I think users should enable it in their confs.
> > ```
> > # When receiving requests from other remote actors, what are the
valid
> > # prefix's to check against. Useful for when dealing with rolling
cluster
> > # migrations with compatible systems such as Lightbend's Akka.
> > accept-protocol-names = ["pekko", "akka"]
> > ```
>
> Whats the problem with having this as a default, seems sensible to me or
am I missing something wild? Or are you suggesting just having
`accept-protocol-names = ["pekko"]` (which is something I can get behind) but
it still doesn't solve the akka version string issue which is a bit of a gotcha
(at minimum it should be documented).
The problem is performance for one. When you allow Akka, you get all the new
logic that I enabled to change the compat messages to include `akka` data as
well as `pekko` data. This is not free.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] add default for pekko.cluster.akka.version [incubator-pekko]
mdedetrich commented on code in PR #1112:
URL: https://github.com/apache/incubator-pekko/pull/1112#discussion_r1485071016
##
cluster/src/main/scala/org/apache/pekko/cluster/SeedNodeProcess.scala:
##
@@ -57,8 +57,10 @@ private[cluster] abstract class
SeedNodeProcess(joinConfigCompatChecker: JoinCon
val cfg = context.system.settings.config
if (cfg.hasPath("akka.version")) {
cfg.getString("akka.version")
-} else {
+} else if (cfg.hasPath("pekko.cluster.akka.version")) {
cfg.getString("pekko.cluster.akka.version")
+} else {
+ "2.6.21"
Review Comment:
> @mdedetrich I might be able to remove this PR if we can agree to change
pekko-remote main reference.conf to
>
> ```
> # When receiving requests from other remote actors, what are the valid
> # prefixes to check against. Useful for when dealing with rolling
cluster
> # migrations with compatible systems such as Lightbend's Akka.
> # By default, we only support "pekko" protocol.
> # If you want to also support Akka, change this config to:
> # pekko.remote.accept-protocol-names = ["pekko", "akka"]
> accept-protocol-names = ["pekko"]
> ```
Thats fine with me, but if we document that you need to change it to
`accept-protocol-names = ["akka", "pekko"]` for the migration scenario we then
hit the akka version gotcha, so what should we do there? Should we still add a
default for `pekko.cluster.akka.version` even if its only going to be used in
the migration scenario?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] add default for pekko.cluster.akka.version [incubator-pekko]
pjfanning commented on code in PR #1112:
URL: https://github.com/apache/incubator-pekko/pull/1112#discussion_r1485071664
##
cluster/src/main/scala/org/apache/pekko/cluster/SeedNodeProcess.scala:
##
@@ -57,8 +57,10 @@ private[cluster] abstract class
SeedNodeProcess(joinConfigCompatChecker: JoinCon
val cfg = context.system.settings.config
if (cfg.hasPath("akka.version")) {
cfg.getString("akka.version")
-} else {
+} else if (cfg.hasPath("pekko.cluster.akka.version")) {
cfg.getString("pekko.cluster.akka.version")
+} else {
+ "2.6.21"
Review Comment:
Sure - I can add `pekko.cluster.akka.version` to the pekko-remote
reference.conf, instead of hardcoding the default in the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] [DRAFT] add default for pekko.remote.akka.version [incubator-pekko]
mdedetrich commented on PR #1112: URL: https://github.com/apache/incubator-pekko/pull/1112#issuecomment-1936988304 Looks much better now, let me know when PR is out of draft and ill review it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] [DRAFT] add default for pekko.remote.akka.version [incubator-pekko]
mdedetrich commented on code in PR #1112:
URL: https://github.com/apache/incubator-pekko/pull/1112#discussion_r1485091228
##
remote/src/main/resources/reference.conf:
##
@@ -198,6 +201,12 @@ pekko {
# nodes have been are running on Apache Pekko
protocol-name = "pekko"
+# When pekko.remote.accept-protocol-names contains "akka", then we
+# need to know the Akka version. If you include the Akka jars on the
classpath,
+# we can use the akka.version from their configuration. This configuration
+# setting is only used if we can't find an akka.version setting.
+akka.version = "2.6.21"
Review Comment:
This might be over-engineering way too much but considering you could put
any string values into `accept-protocol-names` it might make sense for this
configuration to be an object i.e.
```
version {
akka = "2.6.21"
}
```
where the key (in this case `akka`) is pointing to the the same value inside
of ` accept-protocol-names`.
Otherwise we should do some sanity validation on `accept-protocol-names` and
refuse any values that aren't `akka` or `pekko`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] [DRAFT] add default for pekko.remote.akka.version [incubator-pekko]
mdedetrich commented on code in PR #1112:
URL: https://github.com/apache/incubator-pekko/pull/1112#discussion_r1485091228
##
remote/src/main/resources/reference.conf:
##
@@ -198,6 +201,12 @@ pekko {
# nodes have been are running on Apache Pekko
protocol-name = "pekko"
+# When pekko.remote.accept-protocol-names contains "akka", then we
+# need to know the Akka version. If you include the Akka jars on the
classpath,
+# we can use the akka.version from their configuration. This configuration
+# setting is only used if we can't find an akka.version setting.
+akka.version = "2.6.21"
Review Comment:
This might be over-engineering way too much but considering you could put
any string values into `accept-protocol-names` it might make sense for this
configuration to be an object i.e.
```
version {
akka = "2.6.21"
}
```
where the key (in this case `akka`) is pointing to the the same value inside
of `accept-protocol-names`.
Otherwise we should do some sanity validation on `accept-protocol-names` and
refuse any values that aren't `akka` or `pekko`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] chore: fix typo: ContentNegotation -> ContentNegotiation [incubator-pekko-http]
raboof merged PR #477: URL: https://github.com/apache/incubator-pekko-http/pull/477 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] Remove publish-1.0 workflow [incubator-pekko]
raboof merged PR #1110: URL: https://github.com/apache/incubator-pekko/pull/1110 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [I] reproducible builds: scala 3 tasty differences in pekko-http-core `HttpEntity.tasty` [incubator-pekko-http]
raboof commented on issue #476: URL: https://github.com/apache/incubator-pekko-http/issues/476#issuecomment-1937004222 Some findings: * I'm still seeing this behavior with Scala 3.4.1-RC1-bin-20240208-7bcfce2-NIGHTLY * It seems to sometimes think (some code related to) `ResponseEntity` is defined in `ParserOutput` for some reason? * I haven't caught it to see what it thinks is defined in `HttpMessage.scala` - but if that's about `ResponseEntity` as well, that'd also be wrong, as `ResponseEntity` is defined in `HttpEntity.scala`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] [DRAFT] add default for pekko.remote.akka.version [incubator-pekko]
pjfanning commented on code in PR #1112:
URL: https://github.com/apache/incubator-pekko/pull/1112#discussion_r1485105165
##
remote/src/main/resources/reference.conf:
##
@@ -198,6 +201,12 @@ pekko {
# nodes have been are running on Apache Pekko
protocol-name = "pekko"
+# When pekko.remote.accept-protocol-names contains "akka", then we
+# need to know the Akka version. If you include the Akka jars on the
classpath,
+# we can use the akka.version from their configuration. This configuration
+# setting is only used if we can't find an akka.version setting.
+akka.version = "2.6.21"
Review Comment:
I think this is overengineering. The new code I added is very Akka specific
(#765). It only kicks if you include "akka" in `accept-protocol-names` (again
hardcoded). In the real world, I do not know of anyone else who would need to
add a non-Pekko node to a Pekko cluster. If that story ever comes to pass, I
will volunteer to help those users to get the cluster compatibility checks to
work with their nodes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [I] 1.0.x branch has an empty `publish-1.0-nightly` workflow [incubator-pekko]
pjfanning commented on issue #1109: URL: https://github.com/apache/incubator-pekko/issues/1109#issuecomment-1937051537 Fix merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [I] 1.0.x branch has an empty `publish-1.0-nightly` workflow [incubator-pekko]
pjfanning closed issue #1109: 1.0.x branch has an empty `publish-1.0-nightly` workflow URL: https://github.com/apache/incubator-pekko/issues/1109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] [DRAFT] add default for pekko.remote.akka.version [incubator-pekko]
mdedetrich commented on code in PR #1112:
URL: https://github.com/apache/incubator-pekko/pull/1112#discussion_r1485289916
##
remote/src/main/resources/reference.conf:
##
@@ -198,6 +201,12 @@ pekko {
# nodes have been are running on Apache Pekko
protocol-name = "pekko"
+# When pekko.remote.accept-protocol-names contains "akka", then we
+# need to know the Akka version. If you include the Akka jars on the
classpath,
+# we can use the akka.version from their configuration. This configuration
+# setting is only used if we can't find an akka.version setting.
+akka.version = "2.6.21"
Review Comment:
Can we then just add a validation check to the config parsing so that only
`akka` and `pekko` can be put in as values (can also be separate PR)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
[PR] Update commons-codec to 1.16.1 [incubator-pekko]
scala-steward-asf[bot] opened a new pull request, #1113:
URL: https://github.com/apache/incubator-pekko/pull/1113
## About this PR
📦 Updates
[commons-codec:commons-codec](https://github.com/apache/commons-codec) from
`1.16.0` to `1.16.1`
## Usage
✅ **Please merge!**
I'll automatically update this PR to resolve conflicts as long as you don't
change it yourself.
If you'd like to skip this version, you can just close this PR. If you have
any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
[`.scala-steward.conf`](https://github.com/scala-steward-org/scala-steward/blob/33d3ad7d5245cbd05d7004d5502f6f7333833843/docs/repo-specific-configuration.md)
file.
_Have a fantastic day writing Scala!_
âš™ Adjust future updates
Add this to your `.scala-steward.conf` file to ignore future updates of this
dependency:
```
updates.ignore = [ { groupId = "commons-codec", artifactId = "commons-codec"
} ]
```
Or, add this to slow down future updates of this dependency:
```
dependencyOverrides = [{
pullRequests = { frequency = "30 days" },
dependency = { groupId = "commons-codec", artifactId = "commons-codec" }
}]
```
labels: test-library-update, early-semver-patch, semver-spec-patch,
commit-count:1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
[PR] Update jctools-core to 4.0.3 [incubator-pekko]
scala-steward-asf[bot] opened a new pull request, #1114:
URL: https://github.com/apache/incubator-pekko/pull/1114
## About this PR
📦 Updates [org.jctools:jctools-core](https://github.com/JCTools/JCTools)
from `4.0.2` to `4.0.3`
📜 [GitHub Release
Notes](https://github.com/JCTools/JCTools/releases/tag/v4.0.3) - [Version
Diff](https://github.com/JCTools/JCTools/compare/v4.0.2...v4.0.3)
## Usage
✅ **Please merge!**
I'll automatically update this PR to resolve conflicts as long as you don't
change it yourself.
If you'd like to skip this version, you can just close this PR. If you have
any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
[`.scala-steward.conf`](https://github.com/scala-steward-org/scala-steward/blob/33d3ad7d5245cbd05d7004d5502f6f7333833843/docs/repo-specific-configuration.md)
file.
_Have a fantastic day writing Scala!_
âš™ Adjust future updates
Add this to your `.scala-steward.conf` file to ignore future updates of this
dependency:
```
updates.ignore = [ { groupId = "org.jctools", artifactId = "jctools-core" } ]
```
Or, add this to slow down future updates of this dependency:
```
dependencyOverrides = [{
pullRequests = { frequency = "30 days" },
dependency = { groupId = "org.jctools", artifactId = "jctools-core" }
}]
```
labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
[PR] Update junit-jupiter-engine to 5.10.2 [incubator-pekko]
scala-steward-asf[bot] opened a new pull request, #1115:
URL: https://github.com/apache/incubator-pekko/pull/1115
## About this PR
📦 Updates
[org.junit.jupiter:junit-jupiter-engine](https://github.com/junit-team/junit5)
from `5.10.1` to `5.10.2`
## Usage
✅ **Please merge!**
I'll automatically update this PR to resolve conflicts as long as you don't
change it yourself.
If you'd like to skip this version, you can just close this PR. If you have
any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
[`.scala-steward.conf`](https://github.com/scala-steward-org/scala-steward/blob/33d3ad7d5245cbd05d7004d5502f6f7333833843/docs/repo-specific-configuration.md)
file.
_Have a fantastic day writing Scala!_
âš™ Adjust future updates
Add this to your `.scala-steward.conf` file to ignore future updates of this
dependency:
```
updates.ignore = [ { groupId = "org.junit.jupiter", artifactId =
"junit-jupiter-engine" } ]
```
Or, add this to slow down future updates of this dependency:
```
dependencyOverrides = [{
pullRequests = { frequency = "30 days" },
dependency = { groupId = "org.junit.jupiter", artifactId =
"junit-jupiter-engine" }
}]
```
labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
[PR] Update scalatest to 3.2.18 [incubator-pekko]
scala-steward-asf[bot] opened a new pull request, #1116:
URL: https://github.com/apache/incubator-pekko/pull/1116
## About this PR
📦 Updates [org.scalatest:scalatest](https://github.com/scalatest/scalatest)
from `3.2.17` to `3.2.18`
📜 [GitHub Release
Notes](https://github.com/scalatest/scalatest/releases/tag/release-3.2.18) -
[Version
Diff](https://github.com/scalatest/scalatest/compare/release-3.2.17...release-3.2.18)
## Usage
✅ **Please merge!**
I'll automatically update this PR to resolve conflicts as long as you don't
change it yourself.
If you'd like to skip this version, you can just close this PR. If you have
any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
[`.scala-steward.conf`](https://github.com/scala-steward-org/scala-steward/blob/33d3ad7d5245cbd05d7004d5502f6f7333833843/docs/repo-specific-configuration.md)
file.
_Have a fantastic day writing Scala!_
âš™ Adjust future updates
Add this to your `.scala-steward.conf` file to ignore future updates of this
dependency:
```
updates.ignore = [ { groupId = "org.scalatest", artifactId = "scalatest" } ]
```
Or, add this to slow down future updates of this dependency:
```
dependencyOverrides = [{
pullRequests = { frequency = "30 days" },
dependency = { groupId = "org.scalatest", artifactId = "scalatest" }
}]
```
labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
[PR] Update jul-to-slf4j, log4j-over-slf4j, ... to 2.0.12 [incubator-pekko]
scala-steward-asf[bot] opened a new pull request, #1117:
URL: https://github.com/apache/incubator-pekko/pull/1117
## About this PR
📦 Updates
* org.slf4j:jul-to-slf4j
* org.slf4j:log4j-over-slf4j
* org.slf4j:slf4j-api
from `2.0.11` to `2.0.12`
## Usage
✅ **Please merge!**
I'll automatically update this PR to resolve conflicts as long as you don't
change it yourself.
If you'd like to skip this version, you can just close this PR. If you have
any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
[`.scala-steward.conf`](https://github.com/scala-steward-org/scala-steward/blob/33d3ad7d5245cbd05d7004d5502f6f7333833843/docs/repo-specific-configuration.md)
file.
_Have a fantastic day writing Scala!_
âš™ Adjust future updates
Add this to your `.scala-steward.conf` file to ignore future updates of this
dependency:
```
updates.ignore = [ { groupId = "org.slf4j" } ]
```
Or, add this to slow down future updates of this dependency:
```
dependencyOverrides = [{
pullRequests = { frequency = "30 days" },
dependency = { groupId = "org.slf4j" }
}]
```
labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
[PR] Update scalatest to 3.2.18 [incubator-pekko-http]
scala-steward-asf[bot] opened a new pull request, #480:
URL: https://github.com/apache/incubator-pekko-http/pull/480
## About this PR
📦 Updates [org.scalatest:scalatest](https://github.com/scalatest/scalatest)
from `3.2.17` to `3.2.18`
📜 [GitHub Release
Notes](https://github.com/scalatest/scalatest/releases/tag/release-3.2.18) -
[Version
Diff](https://github.com/scalatest/scalatest/compare/release-3.2.17...release-3.2.18)
## Usage
✅ **Please merge!**
I'll automatically update this PR to resolve conflicts as long as you don't
change it yourself.
If you'd like to skip this version, you can just close this PR. If you have
any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
[`.scala-steward.conf`](https://github.com/scala-steward-org/scala-steward/blob/33d3ad7d5245cbd05d7004d5502f6f7333833843/docs/repo-specific-configuration.md)
file.
_Have a fantastic day writing Scala!_
âš™ Adjust future updates
Add this to your `.scala-steward.conf` file to ignore future updates of this
dependency:
```
updates.ignore = [ { groupId = "org.scalatest", artifactId = "scalatest" } ]
```
Or, add this to slow down future updates of this dependency:
```
dependencyOverrides = [{
pullRequests = { frequency = "30 days" },
dependency = { groupId = "org.scalatest", artifactId = "scalatest" }
}]
```
labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
[PR] Update java-client to 3.5.3 [incubator-pekko-connectors]
scala-steward-asf[bot] opened a new pull request, #470:
URL: https://github.com/apache/incubator-pekko-connectors/pull/470
## About this PR
📦 Updates
[com.couchbase.client:java-client](https://github.com/couchbase/couchbase-jvm-clients)
from `2.7.23` to `3.5.3` âš
## Usage
✅ **Please merge!**
I'll automatically update this PR to resolve conflicts as long as you don't
change it yourself.
If you'd like to skip this version, you can just close this PR. If you have
any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
[`.scala-steward.conf`](https://github.com/scala-steward-org/scala-steward/blob/33d3ad7d5245cbd05d7004d5502f6f7333833843/docs/repo-specific-configuration.md)
file.
_Have a fantastic day writing Scala!_
âš™ Adjust future updates
Add this to your `.scala-steward.conf` file to ignore future updates of this
dependency:
```
updates.ignore = [ { groupId = "com.couchbase.client", artifactId =
"java-client" } ]
```
Or, add this to slow down future updates of this dependency:
```
dependencyOverrides = [{
pullRequests = { frequency = "30 days" },
dependency = { groupId = "com.couchbase.client", artifactId =
"java-client" }
}]
```
labels: library-update, early-semver-major, semver-spec-major, commit-count:1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
[PR] Update proto-google-cloud-bigquerystorage-v1 to 2.47.0 [incubator-pekko-connectors]
scala-steward-asf[bot] opened a new pull request, #471:
URL: https://github.com/apache/incubator-pekko-connectors/pull/471
## About this PR
📦 Updates
[com.google.api.grpc:proto-google-cloud-bigquerystorage-v1](https://github.com/googleapis/java-bigquerystorage)
from `2.36.1` to `2.47.0`
📜 [GitHub Release
Notes](https://github.com/googleapis/java-bigquerystorage/releases/tag/v2.47.0)
- [Version
Diff](https://github.com/googleapis/java-bigquerystorage/compare/v2.36.1...v2.47.0)
## Usage
✅ **Please merge!**
I'll automatically update this PR to resolve conflicts as long as you don't
change it yourself.
If you'd like to skip this version, you can just close this PR. If you have
any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
[`.scala-steward.conf`](https://github.com/scala-steward-org/scala-steward/blob/33d3ad7d5245cbd05d7004d5502f6f7333833843/docs/repo-specific-configuration.md)
file.
_Have a fantastic day writing Scala!_
âš™ Adjust future updates
Add this to your `.scala-steward.conf` file to ignore future updates of this
dependency:
```
updates.ignore = [ { groupId = "com.google.api.grpc", artifactId =
"proto-google-cloud-bigquerystorage-v1" } ]
```
Or, add this to slow down future updates of this dependency:
```
dependencyOverrides = [{
pullRequests = { frequency = "30 days" },
dependency = { groupId = "com.google.api.grpc", artifactId =
"proto-google-cloud-bigquerystorage-v1" }
}]
```
labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
[PR] Update google-auth-library-credentials, ... to 1.23.0 [incubator-pekko-connectors]
scala-steward-asf[bot] opened a new pull request, #472:
URL: https://github.com/apache/incubator-pekko-connectors/pull/472
## About this PR
📦 Updates
*
[com.google.auth:google-auth-library-credentials](https://github.com/googleapis/google-auth-library-java)
*
[com.google.auth:google-auth-library-oauth2-http](https://github.com/googleapis/google-auth-library-java)
from `1.22.0` to `1.23.0`
📜 [GitHub Release
Notes](https://github.com/googleapis/google-auth-library-java/releases/tag/v1.23.0)
- [Version
Diff](https://github.com/googleapis/google-auth-library-java/compare/v1.22.0...v1.23.0)
## Usage
✅ **Please merge!**
I'll automatically update this PR to resolve conflicts as long as you don't
change it yourself.
If you'd like to skip this version, you can just close this PR. If you have
any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
[`.scala-steward.conf`](https://github.com/scala-steward-org/scala-steward/blob/33d3ad7d5245cbd05d7004d5502f6f7333833843/docs/repo-specific-configuration.md)
file.
_Have a fantastic day writing Scala!_
âš™ Adjust future updates
Add this to your `.scala-steward.conf` file to ignore future updates of this
dependency:
```
updates.ignore = [ { groupId = "com.google.auth" } ]
```
Or, add this to slow down future updates of this dependency:
```
dependencyOverrides = [{
pullRequests = { frequency = "30 days" },
dependency = { groupId = "com.google.auth" }
}]
```
labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
