mdedetrich commented on code in PR #1112: URL: https://github.com/apache/incubator-pekko/pull/1112#discussion_r1485289916
########## remote/src/main/resources/reference.conf: ########## @@ -198,6 +201,12 @@ pekko { # nodes have been are running on Apache Pekko protocol-name = "pekko" + # When pekko.remote.accept-protocol-names contains "akka", then we + # need to know the Akka version. If you include the Akka jars on the classpath, + # we can use the akka.version from their configuration. This configuration + # setting is only used if we can't find an akka.version setting. + akka.version = "2.6.21" Review Comment: Can we then just add a validation check to the config parsing so that only `akka` and `pekko` can be put in as values (can also be separate PR)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org