mdedetrich commented on code in PR #1112:
URL: https://github.com/apache/incubator-pekko/pull/1112#discussion_r1485071016
##########
cluster/src/main/scala/org/apache/pekko/cluster/SeedNodeProcess.scala:
##########
@@ -57,8 +57,10 @@ private[cluster] abstract class
SeedNodeProcess(joinConfigCompatChecker: JoinCon
val cfg = context.system.settings.config
if (cfg.hasPath("akka.version")) {
cfg.getString("akka.version")
- } else {
+ } else if (cfg.hasPath("pekko.cluster.akka.version")) {
cfg.getString("pekko.cluster.akka.version")
+ } else {
+ "2.6.21"
Review Comment:
> @mdedetrich I might be able to remove this PR if we can agree to change
pekko-remote main reference.conf to
>
> ```
> # When receiving requests from other remote actors, what are the valid
> # prefixes to check against. Useful for when dealing with rolling
cluster
> # migrations with compatible systems such as Lightbend's Akka.
> # By default, we only support "pekko" protocol.
> # If you want to also support Akka, change this config to:
> # pekko.remote.accept-protocol-names = ["pekko", "akka"]
> accept-protocol-names = ["pekko"]
> ```
Thats fine with me, but if we document that you need to change it to
`accept-protocol-names = ["akka", "pekko"]` for the migration scenario we then
hit the akka version gotcha, so what should we do there? Should we still add a
default for `pekko.cluster.akka.version` even if its only going to be used in
the migration scenario?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
