pjfanning commented on code in PR #1112:
URL: https://github.com/apache/incubator-pekko/pull/1112#discussion_r1485070192
##########
cluster/src/main/scala/org/apache/pekko/cluster/SeedNodeProcess.scala:
##########
@@ -57,8 +57,10 @@ private[cluster] abstract class
SeedNodeProcess(joinConfigCompatChecker: JoinCon
val cfg = context.system.settings.config
if (cfg.hasPath("akka.version")) {
cfg.getString("akka.version")
- } else {
+ } else if (cfg.hasPath("pekko.cluster.akka.version")) {
cfg.getString("pekko.cluster.akka.version")
+ } else {
+ "2.6.21"
Review Comment:
> > This is in our main pekko-remote reference.conf. I don't think this
should be in the reference.conf - fine for tests but not set up as our actual
default. I think users should enable it in their confs.
> > ```
> > # When receiving requests from other remote actors, what are the
valid
> > # prefix's to check against. Useful for when dealing with rolling
cluster
> > # migrations with compatible systems such as Lightbend's Akka.
> > accept-protocol-names = ["pekko", "akka"]
> > ```
>
> Whats the problem with having this as a default, seems sensible to me or
am I missing something wild? Or are you suggesting just having
`accept-protocol-names = ["pekko"]` (which is something I can get behind) but
it still doesn't solve the akka version string issue which is a bit of a gotcha
(at minimum it should be documented).
The problem is performance for one. When you allow Akka, you get all the new
logic that I enabled to change the compat messages to include `akka` data as
well as `pekko` data. This is not free.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
