mdedetrich commented on code in PR #1112:
URL: https://github.com/apache/incubator-pekko/pull/1112#discussion_r1485067542
##########
cluster/src/main/scala/org/apache/pekko/cluster/SeedNodeProcess.scala:
##########
@@ -57,8 +57,10 @@ private[cluster] abstract class
SeedNodeProcess(joinConfigCompatChecker: JoinCon
val cfg = context.system.settings.config
if (cfg.hasPath("akka.version")) {
cfg.getString("akka.version")
- } else {
+ } else if (cfg.hasPath("pekko.cluster.akka.version")) {
cfg.getString("pekko.cluster.akka.version")
+ } else {
+ "2.6.21"
Review Comment:
I guess fundamentally to me it just feels weird that we have a hardcoded
akka constant version in the source code considering that the general premise
behind all of these "pekko spoofing itself so it looks like akka" values are
configurable via typesafe config.
It may also be a stretch but I guess someone could come up with some
convoluted scenarios where they don't want the 2.6.21 but something else (tbh I
am not that familiar with this code path so ignore it if its a stupid concern).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
