raboof commented on PR #105: URL: https://github.com/apache/incubator-pekko-projection/pull/105#issuecomment-1935811477
> > TBH I'm not convinced this change fixes the root cause of the instability: because of the assertion `records.count(_.partition() == tp0.partition()) shouldBe 5` AFAICS it should be guaranteed that `tp0TestCount` would always be 5, so this change should not have an effect other than timing differences - or did I miss something? > > The producer produces a total of 20 elements, and each partition has 10 evenly. > > Then Sink consumes 10 elements from two partitions. There is no assertion that each partition consumes 5 evenly. Isn't that asserted by https://github.com/apache/incubator-pekko-projection/pull/105/files#diff-fdbaabc373547fac2368cc881beaa945f8d0225553d3e964dbe09eaf792592adR108-R112 ? > If it is not consumed evenly, it will lead to problems with subsequent assertions, because partition 0 may consume 6 records in the previous step. > > This PR does not force the assertion that Sink consumes evenly from all partitions. If Kafka Consumer is not balanced consume from partitions, I don't think this is the responsibility of this test or should be added a new test to assert. That makes sense to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
