Re: [dpdk-dev] [PATCH] net/failsafe: fix source port ID in Rx packets
On Thu, Apr 18, 2019 at 04:06:31PM +0200, David Marchand wrote:
> Hey Adrien,
Hey David!
> On Thu, Apr 18, 2019 at 3:12 PM Adrien Mazarguil
> wrote:
>
> > When passed to the application, Rx packets retain the port ID value
> > originally set by slave devices. Unfortunately these IDs have no meaning to
> > applications, which are typically unaware of their existence.
> >
> > This confuses those caring about the source port field in mbufs (m->port)
> > which experience issues ranging from traffic drop to crashes.
> >
> > Fixes: a46f8d584eb8 ("net/failsafe: add fail-safe PMD")
> Not a big fan of those duplicated rx_burst functions...
> Reviewed-by: David Marchand
>
> I suppose the bonding pmd has the same issue.
I don't have much experience with it, however chances are that it's not as
bad as with failsafe since bonding behaves more like a helper that
applications knowingly use to aggregate ports they set up and already know
about. Leaving the original port ID in this case may actually be useful, but
could be optional.
Failsafe on the other hand spawns and manages any number of sub-devices
hidden from the application on its own based on opaque user configuration.
These sub-devices may or may not be present depending on hot-plug events
absorbed by failsafe, which means their port IDs are not only unexpected but
also volatile.
--
Adrien Mazarguil
6WIND
Re: [dpdk-dev] [PATCH] net/cxgbe: fix colliding function names
On 4/19/2019 12:37 AM, Stephen Hemminger wrote:
> This driver defines lots of functions (like init_rss) which are intended
> to only be used in this device. But when doing static linking these
> global functions cause link failures when similar function name is
> used in application.
>
> This patch prefixes all functions defined in cxgbe.h with cxgbe_
> to avoid these kind of conflicts.
+1, not static functions should have module prefix
>
> Fixes: bfcb257d3014 ("net/cxgbe: enable RSS for VF")
> Signed-off-by: Stephen Hemminger
Re: [dpdk-dev] [PATCH v2 1/1] test/compress: add max mbuf size test case
There are some variables declared in the middle of the function,
and one (i) is declared twice with two different types.
Tomasz and Tomasz, are you working on it urgently please?
19/04/2019 00:42, Yongseok Koh:
> Hi,
>
> I'm seeing compile error.
> Isn't it due to this patch?
>
> $ gcc --version
> gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28)
>
>
> FAILED: app/test/app@test@@dpdk-test@exe/test_compressdev.c.o
[...]
> ../app/test/test_compressdev.c: In function
> ‘test_compressdev_deflate_stateless_dynamic_big’:
> ../app/test/test_compressdev.c:1992:16: error: conflicting types for ‘i’
> for (uint32_t i = 0; i < BIG_DATA_TEST_SIZE - 1; ++i)
> ^
> ../app/test/test_compressdev.c:1949:11: note: previous definition of ‘i’ was
> here
> uint16_t i = 0;
>^
> ../app/test/test_compressdev.c:1992:2: error: ‘for’ loop initial declarations
> are only allowed in C99 mode
> for (uint32_t i = 0; i < BIG_DATA_TEST_SIZE - 1; ++i)
> ^
> ../app/test/test_compressdev.c:1992:2: note: use option -std=c99 or
> -std=gnu99 to compile your code
> ../app/test/test_compressdev.c:1996:19: warning: assignment from incompatible
> pointer type [enabled by default]
> int_data.buf_idx = &i;
>^
> [1501/1523] Generating igb_uio with a custom command.
> make: Entering directory `/usr/src/kernels/3.10.0-862.el7.x86_64'
> CC [M]
> /auto/mtiswgwork/yskoh/git/mellanox/dpdk.org-2/build/kernel/linux/igb_uio/igb_uio.o
> Building modules, stage 2.
> MODPOST 1 modules
> make[1]: Warning: File
> `/auto/mtiswgwork/yskoh/git/mellanox/dpdk.org-2/build/kernel/linux/igb_uio/igb_uio.mod.c'
> has modification time 0.0096 s in the future
> CC
> /auto/mtiswgwork/yskoh/git/mellanox/dpdk.org-2/build/kernel/linux/igb_uio/igb_uio.mod.o
> LD [M]
> /auto/mtiswgwork/yskoh/git/mellanox/dpdk.org-2/build/kernel/linux/igb_uio/igb_uio.ko
> make[1]: warning: Clock skew detected. Your build may be incomplete.
> make: Leaving directory `/usr/src/kernels/3.10.0-862.el7.x86_64'
>
>
> Thanks,
> Yongseok
[...]
> >> +static int
> >> +test_compressdev_deflate_stateless_dynamic_big(void)
> >> +{
> >> + struct comp_testsuite_params *ts_params = &testsuite_params;
> >> + uint16_t i = 0;
> >> + int ret = TEST_SUCCESS;
> >> + const struct rte_compressdev_capabilities *capab;
> >> + char *test_buffer = NULL;
> >> +
> >> + capab = rte_compressdev_capability_get(0,
> >> RTE_COMP_ALGO_DEFLATE);
> >> + TEST_ASSERT(capab != NULL, "Failed to retrieve device capabilities");
> >> +
> >> + if ((capab->comp_feature_flags &
> >> RTE_COMP_FF_HUFFMAN_DYNAMIC) == 0)
> >> + return -ENOTSUP;
> >> +
> >> + if ((capab->comp_feature_flags &
> >> RTE_COMP_FF_OOP_SGL_IN_SGL_OUT) == 0)
> >> + return -ENOTSUP;
> >> +
> >> + test_buffer = rte_malloc(NULL, BIG_DATA_TEST_SIZE, 0);
> >> + if (test_buffer == NULL) {
> >> + RTE_LOG(ERR, USER1,
> >> + "Can't allocate buffer for big-data\n");
> >> + return TEST_FAILED;
> >> + }
> >> +
> >> + struct interim_data_params int_data = {
> >> + (const char * const *)&test_buffer,
> >> + 1,
> >> + NULL,
> >> + &ts_params->def_comp_xform,
> >> + &ts_params->def_decomp_xform,
> >> + 1
> >> + };
> >> +
> >> + struct test_data_params test_data = {
> >> + RTE_COMP_OP_STATELESS,
> >> + SGL_BOTH,
> >> + ZLIB_DECOMPRESS,
> >> + 0,
> >> + 1
> >> + };
> >> +
> >> + ts_params->def_comp_xform->compress.deflate.huffman =
> >> +
> >>RTE_COMP_HUFFMAN_DYNAMIC;
> >> +
> >> + /* fill the buffer with data based on rand. data */
> >> + srand(BIG_DATA_TEST_SIZE);
> >> + for (uint32_t i = 0; i < BIG_DATA_TEST_SIZE - 1; ++i)
> >> + test_buffer[i] = (uint8_t)(rand() % ((uint8_t)-1)) | 1;
> >> +
> >> + test_buffer[BIG_DATA_TEST_SIZE-1] = 0;
> >> + int_data.buf_idx = &i;
Re: [dpdk-dev] [PATCH v2 1/1] test/compress: add max mbuf size test case
On Fri, Apr 19, 2019 at 11:08 AM Thomas Monjalon
wrote:
> There are some variables declared in the middle of the function,
> and one (i) is declared twice with two different types.
>
> Tomasz and Tomasz, are you working on it urgently please?
>
Found out that this test is not built by default.
I have a trivial fix but I wonder how this has been tested seeing how it
won't compile.
--
David Marchand
>
> 19/04/2019 00:42, Yongseok Koh:
> > Hi,
> >
> > I'm seeing compile error.
> > Isn't it due to this patch?
> >
> > $ gcc --version
> > gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28)
> >
> >
> > FAILED: app/test/app@test@@dpdk-test@exe/test_compressdev.c.o
> [...]
> > ../app/test/test_compressdev.c: In function
> ‘test_compressdev_deflate_stateless_dynamic_big’:
> > ../app/test/test_compressdev.c:1992:16: error: conflicting types for ‘i’
> > for (uint32_t i = 0; i < BIG_DATA_TEST_SIZE - 1; ++i)
> > ^
> > ../app/test/test_compressdev.c:1949:11: note: previous definition of ‘i’
> was here
> > uint16_t i = 0;
> >^
> > ../app/test/test_compressdev.c:1992:2: error: ‘for’ loop initial
> declarations are only allowed in C99 mode
> > for (uint32_t i = 0; i < BIG_DATA_TEST_SIZE - 1; ++i)
> > ^
> > ../app/test/test_compressdev.c:1992:2: note: use option -std=c99 or
> -std=gnu99 to compile your code
> > ../app/test/test_compressdev.c:1996:19: warning: assignment from
> incompatible pointer type [enabled by default]
> > int_data.buf_idx = &i;
> >^
> > [1501/1523] Generating igb_uio with a custom command.
> > make: Entering directory `/usr/src/kernels/3.10.0-862.el7.x86_64'
> > CC [M]
> /auto/mtiswgwork/yskoh/git/mellanox/dpdk.org-2/build/kernel/linux/igb_uio/igb_uio.o
> > Building modules, stage 2.
> > MODPOST 1 modules
> > make[1]: Warning: File
> `/auto/mtiswgwork/yskoh/git/mellanox/dpdk.org-2/build/kernel/linux/igb_uio/igb_uio.mod.c'
> has modification time 0.0096 s in the future
> > CC
> /auto/mtiswgwork/yskoh/git/mellanox/dpdk.org-2/build/kernel/linux/igb_uio/igb_uio.mod.o
> > LD [M]
> /auto/mtiswgwork/yskoh/git/mellanox/dpdk.org-2/build/kernel/linux/igb_uio/igb_uio.ko
> > make[1]: warning: Clock skew detected. Your build may be incomplete.
> > make: Leaving directory `/usr/src/kernels/3.10.0-862.el7.x86_64'
> >
> >
> > Thanks,
> > Yongseok
>
> [...]
> > >> +static int
> > >> +test_compressdev_deflate_stateless_dynamic_big(void)
> > >> +{
> > >> + struct comp_testsuite_params *ts_params = &testsuite_params;
> > >> + uint16_t i = 0;
> > >> + int ret = TEST_SUCCESS;
> > >> + const struct rte_compressdev_capabilities *capab;
> > >> + char *test_buffer = NULL;
> > >> +
> > >> + capab = rte_compressdev_capability_get(0,
> > >> RTE_COMP_ALGO_DEFLATE);
> > >> + TEST_ASSERT(capab != NULL, "Failed to retrieve device
> capabilities");
> > >> +
> > >> + if ((capab->comp_feature_flags &
> > >> RTE_COMP_FF_HUFFMAN_DYNAMIC) == 0)
> > >> + return -ENOTSUP;
> > >> +
> > >> + if ((capab->comp_feature_flags &
> > >> RTE_COMP_FF_OOP_SGL_IN_SGL_OUT) == 0)
> > >> + return -ENOTSUP;
> > >> +
> > >> + test_buffer = rte_malloc(NULL, BIG_DATA_TEST_SIZE, 0);
> > >> + if (test_buffer == NULL) {
> > >> + RTE_LOG(ERR, USER1,
> > >> + "Can't allocate buffer for big-data\n");
> > >> + return TEST_FAILED;
> > >> + }
> > >> +
> > >> + struct interim_data_params int_data = {
> > >> + (const char * const *)&test_buffer,
> > >> + 1,
> > >> + NULL,
> > >> + &ts_params->def_comp_xform,
> > >> + &ts_params->def_decomp_xform,
> > >> + 1
> > >> + };
> > >> +
> > >> + struct test_data_params test_data = {
> > >> + RTE_COMP_OP_STATELESS,
> > >> + SGL_BOTH,
> > >> + ZLIB_DECOMPRESS,
> > >> + 0,
> > >> + 1
> > >> + };
> > >> +
> > >> + ts_params->def_comp_xform->compress.deflate.huffman =
> > >> +
> > >>RTE_COMP_HUFFMAN_DYNAMIC;
> > >> +
> > >> + /* fill the buffer with data based on rand. data */
> > >> + srand(BIG_DATA_TEST_SIZE);
> > >> + for (uint32_t i = 0; i < BIG_DATA_TEST_SIZE - 1; ++i)
> > >> + test_buffer[i] = (uint8_t)(rand() % ((uint8_t)-1)) | 1;
> > >> +
> > >> + test_buffer[BIG_DATA_TEST_SIZE-1] = 0;
> > >> + int_data.buf_idx = &i;
>
>
>
>
[dpdk-dev] [PATCH] net/cxgbe: update Chelsio T5/T6 NIC device ids
Fixes: 04868e5bfddd ("net/cxgbe: add support to run Chelsio T6 cards")
Cc: sta...@dpdk.org
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/base/t4_pci_id_tbl.h | 52 +-
1 file changed, 51 insertions(+), 1 deletion(-)
diff --git a/drivers/net/cxgbe/base/t4_pci_id_tbl.h
b/drivers/net/cxgbe/base/t4_pci_id_tbl.h
index 5f5cbe048..f5f027a2e 100644
--- a/drivers/net/cxgbe/base/t4_pci_id_tbl.h
+++ b/drivers/net/cxgbe/base/t4_pci_id_tbl.h
@@ -1,5 +1,5 @@
/* SPDX-License-Identifier: BSD-3-Clause
- * Copyright(c) 2014-2018 Chelsio Communications.
+ * Copyright(c) 2014-2019 Chelsio Communications.
* All rights reserved.
*/
@@ -103,6 +103,12 @@ CH_PCI_DEVICE_ID_TABLE_DEFINE_BEGIN
CH_PCI_ID_TABLE_FENTRY(0x5013), /* T580-chr */
CH_PCI_ID_TABLE_FENTRY(0x5014), /* T580-so */
CH_PCI_ID_TABLE_FENTRY(0x5015), /* T502-bt */
+ CH_PCI_ID_TABLE_FENTRY(0x5016), /* T580-OCP-SO */
+ CH_PCI_ID_TABLE_FENTRY(0x5017), /* T520-OCP-SO */
+ CH_PCI_ID_TABLE_FENTRY(0x5018), /* T540-BT */
+ CH_PCI_ID_TABLE_FENTRY(0x5019), /* T540-LP-BT */
+ CH_PCI_ID_TABLE_FENTRY(0x501a), /* T540-SO-BT */
+ CH_PCI_ID_TABLE_FENTRY(0x501b), /* T540-SO-CR */
CH_PCI_ID_TABLE_FENTRY(0x5080), /* Custom T540-cr */
CH_PCI_ID_TABLE_FENTRY(0x5081), /* Custom T540-LL-cr */
CH_PCI_ID_TABLE_FENTRY(0x5082), /* Custom T504-cr */
@@ -116,19 +122,63 @@ CH_PCI_DEVICE_ID_TABLE_DEFINE_BEGIN
CH_PCI_ID_TABLE_FENTRY(0x5090), /* Custom T540-CR */
CH_PCI_ID_TABLE_FENTRY(0x5091), /* Custom T522-CR */
CH_PCI_ID_TABLE_FENTRY(0x5092), /* Custom T520-CR */
+ CH_PCI_ID_TABLE_FENTRY(0x5093), /* Custom T580-LP-CR */
+ CH_PCI_ID_TABLE_FENTRY(0x5094), /* Custom T540-CR */
+ CH_PCI_ID_TABLE_FENTRY(0x5095), /* Custom T540-CR-SO */
+ CH_PCI_ID_TABLE_FENTRY(0x5096), /* Custom T580-CR */
+ CH_PCI_ID_TABLE_FENTRY(0x5097), /* Custom T520-KR */
+ CH_PCI_ID_TABLE_FENTRY(0x5098), /* Custom 2x40G QSFP */
+ CH_PCI_ID_TABLE_FENTRY(0x5099), /* Custom 2x40G QSFP */
+ CH_PCI_ID_TABLE_FENTRY(0x509A), /* Custom T520-CR */
+ CH_PCI_ID_TABLE_FENTRY(0x509B), /* Custom T540-CR LOM */
+ CH_PCI_ID_TABLE_FENTRY(0x509c), /* Custom T520-CR SFP+ LOM */
+ CH_PCI_ID_TABLE_FENTRY(0x509d), /* Custom T540-CR SFP+ */
+ CH_PCI_ID_TABLE_FENTRY(0x509e), /* Custom T520-CR */
+ CH_PCI_ID_TABLE_FENTRY(0x509f), /* Custom T540-CR */
+ CH_PCI_ID_TABLE_FENTRY(0x50a0), /* Custom T540-CR */
+ CH_PCI_ID_TABLE_FENTRY(0x50a1), /* Custom T540-CR */
+ CH_PCI_ID_TABLE_FENTRY(0x50a2), /* Custom T580-KR4 */
+ CH_PCI_ID_TABLE_FENTRY(0x50a3), /* Custom T580-KR4 */
+ CH_PCI_ID_TABLE_FENTRY(0x50a4), /* Custom 2x T540-CR */
+ CH_PCI_ID_TABLE_FENTRY(0x50a5), /* Custom T522-BT */
+ CH_PCI_ID_TABLE_FENTRY(0x50a6), /* Custom T522-BT-SO */
+ CH_PCI_ID_TABLE_FENTRY(0x50a7), /* Custom T580-CR */
+ CH_PCI_ID_TABLE_FENTRY(0x50a8), /* Custom T580-KR */
+ CH_PCI_ID_TABLE_FENTRY(0x50a9), /* Custom T580-KR */
+ CH_PCI_ID_TABLE_FENTRY(0x50aa), /* Custom T580-CR */
+ CH_PCI_ID_TABLE_FENTRY(0x50ab), /* Custom T520-CR */
+ CH_PCI_ID_TABLE_FENTRY(0x50ac), /* Custom T540-BT */
+ CH_PCI_ID_TABLE_FENTRY(0x50ad), /* Custom T520-CR */
+ CH_PCI_ID_TABLE_FENTRY(0x50ae), /* Custom T540-XL-SO */
+ CH_PCI_ID_TABLE_FENTRY(0x50af), /* Custom T580-KR-SO */
+ CH_PCI_ID_TABLE_FENTRY(0x50b0), /* Custom T520-CR-LOM */
/* T6 adapter */
CH_PCI_ID_TABLE_FENTRY(0x6001), /* T6225-CR */
CH_PCI_ID_TABLE_FENTRY(0x6002), /* T6225-SO-CR */
CH_PCI_ID_TABLE_FENTRY(0x6003), /* T6425-CR */
+ CH_PCI_ID_TABLE_FENTRY(0x6004), /* T6425-SO-CR */
CH_PCI_ID_TABLE_FENTRY(0x6005), /* T6225-OCP */
+ CH_PCI_ID_TABLE_FENTRY(0x6006), /* T62100-OCP-SO */
CH_PCI_ID_TABLE_FENTRY(0x6007), /* T62100-LP-CR */
CH_PCI_ID_TABLE_FENTRY(0x6008), /* T62100-SO-CR */
+ CH_PCI_ID_TABLE_FENTRY(0x6009), /* T6210-BT */
CH_PCI_ID_TABLE_FENTRY(0x600d), /* T62100-CR */
CH_PCI_ID_TABLE_FENTRY(0x6011), /* T6225-LL-CR */
CH_PCI_ID_TABLE_FENTRY(0x6014), /* T61100-OCP-SO */
+ CH_PCI_ID_TABLE_FENTRY(0x6015), /* T6201-BT */
CH_PCI_ID_TABLE_FENTRY(0x6080), /* Custom T6225-CR SFP28 */
CH_PCI_ID_TABLE_FENTRY(0x6081), /* Custom T62100-CR */
+ CH_PCI_ID_TABLE_FENTRY(0x6082), /* Custom T6225-CR */
+ CH_PCI_ID_TABLE_FENTRY(0x6083), /* Custom T62100-CR */
+ CH_PCI_ID_TABLE_FENTRY(0x6084), /* Custom T64100-CR */
+ CH_PCI_ID_TABLE_FENTRY(0x6085), /* Custom T6240-SO */
+ CH_PCI_ID_TABLE_FENTRY(0x6086), /* Custom T6225-SO-CR */
+ CH_PCI_ID_TABLE_FENTRY(0x6087), /* Custom T6225-CR */
+ CH_PCI_ID_TABLE_FENTRY(0x6088), /* Custom T62100-CR */
+ CH_PCI_ID_TABLE_FENTRY(0x6089), /* Custom T62100-KR */
+ CH_PCI_ID_TABLE_FENTRY(0x608a), /* Custom T62100-CR */
+
Re: [dpdk-dev] [PATCH v2 1/1] test/compress: add max mbuf size test case
19/04/2019 11:25, David Marchand:
> On Fri, Apr 19, 2019 at 11:08 AM Thomas Monjalon
> wrote:
>
> > There are some variables declared in the middle of the function,
> > and one (i) is declared twice with two different types.
> >
> > Tomasz and Tomasz, are you working on it urgently please?
> >
>
> Found out that this test is not built by default.
> I have a trivial fix but I wonder how this has been tested seeing how it
> won't compile.
It is enabled with devtools/test-build.sh
and it is compiling fine with recent compilers I think.
Please send your fix.
> > 19/04/2019 00:42, Yongseok Koh:
> > > Hi,
> > >
> > > I'm seeing compile error.
> > > Isn't it due to this patch?
> > >
> > > $ gcc --version
> > > gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28)
> > >
> > >
> > > FAILED: app/test/app@test@@dpdk-test@exe/test_compressdev.c.o
> > [...]
> > > ../app/test/test_compressdev.c: In function
> > ‘test_compressdev_deflate_stateless_dynamic_big’:
> > > ../app/test/test_compressdev.c:1992:16: error: conflicting types for ‘i’
> > > for (uint32_t i = 0; i < BIG_DATA_TEST_SIZE - 1; ++i)
> > > ^
> > > ../app/test/test_compressdev.c:1949:11: note: previous definition of ‘i’
> > was here
> > > uint16_t i = 0;
> > >^
> > > ../app/test/test_compressdev.c:1992:2: error: ‘for’ loop initial
> > declarations are only allowed in C99 mode
> > > for (uint32_t i = 0; i < BIG_DATA_TEST_SIZE - 1; ++i)
> > > ^
> > > ../app/test/test_compressdev.c:1992:2: note: use option -std=c99 or
> > -std=gnu99 to compile your code
> > > ../app/test/test_compressdev.c:1996:19: warning: assignment from
> > incompatible pointer type [enabled by default]
> > > int_data.buf_idx = &i;
> > >^
> > > [1501/1523] Generating igb_uio with a custom command.
> > > make: Entering directory `/usr/src/kernels/3.10.0-862.el7.x86_64'
> > > CC [M]
> > /auto/mtiswgwork/yskoh/git/mellanox/dpdk.org-2/build/kernel/linux/igb_uio/igb_uio.o
> > > Building modules, stage 2.
> > > MODPOST 1 modules
> > > make[1]: Warning: File
> > `/auto/mtiswgwork/yskoh/git/mellanox/dpdk.org-2/build/kernel/linux/igb_uio/igb_uio.mod.c'
> > has modification time 0.0096 s in the future
> > > CC
> > /auto/mtiswgwork/yskoh/git/mellanox/dpdk.org-2/build/kernel/linux/igb_uio/igb_uio.mod.o
> > > LD [M]
> > /auto/mtiswgwork/yskoh/git/mellanox/dpdk.org-2/build/kernel/linux/igb_uio/igb_uio.ko
> > > make[1]: warning: Clock skew detected. Your build may be incomplete.
> > > make: Leaving directory `/usr/src/kernels/3.10.0-862.el7.x86_64'
> > >
> > >
> > > Thanks,
> > > Yongseok
> >
> > [...]
> > > >> +static int
> > > >> +test_compressdev_deflate_stateless_dynamic_big(void)
> > > >> +{
> > > >> + struct comp_testsuite_params *ts_params = &testsuite_params;
> > > >> + uint16_t i = 0;
> > > >> + int ret = TEST_SUCCESS;
> > > >> + const struct rte_compressdev_capabilities *capab;
> > > >> + char *test_buffer = NULL;
> > > >> +
> > > >> + capab = rte_compressdev_capability_get(0,
> > > >> RTE_COMP_ALGO_DEFLATE);
> > > >> + TEST_ASSERT(capab != NULL, "Failed to retrieve device
> > capabilities");
> > > >> +
> > > >> + if ((capab->comp_feature_flags &
> > > >> RTE_COMP_FF_HUFFMAN_DYNAMIC) == 0)
> > > >> + return -ENOTSUP;
> > > >> +
> > > >> + if ((capab->comp_feature_flags &
> > > >> RTE_COMP_FF_OOP_SGL_IN_SGL_OUT) == 0)
> > > >> + return -ENOTSUP;
> > > >> +
> > > >> + test_buffer = rte_malloc(NULL, BIG_DATA_TEST_SIZE, 0);
> > > >> + if (test_buffer == NULL) {
> > > >> + RTE_LOG(ERR, USER1,
> > > >> + "Can't allocate buffer for big-data\n");
> > > >> + return TEST_FAILED;
> > > >> + }
> > > >> +
> > > >> + struct interim_data_params int_data = {
> > > >> + (const char * const *)&test_buffer,
> > > >> + 1,
> > > >> + NULL,
> > > >> + &ts_params->def_comp_xform,
> > > >> + &ts_params->def_decomp_xform,
> > > >> + 1
> > > >> + };
> > > >> +
> > > >> + struct test_data_params test_data = {
> > > >> + RTE_COMP_OP_STATELESS,
> > > >> + SGL_BOTH,
> > > >> + ZLIB_DECOMPRESS,
> > > >> + 0,
> > > >> + 1
> > > >> + };
> > > >> +
> > > >> + ts_params->def_comp_xform->compress.deflate.huffman =
> > > >> +
> > > >>RTE_COMP_HUFFMAN_DYNAMIC;
> > > >> +
> > > >> + /* fill the buffer with data based on rand. data */
> > > >> + srand(BIG_DATA_TEST_SIZE);
> > > >> + for (uint32_t i = 0; i < BIG_DATA_TEST_SIZE - 1; ++i)
> > > >> + test_buffer[i] = (uint8_t)(rand() % ((uint8_t)-1)) | 1;
> > > >> +
> > > >> + test_buffer[BIG_DATA_TEST_SIZE-1] = 0;
> > > >> + int_data.buf_idx = &i;
> >
> >
> >
> >
>
Re: [dpdk-dev] [PATCH] net/cxgbe: update Chelsio T5/T6 NIC device ids
On 4/19/2019 10:22 AM, Rahul Lakkireddy wrote:
> Fixes: 04868e5bfddd ("net/cxgbe: add support to run Chelsio T6 cards")
Why this is a fix, isn't this just adding new device ids?
> Cc: sta...@dpdk.org
What about keeping 'stable' tag to request the backport but remove the fix?
>
> Signed-off-by: Rahul Lakkireddy
Re: [dpdk-dev] [PATCH v2 1/1] test/compress: add max mbuf size test case
Hi all,
I'm preparing the patch and will send it in 10 minutes
Thx, Tomek
> -Original Message-
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Friday, April 19, 2019 11:30 AM
> To: David Marchand
> Cc: Cel, TomaszX ; Jozwiak, TomaszX
> ; Yongseok Koh ;
> dev@dpdk.org; Trahe, Fiona ; Yigit, Ferruh
>
> Subject: Re: [dpdk-dev] [PATCH v2 1/1] test/compress: add max mbuf size
> test case
>
> 19/04/2019 11:25, David Marchand:
> > On Fri, Apr 19, 2019 at 11:08 AM Thomas Monjalon
>
> > wrote:
> >
> > > There are some variables declared in the middle of the function, and
> > > one (i) is declared twice with two different types.
> > >
> > > Tomasz and Tomasz, are you working on it urgently please?
> > >
> >
> > Found out that this test is not built by default.
> > I have a trivial fix but I wonder how this has been tested seeing how
> > it won't compile.
>
> It is enabled with devtools/test-build.sh and it is compiling fine with recent
> compilers I think.
>
> Please send your fix.
>
>
> > > 19/04/2019 00:42, Yongseok Koh:
> > > > Hi,
> > > >
> > > > I'm seeing compile error.
> > > > Isn't it due to this patch?
> > > >
> > > > $ gcc --version
> > > > gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28)
> > > >
> > > >
> > > > FAILED: app/test/app@test@@dpdk-test@exe/test_compressdev.c.o
> > > [...]
> > > > ../app/test/test_compressdev.c: In function
> > > ‘test_compressdev_deflate_stateless_dynamic_big’:
> > > > ../app/test/test_compressdev.c:1992:16: error: conflicting types for ‘i’
> > > > for (uint32_t i = 0; i < BIG_DATA_TEST_SIZE - 1; ++i)
> > > > ^
> > > > ../app/test/test_compressdev.c:1949:11: note: previous definition of ‘i’
> > > was here
> > > > uint16_t i = 0;
> > > >^
> > > > ../app/test/test_compressdev.c:1992:2: error: ‘for’ loop initial
> > > declarations are only allowed in C99 mode
> > > > for (uint32_t i = 0; i < BIG_DATA_TEST_SIZE - 1; ++i)
> > > > ^
> > > > ../app/test/test_compressdev.c:1992:2: note: use option -std=c99
> > > > or
> > > -std=gnu99 to compile your code
> > > > ../app/test/test_compressdev.c:1996:19: warning: assignment from
> > > incompatible pointer type [enabled by default]
> > > > int_data.buf_idx = &i;
> > > >^
> > > > [1501/1523] Generating igb_uio with a custom command.
> > > > make: Entering directory `/usr/src/kernels/3.10.0-862.el7.x86_64'
> > > > CC [M]
> > > /auto/mtiswgwork/yskoh/git/mellanox/dpdk.org-2/build/kernel/linux/ig
> > > b_uio/igb_uio.o
> > > > Building modules, stage 2.
> > > > MODPOST 1 modules
> > > > make[1]: Warning: File
> > > `/auto/mtiswgwork/yskoh/git/mellanox/dpdk.org-
> 2/build/kernel/linux/igb_uio/igb_uio.mod.c'
> > > has modification time 0.0096 s in the future
> > > > CC
> > > /auto/mtiswgwork/yskoh/git/mellanox/dpdk.org-2/build/kernel/linux/ig
> > > b_uio/igb_uio.mod.o
> > > > LD [M]
> > > /auto/mtiswgwork/yskoh/git/mellanox/dpdk.org-2/build/kernel/linux/ig
> > > b_uio/igb_uio.ko
> > > > make[1]: warning: Clock skew detected. Your build may be
> incomplete.
> > > > make: Leaving directory `/usr/src/kernels/3.10.0-862.el7.x86_64'
> > > >
> > > >
> > > > Thanks,
> > > > Yongseok
> > >
> > > [...]
> > > > >> +static int
> > > > >> +test_compressdev_deflate_stateless_dynamic_big(void)
> > > > >> +{
> > > > >> + struct comp_testsuite_params *ts_params = &testsuite_params;
> > > > >> + uint16_t i = 0;
> > > > >> + int ret = TEST_SUCCESS;
> > > > >> + const struct rte_compressdev_capabilities *capab;
> > > > >> + char *test_buffer = NULL;
> > > > >> +
> > > > >> + capab = rte_compressdev_capability_get(0,
> > > > >> RTE_COMP_ALGO_DEFLATE);
> > > > >> + TEST_ASSERT(capab != NULL, "Failed to retrieve device
> > > capabilities");
> > > > >> +
> > > > >> + if ((capab->comp_feature_flags &
> > > > >> RTE_COMP_FF_HUFFMAN_DYNAMIC) == 0)
> > > > >> + return -ENOTSUP;
> > > > >> +
> > > > >> + if ((capab->comp_feature_flags &
> > > > >> RTE_COMP_FF_OOP_SGL_IN_SGL_OUT) == 0)
> > > > >> + return -ENOTSUP;
> > > > >> +
> > > > >> + test_buffer = rte_malloc(NULL, BIG_DATA_TEST_SIZE, 0); if
> > > > >> + (test_buffer == NULL) {
> > > > >> + RTE_LOG(ERR, USER1,
> > > > >> + "Can't allocate buffer for big-data\n");
> > > > >> + return TEST_FAILED;
> > > > >> + }
> > > > >> +
> > > > >> + struct interim_data_params int_data = {
> > > > >> + (const char * const *)&test_buffer,
> > > > >> + 1,
> > > > >> + NULL,
> > > > >> + &ts_params->def_comp_xform,
> > > > >> + &ts_params->def_decomp_xform,
> > > > >> + 1
> > > > >> + };
> > > > >> +
> > > > >> + struct test_data_params test_data = {
> > > > >> + RTE_COMP_OP_STATELESS,
> > > > >> + SGL_BOTH,
> > > > >> + ZLIB_DECOMPRESS,
> > > > >> + 0,
> > > > >> + 1
> > > > >> + };
> > > > >> +
> > > > >> + ts_params->def_comp_xform->compress.deflate.huffman =
> > > > >> +
Re: [dpdk-dev] [PATCH v2 1/1] test/compress: add max mbuf size test case
On Fri, Apr 19, 2019 at 11:32 AM Jozwiak, TomaszX wrote: > Hi all, > > I'm preparing the patch and will send it in 10 minutes > Ok, dropping mine. -- David Marchand
Re: [dpdk-dev] [PATCH] power: fix for policy dependency to MAC list
On 9/4/2019 10:54 AM, Lukasz Krakowiak wrote:
Removed dependency to mac_list from policies:
* BRANCH_RATIO,
* WORKLOAD,
* TIME
in function update_policy.
Fixes: 1b897991473f ("power: update error handling")
Signed-off-by: Lukasz Krakowiak
---
examples/vm_power_manager/channel_monitor.c | 18 +-
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/examples/vm_power_manager/channel_monitor.c
b/examples/vm_power_manager/channel_monitor.c
index 74df0fe20..ad1ddde07 100644
--- a/examples/vm_power_manager/channel_monitor.c
+++ b/examples/vm_power_manager/channel_monitor.c
@@ -437,9 +437,12 @@ update_policy(struct channel_packet *pkt)
/* Copy the contents of *pkt into the policy.pkt */
policies[i].pkt = *pkt;
get_pcpu_to_control(&policies[i]);
- if (get_pfid(&policies[i]) < 0) {
- updated = 1;
- break;
+ /* Check Eth dev only for Traffic policy */
+ if (policies[i].pkt.policy_to_use == TRAFFIC) {
+ if (get_pfid(&policies[i]) < 0) {
+ updated = 1;
+ break;
+ }
}
core_share_status(i);
policies[i].enabled = 1;
@@ -451,8 +454,13 @@ update_policy(struct channel_packet *pkt)
if (policies[i].enabled == 0) {
policies[i].pkt = *pkt;
get_pcpu_to_control(&policies[i]);
- if (get_pfid(&policies[i]) < 0)
- break;
+ /* Check Eth dev only for Traffic policy */
+ if (policies[i].pkt.policy_to_use == TRAFFIC) {
+ if (get_pfid(&policies[i]) < 0) {
+ updated = 1;
+ break;
+ }
+ }
core_share_status(i);
policies[i].enabled = 1;
break;
I hope it's OK to add Yufeng's Tested-by. As a new member to the mailing
list, they've tested the patch, but does not have the original email to
reply to.
Tested-by: Yufeng Mo
Re: [dpdk-dev] [PATCH v3] net/bonding: fix potential out of bounds read
On 4/18/2019 11:57 PM, Chas Williams wrote:
>
>
> On 4/18/19 2:41 PM, Ferruh Yigit wrote:
>> On 4/17/2019 3:36 PM, Radu Nicolau wrote:
>>> Add validation to pointer constructed from the IPv4 header length
>>> in order to prevent malformed packets from generating a potential
>>> out of bounds memory read.
>>>
>>> Fixes: 09150784a776 ("net/bonding: burst mode hash calculation")
>>> Cc: sta...@dpdk.org
>>>
>>> Signed-off-by: Radu Nicolau
>>
>> Hi Chas,
>>
>> Do you have any objection on the patch?
>> Functionally looks correct to me, but additional checks in datapath perhaps
>> can
>> be a concern, if not I am for getting the patch.
>
> I don't think the calculation is a huge concern.
>
> Acked-by: Chas Williams
Applied to dpdk-next-net/master, thanks.
Re: [dpdk-dev] [PATCH v1 1/2] net/af_xdp: name the buf ring dynamically
On Thu, Apr 18, 2019 at 5:27 PM Xiaolong Ye wrote:
> Naming the buf_ring dynamically allows to create multiple af_xdp vdevs.
>
> Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD")
>
> Reported-by: Markus Theil
> Signed-off-by: Xiaolong Ye
> ---
> drivers/net/af_xdp/rte_eth_af_xdp.c | 9 ++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c
> b/drivers/net/af_xdp/rte_eth_af_xdp.c
> index 497e2cfde..d8e99204e 100644
> --- a/drivers/net/af_xdp/rte_eth_af_xdp.c
> +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c
> @@ -473,7 +473,7 @@ xdp_umem_destroy(struct xsk_umem_info *umem)
> }
>
> static struct
> -xsk_umem_info *xdp_umem_configure(void)
> +xsk_umem_info *xdp_umem_configure(struct pmd_internals *internals)
> {
> struct xsk_umem_info *umem;
> const struct rte_memzone *mz;
> @@ -482,6 +482,7 @@ xsk_umem_info *xdp_umem_configure(void)
> .comp_size = ETH_AF_XDP_DFLT_NUM_DESCS,
> .frame_size = ETH_AF_XDP_FRAME_SIZE,
> .frame_headroom = ETH_AF_XDP_DATA_HEADROOM };
> + char ring_name[RTE_RING_NAMESIZE];
> int ret;
> uint64_t i;
>
> @@ -491,7 +492,9 @@ xsk_umem_info *xdp_umem_configure(void)
> return NULL;
> }
>
> - umem->buf_ring = rte_ring_create("af_xdp_ring",
> + ret = snprintf(ring_name, sizeof(ring_name), "af_xdp_ring_%s_%d",
> + internals->if_name, internals->queue_idx);
>
You can drop the ret assignment, you won't check it anyway.
queue_idx is unsigned %d -> %u ?
+ umem->buf_ring = rte_ring_create(ring_name,
> ETH_AF_XDP_NUM_BUFFERS,
> rte_socket_id(),
> 0x0);
> @@ -541,7 +544,7 @@ xsk_configure(struct pmd_internals *internals, struct
> pkt_rx_queue *rxq,
> int ret = 0;
> int reserve_size;
>
> - rxq->umem = xdp_umem_configure();
> + rxq->umem = xdp_umem_configure(internals);
> if (rxq->umem == NULL)
> return -ENOMEM;
>
> --
> 2.17.1
>
>
Reviewed-by: David Marchand
--
David Marchand
Re: [dpdk-dev] [PATCH v1 2/2] net/af_xdp: name the umem memzone dynamically
On Thu, Apr 18, 2019 at 5:27 PM Xiaolong Ye wrote:
> Naming the umem memzone dynamically allows to create multiple af_xdp vdevs.
>
> Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD")
>
> Reported-by: Markus Theil
> Signed-off-by: Xiaolong Ye
> ---
> drivers/net/af_xdp/rte_eth_af_xdp.c | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c
> b/drivers/net/af_xdp/rte_eth_af_xdp.c
> index d8e99204e..666b4c17e 100644
> --- a/drivers/net/af_xdp/rte_eth_af_xdp.c
> +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c
> @@ -483,6 +483,7 @@ xsk_umem_info *xdp_umem_configure(struct pmd_internals
> *internals)
> .frame_size = ETH_AF_XDP_FRAME_SIZE,
> .frame_headroom = ETH_AF_XDP_DATA_HEADROOM };
> char ring_name[RTE_RING_NAMESIZE];
> + char mz_name[RTE_MEMZONE_NAMESIZE];
> int ret;
> uint64_t i;
>
> @@ -508,7 +509,9 @@ xsk_umem_info *xdp_umem_configure(struct pmd_internals
> *internals)
> (void *)(i * ETH_AF_XDP_FRAME_SIZE +
> ETH_AF_XDP_DATA_HEADROOM));
>
> - mz = rte_memzone_reserve_aligned("af_xdp uemem",
> + ret = snprintf(mz_name, sizeof(mz_name), "af_xdp_umem_%s_%d",
> + internals->if_name, internals->queue_idx);
>
Idem previous patch.
+ mz = rte_memzone_reserve_aligned(mz_name,
> ETH_AF_XDP_NUM_BUFFERS * ETH_AF_XDP_FRAME_SIZE,
> rte_socket_id(), RTE_MEMZONE_IOVA_CONTIG,
> getpagesize());
> --
> 2.17.1
>
>
How about squashing those two patches as a single one ?
The issue is that you can't create multiple devices. Having the first one
still leaves the issue.
Reviewed-by: David Marchand
--
David Marchand
Re: [dpdk-dev] [PATCH] net/cxgbe: update Chelsio T5/T6 NIC device ids
Hi Ferruh,
On Friday, April 04/19/19, 2019 at 15:00:32 +0530, Ferruh Yigit wrote:
> On 4/19/2019 10:22 AM, Rahul Lakkireddy wrote:
> > Fixes: 04868e5bfddd ("net/cxgbe: add support to run Chelsio T6 cards")
>
> Why this is a fix, isn't this just adding new device ids?
>
>
> > Cc: sta...@dpdk.org
>
> What about keeping 'stable' tag to request the backport but remove the fix?
>
It's fixing probe for these new devices. Let me know if this particular
case doesn't require the fixes line and I will send v2 with only the
stable tag.
> >
> > Signed-off-by: Rahul Lakkireddy
>
Thanks,
Rahul
[dpdk-dev] [PATCH] test/compress: fix max mbuf size test case
Fixed the compilation error on gcc (GCC)
4.8.5 20150623 (Red Hat 4.8.5-28)
Fixes: 355b02eedc65 ("test/compress: add max mbuf size test case")
Cc: sta...@dpdk.org
Signed-off-by: Tomasz Jozwiak
---
app/test/test_compressdev.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/app/test/test_compressdev.c b/app/test/test_compressdev.c
index 404b98f..603eeea 100644
--- a/app/test/test_compressdev.c
+++ b/app/test/test_compressdev.c
@@ -1948,6 +1948,7 @@ test_compressdev_deflate_stateless_dynamic_big(void)
struct comp_testsuite_params *ts_params = &testsuite_params;
uint16_t i = 0;
int ret = TEST_SUCCESS;
+ int j = 0;
const struct rte_compressdev_capabilities *capab;
char *test_buffer = NULL;
@@ -1989,8 +1990,8 @@ test_compressdev_deflate_stateless_dynamic_big(void)
/* fill the buffer with data based on rand. data */
srand(BIG_DATA_TEST_SIZE);
- for (uint32_t i = 0; i < BIG_DATA_TEST_SIZE - 1; ++i)
- test_buffer[i] = (uint8_t)(rand() % ((uint8_t)-1)) | 1;
+ for (j = 0; j < BIG_DATA_TEST_SIZE - 1; ++j)
+ test_buffer[j] = (uint8_t)(rand() % ((uint8_t)-1)) | 1;
test_buffer[BIG_DATA_TEST_SIZE-1] = 0;
int_data.buf_idx = &i;
--
2.7.4
Re: [dpdk-dev] [PATCH v2 1/1] test/compress: add max mbuf size test case
Hi Yongseok, Could you check my fix is ok now on gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28) Thx, Tomek > -Original Message- > From: Yongseok Koh [mailto:ys...@mellanox.com] > Sent: Friday, April 19, 2019 12:43 AM > To: Cel, TomaszX ; Thomas Monjalon > ; Jozwiak, TomaszX > Cc: dev@dpdk.org; Trahe, Fiona > Subject: Re: [dpdk-dev] [PATCH v2 1/1] test/compress: add max mbuf size > test case > > Hi, > > I'm seeing compile error. > Isn't it due to this patch? > > $ gcc --version > gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28) > > > [1484/1523] Compiling C object 'app/test/app@test@@dpdk- > test@exe/test_compressdev.c.o'. > FAILED: app/test/app@test@@dpdk-test@exe/test_compressdev.c.o > cc -Iapp/test/app@test@@dpdk-test@exe -Iapp/test -I../app/test - > Ilib/librte_acl -I../lib/librte_acl -I. -I../ -Iconfig -I../config - > Ilib/librte_eal/common/include -I../lib/librte_eal/common/include - > I../lib/librte_eal/linux/eal/include -Ilib/librte_eal/common - > I../lib/librte_eal/common -Ilib/librte_eal/common/include/arch/x86 - > I../lib/librte_eal/common/include/arch/x86 -Ilib/librte_eal > -I../lib/librte_eal - > Ilib/librte_kvargs -I../lib/librte_kvargs -Ilib/librte_bitratestats - > I../lib/librte_bitratestats -Ilib/librte_ethdev -I../lib/librte_ethdev - > Ilib/librte_net -I../lib/librte_net -Ilib/librte_mbuf-I../lib/librte_mbuf - > Ilib/librte_mempool -I../lib/librte_mempool -Ilib/librte_ring - > I../lib/librte_ring -Ilib/librte_cmdline -I../lib/librte_cmdline > -Ilib/librte_meter > -I../lib/librte_meter -Ilib/librte_metrics -I../lib/librte_metrics > -Ilib/librte_bpf - > I../lib/librte_bpf -Ilib/librte_cfgfile -I../lib/librte_cfgfile > -Ilib/librte_cryptodev > -I../lib/librte_cryptodev -Ilib/librte_distributor > -I../lib/librte_distributor - > Ilib/librte_efd -I../lib/librte_efd -Ilib/librte_hash -I../lib/librte_hash - > Ilib/librte_eventdev -I../lib/librte_eventdev -Ilib/librte_timer - > I../lib/librte_timer -Ilib/librte_flow_classify -I../lib/librte_flow_classify > - > Ilib/librte_table -I../lib/librte_table -Ilib/librte_port > -I../lib/librte_port - > Ilib/librte_sched -I../lib/librte_sched -Ilib/librte_ip_frag > -I../lib/librte_ip_frag > -Ilib/librte_kni -I../lib/librte_kni -Ilib/librte_pci -I../lib/librte_pci - > Ilib/librte_lpm -I../lib/librte_lpm -Ilib/librte_ipsec -I../lib/librte_ipsec - > Ilib/librte_security -I../lib/librte_security -Ilib/librte_latencystats - > I../lib/librte_latencystats -Ilib/librte_member -I../lib/librte_member - > Ilib/librte_pipeline -I../lib/librte_pipeline -Ilib/librte_reorder - > I../lib/librte_reorder -Ilib/librte_stack -I../lib/librte_stack > -Ilib/librte_pdump - > I../lib/librte_pdump -Idrivers/net/i40e -I../drivers/net/i40e - > Idrivers/net/i40e/base -I../drivers/net/i40e/base -Idrivers/bus/pci - > I../drivers/bus/pci -I../drivers/bus/pci/linux -Idrivers/bus/vdev - > I../drivers/bus/vdev -Idrivers/net/ixgbe -I../drivers/net/ixgbe - > Idrivers/net/ixgbe/base -I../drivers/net/ixgbe/base-Idrivers/net/bonding - > I../drivers/net/bonding -Idrivers/net/ring -I../drivers/net/ring - > Ilib/librte_power -I../lib/librte_power -Ilib/librte_compressdev - > I../lib/librte_compressdev -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid- > pch -O3 -include rte_config.h -Wsign-compare -Wcast-qual -march=native - > D_GNU_SOURCE -DALLOW_EXPERIMENTAL_API -MD -MQ > 'app/test/app@test@@dpdk-test@exe/test_compressdev.c.o' -MF > 'app/test/app@test@@dpdk-test@exe/test_compressdev.c.o.d' -o > 'app/test/app@test@@dpdk-test@exe/test_compressdev.c.o' -c > ../app/test/test_compressdev.c > ../app/test/test_compressdev.c: In function > ‘test_compressdev_deflate_stateless_dynamic_big’: > ../app/test/test_compressdev.c:1992:16: error: conflicting types for ‘i’ > for (uint32_t i = 0; i < BIG_DATA_TEST_SIZE - 1; ++i) > ^ > ../app/test/test_compressdev.c:1949:11: note: previous definition of ‘i’ was > here > uint16_t i = 0; >^ > ../app/test/test_compressdev.c:1992:2: error: ‘for’ loop initial declarations > are only allowed in C99 mode > for (uint32_t i = 0; i < BIG_DATA_TEST_SIZE - 1; ++i) > ^ > ../app/test/test_compressdev.c:1992:2: note: use option -std=c99 or - > std=gnu99 to compile your code > ../app/test/test_compressdev.c:1996:19: warning: assignment from > incompatible pointer type [enabled by default] > int_data.buf_idx = &i; >^ > [1501/1523] Generating igb_uio with a custom command. > make: Entering directory `/usr/src/kernels/3.10.0-862.el7.x86_64' > CC [M] /auto/mtiswgwork/yskoh/git/mellanox/dpdk.org- > 2/build/kernel/linux/igb_uio/igb_uio.o > Building modules, stage 2. > MODPOST 1 modules > make[1]: Warning: File `/auto/mtiswgwork/yskoh/git/mellanox/dpdk.org- > 2/build/kernel/linux/igb_uio/igb_uio.mod.c' has modification time 0.0096 s in > the future > CC /auto/mtiswgwork/yskoh/git/mellanox/dpdk.org- > 2/build/kernel/linux/igb_uio/igb_uio.mod.o > LD [M] /auto/mtiswgwork/yskoh/git/mellanox/dpdk.org- > 2/bu
[dpdk-dev] [PATCH 2/2] crypto/aesni_mb: cleanup of version check code
The version check for the IPSec_MB library present in the aesni_gcm
library's meson.build file is a little cleaner than that given here,
so update this one so that both work identically.
While one could use the checks done in the other right now, potentially in
future they may have different version dependencies, or may be compiled in
different orders, so keep the code duplicated for safety, since it's only a
few lines.
Signed-off-by: Bruce Richardson
---
drivers/crypto/aesni_mb/meson.build | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/crypto/aesni_mb/meson.build
b/drivers/crypto/aesni_mb/meson.build
index fbc4878af..7c1eb3f86 100644
--- a/drivers/crypto/aesni_mb/meson.build
+++ b/drivers/crypto/aesni_mb/meson.build
@@ -1,25 +1,25 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2018 Intel Corporation
-IPSec_MB_ver_0_52 = '0.52.0'
+
+IMB_required_ver = '0.52.0'
lib = cc.find_library('IPSec_MB', required: false)
if not lib.found()
build = false
else
ext_deps += lib
- imb_arr = cc.get_define('IMB_VERSION_STR',
- prefix : '#include').split('"')
-
- imb_ver = ''.join(imb_arr)
+ # version comes with quotes, so we split based on " and take the middle
+ imb_ver = cc.get_define('IMB_VERSION_STR',
+ prefix : '#include').split('"')[1]
- if (imb_ver == '') or (imb_ver.version_compare('<' + IPSec_MB_ver_0_52))
- message('IPSec_MB version >= 0.52 is required')
+ if (imb_ver == '') or (imb_ver.version_compare('<' + IMB_required_ver))
+ message('IPSec_MB version >= @0@ is required, found version
@1@'.format(
+ IMB_required_ver, imb_ver))
build = false
- else
- sources = files('rte_aesni_mb_pmd.c', 'rte_aesni_mb_pmd_ops.c')
endif
endif
+sources = files('rte_aesni_mb_pmd.c', 'rte_aesni_mb_pmd_ops.c')
allow_experimental_apis = true
deps += ['bus_vdev']
--
2.20.1
[dpdk-dev] [PATCH 1/2] crypto/aesni_gcm: add dependency version check
The aesni_mb driver and the aesni_gcm driver both require the same version
of the IPSec_MB library, but only the former has a check of the library
found to see if it's the correct version. Add a similar check to the
aesni_gcm library's meson.build file, so that the auto-detection of
dependencies works correctly.
Signed-off-by: Bruce Richardson
---
drivers/crypto/aesni_gcm/meson.build | 11 +++
1 file changed, 11 insertions(+)
diff --git a/drivers/crypto/aesni_gcm/meson.build
b/drivers/crypto/aesni_gcm/meson.build
index 70f57ad73..7183cfcba 100644
--- a/drivers/crypto/aesni_gcm/meson.build
+++ b/drivers/crypto/aesni_gcm/meson.build
@@ -1,11 +1,22 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2018 Intel Corporation
+IMB_required_ver = '0.52.0'
lib = cc.find_library('IPSec_MB', required: false)
if not lib.found()
build = false
else
ext_deps += lib
+
+ # version comes with quotes, so we split based on " and take the middle
+ imb_ver = cc.get_define('IMB_VERSION_STR',
+ prefix : '#include').split('"')[1]
+
+ if (imb_ver == '') or (imb_ver.version_compare('<' + IMB_required_ver))
+ message('IPSec_MB version >= @0@ is required, found version
@1@'.format(
+ IMB_required_ver, imb_ver))
+ build = false
+ endif
endif
allow_experimental_apis = true
--
2.20.1
Re: [dpdk-dev] [PATCH] test/compress: fix max mbuf size test case
On Fri, Apr 19, 2019 at 11:57:07AM +0200, Tomasz Jozwiak wrote:
> Fixed the compilation error on gcc (GCC)
> 4.8.5 20150623 (Red Hat 4.8.5-28)
>
> Fixes: 355b02eedc65 ("test/compress: add max mbuf size test case")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Tomasz Jozwiak
> ---
> app/test/test_compressdev.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
This fixes compilation for me with gcc4.8, though I can't comment on the
correctness of the code.
Acked-by: Bruce Richardson
Re: [dpdk-dev] [PATCH] net/cxgbe: fix colliding function names
On Friday, April 04/19/19, 2019 at 05:07:02 +0530, Stephen Hemminger wrote:
> This driver defines lots of functions (like init_rss) which are intended
> to only be used in this device. But when doing static linking these
> global functions cause link failures when similar function name is
> used in application.
>
> This patch prefixes all functions defined in cxgbe.h with cxgbe_
> to avoid these kind of conflicts.
>
Agreed. Thanks for fixing it up.
> Fixes: bfcb257d3014 ("net/cxgbe: enable RSS for VF")
> Signed-off-by: Stephen Hemminger
> ---
> drivers/net/cxgbe/cxgbe.h| 27 +
> drivers/net/cxgbe/cxgbe_ethdev.c | 15 +++---
> drivers/net/cxgbe/cxgbe_main.c | 34
> drivers/net/cxgbe/cxgbevf_main.c | 10 +-
> 4 files changed, 44 insertions(+), 42 deletions(-)
>
> diff --git a/drivers/net/cxgbe/cxgbe.h b/drivers/net/cxgbe/cxgbe.h
> index 5a7490f914c8..951b3ed3e9b6 100644
> --- a/drivers/net/cxgbe/cxgbe.h
> +++ b/drivers/net/cxgbe/cxgbe.h
> @@ -52,7 +52,7 @@
> #define CXGBE_DEVARG_KEEP_OVLAN "keep_ovlan"
> #define CXGBE_DEVARG_FORCE_LINK_UP "force_link_up"
>
> -bool force_linkup(struct adapter *adap);
> +bool cxgbe_force_linkup(struct adapter *adap);
> int cxgbe_probe(struct adapter *adapter);
> int cxgbevf_probe(struct adapter *adapter);
> void cxgbe_get_speed_caps(struct port_info *pi, u32 *speed_caps);
> @@ -65,19 +65,20 @@ void cxgbevf_stats_get(struct port_info *pi, struct
> port_stats *stats);
> void cxgbe_stats_reset(struct port_info *pi);
> int cxgbe_poll_for_completion(struct sge_rspq *q, unsigned int us,
> unsigned int cnt, struct t4_completion *c);
> -int link_start(struct port_info *pi);
> -void init_rspq(struct adapter *adap, struct sge_rspq *q, unsigned int us,
> -unsigned int cnt, unsigned int size, unsigned int iqe_size);
> -int setup_sge_fwevtq(struct adapter *adapter);
> -int setup_sge_ctrl_txq(struct adapter *adapter);
> -void cfg_queues(struct rte_eth_dev *eth_dev);
> -int cfg_queue_count(struct rte_eth_dev *eth_dev);
> -int init_rss(struct adapter *adap);
> -int setup_rss(struct port_info *pi);
> +int cxgbe_link_start(struct port_info *pi);
> +void cxgbe_init_rspq(struct adapter *adap, struct sge_rspq *q, unsigned int
> us,
> + unsigned int cnt, unsigned int size,
> + unsigned int iqe_size);
I see following build error.
cxgbe_main.c:468:13: error: no previous prototype for ‘init_rspq’
[-Werror=missing-prototypes]
inline void init_rspq(struct adapter *adap, struct sge_rspq *q,
^
Since init_rspq() is not used outside cxgbe_main.c, let's make
it static.
Thanks,
Rahul
Re: [dpdk-dev] [PATCH] net/cxgbe: fix colliding function names
On Friday, April 04/19/19, 2019 at 13:45:12 +0530, Ferruh Yigit wrote:
> On 4/19/2019 12:37 AM, Stephen Hemminger wrote:
> > This driver defines lots of functions (like init_rss) which are intended
> > to only be used in this device. But when doing static linking these
> > global functions cause link failures when similar function name is
> > used in application.
> >
> > This patch prefixes all functions defined in cxgbe.h with cxgbe_
> > to avoid these kind of conflicts.
>
> +1, not static functions should have module prefix
>
Agreed. I still see some non-static functions missing cxgbe_
prefix. I'll analyze more and audit them.
> >
> > Fixes: bfcb257d3014 ("net/cxgbe: enable RSS for VF")
> > Signed-off-by: Stephen Hemminger
>
Thanks,
Rahul
Re: [dpdk-dev] [PATCH v2] net/vmxnet3: v4 boot and guest UDP RSS configuration
On 4/18/2019 9:59 PM, Eduard Serra Miralles wrote: > From: Eduard Serra > > This patch introduces: > - VMxnet3 v4 negotiation and, > - entirely guest-driven UDP RSS support. > > VMxnet3 v3 already has UDP RSS support, however it > depends on hypervisor provisioning on the VM through > ESX specific flags, which are not transparent or known > to the guest later on. > > Vmxnet3 v4 introduces a new API transaction which allows > configuring RSS entirely from the guest. This API must be > invoked after device shared mem region is initialized. > > IPv4 ESP RSS (SPI based) is also available, but currently > there are no ESP RSS definitions on rte_eth layer to > handle that. > > Signed-off-by: Eduard Serra > Acked-by: Yong Wang Applied to dpdk-next-net/master, thanks.
Re: [dpdk-dev] [PATCH] test/compress: fix max mbuf size test case
Please check my comments below:
19/04/2019 11:57, Tomasz Jozwiak:
> Fixed the compilation error on gcc (GCC)
> 4.8.5 20150623 (Red Hat 4.8.5-28)
It is seen with more compilers:
https://build.opensuse.org/project/show/home:bluca:dpdk
Please add the log of the error.
> Fixes: 355b02eedc65 ("test/compress: add max mbuf size test case")
> Cc: sta...@dpdk.org
It is a recent commit, no need to Cc stable for backport.
> Signed-off-by: Tomasz Jozwiak
> ---
> app/test/test_compressdev.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/app/test/test_compressdev.c b/app/test/test_compressdev.c
> index 404b98f..603eeea 100644
> --- a/app/test/test_compressdev.c
> +++ b/app/test/test_compressdev.c
> @@ -1948,6 +1948,7 @@ test_compressdev_deflate_stateless_dynamic_big(void)
> struct comp_testsuite_params *ts_params = &testsuite_params;
> uint16_t i = 0;
> int ret = TEST_SUCCESS;
> + int j = 0;
> const struct rte_compressdev_capabilities *capab;
> char *test_buffer = NULL;
>
> @@ -1989,8 +1990,8 @@ test_compressdev_deflate_stateless_dynamic_big(void)
>
> /* fill the buffer with data based on rand. data */
> srand(BIG_DATA_TEST_SIZE);
> - for (uint32_t i = 0; i < BIG_DATA_TEST_SIZE - 1; ++i)
> - test_buffer[i] = (uint8_t)(rand() % ((uint8_t)-1)) | 1;
> + for (j = 0; j < BIG_DATA_TEST_SIZE - 1; ++j)
> + test_buffer[j] = (uint8_t)(rand() % ((uint8_t)-1)) | 1;
>
> test_buffer[BIG_DATA_TEST_SIZE-1] = 0;
> int_data.buf_idx = &i;
What is supposed to be "i"?
It is initialized at 0 and never touched.
Re: [dpdk-dev] [dpdk-stable] [PATCH] kni: fix build for ndo_fdb_add in Linux 5.1
09/04/2019 19:59, Rami Rosen:
> On Mon, Apr 08, 2019 at 03:22:26PM +0100, Ferruh Yigit wrote:
> > Build error seen with Linux kernel 5.1 and
> > when CONFIG_RTE_KNI_KMOD_ETHTOOL is enabled.
> >
> > Build error:
> > .../dpdk/build/build/kernel/linux/kni/igb_main.c:2352:18:
> > error: initialization of ... from incompatible pointer type ...
> > [-Werror=incompatible-pointer-types]
> > .ndo_fdb_add = igb_ndo_fdb_add,
> > ^~~
> >
> > ndo_fdb_add() is changed in Linux kernel version 5.1 and now requires
> > a new parameter, 'struct netlink_ext_ack *extack':
> > Linux Commit 87b0984ebfab ("net: Add extack argument to ndo_fdb_add()")
> >
> > ndo_fdb_add() parameter updated with compile time Linux kernel version
> > check.
> >
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Ferruh Yigit
> > ---
> Tested-by: Bruce Richardson
>
> Thanks.
> Checked build with CONFIG_RTE_KNI_KMOD_ETHTOOL=y
> after applying the patch, build was done against the bleeding edge of
> net-next of today (kernel 5.1-rc4).
> Build of the kni kernel module completed successfully.
>
> Reviewed-by: Rami Rosen
Applied, thanks
[dpdk-dev] [PATCH v2] net/tap: ipc add check for number of messages received
A sucessfull call to rte_mp_request_sync does not guarantee that there
are any messages in the buffer, and this should be checked for before
accessing data in the message. Buffer can be empty if IPC is disabled or
if we deciede to ignore replies.
Fixes: c9aa56edec8e ("net/tap: access primary process queues from secondary")
Cc: rasl...@mellanox.com
Cc: sta...@dpdk.org
Signed-off-by: Herakliusz Lipiec
---
drivers/net/tap/rte_eth_tap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index e9fda8cf6..7f74b5dc9 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_eth_tap.c
@@ -2101,7 +2101,7 @@ tap_mp_attach_queues(const char *port_name, struct
rte_eth_dev *dev)
request.len_param = sizeof(*request_param);
/* Send request and receive reply */
ret = rte_mp_request_sync(&request, &replies, &timeout);
- if (ret < 0) {
+ if (ret < 0 || replies.nb_received != 1) {
TAP_LOG(ERR, "Failed to request queues from primary: %d",
rte_errno);
return -1;
--
2.17.2
Re: [dpdk-dev] [PATCH v2] kni: implement header_ops parse method
12/04/2019 16:52, Ferruh Yigit: > On 4/10/2019 11:30 AM, Igor Ryzhov wrote: > > It allows applications running packet sockets over KNI interfaces to get > > source Ethernet addresses of packets received using recvfrom function. > > > > Signed-off-by: Igor Ryzhov > > Acked-by: Ferruh Yigit Applied, thanks
Re: [dpdk-dev] [PATCH v3] kni: add IOVA va support for kni
Hi, 16/04/2019 06:55, kirankum...@marvell.com: > From: Kiran Kumar K > > With current KNI implementation kernel module will work only in > IOVA=PA mode. This patch will add support for kernel module to work > with IOVA=VA mode. > > The idea is to get the physical address from iova address using > api iommu_iova_to_phys. Using this API, we will get the physical > address from iova address and later use phys_to_virt API to > convert the physical address to kernel virtual address. > > With this approach we have compared the performance with IOVA=PA > and there is no difference observed. Seems like kernel is the > overhead. > > Signed-off-by: Kiran Kumar K > --- > > V3 Changes: > * Add new approach to work kni with IOVA=VA mode using > iommu_iova_to_phys API. Compilation test is failing: http://mails.dpdk.org/archives/test-report/2019-April/080701.html
Re: [dpdk-dev] [PATCH] test/compress: fix max mbuf size test case
On Fri, Apr 19, 2019 at 11:57 AM Tomasz Jozwiak
wrote:
> Fixed the compilation error on gcc (GCC)
> 4.8.5 20150623 (Red Hat 4.8.5-28)
>
> Fixes: 355b02eedc65 ("test/compress: add max mbuf size test case")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Tomasz Jozwiak
> ---
> app/test/test_compressdev.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/app/test/test_compressdev.c b/app/test/test_compressdev.c
> index 404b98f..603eeea 100644
> --- a/app/test/test_compressdev.c
> +++ b/app/test/test_compressdev.c
> @@ -1948,6 +1948,7 @@ test_compressdev_deflate_stateless_dynamic_big(void)
> struct comp_testsuite_params *ts_params = &testsuite_params;
> uint16_t i = 0;
> int ret = TEST_SUCCESS;
> + int j = 0;
>
Useless initialisation.
const struct rte_compressdev_capabilities *capab;
> char *test_buffer = NULL;
>
> @@ -1989,8 +1990,8 @@ test_compressdev_deflate_stateless_dynamic_big(void)
>
> /* fill the buffer with data based on rand. data */
> srand(BIG_DATA_TEST_SIZE);
> - for (uint32_t i = 0; i < BIG_DATA_TEST_SIZE - 1; ++i)
> - test_buffer[i] = (uint8_t)(rand() % ((uint8_t)-1)) | 1;
> + for (j = 0; j < BIG_DATA_TEST_SIZE - 1; ++j)
> + test_buffer[j] = (uint8_t)(rand() % ((uint8_t)-1)) | 1;
>
> test_buffer[BIG_DATA_TEST_SIZE-1] = 0;
> int_data.buf_idx = &i;
> --
> 2.7.4
>
Tested-by: David Marchand
--
David Marchand
Re: [dpdk-dev] [PATCH] eventdev: promote adapter functions as stable
> -Original Message- > From: Carrillo, Erik G > Sent: Friday, April 19, 2019 3:17 AM > To: Jerin Jacob Kollanukkaran ; dev@dpdk.org; Thomas > Monjalon ; Mattias Rönnblom > ; Van Haaren, Harry > ; Gujjar, Abhinandan S > ; Rao, Nikhil > Cc: Pavan Nikhilesh Bhagavatula ; > hemant.agra...@nxp.com; nipun.gu...@nxp.com; Ma, Liang J > > Subject: RE: [dpdk-dev] [PATCH] eventdev: promote adapter functions as stable > > > -Original Message- > > From: jer...@marvell.com [mailto:jer...@marvell.com] > > Sent: Thursday, April 18, 2019 7:06 AM > > To: dev@dpdk.org; Thomas Monjalon ; Jerin Jacob > > ; Mattias Rönnblom > > ; Van Haaren, Harry > > ; Gujjar, Abhinandan S > > ; Rao, Nikhil ; > > Carrillo, Erik G > > Cc: pbhagavat...@marvell.com; hemant.agra...@nxp.com; > > nipun.gu...@nxp.com; Ma, Liang J > > Subject: [dpdk-dev] [PATCH] eventdev: promote adapter functions as > > stable > > > > From: Jerin Jacob > > > > Promote the adapter functions and rte_event_port_unlinks_in_progress() > > as stable as it's been added for a while now and multiple drivers and > > test application like test-eventdev has been tested using the adapter APIs. > > > > Cc: nikhil@intel.com > > Cc: erik.g.carri...@intel.com > > Cc: abhinandan.guj...@intel.com > > Cc: pbhagavat...@marvell.com > > Cc: hemant.agra...@nxp.com > > Cc: nipun.gu...@nxp.com > > Cc: harry.van.haa...@intel.com > > Cc: mattias.ronnb...@ericsson.com > > Cc: liang.j...@intel.com > > > > Signed-off-by: Jerin Jacob > > --- > > Hi Jerin, > > The "__rte_experimental" tag was removed from function prototypes in header > files while still leaving the following text in the Doxygen comments: > >* @warning >* @b EXPERIMENTAL: this API may change without prior notice Thanks Erik. Will fix it in v2. > > Regards, > Erik
Re: [dpdk-dev] [PATCH] net/cxgbe: update Chelsio T5/T6 NIC device ids
On 4/19/2019 10:49 AM, Rahul Lakkireddy wrote:
> Hi Ferruh,
>
> On Friday, April 04/19/19, 2019 at 15:00:32 +0530, Ferruh Yigit wrote:
>> On 4/19/2019 10:22 AM, Rahul Lakkireddy wrote:
>>> Fixes: 04868e5bfddd ("net/cxgbe: add support to run Chelsio T6 cards")
>>
>> Why this is a fix, isn't this just adding new device ids?
>>
>>
>>> Cc: sta...@dpdk.org
>>
>> What about keeping 'stable' tag to request the backport but remove the fix?
>>
>
> It's fixing probe for these new devices. Let me know if this particular
> case doesn't require the fixes line and I will send v2 with only the
> stable tag.
No need a v2, if you are agree I can remove while merging.
The commit is not fixing any old code in DPDK, if the intention of making this
patch a fix is to backport the patch, we can do same via stable tag, fix not
needed.
If these devices were ready at that time, in 17.08, but forgotten in that commit
to be added, than I see the fix but this looks unlikely since it is almost two
years ago.
>
>>>
>>> Signed-off-by: Rahul Lakkireddy
>>
>
> Thanks,
> Rahul
>
Re: [dpdk-dev] [PATCH] test/compress: fix max mbuf size test case
19/04/2019 12:57, Jozwiak, TomaszX: > > What is supposed to be "i"? > > It is initialized at 0 and never touched. > > > It's touched inside test_deflate_comp_decomp function. What do you mean? It's a local variable and its address is referenced: int_data.buf_idx = &i; It looks really wrong. Another error is seen in FreeBSD. Should I totally revert this patch?
Re: [dpdk-dev] [PATCH] test/compress: fix max mbuf size test case
test_deflate_comp_decomp function is common for all test cases. The options for this function are inside struct interim_data_params, which is passed to test_deflate_comp_decomp function as a pointer. The field buf_idx should be initialized because is used inside test_deflate_comp_decomp That's the reason of: int_data.buf_idx = &i; I'm not an author of this solution - sorry. We can review this and try to add new solution. Thx, Tomek > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Friday, April 19, 2019 1:26 PM > To: Jozwiak, TomaszX > Cc: dev@dpdk.org; Richardson, Bruce ; > david.march...@redhat.com; Trahe, Fiona ; > ys...@mellanox.com; Cel, TomaszX > Subject: Re: [dpdk-dev] [PATCH] test/compress: fix max mbuf size test case > > 19/04/2019 12:57, Jozwiak, TomaszX: > > > What is supposed to be "i"? > > > It is initialized at 0 and never touched. > > > > > It's touched inside test_deflate_comp_decomp function. > > What do you mean? > It's a local variable and its address is referenced: > int_data.buf_idx = &i; > It looks really wrong. > > Another error is seen in FreeBSD. > > Should I totally revert this patch? > >
Re: [dpdk-dev] [PATCH] net/cxgbe: fix colliding function names
On 4/19/2019 11:04 AM, Rahul Lakkireddy wrote:
> On Friday, April 04/19/19, 2019 at 05:07:02 +0530, Stephen Hemminger wrote:
>> This driver defines lots of functions (like init_rss) which are intended
>> to only be used in this device. But when doing static linking these
>> global functions cause link failures when similar function name is
>> used in application.
>>
>> This patch prefixes all functions defined in cxgbe.h with cxgbe_
>> to avoid these kind of conflicts.
>>
>
> Agreed. Thanks for fixing it up.
>
>> Fixes: bfcb257d3014 ("net/cxgbe: enable RSS for VF")
>> Signed-off-by: Stephen Hemminger
>> ---
>> drivers/net/cxgbe/cxgbe.h| 27 +
>> drivers/net/cxgbe/cxgbe_ethdev.c | 15 +++---
>> drivers/net/cxgbe/cxgbe_main.c | 34
>> drivers/net/cxgbe/cxgbevf_main.c | 10 +-
>> 4 files changed, 44 insertions(+), 42 deletions(-)
>>
>> diff --git a/drivers/net/cxgbe/cxgbe.h b/drivers/net/cxgbe/cxgbe.h
>> index 5a7490f914c8..951b3ed3e9b6 100644
>> --- a/drivers/net/cxgbe/cxgbe.h
>> +++ b/drivers/net/cxgbe/cxgbe.h
>> @@ -52,7 +52,7 @@
>> #define CXGBE_DEVARG_KEEP_OVLAN "keep_ovlan"
>> #define CXGBE_DEVARG_FORCE_LINK_UP "force_link_up"
>>
>> -bool force_linkup(struct adapter *adap);
>> +bool cxgbe_force_linkup(struct adapter *adap);
>> int cxgbe_probe(struct adapter *adapter);
>> int cxgbevf_probe(struct adapter *adapter);
>> void cxgbe_get_speed_caps(struct port_info *pi, u32 *speed_caps);
>> @@ -65,19 +65,20 @@ void cxgbevf_stats_get(struct port_info *pi, struct
>> port_stats *stats);
>> void cxgbe_stats_reset(struct port_info *pi);
>> int cxgbe_poll_for_completion(struct sge_rspq *q, unsigned int us,
>>unsigned int cnt, struct t4_completion *c);
>> -int link_start(struct port_info *pi);
>> -void init_rspq(struct adapter *adap, struct sge_rspq *q, unsigned int us,
>> - unsigned int cnt, unsigned int size, unsigned int iqe_size);
>> -int setup_sge_fwevtq(struct adapter *adapter);
>> -int setup_sge_ctrl_txq(struct adapter *adapter);
>> -void cfg_queues(struct rte_eth_dev *eth_dev);
>> -int cfg_queue_count(struct rte_eth_dev *eth_dev);
>> -int init_rss(struct adapter *adap);
>> -int setup_rss(struct port_info *pi);
>> +int cxgbe_link_start(struct port_info *pi);
>> +void cxgbe_init_rspq(struct adapter *adap, struct sge_rspq *q, unsigned int
>> us,
>> + unsigned int cnt, unsigned int size,
>> + unsigned int iqe_size);
>
> I see following build error.
>
> cxgbe_main.c:468:13: error: no previous prototype for ‘init_rspq’
> [-Werror=missing-prototypes]
> inline void init_rspq(struct adapter *adap, struct sge_rspq *q,
> ^
>
> Since init_rspq() is not used outside cxgbe_main.c, let's make
> it static.
Hi Rahul,
Can you send a new version with this change, if not I can send one?
[dpdk-dev] [PATCH v2] net/cxgbe: fix colliding function names
From: Stephen Hemminger
This driver defines lots of functions (like init_rss) which are intended
to only be used in this device. But when doing static linking these
global functions cause link failures when similar function name is
used in application.
This patch prefixes all functions defined in cxgbe.h with cxgbe_
to avoid these kind of conflicts.
Fixes: bfcb257d3014 ("net/cxgbe: enable RSS for VF")
Cc: sta...@dpdk.org
Signed-off-by: Stephen Hemminger
Reviewed-by: Ferruh Yigit
---
v2:
* ``init_rspq`` converted into static function instead of prefixing it.
---
drivers/net/cxgbe/cxgbe.h| 24 ++---
drivers/net/cxgbe/cxgbe_ethdev.c | 15 ++---
drivers/net/cxgbe/cxgbe_main.c | 36
drivers/net/cxgbe/cxgbevf_main.c | 10 -
4 files changed, 42 insertions(+), 43 deletions(-)
diff --git a/drivers/net/cxgbe/cxgbe.h b/drivers/net/cxgbe/cxgbe.h
index 5a7490f91..6af3ee79b 100644
--- a/drivers/net/cxgbe/cxgbe.h
+++ b/drivers/net/cxgbe/cxgbe.h
@@ -52,7 +52,7 @@
#define CXGBE_DEVARG_KEEP_OVLAN "keep_ovlan"
#define CXGBE_DEVARG_FORCE_LINK_UP "force_link_up"
-bool force_linkup(struct adapter *adap);
+bool cxgbe_force_linkup(struct adapter *adap);
int cxgbe_probe(struct adapter *adapter);
int cxgbevf_probe(struct adapter *adapter);
void cxgbe_get_speed_caps(struct port_info *pi, u32 *speed_caps);
@@ -65,19 +65,17 @@ void cxgbevf_stats_get(struct port_info *pi, struct
port_stats *stats);
void cxgbe_stats_reset(struct port_info *pi);
int cxgbe_poll_for_completion(struct sge_rspq *q, unsigned int us,
unsigned int cnt, struct t4_completion *c);
-int link_start(struct port_info *pi);
-void init_rspq(struct adapter *adap, struct sge_rspq *q, unsigned int us,
- unsigned int cnt, unsigned int size, unsigned int iqe_size);
-int setup_sge_fwevtq(struct adapter *adapter);
-int setup_sge_ctrl_txq(struct adapter *adapter);
-void cfg_queues(struct rte_eth_dev *eth_dev);
-int cfg_queue_count(struct rte_eth_dev *eth_dev);
-int init_rss(struct adapter *adap);
-int setup_rss(struct port_info *pi);
+int cxgbe_link_start(struct port_info *pi);
+int cxgbe_setup_sge_fwevtq(struct adapter *adapter);
+int cxgbe_setup_sge_ctrl_txq(struct adapter *adapter);
+void cxgbe_cfg_queues(struct rte_eth_dev *eth_dev);
+int cxgbe_cfg_queue_count(struct rte_eth_dev *eth_dev);
+int cxgbe_init_rss(struct adapter *adap);
+int cxgbe_setup_rss(struct port_info *pi);
void cxgbe_enable_rx_queues(struct port_info *pi);
-void print_port_info(struct adapter *adap);
-void print_adapter_info(struct adapter *adap);
+void cxgbe_print_port_info(struct adapter *adap);
+void cxgbe_print_adapter_info(struct adapter *adap);
int cxgbe_get_devargs(struct rte_devargs *devargs, const char *key);
-void configure_max_ethqsets(struct adapter *adapter);
+void cxgbe_configure_max_ethqsets(struct adapter *adapter);
#endif /* _CXGBE_H_ */
diff --git a/drivers/net/cxgbe/cxgbe_ethdev.c b/drivers/net/cxgbe/cxgbe_ethdev.c
index 833dd1f5f..01d256da0 100644
--- a/drivers/net/cxgbe/cxgbe_ethdev.c
+++ b/drivers/net/cxgbe/cxgbe_ethdev.c
@@ -200,7 +200,8 @@ int cxgbe_dev_link_update(struct rte_eth_dev *eth_dev,
cxgbe_poll(&s->fw_evtq, NULL, budget, &work_done);
/* Exit if link status changed or always forced up */
- if (pi->link_cfg.link_ok != old_link || force_linkup(adapter))
+ if (pi->link_cfg.link_ok != old_link ||
+ cxgbe_force_linkup(adapter))
break;
if (!wait_to_complete)
@@ -209,7 +210,7 @@ int cxgbe_dev_link_update(struct rte_eth_dev *eth_dev,
rte_delay_ms(CXGBE_LINK_STATUS_POLL_MS);
}
- new_link.link_status = force_linkup(adapter) ?
+ new_link.link_status = cxgbe_force_linkup(adapter) ?
ETH_LINK_UP : pi->link_cfg.link_ok;
new_link.link_autoneg = pi->link_cfg.autoneg;
new_link.link_duplex = ETH_LINK_FULL_DUPLEX;
@@ -356,7 +357,7 @@ int cxgbe_dev_start(struct rte_eth_dev *eth_dev)
cxgbe_enable_rx_queues(pi);
- err = setup_rss(pi);
+ err = cxgbe_setup_rss(pi);
if (err)
goto out;
@@ -372,7 +373,7 @@ int cxgbe_dev_start(struct rte_eth_dev *eth_dev)
goto out;
}
- err = link_start(pi);
+ err = cxgbe_link_start(pi);
if (err)
goto out;
@@ -412,18 +413,18 @@ int cxgbe_dev_configure(struct rte_eth_dev *eth_dev)
CXGBE_FUNC_TRACE();
if (!(adapter->flags & FW_QUEUE_BOUND)) {
- err = setup_sge_fwevtq(adapter);
+ err = cxgbe_setup_sge_fwevtq(adapter);
if (err)
return err;
adapter->flags |= FW_QUEUE_BOUND;
if (is_pf4(adapter)) {
- err = setup_sge_ctrl_txq(adapter);
+ err = cxgbe_setup_
[dpdk-dev] [PATCH v2] test/compress: fix max mbuf size test case
Fixed the compilation error:
../app/test/test_compressdev.c:1949:11: note: previous
definition of 'i' was here
../app/test/test_compressdev.c:1992:2: error: 'for' loop
initial declarations are only allowed in C99 mode
../app/test/test_compressdev.c:1992:2: note: use option
-std=c99 or -std=gnu99 to compile your code
../app/test/test_compressdev.c:1996:19: warning: assignment
from incompatible pointer type [enabled by default]
Fixes: 355b02eedc65 ("test/compress: add max mbuf size test case")
Signed-off-by: Tomasz Jozwiak
---
app/test/test_compressdev.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/app/test/test_compressdev.c b/app/test/test_compressdev.c
index 404b98f..a1b8649 100644
--- a/app/test/test_compressdev.c
+++ b/app/test/test_compressdev.c
@@ -1948,6 +1948,7 @@ test_compressdev_deflate_stateless_dynamic_big(void)
struct comp_testsuite_params *ts_params = &testsuite_params;
uint16_t i = 0;
int ret = TEST_SUCCESS;
+ int j;
const struct rte_compressdev_capabilities *capab;
char *test_buffer = NULL;
@@ -1989,8 +1990,8 @@ test_compressdev_deflate_stateless_dynamic_big(void)
/* fill the buffer with data based on rand. data */
srand(BIG_DATA_TEST_SIZE);
- for (uint32_t i = 0; i < BIG_DATA_TEST_SIZE - 1; ++i)
- test_buffer[i] = (uint8_t)(rand() % ((uint8_t)-1)) | 1;
+ for (j = 0; j < BIG_DATA_TEST_SIZE - 1; ++j)
+ test_buffer[j] = (uint8_t)(rand() % ((uint8_t)-1)) | 1;
test_buffer[BIG_DATA_TEST_SIZE-1] = 0;
int_data.buf_idx = &i;
--
2.7.4
Re: [dpdk-dev] [PATCH] test/compress: fix max mbuf size test case
Please stop top-posting, and read again below: 19/04/2019 13:36, Jozwiak, TomaszX: > test_deflate_comp_decomp function is common for all test cases. > The options for this function are inside struct interim_data_params, > which is passed to test_deflate_comp_decomp function as a pointer. > > The field buf_idx should be initialized because is used inside > test_deflate_comp_decomp > That's the reason of: > int_data.buf_idx = &i; > > I'm not an author of this solution - sorry. > > We can review this and try to add new solution. I am not talking about int_data but the use of "i". Please look again your patch, you are using "j" instead of "i" and "i" is kept alone. Moreover I don't know how the pointer of a local variable can be used. > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 19/04/2019 12:57, Jozwiak, TomaszX: > > > > What is supposed to be "i"? > > > > It is initialized at 0 and never touched. > > > > > > > It's touched inside test_deflate_comp_decomp function. > > > > What do you mean? > > It's a local variable and its address is referenced: > > int_data.buf_idx = &i; > > It looks really wrong. > > > > Another error is seen in FreeBSD. > > > > Should I totally revert this patch?
[dpdk-dev] [PATCH] app/test: fix missing header
Build of test_compressdev.c fails on FreeBSD due to the missing
include of unistd.h, to provide the function usleep.
Fixes: b06aa643cac4 ("test/compress: add initial unit tests")
Cc: pablo.de.lara.gua...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Bruce Richardson
---
I sent this previously, but I don't think it made the public list, so resending.
Apologies to anyone who gets this twice!
---
app/test/test_compressdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/app/test/test_compressdev.c b/app/test/test_compressdev.c
index 404b98f60..121514af5 100644
--- a/app/test/test_compressdev.c
+++ b/app/test/test_compressdev.c
@@ -5,6 +5,7 @@
#include
#include
#include
+#include
#include
#include
--
2.20.1
[dpdk-dev] [PATCH] devtools/test-meson-builds: fix support for plain bourne shell
The pipefail option is not supported in /bin/sh, just in bash/ksh and
similar shells - which means it's there by default on most Linux distros
but not on e.g. FreeBSD. Therefore we check for it's presence before
setting the option, and if it's missing, we upgrade verbosity level if
needed to ensure we never hide any build failures.
Signed-off-by: Bruce Richardson
---
This patch is a replacement for the previous patch: "fix support for
FreeBSD" [1], which was an incorrect/incomplete fix.
[1]http://patches.dpdk.org/patch/52468/
---
devtools/test-meson-builds.sh | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh
index 0ea79f461..630a1a6fe 100755
--- a/devtools/test-meson-builds.sh
+++ b/devtools/test-meson-builds.sh
@@ -7,7 +7,9 @@
# * if a build-directory already exists we assume it was properly configured
# Run ninja after configuration is done.
-set -o pipefail
+# set pipefail option if possible
+PIPEFAIL=""
+set -o | grep -q pipefail && set -o pipefail && PIPEFAIL=1
srcdir=$(dirname $(readlink -f $0))/..
MESON=${MESON:-meson}
@@ -51,6 +53,11 @@ if [ "$1" = "-vv" ] ; then
elif [ "$1" = "-v" ] ; then
TEST_MESON_BUILD_VERBOSE=1
fi
+# we can't use plain verbose when we don't have pipefail option so up-level
+if [ -z "$PIPEFAIL" -a -n "$TEST_MESON_BUILD_VERBOSE" ] ; then
+ echo "# Missing pipefail shell option, changing VERBOSE to VERY_VERBOSE"
+ TEST_MESON_BUILD_VERY_VERBOSE=1
+fi
# shared and static linked builds with gcc and clang
for c in gcc clang ; do
--
2.20.1
Re: [dpdk-dev] [PATCH v2] net/cxgbe: fix colliding function names
On Friday, April 04/19/19, 2019 at 17:14:25 +0530, Ferruh Yigit wrote:
> From: Stephen Hemminger
>
> This driver defines lots of functions (like init_rss) which are intended
> to only be used in this device. But when doing static linking these
> global functions cause link failures when similar function name is
> used in application.
>
> This patch prefixes all functions defined in cxgbe.h with cxgbe_
> to avoid these kind of conflicts.
>
> Fixes: bfcb257d3014 ("net/cxgbe: enable RSS for VF")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Stephen Hemminger
> Reviewed-by: Ferruh Yigit
Acked-by: Rahul Lakkireddy
Re: [dpdk-dev] [dpdk-stable] [PATCH] app/test: fix missing header
nit: "test/compress:" for the title prefix ?
On Fri, Apr 19, 2019 at 2:03 PM Bruce Richardson
wrote:
> Build of test_compressdev.c fails on FreeBSD due to the missing
> include of unistd.h, to provide the function usleep.
>
> Fixes: b06aa643cac4 ("test/compress: add initial unit tests")
> Cc: pablo.de.lara.gua...@intel.com
> Cc: sta...@dpdk.org
>
> Signed-off-by: Bruce Richardson
> ---
> I sent this previously, but I don't think it made the public list, so
> resending.
> Apologies to anyone who gets this twice!
> ---
> app/test/test_compressdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/app/test/test_compressdev.c b/app/test/test_compressdev.c
> index 404b98f60..121514af5 100644
> --- a/app/test/test_compressdev.c
> +++ b/app/test/test_compressdev.c
> @@ -5,6 +5,7 @@
> #include
> #include
> #include
> +#include
>
> #include
> #include
> --
> 2.20.1
>
>
Tested on FreeBSD 10.4.
Reviewed-by: David Marchand
--
David Marchand
[dpdk-dev] [PATCH v2] eventdev: promote adapter functions as stable
From: Jerin Jacob
Promote the adapter functions and rte_event_port_unlinks_in_progress()
as stable as it's been added for a while now and multiple drivers and
test application like test-eventdev has been tested using the adapter APIs.
Cc: nikhil@intel.com
Cc: erik.g.carri...@intel.com
Cc: abhinandan.guj...@intel.com
Cc: pbhagavat...@marvell.com
Cc: hemant.agra...@nxp.com
Cc: nipun.gu...@nxp.com
Cc: harry.van.haa...@intel.com
Cc: mattias.ronnb...@ericsson.com
Cc: liang.j...@intel.com
Signed-off-by: Jerin Jacob
---
allow experimental api still set to true for following drivers.
drivers/event/sw - due to usage of rte_service_may_be_active() API
drivers/event/dpaa[2] - due to usage of rte_mem_iova2virt() API
v2:
- Remove @warning EXPERIMENTAL from API(Erik)
---
MAINTAINERS | 8 +-
app/test-eventdev/Makefile| 1 -
app/test-eventdev/meson.build | 1 -
drivers/event/dsw/Makefile| 1 -
drivers/event/dsw/meson.build | 1 -
drivers/event/octeontx/Makefile | 1 -
drivers/event/octeontx/meson.build| 1 -
examples/eventdev_pipeline/Makefile | 2 -
examples/eventdev_pipeline/meson.build| 1 -
.../rte_event_crypto_adapter.c| 22 ++---
.../rte_event_crypto_adapter.h| 73 +++-
.../rte_event_eth_rx_adapter.h| 50 +--
.../rte_event_eth_tx_adapter.c| 22 ++---
.../rte_event_eth_tx_adapter.h| 76 -
lib/librte_eventdev/rte_event_timer_adapter.c | 20 ++---
lib/librte_eventdev/rte_event_timer_adapter.h | 83 +++
lib/librte_eventdev/rte_eventdev.c| 8 +-
lib/librte_eventdev/rte_eventdev.h| 14 +---
lib/librte_eventdev/rte_eventdev_version.map | 4 +-
19 files changed, 85 insertions(+), 304 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index a08583471..9c14f7e19 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -398,28 +398,28 @@ F: lib/librte_eventdev/
F: drivers/event/skeleton/
F: app/test/test_eventdev.c
-Eventdev Ethdev Rx Adapter API - EXPERIMENTAL
+Eventdev Ethdev Rx Adapter API
M: Nikhil Rao
T: git://dpdk.org/next/dpdk-next-eventdev
F: lib/librte_eventdev/*eth_rx_adapter*
F: app/test/test_event_eth_rx_adapter.c
F: doc/guides/prog_guide/event_ethernet_rx_adapter.rst
-Eventdev Ethdev Tx Adapter API - EXPERIMENTAL
+Eventdev Ethdev Tx Adapter API
M: Nikhil Rao
T: git://dpdk.org/next/dpdk-next-eventdev
F: lib/librte_eventdev/*eth_tx_adapter*
F: app/test/test_event_eth_tx_adapter.c
F: doc/guides/prog_guide/event_ethernet_tx_adapter.rst
-Eventdev Timer Adapter API - EXPERIMENTAL
+Eventdev Timer Adapter API
M: Erik Gabriel Carrillo
T: git://dpdk.org/next/dpdk-next-eventdev
F: lib/librte_eventdev/*timer_adapter*
F: app/test/test_event_timer_adapter.c
F: doc/guides/prog_guide/event_timer_adapter.rst
-Eventdev Crypto Adapter API - EXPERIMENTAL
+Eventdev Crypto Adapter API
M: Abhinandan Gujjar
T: git://dpdk.org/next/dpdk-next-eventdev
F: lib/librte_eventdev/*crypto_adapter*
diff --git a/app/test-eventdev/Makefile b/app/test-eventdev/Makefile
index cb659110e..e600e21c4 100644
--- a/app/test-eventdev/Makefile
+++ b/app/test-eventdev/Makefile
@@ -6,7 +6,6 @@ include $(RTE_SDK)/mk/rte.vars.mk
APP = dpdk-test-eventdev
-CFLAGS += -DALLOW_EXPERIMENTAL_API
CFLAGS += -O3
CFLAGS += $(WERROR_FLAGS)
diff --git a/app/test-eventdev/meson.build b/app/test-eventdev/meson.build
index a81dcd131..7ff2b786c 100644
--- a/app/test-eventdev/meson.build
+++ b/app/test-eventdev/meson.build
@@ -1,7 +1,6 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2017 Cavium, Inc
-allow_experimental_apis = true
sources = files('evt_main.c',
'evt_options.c',
'evt_test.c',
diff --git a/drivers/event/dsw/Makefile b/drivers/event/dsw/Makefile
index 490ed0b98..922fe2e42 100644
--- a/drivers/event/dsw/Makefile
+++ b/drivers/event/dsw/Makefile
@@ -5,7 +5,6 @@ include $(RTE_SDK)/mk/rte.vars.mk
LIB = librte_pmd_dsw_event.a
-CFLAGS += -DALLOW_EXPERIMENTAL_API
CFLAGS += -O3
CFLAGS += $(WERROR_FLAGS)
ifneq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
diff --git a/drivers/event/dsw/meson.build b/drivers/event/dsw/meson.build
index a6b7bfa59..a3d09eef3 100644
--- a/drivers/event/dsw/meson.build
+++ b/drivers/event/dsw/meson.build
@@ -1,6 +1,5 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2018 Ericsson AB
-allow_experimental_apis = true
deps += ['bus_vdev']
sources = files('dsw_evdev.c', 'dsw_event.c', 'dsw_xstats.c')
diff --git a/drivers/event/octeontx/Makefile b/drivers/event/octeontx/Makefile
index 2e07890b9..2c92ccb35 100644
--- a/drivers/event/octeontx/Makefile
+++ b/drivers/event/octeontx/Makefile
@@ -13,7 +13,6 @@ CFLAGS += $(WERROR_FLAGS)
CFLAGS += -I$(RTE_SDK)/drivers/common/octeontx/
CFLAGS += -I$(RTE_SDK)/drivers/mempool/octeontx/
CFLAGS += -I$
Re: [dpdk-dev] [dpdk-stable] [PATCH] app/test: fix missing header
On Fri, Apr 19, 2019 at 02:09:51PM +0200, David Marchand wrote:
>nit: "test/compress:" for the title prefix ?
maybe so, half the time I never know what to prefix autotest stuff like
this with! :-) Thomas, please fix on apply, if possible.
>On Fri, Apr 19, 2019 at 2:03 PM Bruce Richardson
><[1]bruce.richard...@intel.com> wrote:
>
> Build of test_compressdev.c fails on FreeBSD due to the missing
> include of unistd.h, to provide the function usleep.
> Fixes: b06aa643cac4 ("test/compress: add initial unit tests")
> Cc: [2]pablo.de.lara.gua...@intel.com
> Cc: [3]sta...@dpdk.org
> Signed-off-by: Bruce Richardson <[4]bruce.richard...@intel.com>
> ---
> I sent this previously, but I don't think it made the public list,
> so resending.
> Apologies to anyone who gets this twice!
> ---
> app/test/test_compressdev.c | 1 +
> 1 file changed, 1 insertion(+)
> diff --git a/app/test/test_compressdev.c
> b/app/test/test_compressdev.c
> index 404b98f60..121514af5 100644
> --- a/app/test/test_compressdev.c
> +++ b/app/test/test_compressdev.c
> @@ -5,6 +5,7 @@
> #include
> #include
> #include
> +#include
> #include
> #include
> --
> 2.20.1
>
>Tested on FreeBSD 10.4.
>Reviewed-by: David Marchand <[5]david.march...@redhat.com>
>--
>David Marchand
>
Thanks,
/Bruce
Re: [dpdk-dev] [PATCH] test/compress: fix max mbuf size test case
> Moreover I don't know how the pointer of a local variable can be used. That usage is in all test cases in this file - so probably should be fixed first. May be I'm not an expert but what's wrong with usage of a pointer of local variable inside the function? > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Friday, April 19, 2019 1:50 PM > To: Jozwiak, TomaszX > Cc: dev@dpdk.org; Richardson, Bruce ; > david.march...@redhat.com; Trahe, Fiona ; > ys...@mellanox.com; Cel, TomaszX > Subject: Re: [dpdk-dev] [PATCH] test/compress: fix max mbuf size test case > > Please stop top-posting, and read again below: > > 19/04/2019 13:36, Jozwiak, TomaszX: > > test_deflate_comp_decomp function is common for all test cases. > > The options for this function are inside struct interim_data_params, > > which is passed to test_deflate_comp_decomp function as a pointer. > > > > The field buf_idx should be initialized because is used inside > > test_deflate_comp_decomp That's the reason of: > > int_data.buf_idx = &i; > > > > I'm not an author of this solution - sorry. > > > > We can review this and try to add new solution. > > I am not talking about int_data but the use of "i". > Please look again your patch, you are using "j" instead of "i" > and "i" is kept alone. > Moreover I don't know how the pointer of a local variable can be used. > > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > 19/04/2019 12:57, Jozwiak, TomaszX: > > > > > What is supposed to be "i"? > > > > > It is initialized at 0 and never touched. > > > > > > > > > It's touched inside test_deflate_comp_decomp function. > > > > > > What do you mean? > > > It's a local variable and its address is referenced: > > > int_data.buf_idx = &i; > > > It looks really wrong. > > > > > > Another error is seen in FreeBSD. > > > > > > Should I totally revert this patch? > >
Re: [dpdk-dev] [PATCH] net/cxgbe: update Chelsio T5/T6 NIC device ids
On Friday, April 04/19/19, 2019 at 16:48:55 +0530, Ferruh Yigit wrote:
> On 4/19/2019 10:49 AM, Rahul Lakkireddy wrote:
> > Hi Ferruh,
> >
> > On Friday, April 04/19/19, 2019 at 15:00:32 +0530, Ferruh Yigit wrote:
> >> On 4/19/2019 10:22 AM, Rahul Lakkireddy wrote:
> >>> Fixes: 04868e5bfddd ("net/cxgbe: add support to run Chelsio T6 cards")
> >>
> >> Why this is a fix, isn't this just adding new device ids?
> >>
> >>
> >>> Cc: sta...@dpdk.org
> >>
> >> What about keeping 'stable' tag to request the backport but remove the fix?
> >>
> >
> > It's fixing probe for these new devices. Let me know if this particular
> > case doesn't require the fixes line and I will send v2 with only the
> > stable tag.
>
> No need a v2, if you are agree I can remove while merging.
>
> The commit is not fixing any old code in DPDK, if the intention of making this
> patch a fix is to backport the patch, we can do same via stable tag, fix not
> needed.
> If these devices were ready at that time, in 17.08, but forgotten in that
> commit
> to be added, than I see the fix but this looks unlikely since it is almost two
> years ago.
>
Ok, please remove the fixes line during merge.
> >
> >>>
> >>> Signed-off-by: Rahul Lakkireddy
> >>
> >
Thanks,
Rahul
Re: [dpdk-dev] [dpdk-stable] [PATCH v2] kni: fix the type for MAC address
On 4/10/2019 7:20 AM, Jie Pan wrote:
> The type for MAC address should be unsigned.
>
> Fixes: 1cfe212ed17a ("kni: support MAC address change")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Jie Pan
Acked-by: Ferruh Yigit
Re: [dpdk-dev] [PATCH v2] net/cxgbe: fix colliding function names
On 4/19/2019 1:03 PM, Rahul Lakkireddy wrote:
> On Friday, April 04/19/19, 2019 at 17:14:25 +0530, Ferruh Yigit wrote:
>> From: Stephen Hemminger
>>
>> This driver defines lots of functions (like init_rss) which are intended
>> to only be used in this device. But when doing static linking these
>> global functions cause link failures when similar function name is
>> used in application.
>>
>> This patch prefixes all functions defined in cxgbe.h with cxgbe_
>> to avoid these kind of conflicts.
>>
>> Fixes: bfcb257d3014 ("net/cxgbe: enable RSS for VF")
>> Cc: sta...@dpdk.org
>>
>> Signed-off-by: Stephen Hemminger
>> Reviewed-by: Ferruh Yigit
>
> Acked-by: Rahul Lakkireddy
>
Applied to dpdk-next-net/master, thanks.
Re: [dpdk-dev] [PATCH] net/cxgbe: update Chelsio T5/T6 NIC device ids
On 4/19/2019 10:22 AM, Rahul Lakkireddy wrote:
> Fixes: 04868e5bfddd ("net/cxgbe: add support to run Chelsio T6 cards")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Rahul Lakkireddy
Applied to dpdk-next-net/master, thanks.
(Dropped the fixes line while merging)
Re: [dpdk-dev] [PATCH v1 2/2] net/af_xdp: name the umem memzone dynamically
On 4/19/2019 10:47 AM, David Marchand wrote:
> On Thu, Apr 18, 2019 at 5:27 PM Xiaolong Ye wrote:
>
>> Naming the umem memzone dynamically allows to create multiple af_xdp vdevs.
>>
>> Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD")
>>
>> Reported-by: Markus Theil
>> Signed-off-by: Xiaolong Ye
>> ---
>> drivers/net/af_xdp/rte_eth_af_xdp.c | 5 -
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c
>> b/drivers/net/af_xdp/rte_eth_af_xdp.c
>> index d8e99204e..666b4c17e 100644
>> --- a/drivers/net/af_xdp/rte_eth_af_xdp.c
>> +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c
>> @@ -483,6 +483,7 @@ xsk_umem_info *xdp_umem_configure(struct pmd_internals
>> *internals)
>> .frame_size = ETH_AF_XDP_FRAME_SIZE,
>> .frame_headroom = ETH_AF_XDP_DATA_HEADROOM };
>> char ring_name[RTE_RING_NAMESIZE];
>> + char mz_name[RTE_MEMZONE_NAMESIZE];
>> int ret;
>> uint64_t i;
>>
>> @@ -508,7 +509,9 @@ xsk_umem_info *xdp_umem_configure(struct pmd_internals
>> *internals)
>> (void *)(i * ETH_AF_XDP_FRAME_SIZE +
>> ETH_AF_XDP_DATA_HEADROOM));
>>
>> - mz = rte_memzone_reserve_aligned("af_xdp uemem",
>> + ret = snprintf(mz_name, sizeof(mz_name), "af_xdp_umem_%s_%d",
>> + internals->if_name, internals->queue_idx);
>>
>
> Idem previous patch.
>
> + mz = rte_memzone_reserve_aligned(mz_name,
>> ETH_AF_XDP_NUM_BUFFERS * ETH_AF_XDP_FRAME_SIZE,
>> rte_socket_id(), RTE_MEMZONE_IOVA_CONTIG,
>> getpagesize());
>> --
>> 2.17.1
>>
>>
> How about squashing those two patches as a single one ?
> The issue is that you can't create multiple devices. Having the first one
> still leaves the issue.
>
+1 to squash. let me make a new version applying minor issues you pointed in
other patch, squashing both and keeping your review tag.
>
> Reviewed-by: David Marchand
>
Re: [dpdk-dev] [PATCH] devtools/test-meson-builds: fix support for plain bourne shell
On Fri, 2019-04-19 at 13:04 +0100, Bruce Richardson wrote: > The pipefail option is not supported in /bin/sh, just in bash/ksh and > similar shells - which means it's there by default on most Linux > distros > but not on e.g. FreeBSD. Therefore we check for it's presence before > setting the option, and if it's missing, we upgrade verbosity level > if > needed to ensure we never hide any build failures. > > Signed-off-by: Bruce Richardson < > bruce.richard...@intel.com > > > --- > This patch is a replacement for the previous patch: "fix support for > FreeBSD" [1], which was an incorrect/incomplete fix. > > [1] > http://patches.dpdk.org/patch/52468/ > > --- > devtools/test-meson-builds.sh | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) Acked-by: Luca Boccassi -- Kind regards, Luca Boccassi
[dpdk-dev] [PATCH v2] net/af_xdp: fix creating multiple instance
From: Xiaolong Ye
Naming the buf_ring and umem memzone dynamically allows
to create multiple af_xdp vdevs.
Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD")
Reported-by: Markus Theil
Signed-off-by: Xiaolong Ye
Reviewed-by: David Marchand
---
v2:
* squashed buf_ring & memzone patches
* removed unused return value
* changed format specifier to unsigned
---
drivers/net/af_xdp/rte_eth_af_xdp.c | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c
b/drivers/net/af_xdp/rte_eth_af_xdp.c
index 497e2cfde..acf9ad605 100644
--- a/drivers/net/af_xdp/rte_eth_af_xdp.c
+++ b/drivers/net/af_xdp/rte_eth_af_xdp.c
@@ -473,7 +473,7 @@ xdp_umem_destroy(struct xsk_umem_info *umem)
}
static struct
-xsk_umem_info *xdp_umem_configure(void)
+xsk_umem_info *xdp_umem_configure(struct pmd_internals *internals)
{
struct xsk_umem_info *umem;
const struct rte_memzone *mz;
@@ -482,6 +482,8 @@ xsk_umem_info *xdp_umem_configure(void)
.comp_size = ETH_AF_XDP_DFLT_NUM_DESCS,
.frame_size = ETH_AF_XDP_FRAME_SIZE,
.frame_headroom = ETH_AF_XDP_DATA_HEADROOM };
+ char ring_name[RTE_RING_NAMESIZE];
+ char mz_name[RTE_MEMZONE_NAMESIZE];
int ret;
uint64_t i;
@@ -491,7 +493,9 @@ xsk_umem_info *xdp_umem_configure(void)
return NULL;
}
- umem->buf_ring = rte_ring_create("af_xdp_ring",
+ snprintf(ring_name, sizeof(ring_name), "af_xdp_ring_%s_%u",
+ internals->if_name, internals->queue_idx);
+ umem->buf_ring = rte_ring_create(ring_name,
ETH_AF_XDP_NUM_BUFFERS,
rte_socket_id(),
0x0);
@@ -505,7 +509,9 @@ xsk_umem_info *xdp_umem_configure(void)
(void *)(i * ETH_AF_XDP_FRAME_SIZE +
ETH_AF_XDP_DATA_HEADROOM));
- mz = rte_memzone_reserve_aligned("af_xdp uemem",
+ snprintf(mz_name, sizeof(mz_name), "af_xdp_umem_%s_%u",
+ internals->if_name, internals->queue_idx);
+ mz = rte_memzone_reserve_aligned(mz_name,
ETH_AF_XDP_NUM_BUFFERS * ETH_AF_XDP_FRAME_SIZE,
rte_socket_id(), RTE_MEMZONE_IOVA_CONTIG,
getpagesize());
@@ -541,7 +547,7 @@ xsk_configure(struct pmd_internals *internals, struct
pkt_rx_queue *rxq,
int ret = 0;
int reserve_size;
- rxq->umem = xdp_umem_configure();
+ rxq->umem = xdp_umem_configure(internals);
if (rxq->umem == NULL)
return -ENOMEM;
--
2.20.1
Re: [dpdk-dev] [PATCH v2] net/af_xdp: fix creating multiple instance
On 4/19/2019 1:47 PM, Ferruh Yigit wrote:
> From: Xiaolong Ye
>
> Naming the buf_ring and umem memzone dynamically allows
> to create multiple af_xdp vdevs.
>
> Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD")
>
> Reported-by: Markus Theil
> Signed-off-by: Xiaolong Ye
> Reviewed-by: David Marchand
Applied to dpdk-next-net/master, thanks.
Re: [dpdk-dev] [PATCH v1 2/2] net/af_xdp: name the umem memzone dynamically
On 04/19, Ferruh Yigit wrote:
>On 4/19/2019 10:47 AM, David Marchand wrote:
>> On Thu, Apr 18, 2019 at 5:27 PM Xiaolong Ye wrote:
>>
>>> Naming the umem memzone dynamically allows to create multiple af_xdp vdevs.
>>>
>>> Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD")
>>>
>>> Reported-by: Markus Theil
>>> Signed-off-by: Xiaolong Ye
>>> ---
>>> drivers/net/af_xdp/rte_eth_af_xdp.c | 5 -
>>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c
>>> b/drivers/net/af_xdp/rte_eth_af_xdp.c
>>> index d8e99204e..666b4c17e 100644
>>> --- a/drivers/net/af_xdp/rte_eth_af_xdp.c
>>> +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c
>>> @@ -483,6 +483,7 @@ xsk_umem_info *xdp_umem_configure(struct pmd_internals
>>> *internals)
>>> .frame_size = ETH_AF_XDP_FRAME_SIZE,
>>> .frame_headroom = ETH_AF_XDP_DATA_HEADROOM };
>>> char ring_name[RTE_RING_NAMESIZE];
>>> + char mz_name[RTE_MEMZONE_NAMESIZE];
>>> int ret;
>>> uint64_t i;
>>>
>>> @@ -508,7 +509,9 @@ xsk_umem_info *xdp_umem_configure(struct pmd_internals
>>> *internals)
>>> (void *)(i * ETH_AF_XDP_FRAME_SIZE +
>>> ETH_AF_XDP_DATA_HEADROOM));
>>>
>>> - mz = rte_memzone_reserve_aligned("af_xdp uemem",
>>> + ret = snprintf(mz_name, sizeof(mz_name), "af_xdp_umem_%s_%d",
>>> + internals->if_name, internals->queue_idx);
>>>
>>
>> Idem previous patch.
>>
>> + mz = rte_memzone_reserve_aligned(mz_name,
>>> ETH_AF_XDP_NUM_BUFFERS * ETH_AF_XDP_FRAME_SIZE,
>>> rte_socket_id(), RTE_MEMZONE_IOVA_CONTIG,
>>> getpagesize());
>>> --
>>> 2.17.1
>>>
>>>
>> How about squashing those two patches as a single one ?
>> The issue is that you can't create multiple devices. Having the first one
>> still leaves the issue.
>>
>
>+1 to squash. let me make a new version applying minor issues you pointed in
>other patch, squashing both and keeping your review tag.
Thanks for doing the new patch.
>
>>
>> Reviewed-by: David Marchand
>>
>
Re: [dpdk-dev] [dpdk-stable] [PATCH v2] kni: fix the type for MAC address
On 4/10/2019 7:20 AM, Jie Pan wrote:
> The type for MAC address should be unsigned.
>
> Fixes: 1cfe212ed17a ("kni: support MAC address change")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Jie Pan
Acked-by: Ferruh Yigit
Reviewed-by: Rami Rosen
Re: [dpdk-dev] [dpdk-stable] [PATCH] net/tap: ipc add check for number of messages received
On 4/18/2019 7:13, Ferruh Yigit worte:
> On 4/18/2019 6:19 PM, Herakliusz Lipiec wrote:
> > A sucessfull call to rte_mp_request_sync does not guarantee that there
> > are valid messages in the buffer, and this should be checked for
> > before accessing data in the message.
> >
> > Fixes: c9aa56edec8e ("net/tap: access primary process queues from
> > secondary")
> > Cc: rasl...@mellanox.com
> > Cc: sta...@dpdk.org
> > Signed-off-by: Herakliusz Lipiec
> > ---
> > drivers/net/tap/rte_eth_tap.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/tap/rte_eth_tap.c
> > b/drivers/net/tap/rte_eth_tap.c index e9fda8cf6..a619a8850 100644
> > --- a/drivers/net/tap/rte_eth_tap.c
> > +++ b/drivers/net/tap/rte_eth_tap.c
> > @@ -2101,7 +2101,7 @@ tap_mp_attach_queues(const char *port_name,
> struct rte_eth_dev *dev)
> > request.len_param = sizeof(*request_param);
> > /* Send request and receive reply */
> > ret = rte_mp_request_sync(&request, &replies, &timeout);
> > - if (ret < 0) {
> > + if (ret < 0 || replies.n_receieved != 1) {
>
> The API documentation says:
>
> || * @return
>
>
>
> || * - On success, return 0.
>
>
>
> || * - On failure, return -1, and the reason will be stored in rte_errno.
>
> So if the API returns 0, why the reply is not valid, also if reply is not
> valid how
> can you rely on a value in 'replies'
>
> What do you think updating the 'rte_mp_request_sync()' API to return error
> whenever the reply is not valid?
The reply is not valid, because there is no valid msg pointer in replies.msg
(should be null)
replies.nb_received should be either 0 (if replies carries no message) or 1 (if
there is a message).
There are two other code paths that can return a success, but have no (valid)
message.
In rte_mp_request_sync there is a call to mp_request_sync which may return 0
with no message in case of:
- failure to send the message on behalf of remote
- the caller not caring about reply message.
I propose to add a check for nb_received to net/tap since this seems to be done
in everywhere
else when rte_mp_request_sync is called (this will do no harm), and also I
think that return codes should be fixed,
but that can be done irrelevant of this.
[dpdk-dev] [PATCH v3] test/compress: fix max mbuf size test case
Fixed the compilation error:
../app/test/test_compressdev.c:1949:11: note: previous
definition of 'i' was here
../app/test/test_compressdev.c:1992:2: error: 'for' loop
initial declarations are only allowed in C99 mode
../app/test/test_compressdev.c:1992:2: note: use option
-std=c99 or -std=gnu99 to compile your code
../app/test/test_compressdev.c:1996:19: warning: assignment
from incompatible pointer type [enabled by default]
Fixes: 355b02eedc65 ("test/compress: add max mbuf size test case")
Signed-off-by: Tomasz Jozwiak
Signed-off-by: Fiona Trahe
---
v3 changes:
- moved idx variable to improve code clarity and consistency
with other tests
v2 changes:
- added compile error to commit msg
app/test/test_compressdev.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/app/test/test_compressdev.c b/app/test/test_compressdev.c
index 404b98f60..8d6dbf00d 100644
--- a/app/test/test_compressdev.c
+++ b/app/test/test_compressdev.c
@@ -1948,6 +1948,7 @@ test_compressdev_deflate_stateless_dynamic_big(void)
struct comp_testsuite_params *ts_params = &testsuite_params;
uint16_t i = 0;
int ret = TEST_SUCCESS;
+ int j;
const struct rte_compressdev_capabilities *capab;
char *test_buffer = NULL;
@@ -1970,7 +1971,7 @@ test_compressdev_deflate_stateless_dynamic_big(void)
struct interim_data_params int_data = {
(const char * const *)&test_buffer,
1,
- NULL,
+ &i,
&ts_params->def_comp_xform,
&ts_params->def_decomp_xform,
1
@@ -1989,11 +1990,9 @@ test_compressdev_deflate_stateless_dynamic_big(void)
/* fill the buffer with data based on rand. data */
srand(BIG_DATA_TEST_SIZE);
- for (uint32_t i = 0; i < BIG_DATA_TEST_SIZE - 1; ++i)
- test_buffer[i] = (uint8_t)(rand() % ((uint8_t)-1)) | 1;
-
+ for (j = 0; j < BIG_DATA_TEST_SIZE - 1; ++j)
+ test_buffer[j] = (uint8_t)(rand() % ((uint8_t)-1)) | 1;
test_buffer[BIG_DATA_TEST_SIZE-1] = 0;
- int_data.buf_idx = &i;
/* Compress with compressdev, decompress with Zlib */
test_data.zlib_dir = ZLIB_DECOMPRESS;
--
2.13.6
[dpdk-dev] [Bug 257] ipc: rte_mp_request_sync return 0 on error.
https://bugs.dpdk.org/show_bug.cgi?id=257 Bug ID: 257 Summary: ipc: rte_mp_request_sync return 0 on error. Product: DPDK Version: 18.11 Hardware: All OS: All Status: CONFIRMED Severity: normal Priority: Normal Component: core Assignee: dev@dpdk.org Reporter: herakliusz.lip...@intel.com Target Milestone: --- API can return success (0), but reply buffer might be invalid. There are three code paths that can return a success, but have no (valid) message. In case of two I think it should be a failure. In rte_mp_request_sync there is a call to mp_request_sync which may return 0 with no message in case of: - failure to send the message on behalf of remote - the caller not caring about reply message. (this is probably fine) This is then returned as 0 by rte_mp_request_sync (docs say that it will return 0 on success). If IPC is disabled rte_mp_request_sync also return 0, but i think it should be a failure (it did not send anything, it did not received anything because operation is not supported). -- You are receiving this mail because: You are the assignee for the bug.
Re: [dpdk-dev] [PATCH] test/compress: fix max mbuf size test case
Hi Thomas et al, > -Original Message- > From: Jozwiak, TomaszX > Sent: Friday, April 19, 2019 1:14 PM > To: Thomas Monjalon > Cc: dev@dpdk.org; Richardson, Bruce ; > david.march...@redhat.com; > Trahe, Fiona ; ys...@mellanox.com; Cel, TomaszX > > Subject: RE: [dpdk-dev] [PATCH] test/compress: fix max mbuf size test case [Fiona] Sorry for all the hassle. I've reviewed the related code and fix. In my opinion the original fix was ok to resolve the compile issue, which we missed due to using a different compiler version and also missed spotting in code review. We'll be more careful in future. I've sent a v3 with a small tweak to help the code clarity. This is consistent with a bunch of other tests in same file.
Re: [dpdk-dev] [dpdk-stable] [PATCH] net/tap: ipc add check for number of messages received
On 4/19/2019 5:39 PM, Lipiec, Herakliusz wrote:
> On 4/18/2019 7:13, Ferruh Yigit worte:
>> On 4/18/2019 6:19 PM, Herakliusz Lipiec wrote:
>>> A sucessfull call to rte_mp_request_sync does not guarantee that there
>>> are valid messages in the buffer, and this should be checked for
>>> before accessing data in the message.
>>>
>>> Fixes: c9aa56edec8e ("net/tap: access primary process queues from
>>> secondary")
>>> Cc: rasl...@mellanox.com
>>> Cc: sta...@dpdk.org
>>> Signed-off-by: Herakliusz Lipiec
>>> ---
>>> drivers/net/tap/rte_eth_tap.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/tap/rte_eth_tap.c
>>> b/drivers/net/tap/rte_eth_tap.c index e9fda8cf6..a619a8850 100644
>>> --- a/drivers/net/tap/rte_eth_tap.c
>>> +++ b/drivers/net/tap/rte_eth_tap.c
>>> @@ -2101,7 +2101,7 @@ tap_mp_attach_queues(const char *port_name,
>> struct rte_eth_dev *dev)
>>> request.len_param = sizeof(*request_param);
>>> /* Send request and receive reply */
>>> ret = rte_mp_request_sync(&request, &replies, &timeout);
>>> - if (ret < 0) {
>>> + if (ret < 0 || replies.n_receieved != 1) {
>>
>> The API documentation says:
>>
>> || * @return
>>
>>
>>
>> || * - On success, return 0.
>>
>>
>>
>> || * - On failure, return -1, and the reason will be stored in rte_errno.
>>
>> So if the API returns 0, why the reply is not valid, also if reply is not
>> valid how
>> can you rely on a value in 'replies'
>>
>> What do you think updating the 'rte_mp_request_sync()' API to return error
>> whenever the reply is not valid?
> The reply is not valid, because there is no valid msg pointer in replies.msg
> (should be null)
> replies.nb_received should be either 0 (if replies carries no message) or 1
> (if there is a message).
>
> There are two other code paths that can return a success, but have no (valid)
> message.
> In rte_mp_request_sync there is a call to mp_request_sync which may return 0
> with no message in case of:
> - failure to send the message on behalf of remote
> - the caller not caring about reply message.
> I propose to add a check for nb_received to net/tap since this seems to be
> done in everywhere
> else when rte_mp_request_sync is called (this will do no harm), and also I
> think that return codes should be fixed,
> but that can be done irrelevant of this.
>
I see, "replies.nb_received" can be relied on since it is set in the begging of
the 'rte_mp_request_sync()'
And I can see you have created a defect for the API fix [1], it is OK to get tap
fix for rc2, but for next release it would be appreciated if you own the defect
you have submitted.
Thanks,
ferruh
[1]
https://bugs.dpdk.org/show_bug.cgi?id=257
Re: [dpdk-dev] [PATCH v2] net/tap: ipc add check for number of messages received
On 4/19/2019 11:28 AM, Herakliusz Lipiec wrote:
> A sucessfull call to rte_mp_request_sync does not guarantee that there
> are any messages in the buffer, and this should be checked for before
> accessing data in the message. Buffer can be empty if IPC is disabled or
> if we deciede to ignore replies.
>
> Fixes: c9aa56edec8e ("net/tap: access primary process queues from secondary")
> Cc: rasl...@mellanox.com
> Cc: sta...@dpdk.org
> Signed-off-by: Herakliusz Lipiec
Reviewed-by: Ferruh Yigit
Applied to dpdk-next-net/master, thanks.
(https://bugs.dpdk.org/show_bug.cgi?id=257 created for the API)
Re: [dpdk-dev] [PATCH] mbuf: update Tx VLAN and QinQ mbuf flags documentation
08/04/2019 09:16, Olivier Matz:
> On Tue, Apr 02, 2019 at 06:09:46PM +0100, Ferruh Yigit wrote:
> > Currently PKT_TX_VLAN and PKT_TX_QINQ mbuf flags are documented as
> > they are to say packet contains VLAN or QINQ information.
> >
> > Updating the definition as they are requests from application to
> > driver to insert VLAN or double VLAN tags into packet.
> >
> > Fixes: dc6c911c9993 ("mbuf: use reserved space for double vlan")
> > Fixes: af75078fece3 ("first public release")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Ferruh Yigit
>
> Acked-by: Olivier Matz
Applied, thanks
Re: [dpdk-dev] [dpdk-stable] [PATCH v2] kni: fix the type for MAC address
19/04/2019 17:29, Rami Rosen:
> On 4/10/2019 7:20 AM, Jie Pan wrote:
> > The type for MAC address should be unsigned.
> >
> > Fixes: 1cfe212ed17a ("kni: support MAC address change")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Jie Pan
>
> Acked-by: Ferruh Yigit
>
> Reviewed-by: Rami Rosen
Applied, thanks
Re: [dpdk-dev] [PATCH v3] test/compress: fix max mbuf size test case
19/04/2019 18:52, Fiona Trahe:
> Fixed the compilation error:
>
> ../app/test/test_compressdev.c:1949:11: note: previous
> definition of 'i' was here
>
> ../app/test/test_compressdev.c:1992:2: error: 'for' loop
> initial declarations are only allowed in C99 mode
>
> ../app/test/test_compressdev.c:1992:2: note: use option
> -std=c99 or -std=gnu99 to compile your code
>
> ../app/test/test_compressdev.c:1996:19: warning: assignment
> from incompatible pointer type [enabled by default]
>
> Fixes: 355b02eedc65 ("test/compress: add max mbuf size test case")
>
> Signed-off-by: Tomasz Jozwiak
> Signed-off-by: Fiona Trahe
> ---
> v3 changes:
> - moved idx variable to improve code clarity and consistency
>with other tests
>
> v2 changes:
> - added compile error to commit msg
Applied, thanks
Re: [dpdk-dev] [dpdk-stable] [PATCH] app/test: fix missing header
19/04/2019 14:12, Bruce Richardson:
> On Fri, Apr 19, 2019 at 02:09:51PM +0200, David Marchand wrote:
> >nit: "test/compress:" for the title prefix ?
>
> maybe so, half the time I never know what to prefix autotest stuff like
> this with! :-) Thomas, please fix on apply, if possible.
In this case, you can just copy the prefix from the "Fixes:" line :)
> >On Fri, Apr 19, 2019 at 2:03 PM Bruce Richardson
> ><[1]bruce.richard...@intel.com> wrote:
> >
> > Build of test_compressdev.c fails on FreeBSD due to the missing
> > include of unistd.h, to provide the function usleep.
> > Fixes: b06aa643cac4 ("test/compress: add initial unit tests")
> > Cc: [2]pablo.de.lara.gua...@intel.com
> > Cc: [3]sta...@dpdk.org
> > Signed-off-by: Bruce Richardson <[4]bruce.richard...@intel.com>
> >
> >Tested on FreeBSD 10.4.
> >Reviewed-by: David Marchand <[5]david.march...@redhat.com>
Applied, thanks
Re: [dpdk-dev] [PATCH] devtools/test-meson-builds: fix support for plain bourne shell
19/04/2019 14:42, Luca Boccassi: > On Fri, 2019-04-19 at 13:04 +0100, Bruce Richardson wrote: > > The pipefail option is not supported in /bin/sh, just in bash/ksh and > > similar shells - which means it's there by default on most Linux > > distros > > but not on e.g. FreeBSD. Therefore we check for it's presence before > > setting the option, and if it's missing, we upgrade verbosity level > > if > > needed to ensure we never hide any build failures. > > > > Signed-off-by: Bruce Richardson < > > bruce.richard...@intel.com > > > > > --- > > This patch is a replacement for the previous patch: "fix support for > > FreeBSD" [1], which was an incorrect/incomplete fix. > > > > [1] > > http://patches.dpdk.org/patch/52468/ > > > > --- > > devtools/test-meson-builds.sh | 9 - > > 1 file changed, 8 insertions(+), 1 deletion(-) > > Acked-by: Luca Boccassi Looks good. Applied, thanks
[dpdk-dev] [RFC v2 0/2] Pseudo-number generation improvements
Make rte_rand() multi-thread safe, go faster and produce better-quality pseudo-random numbers. v2: * Removed 32-bit version of rte_rand() and rte_rand_max(). * Switched from a four-sequence LFSR (producing a 32-bit number) to a five-sequence LFSR (producing a 64-bit number). * Added a note on generator not being cryptographically secure. Mattias Rönnblom (2): eal: replace libc-based random number generation with LFSR eal: introduce random generator function with upper bound lib/librte_eal/common/include/rte_random.h | 45 +++--- lib/librte_eal/common/meson.build | 1 + lib/librte_eal/common/rte_random.c | 157 + lib/librte_eal/freebsd/eal/Makefile| 1 + lib/librte_eal/freebsd/eal/eal.c | 2 - lib/librte_eal/linux/eal/Makefile | 1 + lib/librte_eal/linux/eal/eal.c | 2 - lib/librte_eal/rte_eal_version.map | 3 + 8 files changed, 190 insertions(+), 22 deletions(-) create mode 100644 lib/librte_eal/common/rte_random.c -- 2.17.1
[dpdk-dev] [RFC v2 1/2] eal: replace libc-based random number generation with LFSR
This commit replaces rte_rand()'s use of lrand48() with a DPDK-native
combined Linear Feedback Shift Register (LFSR) (also known as
Tausworthe) pseudo-number generator, with five sequences.
This generator is faster and produces better quality random numbers
than libc's lrand48() implementation. This implementation, as opposed
to lrand48(), is multi-thread safe in regards to concurrent rte_rand()
calls from different lcore threads. It is not cryptographically
secure - just like lrand48().
Signed-off-by: Mattias Rönnblom
---
lib/librte_eal/common/include/rte_random.h | 29 ++---
lib/librte_eal/common/meson.build | 1 +
lib/librte_eal/common/rte_random.c | 137 +
lib/librte_eal/freebsd/eal/Makefile| 1 +
lib/librte_eal/freebsd/eal/eal.c | 2 -
lib/librte_eal/linux/eal/Makefile | 1 +
lib/librte_eal/linux/eal/eal.c | 2 -
lib/librte_eal/rte_eal_version.map | 2 +
8 files changed, 153 insertions(+), 22 deletions(-)
create mode 100644 lib/librte_eal/common/rte_random.c
diff --git a/lib/librte_eal/common/include/rte_random.h
b/lib/librte_eal/common/include/rte_random.h
index b2ca1c209..66dfe8ae7 100644
--- a/lib/librte_eal/common/include/rte_random.h
+++ b/lib/librte_eal/common/include/rte_random.h
@@ -16,7 +16,6 @@ extern "C" {
#endif
#include
-#include
/**
* Seed the pseudo-random generator.
@@ -25,34 +24,28 @@ extern "C" {
* value. It may need to be re-seeded by the user with a real random
* value.
*
+ * This function is not multi-thread safe in regards to other
+ * rte_srand() calls, nor is it in relation to concurrent rte_rand()
+ * calls.
+ *
* @param seedval
* The value of the seed.
*/
-static inline void
-rte_srand(uint64_t seedval)
-{
- srand48((long)seedval);
-}
+void
+rte_srand(uint64_t seedval);
/**
* Get a pseudo-random value.
*
- * This function generates pseudo-random numbers using the linear
- * congruential algorithm and 48-bit integer arithmetic, called twice
- * to generate a 64-bit value.
+ * The generator is not cryptographically secure.
+ *
+ * If called from lcore threads, this function is thread-safe.
*
* @return
* A pseudo-random value between 0 and (1<<64)-1.
*/
-static inline uint64_t
-rte_rand(void)
-{
- uint64_t val;
- val = (uint64_t)lrand48();
- val <<= 32;
- val += (uint64_t)lrand48();
- return val;
-}
+uint64_t
+rte_rand(void);
#ifdef __cplusplus
}
diff --git a/lib/librte_eal/common/meson.build
b/lib/librte_eal/common/meson.build
index 0670e4102..bafd23207 100644
--- a/lib/librte_eal/common/meson.build
+++ b/lib/librte_eal/common/meson.build
@@ -35,6 +35,7 @@ common_sources = files(
'rte_keepalive.c',
'rte_malloc.c',
'rte_option.c',
+ 'rte_random.c',
'rte_reciprocal.c',
'rte_service.c'
)
diff --git a/lib/librte_eal/common/rte_random.c
b/lib/librte_eal/common/rte_random.c
new file mode 100644
index 0..288e7b8c5
--- /dev/null
+++ b/lib/librte_eal/common/rte_random.c
@@ -0,0 +1,137 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2019 Ericsson AB
+ */
+
+#include
+
+#include
+#include
+#include
+#include
+
+struct rte_rand_state {
+ uint64_t z1;
+ uint64_t z2;
+ uint64_t z3;
+ uint64_t z4;
+ uint64_t z5;
+} __rte_cache_aligned;
+
+static struct rte_rand_state rand_states[RTE_MAX_LCORE];
+
+static uint32_t
+__rte_rand_lcg32(uint32_t *seed)
+{
+ *seed = 1103515245U * *seed + 12345U;
+
+ return *seed;
+}
+
+static uint64_t
+__rte_rand_lcg64(uint32_t *seed)
+{
+ uint64_t low;
+ uint64_t high;
+
+ /* A 64-bit LCG would have been much cleaner, but well-known
+* good multiplier/increments seem hard to come by.
+*/
+
+ low = __rte_rand_lcg32(seed);
+ high = __rte_rand_lcg32(seed);
+
+ return low | (high << 32);
+}
+
+static uint64_t
+__rte_rand_lfsr258_gen_seed(uint32_t *seed, uint64_t min_value)
+{
+ uint64_t res;
+
+ res = __rte_rand_lcg64(seed);
+
+ if (res < min_value)
+ res += min_value;
+
+ return res;
+}
+
+static void
+__rte_srand_lfsr258(uint64_t seed, struct rte_rand_state *state)
+{
+ uint32_t lcg_seed;
+
+ lcg_seed = (uint32_t)(seed ^ (seed >> 32));
+
+ state->z1 = __rte_rand_lfsr258_gen_seed(&lcg_seed, 2UL);
+ state->z2 = __rte_rand_lfsr258_gen_seed(&lcg_seed, 512UL);
+ state->z3 = __rte_rand_lfsr258_gen_seed(&lcg_seed, 4096UL);
+ state->z4 = __rte_rand_lfsr258_gen_seed(&lcg_seed, 131072UL);
+ state->z5 = __rte_rand_lfsr258_gen_seed(&lcg_seed, 8388608UL);
+}
+
+void __rte_experimental
+rte_srand(uint64_t seed)
+{
+ unsigned int lcore_id;
+
+ /* add lcore_id to seed to avoid having the same sequence */
+ for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++)
+ __rte_srand_lfsr258(seed + lcore_id, &rand_states[lcore_id])
[dpdk-dev] [RFC v2 2/2] eal: introduce random generator function with upper bound
Add a function rte_rand_max() which generates an uniformly distributed
pseudo-random number less than a user-specified upper bound.
The commonly used pattern rte_rand() % SOME_VALUE, in addition to
being slow, also creates biased results if SOME_VALUE is not a power
of 2. This bias is very small for small SOME_VALUE, but increases
linearly with larger SOME_VALUE.
Signed-off-by: Mattias Rönnblom
---
lib/librte_eal/common/include/rte_random.h | 16
lib/librte_eal/common/rte_random.c | 20
lib/librte_eal/rte_eal_version.map | 1 +
3 files changed, 37 insertions(+)
diff --git a/lib/librte_eal/common/include/rte_random.h
b/lib/librte_eal/common/include/rte_random.h
index 66dfe8ae7..053912168 100644
--- a/lib/librte_eal/common/include/rte_random.h
+++ b/lib/librte_eal/common/include/rte_random.h
@@ -47,6 +47,22 @@ rte_srand(uint64_t seedval);
uint64_t
rte_rand(void);
+/**
+ * Generates a pseudo-random number less than upper_bound.
+ *
+ * This function returns an uniformly distributed (unbiased) random
+ * number lower than a user-specified maximum value.
+ *
+ * If called from lcore threads, this function is thread-safe.
+ *
+ * @param upper_bound
+ * The upper bound of the generated number.
+ * @return
+ * A pseudo-random value between 0 and (upper_bound-1).
+ */
+uint64_t
+rte_rand_max(uint64_t upper_bound);
+
#ifdef __cplusplus
}
#endif
diff --git a/lib/librte_eal/common/rte_random.c
b/lib/librte_eal/common/rte_random.c
index 288e7b8c5..bf9240470 100644
--- a/lib/librte_eal/common/rte_random.c
+++ b/lib/librte_eal/common/rte_random.c
@@ -131,6 +131,26 @@ rte_rand(void)
return __rte_rand_lfsr258(state);
}
+uint64_t __rte_experimental
+rte_rand_max(uint64_t upper_bound)
+{
+ uint8_t zeros;
+ uint64_t mask = ~((uint64_t)0);
+ uint64_t res;
+
+ if (upper_bound < 2)
+ return 0;
+
+ zeros = __builtin_clzll(upper_bound);
+ mask >>= zeros;
+
+ do {
+ res = rte_rand() & mask;
+ } while (unlikely(res >= upper_bound));
+
+ return res;
+}
+
RTE_INIT(rte_rand_init)
{
rte_srand(rte_get_timer_cycles());
diff --git a/lib/librte_eal/rte_eal_version.map
b/lib/librte_eal/rte_eal_version.map
index 0d60668fa..8f5b8c6a6 100644
--- a/lib/librte_eal/rte_eal_version.map
+++ b/lib/librte_eal/rte_eal_version.map
@@ -367,6 +367,7 @@ EXPERIMENTAL {
rte_mp_sendmsg;
rte_option_register;
rte_rand;
+ rte_rand_max;
rte_realloc_socket;
rte_service_lcore_attr_get;
rte_service_lcore_attr_reset_all;
--
2.17.1
[dpdk-dev] [PATCH] net/mlx5: fix Direct Rules build
All the library calls must be called via the glue layer.
Fixes: b2177648b8de ("net/mlx5: add Direct Rules flow data alloc/free routines")
Fixes: 79e35d0d5979 ("net/mlx5: share Direct Rules/Verbs flow related
structures")
Cc: viachesl...@mellanox.com
Signed-off-by: Yongseok Koh
---
drivers/net/mlx5/mlx5.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index 65c69afe5a..08ed678d0d 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -332,14 +332,16 @@ mlx5_alloc_shared_dr(struct mlx5_priv *priv)
return 0;
}
/* Reference counter is zero, we should initialize structures. */
- ns = mlx5dv_dr_create_ns(sh->ctx, MLX5DV_DR_NS_DOMAIN_INGRESS_BYPASS);
+ ns = mlx5_glue->dr_create_ns(sh->ctx,
+MLX5DV_DR_NS_DOMAIN_INGRESS_BYPASS);
if (!ns) {
DRV_LOG(ERR, "ingress mlx5dv_dr_create_ns failed");
err = errno;
goto error;
}
sh->rx_ns = ns;
- ns = mlx5dv_dr_create_ns(sh->ctx, MLX5DV_DR_NS_DOMAIN_EGRESS_BYPASS);
+ ns = mlx5_glue->dr_create_ns(sh->ctx,
+MLX5DV_DR_NS_DOMAIN_EGRESS_BYPASS);
if (!ns) {
DRV_LOG(ERR, "egress mlx5dv_dr_create_ns failed");
err = errno;
@@ -367,11 +369,11 @@ mlx5_alloc_shared_dr(struct mlx5_priv *priv)
error:
/* Rollback the created objects. */
if (sh->rx_ns) {
- mlx5dv_dr_destroy_ns(sh->rx_ns);
+ mlx5_glue->dr_destroy_ns(sh->rx_ns);
sh->rx_ns = NULL;
}
if (sh->tx_ns) {
- mlx5dv_dr_destroy_ns(sh->tx_ns);
+ mlx5_glue->dr_destroy_ns(sh->tx_ns);
sh->tx_ns = NULL;
}
if (sh->fdb_ns) {
@@ -410,11 +412,11 @@ mlx5_free_shared_dr(struct mlx5_priv *priv)
if (sh->dv_refcnt && --sh->dv_refcnt)
return;
if (sh->rx_ns) {
- mlx5dv_dr_destroy_ns(sh->rx_ns);
+ mlx5_glue->dr_destroy_ns(sh->rx_ns);
sh->rx_ns = NULL;
}
if (sh->tx_ns) {
- mlx5dv_dr_destroy_ns(sh->tx_ns);
+ mlx5_glue->dr_destroy_ns(sh->tx_ns);
sh->tx_ns = NULL;
}
#ifdef HAVE_MLX5DV_DR_ESWITCH
--
2.11.0
