19/04/2019 14:42, Luca Boccassi: > On Fri, 2019-04-19 at 13:04 +0100, Bruce Richardson wrote: > > The pipefail option is not supported in /bin/sh, just in bash/ksh and > > similar shells - which means it's there by default on most Linux > > distros > > but not on e.g. FreeBSD. Therefore we check for it's presence before > > setting the option, and if it's missing, we upgrade verbosity level > > if > > needed to ensure we never hide any build failures. > > > > Signed-off-by: Bruce Richardson < > > bruce.richard...@intel.com > > > > > --- > > This patch is a replacement for the previous patch: "fix support for > > FreeBSD" [1], which was an incorrect/incomplete fix. > > > > [1] > > http://patches.dpdk.org/patch/52468/ > > > > --- > > devtools/test-meson-builds.sh | 9 ++++++++- > > 1 file changed, 8 insertions(+), 1 deletion(-) > > Acked-by: Luca Boccassi <bl...@debian.org>
Looks good. Applied, thanks