Please stop top-posting, and read again below: 19/04/2019 13:36, Jozwiak, TomaszX: > test_deflate_comp_decomp function is common for all test cases. > The options for this function are inside struct interim_data_params, > which is passed to test_deflate_comp_decomp function as a pointer. > > The field buf_idx should be initialized because is used inside > test_deflate_comp_decomp > That's the reason of: > int_data.buf_idx = &i; > > I'm not an author of this solution - sorry. > > We can review this and try to add new solution.
I am not talking about int_data but the use of "i". Please look again your patch, you are using "j" instead of "i" and "i" is kept alone. Moreover I don't know how the pointer of a local variable can be used. > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 19/04/2019 12:57, Jozwiak, TomaszX: > > > > What is supposed to be "i"? > > > > It is initialized at 0 and never touched. > > > > > > > It's touched inside test_deflate_comp_decomp function. > > > > What do you mean? > > It's a local variable and its address is referenced: > > int_data.buf_idx = &i; > > It looks really wrong. > > > > Another error is seen in FreeBSD. > > > > Should I totally revert this patch?
