On Friday, April 04/19/19, 2019 at 13:45:12 +0530, Ferruh Yigit wrote:
> On 4/19/2019 12:37 AM, Stephen Hemminger wrote:
> > This driver defines lots of functions (like init_rss) which are intended
> > to only be used in this device. But when doing static linking these
> > global functions cause link failures when similar function name is
> > used in application.
> >
> > This patch prefixes all functions defined in cxgbe.h with cxgbe_
> > to avoid these kind of conflicts.
>
> +1, not static functions should have module prefix
>
Agreed. I still see some non-static functions missing cxgbe_
prefix. I'll analyze more and audit them.
> >
> > Fixes: bfcb257d3014 ("net/cxgbe: enable RSS for VF")
> > Signed-off-by: Stephen Hemminger <step...@networkplumber.org>
>
Thanks,
Rahul
