On Friday, April 04/19/19, 2019 at 16:48:55 +0530, Ferruh Yigit wrote:
> On 4/19/2019 10:49 AM, Rahul Lakkireddy wrote:
> > Hi Ferruh,
> >
> > On Friday, April 04/19/19, 2019 at 15:00:32 +0530, Ferruh Yigit wrote:
> >> On 4/19/2019 10:22 AM, Rahul Lakkireddy wrote:
> >>> Fixes: 04868e5bfddd ("net/cxgbe: add support to run Chelsio T6 cards")
> >>
> >> Why this is a fix, isn't this just adding new device ids?
> >>
> >>
> >>> Cc: sta...@dpdk.org
> >>
> >> What about keeping 'stable' tag to request the backport but remove the fix?
> >>
> >
> > It's fixing probe for these new devices. Let me know if this particular
> > case doesn't require the fixes line and I will send v2 with only the
> > stable tag.
>
> No need a v2, if you are agree I can remove while merging.
>
> The commit is not fixing any old code in DPDK, if the intention of making this
> patch a fix is to backport the patch, we can do same via stable tag, fix not
> needed.
> If these devices were ready at that time, in 17.08, but forgotten in that
> commit
> to be added, than I see the fix but this looks unlikely since it is almost two
> years ago.
>
Ok, please remove the fixes line during merge.
> >
> >>>
> >>> Signed-off-by: Rahul Lakkireddy <rahul.lakkire...@chelsio.com>
> >>
> >
Thanks,
Rahul
