Review Request 14307: CLOUDSTACK-702: New test for deploying vm in new cidr

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14307/
---

Review request for cloudstack, venkata swamy babu  budumuru, SrikanteswaraRao 
Talluri, and Prasanna Santhanam.


Repository: cloudstack-git


Description
---

This test will add new guest ip range in new cird in the basic zone.
Deploys vm and make sure that VM gets IP address from new CIDR added in the 
test.


Diffs
-

  test/integration/component/maint/test_multiple_ip_ranges.py PRE-CREATION 

Diff: https://reviews.apache.org/r/14307/diff/


Testing
---

Yes.


Thanks,

sanjeev n

Review Request 14468: CLOUDSTACK-702: Added test for verifying dns service on alias IP

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14468/
---

Review request for cloudstack, venkata swamy babu  budumuru, SrikanteswaraRao 
Talluri, and Prasanna Santhanam.


Repository: cloudstack-git


Description
---

1. Moved some code from test to setupClass method since it is required for all 
the tests
2. Added new test which will deploy vm in new cidr and verifies dns service on 
alias ip on VR.


Diffs
-

  test/integration/component/maint/test_multiple_ip_ranges.py 782957c 

Diff: https://reviews.apache.org/r/14468/diff/


Testing
---

Yes


Thanks,

sanjeev n

Re: Review Request 14335: CLOUDSTACK-4262: Fix TestVPCNetworkGc.test_01_wait_network_gc

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14335/#review2
---


Checking LB rules deletion after network gc looks good to me. However 
validation is missing in the code after listing NetworkAcl rules after gc.
netacls = NetworkACL.list(self.apiclient, networkid=self.network_1.id)
self.debug("List of NetACLS %s" % netacls)
Add validation whether NetworkACL.list is returning empty or not.


- sanjeev n


On Sept. 25, 2013, 1:34 p.m., Girish Shilamkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14335/
> ---
> 
> (Updated Sept. 25, 2013, 1:34 p.m.)
> 
> 
> Review request for cloudstack, Harikrishna Patnala and venkata swamy babu  
> budumuru.
> 
> 
> Bugs: CLOUDSTACK-4262
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> As per the test plan, after waiting for network gc
> LB rules should be cleared. Added that check instead of router
> being in stopped state.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_vpc_network.py 970a625 
> 
> Diff: https://reviews.apache.org/r/14335/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Girish Shilamkar
> 
>

Re: Review Request 14248: CLOUDSTACK: 4537 - test_vpc_vm_life_cycle.py - Fixed vpc and shared network test cases

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14248/#review26667
---

Ship it!


Looks good to me.

- sanjeev n


On Oct. 3, 2013, 7:28 a.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14248/
> ---
> 
> (Updated Oct. 3, 2013, 7:28 a.m.)
> 
> 
> Review request for cloudstack, Harikrishna Patnala, Rayees Namathponnan, 
> venkata swamy babu  budumuru, and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixed Test case test_vpc_vm_life_cycle.py: TestVMLifeCycleSharedNwVPC failed 
> with Insufficient address capacity error
> 
> Changes:
> 1) Shared network requires start ip and end ip shile creating it, if you want 
> to deploy vm in it. Else it throws Insufficient address capacity error
> 2) Removed addition of multiple vms in load balancing rule (VMs belonging to 
> multiple networks). Because this is not allowed.
> 3) For test case test_05_destroy_instance_in_network, added wait for cleanup 
> of vm. So that after it proceeds to check the network rules.
> 4) Removed white spaces and unnecessary comments.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_vpc_vm_life_cycle.py 9844c1f 
> 
> Diff: https://reviews.apache.org/r/14248/diff/
> 
> 
> Testing
> ---
> 
> Tested locally
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 14335: CLOUDSTACK-4262: Fix TestVPCNetworkGc.test_01_wait_network_gc

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14335/#review26725
---

Ship it!


Patch is good to commit. Some commiter has to push it to master.

- sanjeev n


On Oct. 7, 2013, 4:54 a.m., Girish Shilamkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14335/
> ---
> 
> (Updated Oct. 7, 2013, 4:54 a.m.)
> 
> 
> Review request for cloudstack, Harikrishna Patnala and venkata swamy babu  
> budumuru.
> 
> 
> Bugs: CLOUDSTACK-4262
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> As per the test plan, after waiting for network gc
> LB rules should be cleared. Added that check instead of router
> being in stopped state.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_vpc_network.py 970a625 
> 
> Diff: https://reviews.apache.org/r/14335/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Girish Shilamkar
> 
>

Review Request 14531: CLOUDSTACK-702: Verify Userdata and Password service on alias ip on VR

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14531/
---

Review request for cloudstack, venkata swamy babu  budumuru, SrikanteswaraRao 
Talluri, and Prasanna Santhanam.


Repository: cloudstack-git


Description
---

Verify Userdata and Password service on alias ip on VR
1.Added two tests to verify userdata and password service after ip alias 
creation on VR.
2.Tests will deploy vm in new CIDR,checks alias creation and verify services on 
alias ip addresses on VR.


Diffs
-

  test/integration/component/maint/test_multiple_ip_ranges.py 68b5979 

Diff: https://reviews.apache.org/r/14531/diff/


Testing
---

yes


Thanks,

sanjeev n

Re: Review Request 14556: CLOUDSTACK-4766: Add timeout if vm does not reach running state

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14556/#review26816
---


Patch looks good. However still test is failing. Is it a product issue?

- sanjeev n


On Oct. 9, 2013, 9:50 a.m., Girish Shilamkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14556/
> ---
> 
> (Updated Oct. 9, 2013, 9:50 a.m.)
> 
> 
> Review request for cloudstack, sanjeev n and venkata swamy babu  budumuru.
> 
> 
> Bugs: CLOUDSTACK-4766
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> The test use to wait for ever for the vm to attain Running state.
> Added a timeout so it does not get into infinite loop.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_reset_ssh_keypair.py ace4499 
> 
> Diff: https://reviews.apache.org/r/14556/diff/
> 
> 
> Testing
> ---
> 
> Verified that the timeout works. 
> 
> test_01_reset_keypair_normal_user 
> (test_reset_ssh_keypair.TestResetSSHKeyUserRights)Verify API 
> resetSSHKeyForVirtualMachine for non admin non root ... FAIL
> test_02_reset_keypair_domain_admin 
> (test_reset_ssh_keypair.TestResetSSHKeyUserRights)
> Verify API resetSSHKeyForVirtualMachine for domain admin non root ... ok
> test_03_reset_keypair_root_admin 
> (test_reset_ssh_keypair.TestResetSSHKeyUserRights)
> Verify API resetSSHKeyForVirtualMachine for domain admin root ... ok
> test_01_reset_ssh_keys (test_reset_ssh_keypair.TestResetSSHKeypair)
> Test Reset SSH keys for VM  already having SSH key ... ok
> test_02_reset_ssh_key_password_enabled_template 
> (test_reset_ssh_keypair.TestResetSSHKeypair)
> Reset SSH keys for VM  created from password enabled template and ... ok
> test_03_reset_ssh_with_no_key (test_reset_ssh_keypair.TestResetSSHKeypair)
> Reset SSH key for VM  having no SSH key ... ok
> test_04_reset_key_passwd_enabled_no_key 
> (test_reset_ssh_keypair.TestResetSSHKeypair)
> Reset SSH keys for VM  created from password enabled template and ... ok
> test_05_reset_key_in_running_state 
> (test_reset_ssh_keypair.TestResetSSHKeypair)
> Reset SSH keys for VM  already having SSH key when VM is in running ... ok
> test_06_reset_key_passwd_enabled_vm_running 
> (test_reset_ssh_keypair.TestResetSSHKeypair)
> Reset SSH keys for VM  created from password enabled template and ... ok
> test_07_reset_keypair_invalid_params 
> (test_reset_ssh_keypair.TestResetSSHKeypair)
> Verify API resetSSHKeyForVirtualMachine with incorrect parameters … ok
> 
> ==
> FAIL: test_01_reset_keypair_normal_user 
> (test_reset_ssh_keypair.TestResetSSHKeyUserRights)
> Verify API resetSSHKeyForVirtualMachine for non admin non root
> --
> Traceback (most recent call last):
>   File "/root/girish/test_reset_ssh_keypair.py", line 1218, in 
> test_01_reset_keypair_normal_user
> % (vms[0].name, self.services["timeout"]))
> AssertionError: The virtual machine 974d1275-b747-441c-83b2-1795de4d87df 
> failed to start even after 10 minutes
> 
> --
> 
> 
> Thanks,
> 
> Girish Shilamkar
> 
>

Re: Review Request 14556: CLOUDSTACK-4766: Add timeout if vm does not reach running state

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14556/#review27113
---

Ship it!


Patch is good to go.

- sanjeev n


On Oct. 9, 2013, 9:50 a.m., Girish Shilamkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14556/
> ---
> 
> (Updated Oct. 9, 2013, 9:50 a.m.)
> 
> 
> Review request for cloudstack, sanjeev n and venkata swamy babu  budumuru.
> 
> 
> Bugs: CLOUDSTACK-4766
> https://issues.apache.org/jira/browse/CLOUDSTACK-4766
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> The test use to wait for ever for the vm to attain Running state.
> Added a timeout so it does not get into infinite loop.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_reset_ssh_keypair.py ace4499 
> 
> Diff: https://reviews.apache.org/r/14556/diff/
> 
> 
> Testing
> ---
> 
> Verified that the timeout works. 
> 
> test_01_reset_keypair_normal_user 
> (test_reset_ssh_keypair.TestResetSSHKeyUserRights)Verify API 
> resetSSHKeyForVirtualMachine for non admin non root ... FAIL
> test_02_reset_keypair_domain_admin 
> (test_reset_ssh_keypair.TestResetSSHKeyUserRights)
> Verify API resetSSHKeyForVirtualMachine for domain admin non root ... ok
> test_03_reset_keypair_root_admin 
> (test_reset_ssh_keypair.TestResetSSHKeyUserRights)
> Verify API resetSSHKeyForVirtualMachine for domain admin root ... ok
> test_01_reset_ssh_keys (test_reset_ssh_keypair.TestResetSSHKeypair)
> Test Reset SSH keys for VM  already having SSH key ... ok
> test_02_reset_ssh_key_password_enabled_template 
> (test_reset_ssh_keypair.TestResetSSHKeypair)
> Reset SSH keys for VM  created from password enabled template and ... ok
> test_03_reset_ssh_with_no_key (test_reset_ssh_keypair.TestResetSSHKeypair)
> Reset SSH key for VM  having no SSH key ... ok
> test_04_reset_key_passwd_enabled_no_key 
> (test_reset_ssh_keypair.TestResetSSHKeypair)
> Reset SSH keys for VM  created from password enabled template and ... ok
> test_05_reset_key_in_running_state 
> (test_reset_ssh_keypair.TestResetSSHKeypair)
> Reset SSH keys for VM  already having SSH key when VM is in running ... ok
> test_06_reset_key_passwd_enabled_vm_running 
> (test_reset_ssh_keypair.TestResetSSHKeypair)
> Reset SSH keys for VM  created from password enabled template and ... ok
> test_07_reset_keypair_invalid_params 
> (test_reset_ssh_keypair.TestResetSSHKeypair)
> Verify API resetSSHKeyForVirtualMachine with incorrect parameters … ok
> 
> ==
> FAIL: test_01_reset_keypair_normal_user 
> (test_reset_ssh_keypair.TestResetSSHKeyUserRights)
> Verify API resetSSHKeyForVirtualMachine for non admin non root
> --
> Traceback (most recent call last):
>   File "/root/girish/test_reset_ssh_keypair.py", line 1218, in 
> test_01_reset_keypair_normal_user
> % (vms[0].name, self.services["timeout"]))
> AssertionError: The virtual machine 974d1275-b747-441c-83b2-1795de4d87df 
> failed to start even after 10 minutes
> 
> --
> 
> 
> Thanks,
> 
> Girish Shilamkar
> 
>

Review Request 14737: CLOUDSTACK-702: IP alias verification tests on VR

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14737/
---

Review request for cloudstack and SrikanteswaraRao Talluri.


Repository: cloudstack-git


Description
---

Added following code in the existing test
1.Moved vm deployment code to setUp method and vm destroy code to tearDown 
method
2.Added test to verify ip alias removal after destroying last vm in the cidr
3.Added tests to verify ip alias verification on VR after reboot and stop/start 
VR


Diffs
-

  test/integration/component/maint/test_multiple_ip_ranges.py 3f0035e 

Diff: https://reviews.apache.org/r/14737/diff/


Testing
---

Yes


Thanks,

sanjeev n

Re: Review Request 14737: CLOUDSTACK-702: IP alias verification tests on VR

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14737/
---

(Updated Oct. 21, 2013, 9:29 a.m.)


Review request for cloudstack and SrikanteswaraRao Talluri.


Changes
---

Incorporated the review comments.


Repository: cloudstack-git


Description
---

Added following code in the existing test
1.Moved vm deployment code to setUp method and vm destroy code to tearDown 
method
2.Added test to verify ip alias removal after destroying last vm in the cidr
3.Added tests to verify ip alias verification on VR after reboot and stop/start 
VR


Diffs (updated)
-

  test/integration/component/maint/test_multiple_ip_ranges.py 3f0035e 

Diff: https://reviews.apache.org/r/14737/diff/


Testing
---

Yes


Thanks,

sanjeev n

Re: Review Request 14319: CLOUDSTACK 2238: Automation - Non Contiguous VLAN Ranges

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14319/#review27374
---



test/integration/component/test_non_contiguous_vlan.py
<https://reviews.apache.org/r/14319/#comment53230>

This test would fail if the existing vlan rang is say 4090-4095. In this 
case code execution will go to elif block and the ranges will be like as 
follows:
4093-4092,4091-4090,4093-4090 which are not valid vlan ranges(higher to 
lower number). Please change the logic in elif block.



test/integration/component/test_non_contiguous_vlan.py
<https://reviews.apache.org/r/14319/#comment53231>

Instead of simply depending on updatePhysicalNetworkResponse parameter for 
fail/passing the test case also list the updated physical netowrk, read the 
vlan info and validate it. This applies to all the tests.



test/integration/component/test_non_contiguous_vlan.py
<https://reviews.apache.org/r/14319/#comment53232>

No validation to check step3 mentioned in the dotted strings in the test. 
Please add code to validate step3.


- sanjeev n


On Oct. 23, 2013, 9:01 a.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14319/
> ---
> 
> (Updated Oct. 23, 2013, 9:01 a.m.)
> 
> 
> Review request for cloudstack, bharat kumar and sanjeev n.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Adding Automation test cases for feature - Non Contiguous VLAN ranges
> CLOUDSTACk 2238.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_non_contiguous_vlan.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/14319/diff/
> 
> 
> Testing
> ---
> 
> Tested locally on XenServer Setup
> 
> Log:
> 
> test_01 (test_non_contiguous_vlan.TestNonContiguousVLANRanges) ... ok
> test_02 (test_non_contiguous_vlan.TestNonContiguousVLANRanges) ... ok
> test_03 (test_non_contiguous_vlan.TestNonContiguousVLANRanges) ... ok
> test_04 (test_non_contiguous_vlan.TestNonContiguousVLANRanges) ... ok
> test_05 (test_non_contiguous_vlan.TestNonContiguousVLANRanges) ... ok
> 
> --
> Ran 5 tests in 22.387s
> 
> OK
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Review Request 14924: Test to verify ip alias recreation after destroying and recreating VR

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14924/
---

Review request for cloudstack and SrikanteswaraRao Talluri.


Repository: cloudstack-git


Description
---

Added test to verify ip alias creation after VR recreation if it was destroyed.
1.Destroy VR
2.Stop and Start guest VM to recreate VR
3.Verify ip alias


Diffs
-

  test/integration/component/maint/test_multiple_ip_ranges.py dc8021b 

Diff: https://reviews.apache.org/r/14924/diff/


Testing
---

Yes. Executed the test on a basic zone setup running with latest 4.2 build.


Thanks,

sanjeev n

Re: Review Request 14738: Testscript for DeployVM User data enhancement

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14738/#review28087
---

Ship it!


Looks good to me.

- sanjeev n


On Oct. 31, 2013, 1:11 a.m., suresh sadhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14738/
> ---
> 
> (Updated Oct. 31, 2013, 1:11 a.m.)
> 
> 
> Review request for cloudstack, sailaja mada, sanjeev n, Sowmya Krishnan, and 
> SrikanteswaraRao Talluri.
> 
> 
> Bugs: cloudstack-2272
> https://issues.apache.org/jira/browse/cloudstack-2272
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> This script validates VM-deployment  with user-data of size more than 
> 2048(which includes deployment as well as validation part after applying the 
> user-data)
> 
>  
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_deploy_vm_userdata_reg.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/14738/diff/
> 
> 
> Testing
> ---
> 
> yes
> 
> 
> Thanks,
> 
> suresh sadhu
> 
>

Review Request: CLOUDSTACK-2543: createipAlias.sh/deleteipAlias.sh won't be copied to XenServer host

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11221/
---

Review request for cloudstack, Prasanna Santhanam and Koushik Das.


Description
---

createipAlias.sh/deleteipAlias.sh won't be copied to XenServer host.

1.The directory of the scripts should be ".." rather "../../.." in all the 
xenser patches file.
Corrected the path to ".." because the scripts are located at 
scripts/vm/hypervisor/xenserver/xenserver56/patch 
b/scripts/vm/hypervisor/xenserver/


This addresses bug CLOUDSTACK-2543.


Diffs
-

  scripts/vm/hypervisor/xenserver/xcpserver/patch a275df4 
  scripts/vm/hypervisor/xenserver/xenserver56/patch 5c4673d 
  scripts/vm/hypervisor/xenserver/xenserver56fp1/patch c7c58b9 
  scripts/vm/hypervisor/xenserver/xenserver60/patch 26205f2 

Diff: https://reviews.apache.org/r/11221/diff/


Testing
---

Yes. Tested with xenserver6.1 on master branch.


Thanks,

sanjeev n

Re: Review Request: CLOUDSTACK-2543: createipAlias.sh/deleteipAlias.sh won't be copied to XenServer host

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11221/
---

(Updated May 20, 2013, 6:44 a.m.)


Review request for cloudstack, Prasanna Santhanam and Koushik Das.


Changes
---

Added scripts in patch file in scripts/vm/hypervisor/xenserver/xcposs as well.


Description
---

createipAlias.sh/deleteipAlias.sh won't be copied to XenServer host.

1.The directory of the scripts should be ".." rather "../../.." in all the 
xenser patches file.
Corrected the path to ".." because the scripts are located at 
scripts/vm/hypervisor/xenserver/xenserver56/patch 
b/scripts/vm/hypervisor/xenserver/


This addresses bug CLOUDSTACK-2543.


Diffs (updated)
-

  scripts/vm/hypervisor/xenserver/xcposs/patch 6dc3baa 
  scripts/vm/hypervisor/xenserver/xcpserver/patch a275df4 
  scripts/vm/hypervisor/xenserver/xenserver56/patch 5c4673d 
  scripts/vm/hypervisor/xenserver/xenserver56fp1/patch c7c58b9 
  scripts/vm/hypervisor/xenserver/xenserver60/patch 26205f2 

Diff: https://reviews.apache.org/r/11221/diff/


Testing
---

Yes. Tested with xenserver6.1 on master branch.


Thanks,

sanjeev n

Re: Review Request: CLOUDSTACK-2543: createipAlias.sh/deleteipAlias.sh won't be copied to XenServer host

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11221/
---

(Updated May 20, 2013, 1:14 p.m.)


Review request for cloudstack, Prasanna Santhanam and Koushik Das.


Changes
---

createipAlias.sh/deleteipAlias.sh won't be copied to XenServer host
1.Changed target path for the scripts to /usr/lib/xcp/bin in xcposs server 
patch file


Description
---

createipAlias.sh/deleteipAlias.sh won't be copied to XenServer host.

1.The directory of the scripts should be ".." rather "../../.." in all the 
xenser patches file.
Corrected the path to ".." because the scripts are located at 
scripts/vm/hypervisor/xenserver/xenserver56/patch 
b/scripts/vm/hypervisor/xenserver/


This addresses bug CLOUDSTACK-2543.


Diffs (updated)
-

  scripts/vm/hypervisor/xenserver/xcposs/patch 6dc3baa 
  scripts/vm/hypervisor/xenserver/xcpserver/patch a275df4 
  scripts/vm/hypervisor/xenserver/xenserver56/patch 5c4673d 
  scripts/vm/hypervisor/xenserver/xenserver56fp1/patch c7c58b9 
  scripts/vm/hypervisor/xenserver/xenserver60/patch 26205f2 

Diff: https://reviews.apache.org/r/11221/diff/


Testing
---

Yes. Tested with xenserver6.1 on master branch.


Thanks,

sanjeev n

Review Request: Test Snapshot Services

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11904/
---

Review request for cloudstack, Prasanna Santhanam and SrikanteswaraRao Talluri.


Description
---

Secondary Storage vm type has been modified from "SecondaryStorage" to 
"SecondaryStorageVM" in host table in Cloud db.
Modified the same in the test.


Diffs
-

  test/integration/component/test_snapshots.py 014b55a 

Diff: https://reviews.apache.org/r/11904/diff/


Testing
---

Yes


Thanks,

sanjeev n

Re: Review Request: Test Snapshot Services

[sanjeev n]

> On June 18, 2013, 6:40 a.m., Prasanna Santhanam wrote:
> > This test actually passes on jenkins. What are we changing here?

In an environment created with apche master, I see ssvm type as 
"SecondaryStorageVM" in host table. So I modified the script accordingly.


- sanjeev


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11904/#review22054
---


On June 17, 2013, 6:37 a.m., sanjeev n wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11904/
> ---
> 
> (Updated June 17, 2013, 6:37 a.m.)
> 
> 
> Review request for cloudstack, Prasanna Santhanam and SrikanteswaraRao 
> Talluri.
> 
> 
> Description
> ---
> 
> Secondary Storage vm type has been modified from "SecondaryStorage" to 
> "SecondaryStorageVM" in host table in Cloud db.
> Modified the same in the test.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_snapshots.py 014b55a 
> 
> Diff: https://reviews.apache.org/r/11904/diff/
> 
> 
> Testing
> ---
> 
> Yes
> 
> 
> Thanks,
> 
> sanjeev n
> 
>

Review Request: Test Volumes Services

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12021/
---

Review request for cloudstack, Prasanna Santhanam and SrikanteswaraRao Talluri.


Description
---

1.Current Implementation assumes 6 as the max volumes that can be attached to 
disk. Actually it depends on the hypervisor capabilities.
2.Modified the script to get the max limit from hypervsior capabilities.


Diffs
-

  test/integration/component/test_volumes.py 369cefc 

Diff: https://reviews.apache.org/r/12021/diff/


Testing
---


Thanks,

sanjeev n

Review Request 12229: Fixing script issue

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12229/
---

Review request for cloudstack, SrikanteswaraRao Talluri and Prasanna Santhanam.


Repository: cloudstack-git


Description
---

Fixing script issue:
1.Object is being used in one of the Assert statements directly, however it is 
not callable. So fixed it.


Diffs
-

  test/integration/smoke/test_primary_storage.py 598654d 

Diff: https://reviews.apache.org/r/12229/diff/


Testing
---

Yes, Tested on master branch


Thanks,

sanjeev n

Review Request 12899: CLOUDSTACK-702: Tests for Multiple IP Ranges

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12899/
---

Review request for cloudstack, SrikanteswaraRao Talluri and Prasanna Santhanam.


Repository: cloudstack-git


Description
---

1.Removed advanced-sg tags from all the tests. At the movement tests only 
support basic zone.
2.Added a test to deploy guest vm after adding ip range in new CIDR


Diffs
-

  test/integration/component/test_multiple_ip_ranges.py 18409c5 

Diff: https://reviews.apache.org/r/12899/diff/


Testing
---

Yes. Tests on ACS 4.2 branch


Thanks,

sanjeev n

Review Request 13964: CLOUDSTACK-4203: Adding a test for migrating volumes of stopped vms to test_stopped_vm.py

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13964/
---

Review request for cloudstack, SrikanteswaraRao Talluri and Prasanna Santhanam.


Bugs: CLOUDSTACK-4203


Repository: cloudstack-git


Description
---

Adding test for migrating volumes of stopped vm.


Diffs
-

  test/integration/component/test_stopped_vm.py 41eeb46 

Diff: https://reviews.apache.org/r/13964/diff/


Testing
---

Yes


Thanks,

sanjeev n

Re: Review Request 13964: CLOUDSTACK-4203: Adding a test for migrating volumes of stopped vms to test_stopped_vm.py

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13964/
---

(Updated Sept. 5, 2013, 6:32 a.m.)


Review request for cloudstack, venkata swamy babu  budumuru, SrikanteswaraRao 
Talluri, and Prasanna Santhanam.


Bugs: CLOUDSTACK-4203


Repository: cloudstack-git


Description
---

Adding test for migrating volumes of stopped vm.


Diffs
-

  test/integration/component/test_stopped_vm.py 41eeb46 

Diff: https://reviews.apache.org/r/13964/diff/


Testing
---

Yes


Thanks,

sanjeev n

Review Request 13991: Made misc changes in test_multiple_ip_ranges.py

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13991/
---

Review request for cloudstack, venkata swamy babu  budumuru, SrikanteswaraRao 
Talluri, and Prasanna Santhanam.


Bugs: CLOUDSTACK-702


Repository: cloudstack-git


Description
---

This patch is a combination of two commits. In first commit
1. Removed advanced tag from all the tests. At the movement scripts
 support only basic zone
2. Added a test to deploy guest vm after adding ip range in new CIDR
In second commit:
Removed test for deploying vm after adding new cidr
1.This test would block parallel execution of remianing tests
2.Removed list_Routers proc and unused code
3.Added few more debug statements


Diffs
-

  test/integration/component/test_multiple_ip_ranges.py 18409c5 

Diff: https://reviews.apache.org/r/13991/diff/


Testing
---

Yes.


Thanks,

sanjeev n

Re: Review Request: Two test cases from snapshots imporevement feature

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9752/
---

(Updated April 8, 2013, 2 p.m.)


Review request for cloudstack and Prasanna Santhanam.


Changes
---

Included my changes.


Description
---

Added two test cases for snapshots improvement feature.


Diffs (updated)
-

  test/integration/component/test_snapshots_improvements.py PRE-CREATION 

Diff: https://reviews.apache.org/r/9752/diff/


Testing
---

Executed the tests in advanced zone setup.


Thanks,

sanjeev n

Review Request: Multiple IP Ranges Support in CloudStack

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10792/
---

Review request for cloudstack and Prasanna Santhanam.


Description
---

Adding two test cases(Adding guest CIDR in same and diff subnet) for "Multiple 
IP Ranges" support in CloudStack.


Diffs
-

  test/integration/component/test_multiple_ip_ranges.py PRE-CREATION 

Diff: https://reviews.apache.org/r/10792/diff/


Testing
---


Thanks,

sanjeev n

Re: Review Request: Multiple IP Ranges Support in CloudStack

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10792/
---

(Updated April 26, 2013, 11 a.m.)


Review request for cloudstack, Prasanna Santhanam and SrikanteswaraRao Talluri.


Changes
---

Modified as per the review comments.


Description
---

Adding two test cases(Adding guest CIDR in same and diff subnet) for "Multiple 
IP Ranges" support in CloudStack.


This addresses bug CLOUDSTACK-702.


Diffs (updated)
-

  test/integration/component/test_multiple_ip_ranges.py PRE-CREATION 

Diff: https://reviews.apache.org/r/10792/diff/


Testing
---


Thanks,

sanjeev n

Re: Review Request: Multiple IP Ranges Support in CloudStack

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10792/
---

(Updated April 26, 2013, 1:44 p.m.)


Review request for cloudstack, Prasanna Santhanam and SrikanteswaraRao Talluri.


Changes
---

Moved redundant code to methods.


Description
---

Adding two test cases(Adding guest CIDR in same and diff subnet) for "Multiple 
IP Ranges" support in CloudStack.


This addresses bug CLOUDSTACK-702.


Diffs (updated)
-

  test/integration/component/test_multiple_ip_ranges.py PRE-CREATION 

Diff: https://reviews.apache.org/r/10792/diff/


Testing
---


Thanks,

sanjeev n

Re: Review Request: Multiple IP Ranges Support in CloudStack

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10792/
---

(Updated April 29, 2013, 5:35 a.m.)


Review request for cloudstack, Prasanna Santhanam and SrikanteswaraRao Talluri.


Changes
---

Combined three patches into one patch


Description
---

Adding two test cases(Adding guest CIDR in same and diff subnet) for "Multiple 
IP Ranges" support in CloudStack.


This addresses bug CLOUDSTACK-702.


Diffs (updated)
-

  test/integration/component/test_multiple_ip_ranges.py PRE-CREATION 

Diff: https://reviews.apache.org/r/10792/diff/


Testing
---


Thanks,

sanjeev n

Review Request: CLOUDSTACK-702: Tests for Multiple IP Ranges

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10861/
---

Review request for cloudstack, Prasanna Santhanam and SrikanteswaraRao Talluri.


Description
---

CLOUDSTACK-702: Tests for Multiple IP Ranges

1. Deleting IP Range from the existing CIDR.


This addresses bug CLOUDSTACK-702.


Diffs
-

  test/integration/component/test_multiple_ip_ranges.py 489e7ca 

Diff: https://reviews.apache.org/r/10861/diff/


Testing
---

Tested with fixed IP addresses since code has not been implemented(To make sure 
no syntax errors).


Thanks,

sanjeev n

Re: Review Request: CLOUDSTACK-702: Tests for Multiple IP Ranges

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10861/
---

(Updated May 2, 2013, 12:04 p.m.)


Review request for cloudstack, Prasanna Santhanam and SrikanteswaraRao Talluri.


Changes
---

Added two more test cases:
1.Add non-contiguous guest IP range in the existing CIDR
2.Add overlapped guest IP range in the existing CIDR

Also corrected few errors in previous tests.


Description
---

CLOUDSTACK-702: Tests for Multiple IP Ranges

1. Deleting IP Range from the existing CIDR.


This addresses bug CLOUDSTACK-702.


Diffs (updated)
-

  test/integration/component/test_multiple_ip_ranges.py 489e7ca 

Diff: https://reviews.apache.org/r/10861/diff/


Testing
---

Tested with fixed IP addresses since code has not been implemented(To make sure 
no syntax errors).


Thanks,

sanjeev n

Review Request: CLOUDSTACK-702: Tests for Multiple IP Ranges support

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10946/
---

Review request for cloudstack, Prasanna Santhanam and SrikanteswaraRao Talluri.


Description
---

Tests for Multiple IP Ranges
1. Add ip range overlapped with two exiting ip ranges in the existing cidr


This addresses bug CLOUDSTACK-702.


Diffs
-

  test/integration/component/test_multiple_ip_ranges.py 29942bd 

Diff: https://reviews.apache.org/r/10946/diff/


Testing
---

Yes


Thanks,

sanjeev n

Review Request: CLOUDSTACK-702: Tests for Multiple IP Ranges

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11026/
---

Review request for cloudstack, Prasanna Santhanam and SrikanteswaraRao Talluri.


Description
---

CLOUDSTACK-702: Tests for Multiple IP Ranges
1. Add ip range super set to existing CIDR
2. Add ip range subset to existing CIDR


This addresses bug CLOUDSTACK-702.


Diffs
-

  test/integration/component/test_multiple_ip_ranges.py 7e9eeb1 

Diff: https://reviews.apache.org/r/11026/diff/


Testing
---

yes


Thanks,

sanjeev n

Re: Review Request 19399: CLOUDSTACK-6257: Resolving issue in template creation from user VM volume, added method to check the state of VM before template creation

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19399/#review42136
---


Tried to apply it on master but it failed. Please rebase with master. Error 
messages are as follows:
[root@cent62-Sanjeev acs-repo]# git apply 
/root/0001-CLOUDSTACK-6257-Adding-function-to-check-state-of-VM.patch 
error: patch failed: tools/marvin/marvin/codes.py:31
error: tools/marvin/marvin/codes.py: patch does not apply
error: patch failed: tools/marvin/marvin/lib/base.py:22
error: tools/marvin/marvin/lib/base.py: patch does not apply


- sanjeev n


On April 28, 2014, 10:41 a.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19399/
> ---
> 
> (Updated April 28, 2014, 10:41 a.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6257
> https://issues.apache.org/jira/browse/CLOUDSTACK-6257
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> As suggested, added getState method for VirtualMachine class, and it is 
> called before template creation. If VM fails to go into desired state, it 
> returns failure.
> 
> 
> Diffs
> -
> 
>   tools/marvin/marvin/codes.py 28e907c 
>   tools/marvin/marvin/lib/base.py d753098 
> 
> Diff: https://reviews.apache.org/r/19399/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Re: Review Request 19399: CLOUDSTACK-6257: Resolving issue in template creation from user VM volume, added method to check the state of VM before template creation

[sanjeev n]

> On May 5, 2014, 5:53 a.m., ASF Subversion and Git Services wrote:
> > Commit d81c5c44f112df8c0e4388e9d88300b24eefe3d0 in cloudstack's branch 
> > refs/heads/4.4-forward from Girish Shilamkar
> > [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=d81c5c4 ]
> > 
> > Revert "CLOUDSTACK-6257: Adding function to check state of VM"
> > 
> > This reverts commit 1be8b87fb7fb0203464ac4c66596008855ac5041.
> >

Hi Girish,

Why was this commit not reverted from master branch. If it was not reverted was 
there a fix for this patch in master?


- sanjeev


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19399/#review42119
---


On April 28, 2014, 10:41 a.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19399/
> ---
> 
> (Updated April 28, 2014, 10:41 a.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6257
> https://issues.apache.org/jira/browse/CLOUDSTACK-6257
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> As suggested, added getState method for VirtualMachine class, and it is 
> called before template creation. If VM fails to go into desired state, it 
> returns failure.
> 
> 
> Diffs
> -
> 
>   tools/marvin/marvin/codes.py 28e907c 
>   tools/marvin/marvin/lib/base.py d753098 
> 
> Diff: https://reviews.apache.org/r/19399/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Re: Review Request 20891: CLOUDSTACK-6536: Code cleanup - removing unnecessary waits after VM stop operation

[sanjeev n]

> On May 5, 2014, 10:20 a.m., Santhosh Edukulla wrote:
> > Ship It!

I tried to apply the patch on master, however it failed. Please rebase it with 
master.
Following are the erros:
[root@cent62-Sanjeev acs-repo]# git apply 
/root/0002-CLOUDSTACK-6536-Code-cleanup-removing-unnecessary-wa.patch 
error: patch failed: 
test/integration/component/test_dynamic_compute_offering.py:44
error: test/integration/component/test_dynamic_compute_offering.py: patch does 
not apply


- sanjeev


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20891/#review42134
---


On May 2, 2014, 2:23 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20891/
> ---
> 
> (Updated May 2, 2014, 2:23 p.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6536
> https://issues.apache.org/jira/browse/CLOUDSTACK-6536
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Also
> 1)Modified Imports
> 2)Removing white-spaces
> 3)Added try catch blocks wherever necessary
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_add_remove_network.py 3e0e78b 
>   test/integration/component/test_blocker_bugs.py ba2602c 
>   test/integration/component/test_custom_hostname.py 7eeda49 
>   test/integration/component/test_dynamic_compute_offering.py da43fdf 
>   test/integration/component/test_egress_rules.py f0b98e4 
>   test/integration/component/test_escalations.py e994579 
>   test/integration/component/test_netscaler_configs.py 592b351 
>   test/integration/component/test_netscaler_lb.py 732f0f9 
>   test/integration/component/test_netscaler_nw_off.py d3f1f9e 
>   test/integration/component/test_network_offering.py b0b6906 
>   test/integration/component/test_persistent_networks.py deb0d6e 
>   test/integration/component/test_project_resources.py 8f81cf9 
>   test/integration/component/test_project_usage.py 16ca8c1 
>   test/integration/component/test_redundant_router_cleanups.py 2220d51 
>   test/integration/component/test_reset_ssh_keypair.py 307e8dc 
>   test/integration/component/test_resource_limits.py 09d9658 
>   test/integration/component/test_security_groups.py f5c4727 
>   test/integration/component/test_stopped_vm.py 6c77679 
>   test/integration/component/test_tags.py d6b43d9 
>   test/integration/component/test_templates.py 98b1cbc 
>   test/integration/component/test_usage.py eb92011 
>   test/integration/component/test_volumes.py a310472 
>   test/integration/component/test_vpc_network.py 2924b72 
>   test/integration/component/test_vpc_vm_life_cycle.py 95f46d0 
>   test/integration/smoke/test_service_offerings.py 3c91859 
>   test/integration/smoke/test_templates.py 4865ee3 
>   test/integration/smoke/test_vm_life_cycle.py f114ec9 
>   test/integration/smoke/test_volumes.py 7f5c4f3 
> 
> Diff: https://reviews.apache.org/r/20891/diff/
> 
> 
> Testing
> ---
> 
> Tested with python command. No changes in the actual executing code, only the 
> improvements and removing unnecessary code.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 21070: Fixed few exception cases.

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21070/#review42142
---


Please rebase with master since patch apply failed on master branch.

- sanjeev n


On May 5, 2014, 6:49 a.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21070/
> ---
> 
> (Updated May 5, 2014, 6:49 a.m.)
> 
> 
> Review request for cloudstack and sanjeev n.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixed few exception cases. When some request fails, it throws up the stack, 
> but the message str..does not contains a given attribute is little 
> misleading. So, raising exceptions for all cases.
> Added testsuite name for userprovided\default log folder path
> Fixed pep8 changes.
> 
> 
> Diffs
> -
> 
>   tools/marvin/marvin/cloudstackConnection.py caa8609 
>   tools/marvin/marvin/cloudstackTestClient.py d3a6b94 
>   tools/marvin/marvin/configGenerator.py 4f03fd0 
>   tools/marvin/marvin/marvinInit.py de580ce 
>   tools/marvin/marvin/marvinLog.py 65687aa 
>   tools/marvin/marvin/marvinPlugin.py c817cd6 
> 
> Diff: https://reviews.apache.org/r/21070/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>

Re: Review Request 21070: Fixed few exception cases.

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21070/#review42157
---

Ship it!


Ship It!

- sanjeev n


On May 5, 2014, 6:49 a.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21070/
> ---
> 
> (Updated May 5, 2014, 6:49 a.m.)
> 
> 
> Review request for cloudstack and sanjeev n.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixed few exception cases. When some request fails, it throws up the stack, 
> but the message str..does not contains a given attribute is little 
> misleading. So, raising exceptions for all cases.
> Added testsuite name for userprovided\default log folder path
> Fixed pep8 changes.
> 
> 
> Diffs
> -
> 
>   tools/marvin/marvin/cloudstackConnection.py caa8609 
>   tools/marvin/marvin/cloudstackTestClient.py d3a6b94 
>   tools/marvin/marvin/configGenerator.py 4f03fd0 
>   tools/marvin/marvin/marvinInit.py de580ce 
>   tools/marvin/marvin/marvinLog.py 65687aa 
>   tools/marvin/marvin/marvinPlugin.py c817cd6 
> 
> Diff: https://reviews.apache.org/r/21070/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>

Re: Review Request 21070: Fixed few exception cases.

[sanjeev n]

> On May 5, 2014, 4:06 p.m., sanjeev n wrote:
> > Ship It!

Applied patch to 4.4-automation branch
commit ef286da8ccc005fee58c4be5d508c5d7ddfc2a6c
Author: sanjeevneelarapu 
Date:   Tue May 6 02:57:08 2014 +0530

Fixed few exception cases


- sanjeev


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21070/#review42157
---


On May 5, 2014, 6:49 a.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21070/
> ---
> 
> (Updated May 5, 2014, 6:49 a.m.)
> 
> 
> Review request for cloudstack and sanjeev n.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixed few exception cases. When some request fails, it throws up the stack, 
> but the message str..does not contains a given attribute is little 
> misleading. So, raising exceptions for all cases.
> Added testsuite name for userprovided\default log folder path
> Fixed pep8 changes.
> 
> 
> Diffs
> -
> 
>   tools/marvin/marvin/cloudstackConnection.py caa8609 
>   tools/marvin/marvin/cloudstackTestClient.py d3a6b94 
>   tools/marvin/marvin/configGenerator.py 4f03fd0 
>   tools/marvin/marvin/marvinInit.py de580ce 
>   tools/marvin/marvin/marvinLog.py 65687aa 
>   tools/marvin/marvin/marvinPlugin.py c817cd6 
> 
> Diff: https://reviews.apache.org/r/21070/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>

Re: Introducing Vishwas

[Sanjeev N]

Welcome Vishwas !!

On Tue, Feb 28, 2017 at 4:57 AM, Tutkowski, Mike 
wrote:

> Welcome to the CloudStack Community! :)
>
> > On Feb 24, 2017, at 9:30 AM, Nathan Johnson  wrote:
> >
> > Vishwas Pathak  wrote:
> >
> >> Hello CloudStack team,
> >>
> >> My name is Vishwas Pathak and I am working with Accelerite CloudPlatform
> >> testing team. Earlier I have worked in storage systems, cloud computing,
> >> virtualization and telecom messaging domains. Excited to be part of this
> >> community and happy to contribute.
> >
> > Welcome Vishwas!
> >
> >
> > Nathan Johnson
> > R&D Engineer
> > Education Networks of America
>



-- 
Best Regards,
Sanjeev N
Chief Product Engineer@Accelerite

Review Request 23009: Fix for test_portable_ip.py script issues

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23009/
---

Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri.


Bugs: CS-6992
https://issues.apache.org/jira/browse/CS-6992


Repository: cloudstack-git


Description
---

1.Currently the test is not reading test data from the config file. So I have 
made changes in the script to read test data and use it in all the test methods
2.Reading portable ip config values was not proper in 
getPortableIpRangeServices in lib/common.py so made changes in the library to 
read portable ip values properly


Diffs
-

  test/integration/component/test_portable_ip.py b9c9059 
  tools/marvin/marvin/lib/common.py 7b0c7ad 

Diff: https://reviews.apache.org/r/23009/diff/


Testing
---

Yes


Thanks,

sanjeev n

Review Request 23449: Fix for test_portable_ip.py script issues

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23449/
---

Review request for cloudstack and SrikanteswaraRao Talluri.


Bugs: CS-6992
https://issues.apache.org/jira/browse/CS-6992


Repository: cloudstack-git


Description
---

1.Portable Ip range dictionary is missing from services class inside test.So 
added it inside services class.
2.Undefined variable is used in many places. Corrected it.
3.Made changes to getPortableIpRangeServices method in 
tools/marvin/marvin/lib/common.py to read values properly from the config


Diffs
-

  test/integration/component/test_portable_ip.py b9c9059 
  tools/marvin/marvin/lib/common.py 29677d3 

Diff: https://reviews.apache.org/r/23449/diff/


Testing
---

Yes


Thanks,

sanjeev n

Review Request 23609: Signature changes to delete method in VirtualMachine class in base.py

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23609/
---

Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri.


Repository: cloudstack-git


Description
---

destroyVirtualMachine API takes only one parameter (id-virtualmachine id) till 
CS 4.2. In 4.3 we have added expunge parameter to expunge the vm at the destroy 
time instead of waiting for expunge interval.
Made changes to delete method to accept additional parameters.


Diffs
-

  tools/marvin/marvin/lib/base.py e9d5bb4 

Diff: https://reviews.apache.org/r/23609/diff/


Testing
---

yes


Thanks,

sanjeev n

Review Request 23610: New script for verifying multiple shared networks with overlapped cidrs in different vlans

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23610/
---

Review request for cloudstack and SrikanteswaraRao Talluri.


Bugs: cs-4282
https://issues.apache.org/jira/browse/cs-4282


Repository: cloudstack-git


Description
---

Adding new script for verifying multiple shared networks support with 
overlapped cidrs in different vlans.
1.Create network1 with cidr1 and vlan1--pass
2.Create network2 with cidr1 and vlan1--fails
3.Create network3 with cidr1 and vlan2- pass


Diffs
-

  test/integration/component/test_shared_networks.py f99bfbf 

Diff: https://reviews.apache.org/r/23610/diff/


Testing
---

yes


Thanks,

sanjeev n

Review Request 23614: New test for deploying vm with static ip address

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23614/
---

Review request for cloudstack and SrikanteswaraRao Talluri.


Repository: cloudstack-git


Description
---

This is new script for deploying vm with static ip address.
1.Create isolated network with some ip range
2.Deploy vm with one of those ips instead of CS assigning the guest ip to vm
3.Verify the ip address after deployment


Diffs
-

  test/integration/component/test_escalations_instances.py 4900ff6 

Diff: https://reviews.apache.org/r/23614/diff/


Testing
---

yes


Thanks,

sanjeev n

Re: Review Request 23614: New test for deploying vm with static ip address

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23614/
---

(Updated July 22, 2014, 12:11 p.m.)


Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri.


Repository: cloudstack-git


Description
---

This is new script for deploying vm with static ip address.
1.Create isolated network with some ip range
2.Deploy vm with one of those ips instead of CS assigning the guest ip to vm
3.Verify the ip address after deployment


Diffs
-

  test/integration/component/test_escalations_instances.py 4900ff6 

Diff: https://reviews.apache.org/r/23614/diff/


Testing
---

yes


Thanks,

sanjeev n

Re: Review Request 22805: CLOUDSTACK-1466:Adding automation tests for Secondary Storage Limits

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22805/#review48358
---



test/integration/component/test_ss_domain_limits.py
<https://reviews.apache.org/r/22805/#comment84906>

Step6 is missing. Please add test for step6


- sanjeev n


On July 22, 2014, 8:39 a.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22805/
> ---
> 
> (Updated July 22, 2014, 8:39 a.m.)
> 
> 
> Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-1466
> https://issues.apache.org/jira/browse/CLOUDSTACK-1466
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Automation tests for Secondary Storage Limits. This patch contains 2 test 
> suites. 2 more test suites to follow.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_ss_domain_limits.py PRE-CREATION 
>   test/integration/component/test_ss_limits.py PRE-CREATION 
>   test/integration/component/test_ss_max_limits.py PRE-CREATION 
>   test/integration/component/test_ss_project_limits.py PRE-CREATION 
>   tools/marvin/marvin/config/test_data.py d870c98 
>   tools/marvin/marvin/lib/base.py 1ea4fa7 
> 
> Diff: https://reviews.apache.org/r/22805/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Review Request 23838: CLOUDSTACK-5986: Test scipt to verify the fix in isolated network for non-vpc networks

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23838/
---

Review request for cloudstack and Santhosh Edukulla.


Bugs: CS-5986
https://issues.apache.org/jira/browse/CS-5986


Repository: cloudstack-git


Description
---

Test script is to verify the fix for dnsmasq lease issue while reallocating the 
same ip address to new vm.
Test does the following:
Deploy two vms:
VM1 used name: VM1, 10.1.1.10
VM2 used name: VM2, 10.1.1.11
Destroy both the vms
Deploy vm3 with name VM1 and ip 10.1.1.11
Deploy vm4 with name vm3 and ip 10.1.1.10
Before fix vm4 would not get the ip because of dnsmasq lease issue. After fix 
vm4 would get the ip address properly.


Diffs
-

  test/integration/component/test_escalations_instances.py 79fd3b1 

Diff: https://reviews.apache.org/r/23838/diff/


Testing
---

Yes


Thanks,

sanjeev n

Review Request 23928: Test script to verify CS-5986 fix for vpc networks

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23928/
---

Review request for cloudstack and Santhosh Edukulla.


Bugs: CS-5986
https://issues.apache.org/jira/browse/CS-5986


Repository: cloudstack-git


Description
---

Test script is to verify the fix for dnsmasq lease issue while reallocating the 
same ip address to new vm in vpc networks.
Test does the following:
Create vpc and deploy vms in vpc network
Deploy two vms:
VM1 used name: VM1, 10.1.1.10
VM2 used name: VM2, 10.1.1.11
Destroy both the vms
Deploy vm3 with name VM1 and ip 10.1.1.11
Deploy vm4 with name vm3 and ip 10.1.1.10
Before fix vm4 would not get the ip because of dnsmasq lease issue. After fix 
vm4 would get the ip address properly.


Diffs
-

  test/integration/component/test_vpc_vms_deployment.py 1c1f93d 

Diff: https://reviews.apache.org/r/23928/diff/


Testing
---

yes


Thanks,

sanjeev n

Re: Review Request 23976: CLOUDSTACK-7190: Fix Hyper-V issue when attempting SSH to System VMs

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23976/#review48837
---

Ship it!


Ship It!

- sanjeev n


On July 28, 2014, 10:34 a.m., John Dilley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23976/
> ---
> 
> (Updated July 28, 2014, 10:34 a.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-7190
> https://issues.apache.org/jira/browse/CLOUDSTACK-7190
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Hyper-V system VMs need to be accessed in the same way as VMWare system VMs - 
> i.e. via the management server to the private IP rather than via the 
> hypervisor host to the link-local IP. This patch makes Hyper-V and VMWare 
> behave in the same way.
> 
> 
> Diffs
> -
> 
>   test/integration/component/maint/test_redundant_router.py 66bb477 
>   test/integration/component/test_VirtualRouter_alerts.py e6f0a82 
>   test/integration/component/test_deploy_vm_userdata_reg.py 1c9f35c 
>   test/integration/component/test_persistent_networks.py b90d621 
>   test/integration/smoke/test_routers.py f77d11a 
>   test/integration/smoke/test_ssvm.py 9b8d19d 
> 
> Diff: https://reviews.apache.org/r/23976/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> John Dilley
> 
>

Re: Review Request 23610: New script for verifying multiple shared networks with overlapped cidrs in different vlans

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23610/
---

(Updated Aug. 11, 2014, 5:38 a.m.)


Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri.


Bugs: cs-4282
https://issues.apache.org/jira/browse/cs-4282


Repository: cloudstack-git


Description
---

Adding new script for verifying multiple shared networks support with 
overlapped cidrs in different vlans.
1.Create network1 with cidr1 and vlan1--pass
2.Create network2 with cidr1 and vlan1--fails
3.Create network3 with cidr1 and vlan2- pass


Diffs
-

  test/integration/component/test_shared_networks.py f99bfbf 

Diff: https://reviews.apache.org/r/23610/diff/


Testing
---

yes


Thanks,

sanjeev n

Review Request 24589: Test script to verify fix for CS-5332

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24589/
---

Review request for cloudstack and Santhosh Edukulla.


Bugs: CS-5332
https://issues.apache.org/jira/browse/CS-5332


Repository: cloudstack-git


Description
---

This patch verifies the fix for CS-5332 (Network offering does not use new 
system offering for router).
Test involves following steps:
1.Create new system offering for domain router
2.create network offering and use the above offering for VR
3.Implement network and deploy vm in it


Diffs
-

  test/integration/component/test_network_offering.py f2251ff8 

Diff: https://reviews.apache.org/r/24589/diff/


Testing
---

Yes


Thanks,

sanjeev n

Re: Review Request 23452: CLOUDSTACK-4840: Automation tests - LB for secondary IP

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23452/#review50299
---



test/integration/component/test_lb_secondary_ip.py
<https://reviews.apache.org/r/23452/#comment87988>

Add Assertion to check whether assigning lb rule to secondary ip address is 
success or not. Applicable in all tests


- sanjeev n


On Aug. 12, 2014, 10:05 a.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23452/
> ---
> 
> (Updated Aug. 12, 2014, 10:05 a.m.)
> 
> 
> Review request for cloudstack, suresh sadhu, sailaja mada, sanjeev n, Sowmya 
> Krishnan, and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-4840
> https://issues.apache.org/jira/browse/CLOUDSTACK-4840
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Adding automation tests for LB for secondary IP
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_lb_secondary_ip.py PRE-CREATION 
>   tools/marvin/marvin/config/test_data.py a93b883 
>   tools/marvin/marvin/lib/base.py f0d53a6 
> 
> Diff: https://reviews.apache.org/r/23452/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Re: Review Request 23982: CLOUDSTACK-7192: Skip tests on Hyper-V which don't apply

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23982/#review50307
---

Ship it!


Ship It!

- sanjeev n


On Aug. 6, 2014, 2:41 p.m., John Dilley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23982/
> ---
> 
> (Updated Aug. 6, 2014, 2:41 p.m.)
> 
> 
> Review request for cloudstack, sanjeev n and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-7192
> https://issues.apache.org/jira/browse/CLOUDSTACK-7192
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> A number of tests in the following files don't apply to Hyper-V. This patch 
> means they are skipped if an attempt is made to run them.
> 
> test_nic.py
> test_primary_storage.py 
> test_scale_vm.py
> test_snapshots.py
> test_vm_snapshots.py
> test_volumes.py(test7 and test8 only)
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/test_nic.py dd6de96 
>   test/integration/smoke/test_primary_storage.py 66aec59 
>   test/integration/smoke/test_scale_vm.py b5c89be 
>   test/integration/smoke/test_snapshots.py 8b6fdd1 
>   test/integration/smoke/test_vm_snapshots.py 01626f5 
>   test/integration/smoke/test_volumes.py 6e9ea75 
> 
> Diff: https://reviews.apache.org/r/23982/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> John Dilley
> 
>

Review Request 24600: Test script to verify if there is an error in editing network without network domain specified

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24600/
---

Review request for cloudstack and Santhosh Edukulla.


Repository: cloudstack-git


Description
---

Test script to verify if there is an error in updating a network without 
network domain specified.
steps:
1.Create network offering with DHCP,SourceNat,StaticNat services
2.Create an isolated network using the above offering and without network 
domain specified
3.Update network and verify it does not error out


Diffs
-

  test/integration/component/test_network_offering.py 2c9a057 

Diff: https://reviews.apache.org/r/24600/diff/


Testing
---

yes


Thanks,

sanjeev n

Re: Review Request 24055: CLOUDSTACK-2251: Automation test cases for feature - Dedicated guest VLAN ranges per tenant

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24055/#review50850
---



test/integration/component/test_dedicate_guest_vlan_ranges.py
<https://reviews.apache.org/r/24055/#comment88722>

Add assertions to check whether the vlan dedecation is success or not. 
Applies to account2 as well.



test/integration/component/test_dedicate_guest_vlan_ranges.py
<https://reviews.apache.org/r/24055/#comment88723>

Add assertion since this is where the actual test is happening.



test/integration/component/test_dedicate_guest_vlan_ranges.py
<https://reviews.apache.org/r/24055/#comment88724>

This assert statement does not make sense because no vlan would be assigned 
to the network created here. Not sure what would be the value of 
netowrks[0].vlan when there is no vlan assigned for the network.



test/integration/component/test_dedicate_guest_vlan_ranges.py
<https://reviews.apache.org/r/24055/#comment88725>

Not catching the exception if releasing vlan range fails for some reason. 
Add code to handle the error in releasing vlan range.


- sanjeev n


On July 29, 2014, 2:20 p.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24055/
> ---
> 
> (Updated July 29, 2014, 2:20 p.m.)
> 
> 
> Review request for cloudstack, suresh sadhu, sailaja mada, sanjeev n, and 
> Sowmya Krishnan.
> 
> 
> Bugs: CLOUDSTACK-2251
> https://issues.apache.org/jira/browse/CLOUDSTACK-2251
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Automation test cases for feature - Dedicated guest VLAN ranges per tenant
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_dedicate_guest_vlan_ranges.py PRE-CREATION 
>   tools/marvin/marvin/lib/base.py 58033c6 
>   tools/marvin/marvin/lib/common.py 187ede6 
> 
> Diff: https://reviews.apache.org/r/24055/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Re: Review Request 23819: CLOUDSTACK-2251: Automation tests for dedicated public IP addreses per tenant feature

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23819/#review50869
---



test/integration/component/test_dedicate_public_ip_range.py
<https://reviews.apache.org/r/23819/#comment88743>

What is the need for acquiring ip address here? Not deploying any vms in 
the netowrk so why do we need IP address for source nat?



test/integration/component/test_dedicate_public_ip_range.py
<https://reviews.apache.org/r/23819/#comment88742>

Add code to verify the ip range release is success or not.


- sanjeev n


On July 22, 2014, 5:52 p.m., Girish Shilamkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23819/
> ---
> 
> (Updated July 22, 2014, 5:52 p.m.)
> 
> 
> Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-2251
> https://issues.apache.org/jira/browse/CLOUDSTACK-2251
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-2251: Automation tests for dedicated public IP addreses per tenant 
> feature
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_dedicate_public_ip_range.py PRE-CREATION 
>   tools/marvin/marvin/config/test_data.py 3cd4b6c 
>   tools/marvin/marvin/lib/base.py 1a32275 
> 
> Diff: https://reviews.apache.org/r/23819/diff/
> 
> 
> Testing
> ---
> 
> Yes
> 
> 
> Thanks,
> 
> Girish Shilamkar
> 
>

Re: Review Request 23610: New script for verifying multiple shared networks with overlapped cidrs in different vlans

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23610/#review51157
---

Ship it!


Ship It!

- sanjeev n


On Aug. 11, 2014, 5:38 a.m., sanjeev n wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23610/
> ---
> 
> (Updated Aug. 11, 2014, 5:38 a.m.)
> 
> 
> Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri.
> 
> 
> Bugs: cs-4282
> https://issues.apache.org/jira/browse/cs-4282
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Adding new script for verifying multiple shared networks support with 
> overlapped cidrs in different vlans.
> 1.Create network1 with cidr1 and vlan1--pass
> 2.Create network2 with cidr1 and vlan1--fails
> 3.Create network3 with cidr1 and vlan2- pass
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_shared_networks.py f99bfbf 
> 
> Diff: https://reviews.apache.org/r/23610/diff/
> 
> 
> Testing
> ---
> 
> yes
> 
> 
> Thanks,
> 
> sanjeev n
> 
>

Re: Review Request 23452: CLOUDSTACK-4840: Automation tests - LB for secondary IP

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23452/#review51361
---

Ship it!


- sanjeev n


On Aug. 22, 2014, 6:24 a.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23452/
> ---
> 
> (Updated Aug. 22, 2014, 6:24 a.m.)
> 
> 
> Review request for cloudstack, suresh sadhu, sailaja mada, sanjeev n, Sowmya 
> Krishnan, and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-4840
> https://issues.apache.org/jira/browse/CLOUDSTACK-4840
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Adding automation tests for LB for secondary IP
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_lb_secondary_ip.py PRE-CREATION 
>   tools/marvin/marvin/config/test_data.py a93b883 
>   tools/marvin/marvin/lib/base.py f0d53a6 
> 
> Diff: https://reviews.apache.org/r/23452/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Re: Review Request 23452: CLOUDSTACK-4840: Automation tests - LB for secondary IP

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23452/#review51364
---

Ship it!


Ship It!

- sanjeev n


On Aug. 22, 2014, 6:24 a.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23452/
> ---
> 
> (Updated Aug. 22, 2014, 6:24 a.m.)
> 
> 
> Review request for cloudstack, suresh sadhu, sailaja mada, sanjeev n, Sowmya 
> Krishnan, and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-4840
> https://issues.apache.org/jira/browse/CLOUDSTACK-4840
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Adding automation tests for LB for secondary IP
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_lb_secondary_ip.py PRE-CREATION 
>   tools/marvin/marvin/config/test_data.py a93b883 
>   tools/marvin/marvin/lib/base.py f0d53a6 
> 
> Diff: https://reviews.apache.org/r/23452/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Review Request 25017: Disabling VPC tests on Hyper-v

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25017/
---

Review request for cloudstack, John Dilley and Santhosh Edukulla.


Repository: cloudstack-git


Description
---

skipping VPC tests on Hyper-v. Made changes to following test scripts to skip 
VPC tests on Hyper-v :
/test/integration/smoke/test_network_acl.py 
b/test/integration/smoke/test_network_acl.py
/test/integration/smoke/test_privategw_acl.py 
b/test/integration/smoke/test_privategw_acl.py
test/integration/smoke/test_vpc_vpn.py b/test/integration/smoke/test_vpc_vpn.py


Diffs
-

  test/integration/smoke/test_network_acl.py 015ebab 
  test/integration/smoke/test_privategw_acl.py cf0f8e3 
  test/integration/smoke/test_vpc_vpn.py 9e8f97f 

Diff: https://reviews.apache.org/r/25017/diff/


Testing
---

Yes


Thanks,

sanjeev n

Re: Review Request 25017: Disabling VPC tests on Hyper-v

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25017/
---

(Updated Aug. 26, 2014, 10 a.m.)


Review request for cloudstack, John Dilley, Santhosh Edukulla, and 
SrikanteswaraRao Talluri.


Repository: cloudstack-git


Description
---

skipping VPC tests on Hyper-v. Made changes to following test scripts to skip 
VPC tests on Hyper-v :
/test/integration/smoke/test_network_acl.py 
b/test/integration/smoke/test_network_acl.py
/test/integration/smoke/test_privategw_acl.py 
b/test/integration/smoke/test_privategw_acl.py
test/integration/smoke/test_vpc_vpn.py b/test/integration/smoke/test_vpc_vpn.py


Diffs
-

  test/integration/smoke/test_network_acl.py 015ebab 
  test/integration/smoke/test_privategw_acl.py cf0f8e3 
  test/integration/smoke/test_vpc_vpn.py 9e8f97f 

Diff: https://reviews.apache.org/r/25017/diff/


Testing
---

Yes


Thanks,

sanjeev n

Review Request 25097: Test script to verify vm deployment with two networks in SG enabled advanced zone

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25097/
---

Review request for cloudstack, suresh sadhu, Santhosh Edukulla, and 
SrikanteswaraRao Talluri.


Repository: cloudstack-git


Description
---

Test script to verify vm deployment with two networks in SG enabled advanced 
zone. 
Involves following steps:
1.Deploy SG enabled advanced zone with only 4 ip addresses in guest ip range 
using simulator
2.Deploy one guest vm in the default shared guest network so that all the IP 
addresses will be consumed
3.Add another guest network in the zone created at step1
4.Deploy vm without passing the network id. It should pick the network with 
sufficient resources


Diffs
-

  test/integration/component/test_advancedsg_networks.py 85ab697 
  tools/marvin/marvin/config/test_data.cfg 5a3d8aa 

Diff: https://reviews.apache.org/r/25097/diff/


Testing
---

@Desc: VM Cannot deploy to second network in advanced SG network ... === 
TestName: test_34_DeployVM_in_SecondSGNetwork | Status : SUCCESS ===
ok

--
Ran 1 test in 357.750s

OK


Thanks,

sanjeev n

Re: Review Request 24055: CLOUDSTACK-2251: Automation test cases for feature - Dedicated guest VLAN ranges per tenant

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24055/#review51756
---

Ship it!


Ship It!

- sanjeev n


On Aug. 22, 2014, 10:14 a.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24055/
> ---
> 
> (Updated Aug. 22, 2014, 10:14 a.m.)
> 
> 
> Review request for cloudstack, suresh sadhu, sailaja mada, sanjeev n, and 
> Sowmya Krishnan.
> 
> 
> Bugs: CLOUDSTACK-2251
> https://issues.apache.org/jira/browse/CLOUDSTACK-2251
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Automation test cases for feature - Dedicated guest VLAN ranges per tenant
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_dedicate_guest_vlan_ranges.py PRE-CREATION 
>   tools/marvin/marvin/lib/base.py f0d53a6 
>   tools/marvin/marvin/lib/common.py 3706456 
> 
> Diff: https://reviews.apache.org/r/24055/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Re: Review Request 22805: CLOUDSTACK-1466:Adding automation tests for Secondary Storage Limits

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22805/#review51758
---

Ship it!


Ship It!

- sanjeev n


On Aug. 27, 2014, 8:31 a.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22805/
> ---
> 
> (Updated Aug. 27, 2014, 8:31 a.m.)
> 
> 
> Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-1466
> https://issues.apache.org/jira/browse/CLOUDSTACK-1466
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Automation tests for Secondary Storage Limits. This patch contains 2 test 
> suites. 2 more test suites to follow.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_ss_domain_limits.py PRE-CREATION 
>   test/integration/component/test_ss_limits.py PRE-CREATION 
>   test/integration/component/test_ss_max_limits.py PRE-CREATION 
>   test/integration/component/test_ss_project_limits.py PRE-CREATION 
>   tools/marvin/marvin/config/test_data.py ade8657 
>   tools/marvin/marvin/lib/base.py 99a541a 
> 
> Diff: https://reviews.apache.org/r/22805/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Review Request 25293: Test script to verify vm deployment with two networks in SG enabled advanced zone

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25293/
---

Review request for cloudstack, suresh sadhu, Santhosh Edukulla, and 
SrikanteswaraRao Talluri.


Repository: cloudstack-git


Description
---

Test script to verify vm deployment with two networks in SG enabled advanced 
zone.
Involves following steps:
1.Deploy SG enabled advanced zone with only 4 ip addresses in guest ip range 
using simulator
2.Deploy one guest vm in the default shared guest network so that all the IP 
addresses will be consumed
3.Add another guest network in the zone created at step1
4.Deploy vm without passing the network id. It should pick the network with 
sufficient resources


Diffs
-

  test/integration/component/test_advancedsg_networks.py 85ab697 
  tools/marvin/marvin/config/test_data.py b658b01 

Diff: https://reviews.apache.org/r/25293/diff/


Testing
---

@Desc: VM Cannot deploy to second network in advanced SG network ... === 
TestName: test_34_DeployVM_in_SecondSGNetwork | Status : SUCCESS ===
ok

--
Ran 1 test in 343.198s

OK


Thanks,

sanjeev n

Review Request 25536: Adding new test case to verify the fix for issue "Exception when attaching data disk to Rhel vm on vSphere"

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25536/
---

Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri.


Repository: cloudstack-git


Description
---

@desc: Exception when attaching data disk to RHEL VM on vSphere
Step1: Confirm that vmware.root.disk.controller = "ide" in Global Settings.
Step2: Register RHEl 6.0 template and deploy a VM.
Step3: Note that the root disk is attached to IDE.
Step4: Create new DATA disk and attempt to attach it to the VM.
Verify that step4 succeeds without any exception


Diffs
-

  test/integration/component/test_escalations_vmware.py PRE-CREATION 
  tools/marvin/marvin/config/test_data.py 4133aba 

Diff: https://reviews.apache.org/r/25536/diff/


Testing
---

Yes


Thanks,

sanjeev n

Review Request 25580: Adding test case to verify fix for issue "Create volume from custom disk offering does not work as expected"

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25580/
---

Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri.


Repository: cloudstack-git


Description
---

@Desc:Create volume from custom disk offering does not work as expected
Step1:Create custom disk offering
Step2:Create Volume with size x
Step3:Attach that volume to a vm
Step4:Create another volume with size y
Step5:Verify that the new volume is created with size Y but not with size X
  


Diffs
-

  test/integration/component/test_escalations_volumes.py db4c3d8 
  tools/marvin/marvin/lib/base.py 04217b2 

Diff: https://reviews.apache.org/r/25580/diff/


Testing
---

Yes

@Desc:Create volume from custom disk offering does not work as expected ... === 
TestName: test_13_volume_custom_disk_size | Status : SUCCESS ===
ok

--
Ran 1 test in 303.508s

OK


Thanks,

sanjeev n

Re: Review Request 25681: Fixed the test_templates.py script bug CLOUDSTACK-7554

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25681/#review53487
---

Ship it!


commit 50990c40423062ed0b724472c95a1d3120b8b66d
Author: Chandan Purushothama 
Date:   Mon Sep 15 21:12:26 2014 -0700

CLOUDSTACK-7554 : Fixed the script - /component/test_templates.py - User 
Account now has permissions to the Template created by Admin

- sanjeev n


On Sept. 16, 2014, 4:21 a.m., Chandan Purushothama wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25681/
> ---
> 
> (Updated Sept. 16, 2014, 4:21 a.m.)
> 
> 
> Review request for cloudstack, sangeetha hariharan, sanjeev n, and Santhosh 
> Edukulla.
> 
> 
> Bugs: CLOUDSTACK-7554
> https://issues.apache.org/jira/browse/CLOUDSTACK-7554
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Two testcases failed due to template permissions issue:
> 
> test_01_create_template_volume
> test_04_template_from_snapshot
> 
> Template created by Admin should have public permissions so that the Regular 
> Account can use it to deploy VMs in the test cases.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_templates.py 01f331e 
> 
> Diff: https://reviews.apache.org/r/25681/diff/
> 
> 
> Testing
> ---
> 
> Testing was not done.
> 
> 
> Thanks,
> 
> Chandan Purushothama
> 
>

Review Request 25771: Adding new test case to verify the fix provided in bug CLOUDSTACK-6172

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25771/
---

Review request for cloudstack and SrikanteswaraRao Talluri.


Bugs: CS-6172
https://issues.apache.org/jira/browse/CS-6172


Repository: cloudstack-git


Description
---

@Desc:Volume is not retaining same uuid when migrating from one storage to 
another.
Step1:Create a volume/data disk
Step2:Verify UUID of the volume
Step3:Migrate the volume to another primary storage within the cluster
Step4:Migrating volume to new primary storage should succeed
Step5:volume UUID should not change even after migration


Diffs
-

  test/integration/component/test_volumes.py 122f2d1 

Diff: https://reviews.apache.org/r/25771/diff/


Testing
---

Yes
@Desc:Volume is not retaining same uuid when migrating from one storage to 
another. ... === TestName: test_01_migrateVolume | Status : SUCCESS ===
ok

--
Ran 1 test in 343.250s

OK


Thanks,

sanjeev n

Review Request 25889: Add more wait time for ssh execute command in case of Hyper-v

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25889/
---

Review request for cloudstack and SrikanteswaraRao Talluri.


Repository: cloudstack-git


Description
---

In case of Hyper-v ssvm/cpvm reboot takes more time than other hypervisors. So 
made changes to get_process_status accordingly.


Diffs
-

  tools/marvin/marvin/lib/utils.py c52e277 

Diff: https://reviews.apache.org/r/25889/diff/


Testing
---

Yes


Thanks,

sanjeev n

Re: Review Request 25771: Adding new test case to verify the fix provided in bug CLOUDSTACK-6172

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25771/
---

(Updated Sept. 23, 2014, 6:29 a.m.)


Review request for cloudstack and SrikanteswaraRao Talluri.


Changes
---

Fixed Review Comments


Bugs: CS-6172
https://issues.apache.org/jira/browse/CS-6172


Repository: cloudstack-git


Description
---

@Desc:Volume is not retaining same uuid when migrating from one storage to 
another.
Step1:Create a volume/data disk
Step2:Verify UUID of the volume
Step3:Migrate the volume to another primary storage within the cluster
Step4:Migrating volume to new primary storage should succeed
Step5:volume UUID should not change even after migration


Diffs (updated)
-

  test/integration/component/test_volumes.py 122f2d1 

Diff: https://reviews.apache.org/r/25771/diff/


Testing
---

Yes
@Desc:Volume is not retaining same uuid when migrating from one storage to 
another. ... === TestName: test_01_migrateVolume | Status : SUCCESS ===
ok

--
Ran 1 test in 343.250s

OK


Thanks,

sanjeev n

Re: Review Request 25580: Adding test case to verify fix for issue "Create volume from custom disk offering does not work as expected"

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25580/#review54259
---

Ship it!


commit 0d5a435f7669eddd44a6b62317fe26bb1d96e96c
Author: sanjeev 
Date:   Tue Sep 23 14:15:39 2014 +0530

Creating custom disk does not work as expected

- sanjeev n


On Sept. 12, 2014, 1:32 p.m., sanjeev n wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25580/
> ---
> 
> (Updated Sept. 12, 2014, 1:32 p.m.)
> 
> 
> Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> @Desc:Create volume from custom disk offering does not work as expected
> Step1:Create custom disk offering
> Step2:Create Volume with size x
> Step3:Attach that volume to a vm
> Step4:Create another volume with size y
> Step5:Verify that the new volume is created with size Y but not with size X
>   
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_escalations_volumes.py db4c3d8 
>   tools/marvin/marvin/lib/base.py 04217b2 
> 
> Diff: https://reviews.apache.org/r/25580/diff/
> 
> 
> Testing
> ---
> 
> Yes
> 
> @Desc:Create volume from custom disk offering does not work as expected ... 
> === TestName: test_13_volume_custom_disk_size | Status : SUCCESS ===
> ok
> 
> --
> Ran 1 test in 303.508s
> 
> OK
> 
> 
> Thanks,
> 
> sanjeev n
> 
>

Re: Review Request 25536: Adding new test case to verify the fix for issue "Exception when attaching data disk to Rhel vm on vSphere"

[sanjeev n]

> On Sept. 19, 2014, 6:03 a.m., SrikanteswaraRao Talluri wrote:
> > test/integration/component/test_escalations_vmware.py, line 19
> > <https://reviews.apache.org/r/25536/diff/1/?file=685097#file685097line19>
> >
> > can you please avoid import * ?

commit 5fb2b3a0d24c2bcda0745a6b8ff59fae5651e054
Author: sanjeev 
Date:   Wed Sep 10 11:55:26 2014 +0530

Test to verify fix for issue "Exception when attaching data disk to RHEL vm 
on vSphere

Added Rhel6 template details to test_data.py

Signed-off-by: sanjeev 

Fixed review comments provided in RR 25536


- sanjeev


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25536/#review53939
---


On Sept. 11, 2014, 10:31 a.m., sanjeev n wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25536/
> ---
> 
> (Updated Sept. 11, 2014, 10:31 a.m.)
> 
> 
> Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> @desc: Exception when attaching data disk to RHEL VM on vSphere
> Step1: Confirm that vmware.root.disk.controller = "ide" in Global Settings.
> Step2: Register RHEl 6.0 template and deploy a VM.
> Step3: Note that the root disk is attached to IDE.
> Step4: Create new DATA disk and attempt to attach it to the VM.
> Verify that step4 succeeds without any exception
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_escalations_vmware.py PRE-CREATION 
>   tools/marvin/marvin/config/test_data.py 4133aba 
> 
> Diff: https://reviews.apache.org/r/25536/diff/
> 
> 
> Testing
> ---
> 
> Yes
> 
> 
> Thanks,
> 
> sanjeev n
> 
>

Re: Review Request 25293: Test script to verify vm deployment with two networks in SG enabled advanced zone

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25293/
---

(Updated Sept. 26, 2014, 10:15 a.m.)


Review request for cloudstack, suresh sadhu, Santhosh Edukulla, and 
SrikanteswaraRao Talluri.


Changes
---

Incorporated review comments


Repository: cloudstack-git


Description
---

Test script to verify vm deployment with two networks in SG enabled advanced 
zone.
Involves following steps:
1.Deploy SG enabled advanced zone with only 4 ip addresses in guest ip range 
using simulator
2.Deploy one guest vm in the default shared guest network so that all the IP 
addresses will be consumed
3.Add another guest network in the zone created at step1
4.Deploy vm without passing the network id. It should pick the network with 
sufficient resources


Diffs (updated)
-

  test/integration/component/test_advancedsg_networks.py 85ab697 
  tools/marvin/marvin/config/test_data.py b658b01 

Diff: https://reviews.apache.org/r/25293/diff/


Testing
---

@Desc: VM Cannot deploy to second network in advanced SG network ... === 
TestName: test_34_DeployVM_in_SecondSGNetwork | Status : SUCCESS ===
ok

--
Ran 1 test in 343.198s

OK


Thanks,

sanjeev n

Re: Review Request 26080: Automation for volume life cycle testPath

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26080/#review54670
---



test/integration/testpaths/testpath_volumelifecycle.py
<https://reviews.apache.org/r/26080/#comment94907>

Replace with validateList



test/integration/testpaths/testpath_volumelifecycle.py
<https://reviews.apache.org/r/26080/#comment94906>

Add new line(\n)



test/integration/testpaths/testpath_volumelifecycle.py
<https://reviews.apache.org/r/26080/#comment94904>

Replace this with validateList



test/integration/testpaths/testpath_volumelifecycle.py
<https://reviews.apache.org/r/26080/#comment94905>

Replace with assertEqual



test/integration/testpaths/testpath_volumelifecycle.py
<https://reviews.apache.org/r/26080/#comment94902>

Please remove this line



test/integration/testpaths/testpath_volumelifecycle.py
<https://reviews.apache.org/r/26080/#comment94903>

Remove the blank lines



test/integration/testpaths/testpath_volumelifecycle.py
<https://reviews.apache.org/r/26080/#comment94908>

move this line after assertion


- sanjeev n


On Sept. 26, 2014, 10:58 a.m., prashant mishra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26080/
> ---
> 
> (Updated Sept. 26, 2014, 10:58 a.m.)
> 
> 
> Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-7632
> https://issues.apache.org/jira/browse/CLOUDSTACK-7632
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Automation for volume life cycle testPath
> 
> 
> Diffs
> -
> 
>   test/integration/testpaths/testpath_volumelifecycle.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26080/diff/
> 
> 
> Testing
> ---
> 
> tested on following setup 
> 
> 1-only shared storage
> 2-local storage + zone wide storage +shared storage
> 
> 
> Thanks,
> 
> prashant mishra
> 
>

Review Request 26488: New Test to verify the fix for issue "The ISO / Template is automatically deleted after download URL expires."

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26488/
---

Review request for cloudstack and SrikanteswaraRao Talluri.


Repository: cloudstack-git


Description
---

Reproduce:
Template created from volume
Template is downloaded (should succeed the first time)
4 hours later the template vanishes.
Now you cannot deploy from this template.


Diffs
-

  test/integration/smoke/misc/test_escalations_templates.py PRE-CREATION 

Diff: https://reviews.apache.org/r/26488/diff/


Testing
---

test01_template_download_URL_expire 
(integration.smoke.misc.test_escalations_templates.TestTemplates) ... === 
TestName: test01_template_download_URL_expire | Status : SUCCESS ===
ok

--
Ran 1 test in 651.143s

OK


Thanks,

sanjeev n

Review Request 30611: Before throwing exception for iso download try one more time

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30611/
---

Review request for cloudstack and SrikanteswaraRao Talluri.


Repository: cloudstack-git


Description
---

Before throwing exception for iso download try one more time


Diffs
-

  tools/marvin/marvin/lib/base.py e38c394 

Diff: https://reviews.apache.org/r/30611/diff/


Testing
---

Yes


Thanks,

sanjeev n

Re: Review Request 30611: Before throwing exception for iso download try one more time

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30611/
---

(Updated Feb. 16, 2015, 6:47 a.m.)


Review request for cloudstack and SrikanteswaraRao Talluri.


Repository: cloudstack-git


Description
---

Before throwing exception for iso download try one more time


Diffs
-

  tools/marvin/marvin/lib/base.py e38c394 

Diff: https://reviews.apache.org/r/30611/diff/


Testing
---

Yes


Thanks,

sanjeev n

Review Request 31189: skip password assignment from services

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31189/
---

Review request for cloudstack and SrikanteswaraRao Talluri.


Repository: cloudstack-git


Description
---

If self.password is available skip password assignement from test data


Diffs
-

  tools/marvin/marvin/lib/base.py 7443373 

Diff: https://reviews.apache.org/r/31189/diff/


Testing
---

yes


Thanks,

sanjeev n

Review Request 31476: If password is defined in vm response then skip password assignement

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31476/
---

Review request for cloudstack and SrikanteswaraRao Talluri.


Repository: cloudstack-git


Description
---

If password is defined in vm response then skip password assignement


Diffs
-

  tools/marvin/marvin/lib/base.py 7443373 

Diff: https://reviews.apache.org/r/31476/diff/


Testing
---

Yes


Thanks,

sanjeev n

Re: [ANNOUNCE] Rohit Yadav as new PMC member of CloudStack

[Sanjeev N]

Congrats Rohit!!

On Fri, Mar 27, 2015 at 2:06 PM, Jayapal Reddy Uradi <
jayapalreddy.ur...@citrix.com> wrote:

> Congrats Bhaisaab :)
>
> On 27-Mar-2015, at 2:01 PM, Funs Kessen  wrote:
>
> > Congrats Rohit, awesome!
> >
> >> On 27 Mar 2015, at 09:20, Remi Bergsma 
> wrote:
> >>
> >> Congratz Rohit, well deserved! :-)
> >>
> >> Sent from my iPhone
> >>
> >>> On 27 Mar 2015, at 09:08, Sebastien Goasguen  wrote:
> >>>
> >>> The Project Management Committee (PMC) for Apache CloudStack are
> pleased to
> >>> announce that Rohit Yadav has accepted our invitation to join the PMC.
> >>>
> >>> Please join me in congratulating him.
> >>>
> >>> On behalf of the Apache CloudStack PMC
> >>
> >
> > —
> >   =Funs
> >
>
>

Re: [DISCUSS] Stop using Review Board

[Sanjeev N]

+1

On Mon, Mar 30, 2015 at 3:58 PM, Raja Pullela 
wrote:

> +1 for GitHub...
>
> Some of us are already using GH and any new review requests on RB,
> reviewers should ask for the owners to post them to GH.
> Otherwise, there is no easy way to stop people from using RB ?
>
> -Original Message-
> From: Sebastien Goasguen [mailto:run...@gmail.com]
> Sent: Monday, March 30, 2015 12:52 PM
> To: dev@cloudstack.apache.org
> Subject: Re: [DISCUSS] Stop using Review Board
>
>
> > On Mar 30, 2015, at 7:39 AM, Kishan Kavala 
> wrote:
> >
> > +1 for GitHub
> >
> > Can we do a one-time migration of all open RB requests to GH and make RB
> read-only?
> >
>
> I don’t think we can do an automatic migration. We should all check RB in
> the coming days, try to close the one we can and contact the authors we
> know.
>
> I would like to keep this DISCUSS open till next friday, since it’s a
> relatively big change. At that time, I will check with infra if we can make
> RB read only.
>
>
> > -Original Message-
> > From: Rajani Karuturi [mailto:raj...@apache.org]
> > Sent: Monday, March 30, 2015 10:33 AM
> > To: dev@cloudstack.apache.org
> > Subject: Re: [DISCUSS] Stop using Review Board
> >
> > +1
> >
> > ~Rajani
> >
> > On Fri, Mar 27, 2015 at 9:00 PM, Mike Tutkowski <
> mike.tutkow...@solidfire.com> wrote:
> >
> >> +1
> >>
> >> On Fri, Mar 27, 2015 at 2:52 AM, Sebastien Goasguen
> >> 
> >> wrote:
> >>
> >>> Hi everyone,
> >>>
> >>> Since GitHub pull requests have been enabled for cloudstack, we have
> >>> closed 127 commits.
> >>>
> >>> I believe this is a nicer interface, one that folks are used to when
> >>> contributing to other open source projects.
> >>>
> >>> In the meantime, we still have 73 open reviews on Review Board
> >>>
> >>> https://reviews.apache.org/
> >>>
> >>> * I propose that we stop using RB all together, and remove any links
> >>> to
> >> it
> >>> from our website and README.
> >>>
> >>> A few of us have tried to close some of the reviews by pinging the
> >> authors
> >>> already.
> >>>
> >>> * My second proposition is that we write a comment in all reviews:
> >>>
> >>> “Thanks for the patch, the cloudstack community has decided to stop
> >>> using Review Board in favor of github pull request.
> >>> You can see  to learn how to submit a pull request to cloudstack.
> >>> Could you move your patch to a PR ?
> >>> Without response from you we will close this review within 7 days.
> >>> "
> >>>
> >>> There is good contribution guidelines in our docs README:
> >>> https://github.com/apache/cloudstack-docs
> >>>
> >>> -Sebastien
> >>
> >>
> >>
> >>
> >> --
> >> *Mike Tutkowski*
> >> *Senior CloudStack Developer, SolidFire Inc.*
> >> e: mike.tutkow...@solidfire.com
> >> o: 303.746.7302
> >> Advancing the way the world uses the cloud
> >> *™*
> >>
>
>

Re: Migrating to VPC/Site-to-Site VPN

[Sanjeev N]

As Erik mentioned, we can add nic from VPC network to existing vms so the
vms will be in both isolated(non-vpc) and vpc networks.

On Wed, Apr 1, 2015 at 11:56 AM, Erik Weber  wrote:

> Haven't tried it myself, but i think you should be able to create the vpc
> and change nic on VMs.
>
> If you want to keep the ip addresses you might have to use the api
>
> Erik
>
> Den onsdag 1. april 2015 skrev Logan Barfield 
> følgende:
>
> > We have a customer that is currently set up in an isolated network in
> > an advanced zone.  They recently mentioned that they have a need for
> > site-to-site VPN connectivity for their application.
> >
> > Is it possible to move an existing isolated network into a VPC for
> > site-to-site VPN functionality?  Or is there another way to set up a
> > site-to-site VPN using the existing network?
> >
> >
> > Thank You,
> >
> > Logan Barfield
> > Tranquil Hosting
> >
>

Re: Migrating to VPC/Site-to-Site VPN

[Sanjeev N]

It is not possible to add existing network/VR to a VPC.

On Wed, Apr 1, 2015 at 8:03 PM, Logan Barfield 
wrote:

> That's what I figured.  We were hoping to be able to set up
> site-to-site VPN on the existing network.  If a VPC is just a supernet
> to multiple virtual routers it seems like it would be feasible to
> seamlessly add an existing network/VR to a VPC.
>
> Since this isn't possible now I guess opening a feature request for it
> would be good, in case we run into a similar issue next year.  Before
> I do, does anyone know if this is technically possible, just not yet
> coded?  In other words, could I theoretically add an existing isolated
> network/VR to a VPC seamlessly via updating the database or manually
> changing something on the VR?  If so I would think adding the code to
> handle that task would be relatively easy.
>
> Thank You,
>
> Logan Barfield
> Tranquil Hosting
>
>
> On Wed, Apr 1, 2015 at 3:20 AM, Sanjeev N  wrote:
> > As Erik mentioned, we can add nic from VPC network to existing vms so the
> > vms will be in both isolated(non-vpc) and vpc networks.
> >
> > On Wed, Apr 1, 2015 at 11:56 AM, Erik Weber  wrote:
> >
> >> Haven't tried it myself, but i think you should be able to create the
> vpc
> >> and change nic on VMs.
> >>
> >> If you want to keep the ip addresses you might have to use the api
> >>
> >> Erik
> >>
> >> Den onsdag 1. april 2015 skrev Logan Barfield 
> >> følgende:
> >>
> >> > We have a customer that is currently set up in an isolated network in
> >> > an advanced zone.  They recently mentioned that they have a need for
> >> > site-to-site VPN connectivity for their application.
> >> >
> >> > Is it possible to move an existing isolated network into a VPC for
> >> > site-to-site VPN functionality?  Or is there another way to set up a
> >> > site-to-site VPN using the existing network?
> >> >
> >> >
> >> > Thank You,
> >> >
> >> > Logan Barfield
> >> > Tranquil Hosting
> >> >
> >>
>

Re: [ANNOUNCE] New committer: Gaurav Nandkumar Aradhye

[Sanjeev N]

Congrats Gaurav!!

On Tue, Apr 14, 2015 at 9:34 AM, Jayapal Reddy Uradi <
jayapalreddy.ur...@citrix.com> wrote:

> Congrats Gaurav!
>
> -Jayapal
>
> On 14-Apr-2015, at 9:10 AM, Rajani Karuturi 
>  wrote:
>
> > congratulations Gaurav..
> >
> > ~Rajani
> >
> > On Tue, Apr 14, 2015 at 1:35 AM, Erik Weber  wrote:
> >
> >> On Mon, Apr 13, 2015 at 9:43 PM, Daan Hoogland  >
> >> wrote:
> >>
> >>> The Project Management Committee (PMC) for Apache CloudStack
> >>> has asked Gaurav Aradhya to become a committer and we are pleased to
> >>> announce that they have accepted.
> >>>
> >>> Being a committer allows many contributors to contribute more
> >>> autonomously. For developers, it makes it easier to submit changes and
> >>> eliminates the need to have contributions reviewed via the patch
> >>> submission process. Whether contributions are development-related or
> >>> otherwise, it is a recognition of a contributor's participation in the
> >>> project and commitment to the project and the Apache Way.
> >>>
> >>> Please join me in congratulating Gaurav
> >>>
> >>>
> >> Well deserved, welcome!
> >> Congratulations :-)
> >>
> >> --
> >> Erik
> >>
>
>

Re: Review Request 29843: CLOUDSTACK-8149: Code-refactor - test_VirtualRouter_alerts.py

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29843/#review67827
---



test/integration/component/test_VirtualRouter_alerts.py
<https://reviews.apache.org/r/29843/#comment111915>

Why are we just checking for dnsmasq process status? Why don't we stop it 
for the monitor service to start?



test/integration/component/test_VirtualRouter_alerts.py
<https://reviews.apache.org/r/29843/#comment111916>

Read the router.alerts.check.interval value from Global settings and add 
10mins instead of hard coding the value in time.sleep()


- sanjeev n


On Jan. 13, 2015, 7:04 a.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29843/
> ---
> 
> (Updated Jan. 13, 2015, 7:04 a.m.)
> 
> 
> Review request for cloudstack and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-8149
> https://issues.apache.org/jira/browse/CLOUDSTACK-8149
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> The test case needed a major code-refactor. Also it had import issues and 
> pep8 issues. Fixed those too.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_VirtualRouter_alerts.py bff12f9 
> 
> Diff: https://reviews.apache.org/r/29843/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Re: Review Request 29620: CLOUDSTACK-8143: Corrected a test in BVT test_routers.py

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29620/#review67838
---

Ship it!


Ship It!

- sanjeev n


On Jan. 6, 2015, 7:37 a.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29620/
> ---
> 
> (Updated Jan. 6, 2015, 7:37 a.m.)
> 
> 
> Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-8143
> https://issues.apache.org/jira/browse/CLOUDSTACK-8143
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> The test case test_03_restart_network_cleanup is restarting the network with 
> cleanup=True and verifying that the linklocalip of the new router should be 
> different than the linklocalip of the old router.
> 
> However this may not be true as the linklocalip is assigned randomly and 
> hence can be same for the new router.
> 
> The test case should instead check that the publicip of the new router should 
> be the same as publicip of the old router.
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/test_routers.py 7d5f267 
> 
> Diff: https://reviews.apache.org/r/29620/diff/
> 
> 
> Testing
> ---
> 
> Test router internal basic zone ... SKIP: Skip
> Test router internal advanced zone ... SKIP: Skip
> Test restart network ... === TestName: test_03_restart_network_cleanup | 
> Status : SUCCESS ===
> ok
> Test restart network without cleanup ... SKIP: Skip
> Test router basic setup ... SKIP: Skip
> Test router advanced setup ... SKIP: Skip
> Test stop router ... SKIP: Skip
> Test start router ... SKIP: Skip
> Test reboot router ... SKIP: Skip
> 
> --
> Ran 9 tests in 231.829s
> 
> OK (SKIP=8)
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Re: Review Request 29620: CLOUDSTACK-8143: Corrected a test in BVT test_routers.py

[sanjeev n]

> On Jan. 13, 2015, 11:10 a.m., sanjeev n wrote:
> > Ship It!

commit 9f55411295c9abc843a49f226691a6b720fb0c07
Author: Ashutosh K 
Date:   Tue Jan 6 12:54:49 2015 +0530

CLOUDSTACK-8143: Corrected a test in BVT test_routers.py


- sanjeev


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29620/#review67838
---


On Jan. 6, 2015, 7:37 a.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29620/
> ---
> 
> (Updated Jan. 6, 2015, 7:37 a.m.)
> 
> 
> Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-8143
> https://issues.apache.org/jira/browse/CLOUDSTACK-8143
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> The test case test_03_restart_network_cleanup is restarting the network with 
> cleanup=True and verifying that the linklocalip of the new router should be 
> different than the linklocalip of the old router.
> 
> However this may not be true as the linklocalip is assigned randomly and 
> hence can be same for the new router.
> 
> The test case should instead check that the publicip of the new router should 
> be the same as publicip of the old router.
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/test_routers.py 7d5f267 
> 
> Diff: https://reviews.apache.org/r/29620/diff/
> 
> 
> Testing
> ---
> 
> Test router internal basic zone ... SKIP: Skip
> Test router internal advanced zone ... SKIP: Skip
> Test restart network ... === TestName: test_03_restart_network_cleanup | 
> Status : SUCCESS ===
> ok
> Test restart network without cleanup ... SKIP: Skip
> Test router basic setup ... SKIP: Skip
> Test router advanced setup ... SKIP: Skip
> Test stop router ... SKIP: Skip
> Test start router ... SKIP: Skip
> Test reboot router ... SKIP: Skip
> 
> --
> Ran 9 tests in 231.829s
> 
> OK (SKIP=8)
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Re: Review Request 29620: CLOUDSTACK-8143: Corrected a test in BVT test_routers.py

[sanjeev n]

> On Jan. 13, 2015, 11:10 a.m., sanjeev n wrote:
> > Ship It!
> 
> sanjeev n wrote:
> commit 9f55411295c9abc843a49f226691a6b720fb0c07
> Author: Ashutosh K 
> Date:   Tue Jan 6 12:54:49 2015 +0530
> 
> CLOUDSTACK-8143: Corrected a test in BVT test_routers.py

Commit on ACS 4.5:
commit 2ed76b2a55f843053e51d243a1545e92307a0012
Author: Ashutosh K 
Date:   Tue Jan 6 12:54:49 2015 +0530

CLOUDSTACK-8143: Corrected a test in BVT test_routers.py


- sanjeev


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29620/#review67838
---


On Jan. 6, 2015, 7:37 a.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29620/
> ---
> 
> (Updated Jan. 6, 2015, 7:37 a.m.)
> 
> 
> Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-8143
> https://issues.apache.org/jira/browse/CLOUDSTACK-8143
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> The test case test_03_restart_network_cleanup is restarting the network with 
> cleanup=True and verifying that the linklocalip of the new router should be 
> different than the linklocalip of the old router.
> 
> However this may not be true as the linklocalip is assigned randomly and 
> hence can be same for the new router.
> 
> The test case should instead check that the publicip of the new router should 
> be the same as publicip of the old router.
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/test_routers.py 7d5f267 
> 
> Diff: https://reviews.apache.org/r/29620/diff/
> 
> 
> Testing
> ---
> 
> Test router internal basic zone ... SKIP: Skip
> Test router internal advanced zone ... SKIP: Skip
> Test restart network ... === TestName: test_03_restart_network_cleanup | 
> Status : SUCCESS ===
> ok
> Test restart network without cleanup ... SKIP: Skip
> Test router basic setup ... SKIP: Skip
> Test router advanced setup ... SKIP: Skip
> Test stop router ... SKIP: Skip
> Test start router ... SKIP: Skip
> Test reboot router ... SKIP: Skip
> 
> --
> Ran 9 tests in 231.829s
> 
> OK (SKIP=8)
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Re: Review Request 30157: CLOUDSTACK-8174: Fixed network delete issue in test_add_remove_network.py

[sanjeev n]

> On Jan. 22, 2015, 8:49 a.m., sanjeev n wrote:
> > Ship It!

commit 8894fc897b9e6d20efda6f18f7e9178fa63e87a6
Author: Gaurav Aradhye 
Date:   Wed Jan 21 22:31:24 2015 -0800

CLOUDSTACK-8174: Fixed cleanup issue in test_add_remove_network.py


- sanjeev


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30157/#review69147
---


On Jan. 22, 2015, 7:03 a.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30157/
> ---
> 
> (Updated Jan. 22, 2015, 7:03 a.m.)
> 
> 
> Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-8174
> https://issues.apache.org/jira/browse/CLOUDSTACK-8174
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> The test case failed while cleaning up the network.
> The network will be cleaned up as part of account cleanup, no need to add it 
> separately to the cleanup list.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_add_remove_network.py 2f685b5 
> 
> Diff: https://reviews.apache.org/r/30157/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> LOg:
> Add network to vm with wrong vm id ... === TestName: 
> test_15_add_nic_wrong_vm_id | Status : SUCCESS ===
> ok
> Add network to vm with wrong network id ... === TestName: 
> test_16_add_nic_wrong_network_id | Status : SUCCESS ===
> ok
> Add network to vm where both belong to different zones ... === TestName: 
> test_17_add_nic_different_zone | Status : SUCCESS ===
> ok
> Add network to vm in basic zone ... SKIP: This test requires at least one 
> basic zone to be present in the setup
> Try to add network to vm with insufficient permission ... === TestName: 
> test_26_add_nic_insufficient_permission | Status : SUCCESS ===
> ok
> 
> --
> Ran 5 tests in 285.485s
> 
> OK (SKIP=1)
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 30157: CLOUDSTACK-8174: Fixed network delete issue in test_add_remove_network.py

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30157/#review69147
---

Ship it!


Ship It!

- sanjeev n


On Jan. 22, 2015, 7:03 a.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30157/
> ---
> 
> (Updated Jan. 22, 2015, 7:03 a.m.)
> 
> 
> Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-8174
> https://issues.apache.org/jira/browse/CLOUDSTACK-8174
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> The test case failed while cleaning up the network.
> The network will be cleaned up as part of account cleanup, no need to add it 
> separately to the cleanup list.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_add_remove_network.py 2f685b5 
> 
> Diff: https://reviews.apache.org/r/30157/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> LOg:
> Add network to vm with wrong vm id ... === TestName: 
> test_15_add_nic_wrong_vm_id | Status : SUCCESS ===
> ok
> Add network to vm with wrong network id ... === TestName: 
> test_16_add_nic_wrong_network_id | Status : SUCCESS ===
> ok
> Add network to vm where both belong to different zones ... === TestName: 
> test_17_add_nic_different_zone | Status : SUCCESS ===
> ok
> Add network to vm in basic zone ... SKIP: This test requires at least one 
> basic zone to be present in the setup
> Try to add network to vm with insufficient permission ... === TestName: 
> test_26_add_nic_insufficient_permission | Status : SUCCESS ===
> ok
> 
> --
> Ran 5 tests in 285.485s
> 
> OK (SKIP=1)
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 30067: CLOUDSTACK-8170: Skipping tests on HyperV which try to scale VM in running state because feature not supported

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30067/#review69162
---

Ship it!


Ship It!

- sanjeev n


On Jan. 22, 2015, 5:29 a.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30067/
> ---
> 
> (Updated Jan. 22, 2015, 5:29 a.m.)
> 
> 
> Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-8170
> https://issues.apache.org/jira/browse/CLOUDSTACK-8170
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Skipping tests on HyperV because scaling VM in running state is not supported.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_dynamic_compute_offering.py 5215f84 
> 
> Diff: https://reviews.apache.org/r/30067/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 30067: CLOUDSTACK-8170: Skipping tests on HyperV which try to scale VM in running state because feature not supported

[sanjeev n]

> On Jan. 22, 2015, 11:09 a.m., sanjeev n wrote:
> > Ship It!

commit d37c1589bea8a02c9dd8c17254b96d9fb01d70b3
Author: Gaurav Aradhye 
Date:   Tue Jan 20 16:18:08 2015 +0530

CLOUDSTACK-8170: Skipping tests on HyperV which try to scale VM in running 
state because feature not supported


- sanjeev


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30067/#review69162
---


On Jan. 22, 2015, 5:29 a.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30067/
> ---
> 
> (Updated Jan. 22, 2015, 5:29 a.m.)
> 
> 
> Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-8170
> https://issues.apache.org/jira/browse/CLOUDSTACK-8170
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Skipping tests on HyperV because scaling VM in running state is not supported.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_dynamic_compute_offering.py 5215f84 
> 
> Diff: https://reviews.apache.org/r/30067/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 29845: CLOUDSTACK-8152: Adding delay before creating snapshot/template from root disk after writing data to disk - test_vm_passwordenabled.py

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29845/#review69164
---

Ship it!


Ship It!

- sanjeev n


On Jan. 22, 2015, 5:29 a.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29845/
> ---
> 
> (Updated Jan. 22, 2015, 5:29 a.m.)
> 
> 
> Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-8152
> https://issues.apache.org/jira/browse/CLOUDSTACK-8152
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Due to timing issue, sometimes data gets lost if snapshot/template is created 
> from root volume immediately after writing data to disk. Add delay to bypass 
> this issue.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_vm_passwdenabled.py d998ed5 
> 
> Diff: https://reviews.apache.org/r/29845/diff/
> 
> 
> Testing
> ---
> 
> Test get VM password for password enabled template ... === TestName: 
> test_11_get_vm_password | Status : SUCCESS ===
> ok
> 
> --
> Ran 1 test in 751.495s
> 
> OK
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 29845: CLOUDSTACK-8152: Adding delay before creating snapshot/template from root disk after writing data to disk - test_vm_passwordenabled.py

[sanjeev n]

> On Jan. 22, 2015, 11:22 a.m., sanjeev n wrote:
> > Ship It!

commit 2db5ee3c0a5d40cdc4d5de60b2f8f3afca32e57f
Author: Gaurav Aradhye 
Date:   Tue Jan 13 13:56:41 2015 +0530

CLOUDSTACK-8152: Adding delay before creating snapshot/template from root 
disk after writing data to disk - test_vm_passwordenabled.py


- sanjeev


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29845/#review69164
---


On Jan. 22, 2015, 5:29 a.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29845/
> ---
> 
> (Updated Jan. 22, 2015, 5:29 a.m.)
> 
> 
> Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-8152
> https://issues.apache.org/jira/browse/CLOUDSTACK-8152
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Due to timing issue, sometimes data gets lost if snapshot/template is created 
> from root volume immediately after writing data to disk. Add delay to bypass 
> this issue.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_vm_passwdenabled.py d998ed5 
> 
> Diff: https://reviews.apache.org/r/29845/diff/
> 
> 
> Testing
> ---
> 
> Test get VM password for password enabled template ... === TestName: 
> test_11_get_vm_password | Status : SUCCESS ===
> ok
> 
> --
> Ran 1 test in 751.495s
> 
> OK
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: [GitHub] cloudstack pull request: CLOUDSTACK-9121: Adding VmSnapshot valida...

[Sanjeev N]

LGTM!!

Test revert snapshot on XenServer ... === TestName:
test_01_check_revert_snapshot | Status : SUCCESS ===

ok



--

Ran 1 test in 132.503s



OK

On Wed, Dec 23, 2015 at 5:44 PM, pvr9711  wrote:

> Github user pvr9711 commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/1190#issuecomment-166878697
>
> @remibergsma can you please check this commit and merge it in?
> Thanks, Raja
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

Re: [GitHub] cloudstack pull request: CLOUDSTACK-9041: Modifying template creat...

[Sanjeev N]

This PR is related to changes in base.py So ran one test which invokes the
changes to make sure the changes works fine.

Check Snapshots size in database ... === TestName:
test_02_snapshot_size_check | Status : SUCCESS ===
ok

--
Ran 1 tests in 385.302s

OK

On Mon, Dec 28, 2015 at 6:08 PM, sanju1010  wrote:

> Github user sanju1010 commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/1041#issuecomment-167562620
>
> I will post test results. LGTM !!
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

Re: [GitHub] cloudstack pull request: Test to create vpn customer gateway with ...

[Sanjeev N]

Makes sense. I will add code to list vpn customer gateways and will check
if the response contains the customer gateway or not.

On Tue, Jan 5, 2016 at 3:55 PM, DaanHoogland  wrote:

> Github user DaanHoogland commented on a diff in the pull request:
>
> https://github.com/apache/cloudstack/pull/1308#discussion_r48831039
>
> --- Diff: test/integration/component/test_vpc.py ---
> @@ -2490,3 +2498,23 @@ def test_21_deploy_vm_with_gateway_ip(self):
>  "Failed to create VM with first ip address in the CIDR as
> the vm ip"
>  )
>  return
> +
> +@attr(tags=["advanced", "intervlan"], required_hardware="false")
> +def test_22_vpn_customer_gw_with_hostname(self):
> +"""
> +Test to create vpn customer gateway with hostname
> +instead of gateway ip address
> +"""
> +try:
> +vpnGw = VpnCustomerGateway.create(
> +self.apiclient,
> +self.services["vpn_customer_gw"],
> +name="test_vpn_customer_gw",
> +gateway="GwWithHostName",
> +cidrlist="10.1.0.0/16"
> +)
> +self.cleanup.append(vpnGw)
> +except Exception as e:
> +self.fail("Creating vpn customer gateway with hostname\
> +  Failed with error :%s" % e)
> +return
> --- End diff --
>
> @sanju1010 shouldn't some assertion that the adding succeeded be added
> here? If some programmer decides to silently ignore an error somewhere this
> test becomes useless.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

Re: [GitHub] cloudstack pull request: [CLOUDSTACK-9215]Test to verify vm deploy...

[Sanjeev N]

Will add some validations

On Fri, Jan 8, 2016 at 7:51 PM, DaanHoogland  wrote:

> Github user DaanHoogland commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/1316#issuecomment-170016433
>
> test succeeds as is :
> ```
> [root@daans-dev-machinina ~]# ssh cs1 nosetests --with-marvin
> --marvin-config=/data/shared/marvin/mct-zone1-kvm1-kvm2.cfg  -s -a
> tags=advanced,required_hardware=true
> /data/git/cs1/cloudstack/test/integration/component/maint/test_vpc.py
> root@cs1's password:
>
>  Marvin Init Started 
>
> === Marvin Parse Config Successful ===
>
> === Marvin Setting TestData Successful===
>
>  Log Folder Path: /tmp//MarvinLogs//Jan_08_2016_14_17_12_EBMCRT.
> All logs will be available here 
>
> === Marvin Init Logging Successful===
>
>  Marvin Init Successful 
> ===final results are now copied to: /tmp//MarvinLogs/test_vpc_1F4ULR===
> ```
>
> LGTM but seems less useful due to my remark on line 354
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>