----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19399/#review42136 -----------------------------------------------------------
Tried to apply it on master but it failed. Please rebase with master. Error messages are as follows: [root@cent62-Sanjeev acs-repo]# git apply /root/0001-CLOUDSTACK-6257-Adding-function-to-check-state-of-VM.patch error: patch failed: tools/marvin/marvin/codes.py:31 error: tools/marvin/marvin/codes.py: patch does not apply error: patch failed: tools/marvin/marvin/lib/base.py:22 error: tools/marvin/marvin/lib/base.py: patch does not apply - sanjeev n On April 28, 2014, 10:41 a.m., Ashutosh Kelkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19399/ > ----------------------------------------------------------- > > (Updated April 28, 2014, 10:41 a.m.) > > > Review request for cloudstack and Santhosh Edukulla. > > > Bugs: CLOUDSTACK-6257 > https://issues.apache.org/jira/browse/CLOUDSTACK-6257 > > > Repository: cloudstack-git > > > Description > ------- > > As suggested, added getState method for VirtualMachine class, and it is > called before template creation. If VM fails to go into desired state, it > returns failure. > > > Diffs > ----- > > tools/marvin/marvin/codes.py 28e907c > tools/marvin/marvin/lib/base.py d753098 > > Diff: https://reviews.apache.org/r/19399/diff/ > > > Testing > ------- > > Yes. > > > Thanks, > > Ashutosh Kelkar > >
