----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24055/#review50850 -----------------------------------------------------------
test/integration/component/test_dedicate_guest_vlan_ranges.py <https://reviews.apache.org/r/24055/#comment88722> Add assertions to check whether the vlan dedecation is success or not. Applies to account2 as well. test/integration/component/test_dedicate_guest_vlan_ranges.py <https://reviews.apache.org/r/24055/#comment88723> Add assertion since this is where the actual test is happening. test/integration/component/test_dedicate_guest_vlan_ranges.py <https://reviews.apache.org/r/24055/#comment88724> This assert statement does not make sense because no vlan would be assigned to the network created here. Not sure what would be the value of netowrks[0].vlan when there is no vlan assigned for the network. test/integration/component/test_dedicate_guest_vlan_ranges.py <https://reviews.apache.org/r/24055/#comment88725> Not catching the exception if releasing vlan range fails for some reason. Add code to handle the error in releasing vlan range. - sanjeev n On July 29, 2014, 2:20 p.m., Ashutosh Kelkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24055/ > ----------------------------------------------------------- > > (Updated July 29, 2014, 2:20 p.m.) > > > Review request for cloudstack, suresh sadhu, sailaja mada, sanjeev n, and > Sowmya Krishnan. > > > Bugs: CLOUDSTACK-2251 > https://issues.apache.org/jira/browse/CLOUDSTACK-2251 > > > Repository: cloudstack-git > > > Description > ------- > > Automation test cases for feature - Dedicated guest VLAN ranges per tenant > > > Diffs > ----- > > test/integration/component/test_dedicate_guest_vlan_ranges.py PRE-CREATION > tools/marvin/marvin/lib/base.py 58033c6 > tools/marvin/marvin/lib/common.py 187ede6 > > Diff: https://reviews.apache.org/r/24055/diff/ > > > Testing > ------- > > Yes. > > > Thanks, > > Ashutosh Kelkar > >
