----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29620/#review67838 -----------------------------------------------------------
Ship it! Ship It! - sanjeev n On Jan. 6, 2015, 7:37 a.m., Ashutosh Kelkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29620/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2015, 7:37 a.m.) > > > Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-8143 > https://issues.apache.org/jira/browse/CLOUDSTACK-8143 > > > Repository: cloudstack-git > > > Description > ------- > > The test case test_03_restart_network_cleanup is restarting the network with > cleanup=True and verifying that the linklocalip of the new router should be > different than the linklocalip of the old router. > > However this may not be true as the linklocalip is assigned randomly and > hence can be same for the new router. > > The test case should instead check that the publicip of the new router should > be the same as publicip of the old router. > > > Diffs > ----- > > test/integration/smoke/test_routers.py 7d5f267 > > Diff: https://reviews.apache.org/r/29620/diff/ > > > Testing > ------- > > Test router internal basic zone ... SKIP: Skip > Test router internal advanced zone ... SKIP: Skip > Test restart network ... === TestName: test_03_restart_network_cleanup | > Status : SUCCESS === > ok > Test restart network without cleanup ... SKIP: Skip > Test router basic setup ... SKIP: Skip > Test router advanced setup ... SKIP: Skip > Test stop router ... SKIP: Skip > Test start router ... SKIP: Skip > Test reboot router ... SKIP: Skip > > ---------------------------------------------------------------------- > Ran 9 tests in 231.829s > > OK (SKIP=8) > > > Thanks, > > Ashutosh Kelkar > >
