----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14319/#review27374 -----------------------------------------------------------
test/integration/component/test_non_contiguous_vlan.py <https://reviews.apache.org/r/14319/#comment53230> This test would fail if the existing vlan rang is say 4090-4095. In this case code execution will go to elif block and the ranges will be like as follows: 4093-4092,4091-4090,4093-4090 which are not valid vlan ranges(higher to lower number). Please change the logic in elif block. test/integration/component/test_non_contiguous_vlan.py <https://reviews.apache.org/r/14319/#comment53231> Instead of simply depending on updatePhysicalNetworkResponse parameter for fail/passing the test case also list the updated physical netowrk, read the vlan info and validate it. This applies to all the tests. test/integration/component/test_non_contiguous_vlan.py <https://reviews.apache.org/r/14319/#comment53232> No validation to check step3 mentioned in the dotted strings in the test. Please add code to validate step3. - sanjeev n On Oct. 23, 2013, 9:01 a.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14319/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2013, 9:01 a.m.) > > > Review request for cloudstack, bharat kumar and sanjeev n. > > > Repository: cloudstack-git > > > Description > ------- > > Adding Automation test cases for feature - Non Contiguous VLAN ranges > CLOUDSTACk 2238. > > > Diffs > ----- > > test/integration/component/test_non_contiguous_vlan.py PRE-CREATION > > Diff: https://reviews.apache.org/r/14319/diff/ > > > Testing > ------- > > Tested locally on XenServer Setup > > Log: > > test_01 (test_non_contiguous_vlan.TestNonContiguousVLANRanges) ... ok > test_02 (test_non_contiguous_vlan.TestNonContiguousVLANRanges) ... ok > test_03 (test_non_contiguous_vlan.TestNonContiguousVLANRanges) ... ok > test_04 (test_non_contiguous_vlan.TestNonContiguousVLANRanges) ... ok > test_05 (test_non_contiguous_vlan.TestNonContiguousVLANRanges) ... ok > > ---------------------------------------------------------------------- > Ran 5 tests in 22.387s > > OK > > > Thanks, > > Gaurav Aradhye > >
