----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29843/#review67827 -----------------------------------------------------------
test/integration/component/test_VirtualRouter_alerts.py <https://reviews.apache.org/r/29843/#comment111915> Why are we just checking for dnsmasq process status? Why don't we stop it for the monitor service to start? test/integration/component/test_VirtualRouter_alerts.py <https://reviews.apache.org/r/29843/#comment111916> Read the router.alerts.check.interval value from Global settings and add 10mins instead of hard coding the value in time.sleep() - sanjeev n On Jan. 13, 2015, 7:04 a.m., Ashutosh Kelkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29843/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2015, 7:04 a.m.) > > > Review request for cloudstack and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-8149 > https://issues.apache.org/jira/browse/CLOUDSTACK-8149 > > > Repository: cloudstack-git > > > Description > ------- > > The test case needed a major code-refactor. Also it had import issues and > pep8 issues. Fixed those too. > > > Diffs > ----- > > test/integration/component/test_VirtualRouter_alerts.py bff12f9 > > Diff: https://reviews.apache.org/r/29843/diff/ > > > Testing > ------- > > Yes. > > > Thanks, > > Ashutosh Kelkar > >
