Error while starting Management server

[Ritu Sabharwal]

Hi,

I am new to the CloudStack development and trying to get the management server 
up for testing.

I am following instruction from wiki page:  
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Setting+up+a+CloudStack+dev+environment+on+Windows

I got the latest code from git. I build, setup db and trying to jetty server on 
Windows Server 2008.

But jetty server is not coming up.

I am getting following error:

[ERROR] Failed startup of context 
org.mortbay.jetty.plugin.Jetty6PluginWebAppContext@7160a9b9{/client,C:\cygwin\home\rsabharw\cloudstack-oss\cloudstack\client\target\generated-webapp}
org.springframework.beans.factory.BeanCreationException: Error creating bean 
with name 'accountManagerImpl': Injection of autowired dependencies failed; 
nested exception is org.springframework.beans.factory.BeanCreationException: 
Could not autowire field: private com.cloud.storage.dao.VMTemplateDao 
com.cloud.user.AccountManagerImpl._templateDao; nested exception is 
org.springframework.beans.factory.BeanCreationException: Error creating bean 
with name 'VMTemplateDaoImpl': Injection of autowired dependencies failed; 
nested exception is org.springframework.beans.factory.BeanCreationException: 
Could not autowire field: 
org.apache.cloudstack.storage.datastore.db.TemplateDataStoreDao 
com.cloud.storage.dao.VMTemplateDaoImpl._templateDataStoreDao; nested exception 
is org.springframework.beans.factory.BeanCreationException: Error creating bean 
with name 'templateDataStoreDaoImpl': Injection of autowired dependencies 
failed; nested exception is 
org.springframework.beans.factory.BeanCreationException: Could not autowire 
field: private 
org.apache.cloudstack.engine.subsystem.api.storage.DataStoreManager 
org.apache.cloudstack.storage.image.db.TemplateDataStoreDaoImpl._storeMgr; 
nested exception is org.springframework.beans.factory.BeanCreationException: 
Error creating bean with name 'dataStoreProviderManager': Injection of 
autowired dependencies failed; nested exception is 
org.springframework.beans.factory.BeanCreationException: Could not autowire 
field: org.apache.cloudstack.storage.datastore.PrimaryDataStoreProviderManager 
org.apache.cloudstack.storage.datastore.provider.DataStoreProviderManagerImpl.primaryDataStoreProviderMgr;
 nested exception is org.springframework.beans.factory.BeanCreationException: 
Error creating bean with name 'primaryDataStoreProviderMgr': Injection of 
autowired dependencies failed; nested exception is 
org.springframework.beans.factory.BeanCreationException: Could not autowire 
field: com.cloud.storage.StorageManager 
org.apache.cloudstack.storage.datastore.manager.PrimaryDataStoreProviderManagerImpl.storageMgr;
 nested exception is org.springframework.beans.factory.BeanCreationException: 
Error creating bean with name 'storageManagerImpl': Injection of autowired 
dependencies failed; nested exception is 
org.springframework.beans.factory.BeanCreationException: Could not autowire 
field: protected com.cloud.agent.AgentManager 
com.cloud.storage.StorageManagerImpl._agentMgr; nested exception is 
org.springframework.beans.factory.BeanCreationException: Error creating bean 
with name 'clusteredAgentManagerImpl': Injection of autowired dependencies 
failed; nested exception is 
org.springframework.beans.factory.BeanCreationException: Could not autowire 
field: protected com.cloud.ha.HighAvailabilityManager 
com.cloud.agent.manager.AgentManagerImpl._haMgr; nested exception is 
org.springframework.beans.factory.BeanCreationException: Error creating bean 
with name 'highAvailabilityManagerExtImpl': Injection of autowired dependencies 
failed; nested exception is 
org.springframework.beans.factory.BeanCreationException: Could not autowire 
field: com.cloud.alert.AlertManager 
com.cloud.ha.HighAvailabilityManagerImpl._alertMgr; nested exception is 
org.springframework.beans.factory.BeanCreationException: Error creating bean 
with name 'alertManagerImpl': Injection of autowired dependencies failed; 
nested exception is org.springframework.beans.factory.BeanCreationException: 
Could not autowire field: protected com.cloud.capacity.CapacityManager 
com.cloud.alert.AlertManagerImpl._capacityMgr; nested exception is 
org.springframework.beans.factory.BeanCreationException: Error creating bean 
with name 'capacityManagerImpl': Injection of autowired dependencies failed; 
nested exception is org.springframework.beans.factory.BeanCreationException: 
Could not autowire field: com.cloud.resource.ResourceManager 
com.cloud.capacity.CapacityManagerImpl._resourceMgr; nested exception is 
org.springframework.beans.factory.BeanCreationException: Error creating bean 
with name 'resourceManagerImpl': Injection of autowired dependencies failed; 
nested exception is org.springframework.beans.factory.BeanCreationException: 
Could not autowire field: private com.cloud.vm.VirtualMachineManager 
com.cloud.resource.ResourceManagerImpl._vmMgr; nested exception is 
org.springframework.beans.factory.BeanCr

RE: Error while starting Management server

[Ritu Sabharwal]

  at 
org.apache.cloudstack.spring.module.factory.ModuleBasedContextFactory.loadModules(ModuleBasedContextFactory.java:37)
at 
org.apache.cloudstack.spring.module.factory.CloudStackSpringContext.init(CloudStackSpringContext.java:70)
at 
org.apache.cloudstack.spring.module.factory.CloudStackSpringContext.(CloudStackSpringContext.java:57)
at 
org.apache.cloudstack.spring.module.factory.CloudStackSpringContext.(CloudStackSpringContext.java:61)
at 
org.apache.cloudstack.spring.module.web.CloudStackContextLoaderListener.contextInitialized(CloudStackContextLoaderListener.java:52)
at 
org.apache.catalina.core.StandardContext.listenerStart(StandardContext.java:4206)
at 
org.apache.catalina.core.StandardContext.start(StandardContext.java:4705)
at 
org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:799)
at 
org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:779)
at 
org.apache.catalina.core.StandardHost.addChild(StandardHost.java:601)
at 
org.apache.catalina.startup.HostConfig.deployWAR(HostConfig.java:943)
at 
org.apache.catalina.startup.HostConfig.deployWARs(HostConfig.java:778)
at 
org.apache.catalina.startup.HostConfig.deployApps(HostConfig.java:504)
at 
org.apache.catalina.startup.HostConfig.check(HostConfig.java:1385)
at 
org.apache.catalina.startup.HostConfig.lifecycleEvent(HostConfig.java:306)
at 
org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:142)
at 
org.apache.catalina.core.ContainerBase.backgroundProcess(ContainerBase.java:1389)
at 
org.apache.catalina.core.ContainerBase$ContainerBackgroundProcessor.processChildren(ContainerBase.java:1653)
at 
org.apache.catalina.core.ContainerBase$ContainerBackgroundProcessor.processChildren(ContainerBase.java:1662)
at 
org.apache.catalina.core.ContainerBase$ContainerBackgroundProcessor.run(ContainerBase.java:1642)
at java.lang.Thread.run(Unknown Source)

Thanks & Regards,
Ritu S.

From: Ritu Sabharwal
Sent: Thursday, May 01, 2014 3:48 PM
To: 'dev@cloudstack.apache.org'
Subject: Error while starting Management server

Hi,

I am new to the CloudStack development and trying to get the management server 
up for testing.

I am following instruction from wiki page:  
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Setting+up+a+CloudStack+dev+environment+on+Windows

I got the latest code from git. I build, setup db and trying to jetty server on 
Windows Server 2008.

But jetty server is not coming up.

I am getting following error:

[ERROR] Failed startup of context 
org.mortbay.jetty.plugin.Jetty6PluginWebAppContext@7160a9b9{/client,C:\cygwin\home\rsabharw\cloudstack-oss\cloudstack\client\target\generated-webapp}<mailto:org.mortbay.jetty.plugin.Jetty6PluginWebAppContext@7160a9b9%7b/client,C:\cygwin\home\rsabharw\cloudstack-oss\cloudstack\client\target\generated-webapp%7d>
org.springframework.beans.factory.BeanCreationException: Error creating bean 
with name 'accountManagerImpl': Injection of autowired dependencies failed; 
nested exception is org.springframework.beans.factory.BeanCreationException: 
Could not autowire field: private com.cloud.storage.dao.VMTemplateDao 
com.cloud.user.AccountManagerImpl._templateDao; nested exception is 
org.springframework.beans.factory.BeanCreationException: Error creating bean 
with name 'VMTemplateDaoImpl': Injection of autowired dependencies failed; 
nested exception is org.springframework.beans.factory.BeanCreationException: 
Could not autowire field: 
org.apache.cloudstack.storage.datastore.db.TemplateDataStoreDao 
com.cloud.storage.dao.VMTemplateDaoImpl._templateDataStoreDao; nested exception 
is org.springframework.beans.factory.BeanCreationException: Error creating bean 
with name 'templateDataStoreDaoImpl': Injection of autowired dependencies 
failed; nested exception is 
org.springframework.beans.factory.BeanCreationException: Could not autowire 
field: private 
org.apache.cloudstack.engine.subsystem.api.storage.DataStoreManager 
org.apache.cloudstack.storage.image.db.TemplateDataStoreDaoImpl._storeMgr; 
nested exception is org.springframework.beans.factory.BeanCreationException: 
Error creating bean with name 'dataStoreProviderManager': Injection of 
autowired dependencies failed; nested exception is 
org.springframework.beans.factory.BeanCreationException: Could not autowire 
field: org.apache.cloudstack.storage.datastore.PrimaryDataStoreProviderManager 
org.apache.cloudstack.storage.datastore.provider.DataStoreProviderManagerImpl.primaryDataStoreProviderMgr;
 nested exception is org.springframework.beans.factory.BeanCreationException: 
Error creating bean with name 'primaryDataStoreProvi

RE: [PROPOSAL] Using continuous integration to maintain our code quality...

[Ritu Sabharwal]

Hi Alex,

I am a new developer (non-commiter) and getting to learn about the development 
process of CloudStack. 

I have a question about the Jenkins, when you say create a branch for your code 
and ask Jenkins to run BVT on your branch. The branch will be created on my 
local repository but Jenkins would run on central repository. In that case, 
does it mean that I install Jenkins locally on my setup.

Please help.

Thanks,
Ritu S.

-Original Message-
From: Alex Huang [mailto:alex.hu...@citrix.com] 
Sent: Tuesday, May 06, 2014 5:04 PM
To: dev@cloudstack.apache.org
Subject: [PROPOSAL] Using continuous integration to maintain our code quality...

Hi All,

This is something I brought up a long time ago but really didn't have the 
resources to get it all up and running until now.  Throughout the past year, 
Edison, Prasanna, Amogh, Bharat, Koushik, Talluri, and others have been 
chipping away at it.  At this point, we finally pull together a continuous 
integration setup that we can use to make sure that CloudStack master and the 
currently release branch are always stable.  This is getting pretty close to be 
completed and we like to share it with the community in hopes that we can 
reduce/eliminate that problems we've seen with our recent releases.  Currently, 
the physical hardware are hosted by Citrix but we'll be more than willing to 
donate the work to infra when that's all settled.  

This does require effort from the community to make a change in their 
development process.  These steps are detailed at [1].  I like to get feedback 
on what everyone think about this.  

What have we done:
  - We replaced a large selection of the BVT tests to run with the simulator 
instead of actual hardware.  This shortens the duration of each BVT run.  
Today, a BVT that runs tests for XenServer and KVM completes in 30-40 minutes.
  - We will run the new BVT on master and the current release branch on a 
continuous basis.
  - Developers can use Jenkins to ask BVT to be run on their branch so they can 
know it won't break the continuous integration before they merge to master and 
the current release branch.

Please have a read and let me know what you think.

--Alex

[1] https://cwiki.apache.org/confluence/display/CLOUDSTACK/Development+Process

RE: [PROPOSAL] Using continuous integration to maintain our code quality...

[Ritu Sabharwal]

Thanks Alex for the information!

-Original Message-
From: Alex Huang [mailto:alex.hu...@citrix.com] 
Sent: Wednesday, May 07, 2014 2:56 PM
To: Ritu Sabharwal
Cc: dev@cloudstack.apache.org
Subject: RE: [PROPOSAL] Using continuous integration to maintain our code 
quality...

Hi Ritu,

Citrix will provide a Jenkins server that's public accessible that enables you 
to request BVT to be run on your branch.  You don't need to install one 
yourself.  When ASF infra is ready with their hardware, the scripts can be 
donated to ASF and then developers will need to switch over to the Jenkins 
operated by ASF.

As for contributors, I did leave out one important part.  We will try to allow 
for the code to be pulled from github but that might come after CI is made 
available.  For now, you'll have to submit your patch through review board and 
let the reviewer put it through CI for you.

--Alex

> -Original Message-
> From: Ritu Sabharwal [mailto:rsabh...@brocade.com]
> Sent: Wednesday, May 7, 2014 11:23 AM
> To: Alex Huang
> Cc: dev@cloudstack.apache.org
> Subject: FW: [PROPOSAL] Using continuous integration to maintain our 
> code quality...
> 
> Hi Alex,
> 
> I am a new developer (non-commiter) and getting to learn about the 
> development process of CloudStack.
> 
> I have a question about the Jenkins, when you say create a branch for 
> your code and ask Jenkins to run BVT on your branch. The branch will 
> be created on my local repository but Jenkins would run on central 
> repository. In that case, does it mean that I install Jenkins locally 
> on my setup or do I o need to create account on Jenkins and run BVT on my 
> local branch.
> 
> Please help.
> 
> Thanks,
> Ritu S.
> 
> -Original Message-
> From: Alex Huang [mailto:alex.hu...@citrix.com]
> Sent: Tuesday, May 06, 2014 5:04 PM
> To: dev@cloudstack.apache.org
> Subject: [PROPOSAL] Using continuous integration to maintain our code 
> quality...
> 
> Hi All,
> 
> This is something I brought up a long time ago but really didn't have 
> the resources to get it all up and running until now.  Throughout the 
> past year, Edison, Prasanna, Amogh, Bharat, Koushik, Talluri, and 
> others have been chipping away at it.  At this point, we finally pull 
> together a continuous integration setup that we can use to make sure 
> that CloudStack master and the currently release branch are always 
> stable.  This is getting pretty close to be completed and we like to 
> share it with the community in hopes that we can reduce/eliminate that 
> problems we've seen with our recent releases.
> Currently, the physical hardware are hosted by Citrix but we'll be 
> more than willing to donate the work to infra when that's all settled.
> 
> This does require effort from the community to make a change in their 
> development process.  These steps are detailed at [1].  I like to get 
> feedback on what everyone think about this.
> 
> What have we done:
>   - We replaced a large selection of the BVT tests to run with the 
> simulator instead of actual hardware.  This shortens the duration of each BVT 
> run.
> Today, a BVT that runs tests for XenServer and KVM completes in 30-40 
> minutes.
>   - We will run the new BVT on master and the current release branch 
> on a continuous basis.
>   - Developers can use Jenkins to ask BVT to be run on their branch so 
> they can know it won't break the continuous integration before they 
> merge to master and the current release branch.
> 
> Please have a read and let me know what you think.
> 
> --Alex
> 
> [1]
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Development+P
> rocess

FW: [PROPOSAL] Using continuous integration to maintain our code quality...

[Ritu Sabharwal]

Hi Alex,

I am a new developer (non-commiter) and getting to learn about the development 
process of CloudStack. 

I have a question about the Jenkins, when you say create a branch for your code 
and ask Jenkins to run BVT on your branch. The branch will be created on my 
local repository but Jenkins would run on central repository. In that case, 
does it mean that I install Jenkins locally on my setup or do I o need to 
create account on Jenkins and run BVT on my local branch.

Please help.

Thanks,
Ritu S.

-Original Message-
From: Alex Huang [mailto:alex.hu...@citrix.com] 
Sent: Tuesday, May 06, 2014 5:04 PM
To: dev@cloudstack.apache.org
Subject: [PROPOSAL] Using continuous integration to maintain our code quality...

Hi All,

This is something I brought up a long time ago but really didn't have the 
resources to get it all up and running until now.  Throughout the past year, 
Edison, Prasanna, Amogh, Bharat, Koushik, Talluri, and others have been 
chipping away at it.  At this point, we finally pull together a continuous 
integration setup that we can use to make sure that CloudStack master and the 
currently release branch are always stable.  This is getting pretty close to be 
completed and we like to share it with the community in hopes that we can 
reduce/eliminate that problems we've seen with our recent releases.  Currently, 
the physical hardware are hosted by Citrix but we'll be more than willing to 
donate the work to infra when that's all settled.  

This does require effort from the community to make a change in their 
development process.  These steps are detailed at [1].  I like to get feedback 
on what everyone think about this.  

What have we done:
  - We replaced a large selection of the BVT tests to run with the simulator 
instead of actual hardware.  This shortens the duration of each BVT run.  
Today, a BVT that runs tests for XenServer and KVM completes in 30-40 minutes.
  - We will run the new BVT on master and the current release branch on a 
continuous basis.
  - Developers can use Jenkins to ask BVT to be run on their branch so they can 
know it won't break the continuous integration before they merge to master and 
the current release branch.

Please have a read and let me know what you think.

--Alex

[1] https://cwiki.apache.org/confluence/display/CLOUDSTACK/Development+Process

RE: Feature Frezee date for 4.5 release.

[Ritu Sabharwal]

Hi Alex,

What is the Feature freeze date for 4.5 release? We are planning for a plugin 
so wanted to make our project plan accordingly.

Thanks & regards,
Ritu S.

Feature Frezee date for 4.5 release.

[Ritu Sabharwal]

Hi Alex,

What is the Feature freeze date for 4.5 release? We are planning for a plugin 
so wanted to make our project plan accordingly.

Thanks & regards,
Ritu S.

RE: Feature Frezee date for 4.5 release.

[Ritu Sabharwal]

Thanks Daan!

I will send a proposal email soon for the plugin soon to the mailing list .

Thanks & Regards,
Ritu S.

-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] 
Sent: Saturday, May 17, 2014 2:39 AM
To: dev
Cc: Alex Huang
Subject: Re: Feature Frezee date for 4.5 release.

4.4 ffd + 4m => about half august


On Sat, May 17, 2014 at 4:26 AM, Ritu Sabharwal  wrote:
> Hi Alex,
>
> What is the Feature freeze date for 4.5 release? We are planning for a plugin 
> so wanted to make our project plan accordingly.
>
> Thanks & regards,
> Ritu S.



-- 
Daan

How does Jenkins test new plugin for new device support?

[Ritu Sabharwal]

Hi,

I am adding a new plugin for supporting new device.
Once the code is reviewed and committed to Git, would Jenkins run the automated 
tests only for the management server and not the plugin code because it would 
not have the new hardware to test it with.

How does that happen ?

Thanks & Regards,
Ritu S.

[DISCUSS] Brocade network plugin to orchestrate Brocade VCS cluster

[Ritu Sabharwal]

Hi CS Developers,



I am Ritu Sabharwal from Brocade Communications Systems.



I am leading an effort to implement CloudStack Network Plugin ( named Brocade 
VCS plugin) to orchestrate Brocade VCS cluster. We are using 4.3 as the base 
for development.



Initially, the plugin will focus on L2 services. The plugin would automatically 
orchestrate Brocade's VCS cluster when VMs are created and attached to Network.



The tenant isolation is provided via VLAN. When Isolated networks are created 
from CloudStack and allocated VLAN, the same VLANs need to be propagated to the 
VCS cluster as well, so that when a VLAN-tagged packet arrives on a 
switch-port, the switch know which ports to flood the packet.

The Brocade VCS Plugin will orchestrate VCS directly using NETCONF.



In order to find the switch-ports that are connected to the hypervisor hosts, 
the plugin would implement the Pluggable interface and expose Pluggable service 
API for the admin to provide the traffic-label to switch-port mapping.



We will write a NetworkGuru and override the implement() method to:

1.Configure a VLAN interface on VCS.

2.Configure the interface port on VCS.

3.Configure VLAN membership on the interfaces.



Please provide comments and feedback for this proposal.



Thanks & Regards,

Ritu S.

RE: How does Jenkins test new plugin for new device support?

[Ritu Sabharwal]

Hello,

Can someone please answer  this question for me?

Thanks & Regards,
Ritu S.

-Original Message-
From: Ritu Sabharwal [mailto:rsabh...@brocade.com] 
Sent: Wednesday, May 21, 2014 2:28 PM
To: dev@cloudstack.apache.org
Subject: How does Jenkins test new plugin for new device support?

Hi,

I am adding a new plugin for supporting new device.
Once the code is reviewed and committed to Git, would Jenkins run the automated 
tests only for the management server and not the plugin code because it would 
not have the new hardware to test it with.

How does that happen ?

Thanks & Regards,
Ritu S.

RE: [DISCUSS] Brocade network plugin to orchestrate Brocade VCS cluster for CloudStack 4.5

[Ritu Sabharwal]

We are targeting this for CloudStack 4.5 release.

Thanks & Regards,
Ritu S.

-Original Message-
From: Ritu Sabharwal [mailto:rsabh...@brocade.com] 
Sent: Friday, May 23, 2014 11:59 AM
To: dev@cloudstack.apache.org
Cc: Prakash Kaligotla
Subject: [DISCUSS] Brocade network plugin to orchestrate Brocade VCS cluster

Hi CS Developers,



I am Ritu Sabharwal from Brocade Communications Systems.



I am leading an effort to implement CloudStack Network Plugin ( named Brocade 
VCS plugin) to orchestrate Brocade VCS cluster. We are using 4.3 as the base 
for development.



Initially, the plugin will focus on L2 services. The plugin would automatically 
orchestrate Brocade's VCS cluster when VMs are created and attached to Network.



The tenant isolation is provided via VLAN. When Isolated networks are created 
from CloudStack and allocated VLAN, the same VLANs need to be propagated to the 
VCS cluster as well, so that when a VLAN-tagged packet arrives on a 
switch-port, the switch know which ports to flood the packet.

The Brocade VCS Plugin will orchestrate VCS directly using NETCONF.



In order to find the switch-ports that are connected to the hypervisor hosts, 
the plugin would implement the Pluggable interface and expose Pluggable service 
API for the admin to provide the traffic-label to switch-port mapping.



We will write a NetworkGuru and override the implement() method to:

1.Configure a VLAN interface on VCS.

2.Configure the interface port on VCS.

3.Configure VLAN membership on the interfaces.



Please provide comments and feedback for this proposal.



Thanks & Regards,

Ritu S.

RE: [ACS45][ACS50][PROPOSAL] move forward feature freeze

[Ritu Sabharwal]

When  you say release schedule shift, does it mean 4.5 release target is moved 
from Oct '14 to a forward date?

Thanks & Regards,
Ritu S.

-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] 
Sent: Monday, May 26, 2014 5:26 AM
To: dev
Subject: [ACS45][ACS50][PROPOSAL] move forward feature freeze

LS,

When I seeing once again our release schedule shift, I think we have no option 
but to move feature freeze for the next release forward.
This is the only way it seems we can reduce the complexity of the total sum of 
changes. Therefore it is the only way we can prevent lapsing even more in time 
without risking reduced quality of our next release.
So I propose to move feature freeze forward by a month to be at the 19th of 
June (instead of July). I don't think we need to strictly move code freeze 
forward as well but vigilance onto added features will be necessary.

--
Daan

RE: [ACS45][ACS50][PROPOSAL] move forward feature freeze

[Ritu Sabharwal]

Thanks Daan for the clarification!

-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] 
Sent: Tuesday, May 27, 2014 1:56 PM
To: dev
Subject: Re: [ACS45][ACS50][PROPOSAL] move forward feature freeze

What I mean is that to prevent the date of oct '14 moving we need to move the 
feature freeze forward. so we have more time to create the release.

On Tue, May 27, 2014 at 10:45 PM, Ritu Sabharwal  wrote:
> When  you say release schedule shift, does it mean 4.5 release target is 
> moved from Oct '14 to a forward date?
>
> Thanks & Regards,
> Ritu S.
>
> -Original Message-
> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> Sent: Monday, May 26, 2014 5:26 AM
> To: dev
> Subject: [ACS45][ACS50][PROPOSAL] move forward feature freeze
>
> LS,
>
> When I seeing once again our release schedule shift, I think we have no 
> option but to move feature freeze for the next release forward.
> This is the only way it seems we can reduce the complexity of the total sum 
> of changes. Therefore it is the only way we can prevent lapsing even more in 
> time without risking reduced quality of our next release.
> So I propose to move feature freeze forward by a month to be at the 19th of 
> June (instead of July). I don't think we need to strictly move code freeze 
> forward as well but vigilance onto added features will be necessary.
>
> --
> Daan



--
Daan

RE: How does Jenkins test new plugin for new device support?

[Ritu Sabharwal]

Hi Prasanna,

Thanks for the reply. I will keep a watch on other communication thread for 
hardware.

Thanks & Regards,
Ritu S.

-Original Message-
From: Prasanna Santhanam [mailto:t...@apache.org] 
Sent: Tuesday, May 27, 2014 10:24 PM
To: dev@cloudstack.apache.org
Cc: Alex Huang
Subject: Re: How does Jenkins test new plugin for new device support?

Ritu - you're correct. The plugin code at this point does not get tested by our 
CI without the hardware. It has been the onus of the contributor of the plugin 
to test against the hardware. 

Because the project cannot afford to purchase, deploy and test against every 
piece of hardware we depend on the volunteer community to help out. You are 
encouraged to write Marvin tests/unit tests against your hardware and submit 
them to the repo along with the plugin code. In the event of the CI system 
including the hardware at least these tests can be run.

Meanwhile, the project is discussing on hardware requirements in another thread 
which you responded to that AlexH @ Citrix started. If your company is 
interested in donating hardware to the ASF for the testing of its plugin, 
please keep an eye on how you can donate the same so your plugin may be tested 
adequately

On Tue, May 27, 2014 at 10:27:05AM -0700, Ritu Sabharwal wrote:
> Hello,
> 
> Can someone please answer  this question for me?
> 
> Thanks & Regards,
> Ritu S.
> 
> -----Original Message-
> From: Ritu Sabharwal [mailto:rsabh...@brocade.com]
> Sent: Wednesday, May 21, 2014 2:28 PM
> To: dev@cloudstack.apache.org
> Subject: How does Jenkins test new plugin for new device support?
> 
> Hi,
> 
> I am adding a new plugin for supporting new device.
> Once the code is reviewed and committed to Git, would Jenkins run the 
> automated tests only for the management server and not the plugin code 
> because it would not have the new hardware to test it with.
> 
> How does that happen ?
> 
> Thanks & Regards,
> Ritu S.

--
Prasanna.,


Powered by BigRock.com

RE: [DISCUSS] Brocade network plugin to orchestrate Brocade VCS cluster for CloudStack 4.5

[Ritu Sabharwal]

Hi,

Can you please review the proposal and let me know if I need to add anything 
else here?

Thanks & Regards,
Ritu S.

-Original Message-
From: Ritu Sabharwal [mailto:rsabh...@brocade.com] 
Sent: Tuesday, May 27, 2014 10:34 AM
To: dev@cloudstack.apache.org
Subject: RE: [DISCUSS] Brocade network plugin to orchestrate Brocade VCS 
cluster for CloudStack 4.5

We are targeting this for CloudStack 4.5 release.

Thanks & Regards,
Ritu S.

-Original Message-
From: Ritu Sabharwal [mailto:rsabh...@brocade.com] 
Sent: Friday, May 23, 2014 11:59 AM
To: dev@cloudstack.apache.org
Cc: Prakash Kaligotla
Subject: [DISCUSS] Brocade network plugin to orchestrate Brocade VCS cluster

Hi CS Developers,



I am Ritu Sabharwal from Brocade Communications Systems.



I am leading an effort to implement CloudStack Network Plugin ( named Brocade 
VCS plugin) to orchestrate Brocade VCS cluster. We are using 4.3 as the base 
for development.



Initially, the plugin will focus on L2 services. The plugin would automatically 
orchestrate Brocade's VCS cluster when VMs are created and attached to Network.



The tenant isolation is provided via VLAN. When Isolated networks are created 
from CloudStack and allocated VLAN, the same VLANs need to be propagated to the 
VCS cluster as well, so that when a VLAN-tagged packet arrives on a 
switch-port, the switch know which ports to flood the packet.

The Brocade VCS Plugin will orchestrate VCS directly using NETCONF.



In order to find the switch-ports that are connected to the hypervisor hosts, 
the plugin would implement the Pluggable interface and expose Pluggable service 
API for the admin to provide the traffic-label to switch-port mapping.



We will write a NetworkGuru and override the implement() method to:

1.Configure a VLAN interface on VCS.

2.Configure the interface port on VCS.

3.Configure VLAN membership on the interfaces.



Please provide comments and feedback for this proposal.



Thanks & Regards,

Ritu S.

RE: Feature Frezee date for 4.5 release.

[Ritu Sabharwal]

Hi Daan,

We are tracking to deliver our plugin (Brocade Network plugin for VDX switches) 
as per earlier communication of feature freeze for 4.5 release on mid-August. 
Based on your proposal for moving in the code freeze to mid-June is too early 
for us to provide the support for this release. I request to keep the timelines 
to mid-August so that we can provide VDX support from Brocade in 4.5 release.

Thanks & Regards,
Ritu S.

-Original Message-
From: Ritu Sabharwal [mailto:rsabh...@brocade.com] 
Sent: Monday, May 19, 2014 10:32 AM
To: dev@cloudstack.apache.org
Cc: Alex Huang
Subject: RE: Feature Frezee date for 4.5 release.

Thanks Daan!

I will send a proposal email soon for the plugin soon to the mailing list .

Thanks & Regards,
Ritu S.

-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] 
Sent: Saturday, May 17, 2014 2:39 AM
To: dev
Cc: Alex Huang
Subject: Re: Feature Frezee date for 4.5 release.

4.4 ffd + 4m => about half august


On Sat, May 17, 2014 at 4:26 AM, Ritu Sabharwal  wrote:
> Hi Alex,
>
> What is the Feature freeze date for 4.5 release? We are planning for a plugin 
> so wanted to make our project plan accordingly.
>
> Thanks & regards,
> Ritu S.



-- 
Daan

RE: Feature Frezee date for 4.5 release.

[Ritu Sabharwal]

Hi Daan,

Read your amended proposal. Just to clarify, does it mean the feature proposal 
deadline is 19th June and the feature code complete, testing and merging to 
master branch is mid-August?

Thanks & Regards,
Ritu S.

-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] 
Sent: Thursday, May 29, 2014 10:41 AM
To: dev
Cc: Alex Huang; Prakash Kaligotla
Subject: Re: Feature Frezee date for 4.5 release.

Good reason, and I would certainly retract my proposal if it wouldn't mean that 
a lot of new features will come in last minute. You won't have to be done 
earlier.

So let me amend my proposal

On Thu, May 29, 2014 at 7:30 PM, Ritu Sabharwal  wrote:
> Hi Daan,
>
> We are tracking to deliver our plugin (Brocade Network plugin for VDX 
> switches) as per earlier communication of feature freeze for 4.5 release on 
> mid-August. Based on your proposal for moving in the code freeze to mid-June 
> is too early for us to provide the support for this release. I request to 
> keep the timelines to mid-August so that we can provide VDX support from 
> Brocade in 4.5 release.
>
> Thanks & Regards,
> Ritu S.
>
> -Original Message-
> From: Ritu Sabharwal [mailto:rsabh...@brocade.com]
> Sent: Monday, May 19, 2014 10:32 AM
> To: dev@cloudstack.apache.org
> Cc: Alex Huang
> Subject: RE: Feature Frezee date for 4.5 release.
>
> Thanks Daan!
>
> I will send a proposal email soon for the plugin soon to the mailing list .
>
> Thanks & Regards,
> Ritu S.
>
> -Original Message-
> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> Sent: Saturday, May 17, 2014 2:39 AM
> To: dev
> Cc: Alex Huang
> Subject: Re: Feature Frezee date for 4.5 release.
>
> 4.4 ffd + 4m => about half august
>
>
> On Sat, May 17, 2014 at 4:26 AM, Ritu Sabharwal  wrote:
>> Hi Alex,
>>
>> What is the Feature freeze date for 4.5 release? We are planning for a 
>> plugin so wanted to make our project plan accordingly.
>>
>> Thanks & regards,
>> Ritu S.
>
>
>
> --
> Daan



--
Daan

License to be signed for contributing to CloudStack

[Ritu Sabharwal]

Hi,



I wanted to know if there are any license to be signed by individuals or 
corporates to contribute to CloudStack.

Thanks & Regards,
Ritu S.

RE: License to be signed for contributing to CloudStack

[Ritu Sabharwal]

Hi ilya, David,

Thanks for the information!

I am working with Brocade Communications Systems and we are implementing a 
network plugin for their VDX integration for L2 services.  We are targeting for 
4.5 release.

Some follow up questions:

1. Since I am not an Apache committer, I need not sign an Individual 
Contributor License Agreement?
2. For IP Clearance form for the plugin code, when do we send an email for the 
IP clearance and vote? Is it after the code review at the time of code merge to 
master branch?

Thanks & Regards,
Ritu S.

-Original Message-
From: David Nalley [mailto:da...@gnsa.us] 
Sent: Thursday, May 29, 2014 6:13 PM
To: dev@cloudstack.apache.org
Subject: Re: License to be signed for contributing to CloudStack

On Thu, May 29, 2014 at 6:10 PM, Ritu Sabharwal  wrote:
> Hi,
>
>
>
> I wanted to know if there are any license to be signed by individuals or 
> corporates to contribute to CloudStack.
>
> Thanks & Regards,
> Ritu S.


So, it depends.
If you or your company is donating a significant contribution of code that was 
developed outside of the project; you probably need to go through IP Clearance. 
That typically involves a Software Grant Agreement or Contributor License 
Agreement.

If you or your company are donating code that was developed inside the project, 
you probably don't need to sign anything unless it's a very large contribution.

Also note that committers must sign an individual contributor license agreement 
for their account to be created.

--David

RE: License to be signed for contributing to CloudStack

[Ritu Sabharwal]

Hi Sebastian,

This gives a real good picture of the IP clearance process.

I sent a Proposal email to mailing list last week, still waiting for 
acceptance. Can you please have a look at it and provide feedback?

I am in the state to submit my design document to CloudStack wiki. I have 
created account on JIRA, Review Board and CloudStack wiki. I need permissions 
to contribute. Can you please give these permissions?

It would be good to create a branch for Brocade plugin and we can submitting 
patches for review to Review Board in another one week .

Thanks & Regards,
Ritu S.

-Original Message-
From: Sebastien Goasguen [mailto:run...@gmail.com] 
Sent: Friday, May 30, 2014 12:42 PM
To: dev@cloudstack.apache.org
Cc: David Nalley; ilya musayev
Subject: Re: License to be signed for contributing to CloudStack


On May 30, 2014, at 1:55 PM, Ritu Sabharwal  wrote:

> Hi ilya, David,
> 
> Thanks for the information!
> 
> I am working with Brocade Communications Systems and we are implementing a 
> network plugin for their VDX integration for L2 services.  We are targeting 
> for 4.5 release.
> 
> Some follow up questions:
> 
> 1. Since I am not an Apache committer, I need not sign an Individual 
> Contributor License Agreement?

Correct. You only sign an ICLA when you get invited to become a committer.

> 2. For IP Clearance form for the plugin code, when do we send an email for 
> the IP clearance and vote? Is it after the code review at the time of code 
> merge to master branch?
> 

I don't know what's the state of the plugin right now. But if it's developed 
from scratch, just start submitting patches to cloudstack via review board. The 
sooner you do this, the less likely you will face IP clearance issues. These 
issues tend to arise when code has been developed behind closed doors and with 
many authors. You raising this issue on the list is already a good start. I 
would recommend you submit patches (even though incomplete) yesterday :). We 
can create a brocade plugin branch for you, then you and other colleagues 
working on this should submit incremental patches. As we review the patches, we 
gain trust in you and your code, and most likely there will be no need for IP 
clearance. Something important to keep in mind is authorship. Do not submit 
code (via review board) that you have not written.

Trying to avoid IP clearance is good -because it's a headache-.

> Thanks & Regards,
> Ritu S.
> 
> -Original Message-
> From: David Nalley [mailto:da...@gnsa.us] 
> Sent: Thursday, May 29, 2014 6:13 PM
> To: dev@cloudstack.apache.org
> Subject: Re: License to be signed for contributing to CloudStack
> 
> On Thu, May 29, 2014 at 6:10 PM, Ritu Sabharwal  wrote:
>> Hi,
>> 
>> 
>> 
>> I wanted to know if there are any license to be signed by individuals or 
>> corporates to contribute to CloudStack.
>> 
>> Thanks & Regards,
>> Ritu S.
> 
> 
> So, it depends.
> If you or your company is donating a significant contribution of code that 
> was developed outside of the project; you probably need to go through IP 
> Clearance. That typically involves a Software Grant Agreement or Contributor 
> License Agreement.
> 
> If you or your company are donating code that was developed inside the 
> project, you probably don't need to sign anything unless it's a very large 
> contribution.
> 
> Also note that committers must sign an individual contributor license 
> agreement for their account to be created.
> 
> --David

RE: License to be signed for contributing to CloudStack

[Ritu Sabharwal]

Hi Chip,

Thanks for the information.

I created a JIRA bug for the plugin development CLOUDSTACK-6823. 

I don't have the Edit permissions to edit the wiki to add the design spec. 

User ID: rsabharw

Can I get the edit permissions to edit the wiki please?

Thanks & Regards,
Ritu S.


-Original Message-
From: Chip Childers [mailto:chipchild...@apache.org] 
Sent: Monday, June 02, 2014 7:53 AM
To: dev@cloudstack.apache.org
Cc: run...@gmail.com; David Nalley; ilya musayev
Subject: Re: License to be signed for contributing to CloudStack

On Fri, May 30, 2014 at 01:57:13PM -0700, Ritu Sabharwal wrote:
> Hi Sebastian,
> 
> This gives a real good picture of the IP clearance process.
> 
> I sent a Proposal email to mailing list last week, still waiting for 
> acceptance. Can you please have a look at it and provide feedback?

Don't assume that it requires any acceptance.  Apache projects operate on the 
idea of lazy consensus, which means that a proposal like this is really only 
something that will be commented on if there is a strong opinion (on how to do 
it, or to do / not do it).  Silence means consent, but that's another reason to 
incrementally submit patches as work in progress.  That will ensure that you 
are seeing the results of your work get into our repo as you progress (and 
provide opportunities for individuals that might not have read the proposal to 
help guide the implementation).

> 
> I am in the state to submit my design document to CloudStack wiki. I have 
> created account on JIRA, Review Board and CloudStack wiki. I need permissions 
> to contribute. Can you please give these permissions?
> 

You are all set for JIRA.  IIRC, you should be able to edit the wiki if you 
create an account on it.

> It would be good to create a branch for Brocade plugin and we can submitting 
> patches for review to Review Board in another one week .
> 

We will do that (likely) when the first patch comes in.  Please provide a note 
in the submission asking for a new branch.

> Thanks & Regards,
> Ritu S.

RE: License to be signed for contributing to CloudStack

[Ritu Sabharwal]

Hi Sebastian,

Right now I am the only author for the plugin. Will add more to the wiki and 
Review Board as an when people join me.

Thanks & Regards,
Ritu S.

-Original Message-
From: sebgoa [mailto:run...@gmail.com] 
Sent: Monday, June 02, 2014 7:59 AM
To: Ritu Sabharwal
Cc: dev@cloudstack.apache.org; David Nalley; ilya musayev
Subject: Re: License to be signed for contributing to CloudStack


On May 30, 2014, at 10:57 PM, Ritu Sabharwal  wrote:

> Hi Sebastian,
> 
> This gives a real good picture of the IP clearance process.
> 
> I sent a Proposal email to mailing list last week, still waiting for 
> acceptance. Can you please have a look at it and provide feedback?
> 
> I am in the state to submit my design document to CloudStack wiki. I have 
> created account on JIRA, Review Board and CloudStack wiki. I need permissions 
> to contribute. Can you please give these permissions?
> 
> It would be good to create a branch for Brocade plugin and we can submitting 
> patches for review to Review Board in another one week .

Just be careful with that *we*. Every code author should submit his own 
patches. 

> 
> Thanks & Regards,
> Ritu S.
> 
> -Original Message-
> From: Sebastien Goasguen [mailto:run...@gmail.com] 
> Sent: Friday, May 30, 2014 12:42 PM
> To: dev@cloudstack.apache.org
> Cc: David Nalley; ilya musayev
> Subject: Re: License to be signed for contributing to CloudStack
> 
> 
> On May 30, 2014, at 1:55 PM, Ritu Sabharwal  wrote:
> 
>> Hi ilya, David,
>> 
>> Thanks for the information!
>> 
>> I am working with Brocade Communications Systems and we are implementing a 
>> network plugin for their VDX integration for L2 services.  We are targeting 
>> for 4.5 release.
>> 
>> Some follow up questions:
>> 
>> 1. Since I am not an Apache committer, I need not sign an Individual 
>> Contributor License Agreement?
> 
> Correct. You only sign an ICLA when you get invited to become a committer.
> 
>> 2. For IP Clearance form for the plugin code, when do we send an email for 
>> the IP clearance and vote? Is it after the code review at the time of code 
>> merge to master branch?
>> 
> 
> I don't know what's the state of the plugin right now. But if it's developed 
> from scratch, just start submitting patches to cloudstack via review board. 
> The sooner you do this, the less likely you will face IP clearance issues. 
> These issues tend to arise when code has been developed behind closed doors 
> and with many authors. You raising this issue on the list is already a good 
> start. I would recommend you submit patches (even though incomplete) 
> yesterday :). We can create a brocade plugin branch for you, then you and 
> other colleagues working on this should submit incremental patches. As we 
> review the patches, we gain trust in you and your code, and most likely there 
> will be no need for IP clearance. Something important to keep in mind is 
> authorship. Do not submit code (via review board) that you have not written.
> 
> Trying to avoid IP clearance is good -because it's a headache-.
> 
>> Thanks & Regards,
>> Ritu S.
>> 
>> -Original Message-
>> From: David Nalley [mailto:da...@gnsa.us] 
>> Sent: Thursday, May 29, 2014 6:13 PM
>> To: dev@cloudstack.apache.org
>> Subject: Re: License to be signed for contributing to CloudStack
>> 
>> On Thu, May 29, 2014 at 6:10 PM, Ritu Sabharwal  wrote:
>>> Hi,
>>> 
>>> 
>>> 
>>> I wanted to know if there are any license to be signed by individuals or 
>>> corporates to contribute to CloudStack.
>>> 
>>> Thanks & Regards,
>>> Ritu S.
>> 
>> 
>> So, it depends.
>> If you or your company is donating a significant contribution of code that 
>> was developed outside of the project; you probably need to go through IP 
>> Clearance. That typically involves a Software Grant Agreement or Contributor 
>> License Agreement.
>> 
>> If you or your company are donating code that was developed inside the 
>> project, you probably don't need to sign anything unless it's a very large 
>> contribution.
>> 
>> Also note that committers must sign an individual contributor license 
>> agreement for their account to be created.
>> 
>> --David
> 

[DISCUSS] NetConf client Library for Brocade Network Plugin implemenatation...

[Ritu Sabharwal]

Hi,



The Brocade Network plugin uses NetConf Java client library, NetConf4j 
https://github.com/dana-i2cat/netconf4j  for its implementation. It is 
available under LGPL license. Is it ok to use this library with CloudStack  or 
are there any other recommendations that have been used earlier for other 
plugins?



Thanks & Regards,

Ritu S.

NetworkOrchestrator selects 2 NetworkGurus at one time....

[Ritu Sabharwal]

Hi,

I am writing a Network Guru for automatically orchestrating Brocade VDX 
switches to provide tenant isolation via VLAN. In my NetworkGuru, I have 
implemented the canHandle() method for Guest isolated network in Advanced zone 
using VLAN isolation. When the NetworkOrchestrator selects the NetworkGuru, it 
selects my NetworkGuru and the ExternalGuestNetworkGuru also and I see 2 
networks created. How do I make sure that ExternalGuestNetworkGuru is not 
selected by NetworkOrchestrator.

Thanks & Regards,
Ritu S.

[PROPOSAL] Brocade network plugin to orchestrate Brocade VDX Switches for CloudStack 4.5

[Ritu Sabharwal]

Hi CS Developers,

I have added the Design document for the Plugin in the wiki.  Here is the link 
: 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Brocade+Network+Plugin+to+Orchestrate+Brocade+VDX+Switches

Please review it and provide your comments.

Thanks & Regards,
Ritu S.

RE: NetworkOrchestrator selects 2 NetworkGurus at one time....

[Ritu Sabharwal]

Thanks Chiradeep and Murali for the reply!

I am thinking of explicitly telling ExternalNetworkGuru to skip design when 
Brocade plugin is designing the network. I don't want to disable 
ExternalNetworkGuru from default build when Brocade plugin is not present so 
won't exclude it from the spring class loader.

Thanks & Regards,
Ritu S.

-Original Message-
From: Murali Reddy [mailto:murali.re...@citrix.com] 
Sent: Tuesday, June 10, 2014 10:54 PM
To: Chiradeep Vittal; dev@cloudstack.apache.org
Cc: Sheng Yang; Jayapal Reddy Uradi; Alena Prokharchyk
Subject: Re: NetworkOrchestrator selects 2 NetworkGurus at one time

This is know design issue. Unlike service orchestration (which has prescriptive 
way to tell which network elements to be called for with network offerings ) 
there is no such logic for network design. Orchestrator just loops through all 
the network guru's asking to design the network which can results in one or 
more networks. Hugo did a cleanup [1] but I believe it was not merged as there 
was no consensus. There is 1-1 mapping between isolation type and Guru but In 
this case both Brocade Guru and ExternalNetworkGuru will attempt to design the 
VLAN isolated networks.

One in-elegent solution is to hard code ExternalGuestNetworu guru to skip 
network deign when Brocade plug-in is supposed to do design the network. Other 
option could be exclude ExternalNetworkGuru bean from spring class loader.

[1] https://www.mail-archive.com/dev@cloudstack.apache.org/msg17344.html

From: Chiradeep Vittal 
mailto:chiradeep.vit...@citrix.com>>
Date: Wednesday, 11 June 2014 6:24 AM
To: "dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>" 
mailto:dev@cloudstack.apache.org>>
Cc: Sheng Yang mailto:sheng.y...@citrix.com>>, Murali 
Reddy mailto:murali.re...@citrix.com>>, Jayapal Reddy 
Uradi mailto:jayapalreddy.ur...@citrix.com>>, 
Alena Prokharchyk 
mailto:alena.prokharc...@citrix.com>>
Subject: Re: NetworkOrchestrator selects 2 NetworkGurus at one time

That is strange. Looks like a bug to me. That is because the 
ExternalGuestNetworkGuru returns 'true' for canHandle.

From: Ritu Sabharwal mailto:rsabh...@brocade.com>>
Reply-To: "dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>" 
mailto:dev@cloudstack.apache.org>>
Date: Tuesday, June 10, 2014 at 11:02 AM
To: "dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>" 
mailto:dev@cloudstack.apache.org>>
Subject: NetworkOrchestrator selects 2 NetworkGurus at one time

Hi,

I am writing a Network Guru for automatically orchestrating Brocade VDX 
switches to provide tenant isolation via VLAN. In my NetworkGuru, I have 
implemented the canHandle() method for Guest isolated network in Advanced zone 
using VLAN isolation. When the NetworkOrchestrator selects the NetworkGuru, it 
selects my NetworkGuru and the ExternalGuestNetworkGuru also and I see 2 
networks created. How do I make sure that ExternalGuestNetworkGuru is not 
selected by NetworkOrchestrator.

Thanks & Regards,
Ritu S.

RE: [PROPOSAL] Brocade network plugin to orchestrate Brocade VDX Switches for CloudStack 4.5

[Ritu Sabharwal]

Thanks Chiradeep! Please see my answers inlined.

Thanks & Regards,
Ritu S.

-Original Message-
From: Chiradeep Vittal [mailto:chiradeep.vit...@citrix.com] 
Sent: Tuesday, June 10, 2014 5:12 PM
To: dev@cloudstack.apache.org
Cc: Prakash Kaligotla; Nagendra Jaladanki
Subject: Re: [PROPOSAL] Brocade network plugin to orchestrate Brocade VDX 
Switches for CloudStack 4.5

Well done.
Question: How do you figure out the VLAN -to- Brocade switch port mapping? By 
using the mac address of the VM nic?

[RS]: The plugin creates a port profile for each network and at the time of VM 
creation, associates the mac address of the VM nic to the respective network's 
port profile. 

Comment: It looks like you are creating a table (BrocadeNetworkHostMapping). 
Could you add details of this table (schema). Make sure this table appears in 
any upgrade scripts from previous releases.

[RS]: I will add the schema for the BrocadeNetworkHostMapping table. I have 
added this table to create-schema.sql script. For 4.5, upgrade is supported  
from what all releases? I will add this to the respective scripts.

From: Ritu Sabharwal mailto:rsabh...@brocade.com>>
Reply-To: "dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>" 
mailto:dev@cloudstack.apache.org>>
Date: Tuesday, June 10, 2014 at 11:51 AM
To: "dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>" 
mailto:dev@cloudstack.apache.org>>
Cc: Prakash Kaligotla mailto:pkali...@brocade.com>>, 
Nagendra Jaladanki mailto:njala...@brocade.com>>
Subject: [PROPOSAL] Brocade network plugin to orchestrate Brocade VDX Switches 
for CloudStack 4.5

Hi CS Developers,

I have added the Design document for the Plugin in the wiki.  Here is the link 
: 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Brocade+Network+Plugin+to+Orchestrate+Brocade+VDX+Switches

Please review it and provide your comments.

Thanks & Regards,
Ritu S.

RE: [PROPOSAL] Brocade network plugin to orchestrate Brocade VDX Switches for CloudStack 4.5

[Ritu Sabharwal]

Alena,

Thanks for answering. For upgrade from 4.4 to 4.5, I understand it will be in 
in 44-45.sql.

How about a fresh install of 4.5? For 4.5. the db setup will be done by 
create-schema.sql or some other script?

Thanks & Regards,
Ritu S.

-Original Message-
From: Alena Prokharchyk [mailto:alena.prokharc...@citrix.com] 
Sent: Wednesday, June 11, 2014 3:25 PM
To: dev@cloudstack.apache.org; Ritu Sabharwal
Cc: Prakash Kaligotla; Nagendra Jaladanki
Subject: Re: [PROPOSAL] Brocade network plugin to orchestrate Brocade VDX 
Switches for CloudStack 4.5

Ritu,


Answering your DB upgrade question. Schema upgrade changes should be put to 
44-45 sql upgrade script, not to create-schema.sql. All previous releases get 
upgraded to 4.4 before being upgraded to 45.


-Alena.


On 6/11/14, 11:56 AM, "Ritu Sabharwal"  wrote:

>Thanks Chiradeep! Please see my answers inlined.
>
>Thanks & Regards,
>Ritu S.
>
>-Original Message-
>From: Chiradeep Vittal [mailto:chiradeep.vit...@citrix.com]
>Sent: Tuesday, June 10, 2014 5:12 PM
>To: dev@cloudstack.apache.org
>Cc: Prakash Kaligotla; Nagendra Jaladanki
>Subject: Re: [PROPOSAL] Brocade network plugin to orchestrate Brocade 
>VDX Switches for CloudStack 4.5
>
>Well done.
>Question: How do you figure out the VLAN -to- Brocade switch port 
>mapping? By using the mac address of the VM nic?
>
>[RS]: The plugin creates a port profile for each network and at the 
>time of VM creation, associates the mac address of the VM nic to the 
>respective network's port profile.
>
>Comment: It looks like you are creating a table 
>(BrocadeNetworkHostMapping). Could you add details of this table 
>(schema). Make sure this table appears in any upgrade scripts from 
>previous releases.
>
>[RS]: I will add the schema for the BrocadeNetworkHostMapping table. I 
>have added this table to create-schema.sql script. For 4.5, upgrade is 
>supported  from what all releases? I will add this to the respective 
>scripts.
>
>From: Ritu Sabharwal 
>mailto:rsabh...@brocade.com>>
>Reply-To: "dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>"
>mailto:dev@cloudstack.apache.org>>
>Date: Tuesday, June 10, 2014 at 11:51 AM
>To: "dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>"
>mailto:dev@cloudstack.apache.org>>
>Cc: Prakash Kaligotla
>mailto:pkali...@brocade.com>>, Nagendra Jaladanki 
>mailto:njala...@brocade.com>>
>Subject: [PROPOSAL] Brocade network plugin to orchestrate Brocade VDX 
>Switches for CloudStack 4.5
>
>Hi CS Developers,
>
>I have added the Design document for the Plugin in the wiki.  Here is 
>the link :
>https://cwiki.apache.org/confluence/display/CLOUDSTACK/Brocade+Network+
>Plu
>gin+to+Orchestrate+Brocade+VDX+Switches
>
>Please review it and provide your comments.
>
>Thanks & Regards,
>Ritu S.
>

RE: NetworkOrchestrator selects 2 NetworkGurus at one time....

[Ritu Sabharwal]

Thanks Murali and Alena for the explanation!

BrocadeNetworkGuru supports Isolated Guest Network in Advanced Zone. The 
isolation method supported is VLAN. Additionally, it needs to check the 
existence of configuration file providing  Brocade Switches details. 

ExternalNetworkGuru also supports isolated Guest network in Advanced Zone, The 
isolation method supported are GRE, L3 and VLAN. This makes the 
ExternalNetworkGuru conditions a superset of conditions supported by 
BrocadeNetworkGuru and hence selects both.

I  am adding  a check in ExternalNetworkGuru that if the configuration file for 
Brocade VDX switches are available, then skip the design.

Comments please!

Thanks & Regards,
Ritu S.


-Original Message-
From: Alena Prokharchyk [mailto:alena.prokharc...@citrix.com] 
Sent: Thursday, June 12, 2014 9:51 AM
To: Murali Reddy; dev@cloudstack.apache.org; Chiradeep Vittal
Cc: Sheng Yang; Jayapal Reddy Uradi
Subject: Re: NetworkOrchestrator selects 2 NetworkGurus at one time

The suggested fix would break the case when customer decides to create a 
regular Isolated network with the VR as a provider, in the same setup.

I think the right fix would be - find out what is different between networks 
implemented by BrocadeNetworkGuru and ExternalNetwork guru, and modify the 
ExternalGuestNetworkGuru to skip brocade networks. Just like Murali suggested 
in his email. But canHandle shouldn¹t directly say ³if not brocade, skip². May 
be there are some services or isolation methods that only BrocadeNetworkGuru 
can support?

-Alena.

On 6/12/14, 12:53 AM, "Murali Reddy"  wrote:

>On 12/06/14 12:13 AM, "Ritu Sabharwal"  wrote:
>
>>Thanks Chiradeep and Murali for the reply!
>>
>>I am thinking of explicitly telling ExternalNetworkGuru to skip design 
>>when Brocade plugin is designing the network. I don't want to disable 
>>ExternalNetworkGuru from default build when Brocade plugin is not 
>>present so won't exclude it from the spring class loader.
>
>Small correction, I did not mean to remove it from the build, but 
>remove bean from loading at run time. Unless any one has objection, 
>explicit check seems fine for now until design issue is fixed.
>
>>
>>Thanks & Regards,
>>Ritu S.
>>
>>-Original Message-
>>From: Murali Reddy [mailto:murali.re...@citrix.com]
>>Sent: Tuesday, June 10, 2014 10:54 PM
>>To: Chiradeep Vittal; dev@cloudstack.apache.org
>>Cc: Sheng Yang; Jayapal Reddy Uradi; Alena Prokharchyk
>>Subject: Re: NetworkOrchestrator selects 2 NetworkGurus at one time
>>
>>This is know design issue. Unlike service orchestration (which has 
>>prescriptive way to tell which network elements to be called for with 
>>network offerings ) there is no such logic for network design.
>>Orchestrator just loops through all the network guru's asking to 
>>design the network which can results in one or more networks. Hugo did 
>>a cleanup [1] but I believe it was not merged as there was no 
>>consensus. There is
>>1-1 mapping between isolation type and Guru but In this case both 
>>Brocade Guru and ExternalNetworkGuru will attempt to design the VLAN 
>>isolated networks.
>>
>>One in-elegent solution is to hard code ExternalGuestNetworu guru to 
>>skip network deign when Brocade plug-in is supposed to do design the network.
>>Other option could be exclude ExternalNetworkGuru bean from spring 
>>class loader.
>>
>>[1] 
>>https://www.mail-archive.com/dev@cloudstack.apache.org/msg17344.html
>>
>>From: Chiradeep Vittal
>>mailto:chiradeep.vit...@citrix.com>>
>>Date: Wednesday, 11 June 2014 6:24 AM
>>To: "dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>"
>>mailto:dev@cloudstack.apache.org>>
>>Cc: Sheng Yang mailto:sheng.y...@citrix.com>>,
>>Murali Reddy 
>>mailto:murali.re...@citrix.com>>,
>>Jayapal Reddy Uradi
>>mailto:jayapalreddy.ur...@citrix.com>>,
>>Alena Prokharchyk
>>mailto:alena.prokharc...@citrix.com>>
>>Subject: Re: NetworkOrchestrator selects 2 NetworkGurus at one time
>>
>>That is strange. Looks like a bug to me. That is because the 
>>ExternalGuestNetworkGuru returns 'true' for canHandle.
>>
>>From: Ritu Sabharwal 
>>mailto:rsabh...@brocade.com>>
>>Reply-To: "dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>"
>>mailto:dev@cloudstack.apache.org>>
>>Date: Tuesday, June 10, 2014 at 11:02 AM
>>To: "dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>"
>>mailto:dev@cloudstack.apache.org>>
>>Subject: NetworkOrchestrator selects 2 Net

RE: [PROPOSAL] Brocade network plugin to orchestrate Brocade VDX Switches for CloudStack 4.5

[Ritu Sabharwal]

Ok, got it. Then I can safely add it to 44-45.

Thanks,
Ritu S.

-Original Message-
From: Alena Prokharchyk [mailto:alena.prokharc...@citrix.com] 
Sent: Thursday, June 12, 2014 11:36 AM
To: Ritu Sabharwal; dev@cloudstack.apache.org
Cc: Prakash Kaligotla; Nagendra Jaladanki
Subject: Re: [PROPOSAL] Brocade network plugin to orchestrate Brocade VDX 
Switches for CloudStack 4.5

Ritu, when we do fresh install, db upgrade works like this:

1) First, create-schema.sql gets executed - that¹s the base. I¹m not sure 
though what version its based on, but definitely earlier than 4.2
2) Then all the upgrade paths get executed on a top of it 41-42, 42-43,
44-45

-Alena.

On 6/12/14, 11:19 AM, "Ritu Sabharwal"  wrote:

>Alena,
>
>Thanks for answering. For upgrade from 4.4 to 4.5, I understand it will 
>be in in 44-45.sql.
>
>How about a fresh install of 4.5? For 4.5. the db setup will be done by 
>create-schema.sql or some other script?
>
>Thanks & Regards,
>Ritu S.
>
>-Original Message-
>From: Alena Prokharchyk [mailto:alena.prokharc...@citrix.com]
>Sent: Wednesday, June 11, 2014 3:25 PM
>To: dev@cloudstack.apache.org; Ritu Sabharwal
>Cc: Prakash Kaligotla; Nagendra Jaladanki
>Subject: Re: [PROPOSAL] Brocade network plugin to orchestrate Brocade 
>VDX Switches for CloudStack 4.5
>
>Ritu,
>
>
>Answering your DB upgrade question. Schema upgrade changes should be 
>put to 44-45 sql upgrade script, not to create-schema.sql. All previous 
>releases get upgraded to 4.4 before being upgraded to 45.
>
>
>-Alena.
>
>
>On 6/11/14, 11:56 AM, "Ritu Sabharwal"  wrote:
>
>>Thanks Chiradeep! Please see my answers inlined.
>>
>>Thanks & Regards,
>>Ritu S.
>>
>>-Original Message-
>>From: Chiradeep Vittal [mailto:chiradeep.vit...@citrix.com]
>>Sent: Tuesday, June 10, 2014 5:12 PM
>>To: dev@cloudstack.apache.org
>>Cc: Prakash Kaligotla; Nagendra Jaladanki
>>Subject: Re: [PROPOSAL] Brocade network plugin to orchestrate Brocade 
>>VDX Switches for CloudStack 4.5
>>
>>Well done.
>>Question: How do you figure out the VLAN -to- Brocade switch port 
>>mapping? By using the mac address of the VM nic?
>>
>>[RS]: The plugin creates a port profile for each network and at the 
>>time of VM creation, associates the mac address of the VM nic to the 
>>respective network's port profile.
>>
>>Comment: It looks like you are creating a table 
>>(BrocadeNetworkHostMapping). Could you add details of this table 
>>(schema). Make sure this table appears in any upgrade scripts from 
>>previous releases.
>>
>>[RS]: I will add the schema for the BrocadeNetworkHostMapping table. I 
>>have added this table to create-schema.sql script. For 4.5, upgrade is 
>>supported  from what all releases? I will add this to the respective 
>>scripts.
>>
>>From: Ritu Sabharwal
>>mailto:rsabh...@brocade.com>>
>>Reply-To: "dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>"
>>mailto:dev@cloudstack.apache.org>>
>>Date: Tuesday, June 10, 2014 at 11:51 AM
>>To: "dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>"
>>mailto:dev@cloudstack.apache.org>>
>>Cc: Prakash Kaligotla
>>mailto:pkali...@brocade.com>>, Nagendra 
>>Jaladanki mailto:njala...@brocade.com>>
>>Subject: [PROPOSAL] Brocade network plugin to orchestrate Brocade VDX 
>>Switches for CloudStack 4.5
>>
>>Hi CS Developers,
>>
>>I have added the Design document for the Plugin in the wiki.  Here is 
>>the link :
>>https://cwiki.apache.org/confluence/display/CLOUDSTACK/Brocade+Network
>>+
>>Plu
>>gin+to+Orchestrate+Brocade+VDX+Switches
>>
>>Please review it and provide your comments.
>>
>>Thanks & Regards,
>>Ritu S.
>>
>

Review Request 22863: First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

[Ritu Sabharwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/
---

Review request for cloudstack.


Bugs: CLOUDSTACK-6823
https://issues.apache.org/jira/browse/CLOUDSTACK-6823


Repository: cloudstack-git


Description
---

First code drop for Brocade Network plugin to orchestrate Brocade VDX switches 
for L2 connectivity.


Diffs
-

  api/src/com/cloud/network/Network.java b5e8173 
  api/src/com/cloud/network/Networks.java 3159f6e 
  api/src/com/cloud/network/PhysicalNetwork.java 5d38b50 
  build/replace.properties 265f335 
  client/pom.xml 3995f6e 
  plugins/pom.xml 4f7805a 
  setup/db/create-schema.sql 55cb4cc 
  ui/scripts/system.js 0c56baf 
  utils/conf/db.properties e1b5fe9 

Diff: https://reviews.apache.org/r/22863/diff/


Testing
---

•   Create an isolated network; verify that the port-profile is created on 
the Brocade switch.
•   Attach a VM to the network; verify that the VMs MAC address is 
associated with the port profile of the network on the Brocade switch.
•   Delete VMs for an isolated network; verify that the VMs MAC address is 
disassociated with the port profile of the network on the Brocade switch.
•   Delete the isolated network; verify that the port-profile is deleted 
from the Brocade switch.


File Attachments


Diff for the existing cloudstack code
  
https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
Patch for the plugin code
  
https://reviews.apache.org/media/uploaded/files/2014/06/23/fbb2b949-a42c-4b22-afa7-60e691c778df__brocade-vcs.patch


Thanks,

Ritu  Sabharwal

Re: Review Request 22863: First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

[Ritu Sabharwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/
---

(Updated June 23, 2014, 10:15 a.m.)


Review request for cloudstack.


Bugs: CLOUDSTACK-6823
https://issues.apache.org/jira/browse/CLOUDSTACK-6823


Repository: cloudstack-git


Description
---

First code drop for Brocade Network plugin to orchestrate Brocade VDX switches 
for L2 connectivity.


Diffs
-

  api/src/com/cloud/network/Network.java b5e8173 
  api/src/com/cloud/network/Networks.java 3159f6e 
  api/src/com/cloud/network/PhysicalNetwork.java 5d38b50 
  build/replace.properties 265f335 
  client/pom.xml 3995f6e 
  plugins/pom.xml 4f7805a 
  setup/db/create-schema.sql 55cb4cc 
  ui/scripts/system.js 0c56baf 
  utils/conf/db.properties e1b5fe9 

Diff: https://reviews.apache.org/r/22863/diff/


Testing
---

•   Create an isolated network; verify that the port-profile is created on 
the Brocade switch.
•   Attach a VM to the network; verify that the VMs MAC address is 
associated with the port profile of the network on the Brocade switch.
•   Delete VMs for an isolated network; verify that the VMs MAC address is 
disassociated with the port profile of the network on the Brocade switch.
•   Delete the isolated network; verify that the port-profile is deleted 
from the Brocade switch.


File Attachments


Diff for the existing cloudstack code
  
https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
Patch for the plugin code
  
https://reviews.apache.org/media/uploaded/files/2014/06/23/fbb2b949-a42c-4b22-afa7-60e691c778df__brocade-vcs.patch


Thanks,

Ritu  Sabharwal

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

[Ritu Sabharwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/
---

(Updated June 23, 2014, 10:18 a.m.)


Review request for cloudstack.


Changes
---

Updated the JIRA Bug id on Summary.


Summary (updated)
-

CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate 
Brocade VDX switches for L2 connectivity.


Bugs: CLOUDSTACK-6823
https://issues.apache.org/jira/browse/CLOUDSTACK-6823


Repository: cloudstack-git


Description
---

First code drop for Brocade Network plugin to orchestrate Brocade VDX switches 
for L2 connectivity.


Diffs
-

  api/src/com/cloud/network/Network.java b5e8173 
  api/src/com/cloud/network/Networks.java 3159f6e 
  api/src/com/cloud/network/PhysicalNetwork.java 5d38b50 
  build/replace.properties 265f335 
  client/pom.xml 3995f6e 
  plugins/pom.xml 4f7805a 
  setup/db/create-schema.sql 55cb4cc 
  ui/scripts/system.js 0c56baf 
  utils/conf/db.properties e1b5fe9 

Diff: https://reviews.apache.org/r/22863/diff/


Testing
---

•   Create an isolated network; verify that the port-profile is created on 
the Brocade switch.
•   Attach a VM to the network; verify that the VMs MAC address is 
associated with the port profile of the network on the Brocade switch.
•   Delete VMs for an isolated network; verify that the VMs MAC address is 
disassociated with the port profile of the network on the Brocade switch.
•   Delete the isolated network; verify that the port-profile is deleted 
from the Brocade switch.


File Attachments


Diff for the existing cloudstack code
  
https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
Patch for the plugin code
  
https://reviews.apache.org/media/uploaded/files/2014/06/23/fbb2b949-a42c-4b22-afa7-60e691c778df__brocade-vcs.patch


Thanks,

Ritu  Sabharwal

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

[Ritu Sabharwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/
---

(Updated June 23, 2014, 5:49 p.m.)


Review request for cloudstack.


Changes
---

Added a note requesting a new branch for Brocade plugin.


Bugs: CLOUDSTACK-6823
https://issues.apache.org/jira/browse/CLOUDSTACK-6823


Repository: cloudstack-git


Description (updated)
---

First code drop for Brocade Network plugin to orchestrate Brocade VDX switches 
for L2 connectivity. Please create a new branch for Brocade plugin.


Diffs
-

  api/src/com/cloud/network/Network.java b5e8173 
  api/src/com/cloud/network/Networks.java 3159f6e 
  api/src/com/cloud/network/PhysicalNetwork.java 5d38b50 
  build/replace.properties 265f335 
  client/pom.xml 3995f6e 
  plugins/pom.xml 4f7805a 
  setup/db/create-schema.sql 55cb4cc 
  ui/scripts/system.js 0c56baf 
  utils/conf/db.properties e1b5fe9 

Diff: https://reviews.apache.org/r/22863/diff/


Testing
---

•   Create an isolated network; verify that the port-profile is created on 
the Brocade switch.
•   Attach a VM to the network; verify that the VMs MAC address is 
associated with the port profile of the network on the Brocade switch.
•   Delete VMs for an isolated network; verify that the VMs MAC address is 
disassociated with the port profile of the network on the Brocade switch.
•   Delete the isolated network; verify that the port-profile is deleted 
from the Brocade switch.


File Attachments


Diff for the existing cloudstack code
  
https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
Patch for the plugin code
  
https://reviews.apache.org/media/uploaded/files/2014/06/23/fbb2b949-a42c-4b22-afa7-60e691c778df__brocade-vcs.patch


Thanks,

Ritu  Sabharwal

RE: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

[Ritu Sabharwal]

Hi Sebastian,

I submitted the first code drop for plugin for review. Can you please create a 
new branch for Brocade plugin development.  

Also, I wanted to know how do I select specific reviewers for reviewing the 
request. I did not see any option to choose that while submitting the request.

Thanks & Regards,
Ritu S. 

-Original Message-
From: Ritu Sabharwal [mailto:nore...@reviews.apache.org] On Behalf Of Ritu 
Sabharwal
Sent: Monday, June 23, 2014 10:49 AM
To: Ritu Sabharwal; cloudstack
Subject: Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for 
Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/
---

(Updated June 23, 2014, 5:49 p.m.)


Review request for cloudstack.


Changes
---

Added a note requesting a new branch for Brocade plugin.


Bugs: CLOUDSTACK-6823
https://issues.apache.org/jira/browse/CLOUDSTACK-6823


Repository: cloudstack-git


Description (updated)
---

First code drop for Brocade Network plugin to orchestrate Brocade VDX switches 
for L2 connectivity. Please create a new branch for Brocade plugin.


Diffs
-

  api/src/com/cloud/network/Network.java b5e8173 
  api/src/com/cloud/network/Networks.java 3159f6e 
  api/src/com/cloud/network/PhysicalNetwork.java 5d38b50 
  build/replace.properties 265f335 
  client/pom.xml 3995f6e 
  plugins/pom.xml 4f7805a 
  setup/db/create-schema.sql 55cb4cc 
  ui/scripts/system.js 0c56baf 
  utils/conf/db.properties e1b5fe9 

Diff: https://reviews.apache.org/r/22863/diff/


Testing
---

•   Create an isolated network; verify that the port-profile is created on 
the Brocade switch.
•   Attach a VM to the network; verify that the VMs MAC address is 
associated with the port profile of the network on the Brocade switch.
•   Delete VMs for an isolated network; verify that the VMs MAC address is 
disassociated with the port profile of the network on the Brocade switch.
•   Delete the isolated network; verify that the port-profile is deleted 
from the Brocade switch.


File Attachments


Diff for the existing cloudstack code
  
https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
Patch for the plugin code
  
https://reviews.apache.org/media/uploaded/files/2014/06/23/fbb2b949-a42c-4b22-afa7-60e691c778df__brocade-vcs.patch


Thanks,

Ritu  Sabharwal

RE: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

[Ritu Sabharwal]

Hi Hugo,

There is a separate file


From: Hugo Trippaers [mailto:nore...@reviews.apache.org] On Behalf Of Hugo 
Trippaers
Sent: Monday, June 23, 2014 11:41 PM
To: Ritu Sabharwal; Hugo Trippaers; cloudstack
Subject: Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for 
Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

This is an automatically generated e-mail. To reply, visit: 
https://reviews.apache.org/r/22863/




Hey,



There are a number of issues with this patch, i've made the commments on the 
lines directly. Also where is the real functionality? The code in this patch 
seems to only be the hook into the existing cloudstack code and not the brocade 
code itself?



Cheers,



Hugo

api/src/com/cloud/network/Network.java<https://reviews.apache.org/r/22863/diff/1/?file=614964#file614964line135>
 (Diff revision 1)


public static class Provider {


135





Please remove tabs from the sources.

build/replace.properties<https://reviews.apache.org/r/22863/diff/1/?file=614967#file614967line20>
 (Diff revision 1)

20


DBROOTPW=

20


DBROOTPW=password


This change will break some developer setups. Can you remove this file from the 
patch.

plugins/pom.xml<https://reviews.apache.org/r/22863/diff/1/?file=614969#file614969line71>
 (Diff revision 1)


71


test


Why do you need to include test in the main build process?

setup/db/create-schema.sql<https://reviews.apache.org/r/22863/diff/1/?file=614970#file614970line148>
 (Diff revision 1)


148


DROP TABLE IF EXISTS `cloud`.`brocade_network_host_map`;


Don't make changes to this file. Add the new tables to the upgrade files. In 
this case you need to make the changes in the 4.4 to 4.5 upgrade file.

utils/conf/db.properties<https://reviews.apache.org/r/22863/diff/1/?file=614972#file614972line28>
 (Diff revision 1)

28


db.root.password=

28


db.root.password=password


Please don't commit any changes to this file.


- Hugo Trippaers


On June 23rd, 2014, 5:49 p.m. UTC, Ritu Sabharwal wrote:
Review request for cloudstack.
By Ritu Sabharwal.

Updated June 23, 2014, 5:49 p.m.
Bugs: CLOUDSTACK-6823<https://issues.apache.org/jira/browse/CLOUDSTACK-6823>
Repository: cloudstack-git
Description

First code drop for Brocade Network plugin to orchestrate Brocade VDX switches 
for L2 connectivity. Please create a new branch for Brocade plugin.


Testing

•   Create an isolated network; verify that the port-profile is created on 
the Brocade switch.

•   Attach a VM to the network; verify that the VMs MAC address is 
associated with the port profile of the network on the Brocade switch.

•   Delete VMs for an isolated network; verify that the VMs MAC address is 
disassociated with the port profile of the network on the Brocade switch.

•   Delete the isolated network; verify that the port-profile is deleted 
from the Brocade switch.


Diffs

 *   api/src/com/cloud/network/Network.java (b5e8173)
 *   api/src/com/cloud/network/Networks.java (3159f6e)
 *   api/src/com/cloud/network/PhysicalNetwork.java (5d38b50)
 *   build/replace.properties (265f335)
 *   client/pom.xml (3995f6e)
 *   plugins/pom.xml (4f7805a)
 *   setup/db/create-schema.sql (55cb4cc)
 *   ui/scripts/system.js (0c56baf)
 *   utils/conf/db.properties (e1b5fe9)

View Diff<https://reviews.apache.org/r/22863/diff/>

File Attachments

 *   Diff for the existing cloudstack 
code<https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff>
 *   Patch for the plugin 
code<https://reviews.apache.org/media/uploaded/files/2014/06/23/fbb2b949-a42c-4b22-afa7-60e691c778df__brocade-vcs.patch>

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

[Ritu Sabharwal]

> On June 24, 2014, 6:40 a.m., Hugo Trippaers wrote:
> > Hey,
> > 
> > There are a number of issues with this patch, i've made the commments on 
> > the lines directly. Also where is the real functionality? The code in this 
> > patch seems to only be the hook into the existing cloudstack code and not 
> > the brocade code itself?
> > 
> > Cheers,
> > 
> > Hugo

Hi Hugo,

I commented on the review comments directly. I included a patch file 
brocade-vcs.patch which has Brocade code. 

I followed these steps to create the patch:

-git add plugins/network-elements/brocade-vcs
-git commit -m "Commit message“
-git format-patch master --stdout > ~/brocade-vcs.patch

Is there any other way to include Brocade code in the diffs? Please let me 
know. I will submit that for review.

Thanks,
Ritu.


> On June 24, 2014, 6:40 a.m., Hugo Trippaers wrote:
> > build/replace.properties, line 20
> > <https://reviews.apache.org/r/22863/diff/1/?file=614967#file614967line20>
> >
> > This change will break some developer setups. Can you remove this file 
> > from the patch.

The changes in this file are for my local server. I will remove this file from 
the patch.


> On June 24, 2014, 6:40 a.m., Hugo Trippaers wrote:
> > api/src/com/cloud/network/Network.java, line 135
> > <https://reviews.apache.org/r/22863/diff/1/?file=614964#file614964line135>
> >
> > Please remove tabs from the sources.

I will fix this.


> On June 24, 2014, 6:40 a.m., Hugo Trippaers wrote:
> > plugins/pom.xml, line 71
> > <https://reviews.apache.org/r/22863/diff/1/?file=614969#file614969line71>
> >
> > Why do you need to include test in the main build process?

I created some test project for my testing. I will fix this.


> On June 24, 2014, 6:40 a.m., Hugo Trippaers wrote:
> > setup/db/create-schema.sql, line 148
> > <https://reviews.apache.org/r/22863/diff/1/?file=614970#file614970line148>
> >
> > Don't make changes to this file. Add the new tables to the upgrade 
> > files. In this case you need to make the changes in the 4.4 to 4.5 upgrade 
> > file.

I will fix this.


> On June 24, 2014, 6:40 a.m., Hugo Trippaers wrote:
> > utils/conf/db.properties, line 28
> > <https://reviews.apache.org/r/22863/diff/1/?file=614972#file614972line28>
> >
> > Please don't commit any changes to this file.

This again is for my local server. I will remove this file from the patch.


- Ritu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/#review46498
---


On June 23, 2014, 5:49 p.m., Ritu  Sabharwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22863/
> ---
> 
> (Updated June 23, 2014, 5:49 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Bugs: CLOUDSTACK-6823
> https://issues.apache.org/jira/browse/CLOUDSTACK-6823
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> First code drop for Brocade Network plugin to orchestrate Brocade VDX 
> switches for L2 connectivity. Please create a new branch for Brocade plugin.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/Network.java b5e8173 
>   api/src/com/cloud/network/Networks.java 3159f6e 
>   api/src/com/cloud/network/PhysicalNetwork.java 5d38b50 
>   build/replace.properties 265f335 
>   client/pom.xml 3995f6e 
>   plugins/pom.xml 4f7805a 
>   setup/db/create-schema.sql 55cb4cc 
>   ui/scripts/system.js 0c56baf 
>   utils/conf/db.properties e1b5fe9 
> 
> Diff: https://reviews.apache.org/r/22863/diff/
> 
> 
> Testing
> ---
> 
> • Create an isolated network; verify that the port-profile is created on 
> the Brocade switch.
> • Attach a VM to the network; verify that the VMs MAC address is 
> associated with the port profile of the network on the Brocade switch.
> • Delete VMs for an isolated network; verify that the VMs MAC address is 
> disassociated with the port profile of the network on the Brocade switch.
> • Delete the isolated network; verify that the port-profile is deleted 
> from the Brocade switch.
> 
> 
> File Attachments
> 
> 
> Diff for the existing cloudstack code
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
> Patch for the plugin code
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/23/fbb2b949-a42c-4b22-afa7-60e691c778df__brocade-vcs.patch
> 
> 
> Thanks,
> 
> Ritu  Sabharwal
> 
>

[ISSUE] can not parse [10.1.1.0] error while creating Guest Network for CIDR

[Ritu Sabharwal]

Hi,

I am trying to create a guest network for a network offering. I am giving in 
all the values and when I give IPv6 cidr value to 10.1.10/23 I get error on UI.

can not parse [10.1.1.0].

I tried this with 4.3 and it was workin. It does not work with master branch 
codebase.

Please let me know what is the change in the format.

Thanks & Regards,
Ritu S.

RE: [ISSUE] can not parse [10.1.1.0] error while creating Guest Network for CIDR

[Ritu Sabharwal]

Sorry for the typo in earlier mail.

I gave 10.1.10.1/23 in the IPv6 CIDR field and get an error can not parse 
[10.1.10.1]. This was working with 4.3

Ritu.

-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] 
Sent: Thursday, June 26, 2014 2:47 PM
To: dev
Subject: Re: [ISSUE] can not parse [10.1.1.0] error while creating Guest 
Network for CIDR

PS
Don't know of a format change.

On Thu, Jun 26, 2014 at 11:46 PM, Daan Hoogland  wrote:
> H Ritu,
>
> Are you sure you entered 10.1.10/23? it seems to me it would have to 
> be 10.1.10.0/23.
> and did you enter it in the field for IPv6? this is an ipv4 address 
> format
>
> Daan
>
> On Thu, Jun 26, 2014 at 11:40 PM, Ritu Sabharwal  wrote:
>> Hi,
>>
>> I am trying to create a guest network for a network offering. I am giving in 
>> all the values and when I give IPv6 cidr value to 10.1.10/23 I get error on 
>> UI.
>>
>> can not parse [10.1.1.0].
>>
>> I tried this with 4.3 and it was workin. It does not work with master branch 
>> codebase.
>>
>> Please let me know what is the change in the format.
>>
>> Thanks & Regards,
>> Ritu S.
>
>
>
> --
> Daan



--
Daan

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

[Ritu Sabharwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/
---

(Updated June 26, 2014, 10:25 p.m.)


Review request for cloudstack.


Changes
---

Fixed the issues as provided in review comments. Uploaded new diff file with 
changes and patch file for Brocade functionality code.


Bugs: CLOUDSTACK-6823
https://issues.apache.org/jira/browse/CLOUDSTACK-6823


Repository: cloudstack-git


Description
---

First code drop for Brocade Network plugin to orchestrate Brocade VDX switches 
for L2 connectivity. Please create a new branch for Brocade plugin.


Diffs (updated)
-

  api/src/com/cloud/network/Network.java 885bffe 
  api/src/com/cloud/network/Networks.java 1e4d229 
  api/src/com/cloud/network/PhysicalNetwork.java 8cc214e 
  client/pom.xml 29fef4f 
  plugins/pom.xml b5e6a61 
  setup/db/db/schema-440to450.sql 77445a9 
  ui/scripts/system.js 9a98a5c 

Diff: https://reviews.apache.org/r/22863/diff/


Testing
---

•   Create an isolated network; verify that the port-profile is created on 
the Brocade switch.
•   Attach a VM to the network; verify that the VMs MAC address is 
associated with the port profile of the network on the Brocade switch.
•   Delete VMs for an isolated network; verify that the VMs MAC address is 
disassociated with the port profile of the network on the Brocade switch.
•   Delete the isolated network; verify that the port-profile is deleted 
from the Brocade switch.


File Attachments (updated)


Diff for the existing cloudstack code
  
https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
Patch file for Brocade functionality code
  
https://reviews.apache.org/media/uploaded/files/2014/06/26/92bb0014-a7b7-4f0b-97c9-018d615b658a__brocade-vcs.patch


Thanks,

Ritu  Sabharwal

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

[Ritu Sabharwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/
---

(Updated July 4, 2014, 9:35 a.m.)


Review request for cloudstack and Hugo Trippaers.


Bugs: CLOUDSTACK-6823
https://issues.apache.org/jira/browse/CLOUDSTACK-6823


Repository: cloudstack-git


Description
---

First code drop for Brocade Network plugin to orchestrate Brocade VDX switches 
for L2 connectivity. Please create a new branch for Brocade plugin.


Diffs
-

  api/src/com/cloud/network/Network.java 885bffe 
  api/src/com/cloud/network/Networks.java 1e4d229 
  api/src/com/cloud/network/PhysicalNetwork.java 8cc214e 
  client/pom.xml 29fef4f 
  plugins/pom.xml b5e6a61 
  setup/db/db/schema-440to450.sql 77445a9 
  ui/scripts/system.js 9a98a5c 

Diff: https://reviews.apache.org/r/22863/diff/


Testing
---

•   Create an isolated network; verify that the port-profile is created on 
the Brocade switch.
•   Attach a VM to the network; verify that the VMs MAC address is 
associated with the port profile of the network on the Brocade switch.
•   Delete VMs for an isolated network; verify that the VMs MAC address is 
disassociated with the port profile of the network on the Brocade switch.
•   Delete the isolated network; verify that the port-profile is deleted 
from the Brocade switch.


File Attachments


Diff for the existing cloudstack code
  
https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
Patch file for Brocade functionality code
  
https://reviews.apache.org/media/uploaded/files/2014/06/26/92bb0014-a7b7-4f0b-97c9-018d615b658a__brocade-vcs.patch


Thanks,

Ritu  Sabharwal

Review Request 23314: Plugin specific code for the Brocade Network Plugin

[Ritu Sabharwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23314/
---

Review request for cloudstack.


Summary (updated)
-

Plugin specific code for the Brocade Network Plugin


Bugs: CLOUDSTACK-6823
https://issues.apache.org/jira/browse/CLOUDSTACK-6823


Repository: cloudstack-git


Description (updated)
---

Plugin specific code.


Diffs (updated)
-

  plugins/network-elements/brocade-vcs/pom.xml PRE-CREATION 
  plugins/network-elements/brocade-vcs/resources/BrocadeInterfaceSchema.xsd 
PRE-CREATION 
  plugins/network-elements/brocade-vcs/resources/BrocadePortProfileSchema.xsd 
PRE-CREATION 
  
plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/module.properties
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/spring-vcs-context.xml
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkAnswer.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkAnswer.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkAnswer.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkAnswer.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/StartupBrocadeVcsCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/BrocadeVcsNetworkHostMappingVO.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApiException.java
 PRE-CREATION 
  plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/Cache.java 
PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/CacheManager.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/Switch.java 
PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsNetworkHostMappingDao.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsNetworkHostMappingDaoImpl.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/element/BrocadeVcsElement.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/guru/BrocadeVcsGuestNetworkGuru.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/resource/BrocadeVcsResource.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/23314/diff/


Testing
---


Thanks,

Ritu  Sabharwal

Re: Review Request 23314: Plugin specific code for the Brocade Network Plugin

[Ritu Sabharwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23314/
---

(Updated July 7, 2014, 7:08 p.m.)


Review request for cloudstack.


Bugs: CLOUDSTACK-6823
https://issues.apache.org/jira/browse/CLOUDSTACK-6823


Repository: cloudstack-git


Description
---

Plugin specific code.


Diffs (updated)
-

  plugins/network-elements/brocade-vcs/pom.xml PRE-CREATION 
  plugins/network-elements/brocade-vcs/resources/BrocadeInterfaceSchema.xsd 
PRE-CREATION 
  plugins/network-elements/brocade-vcs/resources/BrocadePortProfileSchema.xsd 
PRE-CREATION 
  plugins/network-elements/brocade-vcs/resources/BrocadeShowVcsSchema.xsd 
PRE-CREATION 
  
plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/module.properties
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/spring-vcs-context.xml
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkAnswer.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkAnswer.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkAnswer.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkAnswer.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/StartupBrocadeVcsCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/BrocadeVcsNetworkHostMappingVO.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApiException.java
 PRE-CREATION 
  plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/Cache.java 
PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/CacheManager.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/Constants.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/Switch.java 
PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsNetworkHostMappingDao.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsNetworkHostMappingDaoImpl.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/element/BrocadeVcsElement.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/guru/BrocadeVcsGuestNetworkGuru.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/resource/BrocadeVcsResource.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/23314/diff/


Testing
---


Thanks,

Ritu  Sabharwal

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

[Ritu Sabharwal]

> On June 24, 2014, 6:40 a.m., Hugo Trippaers wrote:
> > Hey,
> > 
> > There are a number of issues with this patch, i've made the commments on 
> > the lines directly. Also where is the real functionality? The code in this 
> > patch seems to only be the hook into the existing cloudstack code and not 
> > the brocade code itself?
> > 
> > Cheers,
> > 
> > Hugo
> 
> Ritu  Sabharwal wrote:
> Hi Hugo,
> 
> I commented on the review comments directly. I included a patch file 
> brocade-vcs.patch which has Brocade code. 
> 
> I followed these steps to create the patch:
> 
> -git add plugins/network-elements/brocade-vcs
> -git commit -m "Commit message“
> -git format-patch master --stdout > ~/brocade-vcs.patch
> 
> Is there any other way to include Brocade code in the diffs? Please let 
> me know. I will submit that for review.
> 
> Thanks,
> Ritu.
>
> 
> Hugo Trippaers wrote:
> You can create a separate review request for the vcs code (and post a 
> link in this review) or create a single big patch with everything. I'm fine 
> with either option, but we need the patch in review board as that will help 
> us do the review properly.
> 
> Thanks for fixing the other items.
> 
> Cheers,
> 
> Hugo

Hi Hugo,

I have created another request for vcs specific code. Please find the link for 
the review request: https://reviews.apache.org/r/23314/ 

Hope this helps to review it properly.

Thanks & Regards,
Ritu S.


- Ritu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/#review46498
---


On July 4, 2014, 9:35 a.m., Ritu  Sabharwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22863/
> ---
> 
> (Updated July 4, 2014, 9:35 a.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Bugs: CLOUDSTACK-6823
> https://issues.apache.org/jira/browse/CLOUDSTACK-6823
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> First code drop for Brocade Network plugin to orchestrate Brocade VDX 
> switches for L2 connectivity. Please create a new branch for Brocade plugin.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/Network.java 885bffe 
>   api/src/com/cloud/network/Networks.java 1e4d229 
>   api/src/com/cloud/network/PhysicalNetwork.java 8cc214e 
>   client/pom.xml 29fef4f 
>   plugins/pom.xml b5e6a61 
>   setup/db/db/schema-440to450.sql 77445a9 
>   ui/scripts/system.js 9a98a5c 
> 
> Diff: https://reviews.apache.org/r/22863/diff/
> 
> 
> Testing
> ---
> 
> • Create an isolated network; verify that the port-profile is created on 
> the Brocade switch.
> • Attach a VM to the network; verify that the VMs MAC address is 
> associated with the port profile of the network on the Brocade switch.
> • Delete VMs for an isolated network; verify that the VMs MAC address is 
> disassociated with the port profile of the network on the Brocade switch.
> • Delete the isolated network; verify that the port-profile is deleted 
> from the Brocade switch.
> 
> 
> File Attachments
> ----
> 
> Diff for the existing cloudstack code
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
> Patch file for Brocade functionality code
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/26/92bb0014-a7b7-4f0b-97c9-018d615b658a__brocade-vcs.patch
> 
> 
> Thanks,
> 
> Ritu  Sabharwal
> 
>

Timeout error while brining up VM console from UI for testing Brocade Network Plugin: CLOUDSTACK-6823

[Ritu Sabharwal]

Hi,

I have tested the plugin functionality with the Simulator by creating the 
datacenter with the marvin script and configuring the Brocade VDX switches.

The Brocade VDX switches are configured with the port-profiles and interfaces 
at appropriate lifecycles of VMs.

I can see the VMs coming up and running. I need to bring up the console for the 
VMs to test the ping across the VMs.

In the CloudStack UI, when I click the console button for a VM, I don't get the 
console but see a timeout message.

Thanks & Regards,
Ritu S.

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

[Ritu Sabharwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/
---

(Updated July 8, 2014, 9:30 a.m.)


Review request for cloudstack and Hugo Trippaers.


Changes
---

Add the dependency on the plugin code


Bugs: CLOUDSTACK-6823
https://issues.apache.org/jira/browse/CLOUDSTACK-6823


Repository: cloudstack-git


Description
---

First code drop for Brocade Network plugin to orchestrate Brocade VDX switches 
for L2 connectivity. Please create a new branch for Brocade plugin.


Diffs
-

  api/src/com/cloud/network/Network.java 885bffe 
  api/src/com/cloud/network/Networks.java 1e4d229 
  api/src/com/cloud/network/PhysicalNetwork.java 8cc214e 
  client/pom.xml 29fef4f 
  plugins/pom.xml b5e6a61 
  setup/db/db/schema-440to450.sql 77445a9 
  ui/scripts/system.js 9a98a5c 

Diff: https://reviews.apache.org/r/22863/diff/


Testing
---

•   Create an isolated network; verify that the port-profile is created on 
the Brocade switch.
•   Attach a VM to the network; verify that the VMs MAC address is 
associated with the port profile of the network on the Brocade switch.
•   Delete VMs for an isolated network; verify that the VMs MAC address is 
disassociated with the port profile of the network on the Brocade switch.
•   Delete the isolated network; verify that the port-profile is deleted 
from the Brocade switch.


File Attachments


Diff for the existing cloudstack code
  
https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
Patch file for Brocade functionality code
  
https://reviews.apache.org/media/uploaded/files/2014/06/26/92bb0014-a7b7-4f0b-97c9-018d615b658a__brocade-vcs.patch


Thanks,

Ritu  Sabharwal

Re: Review Request 23314: Plugin specific code for the Brocade Network Plugin

[Ritu Sabharwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23314/
---

(Updated July 8, 2014, 6:49 p.m.)


Review request for cloudstack.


Changes
---

Thanks for reviewing the code.

I have fixed the license in all the files.

I am working on writing the unit tests for the plugin.

I am working on providing the documentation on using the plugin.

I have tested the plugin with the simulator and see the configurations on 
Brocade switches happening. Currently, I am setting up a real hardware setup 
with Vmware hypervisor and Brocade switches so test the connectivity between 
spawned VMs.

Can I continue writing the unit tests and marvin integration tests and 
documentation after the July 19 date so that this plugin makes to 4.5 feature 
freeze date.

I have updated the diffs with the changes for the license and other comments.


Bugs: CLOUDSTACK-6823
https://issues.apache.org/jira/browse/CLOUDSTACK-6823


Repository: cloudstack-git


Description
---

Plugin specific code.


Diffs (updated)
-

  plugins/network-elements/brocade-vcs/pom.xml PRE-CREATION 
  plugins/network-elements/brocade-vcs/resources/BrocadeInterfaceSchema.xsd 
PRE-CREATION 
  plugins/network-elements/brocade-vcs/resources/BrocadePortProfileSchema.xsd 
PRE-CREATION 
  plugins/network-elements/brocade-vcs/resources/BrocadeShowVcsSchema.xsd 
PRE-CREATION 
  
plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/module.properties
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/spring-vcs-context.xml
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkAnswer.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkAnswer.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkAnswer.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkAnswer.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/StartupBrocadeVcsCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/BrocadeVcsNetworkHostMappingVO.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApiException.java
 PRE-CREATION 
  plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/Cache.java 
PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/CacheManager.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/Constants.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/Switch.java 
PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsNetworkHostMappingDao.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsNetworkHostMappingDaoImpl.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/element/BrocadeVcsElement.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/guru/BrocadeVcsGuestNetworkGuru.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/resource/BrocadeVcsResource.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/23314/diff/


Testing
---


Thanks,

Ritu  Sabharwal

Re: Review Request 23314: Plugin specific code for the Brocade Network Plugin

[Ritu Sabharwal]

> On July 8, 2014, 9:29 a.m., Hugo Trippaers wrote:
> > Thanks for make this a separate review, much easier to read.
> > 
> > The licenses are not added to all files and in some files they appear not 
> > to be complete. A good trick to solve this is to include the 
> > license-maven-plugin in the build section. See 
> > plugins/network-elements/nicira-nvp/pom.xml for an example.
> > 
> > Also the plugin doesn't contain any tests. We need unit tests or functional 
> > tests (and preferably both) to validate that this plugin works and keeps on 
> > working in future versions of CloudStack. It would be great if you could 
> > supply unit tests to validate this inner workings of this module and marvin 
> > based integration tests that we can run to see if this work with the 
> > intended hardware.
> > 
> > The last general point is that we would also need documentation on this 
> > plugin so administrators will know how to use this.

Thanks for reviewing the code.

I have fixed the license in all the files.

I am working on writing the unit tests for the plugin.

I am working on providing the documentation on using the plugin.

I have tested the plugin with the simulator and see the configurations on 
Brocade switches happening. Currently, I am setting up a real hardware setup 
with Vmware hypervisor and Brocade switches so test the connectivity between 
spawned VMs.

Can I continue writing the unit tests and marvin integration tests and 
documentation after the July 19 date so that this plugin makes to 4.5 feature 
freeze date.

I have updated the diffs with the changes for the license and other comments.


> On July 8, 2014, 9:29 a.m., Hugo Trippaers wrote:
> > plugins/network-elements/brocade-vcs/src/com/cloud/network/guru/BrocadeVcsGuestNetworkGuru.java,
> >  line 303
> > <https://reviews.apache.org/r/23314/diff/2/?file=624856#file624856line303>
> >
> > This TODO is fixed right?

This is fixed. Just the comment was there.


> On July 8, 2014, 9:29 a.m., Hugo Trippaers wrote:
> > plugins/network-elements/brocade-vcs/src/com/cloud/network/guru/BrocadeVcsGuestNetworkGuru.java,
> >  line 106
> > <https://reviews.apache.org/r/23314/diff/2/?file=624856#file624856line106>
> >
> > Please remove commented code.

Removed the commented code.


> On July 8, 2014, 9:29 a.m., Hugo Trippaers wrote:
> > plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/CacheManager.java,
> >  line 50
> > <https://reviews.apache.org/r/23314/diff/2/?file=624850#file624850line50>
> >
> > You should get all properties from the CloudStack configuration 
> > mechanism. Either via the global config or via the settings on the network 
> > service provider configuration (preferred)

The Brocade network gear details are read from config file for now because of 
the time constraint to meet the 4.5 timelines. I plan to enhance this and get 
these values from network service provider configuration for future versions.


> On July 8, 2014, 9:29 a.m., Hugo Trippaers wrote:
> > plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/CacheManager.java,
> >  line 86
> > <https://reviews.apache.org/r/23314/diff/2/?file=624850#file624850line86>
> >
> > This looks like something that should be persisted in the cloudstack 
> > database instead of stored outside cloudstack.

The Brocade network gear mapping details are read from config file for now 
because of the time constraint to meet the 4.5 timelines. I plan to enhance 
this and get these values from network service provider configuration for 
future versions and persist it DB.


- Ritu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23314/#review47435
---


On July 8, 2014, 6:49 p.m., Ritu  Sabharwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23314/
> ---
> 
> (Updated July 8, 2014, 6:49 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Bugs: CLOUDSTACK-6823
> https://issues.apache.org/jira/browse/CLOUDSTACK-6823
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Plugin specific code.
> 
> 
> Diffs
> -
> 
>   plugins/network-elements/brocade-vcs/pom.xml PRE-CREATION 
>   plugins/network-elements/brocade-vcs/resources/BrocadeInterfaceSchema.xsd 
> PRE-CREATION 
>   plugins/network-elements/brocade-vcs/resources/BrocadePortProfile

[HELP] How to build CS to enable VMware support in CloudStack..

[Ritu Sabharwal]

Hi,

I am trying to add VMWare DC for the first time in CloudStack management server 
and need help in doing so. I downloaded the vim25.jar and apputils.jar from 
VSphere Management SDK and copied them to deps folder.

When I a tryingto build cloudStack from source using the command mvn install  
-Dnoredist , it is failing and looking for dependencies for NetApp Plugin.

[ERROR] Failed to execute goal on project cloud-plugin-netapp: Could not 
resolve dependencies for project 
org.apache.cloudstack:cloud-plugin-netapp:jar:4.5.0-SNAPSHOT: Failure to find 
com.cloud.com.netapp:manageontap:jar:4.0 in http://repo.maven.apache.org/maven2 
was cached in the local repository, resolution will not be reattempted until 
the update interval of central has elapsed or updates are forced -> [Help 1]


How can I just build for enabling VMware support and no other opensource 
dependency?

Help in this regard is appreciated.

Thanks & Regards,
Ritu S.

RE: Timeout error while brining up VM console from UI for testing Brocade Network Plugin: CLOUDSTACK-6823

[Ritu Sabharwal]

Thanks Amogh for the reply.

So for testing the ping across VMs , I need to setup real hardware. I am trying 
to add a VMware Cluster with ESXi hosts connected to Brocade VDX switches.

I am facing issues in setting up the VMWare support in CS.

I downloaded the vim25.jar and apputils.jar from VSphere Management SDK and 
copied them to deps folder.

When I am trying to build cloudStack from source using the command mvn install  
-Dnoredist , it is failing and looking for dependencies for NetApp Plugin.

[ERROR] Failed to execute goal on project cloud-plugin-netapp: Could not 
resolve dependencies for project 
org.apache.cloudstack:cloud-plugin-netapp:jar:4.5.0-SNAPSHOT: Failure to find 
com.cloud.com.netapp:manageontap:jar:4.0 in http://repo.maven.apache.org/maven2 
was cached in the local repository, resolution will not be reattempted until 
the update interval of central has elapsed or updates are forced -> [Help 1]

How can I just build for enabling VMware support and no other opensource 
dependency?

Thanks & Regards,
Ritu S.

-Original Message-
From: Amogh Vasekar [mailto:amogh.vase...@citrix.com] 
Sent: Tuesday, July 08, 2014 11:22 AM
To: dev@cloudstack.apache.org; Hugo Trippaers
Subject: Re: Timeout error while brining up VM console from UI for testing 
Brocade Network Plugin: CLOUDSTACK-6823

Hi,

AFAIK, since the simulator does not actually have any H/W or real VM, I don't 
think console access is available.

Thanks,
Amogh

On 7/7/14 4:00 PM, "Ritu Sabharwal"  wrote:

>Hi,
>
>I have tested the plugin functionality with the Simulator by creating 
>the datacenter with the marvin script and configuring the Brocade VDX 
>switches.
>
>The Brocade VDX switches are configured with the port-profiles and 
>interfaces at appropriate lifecycles of VMs.
>
>I can see the VMs coming up and running. I need to bring up the console 
>for the VMs to test the ping across the VMs.
>
>In the CloudStack UI, when I click the console button for a VM, I don't 
>get the console but see a timeout message.
>
>Thanks & Regards,
>Ritu S.

RE: [HELP] How to build CS to enable VMware support in CloudStack..

[Ritu Sabharwal]

Thanks Hugo, I was able to build Cloudstack.

I have some more questions on Vmware cluster setup for CloudStack. Sent that in 
a  separate email.

Thanks & Regards,
Ritu S.

-Original Message-
From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers
Sent: Tuesday, July 08, 2014 1:52 PM
To: dev@cloudstack.apache.org
Subject: Re: [HELP] How to build CS to enable VMware support in CloudStack..

Ritu.

If you wan to build only the vmware dependencies , just enable the profile 
vmware

So the command should be: mvm -P vmware,systemvm install.

That would build only the vmware dependencies. Make sure the dependencies are 
in the deps folder and added to the local maven repository. The commands to do 
that are in the install-non-oss.sh script in the deps directory.

The noredist flag is just a convenience flag that enables all plugins with 
distribution restrictions, no need to use it to just build vmware support.

Cheers,

Hugo


On 8 jul. 2014, at 22:03, Ritu Sabharwal  wrote:

> Hi,
> 
> I am trying to add VMWare DC for the first time in CloudStack management 
> server and need help in doing so. I downloaded the vim25.jar and apputils.jar 
> from VSphere Management SDK and copied them to deps folder.
> 
> When I a tryingto build cloudStack from source using the command mvn install  
> -Dnoredist , it is failing and looking for dependencies for NetApp Plugin.
> 
> [ERROR] Failed to execute goal on project cloud-plugin-netapp: Could not 
> resolve dependencies for project 
> org.apache.cloudstack:cloud-plugin-netapp:jar:4.5.0-SNAPSHOT: Failure to find 
> com.cloud.com.netapp:manageontap:jar:4.0 in 
> http://repo.maven.apache.org/maven2 was cached in the local repository, 
> resolution will not be reattempted until the update interval of central has 
> elapsed or updates are forced -> [Help 1]
> 
> 
> How can I just build for enabling VMware support and no other opensource 
> dependency?
> 
> Help in this regard is appreciated.
> 
> Thanks & Regards,
> Ritu S.
> 

[Help] Help for setting up Vmware Cluster in CloudStack...

[Ritu Sabharwal]

Hi Ilya,

I am trying to add VMWare DC for the first time in CloudStack management server 
and need help in doing so. I am trying to test the Brocade Network Plugin 
functionality. The Jira id is : 
https://issues.apache.org/jira/browse/CLOUDSTACK-6823

I am following the Tutorial: 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+Advanced+Network+Tutorial+-+Step+by+Step

My Network setup:


1.   2 ESXi hosts 4.1.0 hosts.

2.   vCenter 5.0

Network layout:

vSwitch0: For Management Network
vSwitch0: for Guest Network

vSwitch0 is assigned 1 Physical Nic. This Nic is connected to Brocade VDX 
switch.


My test includes:

 *   Create an isolated network; verify that the port-profile is created on the 
Brocade switch.
 *   Attach a VM to the network; verify that the VMs MAC address is associated 
with the port profile of the network on the Brocade switch.
 *   Add VMs to the same guest network but on different hosts and verify 
connectivity.
 *   Check the availability of the switch by using the CloudStack API: 
http://:8096/client/api?command=listHosts&type=L2Networking.
 This should list the switch with its availability status.
 *   Delete VMs for an isolated network; verify that the VMs MAC address is 
disassociated with the port profile of the network on the Brocade switch.
 *   Delete the isolated network; verify that the port-profile is deleted from 
the Brocade switch.

I have few questions:

1.   Where do I download the system vm template for vmware. I am using 
master CS codebase, I don't have the script 
/usr/lib64/cloud/common/scripts/storage/secondary/cloud-install-sys-tmplt

2.   Since I am testing L2 connectivity b/w VMs using Brocade switches by 
configuring the VLANs( by creating port-profiles) for the network on the 
switches, do I need to assign a IP range for Public network and storage network?

3.   In the tutorial, there are 2 portgroups for VMs on Managemnt Network 
and Development Network? What are these 2 types of VMs?

4.   For primary storage, do I give the datastore attached to the 
hypervisor hosts?


Any help is appreciated.

Thanks & Regards,
Ritu S.

Re: Review Request 23314: Plugin specific code for the Brocade Network Plugin

[Ritu Sabharwal]

> On July 8, 2014, 9:29 a.m., Hugo Trippaers wrote:
> > Thanks for make this a separate review, much easier to read.
> > 
> > The licenses are not added to all files and in some files they appear not 
> > to be complete. A good trick to solve this is to include the 
> > license-maven-plugin in the build section. See 
> > plugins/network-elements/nicira-nvp/pom.xml for an example.
> > 
> > Also the plugin doesn't contain any tests. We need unit tests or functional 
> > tests (and preferably both) to validate that this plugin works and keeps on 
> > working in future versions of CloudStack. It would be great if you could 
> > supply unit tests to validate this inner workings of this module and marvin 
> > based integration tests that we can run to see if this work with the 
> > intended hardware.
> > 
> > The last general point is that we would also need documentation on this 
> > plugin so administrators will know how to use this.
> 
> Ritu  Sabharwal wrote:
> Thanks for reviewing the code.
> 
> I have fixed the license in all the files.
> 
> I am working on writing the unit tests for the plugin.
> 
> I am working on providing the documentation on using the plugin.
> 
> I have tested the plugin with the simulator and see the configurations on 
> Brocade switches happening. Currently, I am setting up a real hardware setup 
> with Vmware hypervisor and Brocade switches so test the connectivity between 
> spawned VMs.
> 
> Can I continue writing the unit tests and marvin integration tests and 
> documentation after the July 19 date so that this plugin makes to 4.5 feature 
> freeze date.
> 
> I have updated the diffs with the changes for the license and other 
> comments.

I am planning to include the following in the documentation:
 - Brocade switch setup
 - Connections to the Hypervisor hosts
 - the flow to use the plugin from UI


- Ritu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23314/#review47435
---


On July 8, 2014, 6:49 p.m., Ritu  Sabharwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23314/
> ---
> 
> (Updated July 8, 2014, 6:49 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Bugs: CLOUDSTACK-6823
> https://issues.apache.org/jira/browse/CLOUDSTACK-6823
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Plugin specific code.
> 
> 
> Diffs
> -
> 
>   plugins/network-elements/brocade-vcs/pom.xml PRE-CREATION 
>   plugins/network-elements/brocade-vcs/resources/BrocadeInterfaceSchema.xsd 
> PRE-CREATION 
>   plugins/network-elements/brocade-vcs/resources/BrocadePortProfileSchema.xsd 
> PRE-CREATION 
>   plugins/network-elements/brocade-vcs/resources/BrocadeShowVcsSchema.xsd 
> PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/module.properties
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/spring-vcs-context.xml
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/StartupBrocadeVcsCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/BrocadeVcsNetworkHostMappingVO.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java
>  PRE-CREATION 
>   
> plugins/network-element

Re: Review Request 23314: Plugin specific code for the Brocade Network Plugin

[Ritu Sabharwal]

> On July 8, 2014, 9:29 a.m., Hugo Trippaers wrote:
> > Thanks for make this a separate review, much easier to read.
> > 
> > The licenses are not added to all files and in some files they appear not 
> > to be complete. A good trick to solve this is to include the 
> > license-maven-plugin in the build section. See 
> > plugins/network-elements/nicira-nvp/pom.xml for an example.
> > 
> > Also the plugin doesn't contain any tests. We need unit tests or functional 
> > tests (and preferably both) to validate that this plugin works and keeps on 
> > working in future versions of CloudStack. It would be great if you could 
> > supply unit tests to validate this inner workings of this module and marvin 
> > based integration tests that we can run to see if this work with the 
> > intended hardware.
> > 
> > The last general point is that we would also need documentation on this 
> > plugin so administrators will know how to use this.
> 
> Ritu  Sabharwal wrote:
> Thanks for reviewing the code.
> 
> I have fixed the license in all the files.
> 
> I am working on writing the unit tests for the plugin.
> 
> I am working on providing the documentation on using the plugin.
> 
> I have tested the plugin with the simulator and see the configurations on 
> Brocade switches happening. Currently, I am setting up a real hardware setup 
> with Vmware hypervisor and Brocade switches so test the connectivity between 
> spawned VMs.
> 
> Can I continue writing the unit tests and marvin integration tests and 
> documentation after the July 19 date so that this plugin makes to 4.5 feature 
> freeze date.
> 
> I have updated the diffs with the changes for the license and other 
> comments.
> 
> Ritu  Sabharwal wrote:
> I am planning to include the following in the documentation:
>  - Brocade switch setup
>  - Connections to the Hypervisor hosts
>  - the flow to use the plugin from UI
> 
> Hugo Trippaers wrote:
> Thanks for fixing the open issues.
> 
> I think it's ok to work on the documentation while a release is being 
> tested (eventhough it is far better to have it ready for the testers). 
> However unittests and functional testcases need to be there before we can 
> merge the plugin. Without it we can not properly test the plugin to see if it 
> is fit to be part of the release. 
> 
> I'd rather have a completely done plugin in the 4.6 release than 
> something that is not complete in 4.5. So currently the blockers for a merge 
> into master are the two property files and we need unit and integration tests.

Hi Hugo,

Thanks for reviewing the plugin.

Few points:

1. The configuration using properties file was part of the Design document 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Brocade+Network+Plugin+to+Orchestrate+Brocade+VDX+Switches
 and was not raised as a concern earlier and the implementation is based on 
that.  

Changing the implementation right now would involve some work. Can this be done 
as an enhancement as part of bug fix during testing?

2. For functional testcases, we are doing functional testing but how will 
functional testcases be run by the community without the Brocade hardware? 

We are working on writing the unit and functional testcases.


- Ritu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23314/#review47435
---


On July 8, 2014, 6:49 p.m., Ritu  Sabharwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23314/
> ---
> 
> (Updated July 8, 2014, 6:49 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Bugs: CLOUDSTACK-6823
> https://issues.apache.org/jira/browse/CLOUDSTACK-6823
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Plugin specific code.
> 
> 
> Diffs
> -
> 
>   plugins/network-elements/brocade-vcs/pom.xml PRE-CREATION 
>   plugins/network-elements/brocade-vcs/resources/BrocadeInterfaceSchema.xsd 
> PRE-CREATION 
>   plugins/network-elements/brocade-vcs/resources/BrocadePortProfileSchema.xsd 
> PRE-CREATION 
>   plugins/network-elements/brocade-vcs/resources/BrocadeShowVcsSchema.xsd 
> PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/module.properties
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/resources/META-INF/cloud

RE: [Help] Help for setting up Vmware Cluster in CloudStack...

[Ritu Sabharwal]

Hi Ilya,

Thanks for your replies.

This is really helpful. We can surely get into some video conferencing and get 
this setup ready. I am in San Jose, CA.

Thanks & Regards,
Ritu S.

From: ilya musayev [mailto:ilya.mailing.li...@gmail.com]
Sent: Wednesday, July 09, 2014 12:58 PM
To: Ritu Sabharwal; Hugo Trippaers
Cc: dev@cloudstack.apache.org
Subject: Re: [Help] Help for setting up Vmware Cluster in CloudStack...

Ritu,

That tutorial is a bit old.

Let me try to answer them, i do have an alternative solution, perhaps we can 
get on the phone and do a webex session or something similar - this week is bad 
for me, i'm traveling, but next week, Thursday and beyond - my schedule is 
flexible. I assume you are on PST timezone somewhere in bay area.

Please see response inline to your inquiries.



On 7/8/14, 6:29 PM, Ritu Sabharwal wrote:

Hi Ilya,

I am trying to add VMWare DC for the first time in CloudStack management server 
and need help in doing so. I am trying to test the Brocade Network Plugin 
functionality. The Jira id is : 
https://issues.apache.org/jira/browse/CLOUDSTACK-6823

I am following the Tutorial: 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+Advanced+Network+Tutorial+-+Step+by+Step

My Network setup:


1.   2 ESXi hosts 4.1.0 hosts.

2.   vCenter 5.0

Network layout:

vSwitch0: For Management Network
vSwitch0: for Guest Network

vSwitch0 is assigned 1 Physical Nic. This Nic is connected to Brocade VDX 
switch.


My test includes:

 *   Create an isolated network; verify that the port-profile is created on the 
Brocade switch.
 *   Attach a VM to the network; verify that the VMs MAC address is associated 
with the port profile of the network on the Brocade switch.
 *   Add VMs to the same guest network but on different hosts and verify 
connectivity.
 *   Check the availability of the switch by using the CloudStack API: 
http://:8096/client/api?command=listHosts&type=L2Networking.
 This should list the switch with its availability status.
 *   Delete VMs for an isolated network; verify that the VMs MAC address is 
disassociated with the port profile of the network on the Brocade switch.
 *   Delete the isolated network; verify that the port-profile is deleted from 
the Brocade switch.

I have few questions:

1.   Where do I download the system vm template for vmware. I am using 
master CS codebase, I don't have the script 
/usr/lib64/cloud/common/scripts/storage/secondary/cloud-install-sys-tmplt
The path is incorrect, this use to apply to CloudStack 4.0 or 4.1, but anything 
post 4.2 has cloudstack in its path.
Here is the snippet of my install script:

/usr/share/cloudstack-common/scripts/storage/secondary/cloud-install-sys-tmplt 
-m /mnt/nfs/secondary -u 
http://my-webserver/systemvm64template-latest-master-vmware.ova -h vmware -F

Note that /mnt/nfs/secondary - is nfs mount - either local or remote
That mount must be accessible by hypervisors. Cloudstack needs to access 
hypervisors and vcenter on port 443.


2.   Since I am testing L2 connectivity b/w VMs using Brocade switches by 
configuring the VLANs( by creating port-profiles) for the network on the 
switches, do I need to assign a IP range for Public network and storage network?
Depends on your setup. Storage network is used when you have a separate 
segregated NFS or alike storage network. In that case, that storage network 
must be trunked  to you hypervisors.
If you are deploying for POC and you dont have a specific storage network, dont 
add storage network traffic label.
Public network - also depends on your setup, if you are doing Advanced Zone 
with VPC (amazon like cloud), you will need a larger IP pool as you want to 
assign public IPs to your guest VMs. However, if you are deploying Advanced 
Shared  Zone without VPC, where you are using your physical network and 
routers/firewalls, then all you need is 2 public ips per zone - which arent 
really public in the internet sense.


3.   In the tutorial, there are 2 portgroups for VMs on Managemnt Network 
and Development Network? What are these 2 types of VMs?
Cloudstack deploys System VMs in following fashion.
Per zone, you have:

Advanced Shared Zone (non VPC)
- Storage VM - doing storage things
   uses 1 public ip and 1 management ip (private communication link)

- Console Proxy VM - proxies VNC console session from hypervisor to end user
   uses 1 public ip and 1 management ip (private communication link)

- RouterVM - 1 per VLAN
   uses 1 management ip (private communication link)

Advanced Shared Zone (VPC - dont use this type of env so i'm not certain - but 
from what i'm told)
- Storage VM - doing storage things
   uses 1 public ip and 1 management ip (private communication link)

- Console Proxy VM - proxies VNC console session from hypervisor to end user
   uses 1 public ip and 1 management ip (private communication link)

- RouterVM - 1 per VLAN per Account
   uses 1 management ip (private comm

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

[Ritu Sabharwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/
---

(Updated July 11, 2014, 10:10 p.m.)


Review request for cloudstack and Hugo Trippaers.


Changes
---

Updated the diff.


Bugs: CLOUDSTACK-6823
https://issues.apache.org/jira/browse/CLOUDSTACK-6823


Repository: cloudstack-git


Description
---

First code drop for Brocade Network plugin to orchestrate Brocade VDX switches 
for L2 connectivity. Please create a new branch for Brocade plugin.


Diffs (updated)
-

  api/src/com/cloud/network/Network.java 885bffe 
  api/src/com/cloud/network/Networks.java 1e4d229 
  api/src/com/cloud/network/PhysicalNetwork.java 8cc214e 
  client/pom.xml 29fef4f 
  plugins/pom.xml b5e6a61 
  setup/db/db/schema-440to450.sql 77445a9 
  ui/scripts/system.js 9a98a5c 
  ui/scripts/ui-custom/zoneWizard.js 4091c03 

Diff: https://reviews.apache.org/r/22863/diff/


Testing
---

•   Create an isolated network; verify that the port-profile is created on 
the Brocade switch.
•   Attach a VM to the network; verify that the VMs MAC address is 
associated with the port profile of the network on the Brocade switch.
•   Delete VMs for an isolated network; verify that the VMs MAC address is 
disassociated with the port profile of the network on the Brocade switch.
•   Delete the isolated network; verify that the port-profile is deleted 
from the Brocade switch.


File Attachments


Diff for the existing cloudstack code
  
https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
Patch file for Brocade functionality code
  
https://reviews.apache.org/media/uploaded/files/2014/06/26/92bb0014-a7b7-4f0b-97c9-018d615b658a__brocade-vcs.patch


Thanks,

Ritu  Sabharwal

Re: Review Request 23314: Plugin specific code for the Brocade Network Plugin

[Ritu Sabharwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23314/
---

(Updated July 11, 2014, 11:44 p.m.)


Review request for cloudstack.


Changes
---

Unit tests added.


Bugs: CLOUDSTACK-6823
https://issues.apache.org/jira/browse/CLOUDSTACK-6823


Repository: cloudstack-git


Description
---

Plugin specific code.


Diffs (updated)
-

  plugins/network-elements/brocade-vcs/pom.xml PRE-CREATION 
  plugins/network-elements/brocade-vcs/resources/BrocadeInterfaceSchema.xsd 
PRE-CREATION 
  plugins/network-elements/brocade-vcs/resources/BrocadePortProfileSchema.xsd 
PRE-CREATION 
  plugins/network-elements/brocade-vcs/resources/BrocadeShowVcsSchema.xsd 
PRE-CREATION 
  
plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/module.properties
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/spring-vcs-context.xml
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkAnswer.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkAnswer.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkAnswer.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkAnswer.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/StartupBrocadeVcsCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/BrocadeVcsNetworkHostMappingVO.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApiException.java
 PRE-CREATION 
  plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/Cache.java 
PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/CacheManager.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/Constants.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/Switch.java 
PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsNetworkHostMappingDao.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsNetworkHostMappingDaoImpl.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/element/BrocadeVcsElement.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/guru/BrocadeVcsGuestNetworkGuru.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/resource/BrocadeVcsResource.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/test/com/cloud/network/brocade/BrocadeVcsApiTest.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/test/com/cloud/network/guru/BrocadeVcsGuestNetworkGuruTest.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/test/com/cloud/network/resource/BrocadeVcsResourceTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/23314/diff/


Testing
---


Thanks,

Ritu  Sabharwal

Re: Review Request 23314: Plugin specific code for the Brocade Network Plugin

[Ritu Sabharwal]

> On July 8, 2014, 9:29 a.m., Hugo Trippaers wrote:
> > Thanks for make this a separate review, much easier to read.
> > 
> > The licenses are not added to all files and in some files they appear not 
> > to be complete. A good trick to solve this is to include the 
> > license-maven-plugin in the build section. See 
> > plugins/network-elements/nicira-nvp/pom.xml for an example.
> > 
> > Also the plugin doesn't contain any tests. We need unit tests or functional 
> > tests (and preferably both) to validate that this plugin works and keeps on 
> > working in future versions of CloudStack. It would be great if you could 
> > supply unit tests to validate this inner workings of this module and marvin 
> > based integration tests that we can run to see if this work with the 
> > intended hardware.
> > 
> > The last general point is that we would also need documentation on this 
> > plugin so administrators will know how to use this.
> 
> Ritu  Sabharwal wrote:
> Thanks for reviewing the code.
> 
> I have fixed the license in all the files.
> 
> I am working on writing the unit tests for the plugin.
> 
> I am working on providing the documentation on using the plugin.
> 
> I have tested the plugin with the simulator and see the configurations on 
> Brocade switches happening. Currently, I am setting up a real hardware setup 
> with Vmware hypervisor and Brocade switches so test the connectivity between 
> spawned VMs.
> 
> Can I continue writing the unit tests and marvin integration tests and 
> documentation after the July 19 date so that this plugin makes to 4.5 feature 
> freeze date.
> 
> I have updated the diffs with the changes for the license and other 
> comments.
> 
> Ritu  Sabharwal wrote:
> I am planning to include the following in the documentation:
>  - Brocade switch setup
>  - Connections to the Hypervisor hosts
>  - the flow to use the plugin from UI
> 
> Hugo Trippaers wrote:
> Thanks for fixing the open issues.
> 
> I think it's ok to work on the documentation while a release is being 
> tested (eventhough it is far better to have it ready for the testers). 
> However unittests and functional testcases need to be there before we can 
> merge the plugin. Without it we can not properly test the plugin to see if it 
> is fit to be part of the release. 
> 
> I'd rather have a completely done plugin in the 4.6 release than 
> something that is not complete in 4.5. So currently the blockers for a merge 
> into master are the two property files and we need unit and integration tests.
> 
> Ritu  Sabharwal wrote:
> Hi Hugo,
> 
> Thanks for reviewing the plugin.
> 
> Few points:
> 
> 1. The configuration using properties file was part of the Design 
> document 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Brocade+Network+Plugin+to+Orchestrate+Brocade+VDX+Switches
>  and was not raised as a concern earlier and the implementation is based on 
> that.  
> 
> Changing the implementation right now would involve some work. Can this 
> be done as an enhancement as part of bug fix during testing?
> 
> 2. For functional testcases, we are doing functional testing but how will 
> functional testcases be run by the community without the Brocade hardware? 
> 
> We are working on writing the unit and functional testcases.
>

Hi Hugo,

I have added the unit tests, working on the the marvin integration tests.

Please reply back for the properties file change if that can be treated an an 
enhancement bug fix during testing phase.

Thanks for reviewing and supporting the plugin.

Thanks & Regards,
Ritu S.


- Ritu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23314/#review47435
---


On July 11, 2014, 11:44 p.m., Ritu  Sabharwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23314/
> ---
> 
> (Updated July 11, 2014, 11:44 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Bugs: CLOUDSTACK-6823
> https://issues.apache.org/jira/browse/CLOUDSTACK-6823
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Plugin specific code.
> 
> 
> Diffs
> -
> 
>   plugins/network-elements/brocade-vcs/pom.xml PRE-CREATION 
>   plugins/networ

Re: Review Request 23314: Plugin specific code for the Brocade Network Plugin

[Ritu Sabharwal]

> On July 8, 2014, 9:29 a.m., Hugo Trippaers wrote:
> > Thanks for make this a separate review, much easier to read.
> > 
> > The licenses are not added to all files and in some files they appear not 
> > to be complete. A good trick to solve this is to include the 
> > license-maven-plugin in the build section. See 
> > plugins/network-elements/nicira-nvp/pom.xml for an example.
> > 
> > Also the plugin doesn't contain any tests. We need unit tests or functional 
> > tests (and preferably both) to validate that this plugin works and keeps on 
> > working in future versions of CloudStack. It would be great if you could 
> > supply unit tests to validate this inner workings of this module and marvin 
> > based integration tests that we can run to see if this work with the 
> > intended hardware.
> > 
> > The last general point is that we would also need documentation on this 
> > plugin so administrators will know how to use this.
> 
> Ritu  Sabharwal wrote:
> Thanks for reviewing the code.
> 
> I have fixed the license in all the files.
> 
> I am working on writing the unit tests for the plugin.
> 
> I am working on providing the documentation on using the plugin.
> 
> I have tested the plugin with the simulator and see the configurations on 
> Brocade switches happening. Currently, I am setting up a real hardware setup 
> with Vmware hypervisor and Brocade switches so test the connectivity between 
> spawned VMs.
> 
> Can I continue writing the unit tests and marvin integration tests and 
> documentation after the July 19 date so that this plugin makes to 4.5 feature 
> freeze date.
> 
> I have updated the diffs with the changes for the license and other 
> comments.
> 
> Ritu  Sabharwal wrote:
> I am planning to include the following in the documentation:
>  - Brocade switch setup
>  - Connections to the Hypervisor hosts
>  - the flow to use the plugin from UI
> 
> Hugo Trippaers wrote:
> Thanks for fixing the open issues.
> 
> I think it's ok to work on the documentation while a release is being 
> tested (eventhough it is far better to have it ready for the testers). 
> However unittests and functional testcases need to be there before we can 
> merge the plugin. Without it we can not properly test the plugin to see if it 
> is fit to be part of the release. 
> 
> I'd rather have a completely done plugin in the 4.6 release than 
> something that is not complete in 4.5. So currently the blockers for a merge 
> into master are the two property files and we need unit and integration tests.
> 
> Ritu  Sabharwal wrote:
> Hi Hugo,
> 
> Thanks for reviewing the plugin.
> 
> Few points:
> 
> 1. The configuration using properties file was part of the Design 
> document 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Brocade+Network+Plugin+to+Orchestrate+Brocade+VDX+Switches
>  and was not raised as a concern earlier and the implementation is based on 
> that.  
> 
> Changing the implementation right now would involve some work. Can this 
> be done as an enhancement as part of bug fix during testing?
> 
> 2. For functional testcases, we are doing functional testing but how will 
> functional testcases be run by the community without the Brocade hardware? 
> 
> We are working on writing the unit and functional testcases.
>
> 
> Ritu  Sabharwal wrote:
> Hi Hugo,
> 
> I have added the unit tests, working on the the marvin integration tests.
> 
> Please reply back for the properties file change if that can be treated 
> an an enhancement bug fix during testing phase.
> 
> Thanks for reviewing and supporting the plugin.
> 
> Thanks & Regards,
> Ritu S.

Hi Hugo,

Just an update, I am working on removing the reading of configurations from the 
properties file and adding them as part of network provider configuration 
through APIs and UI. Also, working ont he marvin integration tests.

Should be able to update code by tomorrow for review.

Thanks & Regards,
Ritu S.


- Ritu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23314/#review47435
---


On July 11, 2014, 11:44 p.m., Ritu  Sabharwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23314/
> --

[HELP] CS GUI does not come up...

[Ritu Sabharwal]

I am building CS from source master on Windows and when I am running management 
server I am seeing this error:

INFO  [c.c.s.ConfigurationServerImpl] (main:null) Processing updateSSLKeyStore
INFO  [c.c.s.ConfigurationServerImpl] (main:null) SSL keystore located at 
C:\cygwin\home\rsabharw\cloudstack-oss\cloudstack\client\target\generated-webapp\WEB-INF\classes/cloud.keystore
WARN  [c.c.u.s.Script] (main:null) Exception: sudo keytool -genkey -keystore 
C:\cygwin\home\rsabharw\cloudstack-oss\cloudstack\client\target\generated-webapp\WEB-INF\classes/cloud.keystore
 -storepass vmops.com -keypass vmops.com -keyalg RSA -validity 3650 -dname 
cn="Cloudstack User",ou="englab.brocade.com",o="englab.brocade.com",c="Unknown"
java.io.IOException: Cannot run program "sudo": CreateProcess error=2, The 
system cannot find the file specified
at java.lang.ProcessBuilder.start(ProcessBuilder.java:1041)
at com.cloud.utils.script.Script.execute(Script.java:195)
at com.cloud.utils.script.Script.execute(Script.java:163)
at 
com.cloud.server.ConfigurationServerImpl.generateDefaultKeystore(ConfigurationServerImpl.java:599)
at 
com.cloud.server.ConfigurationServerImpl.updateSSLKeystore(ConfigurationServerImpl.java:629)
at 
com.cloud.server.ConfigurationServerImpl.persistDefaultValues(ConfigurationServerImpl.java:300)
at 
com.cloud.server.ConfigurationServerImpl.configure(ConfigurationServerImpl.java:165)
at 
org.apache.cloudstack.spring.lifecycle.CloudStackExtendedLifeCycle$3.with(CloudStackExtendedLifeCycle.java:114)
at 
org.apache.cloudstack.spring.lifecycle.CloudStackExtendedLifeCycle.with(CloudStackExtendedLifeCycle.java:153)
at 
org.apache.cloudstack.spring.lifecycle.CloudStackExtendedLifeCycle.configure(CloudStackExtendedLifeCycle.java:110)
at 
org.apache.cloudstack.spring.lifecycle.CloudStackExtendedLifeCycle.start(CloudStackExtendedLifeCycle.java:56)
at 
org.springframework.context.support.DefaultLifecycleProcessor.doStart(DefaultLifecycleProcessor.java:167)
at 
org.springframework.context.support.DefaultLifecycleProcessor.access$200(DefaultLifecycleProcessor.java:51)
at 
org.springframework.context.support.DefaultLifecycleProcessor$LifecycleGroup.start(DefaultLifecycleProcessor.java:339)
at 
org.springframework.context.support.DefaultLifecycleProcessor.startBeans(DefaultLifecycleProcessor.java:143)
at 
org.springframework.context.support.DefaultLifecycleProcessor.onRefresh(DefaultLifecycleProcessor.java:108)
at 
org.springframework.context.support.AbstractApplicationContext.finishRefresh(AbstractApplicationContext.java:945)
at 
org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:482)
at 
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.loadContext(DefaultModuleDefinitionSet.java:145)
at 
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet$2.with(DefaultModuleDefinitionSet.java:122)
at 
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule(DefaultModuleDefinitionSet.java:245)
at 
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule(DefaultModuleDefinitionSet.java:250)
at 
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule(DefaultModuleDefinitionSet.java:250)
at 
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule(DefaultModuleDefinitionSet.java:233)
at 
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.loadContexts(DefaultModuleDefinitionSet.java:117)
at 
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.load(DefaultModuleDefinitionSet.java:79)
at 
org.apache.cloudstack.spring.module.factory.ModuleBasedContextFactory.loadModules(ModuleBasedContextFactory.java:37)
at 
org.apache.cloudstack.spring.module.factory.CloudStackSpringContext.init(CloudStackSpringContext.java:70)
at 
org.apache.cloudstack.spring.module.factory.CloudStackSpringContext.(CloudStackSpringContext.java:57)
at 
org.apache.cloudstack.spring.module.factory.CloudStackSpringContext.(CloudStackSpringContext.java:61)
at 
org.apache.cloudstack.spring.module.web.CloudStackContextLoaderListener.contextInitialized(CloudStackContextLoaderListener.java:52)
at 
org.mortbay.jetty.handler.ContextHandler.startContext(ContextHandler.java:549)
at org.mortbay.jetty.servlet.Context.startContext(Context.java:136)
at 
org.mortbay.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1282)
at 
org.mortbay.jetty.handler.ContextHandler.doStart(ContextHandler.java:518)
at 
org.mortbay.jetty.webapp.WebAppContext.doStart(WebAppContext.java:499)
at 
org.mortbay.jetty.plugin.Jetty6PluginWebAppContext.doStart(Jetty6Plu

RE: [HELP] CS GUI does not come up...

[Ritu Sabharwal]

HI Prachi,

I tried this workaround, the server starts but the GUI does not come up.

There is no other error in the server logs. Why would the GUI not come up then?

Thanks & Regards,
Ritu S.

-Original Message-
From: Prachi Damle [mailto:prachi.da...@citrix.com] 
Sent: Monday, July 14, 2014 3:54 PM
To: dev@cloudstack.apache.org; Hugo Trippaers
Subject: RE: [HELP] CS GUI does not come up...

update configuration set value='false' where name='developer';

This should resolve the error - after updating the db, you will still see some 
stack trace regarding " CreateProcess error=2" but it will not stop the server 
from running.

Prachi
-----Original Message-
From: Ritu Sabharwal [mailto:rsabh...@brocade.com] 
Sent: Monday, July 14, 2014 3:49 PM
To: dev@cloudstack.apache.org; Hugo Trippaers
Subject: [HELP] CS GUI does not come up...

I am building CS from source master on Windows and when I am running management 
server I am seeing this error:

INFO  [c.c.s.ConfigurationServerImpl] (main:null) Processing updateSSLKeyStore 
INFO  [c.c.s.ConfigurationServerImpl] (main:null) SSL keystore located at 
C:\cygwin\home\rsabharw\cloudstack-oss\cloudstack\client\target\generated-webapp\WEB-INF\classes/cloud.keystore
WARN  [c.c.u.s.Script] (main:null) Exception: sudo keytool -genkey -keystore 
C:\cygwin\home\rsabharw\cloudstack-oss\cloudstack\client\target\generated-webapp\WEB-INF\classes/cloud.keystore
 -storepass vmops.com -keypass vmops.com -keyalg RSA -validity 3650 -dname 
cn="Cloudstack User",ou="englab.brocade.com",o="englab.brocade.com",c="Unknown"
java.io.IOException: Cannot run program "sudo": CreateProcess error=2, The 
system cannot find the file specified
at java.lang.ProcessBuilder.start(ProcessBuilder.java:1041)
at com.cloud.utils.script.Script.execute(Script.java:195)
at com.cloud.utils.script.Script.execute(Script.java:163)
at 
com.cloud.server.ConfigurationServerImpl.generateDefaultKeystore(ConfigurationServerImpl.java:599)
at 
com.cloud.server.ConfigurationServerImpl.updateSSLKeystore(ConfigurationServerImpl.java:629)
at 
com.cloud.server.ConfigurationServerImpl.persistDefaultValues(ConfigurationServerImpl.java:300)
at 
com.cloud.server.ConfigurationServerImpl.configure(ConfigurationServerImpl.java:165)
at 
org.apache.cloudstack.spring.lifecycle.CloudStackExtendedLifeCycle$3.with(CloudStackExtendedLifeCycle.java:114)
at 
org.apache.cloudstack.spring.lifecycle.CloudStackExtendedLifeCycle.with(CloudStackExtendedLifeCycle.java:153)
at 
org.apache.cloudstack.spring.lifecycle.CloudStackExtendedLifeCycle.configure(CloudStackExtendedLifeCycle.java:110)
at 
org.apache.cloudstack.spring.lifecycle.CloudStackExtendedLifeCycle.start(CloudStackExtendedLifeCycle.java:56)
at 
org.springframework.context.support.DefaultLifecycleProcessor.doStart(DefaultLifecycleProcessor.java:167)
at 
org.springframework.context.support.DefaultLifecycleProcessor.access$200(DefaultLifecycleProcessor.java:51)
at 
org.springframework.context.support.DefaultLifecycleProcessor$LifecycleGroup.start(DefaultLifecycleProcessor.java:339)
at 
org.springframework.context.support.DefaultLifecycleProcessor.startBeans(DefaultLifecycleProcessor.java:143)
at 
org.springframework.context.support.DefaultLifecycleProcessor.onRefresh(DefaultLifecycleProcessor.java:108)
at 
org.springframework.context.support.AbstractApplicationContext.finishRefresh(AbstractApplicationContext.java:945)
at 
org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:482)
at 
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.loadContext(DefaultModuleDefinitionSet.java:145)
at 
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet$2.with(DefaultModuleDefinitionSet.java:122)
at 
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule(DefaultModuleDefinitionSet.java:245)
at 
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule(DefaultModuleDefinitionSet.java:250)
at 
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule(DefaultModuleDefinitionSet.java:250)
at 
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule(DefaultModuleDefinitionSet.java:233)
at 
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.loadContexts(DefaultModuleDefinitionSet.java:117)
at 
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.load(DefaultModuleDefinitionSet.java:79)
at 
org.apache.cloudstack.spring.module.factory.ModuleBasedContextFactory.loadModules(ModuleBasedContextFactory.java:37)
at 
org.apache.cloudstack.spring.mod

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

[Ritu Sabharwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/
---

(Updated July 15, 2014, 9:16 p.m.)


Review request for cloudstack and Hugo Trippaers.


Changes
---

Updated diff after removing formatting of system.js. Also, removed the 
configuration reading from properties files. Now the plugin configurations are 
read as network service provider configurations from GUI or APIs.


Bugs: CLOUDSTACK-6823
https://issues.apache.org/jira/browse/CLOUDSTACK-6823


Repository: cloudstack-git


Description
---

First code drop for Brocade Network plugin to orchestrate Brocade VDX switches 
for L2 connectivity. Please create a new branch for Brocade plugin.


Diffs (updated)
-

  api/src/com/cloud/network/Network.java 885bffe 
  api/src/com/cloud/network/Networks.java 1e4d229 
  api/src/com/cloud/network/PhysicalNetwork.java 8cc214e 
  api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java 
e73f526 
  client/WEB-INF/classes/resources/messages.properties b504a18 
  client/WEB-INF/classes/resources/messages_zh_CN.properties 1ec4e95 
  client/pom.xml 29fef4f 
  client/tomcatconf/commands.properties.in d247aa0 
  plugins/pom.xml b5e6a61 
  setup/db/db/schema-440to450.sql 77445a9 
  tools/apidoc/gen_toc.py 827d6bf 
  ui/dictionary.jsp 9026a36 
  ui/scripts/system.js 9a98a5c 
  ui/scripts/ui-custom/zoneWizard.js 4091c03 

Diff: https://reviews.apache.org/r/22863/diff/


Testing
---

•   Create an isolated network; verify that the port-profile is created on 
the Brocade switch.
•   Attach a VM to the network; verify that the VMs MAC address is 
associated with the port profile of the network on the Brocade switch.
•   Delete VMs for an isolated network; verify that the VMs MAC address is 
disassociated with the port profile of the network on the Brocade switch.
•   Delete the isolated network; verify that the port-profile is deleted 
from the Brocade switch.


File Attachments


Diff for the existing cloudstack code
  
https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
Patch file for Brocade functionality code
  
https://reviews.apache.org/media/uploaded/files/2014/06/26/92bb0014-a7b7-4f0b-97c9-018d615b658a__brocade-vcs.patch


Thanks,

Ritu  Sabharwal

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

[Ritu Sabharwal]

> On July 15, 2014, 11:09 a.m., Hugo Trippaers wrote:
> > Can you resubmit this patch without the reformatting of system.js? At the 
> > moment it shows 4233 changes to that file, which is impossible for me to 
> > review. I need to see only the changes you made for the brocade plugin. If 
> > you think a reformat is needed you can submit the reformat as a separate 
> > patch, but we would prefer to keep the existing format.
> > 
> >

Hi Hugo,

I have resubmitted the patch. Updated diff after removing formatting of 
system.js. Also, removed the configuration reading from properties files. Now 
the plugin configurations are read as network service provider configurations 
from GUI or APIs.

Please review it.

Thanks & Regards,
Ritu S.


- Ritu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/#review47768
-------


On July 15, 2014, 9:16 p.m., Ritu  Sabharwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22863/
> ---
> 
> (Updated July 15, 2014, 9:16 p.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Bugs: CLOUDSTACK-6823
> https://issues.apache.org/jira/browse/CLOUDSTACK-6823
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> First code drop for Brocade Network plugin to orchestrate Brocade VDX 
> switches for L2 connectivity. Please create a new branch for Brocade plugin.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/Network.java 885bffe 
>   api/src/com/cloud/network/Networks.java 1e4d229 
>   api/src/com/cloud/network/PhysicalNetwork.java 8cc214e 
>   api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java 
> e73f526 
>   client/WEB-INF/classes/resources/messages.properties b504a18 
>   client/WEB-INF/classes/resources/messages_zh_CN.properties 1ec4e95 
>   client/pom.xml 29fef4f 
>   client/tomcatconf/commands.properties.in d247aa0 
>   plugins/pom.xml b5e6a61 
>   setup/db/db/schema-440to450.sql 77445a9 
>   tools/apidoc/gen_toc.py 827d6bf 
>   ui/dictionary.jsp 9026a36 
>   ui/scripts/system.js 9a98a5c 
>   ui/scripts/ui-custom/zoneWizard.js 4091c03 
> 
> Diff: https://reviews.apache.org/r/22863/diff/
> 
> 
> Testing
> ---
> 
> • Create an isolated network; verify that the port-profile is created on 
> the Brocade switch.
> • Attach a VM to the network; verify that the VMs MAC address is 
> associated with the port profile of the network on the Brocade switch.
> • Delete VMs for an isolated network; verify that the VMs MAC address is 
> disassociated with the port profile of the network on the Brocade switch.
> • Delete the isolated network; verify that the port-profile is deleted 
> from the Brocade switch.
> 
> 
> File Attachments
> 
> 
> Diff for the existing cloudstack code
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
> Patch file for Brocade functionality code
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/26/92bb0014-a7b7-4f0b-97c9-018d615b658a__brocade-vcs.patch
> 
> 
> Thanks,
> 
> Ritu  Sabharwal
> 
>

Re: Review Request 23314: Plugin specific code for the Brocade Network Plugin

[Ritu Sabharwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23314/
---

(Updated July 15, 2014, 9:52 p.m.)


Review request for cloudstack.


Changes
---

Removed the configuration reading from properties files. Now the plugin 
configurations are read as network service provider configurations from GUI or 
APIs.


Bugs: CLOUDSTACK-6823
https://issues.apache.org/jira/browse/CLOUDSTACK-6823


Repository: cloudstack-git


Description
---

Plugin specific code.


Diffs (updated)
-

  plugins/network-elements/brocade-vcs/pom.xml PRE-CREATION 
  plugins/network-elements/brocade-vcs/resources/BrocadeInterfaceSchema.xsd 
PRE-CREATION 
  plugins/network-elements/brocade-vcs/resources/BrocadePortProfileSchema.xsd 
PRE-CREATION 
  plugins/network-elements/brocade-vcs/resources/BrocadeShowVcsSchema.xsd 
PRE-CREATION 
  
plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/module.properties
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/spring-vcs-context.xml
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkAnswer.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkAnswer.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkAnswer.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkAnswer.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/StartupBrocadeVcsCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/AddBrocadeVcsDeviceCmd.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/DeleteBrocadeVcsDeviceCmd.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/ListBrocadeVcsDeviceNetworksCmd.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/ListBrocadeVcsDevicesCmd.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/BrocadeVcsDeviceVO.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/BrocadeVcsNetworkVlanMappingVO.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApiException.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/Constants.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsDao.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsDaoImpl.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsNetworkVlanMappingDao.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsNetworkVlanMappingDaoImpl.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/element/BrocadeVcsElement.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/element/BrocadeVcsElementService.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/guru/BrocadeVcsGuestNetworkGuru.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/resource/BrocadeVcsResource.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/test/com/cloud/network/brocade/BrocadeVcsApiTest.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/test/com/cloud/network/guru/BrocadeVcsGuestNetworkGuruTest.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/test/com/cloud/network/resource/BrocadeVcsResourceTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/23314/diff/


Testing
---


Thanks,

Ritu  Sabharwal

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

[Ritu Sabharwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/
---

(Updated July 15, 2014, 9:57 p.m.)


Review request for cloudstack and Hugo Trippaers.


Changes
---

Fixed the PhysicalNetwork.java.


Bugs: CLOUDSTACK-6823
https://issues.apache.org/jira/browse/CLOUDSTACK-6823


Repository: cloudstack-git


Description
---

First code drop for Brocade Network plugin to orchestrate Brocade VDX switches 
for L2 connectivity. Please create a new branch for Brocade plugin.


Diffs (updated)
-

  api/src/com/cloud/network/Network.java 885bffe 
  api/src/com/cloud/network/Networks.java 1e4d229 
  api/src/com/cloud/network/PhysicalNetwork.java 8cc214e 
  api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java 
e73f526 
  client/WEB-INF/classes/resources/messages.properties b504a18 
  client/WEB-INF/classes/resources/messages_zh_CN.properties 1ec4e95 
  client/pom.xml 29fef4f 
  client/tomcatconf/commands.properties.in d247aa0 
  plugins/pom.xml b5e6a61 
  setup/db/db/schema-440to450.sql 77445a9 
  tools/apidoc/gen_toc.py 827d6bf 
  ui/dictionary.jsp 9026a36 
  ui/scripts/system.js 9a98a5c 
  ui/scripts/ui-custom/zoneWizard.js 4091c03 

Diff: https://reviews.apache.org/r/22863/diff/


Testing
---

•   Create an isolated network; verify that the port-profile is created on 
the Brocade switch.
•   Attach a VM to the network; verify that the VMs MAC address is 
associated with the port profile of the network on the Brocade switch.
•   Delete VMs for an isolated network; verify that the VMs MAC address is 
disassociated with the port profile of the network on the Brocade switch.
•   Delete the isolated network; verify that the port-profile is deleted 
from the Brocade switch.


File Attachments


Diff for the existing cloudstack code
  
https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
Patch file for Brocade functionality code
  
https://reviews.apache.org/media/uploaded/files/2014/06/26/92bb0014-a7b7-4f0b-97c9-018d615b658a__brocade-vcs.patch


Thanks,

Ritu  Sabharwal

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

[Ritu Sabharwal]

> On July 15, 2014, 9:30 p.m., Erik Weber wrote:
> > api/src/com/cloud/network/PhysicalNetwork.java, line 36
> > <https://reviews.apache.org/r/22863/diff/4/?file=632861#file632861line36>
> >
> > Looks like you removed the 'N' in L3VPN

Fixed it.


- Ritu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/#review47820
---


On July 15, 2014, 9:57 p.m., Ritu  Sabharwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22863/
> ---
> 
> (Updated July 15, 2014, 9:57 p.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Bugs: CLOUDSTACK-6823
> https://issues.apache.org/jira/browse/CLOUDSTACK-6823
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> First code drop for Brocade Network plugin to orchestrate Brocade VDX 
> switches for L2 connectivity. Please create a new branch for Brocade plugin.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/Network.java 885bffe 
>   api/src/com/cloud/network/Networks.java 1e4d229 
>   api/src/com/cloud/network/PhysicalNetwork.java 8cc214e 
>   api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java 
> e73f526 
>   client/WEB-INF/classes/resources/messages.properties b504a18 
>   client/WEB-INF/classes/resources/messages_zh_CN.properties 1ec4e95 
>   client/pom.xml 29fef4f 
>   client/tomcatconf/commands.properties.in d247aa0 
>   plugins/pom.xml b5e6a61 
>   setup/db/db/schema-440to450.sql 77445a9 
>   tools/apidoc/gen_toc.py 827d6bf 
>   ui/dictionary.jsp 9026a36 
>   ui/scripts/system.js 9a98a5c 
>   ui/scripts/ui-custom/zoneWizard.js 4091c03 
> 
> Diff: https://reviews.apache.org/r/22863/diff/
> 
> 
> Testing
> ---
> 
> • Create an isolated network; verify that the port-profile is created on 
> the Brocade switch.
> • Attach a VM to the network; verify that the VMs MAC address is 
> associated with the port profile of the network on the Brocade switch.
> • Delete VMs for an isolated network; verify that the VMs MAC address is 
> disassociated with the port profile of the network on the Brocade switch.
> • Delete the isolated network; verify that the port-profile is deleted 
> from the Brocade switch.
> 
> 
> File Attachments
> 
> 
> Diff for the existing cloudstack code
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
> Patch file for Brocade functionality code
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/26/92bb0014-a7b7-4f0b-97c9-018d615b658a__brocade-vcs.patch
> 
> 
> Thanks,
> 
> Ritu  Sabharwal
> 
>

Re: Review Request 23314: Plugin specific code for the Brocade Network Plugin

[Ritu Sabharwal]

> On July 15, 2014, 11:21 a.m., Hugo Trippaers wrote:
> > This is looking good, when you addresses the comment on the system.js file 
> > in the other review i'll apply both patches. If the patches apply clean 
> > i'll run findbugs and cobertura to check for any issues and unit test 
> > coverage. 
> > 
> > Hugo

Hi Hugo,

I have fixed the system.js file. Also, removed the configuration reading from 
properties files. Now the plugin configurations are read as network service 
provider configurations from GUI or APIs. The unit tests are also updated for 
the change.

Please review it and do the needful so that we can make it by July 19.

Thanks & Regards,
Ritu S.


> On July 15, 2014, 11:21 a.m., Hugo Trippaers wrote:
> > plugins/network-elements/brocade-vcs/resources/BrocadeInterfaceSchema.xsd, 
> > line 5
> > <https://reviews.apache.org/r/23314/diff/2-3/?file=624832#file624832line5>
> >
> > Did you check with the rat plugin if the license is accepted like this?
> > 
> > I think the license is only properly detected with it is located in a 
> > comment like in the spring xml files.

The standard way to add comments to schema files is using annotation element. 
Reference: http://www.w3schools.com/schema/el_annotation.asp

The build throws parsing error if the comments are given like spring xml files. 
With annotation tag , the compilation goes fine and JAXB generation also works 
fine.

I did not find any xsd files in CloudStack codebase to get an example. What is 
the rat plugin?


- Ritu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23314/#review47769
---


On July 15, 2014, 9:52 p.m., Ritu  Sabharwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23314/
> ---
> 
> (Updated July 15, 2014, 9:52 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Bugs: CLOUDSTACK-6823
> https://issues.apache.org/jira/browse/CLOUDSTACK-6823
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Plugin specific code.
> 
> 
> Diffs
> -
> 
>   plugins/network-elements/brocade-vcs/pom.xml PRE-CREATION 
>   plugins/network-elements/brocade-vcs/resources/BrocadeInterfaceSchema.xsd 
> PRE-CREATION 
>   plugins/network-elements/brocade-vcs/resources/BrocadePortProfileSchema.xsd 
> PRE-CREATION 
>   plugins/network-elements/brocade-vcs/resources/BrocadeShowVcsSchema.xsd 
> PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/module.properties
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/spring-vcs-context.xml
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/StartupBrocadeVcsCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/AddBrocadeVcsDeviceCmd.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/DeleteBrocadeVcsDeviceCmd.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/ListBrocadeVcsDeviceNetworksCmd.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/ListBrocadeVcsDevicesCmd.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/BrocadeVcsDeviceVO.jav

Brocade Plugin review..

[Ritu Sabharwal]

Hi Hugo,

I have fixed the system.js file. Also, removed the configuration reading from 
properties files. Now the plugin configurations are read as network service 
provider configurations from GUI or APIs. The unit tests are also updated for 
the change.

Please review it and do the needful so that we can make it by July 19.

Thanks for reviewing the plugin.

Thanks & Regards,
Ritu S.

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

[Ritu Sabharwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/
---

(Updated July 17, 2014, 10:04 p.m.)


Review request for cloudstack and Hugo Trippaers.


Changes
---

Added marvin integration test.


Bugs: CLOUDSTACK-6823
https://issues.apache.org/jira/browse/CLOUDSTACK-6823


Repository: cloudstack-git


Description
---

First code drop for Brocade Network plugin to orchestrate Brocade VDX switches 
for L2 connectivity. Please create a new branch for Brocade plugin.


Diffs (updated)
-

  api/src/com/cloud/network/Network.java 885bffe 
  api/src/com/cloud/network/Networks.java 1e4d229 
  api/src/com/cloud/network/PhysicalNetwork.java 8cc214e 
  api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java 
e73f526 
  client/WEB-INF/classes/resources/messages.properties b504a18 
  client/WEB-INF/classes/resources/messages_zh_CN.properties 1ec4e95 
  client/pom.xml 29fef4f 
  client/tomcatconf/commands.properties.in d247aa0 
  plugins/pom.xml b5e6a61 
  setup/db/db/schema-440to450.sql 77445a9 
  setup/dev/advancedvcs.cfg PRE-CREATION 
  test/integration/component/test_brocade_vcs.py PRE-CREATION 
  tools/apidoc/gen_toc.py 827d6bf 
  ui/dictionary.jsp 9026a36 
  ui/scripts/system.js 9a98a5c 
  ui/scripts/ui-custom/zoneWizard.js 4091c03 

Diff: https://reviews.apache.org/r/22863/diff/


Testing
---

•   Create an isolated network; verify that the port-profile is created on 
the Brocade switch.
•   Attach a VM to the network; verify that the VMs MAC address is 
associated with the port profile of the network on the Brocade switch.
•   Delete VMs for an isolated network; verify that the VMs MAC address is 
disassociated with the port profile of the network on the Brocade switch.
•   Delete the isolated network; verify that the port-profile is deleted 
from the Brocade switch.


File Attachments


Diff for the existing cloudstack code
  
https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
Patch file for Brocade functionality code
  
https://reviews.apache.org/media/uploaded/files/2014/06/26/92bb0014-a7b7-4f0b-97c9-018d615b658a__brocade-vcs.patch


Thanks,

Ritu  Sabharwal

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

[Ritu Sabharwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/
---

(Updated July 17, 2014, 11:52 p.m.)


Review request for cloudstack and Hugo Trippaers.


Changes
---

Removed the cfg file from patch. Only for testing.


Bugs: CLOUDSTACK-6823
https://issues.apache.org/jira/browse/CLOUDSTACK-6823


Repository: cloudstack-git


Description
---

First code drop for Brocade Network plugin to orchestrate Brocade VDX switches 
for L2 connectivity. Please create a new branch for Brocade plugin.


Diffs (updated)
-

  api/src/com/cloud/network/Network.java 885bffe 
  api/src/com/cloud/network/Networks.java 1e4d229 
  api/src/com/cloud/network/PhysicalNetwork.java 8cc214e 
  api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java 
e73f526 
  client/WEB-INF/classes/resources/messages.properties b504a18 
  client/WEB-INF/classes/resources/messages_zh_CN.properties 1ec4e95 
  client/pom.xml 29fef4f 
  client/tomcatconf/commands.properties.in d247aa0 
  plugins/pom.xml b5e6a61 
  setup/db/db/schema-440to450.sql 77445a9 
  test/integration/component/test_brocade_vcs.py PRE-CREATION 
  tools/apidoc/gen_toc.py 827d6bf 
  ui/dictionary.jsp 9026a36 
  ui/scripts/system.js 9a98a5c 
  ui/scripts/ui-custom/zoneWizard.js 4091c03 

Diff: https://reviews.apache.org/r/22863/diff/


Testing (updated)
---

•   Create an isolated network; verify that the port-profile is created on 
the Brocade switch.
•   Attach a VM to the network; verify that the VMs MAC address is 
associated with the port profile of the network on the Brocade switch.
•   Delete VMs for an isolated network; verify that the VMs MAC address is 
disassociated with the port profile of the network on the Brocade switch.
•   Delete the isolated network; verify that the port-profile is deleted 
from the Brocade switch.

Integration test result:

Test Brocade Network and VM Creation ... === TestName: test_network_vcs | 
Status : SUCCESS ===
ok

--
Ran 1 test in 297.497s

OK


File Attachments


Diff for the existing cloudstack code
  
https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
Patch file for Brocade functionality code
  
https://reviews.apache.org/media/uploaded/files/2014/06/26/92bb0014-a7b7-4f0b-97c9-018d615b658a__brocade-vcs.patch


Thanks,

Ritu  Sabharwal

Review Request #22863 , #23314 : Brocade Plugin review request...

[Ritu Sabharwal]

Hi Hugo,

I have fixed the 3 items as proposed by you:

1.   Added the unit tests

2.   Added integration test

3.   Removed the configuration from properties file to networks service 
provider configuration using APIs or GUI.

Can you please review the plugin code so that we can make it by July 19th.

Thanks for reviewing the plugin and supporting us.

Thanks & Regards,
Ritu S.

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

[Ritu Sabharwal]

> On July 21, 2014, 2:02 p.m., Hugo Trippaers wrote:
> > Can you rebase on latest master as the patch currently fails to apply.
> > 
> > Cheers,
> > 
> > Hugo
> > 
> > 
> > patching file api/src/com/cloud/network/Network.java
> > Hunk #1 FAILED at 132.
> > Hunk #2 succeeded at 224 (offset 3 lines).
> > 1 out of 2 hunks FAILED -- saving rejects to file 
> > api/src/com/cloud/network/Network.java.rej
> > patching file api/src/com/cloud/network/Networks.java
> > patching file api/src/com/cloud/network/PhysicalNetwork.java
> > Hunk #1 FAILED at 33.
> > 1 out of 1 hunk FAILED -- saving rejects to file 
> > api/src/com/cloud/network/PhysicalNetwork.java.rej
> > patching file 
> > api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java
> > patching file client/WEB-INF/classes/resources/messages.properties
> > Hunk #1 FAILED at 327.
> > Hunk #2 FAILED at 500.
> > Hunk #3 succeeded at 880 (offset 6 lines).
> > Hunk #4 succeeded at 1426 (offset 7 lines).
> > Hunk #5 succeeded at 1639 with fuzz 2 (offset 7 lines).
> > 2 out of 5 hunks FAILED -- saving rejects to file 
> > client/WEB-INF/classes/resources/messages.properties.rej
> > patching file client/WEB-INF/classes/resources/messages_zh_CN.properties
> > Hunk #1 FAILED at 297.
> > Hunk #2 FAILED at 509.
> > Hunk #3 succeeded at 1612 with fuzz 2 (offset 4 lines).
> > 2 out of 3 hunks FAILED -- saving rejects to file 
> > client/WEB-INF/classes/resources/messages_zh_CN.properties.rej
> > patching file client/pom.xml
> > patching file client/tomcatconf/commands.properties.in
> > Hunk #1 succeeded at 607 (offset 1 line).
> > patching file plugins/pom.xml
> > Hunk #1 succeeded at 64 (offset 1 line).
> > patching file setup/db/db/schema-440to450.sql
> > Hunk #1 succeeded at 244 with fuzz 2 (offset 20 lines).
> > patching file test/integration/component/test_brocade_vcs.py
> > patching file tools/apidoc/gen_toc.py
> > Hunk #1 succeeded at 132 with fuzz 2.
> > patching file ui/dictionary.jsp
> > Hunk #1 FAILED at 349.
> > Hunk #2 FAILED at 505.
> > Hunk #3 succeeded at 870 (offset 7 lines).
> > Hunk #4 succeeded at 1436 with fuzz 2 (offset 8 lines).
> > Hunk #5 succeeded at 1742 (offset 9 lines).
> > 2 out of 5 hunks FAILED -- saving rejects to file ui/dictionary.jsp.rej
> > patching file ui/scripts/system.js
> > Hunk #2 succeeded at 12240 (offset 243 lines).
> > Hunk #3 succeeded at 19564 (offset 584 lines).
> > Hunk #4 succeeded at 20343 (offset 615 lines).
> > Hunk #5 succeeded at 20379 (offset 618 lines).
> > patching file ui/scripts/ui-custom/zoneWizard.js
> > Hunk #1 FAILED at 726.
> > 1 out of 1 hunk FAILED -- saving rejects to file 
> > ui/scripts/ui-custom/zoneWizard.js.rej
> >

Hi Hugo,

I have rebased to latest master and uploaded the patch. The patch now has both 
the changes: existing cloudstack code changes and plugin specific code.

Please review it and let me know if anything else is needed from my side.

Thanks & Regards,
Ritu Sabharwal.


- Ritu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/#review48220
---


On July 17, 2014, 11:52 p.m., Ritu  Sabharwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22863/
> ---
> 
> (Updated July 17, 2014, 11:52 p.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Bugs: CLOUDSTACK-6823
> https://issues.apache.org/jira/browse/CLOUDSTACK-6823
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> First code drop for Brocade Network plugin to orchestrate Brocade VDX 
> switches for L2 connectivity. Please create a new branch for Brocade plugin.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/Network.java 885bffe 
>   api/src/com/cloud/network/Networks.java 1e4d229 
>   api/src/com/cloud/network/PhysicalNetwork.java 8cc214e 
>   api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java 
> e73f526 
>   client/WEB-INF/classes/resources/messages.properties b504a18 
>   client/WEB-INF/classes/resources/messages_zh_CN.properties 1ec4e95 
>   client/pom.xml 29fef4f 
>   client/tomcatconf/commands.properties.in d247aa0 
>   plugins/pom.xml b5e6a61 
>   setup/db/db/schema-440to450.sql 77445a9 
>   test/integration/component/test_brocade_

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

[Ritu Sabharwal]

/pom.xml eff5a01 
  setup/db/db/schema-440to450.sql 6cb81c6 
  test/integration/component/test_brocade_vcs.py PRE-CREATION 
  tools/apidoc/gen_toc.py bcc8417 
  ui/dictionary.jsp c84d0dd 
  ui/scripts/system.js 502007f 
  ui/scripts/ui-custom/zoneWizard.js 645c2b1 

Diff: https://reviews.apache.org/r/22863/diff/


Testing
---

•   Create an isolated network; verify that the port-profile is created on 
the Brocade switch.
•   Attach a VM to the network; verify that the VMs MAC address is 
associated with the port profile of the network on the Brocade switch.
•   Delete VMs for an isolated network; verify that the VMs MAC address is 
disassociated with the port profile of the network on the Brocade switch.
•   Delete the isolated network; verify that the port-profile is deleted 
from the Brocade switch.

Integration test result:

Test Brocade Network and VM Creation ... === TestName: test_network_vcs | 
Status : SUCCESS ===
ok

--
Ran 1 test in 297.497s

OK


File Attachments


Diff for the existing cloudstack code
  
https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
Patch file for Brocade functionality code
  
https://reviews.apache.org/media/uploaded/files/2014/06/26/92bb0014-a7b7-4f0b-97c9-018d615b658a__brocade-vcs.patch


Thanks,

Ritu  Sabharwal

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

[Ritu Sabharwal]

/pom.xml eff5a01 
  setup/db/db/schema-440to450.sql 6cb81c6 
  test/integration/component/test_brocade_vcs.py PRE-CREATION 
  tools/apidoc/gen_toc.py bcc8417 
  ui/dictionary.jsp c84d0dd 
  ui/scripts/system.js 502007f 
  ui/scripts/ui-custom/zoneWizard.js 645c2b1 

Diff: https://reviews.apache.org/r/22863/diff/


Testing
---

•   Create an isolated network; verify that the port-profile is created on 
the Brocade switch.
•   Attach a VM to the network; verify that the VMs MAC address is 
associated with the port profile of the network on the Brocade switch.
•   Delete VMs for an isolated network; verify that the VMs MAC address is 
disassociated with the port profile of the network on the Brocade switch.
•   Delete the isolated network; verify that the port-profile is deleted 
from the Brocade switch.

Integration test result:

Test Brocade Network and VM Creation ... === TestName: test_network_vcs | 
Status : SUCCESS ===
ok

--
Ran 1 test in 297.497s

OK


File Attachments


Diff for the existing cloudstack code
  
https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
Patch file for Brocade functionality code
  
https://reviews.apache.org/media/uploaded/files/2014/06/26/92bb0014-a7b7-4f0b-97c9-018d615b658a__brocade-vcs.patch


Thanks,

Ritu  Sabharwal

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

[Ritu Sabharwal]

> On July 22, 2014, 9:57 a.m., Hugo Trippaers wrote:
> > The patch applies cleanly now, thanks for rebasing.
> > 
> > Can you have a look at the following findbug findings:
> > [INFO] --- findbugs-maven-plugin:2.5.3:check (cloudstack-findbugs) @ 
> > cloud-plugin-network-vcs ---
> > [INFO] BugInstance size is 2
> > [INFO] Error size is 0
> > [INFO] Total bugs: 2
> > [INFO] Found reliance on default encoding in 
> > com.cloud.network.brocade.BrocadeVcsApi.executeRetreiveStatus(String): new 
> > java.io.InputStreamReader(InputStream) 
> > ["com.cloud.network.brocade.BrocadeVcsApi"] At BrocadeVcsApi.java:[lines 
> > 67-520]
> > [INFO] Found reliance on default encoding in 
> > com.cloud.network.brocade.BrocadeVcsApi.responseToErrorMessage(HttpResponse):
> >  new java.io.InputStreamReader(InputStream) 
> > ["com.cloud.network.brocade.BrocadeVcsApi"] At BrocadeVcsApi.java:[lines 
> > 67-520]
> > 
> > The rat check (mvn -pl org.apache.cloudstack:cloudstack 
> > org.apache.rat:apache-rat-plugin:0.10:check) is clear, no no license issues.
> > 
> > If you can fix the two findbug findings i can merge it.
> > 
> > 
> >

Hi Hugo,

I have fixed the 2 findbug findings.

Thanks & Regards,
Ritu Sabharwal.


- Ritu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/#review48356
---


On July 22, 2014, 7:19 p.m., Ritu  Sabharwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22863/
> ---
> 
> (Updated July 22, 2014, 7:19 p.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Bugs: CLOUDSTACK-6823
> https://issues.apache.org/jira/browse/CLOUDSTACK-6823
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> First code drop for Brocade Network plugin to orchestrate Brocade VDX 
> switches for L2 connectivity. Please create a new branch for Brocade plugin.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/Network.java 0a08f28 
>   api/src/com/cloud/network/Networks.java 1ad3350 
>   api/src/com/cloud/network/PhysicalNetwork.java 024b3ce 
>   api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java 
> e73f526 
>   client/WEB-INF/classes/resources/messages.properties bb75b08 
>   client/WEB-INF/classes/resources/messages_zh_CN.properties d7a0ca9 
>   client/pom.xml 410cb19 
>   client/tomcatconf/commands.properties.in aa03949 
>   plugins/network-elements/brocade-vcs/pom.xml PRE-CREATION 
>   plugins/network-elements/brocade-vcs/resources/BrocadeInterfaceSchema.xsd 
> PRE-CREATION 
>   plugins/network-elements/brocade-vcs/resources/BrocadePortProfileSchema.xsd 
> PRE-CREATION 
>   plugins/network-elements/brocade-vcs/resources/BrocadeShowVcsSchema.xsd 
> PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/module.properties
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/spring-vcs-context.xml
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/StartupBrocadeVcsCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/AddBrocadeVcsDeviceCmd.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/DeleteBrocadeVcsDeviceCmd.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

[Ritu Sabharwal]

/pom.xml eff5a01 
  setup/db/db/schema-440to450.sql 6cb81c6 
  test/integration/component/test_brocade_vcs.py PRE-CREATION 
  tools/apidoc/gen_toc.py bcc8417 
  ui/dictionary.jsp c84d0dd 
  ui/scripts/system.js 502007f 
  ui/scripts/ui-custom/zoneWizard.js 645c2b1 

Diff: https://reviews.apache.org/r/22863/diff/


Testing
---

•   Create an isolated network; verify that the port-profile is created on 
the Brocade switch.
•   Attach a VM to the network; verify that the VMs MAC address is 
associated with the port profile of the network on the Brocade switch.
•   Delete VMs for an isolated network; verify that the VMs MAC address is 
disassociated with the port profile of the network on the Brocade switch.
•   Delete the isolated network; verify that the port-profile is deleted 
from the Brocade switch.

Integration test result:

Test Brocade Network and VM Creation ... === TestName: test_network_vcs | 
Status : SUCCESS ===
ok

--
Ran 1 test in 297.497s

OK


File Attachments


Diff for the existing cloudstack code
  
https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
Patch file for Brocade functionality code
  
https://reviews.apache.org/media/uploaded/files/2014/06/26/92bb0014-a7b7-4f0b-97c9-018d615b658a__brocade-vcs.patch


Thanks,

Ritu  Sabharwal

RE: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

[Ritu Sabharwal]

Hi Hugo,

Thanks for reviewing and approving the Brocade VCS plugin.

Thanks & Regards,
Ritu Sabharwal.

-Original Message-
From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers
Sent: Wednesday, July 23, 2014 2:15 AM
To: 
Cc: Ritu Sabharwal
Subject: Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for 
Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

Hey all,

Just pushed the brocade VDX code into master.

* fing bugs is not showing any issues
* decent unit test coverage
* includes functional test procedure
* majority of the functional code is contained in a plugin, minimal changes to 
core

Cheers,

Hugo



On 23 jul. 2014, at 11:12, Hugo Trippaers  wrote:

> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22863/#review48487
> ---
> 
> Ship it!
> 
> 
> commit 628d8e66f77053de9819436739325720710175ed
> Author: Ritu Sabharwal 
> Date:   Wed Jul 23 08:51:20 2014 +0200
> 
>CLOUDSTACK-6823 : First code drop for Brocade Network plugin to 
> orchestrate Brocade VDX switches for L2 connectivity
> 
>Signed-off-by: Hugo Trippaers 
> 
> 
> - Hugo Trippaers
> 
> 
> On July 22, 2014, 9:44 p.m., Ritu  Sabharwal wrote:
>> 
>> ---
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/22863/
>> ---
>> 
>> (Updated July 22, 2014, 9:44 p.m.)
>> 
>> 
>> Review request for cloudstack and Hugo Trippaers.
>> 
>> 
>> Bugs: CLOUDSTACK-6823
>>https://issues.apache.org/jira/browse/CLOUDSTACK-6823
>> 
>> 
>> Repository: cloudstack-git
>> 
>> 
>> Description
>> ---
>> 
>> First code drop for Brocade Network plugin to orchestrate Brocade VDX 
>> switches for L2 connectivity. Please create a new branch for Brocade plugin.
>> 
>> 
>> Diffs
>> -
>> 
>>  api/src/com/cloud/network/Network.java 0a08f28  
>> api/src/com/cloud/network/Networks.java 1ad3350  
>> api/src/com/cloud/network/PhysicalNetwork.java 024b3ce  
>> api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.ja
>> va e73f526  client/WEB-INF/classes/resources/messages.properties 
>> bb75b08  client/WEB-INF/classes/resources/messages_zh_CN.properties 
>> d7a0ca9  client/pom.xml 410cb19  
>> client/tomcatconf/commands.properties.in aa03949  
>> plugins/network-elements/brocade-vcs/pom.xml PRE-CREATION  
>> plugins/network-elements/brocade-vcs/resources/BrocadeInterfaceSchema
>> .xsd PRE-CREATION  
>> plugins/network-elements/brocade-vcs/resources/BrocadePortProfileSche
>> ma.xsd PRE-CREATION  
>> plugins/network-elements/brocade-vcs/resources/BrocadeShowVcsSchema.x
>> sd PRE-CREATION  
>> plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vc
>> s/module.properties PRE-CREATION  
>> plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vc
>> s/spring-vcs-context.xml PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/Associat
>> eMacToNetworkAnswer.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/Associat
>> eMacToNetworkCommand.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNe
>> tworkAnswer.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNe
>> tworkCommand.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNe
>> tworkAnswer.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNe
>> tworkCommand.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/Disassoc
>> iateMacFromNetworkAnswer.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/Disassoc
>> iateMacFromNetworkCommand.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/StartupB
>> rocadeVcsCommand.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/AddBr
>> ocadeVcsDeviceCmd.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/Delet
>> eBrocadeVcsDeviceCmd.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/ListB
>> rocadeVcsDeviceNetworksCmd.java PRE-CREATION  
>> plugins/n

RE: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

[Ritu Sabharwal]

That's right Hugo.

Thanks & Regards,
Ritu S.

-Original Message-
From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers
Sent: Wednesday, July 23, 2014 5:29 AM
To: dev@cloudstack.apache.org
Cc: Ritu Sabharwal
Subject: Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for 
Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

Sudha,

I think those tests are in test/integration/component/test_brocade_vcs.py that 
Ritu included.

Cheers,

Hugo

On 23 jul. 2014, at 14:07, Sudha Ponnaganti  wrote:

> Ritu,
> 
> Would be good to add automated tests for the procedure you have outlined.  
> Marvin has already similar tests and you should be able to reuse them. 
> 
> Thanks
> /sudha
> 
>>> Testing
>>> ---
>>> 
>>> *   Create an isolated network; verify that the port-profile is created on 
>>> the Brocade switch.
>>> *   Attach a VM to the network; verify that the VMs MAC address is 
>>> associated with the port profile of the network on the Brocade switch.
>>> *   Delete VMs for an isolated network; verify that the VMs MAC address is 
>>> disassociated with the port profile of the network on the Brocade switch.
>>> *   Delete the isolated network; verify that the port-profile is deleted 
>>> from the Brocade switch.
>>> 
>>> Integration test result:
>>> 
>>> Test Brocade Network and VM Creation ... === TestName: 
>>> test_network_vcs | Status : SUCCESS === ok
>>> 
> 
> -Original Message-
> From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers
> Sent: Wednesday, July 23, 2014 2:15 AM
> To: 
> Cc: Ritu Sabharwal
> Subject: Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for 
> Brocade Network plugin to orchestrate Brocade VDX switches for L2 
> connectivity.
> 
> Hey all,
> 
> Just pushed the brocade VDX code into master.
> 
> * fing bugs is not showing any issues
> * decent unit test coverage
> * includes functional test procedure
> * majority of the functional code is contained in a plugin, minimal 
> changes to core
> 
> Cheers,
> 
> Hugo
> 
> 
> 
> On 23 jul. 2014, at 11:12, Hugo Trippaers  
> wrote:
> 
>> 
>> -------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/22863/#review48487
>> ---
>> 
>> Ship it!
>> 
>> 
>> commit 628d8e66f77053de9819436739325720710175ed
>> Author: Ritu Sabharwal 
>> Date:   Wed Jul 23 08:51:20 2014 +0200
>> 
>>   CLOUDSTACK-6823 : First code drop for Brocade Network plugin to 
>> orchestrate Brocade VDX switches for L2 connectivity
>> 
>>   Signed-off-by: Hugo Trippaers 
>> 
>> 
>> - Hugo Trippaers
>> 
>> 
>> On July 22, 2014, 9:44 p.m., Ritu  Sabharwal wrote:
>>> 
>>> ---
>>> This is an automatically generated e-mail. To reply, visit:
>>> https://reviews.apache.org/r/22863/
>>> ---
>>> 
>>> (Updated July 22, 2014, 9:44 p.m.)
>>> 
>>> 
>>> Review request for cloudstack and Hugo Trippaers.
>>> 
>>> 
>>> Bugs: CLOUDSTACK-6823
>>>   https://issues.apache.org/jira/browse/CLOUDSTACK-6823
>>> 
>>> 
>>> Repository: cloudstack-git
>>> 
>>> 
>>> Description
>>> ---
>>> 
>>> First code drop for Brocade Network plugin to orchestrate Brocade VDX 
>>> switches for L2 connectivity. Please create a new branch for Brocade plugin.
>>> 
>>> 
>>> Diffs
>>> -
>>> 
>>> api/src/com/cloud/network/Network.java 0a08f28 
>>> api/src/com/cloud/network/Networks.java 1ad3350 
>>> api/src/com/cloud/network/PhysicalNetwork.java 024b3ce 
>>> api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.j
>>> a va e73f526  client/WEB-INF/classes/resources/messages.properties
>>> bb75b08  client/WEB-INF/classes/resources/messages_zh_CN.properties
>>> d7a0ca9  client/pom.xml 410cb19
>>> client/tomcatconf/commands.properties.in aa03949 
>>> plugins/network-elements/brocade-vcs/pom.xml PRE-CREATION 
>>> plugins/network-elements/brocade-vcs/resources/BrocadeInterfaceSchem
>>> a
>>> .xsd PRE-CREATION
>>> plugins/network-elements/brocade-vcs/resources/BrocadePortProfileSch
&g

RE: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

[Ritu Sabharwal]

Hi Hugo,

Where can I submit the Brocade Plugin Usage document?

Thanks & Regards,
Ritu S.

-Original Message-
From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers
Sent: Wednesday, July 23, 2014 2:15 AM
To: 
Cc: Ritu Sabharwal
Subject: Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for 
Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

Hey all,

Just pushed the brocade VDX code into master.

* fing bugs is not showing any issues
* decent unit test coverage
* includes functional test procedure
* majority of the functional code is contained in a plugin, minimal changes to 
core

Cheers,

Hugo



On 23 jul. 2014, at 11:12, Hugo Trippaers  wrote:

> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22863/#review48487
> ---
> 
> Ship it!
> 
> 
> commit 628d8e66f77053de9819436739325720710175ed
> Author: Ritu Sabharwal 
> Date:   Wed Jul 23 08:51:20 2014 +0200
> 
>CLOUDSTACK-6823 : First code drop for Brocade Network plugin to 
> orchestrate Brocade VDX switches for L2 connectivity
> 
>Signed-off-by: Hugo Trippaers 
> 
> 
> - Hugo Trippaers
> 
> 
> On July 22, 2014, 9:44 p.m., Ritu  Sabharwal wrote:
>> 
>> ---
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/22863/
>> ---
>> 
>> (Updated July 22, 2014, 9:44 p.m.)
>> 
>> 
>> Review request for cloudstack and Hugo Trippaers.
>> 
>> 
>> Bugs: CLOUDSTACK-6823
>>https://issues.apache.org/jira/browse/CLOUDSTACK-6823
>> 
>> 
>> Repository: cloudstack-git
>> 
>> 
>> Description
>> ---
>> 
>> First code drop for Brocade Network plugin to orchestrate Brocade VDX 
>> switches for L2 connectivity. Please create a new branch for Brocade plugin.
>> 
>> 
>> Diffs
>> -
>> 
>>  api/src/com/cloud/network/Network.java 0a08f28  
>> api/src/com/cloud/network/Networks.java 1ad3350  
>> api/src/com/cloud/network/PhysicalNetwork.java 024b3ce  
>> api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.ja
>> va e73f526  client/WEB-INF/classes/resources/messages.properties 
>> bb75b08  client/WEB-INF/classes/resources/messages_zh_CN.properties 
>> d7a0ca9  client/pom.xml 410cb19  
>> client/tomcatconf/commands.properties.in aa03949  
>> plugins/network-elements/brocade-vcs/pom.xml PRE-CREATION  
>> plugins/network-elements/brocade-vcs/resources/BrocadeInterfaceSchema
>> .xsd PRE-CREATION  
>> plugins/network-elements/brocade-vcs/resources/BrocadePortProfileSche
>> ma.xsd PRE-CREATION  
>> plugins/network-elements/brocade-vcs/resources/BrocadeShowVcsSchema.x
>> sd PRE-CREATION  
>> plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vc
>> s/module.properties PRE-CREATION  
>> plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vc
>> s/spring-vcs-context.xml PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/Associat
>> eMacToNetworkAnswer.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/Associat
>> eMacToNetworkCommand.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNe
>> tworkAnswer.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNe
>> tworkCommand.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNe
>> tworkAnswer.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNe
>> tworkCommand.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/Disassoc
>> iateMacFromNetworkAnswer.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/Disassoc
>> iateMacFromNetworkCommand.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/StartupB
>> rocadeVcsCommand.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/AddBr
>> ocadeVcsDeviceCmd.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/Delet
>> eBrocadeVcsDeviceCmd.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/ListB
>> rocadeVcsDeviceNetworksCmd.java PRE-CREATION  
>> plugins/netw

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

[Ritu Sabharwal]

 
  plugins/pom.xml eff5a01 
  setup/db/db/schema-440to450.sql 6cb81c6 
  test/integration/component/test_brocade_vcs.py PRE-CREATION 
  tools/apidoc/gen_toc.py bcc8417 
  ui/dictionary.jsp c84d0dd 
  ui/scripts/system.js 502007f 
  ui/scripts/ui-custom/zoneWizard.js 645c2b1 

Diff: https://reviews.apache.org/r/22863/diff/


Testing
---

•   Create an isolated network; verify that the port-profile is created on 
the Brocade switch.
•   Attach a VM to the network; verify that the VMs MAC address is 
associated with the port profile of the network on the Brocade switch.
•   Delete VMs for an isolated network; verify that the VMs MAC address is 
disassociated with the port profile of the network on the Brocade switch.
•   Delete the isolated network; verify that the port-profile is deleted 
from the Brocade switch.

Integration test result:

Test Brocade Network and VM Creation ... === TestName: test_network_vcs | 
Status : SUCCESS ===
ok

--
Ran 1 test in 297.497s

OK


File Attachments


Diff for the existing cloudstack code
  
https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
Patch file for Brocade functionality code
  
https://reviews.apache.org/media/uploaded/files/2014/06/26/92bb0014-a7b7-4f0b-97c9-018d615b658a__brocade-vcs.patch


Thanks,

Ritu  Sabharwal

RE: New Defects reported by Coverity Scan for cloudstack

[Ritu Sabharwal]

Hi Hugo,

I have fixed the reported findings and posted the patch on review board.

Thanks & Regards,
Ritu S.

From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers
Sent: Tuesday, July 29, 2014 6:41 AM
To: Ritu Sabharwal
Cc: ; Santhosh Edukulla
Subject: Fwd: New Defects reported by Coverity Scan for cloudstack

Ritu,

Coverity identified a number of issues with the brocade plugin. Could you have 
a look at them and post the fixes on the review board?


If you need additional details on the findings you can request coverity access 
here : https://scan.coverity.com/projects/943

Cheers,

Hugo


Begin forwarded message:


From: scan-ad...@coverity.com<mailto:scan-ad...@coverity.com>
Subject: New Defects reported by Coverity Scan for cloudstack
Date: 29 juli 2014 15:22:48 CEST


Hi,


Please find the latest report on new defect(s) introduced to cloudstack found 
with Coverity Scan.

Defect(s) Reported-by: Coverity Scan
Showing 7 of 7 defect(s)


** CID 1229114:  Resource leak  (RESOURCE_LEAK)
/plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java:
 509 in 
com.cloud.network.brocade.BrocadeVcsApi.responseToErrorMessage(org.apache.http.HttpResponse)()
/plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java:
 513 in 
com.cloud.network.brocade.BrocadeVcsApi.responseToErrorMessage(org.apache.http.HttpResponse)()

** CID 1229113:  Resource leak  (RESOURCE_LEAK)
/plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java:
 457 in 
com.cloud.network.brocade.BrocadeVcsApi.executeRetreiveStatus(java.lang.String)()

** CID 1229115:  Dereference before null check  (REVERSE_INULL)
/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java:
 6299 in 
com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.execute(com.cloud.agent.api.CreateVMSnapshotCommand)()

** CID 1229121:  UrF: Unread field  (FB.URF_UNREAD_FIELD)
/plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java:
 67 in ()
/plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java:
 71 in ()
/plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java:
 55 in ()
/plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java:
 59 in ()
/plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java:
 63 in ()

** CID 1229120:  WMI: Inefficient Map Iterator  (FB.WMI_WRONG_MAP_ITERATOR)
/engine/schema/src/com/cloud/capacity/dao/CapacityDaoImpl.java: 478 in 
com.cloud.capacity.dao.CapacityDaoImpl.findCapacityBy(java.lang.Integer, 
java.lang.Long, java.lang.Long, java.lang.Long)()

** CID 1229119:  DLS: Dead local store  (FB.DLS_DEAD_LOCAL_STORE)
/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java:
 4438 in 
com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.initialize()()

** CID 1229116:  REC: RuntimeException capture  (FB.REC_CATCH_EXCEPTION)
/engine/schema/src/com/cloud/storage/dao/VMTemplatePoolDaoImpl.java: 189 in 
com.cloud.storage.dao.VMTemplatePoolDaoImpl.listByTemplateStatus(long, long, 
long, com.cloud.storage.VMTemplateStorageResourceAssoc$Status)()



*** CID 1229114:  Resource leak  (RESOURCE_LEAK)
/plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java:
 509 in 
com.cloud.network.brocade.BrocadeVcsApi.responseToErrorMessage(org.apache.http.HttpResponse)()
503 try {
504
505 BufferedReader rd = new BufferedReader(new 
InputStreamReader(response.getEntity().getContent(), Charset.forName("UTF-8")));
506
507 StringBuffer result = new StringBuffer();
508 String line = "";

   CID 1229114:  Resource leak  (RESOURCE_LEAK)
   Variable "rd" going out of scope leaks the resource it refers to.
509 while ((line = rd.readLine()) != null) {
510 result.append(line);
511 }
512
513 return result.toString();
514 } catch (IOException e) {
/plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java:
 513 in 
com.cloud.network.brocade.BrocadeVcsApi.responseToErrorMessage(org.apache.http.HttpResponse)()
507 StringBuffer result = new StringBuffer();
508 String line = "";
509 while ((line = rd.readLine()) != null) {
510 result.append(line);
511 }
512

   CID 1229114:  Resource leak  (RESOURCE_LEAK)
   Variable "rd" going out of scope leaks the resource it refers to.
513 return result.t

Review Request 24111: Coverity findings for brocade-plugin

[Ritu Sabharwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24111/
---

Review request for cloudstack and Hugo Trippaers.


Bugs: CLOUDSTACK-6823
https://issues.apache.org/jira/browse/CLOUDSTACK-6823


Repository: cloudstack-git


Description
---

Fixed Coverity findings for brocade-plugin


Diffs
-

  
plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java
 60edbcf 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java
 d5f06f8 

Diff: https://reviews.apache.org/r/24111/diff/


Testing
---


Thanks,

Ritu  Sabharwal

RE: New Defects reported by Coverity Scan for cloudstack

[Ritu Sabharwal]

Hi Hugo,

I have created a separate review request based on current master.

The review request is: https://reviews.apache.org/r/24111/


Thanks & Regards,
Ritu S.

From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers
Sent: Tuesday, July 29, 2014 11:09 PM
To: Ritu Sabharwal
Cc: ; Santhosh Edukulla
Subject: Re: New Defects reported by Coverity Scan for cloudstack

Hey Ritu,

Thanks! Could you post the patch as a separate review? That way it will be a 
lot easier for me to merge the changes.

The easiest way to do it is to base the new patch on the current state of the 
master branch.

Cheers,

Hugo


On 29 jul. 2014, at 22:32, Ritu Sabharwal 
mailto:rsabh...@brocade.com>> wrote:


Hi Hugo,

I have fixed the reported findings and posted the patch on review board.

Thanks & Regards,
Ritu S.

From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers
Sent: Tuesday, July 29, 2014 6:41 AM
To: Ritu Sabharwal
Cc: mailto:dev@cloudstack.apache.org>>; Santhosh 
Edukulla
Subject: Fwd: New Defects reported by Coverity Scan for cloudstack

Ritu,

Coverity identified a number of issues with the brocade plugin. Could you have 
a look at them and post the fixes on the review board?


If you need additional details on the findings you can request coverity access 
here : https://scan.coverity.com/projects/943

Cheers,

Hugo


Begin forwarded message:



From: scan-ad...@coverity.com<mailto:scan-ad...@coverity.com>
Subject: New Defects reported by Coverity Scan for cloudstack
Date: 29 juli 2014 15:22:48 CEST


Hi,


Please find the latest report on new defect(s) introduced to cloudstack found 
with Coverity Scan.

Defect(s) Reported-by: Coverity Scan
Showing 7 of 7 defect(s)


** CID 1229114:  Resource leak  (RESOURCE_LEAK)
/plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java:
 509 in 
com.cloud.network.brocade.BrocadeVcsApi.responseToErrorMessage(org.apache.http.HttpResponse)()
/plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java:
 513 in 
com.cloud.network.brocade.BrocadeVcsApi.responseToErrorMessage(org.apache.http.HttpResponse)()

** CID 1229113:  Resource leak  (RESOURCE_LEAK)
/plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java:
 457 in 
com.cloud.network.brocade.BrocadeVcsApi.executeRetreiveStatus(java.lang.String)()

** CID 1229115:  Dereference before null check  (REVERSE_INULL)
/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java:
 6299 in 
com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.execute(com.cloud.agent.api.CreateVMSnapshotCommand)()

** CID 1229121:  UrF: Unread field  (FB.URF_UNREAD_FIELD)
/plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java:
 67 in ()
/plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java:
 71 in ()
/plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java:
 55 in ()
/plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java:
 59 in ()
/plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java:
 63 in ()

** CID 1229120:  WMI: Inefficient Map Iterator  (FB.WMI_WRONG_MAP_ITERATOR)
/engine/schema/src/com/cloud/capacity/dao/CapacityDaoImpl.java: 478 in 
com.cloud.capacity.dao.CapacityDaoImpl.findCapacityBy(java.lang.Integer, 
java.lang.Long, java.lang.Long, java.lang.Long)()

** CID 1229119:  DLS: Dead local store  (FB.DLS_DEAD_LOCAL_STORE)
/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java:
 4438 in 
com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.initialize()()

** CID 1229116:  REC: RuntimeException capture  (FB.REC_CATCH_EXCEPTION)
/engine/schema/src/com/cloud/storage/dao/VMTemplatePoolDaoImpl.java: 189 in 
com.cloud.storage.dao.VMTemplatePoolDaoImpl.listByTemplateStatus(long, long, 
long, com.cloud.storage.VMTemplateStorageResourceAssoc$Status)()



*** CID 1229114:  Resource leak  (RESOURCE_LEAK)
/plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java:
 509 in 
com.cloud.network.brocade.BrocadeVcsApi.responseToErrorMessage(org.apache.http.HttpResponse)()
503 try {
504
505 BufferedReader rd = new BufferedReader(new 
InputStreamReader(response.getEntity().getContent(), Charset.forName("UTF-8")));
506
507 StringBuffer result = new StringBuffer();
508 String line = "";


   CID 1229114:  Resource leak  (RESOURCE_LEAK)
   Variable "rd" going out of scope leaks the resource it refers to.
509 while ((line = rd.readLine()) != null) {
510   

Re: Review Request 24111: Coverity findings for brocade-plugin

[Ritu Sabharwal]

> On July 31, 2014, 4:19 a.m., Santhosh Edukulla wrote:
> > plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java,
> >  line 482
> > <https://reviews.apache.org/r/24111/diff/1/?file=646144#file646144line482>
> >
> > Message info seems to be corrected.

Hi Santhosh,

What is fix required here?

Thanks & Regards,
Ritu.


> On July 31, 2014, 4:19 a.m., Santhosh Edukulla wrote:
> > plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java,
> >  line 561
> > <https://reviews.apache.org/r/24111/diff/1/?file=646144#file646144line561>
> >
> > Missing try\catch here. But, there is a better way suggested by Daan to 
> > auto close resources using try-with-resource to avoid any of these usages.

I will fix this using try-with-resources.


- Ritu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24111/#review49200
-------


On July 30, 2014, 7:44 p.m., Ritu  Sabharwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24111/
> ---
> 
> (Updated July 30, 2014, 7:44 p.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Bugs: CLOUDSTACK-6823
> https://issues.apache.org/jira/browse/CLOUDSTACK-6823
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixed Coverity findings for brocade-plugin
> 
> 
> Diffs
> -
> 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java
>  60edbcf 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java
>  d5f06f8 
> 
> Diff: https://reviews.apache.org/r/24111/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ritu  Sabharwal
> 
>

Re: Review Request 24111: Coverity findings for brocade-plugin

[Ritu Sabharwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24111/
---

(Updated July 31, 2014, 5:57 p.m.)


Review request for cloudstack and Hugo Trippaers.


Changes
---

Fixed the open issues.


Bugs: CLOUDSTACK-6823
https://issues.apache.org/jira/browse/CLOUDSTACK-6823


Repository: cloudstack-git


Description
---

Fixed Coverity findings for brocade-plugin


Diffs (updated)
-

  
plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java
 60edbcf 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java
 d5f06f8 

Diff: https://reviews.apache.org/r/24111/diff/


Testing
---


Thanks,

Ritu  Sabharwal

Re: Review Request 24111: Coverity findings for brocade-plugin

[Ritu Sabharwal]

> On July 31, 2014, 7:01 a.m., Santhosh Edukulla wrote:
> > plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java,
> >  line 482
> > <https://reviews.apache.org/r/24111/diff/1/?file=646144#file646144line482>
> >
> > This particular try\except  is  for an IO exception possible when 
> > closing a resource, so the message should have some reflection in it. But, 
> > when you use try-with-resource as mentioned in other issue, this is not 
> > required.

Fixed this also.


- Ritu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24111/#review49213
-------


On July 31, 2014, 5:57 p.m., Ritu  Sabharwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24111/
> ---
> 
> (Updated July 31, 2014, 5:57 p.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Bugs: CLOUDSTACK-6823
> https://issues.apache.org/jira/browse/CLOUDSTACK-6823
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixed Coverity findings for brocade-plugin
> 
> 
> Diffs
> -
> 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java
>  60edbcf 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java
>  d5f06f8 
> 
> Diff: https://reviews.apache.org/r/24111/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ritu  Sabharwal
> 
>

Re: Review Request 24111: Coverity findings for brocade-plugin

[Ritu Sabharwal]

> On Aug. 1, 2014, 5:57 a.m., Santhosh Edukulla wrote:
> > plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java,
> >  line 547
> > <https://reviews.apache.org/r/24111/diff/2/?file=646948#file646948line547>
> >
> > It seems there is no corresponding catch here, did compilation worked?

Hi Santhosh,

This log statement is not there in the latest patch that I submitted.

There is a throws clause in the method signature private String 
responseToErrorMessage(HttpResponse response) throws IOException  and the 
IOException is handled in the caller methods.

The compilation works fine.

Thanks,
Ritu S.


- Ritu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24111/#review49323
---


On July 31, 2014, 5:57 p.m., Ritu  Sabharwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24111/
> ---
> 
> (Updated July 31, 2014, 5:57 p.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Bugs: CLOUDSTACK-6823
> https://issues.apache.org/jira/browse/CLOUDSTACK-6823
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixed Coverity findings for brocade-plugin
> 
> 
> Diffs
> -
> 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java
>  60edbcf 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java
>  d5f06f8 
> 
> Diff: https://reviews.apache.org/r/24111/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ritu  Sabharwal
> 
>

RE: [Help] Help for setting up Vmware Cluster in CloudStack...

[Ritu Sabharwal]

Hi Ilya,

I am trying to do this vmware integration with Cloudstack again but seeing some 
issues. Need your help to move forward.

I followed the steps from the tutorial: 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+Advanced+Network+Tutorial+-+Step+by+Step

I imported the system template from the location  
http://cloudstack.apt-get.eu/systemvm/systemvm64template-2014-01-14-master-vmware.ova
 by running the command

/usr/share/cloudstack-common/scripts/storage/secondary/cloud-install-sys-tmplt 
-m /mnt/secondary -u systemvm64template-2014-01-14-master-vmware.ova -h vmware 
-F

Looks like the import did not happen successfully because the ova file created 
under /mnt/secondary/template/tmpl/1/8/ is of size 0.

I followed rest of the steps in the tutorial . All went fine, adding zone, pod, 
cluster, primary storage, secondary storage but the system vms (Secondary 
storage VM and Console Proxy VM)  are not deployed.

Now when I am trying to create a user VM, I don't see any templates available 
to create it.

Please help to unblock me with this setup.

Thanks & Regards,
Ritu S.

From: ilya musayev [mailto:ilya.mailing.li...@gmail.com]
Sent: Wednesday, July 09, 2014 10:53 PM
To: Ritu Sabharwal; Hugo Trippaers
Cc: dev@cloudstack.apache.org
Subject: Re: [Help] Help for setting up Vmware Cluster in CloudStack...

I'm in Sunnyvale. I've been trying to do a meetup and perhaps demo the whole 
vmware/cloudstack setup, but i never really got to do this.

Hopefully, we can put something together for July or early August timeframe for 
the meetup.

Also, Router VMs have 1 Management and 1 Guest IP - just realized i missed it.

If i can give you a suggestion in the meantime, try to get your setup working 
with stable 4.3. Once you figure the process out - which is really not that 
difficult in my opinion (should take 10-30 minutes at most - granted you have 
everything pre-set), then try it with master codebase, and only then master 
codebase and your patch.

You did not mention if you are using VLAN tagging btw. Not that it matters 
greatly, but consider using newer vSphere, you can download trials from VMware 
site, you can even do a nested setup and run many vSphere CloudStack 
environments for dev/qa - which is what i've been doing lately. You have 60 day 
trial, post that, you can reset the environment to be compliant with vmware 
licensing model - needless to say, this can be semi or completely automated, 
depends how much effort you want to put into this. I'd double check this with 
vmware rep to be on the safe side.


On 7/9/14, 5:36 PM, Ritu Sabharwal wrote:
Hi Ilya,

Thanks for your replies.

This is really helpful. We can surely get into some video conferencing and get 
this setup ready. I am in San Jose, CA.

Thanks & Regards,
Ritu S.

From: ilya musayev [mailto:ilya.mailing.li...@gmail.com]
Sent: Wednesday, July 09, 2014 12:58 PM
To: Ritu Sabharwal; Hugo Trippaers
Cc: dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>
Subject: Re: [Help] Help for setting up Vmware Cluster in CloudStack...

Ritu,

That tutorial is a bit old.

Let me try to answer them, i do have an alternative solution, perhaps we can 
get on the phone and do a webex session or something similar - this week is bad 
for me, i'm traveling, but next week, Thursday and beyond - my schedule is 
flexible. I assume you are on PST timezone somewhere in bay area.

Please see response inline to your inquiries.



On 7/8/14, 6:29 PM, Ritu Sabharwal wrote:


Hi Ilya,

I am trying to add VMWare DC for the first time in CloudStack management server 
and need help in doing so. I am trying to test the Brocade Network Plugin 
functionality. The Jira id is : 
https://issues.apache.org/jira/browse/CLOUDSTACK-6823

I am following the Tutorial: 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+Advanced+Network+Tutorial+-+Step+by+Step

My Network setup:


1.   2 ESXi hosts 4.1.0 hosts.

2.   vCenter 5.0

Network layout:

vSwitch0: For Management Network
vSwitch0: for Guest Network

vSwitch0 is assigned 1 Physical Nic. This Nic is connected to Brocade VDX 
switch.


My test includes:

 *   Create an isolated network; verify that the port-profile is created on the 
Brocade switch.
 *   Attach a VM to the network; verify that the VMs MAC address is associated 
with the port profile of the network on the Brocade switch.
 *   Add VMs to the same guest network but on different hosts and verify 
connectivity.
 *   Check the availability of the switch by using the CloudStack API: 
http://:8096/client/api?command=listHosts&type=L2Networking.
 This should list the switch with its availability status.
 *   Delete VMs for an isolated network; verify that the VMs MAC address is 
disassociated with the port profile of the network on the Brocade switch.
 *   Delete the isolated network; verify that the port-profile is deleted from 
the Brocade switch.

I have few questi

RE: [Help] Help for setting up Vmware Cluster in CloudStack...

[Ritu Sabharwal]

Hello CS developers,

I need help in setting up Vmware cluster in CloudStack.

Any help is appreciated!

Thanks & Regards,
Ritu S.

-Original Message-
From: Ritu Sabharwal [mailto:rsabh...@brocade.com] 
Sent: Friday, September 05, 2014 4:51 PM
To: ilya musayev
Cc: dev@cloudstack.apache.org; Adip Shetty
Subject: RE: [Help] Help for setting up Vmware Cluster in CloudStack...

Hi Ilya,

I am trying to do this vmware integration with Cloudstack again but seeing some 
issues. Need your help to move forward.

I followed the steps from the tutorial: 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+Advanced+Network+Tutorial+-+Step+by+Step

I imported the system template from the location  
http://cloudstack.apt-get.eu/systemvm/systemvm64template-2014-01-14-master-vmware.ova
 by running the command

/usr/share/cloudstack-common/scripts/storage/secondary/cloud-install-sys-tmplt 
-m /mnt/secondary -u systemvm64template-2014-01-14-master-vmware.ova -h vmware 
-F

Looks like the import did not happen successfully because the ova file created 
under /mnt/secondary/template/tmpl/1/8/ is of size 0.

I followed rest of the steps in the tutorial . All went fine, adding zone, pod, 
cluster, primary storage, secondary storage but the system vms (Secondary 
storage VM and Console Proxy VM)  are not deployed.

Now when I am trying to create a user VM, I don't see any templates available 
to create it.

Please help to unblock me with this setup.

Thanks & Regards,
Ritu S.

From: ilya musayev [mailto:ilya.mailing.li...@gmail.com]
Sent: Wednesday, July 09, 2014 10:53 PM
To: Ritu Sabharwal; Hugo Trippaers
Cc: dev@cloudstack.apache.org
Subject: Re: [Help] Help for setting up Vmware Cluster in CloudStack...

I'm in Sunnyvale. I've been trying to do a meetup and perhaps demo the whole 
vmware/cloudstack setup, but i never really got to do this.

Hopefully, we can put something together for July or early August timeframe for 
the meetup.

Also, Router VMs have 1 Management and 1 Guest IP - just realized i missed it.

If i can give you a suggestion in the meantime, try to get your setup working 
with stable 4.3. Once you figure the process out - which is really not that 
difficult in my opinion (should take 10-30 minutes at most - granted you have 
everything pre-set), then try it with master codebase, and only then master 
codebase and your patch.

You did not mention if you are using VLAN tagging btw. Not that it matters 
greatly, but consider using newer vSphere, you can download trials from VMware 
site, you can even do a nested setup and run many vSphere CloudStack 
environments for dev/qa - which is what i've been doing lately. You have 60 day 
trial, post that, you can reset the environment to be compliant with vmware 
licensing model - needless to say, this can be semi or completely automated, 
depends how much effort you want to put into this. I'd double check this with 
vmware rep to be on the safe side.


On 7/9/14, 5:36 PM, Ritu Sabharwal wrote:
Hi Ilya,

Thanks for your replies.

This is really helpful. We can surely get into some video conferencing and get 
this setup ready. I am in San Jose, CA.

Thanks & Regards,
Ritu S.

From: ilya musayev [mailto:ilya.mailing.li...@gmail.com]
Sent: Wednesday, July 09, 2014 12:58 PM
To: Ritu Sabharwal; Hugo Trippaers
Cc: dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>
Subject: Re: [Help] Help for setting up Vmware Cluster in CloudStack...

Ritu,

That tutorial is a bit old.

Let me try to answer them, i do have an alternative solution, perhaps we can 
get on the phone and do a webex session or something similar - this week is bad 
for me, i'm traveling, but next week, Thursday and beyond - my schedule is 
flexible. I assume you are on PST timezone somewhere in bay area.

Please see response inline to your inquiries.



On 7/8/14, 6:29 PM, Ritu Sabharwal wrote:


Hi Ilya,

I am trying to add VMWare DC for the first time in CloudStack management server 
and need help in doing so. I am trying to test the Brocade Network Plugin 
functionality. The Jira id is : 
https://issues.apache.org/jira/browse/CLOUDSTACK-6823

I am following the Tutorial: 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+Advanced+Network+Tutorial+-+Step+by+Step

My Network setup:


1.   2 ESXi hosts 4.1.0 hosts.

2.   vCenter 5.0

Network layout:

vSwitch0: For Management Network
vSwitch0: for Guest Network

vSwitch0 is assigned 1 Physical Nic. This Nic is connected to Brocade VDX 
switch.


My test includes:

 *   Create an isolated network; verify that the port-profile is created on the 
Brocade switch.
 *   Attach a VM to the network; verify that the VMs MAC address is associated 
with the port profile of the network on the Brocade switch.
 *   Add VMs to the same guest network but on different hosts and verify 
connectivity.
 *   Check the availability of the switch by using the CloudStack API:

RE: [Help] Help for setting up Vmware Cluster in CloudStack...

[Ritu Sabharwal]

Hi Rayees,

Can you please point me to the right system VM template for VMware. I am using 
the one from 
http://cloudstack.apt-get.eu/systemvm/systemvm64template-2014-01-14-master-vmware.ova
With this one, the import did not work correctly because the ova created under 
/mnt/secondary/template/tmpl/1/8/ is of size 0.

Thanks & Regards,
Ritu S.

-Original Message-
From: Amogh Vasekar [mailto:amogh.vase...@citrix.com] 
Sent: Thursday, September 11, 2014 11:53 AM
To: dev@cloudstack.apache.org; ilya musayev; Rayees Namathponnan
Cc: Adip Shetty
Subject: Re: [Help] Help for setting up Vmware Cluster in CloudStack...

Hi,

The management server logs will help.
Templates for launching user Vms won't be available until SSVM comes up and 
downloads them to the correct location.
You may want to confirm if you are using the right systemVM template for the 
(4.5?) build. 
Adding Rayees who may be able to point to the right systemVM template.

Thanks,
Amogh

On 9/11/14 11:25 AM, "Ritu Sabharwal"  wrote:

>Hello CS developers,
>
>I need help in setting up Vmware cluster in CloudStack.
>
>Any help is appreciated!
>
>Thanks & Regards,
>Ritu S.
>
>-Original Message-
>From: Ritu Sabharwal [mailto:rsabh...@brocade.com]
>Sent: Friday, September 05, 2014 4:51 PM
>To: ilya musayev
>Cc: dev@cloudstack.apache.org; Adip Shetty
>Subject: RE: [Help] Help for setting up Vmware Cluster in CloudStack...
>
>Hi Ilya,
>
>I am trying to do this vmware integration with Cloudstack again but 
>seeing some issues. Need your help to move forward.
>
>I followed the steps from the tutorial:
>https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+Advan
>ced
>+Network+Tutorial+-+Step+by+Step
>
>I imported the system template from the location 
>http://cloudstack.apt-get.eu/systemvm/systemvm64template-2014-01-14-mas
>ter
>-vmware.ova by running the command
>
>/usr/share/cloudstack-common/scripts/storage/secondary/cloud-install-sy
>s-t mplt -m /mnt/secondary -u 
>systemvm64template-2014-01-14-master-vmware.ova
>-h vmware -F
>
>Looks like the import did not happen successfully because the ova file 
>created under /mnt/secondary/template/tmpl/1/8/ is of size 0.
>
>I followed rest of the steps in the tutorial . All went fine, adding 
>zone, pod, cluster, primary storage, secondary storage but the system 
>vms (Secondary storage VM and Console Proxy VM)  are not deployed.
>
>Now when I am trying to create a user VM, I don't see any templates 
>available to create it.
>
>Please help to unblock me with this setup.
>
>Thanks & Regards,
>Ritu S.
>
>From: ilya musayev [mailto:ilya.mailing.li...@gmail.com]
>Sent: Wednesday, July 09, 2014 10:53 PM
>To: Ritu Sabharwal; Hugo Trippaers
>Cc: dev@cloudstack.apache.org
>Subject: Re: [Help] Help for setting up Vmware Cluster in CloudStack...
>
>I'm in Sunnyvale. I've been trying to do a meetup and perhaps demo the 
>whole vmware/cloudstack setup, but i never really got to do this.
>
>Hopefully, we can put something together for July or early August 
>timeframe for the meetup.
>
>Also, Router VMs have 1 Management and 1 Guest IP - just realized i 
>missed it.
>
>If i can give you a suggestion in the meantime, try to get your setup 
>working with stable 4.3. Once you figure the process out - which is 
>really not that difficult in my opinion (should take 10-30 minutes at 
>most - granted you have everything pre-set), then try it with master 
>codebase, and only then master codebase and your patch.
>
>You did not mention if you are using VLAN tagging btw. Not that it 
>matters greatly, but consider using newer vSphere, you can download 
>trials from VMware site, you can even do a nested setup and run many 
>vSphere CloudStack environments for dev/qa - which is what i've been 
>doing lately. You have 60 day trial, post that, you can reset the 
>environment to be compliant with vmware licensing model - needless to 
>say, this can be semi or completely automated, depends how much effort 
>you want to put into this. I'd double check this with vmware rep to be 
>on the safe side.
>
>
>On 7/9/14, 5:36 PM, Ritu Sabharwal wrote:
>Hi Ilya,
>
>Thanks for your replies.
>
>This is really helpful. We can surely get into some video conferencing 
>and get this setup ready. I am in San Jose, CA.
>
>Thanks & Regards,
>Ritu S.
>
>From: ilya musayev [mailto:ilya.mailing.li...@gmail.com]
>Sent: Wednesday, July 09, 2014 12:58 PM
>To: Ritu Sabharwal; Hugo Trippaers
>Cc: dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>
>Subject: Re: [Help] Help for setting up Vmware Cluster in CloudStack...
>
>Ritu,
>
>That tutorial is a bit old.
>
>

[VMWARE SETUP ERROR] Error seeing in brining up System VMs with Vmware setup with CS server

[Ritu Sabharwal]

Hi Sateesh, Koushik,

I am setting up Vmware Cluster with CS (master) and seeing errors. ilya was 
helping me for this setup and figured out this error.

The System VMs(Secondary Stogare VM and Console Proxy VM) are not coming up 
properly. The system vms are reconfiguring and destroying again and again in 
cycle.

I have used Vmware Vsphere 5.1 SDK for building CS.

The error logs give this error:

2014-09-16 16:11:01,619 WARN  [c.c.h.v.r.VmwareResource] 
(DirectAgent-8:ctx-8909215e 10.24.41.149, job-54/job-68, cmd: StartCommand) 
StartCommand failed due to Exception: java.lang.NullPointerException
Message: null

java.lang.NullPointerException
at 
com.cloud.hypervisor.vmware.resource.VmwareResource.postDiskConfigBeforeStart(VmwareResource.java:2094)
at 
com.cloud.hypervisor.vmware.resource.VmwareResource.execute(VmwareResource.java:1685)
at 
com.cloud.hypervisor.vmware.resource.VmwareResource.executeRequest(VmwareResource.java:448)
at 
com.cloud.agent.manager.DirectAgentAttache$Task.runInContext(DirectAgentAttache.java:294)
at 
org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
at 
org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46)
at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:744)

Please help to resolve this issue.

Thanks & Regards,
Ritu S.

RE: [VMWARE SETUP ERROR] Error seeing in brining up System VMs with Vmware setup with CS server

[Ritu Sabharwal]

Hi Mike,

I updated the master just now and tried the setup. I see the same error on same 
line number.

Thanks & Regards,
Ritu S.

-Original Message-
From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com] 
Sent: Tuesday, September 16, 2014 8:32 PM
To: dev@cloudstack.apache.org
Cc: ilya musayev; Koushik Das; Sateesh Chodapuneedi; Adip Shetty
Subject: Re: [VMWARE SETUP ERROR] Error seeing in brining up System VMs with 
Vmware setup with CS server

Can you tell us what commit SHA you are running under?

I just updated master and line 2094 in VmwareResource is the following:

String[] diskChain = diskInfo.getDiskChain();

The only candidate for a NullPointerException there is diskInfo; however, the 
previous line would have caught this as it looks like this:

assert (diskInfo != null);

That being the case, I'm curious what commit SHA you saw this on?

Thanks!

On Tue, Sep 16, 2014 at 5:22 PM, Ritu Sabharwal 
wrote:

> Hi Sateesh, Koushik,
>
> I am setting up Vmware Cluster with CS (master) and seeing errors. 
> ilya was helping me for this setup and figured out this error.
>
> The System VMs(Secondary Stogare VM and Console Proxy VM) are not 
> coming up properly. The system vms are reconfiguring and destroying 
> again and again in cycle.
>
> I have used Vmware Vsphere 5.1 SDK for building CS.
>
> The error logs give this error:
>
> 2014-09-16 16:11:01,619 WARN  [c.c.h.v.r.VmwareResource] 
> (DirectAgent-8:ctx-8909215e 10.24.41.149, job-54/job-68, cmd: 
> StartCommand) StartCommand failed due to Exception: 
> java.lang.NullPointerException
> Message: null
>
> java.lang.NullPointerException
> at
> com.cloud.hypervisor.vmware.resource.VmwareResource.postDiskConfigBeforeStart(VmwareResource.java:2094)
> at
> com.cloud.hypervisor.vmware.resource.VmwareResource.execute(VmwareResource.java:1685)
> at
> com.cloud.hypervisor.vmware.resource.VmwareResource.executeRequest(VmwareResource.java:448)
> at
> com.cloud.agent.manager.DirectAgentAttache$Task.runInContext(DirectAgentAttache.java:294)
> at
> org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
> at
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
> at
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
> at
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
> at
> org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:744)
>
> Please help to resolve this issue.
>
> Thanks & Regards,
> Ritu S.
>
>


--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
<http://solidfire.com/solution/overview/?video=play>*™*

RE: [VMWARE SETUP ERROR] Error seeing in brining up System VMs with Vmware setup with CS server

[Ritu Sabharwal]

Hi Mike,

Sure, it will help to see if you can reproduce the error.

I used the system vm template :  
http://cloudstack.apt-get.eu/systemvm/systemvm64template-2014-01-14-master-vmware.ova
 but http://jenkins.buildacloud.org/job/build-systemvm64-master/  is latest and 
OVA is to be used.


Thanks & Regards,
Ritu S.

-Original Message-
From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com] 
Sent: Wednesday, September 17, 2014 2:17 PM
To: dev@cloudstack.apache.org
Cc: ilya musayev; Koushik Das; Sateesh Chodapuneedi; Adip Shetty
Subject: Re: [VMWARE SETUP ERROR] Error seeing in brining up System VMs with 
Vmware setup with CS server

I can set up a VMware cluster hopefully later tonight and see if I can 
reproduce this.

Off hand I'm not sure why the "managed" logic would be causing this, though.

In your situation, "managed" should be false and the "standard" logic should 
run.

Is this where I can get the latest system template for VMware?

http://jenkins.buildacloud.org/job/build-systemvm64-master/

I see an OVA and a VMDK. Which one do I use for seeding secondary storage for 
VMware (it's been a while since I've used VMware a system template)?

Thanks!

On Wed, Sep 17, 2014 at 2:53 PM, Mike Tutkowski < mike.tutkow...@solidfire.com> 
wrote:

> You're right, Marcus. Now that I think about it, asserts are ignored 
> by default.
>
> On Wed, Sep 17, 2014 at 1:59 PM, Marcus  wrote:
>
>> Aren't asserts ignored by default? I think we had an issue with 
>> asserts in the past, and I believe at the time the default config had 
>> asserts disabled.
>>
>>
>> On Wed, Sep 17, 2014 at 1:35 PM, Ritu Sabharwal 
>> 
>> wrote:
>>
>> > Hi Mike,
>> >
>> > I updated the master just now and tried the setup. I see the same 
>> > error
>> on
>> > same line number.
>> >
>> > Thanks & Regards,
>> > Ritu S.
>> >
>> > -Original Message-
>> > From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
>> > Sent: Tuesday, September 16, 2014 8:32 PM
>> > To: dev@cloudstack.apache.org
>> > Cc: ilya musayev; Koushik Das; Sateesh Chodapuneedi; Adip Shetty
>> > Subject: Re: [VMWARE SETUP ERROR] Error seeing in brining up System 
>> > VMs with Vmware setup with CS server
>> >
>> > Can you tell us what commit SHA you are running under?
>> >
>> > I just updated master and line 2094 in VmwareResource is the following:
>> >
>> > String[] diskChain = diskInfo.getDiskChain();
>> >
>> > The only candidate for a NullPointerException there is diskInfo;
>> however,
>> > the previous line would have caught this as it looks like this:
>> >
>> > assert (diskInfo != null);
>> >
>> > That being the case, I'm curious what commit SHA you saw this on?
>> >
>> > Thanks!
>> >
>> > On Tue, Sep 16, 2014 at 5:22 PM, Ritu Sabharwal 
>> > 
>> > wrote:
>> >
>> > > Hi Sateesh, Koushik,
>> > >
>> > > I am setting up Vmware Cluster with CS (master) and seeing errors.
>> > > ilya was helping me for this setup and figured out this error.
>> > >
>> > > The System VMs(Secondary Stogare VM and Console Proxy VM) are not 
>> > > coming up properly. The system vms are reconfiguring and 
>> > > destroying again and again in cycle.
>> > >
>> > > I have used Vmware Vsphere 5.1 SDK for building CS.
>> > >
>> > > The error logs give this error:
>> > >
>> > > 2014-09-16 16:11:01,619 WARN  [c.c.h.v.r.VmwareResource] 
>> > > (DirectAgent-8:ctx-8909215e 10.24.41.149, job-54/job-68, cmd:
>> > > StartCommand) StartCommand failed due to Exception:
>> > > java.lang.NullPointerException
>> > > Message: null
>> > >
>> > > java.lang.NullPointerException
>> > > at
>> > >
>> >
>> com.cloud.hypervisor.vmware.resource.VmwareResource.postDiskConfigBef
>> oreStart(VmwareResource.java:2094)
>> > > at
>> > >
>> >
>> com.cloud.hypervisor.vmware.resource.VmwareResource.execute(VmwareRes
>> ource.java:1685)
>> > > at
>> > >
>> >
>> com.cloud.hypervisor.vmware.resource.VmwareResource.executeRequest(Vm
>> wareResource.java:448)
>> > > at
>> > >
>> >
>> com.cloud.agent.manager.DirectAgentAttache$Task.runInContext(DirectAg
>> entAttache.java:294)
>&

RE: [VMWARE SETUP ERROR] Error seeing in brining up System VMs with Vmware setup with CS server

[Ritu Sabharwal]

I have an external NFS server and it is mounted to /mnt/secondary on my CS 
server so seeding command I used is:

/usr/share/cloudstack-common/scripts/storage/secondary/cloud-install-sys-tmplt  
-m /mnt/secondary  -u 
http://cloudstack.apt-get.eu/systemvm/4.4/systemvm64template-4.4.0-6-vmware.ova
-h vmware -F

I guess, if the secondary storage is local, then /export/secondary should be 
fine.

Regards,
Ritu S.
-Original Message-
From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com] 
Sent: Thursday, September 18, 2014 2:34 PM
To: dev@cloudstack.apache.org
Cc: ilya musayev; Koushik Das; Sateesh Chodapuneedi; Adip Shetty
Subject: Re: [VMWARE SETUP ERROR] Error seeing in brining up System VMs with 
Vmware setup with CS server

The instructions to seed secondary storage for VMware look like this:

/usr/share/cloudstack-common/scripts/storage/secondary/cloud-install-sys-tmplt 
\ -m /mnt/secondary \ -u 
http://cloudstack.apt-get.eu/systemvm/4.4/systemvm64template-4.4.0-6-vmware.ova
\
-h vmware \
-s  \ -F

For -m, I have /export/secondary (not /mnt/secondary). I assume that's correct 
because that is, in fact, where my secondary storage system template is located 
for XenServer and that seems to work just fine.


On Thu, Sep 18, 2014 at 3:20 PM, Mike Tutkowski < mike.tutkow...@solidfire.com> 
wrote:

> I'm not getting far enough along in the process to repro (or not) the 
> problem.
>
> I do have a /mnt/sec folder (and I even made it 777).
>
> Any thoughts on this?
>
> WARN  [c.c.s.r.VmwareStorageProcessor] (DirectAgent-46:ctx-fdd23ec9 
> 192.168.129.71, job-95/job-123, cmd: CopyCommand) Exception: tar 
> --no-same-owner -xf /mnt/sec/template/tmpl/1/8//routing-8.ova
> java.io.IOException: Cannot run program "tar" (in directory
> "/mnt/sec/template/tmpl/1/8"): error=2, No such file or directory
> at java.lang.ProcessBuilder.start(ProcessBuilder.java:1041)
> at com.cloud.utils.script.Script.execute(Script.java:195)
> at com.cloud.utils.script.Script.execute(Script.java:163)
> at com.cloud.storage.res
>
> On Wed, Sep 17, 2014 at 2:53 PM, Mike Tutkowski < 
> mike.tutkow...@solidfire.com> wrote:
>
>> You're right, Marcus. Now that I think about it, asserts are ignored 
>> by default.
>>
>> On Wed, Sep 17, 2014 at 1:59 PM, Marcus  wrote:
>>
>>> Aren't asserts ignored by default? I think we had an issue with 
>>> asserts in the past, and I believe at the time the default config 
>>> had asserts disabled.
>>>
>>>
>>> On Wed, Sep 17, 2014 at 1:35 PM, Ritu Sabharwal 
>>> 
>>> wrote:
>>>
>>> > Hi Mike,
>>> >
>>> > I updated the master just now and tried the setup. I see the same
>>> error on
>>> > same line number.
>>> >
>>> > Thanks & Regards,
>>> > Ritu S.
>>> >
>>> > -Original Message-
>>> > From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
>>> > Sent: Tuesday, September 16, 2014 8:32 PM
>>> > To: dev@cloudstack.apache.org
>>> > Cc: ilya musayev; Koushik Das; Sateesh Chodapuneedi; Adip Shetty
>>> > Subject: Re: [VMWARE SETUP ERROR] Error seeing in brining up 
>>> > System VMs with Vmware setup with CS server
>>> >
>>> > Can you tell us what commit SHA you are running under?
>>> >
>>> > I just updated master and line 2094 in VmwareResource is the following:
>>> >
>>> > String[] diskChain = diskInfo.getDiskChain();
>>> >
>>> > The only candidate for a NullPointerException there is diskInfo;
>>> however,
>>> > the previous line would have caught this as it looks like this:
>>> >
>>> > assert (diskInfo != null);
>>> >
>>> > That being the case, I'm curious what commit SHA you saw this on?
>>> >
>>> > Thanks!
>>> >
>>> > On Tue, Sep 16, 2014 at 5:22 PM, Ritu Sabharwal 
>>> > 
>>> > wrote:
>>> >
>>> > > Hi Sateesh, Koushik,
>>> > >
>>> > > I am setting up Vmware Cluster with CS (master) and seeing errors.
>>> > > ilya was helping me for this setup and figured out this error.
>>> > >
>>> > > The System VMs(Secondary Stogare VM and Console Proxy VM) are 
>>> > > not coming up properly. The system vms are reconfiguring and 
>>> > > destroying again and again in cycle.
>>> > >
>>> > > I have used Vmware Vsphere 5.1 SDK for building CS.
>>> > >
>>> > >

RE: [VMWARE SETUP ERROR] Error seeing in brining up System VMs with Vmware setup with CS server

[Ritu Sabharwal]

quot;,
> > >>>> "");
> > >>>>
> > >>>>
> > >>>>  Map details = vol.getDetails();
> > >>>>
> > >>>> boolean isManaged = details != null &&
> > >>>> Boolean.parseBoolean(details.get(DiskTO.MANAGED));
> > >>>>
> > >>>>
> > >>>>  VirtualMachineDiskInfo diskInfo =
> > >>>>
> > >>>>
> > >>>> diskInfoBuilder.getDiskInfoByBackingFileBaseName(isManaged ?
> > >>>> new
> > >>>> DatastoreFile(volume.getPath()).getFileBaseName() :
> volume.getPath(),
> > >>>> dsName);
> > >>>>
> > >>>> On Thu, Sep 18, 2014 at 4:34 PM, Mike Tutkowski <
> > >>>> mike.tutkow...@solidfire.com> wrote:
> > >>>>
> > >>>>> I think I found the magic. :)
> > >>>>>
> > >>>>> sudo mount -t nfs 192.168.129.46:/export/secondary /mnt/sec
> > >>>>>
> > >>>>> If I mount /export/secondary to /mnt/sec (I did it in a bit of
> > >>>>> a roundabout way here), then the management server is happy.
> > >>>>>
> > >>>>> I think this is only VMware "thing" for the management server.
> > >>>>>
> > >>>>> Does anyone know if we document this?
> > >>>>>
> > >>>>> Thanks!
> > >>>>>
> > >>>>> On Thu, Sep 18, 2014 at 4:18 PM, Mike Tutkowski <
> > >>>>> mike.tutkow...@solidfire.com> wrote:
> > >>>>>
> > >>>>>> The instructions even say the following:
> > >>>>>>
> > >>>>>>  If your secondary storage mount point is not named
> /mnt/secondary,
> > >>>>>> substitute your own mount point name.
> > >>>>>>
> > >>>>>> On Thu, Sep 18, 2014 at 4:15 PM, Mike Tutkowski <
> > >>>>>> mike.tutkow...@solidfire.com> wrote:
> > >>>>>>
> > >>>>>>> Yeah, I've been through the instructions a couple times and
> > >>>>>>> don't see anything that indicates why it's having trouble
> > >>>>>>> with /mnt/sec
> > (it says
> > >>>>>>> /mnt/sec instead of /mnt/secondary in the log messages).
> > >>>>>>>
> > >>>>>>> On Thu, Sep 18, 2014 at 4:01 PM, Ritu Sabharwal <
> > >>>>>>> rsabh...@brocade.com> wrote:
> > >>>>>>>
> > >>>>>>>> I have an external NFS server and it is mounted to
> /mnt/secondary
> > >>>>>>>> on my CS server so seeding command I used is:
> > >>>>>>>>
> > >>>>>>>>
> >
> /usr/share/cloudstack-common/scripts/storage/secondary/cloud-install-s
> ys-tmplt
> > >>>>>>>> -m /mnt/secondary  -u
> > >>>>>>>>
> >
> http://cloudstack.apt-get.eu/systemvm/4.4/systemvm64template-4.4.0-6-v
> mware.ova
> > >>>>>>>> -h vmware -F
> > >>>>>>>>
> > >>>>>>>> I guess, if the secondary storage is local, then
> /export/secondary
> > >>>>>>>> should be fine.
> > >>>>>>>>
> > >>>>>>>> Regards,
> > >>>>>>>> Ritu S.
> > >>>>>>>> -Original Message-
> > >>>>>>>> From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
> > >>>>>>>>  Sent: Thursday, September 18, 2014 2:34 PM
> > >>>>>>>> To: dev@cloudstack.apache.org
> > >>>>>>>> Cc: ilya musayev; Koushik Das; Sateesh Chodapuneedi; Adip
> > >>>>>>>> Shetty
> > >>>>>>>> Subject: Re: [VMWARE SETUP ERROR] Error seeing in brining
> > >>>>>>>> up
> > System
> > >>>>>>>> VMs with Vmware setup with CS server
> > >>>>>>>>
> > >>>>>>>> The instructions to seed secondary storage for VMware look
> > >>>>>>>

RE: [VMWARE SETUP ERROR] Error seeing in brining up System VMs with Vmware setup with CS server

[Ritu Sabharwal]

t;>>>>
>> > >>>>>>>>>> Thank you Mike, please keep us posted.
>> > >>>>>>>>>>
>> > >>>>>>>>>> Regards
>> > >>>>>>>>>> ilya
>> > >>>>>>>>>>
>> > >>>>>>>>>> On 9/18/14, 4:14 PM, Mike Tutkowski wrote:
>> > >>>>>>>>>>
>> > >>>>>>>>>> Little clarification on this:
>> > >>>>>>>>>>
>> > >>>>>>>>>> "The dsName is derived from the UUID of the datastore."
>> > >>>>>>>>>>
>> > >>>>>>>>>> I mean that the dsName is derived from the UUID primary
>> > >>>>>>>>>> storage in
>> > >>>>>> the
>> > >>>>>>>>>> DB.
>> > >>>>>>>>>>
>> > >>>>>>>>>> On Thu, Sep 18, 2014 at 5:12 PM, Mike Tutkowski <
>> > >>>>>>>>>> mike.tutkow...@solidfire.com> wrote:
>> > >>>>>>>>>>
>> > >>>>>>>>>>> Just a little update on this:
>> > >>>>>>>>>>>
>> > >>>>>>>>>>> The problem doesn't seem to have anything to do with
>> "managed"
>> > >>>>>>>>>>> storage code that was introduced back in March.
>> > >>>>>>>>>>>
>> > >>>>>>>>>>> The dsName is derived from the UUID of the datastore.
>> > >>>>>>>>>>> This leads
>> > >>>>>> to a
>> > >>>>>>>>>>> null being returned from
>> > >>>>>>> diskInfoBuilder.getDiskInfoByBackingFileBaseName,
>> > >>>>>>>>>>> which subsequently leads to a null being returned from
>> > >>>>>>>>>>> this
>> > >> method
>> > >>>>>>> (and a
>> > >>>>>>>>>>> NullPointerException being thrown).
>> > >>>>>>>>>>>
>> > >>>>>>>>>>> I plan to take a look at the history of this file in gitk.
>> > >>>>>>>>>>>
>> > >>>>>>>>>>>  private VirtualMachineDiskInfo
>> > >>>>>>>>>>> getMatchingExistingDisk(VirtualMachineDiskInfoBuilder
>> > >>>>>> diskInfoBuilder,
>> > >>>>>>>>>>> DiskTO vol) {
>> > >>>>>>>>>>>
>> > >>>>>>>>>>>  if (diskInfoBuilder != null) {
>> > >>>>>>>>>>>
>> > >>>>>>>>>>>  VolumeObjectTO volume =
>> > >>>>>>>>>>> (VolumeObjectTO)vol.getData();
>> > >>>>>>>>>>>
>> > >>>>>>>>>>>  String dsName =
>> > >>>>>>> volume.getDataStore().getUuid().replace("-",
>> > >>>>>>>>>>> "");
>> > >>>>>>>>>>>
>> > >>>>>>>>>>>
>> > >>>>>>>>>>>   Map details =
>> > >>>>>>>>>>> vol.getDetails();
>> > >>>>>>>>>>>
>> > >>>>>>>>>>>  boolean isManaged = details != null &&
>> > >>>>>>>>>>> Boolean.parseBoolean(details.get(DiskTO.MANAGED));
>> > >>>>>>>>>>>
>> > >>>>>>>>>>>
>> > >>>>>>>>>>>   VirtualMachineDiskInfo diskInfo =
>> > >>>>>>>>>>>
>> > >>>>>>>>>>>
>> > >>>>>>>>>>> diskInfoBuilder.getDiskInfoByBackingFileBaseName(isManaged ?
>> > >>>>>>>>>>> new
>> > >>>&g

Help in Adding XenServer to CS Management Server

[Ritu Sabharwal]

Hi,

I am trying to add XenServer to the CS Management Server.

I could add the hosts and I see Host status as up on the GUI. But I don't see 
any System VMs coming up and Virtual Router coming up in the dashboard. When I 
try to create a User VM there is no template available to select.

I am blocked at this point.

I did seed Secondary Storage by importing system VM templat from 
http://jenkins.buildacloud.org/view/4.4/job/cloudstack-4.4-systemvm64/  for Xen 
(systemvm64template-4.4-2014-09-30-xen.vhd.bz2)

Any help on this is appreciated.

Thanks & Regards,
Ritu S.

RE: Help in Adding XenServer to CS Management Server

[Ritu Sabharwal]

Thanks Yitao and Pierre for replying!

I enabled the Zone and monitored the CS server logs. 

I did not configured the Secondary Storage earlier and did that.

After that I could see that Secondary Storage and Console Proxy VMs are 
starting and stopping again and again.

In the logs:

2014-10-16 09:21:59,395 WARN  [c.c.h.x.r.XenServerStorageProcessor] 
(DirectAgent-317:ctx-2212833f) can't mount 
10.24.41.132:/export/secondary/template/tmpl/1/1 to 
/var/run/cloud_mount/67fce140-25f9-480f-a08a-3b2746adf142
2014-10-16 09:21:59,395 WARN  [c.c.h.x.r.XenServerStorageProcessor] 
(DirectAgent-317:ctx-2212833f) Catch Exception 
com.cloud.utils.exception.CloudRuntimeException for template +  due to 
com.cloud.utils.exception.CloudRuntimeException: can't mount 
10.24.41.132:/export/secondary/template/tmpl/1/1 to 
/var/run/cloud_mount/67fce140-25f9-480f-a08a-3b2746adf142
com.cloud.utils.exception.CloudRuntimeException: can't mount 
10.24.41.132:/export/secondary/template/tmpl/1/1 to 
/var/run/cloud_mount/67fce140-25f9-480f-a08a-3b2746adf142
at 
com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.copy_vhd_from_secondarystorage(XenServerStorageProcessor.java:699)
at 
com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.copyTemplateToPrimaryStorage(XenServerStorageProcessor.java:815)
at 
com.cloud.storage.resource.StorageSubsystemCommandHandlerBase.execute(StorageSubsystemCommandHandlerBase.java:78)
at 
com.cloud.storage.resource.StorageSubsystemCommandHandlerBase.handleStorageCommands(StorageSubsystemCommandHandlerBase.java:53)

  

I also tried to manually mount the NF S share on XenServer on CLI and see this 
error.

[root@DCM-Xen-67 ~]# mount -t nfs 10.24.41.132:/export/secondary/template/1/1 
/mnt/secondary
mount: mount to NFS server '10.24.41.132' failed: RPC Error: Program not 
registered.

Looks like the NFS mount is not working on XenServer from NFS share.

How can I solve this issue? Any specific setting on the XenServer needed?

Thanks & Regards,
Ritu s.

-Original Message-
From: Pierre-Luc Dion [mailto:pdion...@apache.org] 
Sent: Wednesday, October 15, 2014 7:52 PM
To: dev@cloudstack.apache.org
Subject: Re: Help in Adding XenServer to CS Management Server

Ritu,
 You have to wait a little when creating a zone until you have the SSVM and 
CPVM ready. then it will automatically download a centos 5.6  which confirm 
your initial zone is working. if  this is not happening, there might be a 
config issue related to primary, secondary storage or network label.

hope this help,

PL


On Wed, Oct 15, 2014 at 9:08 PM, Yitao Jiang  wrote:

> 1.Check zone status, make sure enabled.
> 2.change mgmt server debug level, watch ing the log file in 
> /var/log/cloud/ On Oct 16, 2014 7:13 AM, "Ritu Sabharwal" 
>  wrote:
>
> > Hi,
> >
> > I am trying to add XenServer to the CS Management Server.
> >
> > I could add the hosts and I see Host status as up on the GUI. But I 
> > don't see any System VMs coming up and Virtual Router coming up in 
> > the
> dashboard.
> > When I try to create a User VM there is no template available to select.
> >
> > I am blocked at this point.
> >
> > I did seed Secondary Storage by importing system VM templat from 
> > http://jenkins.buildacloud.org/view/4.4/job/cloudstack-4.4-systemvm6
> > 4/ for Xen (systemvm64template-4.4-2014-09-30-xen.vhd.bz2<
> >
> http://jenkins.buildacloud.org/view/4.4/job/cloudstack-4.4-systemvm64/
> lastSuccessfulBuild/artifact/tools/appliance/dist/systemvm64template-4
> .4-2014-09-30-xen.vhd.bz2
> > >)
> >
> > Any help on this is appreciated.
> >
> > Thanks & Regards,
> > Ritu S.
> >
>

RE: Help in Adding XenServer to CS Management Server

[Ritu Sabharwal]

Hi,

I could move ahead with the issues and see the SSVM and CPVM coming up . But 
when I  try to create a user VM I still don't see the default template.

What could be the problem here? Any suggestions?

Thanks & Regards,
Ritu S.

-Original Message-
From: Pierre-Luc Dion [mailto:pdion...@apache.org] 
Sent: Wednesday, October 15, 2014 7:52 PM
To: dev@cloudstack.apache.org
Subject: Re: Help in Adding XenServer to CS Management Server

Ritu,
 You have to wait a little when creating a zone until you have the SSVM and 
CPVM ready. then it will automatically download a centos 5.6  which confirm 
your initial zone is working. if  this is not happening, there might be a 
config issue related to primary, secondary storage or network label.

hope this help,

PL


On Wed, Oct 15, 2014 at 9:08 PM, Yitao Jiang  wrote:

> 1.Check zone status, make sure enabled.
> 2.change mgmt server debug level, watch ing the log file in 
> /var/log/cloud/ On Oct 16, 2014 7:13 AM, "Ritu Sabharwal" 
>  wrote:
>
> > Hi,
> >
> > I am trying to add XenServer to the CS Management Server.
> >
> > I could add the hosts and I see Host status as up on the GUI. But I 
> > don't see any System VMs coming up and Virtual Router coming up in 
> > the
> dashboard.
> > When I try to create a User VM there is no template available to select.
> >
> > I am blocked at this point.
> >
> > I did seed Secondary Storage by importing system VM templat from 
> > http://jenkins.buildacloud.org/view/4.4/job/cloudstack-4.4-systemvm6
> > 4/ for Xen (systemvm64template-4.4-2014-09-30-xen.vhd.bz2<
> >
> http://jenkins.buildacloud.org/view/4.4/job/cloudstack-4.4-systemvm64/
> lastSuccessfulBuild/artifact/tools/appliance/dist/systemvm64template-4
> .4-2014-09-30-xen.vhd.bz2
> > >)
> >
> > Any help on this is appreciated.
> >
> > Thanks & Regards,
> > Ritu S.
> >
>