> On July 31, 2014, 7:01 a.m., Santhosh Edukulla wrote: > > plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java, > > line 482 > > <https://reviews.apache.org/r/24111/diff/1/?file=646144#file646144line482> > > > > This particular try\except is for an IO exception possible when > > closing a resource, so the message should have some reflection in it. But, > > when you use try-with-resource as mentioned in other issue, this is not > > required.
Fixed this also. - Ritu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24111/#review49213 ----------------------------------------------------------- On July 31, 2014, 5:57 p.m., Ritu Sabharwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24111/ > ----------------------------------------------------------- > > (Updated July 31, 2014, 5:57 p.m.) > > > Review request for cloudstack and Hugo Trippaers. > > > Bugs: CLOUDSTACK-6823 > https://issues.apache.org/jira/browse/CLOUDSTACK-6823 > > > Repository: cloudstack-git > > > Description > ------- > > Fixed Coverity findings for brocade-plugin > > > Diffs > ----- > > > plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java > 60edbcf > > plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java > d5f06f8 > > Diff: https://reviews.apache.org/r/24111/diff/ > > > Testing > ------- > > > Thanks, > > Ritu Sabharwal > >
