-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23314/
-----------------------------------------------------------
(Updated July 8, 2014, 6:49 p.m.)
Review request for cloudstack.
Changes
-------
Thanks for reviewing the code.
I have fixed the license in all the files.
I am working on writing the unit tests for the plugin.
I am working on providing the documentation on using the plugin.
I have tested the plugin with the simulator and see the configurations on
Brocade switches happening. Currently, I am setting up a real hardware setup
with Vmware hypervisor and Brocade switches so test the connectivity between
spawned VMs.
Can I continue writing the unit tests and marvin integration tests and
documentation after the July 19 date so that this plugin makes to 4.5 feature
freeze date.
I have updated the diffs with the changes for the license and other comments.
Bugs: CLOUDSTACK-6823
https://issues.apache.org/jira/browse/CLOUDSTACK-6823
Repository: cloudstack-git
Description
-------
Plugin specific code.
Diffs (updated)
-----
plugins/network-elements/brocade-vcs/pom.xml PRE-CREATION
plugins/network-elements/brocade-vcs/resources/BrocadeInterfaceSchema.xsd
PRE-CREATION
plugins/network-elements/brocade-vcs/resources/BrocadePortProfileSchema.xsd
PRE-CREATION
plugins/network-elements/brocade-vcs/resources/BrocadeShowVcsSchema.xsd
PRE-CREATION
plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/module.properties
PRE-CREATION
plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/spring-vcs-context.xml
PRE-CREATION
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkAnswer.java
PRE-CREATION
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkCommand.java
PRE-CREATION
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkAnswer.java
PRE-CREATION
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkCommand.java
PRE-CREATION
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkAnswer.java
PRE-CREATION
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkCommand.java
PRE-CREATION
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkAnswer.java
PRE-CREATION
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkCommand.java
PRE-CREATION
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/StartupBrocadeVcsCommand.java
PRE-CREATION
plugins/network-elements/brocade-vcs/src/com/cloud/network/BrocadeVcsNetworkHostMappingVO.java
PRE-CREATION
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java
PRE-CREATION
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApiException.java
PRE-CREATION
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/Cache.java
PRE-CREATION
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/CacheManager.java
PRE-CREATION
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/Constants.java
PRE-CREATION
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/Switch.java
PRE-CREATION
plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsNetworkHostMappingDao.java
PRE-CREATION
plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsNetworkHostMappingDaoImpl.java
PRE-CREATION
plugins/network-elements/brocade-vcs/src/com/cloud/network/element/BrocadeVcsElement.java
PRE-CREATION
plugins/network-elements/brocade-vcs/src/com/cloud/network/guru/BrocadeVcsGuestNetworkGuru.java
PRE-CREATION
plugins/network-elements/brocade-vcs/src/com/cloud/network/resource/BrocadeVcsResource.java
PRE-CREATION
Diff: https://reviews.apache.org/r/23314/diff/
Testing
-------
Thanks,
Ritu Sabharwal
