Hi Sebastian, I submitted the first code drop for plugin for review. Can you please create a new branch for Brocade plugin development.
Also, I wanted to know how do I select specific reviewers for reviewing the request. I did not see any option to choose that while submitting the request. Thanks & Regards, Ritu S. -----Original Message----- From: Ritu Sabharwal [mailto:nore...@reviews.apache.org] On Behalf Of Ritu Sabharwal Sent: Monday, June 23, 2014 10:49 AM To: Ritu Sabharwal; cloudstack Subject: Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22863/ ----------------------------------------------------------- (Updated June 23, 2014, 5:49 p.m.) Review request for cloudstack. Changes ------- Added a note requesting a new branch for Brocade plugin. Bugs: CLOUDSTACK-6823 https://issues.apache.org/jira/browse/CLOUDSTACK-6823 Repository: cloudstack-git Description (updated) ------- First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity. Please create a new branch for Brocade plugin. Diffs ----- api/src/com/cloud/network/Network.java b5e8173 api/src/com/cloud/network/Networks.java 3159f6e api/src/com/cloud/network/PhysicalNetwork.java 5d38b50 build/replace.properties 265f335 client/pom.xml 3995f6e plugins/pom.xml 4f7805a setup/db/create-schema.sql 55cb4cc ui/scripts/system.js 0c56baf utils/conf/db.properties e1b5fe9 Diff: https://reviews.apache.org/r/22863/diff/ Testing ------- • Create an isolated network; verify that the port-profile is created on the Brocade switch. • Attach a VM to the network; verify that the VMs MAC address is associated with the port profile of the network on the Brocade switch. • Delete VMs for an isolated network; verify that the VMs MAC address is disassociated with the port profile of the network on the Brocade switch. • Delete the isolated network; verify that the port-profile is deleted from the Brocade switch. File Attachments ---------------- Diff for the existing cloudstack code https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff Patch for the plugin code https://reviews.apache.org/media/uploaded/files/2014/06/23/fbb2b949-a42c-4b22-afa7-60e691c778df__brocade-vcs.patch Thanks, Ritu Sabharwal
