> On June 24, 2014, 6:40 a.m., Hugo Trippaers wrote: > > Hey, > > > > There are a number of issues with this patch, i've made the commments on > > the lines directly. Also where is the real functionality? The code in this > > patch seems to only be the hook into the existing cloudstack code and not > > the brocade code itself? > > > > Cheers, > > > > Hugo > > Ritu Sabharwal wrote: > Hi Hugo, > > I commented on the review comments directly. I included a patch file > brocade-vcs.patch which has Brocade code. > > I followed these steps to create the patch: > > -git add plugins/network-elements/brocade-vcs > -git commit -m "Commit message“ > -git format-patch master --stdout > ~/brocade-vcs.patch > > Is there any other way to include Brocade code in the diffs? Please let > me know. I will submit that for review. > > Thanks, > Ritu. > > > Hugo Trippaers wrote: > You can create a separate review request for the vcs code (and post a > link in this review) or create a single big patch with everything. I'm fine > with either option, but we need the patch in review board as that will help > us do the review properly. > > Thanks for fixing the other items. > > Cheers, > > Hugo
Hi Hugo, I have created another request for vcs specific code. Please find the link for the review request: https://reviews.apache.org/r/23314/ Hope this helps to review it properly. Thanks & Regards, Ritu S. - Ritu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22863/#review46498 ----------------------------------------------------------- On July 4, 2014, 9:35 a.m., Ritu Sabharwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22863/ > ----------------------------------------------------------- > > (Updated July 4, 2014, 9:35 a.m.) > > > Review request for cloudstack and Hugo Trippaers. > > > Bugs: CLOUDSTACK-6823 > https://issues.apache.org/jira/browse/CLOUDSTACK-6823 > > > Repository: cloudstack-git > > > Description > ------- > > First code drop for Brocade Network plugin to orchestrate Brocade VDX > switches for L2 connectivity. Please create a new branch for Brocade plugin. > > > Diffs > ----- > > api/src/com/cloud/network/Network.java 885bffe > api/src/com/cloud/network/Networks.java 1e4d229 > api/src/com/cloud/network/PhysicalNetwork.java 8cc214e > client/pom.xml 29fef4f > plugins/pom.xml b5e6a61 > setup/db/db/schema-440to450.sql 77445a9 > ui/scripts/system.js 9a98a5c > > Diff: https://reviews.apache.org/r/22863/diff/ > > > Testing > ------- > > • Create an isolated network; verify that the port-profile is created on > the Brocade switch. > • Attach a VM to the network; verify that the VMs MAC address is > associated with the port profile of the network on the Brocade switch. > • Delete VMs for an isolated network; verify that the VMs MAC address is > disassociated with the port profile of the network on the Brocade switch. > • Delete the isolated network; verify that the port-profile is deleted > from the Brocade switch. > > > File Attachments > ---------------- > > Diff for the existing cloudstack code > > https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff > Patch file for Brocade functionality code > > https://reviews.apache.org/media/uploaded/files/2014/06/26/92bb0014-a7b7-4f0b-97c9-018d615b658a__brocade-vcs.patch > > > Thanks, > > Ritu Sabharwal > >
