Re: Problem creating VirtualRouter on XenServer 6.2 due to problem with copy_vhd_from_secondarystorage.sh

2013-09-27 Thread Nitin Mehta
ListTemplateCommand() just reads the content present on secondary storage
through template.properties. How did you put the new template ? Was
template.properties and DB updated accordingly ?


On 27/09/13 11:30 AM, "Soheil Eizadi"  wrote:

>I traced this to a problem with ListTemplateCommand() that is returning
>what I assumed is a cached value
>10.48.15.22:/home/nfs/secondary/template/tmpl/1/1/34b74283-916e-4562-82fd-
>082b387b51c5.vhd, the new secondary storage has a new template now:
>template/tmpl/1/1/170c3425-6078-479e-8843-3f8fdc02aaf3.vhd.
>
>I am not sure at what stage this happened, and rather than debug this
>further, I just reinstalled it from scratch and fixed the issue.
>-Soheil
>
>From: Soheil Eizadi [seiz...@infoblox.com]
>Sent: Tuesday, September 24, 2013 6:10 PM
>To: dev@cloudstack.apache.org
>Subject: RE: Problem creating VirtualRouter on XenServer 6.2 due to
>problem with copy_vhd_from_secondarystorage.sh
>
>The error with copy_vhd_from_secondarystorage.sh is due to a problem with
>secondary storage, vhd_util returning a negative number to a query as the
>file does not exist. I am not sure why
>34b74283-916e-4562-82fd-082b387b51c5.vhd versus
>170c3425-6078-479e-8843-3f8fdc02aaf3.vhd is referenced, that is the next
>step to chase down.
>-Soheil
>
>[root@cloudstackxenserver1 bin]# ./vhd-util query -v -n
>10.48.15.22:/home/nfs/secondary/template/tmpl/1/1/34b74283-916e-4562-82fd-
>082b387b51c5.vhd
>error opening 
>10.48.15.22:/home/nfs/secondary/template/tmpl/1/1/34b74283-916e-4562-82fd-
>082b387b51c5.vhd: -2
>
>root@nfs-server-10-48-15-21:/opt/storage/secondary# find
>.
>./template
>./template/tmpl
>./template/tmpl/1
>./template/tmpl/1/1
>./template/tmpl/1/1/170c3425-6078-479e-8843-3f8fdc02aaf3.vhd
>./template/tmpl/1/1/template.properties
>./template/tmpl/1/5
>./template/tmpl/1/5/0911ae22-350f-38f5-ad3e-423e7e5d6539.vhd
>./template/tmpl/1/5/template.properties
>./template/tmpl/2
>./volumes
>./snapshots
>
>
>From: Soheil Eizadi [seiz...@infoblox.com]
>Sent: Tuesday, September 24, 2013 5:11 PM
>To: dev@cloudstack.apache.org
>Subject: Problem creating VirtualRouter on XenServer 6.2 due to problem
>with copy_vhd_from_secondarystorage.sh
>
>Environment:
>- 4.3 master (synced with master 08/28/2013 08:43 AM)
>- XenServer 6.2
>
>I have a problem creating a Virtual Router on XenServer 6.2, here are the
>symptoms, vmops.log and SMlog don't tell you much, but when I run the
>copy command native I get an error like the
>copy_vhd_from_secondarystorage.sh shell is not compatible with XenServer
>6.2. I cleared the XenServer host tag to make sure the latest scripts
>were downloaded from my build. If someone thinks this problem is fixed on
>the top of the trunk, I can do another pull, otherwise I guess I need
>chase this some more in my enviroment?
>-Soheil
>
>[root@cloudstackxenserver1 log]#
>/opt/xensource/bin/copy_vhd_from_secondarystorage.sh
>10.48.15.22:/home/nfs/secondary/template/tmpl/1/1/34b74283-916e-4562-82fd-
>082b387b51c5.vhd 1cca28ee-886a-6d52-5461-662b33f1d8d8
>cloud-0230b187-29c2-4060-826c-7f697cceea35
>Syntax error: Unknown switch: -22MiB
>For usage run: 'xe help'
>9#can not create vdi in sr 1cca28ee-886a-6d52-5461-662b33f1d8d8
>
>vmops.log:
>
>INFO  [o.a.c.n.e.InfobloxElement] (Job-Executor-5:ctx-e6414bc5)
>InfobloxDeviceElement Host Record created for VM r-9-VM
>WARN  [c.c.h.x.r.XenServerStorageProcessor] (DirectAgent-382:null)
>destoryVDIbyNameLabel failed due to there are 0 VDIs with name
>cloud-0230b187-29c2-4060-826c-7f697cceea35
>WARN  [c.c.h.x.r.XenServerStorageProcessor] (DirectAgent-382:null) can
>not create vdi in sr 1cca28ee-886a-6d52-5461-662b33f1d8d8
>.
>
>SMlog:
>Sep 24 16:39:41 cloudstackxenserver1 SM: [28919]  VMOPS enter
>copy_vhd_from_secondarystorage 
>Sep 24 16:39:41 cloudstackxenserver1 SM: [28919] ['bash',
>'/opt/xensource/bin/copy_vhd_from_secondarystorage.sh',
>'10.48.15.22:/home/nfs/secondary/template/tmpl/1/1/34b74283-916e-4562-82fd
>-082b387b51c5.vhd', '1cca28ee-886a-6d52-5461-662b33f1d8d8',
>'cloud-0230b187-29c2-4060-826c-7f697cceea35']
>Sep 24 16:39:41 cloudstackxenserver1 SM: [28919]   pread SUCCESS
>Sep 24 16:39:41 cloudstackxenserver1 SM: [28919]  VMOPS exit
>copy_vhd_from_secondarystorage 
>Sep 24 16:39:42 cloudstackxenserver1 SM: [28955]  VMOPS enter
>kill_copy_process 
>Sep 24 16:39:42 cloudstackxenserver1 SM: [28955] ['bash',
>'/opt/xensource/bin/kill_copy_process.sh',
>'34b74283-916e-4562-82fd-082b387b51c5.vhd']
>Sep 24 16:39:42 cloudstackxenserver1 SM: [28955]   pread SUCCESS
>Sep 24 16:39:42 cloudstackxenserver1 SM: [28955]  VMOPS exit
>kill_copy_process 



Re: Cloudstack doesn't seem to recognize we added 100GB of memory to the nodes.

2013-09-27 Thread Nitin Mehta
I guess you are referring to the same issue as discussed in the thread
http://www.mail-archive.com/dev@cloudstack.apache.org/msg15197.html


There is a bug created
https://issues.apache.org/jira/browse/CLOUDSTACK-4755
For this with the workaround.

On 27/09/13 1:48 PM, "Jeronimo Garcia"  wrote:

>Hi List.
>
>We've done some memory upgrades to our hosts but even tho we can see the
>new memory numbers and all that .. the cluster where this hosts belong to
>still showing full (in the dashboard).
>
>We've forced recalculation and still no luck.
>
>Do you guys happen to know what to do with this?
>
>Thanks



Re: Scaling up cpu and memory of user vm above host capacity

2013-10-01 Thread Nitin Mehta
Gaurav - Were you trying this on a stopped vm ? If you try and start it
with an offering
above the host capacity (including over provisioning ) then it shouldn't
start. Let me know how it goes.

More details on scale vm feature @
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Dynamic+scaling+of+C
PU+and+RAM 

On 01/10/13 12:02 AM, "Gaurav Aradhye"  wrote:

>Thanks David. That disabuses my confusion about the CPU provisioning. I
>was
>using the wrong API to scale up the virtual machine, so above observations
>stand invalid till I get the same results with the right API.
>
>About over-provisioning, I have the over provisioning factor set as 1 both
>in case of CPU and memory.
>
>Regards,
>Gaurav
>
>
>On Mon, Sep 30, 2013 at 10:55 PM, David Ortiz  wrote:
>
>> A machine won't be able to support more cores on a VM than the physical
>> processor.  That should result in problems trying to deploy it.  I'm
>> guessing the service offering is still valid since you could add a host
>> later which has a hex core or two cpus in it.  As far as RAM goes, do
>>you
>> have overprovisioning enabled?
>>
>> > From: gaurav.arad...@clogeny.com
>> > Date: Mon, 30 Sep 2013 14:00:04 +0530
>> > Subject: Scaling up cpu and memory of user vm above host capacity
>> > To: dev@cloudstack.apache.org
>> >
>> > Hi,
>> >
>> > I am trying to automate a scenario here. I have only one host in
>>cluster
>> > with 4 CPU cores and 15 GB total memory. When I try to scale up cpu
>>and
>> RAM
>> > of a running user vm above the host capacity, it doesn't throw any
>>error
>> > and I can see the updated values in VM statistics too.
>> >
>> > For CPU, I am able to change the service offering of user vm as  5
>>cores
>> *
>> > 100 MHz (even though host has 4 cores). I am not sure how this
>> calculation
>> > is done. Definitely many no. of virtual cores can be formed on host
>>(more
>> > than 4), but is it possible to allocate 5 cores to single VM ? When I
>>try
>> > to deploy new VM with 5 core CPU service offering, then in this case
>>it
>> > fails saying not enough server capacity.
>> >
>> > Also, For memory, I am able to create 17 GB memory service offering
>>and
>> > allocate it to any running user vm (although the total memory on host
>>is
>> 15
>> > GB).
>> >
>> > Any directions? Is this an issue or am I missing something here?
>> >
>> > Regards,
>> > Gaurav
>>
>>



Re: capacity of secondaey stor us eq 0. bug ir known ussue?

2013-10-03 Thread Nitin Mehta
This generally should happen because of management server not able to
communicate with the SSVM agent.
Could you run the ssvm health check script to see if the connection is
healthy btwn ssvm and CS ?

On 03/10/13 3:39 AM, "benoit lair"  wrote:

>Hello,
>
>I have the same issue with cs 4.2 installed from the cloudstack rpm
>repositories (the stable ones), found no way to get an ssvm operationnal.
>
>Thanks.
>
>
>2013/9/28 Netmaster 
>
>> Hallo,
>> we have several installation of cloudstack 4.2
>> In dashboard the capacity of secondary storage equal 0kb
>> We have standart nfs.
>> Api backed the same error, capacity of resource type 6 is 0
>> The secondary stor vm (system vm) shows normall capacity of 10tb,
>> as it have to be.
>> Is it bug or known issue?
>> Thanks



Re: Scaling up cpu and memory of user vm above host capacity

2013-10-04 Thread Nitin Mehta
changeServiceForVirtualMachine API was the old API to change the service
offering for a stopped vm only.
I think it shouldn't have succeeded for a running vm. Please file a bug if
this is the case

scaleVirtualMachine is the new API introduced in 4.2 for scaling a
running/stopped vm. Do read the link I pointed below when you get a chance.

Thanks,
-Nitin

On 03/10/13 11:50 PM, "Gaurav Aradhye"  wrote:

>Hi Nitin,
>
>I was trying on running vm only, but I was
>using changeServiceForVirtualMachine API instead of scaleVirtualMachine
>API.
>But I wonder why changeServiceForVirtualMachine API succeeded in
>allocating
>more than host capacity.
>
>What is the basic difference between these two operations?
>
>Regards,
>Gaurav
>
>
>On Tue, Oct 1, 2013 at 10:45 PM, Nitin Mehta 
>wrote:
>
>> Gaurav - Were you trying this on a stopped vm ? If you try and start it
>> with an offering
>> above the host capacity (including over provisioning ) then it shouldn't
>> start.  Let me know how it goes.
>>
>> More details on scale vm feature @
>> 
>>https://cwiki.apache.org/confluence/display/CLOUDSTACK/Dynamic+scaling+of
>>+C
>> PU+and+RAM
>>
>> On 01/10/13 12:02 AM, "Gaurav Aradhye" 
>>wrote:
>>
>> >Thanks David. That disabuses my confusion about the CPU provisioning. I
>> >was
>> >using the wrong API to scale up the virtual machine, so above
>>observations
>> >stand invalid till I get the same results with the right API.
>> >
>> >About over-provisioning, I have the over provisioning factor set as 1
>>both
>> >in case of CPU and memory.
>> >
>> >Regards,
>> >Gaurav
>> >
>> >
>> >On Mon, Sep 30, 2013 at 10:55 PM, David Ortiz 
>> wrote:
>> >
>> >> A machine won't be able to support more cores on a VM than the
>>physical
>> >> processor.  That should result in problems trying to deploy it.  I'm
>> >> guessing the service offering is still valid since you could add a
>>host
>> >> later which has a hex core or two cpus in it.  As far as RAM goes, do
>> >>you
>> >> have overprovisioning enabled?
>> >>
>> >> > From: gaurav.arad...@clogeny.com
>> >> > Date: Mon, 30 Sep 2013 14:00:04 +0530
>> >> > Subject: Scaling up cpu and memory of user vm above host capacity
>> >> > To: dev@cloudstack.apache.org
>> >> >
>> >> > Hi,
>> >> >
>> >> > I am trying to automate a scenario here. I have only one host in
>> >>cluster
>> >> > with 4 CPU cores and 15 GB total memory. When I try to scale up cpu
>> >>and
>> >> RAM
>> >> > of a running user vm above the host capacity, it doesn't throw any
>> >>error
>> >> > and I can see the updated values in VM statistics too.
>> >> >
>> >> > For CPU, I am able to change the service offering of user vm as  5
>> >>cores
>> >> *
>> >> > 100 MHz (even though host has 4 cores). I am not sure how this
>> >> calculation
>> >> > is done. Definitely many no. of virtual cores can be formed on host
>> >>(more
>> >> > than 4), but is it possible to allocate 5 cores to single VM ?
>>When I
>> >>try
>> >> > to deploy new VM with 5 core CPU service offering, then in this
>>case
>> >>it
>> >> > fails saying not enough server capacity.
>> >> >
>> >> > Also, For memory, I am able to create 17 GB memory service offering
>> >>and
>> >> > allocate it to any running user vm (although the total memory on
>>host
>> >>is
>> >> 15
>> >> > GB).
>> >> >
>> >> > Any directions? Is this an issue or am I missing something here?
>> >> >
>> >> > Regards,
>> >> > Gaurav
>> >>
>> >>
>>
>>



[SOLVED] Re: capacity of secondaey stor us eq 0. bug ir known ussue?

2013-10-04 Thread Nitin Mehta
That¹s great Benoit. You could have also found this out running the ssvm
health check script.
Thumb rule - In case of ssvm/secondary storage related issues first
troubleshooting step is to run ssvm health check script

On 04/10/13 1:37 AM, "benoit lair"  wrote:

>Hello,
>
>Issue resolved for me.
>
>In my case, my dashboard said me, i have 0kb of storage on my secondary
>storage.
>
>The reason was not due to the cs 4.2, but it was entirely my fault due to
>a
>misconfiguration :
>
>My ssvm was correctly deploying, but it can't communicate with my nfs
>server.
>
>The reason was because i misconfigured my storage traffic label for
>xenserver, so my storage traffic was routed on the bad nic on the
>hypervisor, so the storage vlan was not available et so the ssvm cloudn't
>ping to the nfs server.
>
>If the ssvm can't ping to the nfs server, it can't mount it, if can't
>mount, it does not recognize the right size of the nfs server volume, so
>0kb.
>
>So, if dashboard says secondary storage at 0kb, there is probably a
>network
>issue with my nfs server.
>
>
>Regards, Benoit.
>
>
>2013/10/4 Nitin Mehta 
>
>> This generally should happen because of management server not able to
>> communicate with the SSVM agent.
>> Could you run the ssvm health check script to see if the connection is
>> healthy btwn ssvm and CS ?
>>
>> On 03/10/13 3:39 AM, "benoit lair"  wrote:
>>
>> >Hello,
>> >
>> >I have the same issue with cs 4.2 installed from the cloudstack rpm
>> >repositories (the stable ones), found no way to get an ssvm
>>operationnal.
>> >
>> >Thanks.
>> >
>> >
>> >2013/9/28 Netmaster 
>> >
>> >> Hallo,
>> >> we have several installation of cloudstack 4.2
>> >> In dashboard the capacity of secondary storage equal 0kb
>> >> We have standart nfs.
>> >> Api backed the same error, capacity of resource type 6 is 0
>> >> The secondary stor vm (system vm) shows normall capacity of 10tb,
>> >> as it have to be.
>> >> Is it bug or known issue?
>> >> Thanks
>>



Re: XenServer Question

2013-10-04 Thread Nitin Mehta
What is your storage over provisioning factor ? Even that could be the
reason.
Regarding allocated vs used capacity I had written a wiki[1] sometime
back. Please see if it helps.

[1] 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Understanding+Dashbo
ard


Thanks,
-Nitin

On 04/10/13 8:08 AM, "benoit lair"  wrote:

>Effectively, it's very surprising.
>
>I checked my differents storage (local as iscsi sr) on xcp 1.0, xcp 1.1,
>xcp 1.4.90, xcp 1.6, xenserver 6.0 and xenserver 6.2, i observe that i can
>have a 'used' storage more important that the 'allocated' one
>
>I verified connected to my hypervisors shells and verified the data
>displayed in xencenter, the value 'used' is the good one.
>
>However, i can have allocated 200GB on my local SR to one vm (so it's
>provisionning). I can have 33GB 'used' on my local SR, but i have in
>reality less storage available into my vm.
>
>More clearly, if 200GB allocated on one vm, if xencenter says me 33GB are
>used, i can retrieve a vhd file corresponding to my vm of a size of 33GB,
>but when i'm connected to the vm's shell, i don't retrieve my 33gbs of
>storage.
>
>I observe the same phenomenon with my others xenserver hypervisors.
>
>It seems that some metadatas could be present into the vhd file + the real
>vm storage.
>
>
>
>Is there any citrix xenserver specialist in the room to confirm (or not)
>what i said ?
>
>
>Thanks.
>
>Regards, Benoit.
>
>
>2013/10/4 Mike Tutkowski 
>
>> Doh! I guess that would have been helpful info. :)
>>
>> It is in XenCenter. If you click on an SR and look at the General tab.
>>
>> http://i.imgur.com/z5F1Ct0.png
>>
>>
>> On Fri, Oct 4, 2013 at 4:34 AM, benoit lair 
>>wrote:
>>
>> > Hi Mike,
>> >
>> > Where do you see this information ? On the CS dashboard ? Or with
>> > xencenter, listing the sr with the windows gui ?
>> >
>> > Regards, Benoit.
>> >
>> >
>> > 2013/10/3 Mike Tutkowski 
>> >
>> > > Hi,
>> > >
>> > > On one of my SRs, I see the following information:
>> > >
>> > > 100.2 GB used of 200 GB total (100 GB allocated)
>> > >
>> > > Can someone explain how 'used' can be larger than 'allocated'?
>> > >
>> > > On storage systems I've worked on before, 'allocated' is generally
>> > > synonymous with 'reserved' or 'provisioned'. On these systems,
>>'used'
>> is
>> > > always less than or equal to 'allocated'. Typically 'used' is less
>>than
>> > > 'allocated' because as 'used' approaches 'allocated', 'allocated' is
>> > > expanded (until it runs into 'total').
>> > >
>> > > Thanks!
>> > >
>> > > --
>> > > *Mike Tutkowski*
>> > > *Senior CloudStack Developer, SolidFire Inc.*
>> > > e: mike.tutkow...@solidfire.com
>> > > o: 303.746.7302
>> > > Advancing the way the world uses the
>> > > cloud
>> > > **
>> > >
>> >
>>
>>
>>
>> --
>> *Mike Tutkowski*
>> *Senior CloudStack Developer, SolidFire Inc.*
>> e: mike.tutkow...@solidfire.com
>> o: 303.746.7302
>> Advancing the way the world uses the
>> cloud
>> **
>>



Re: Review Request 14076: New test added for template copy feature

2013-10-06 Thread Nitin Mehta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14076/#review26713
---



test/integration/component/test_templates.py
<https://reviews.apache.org/r/14076/#comment52028>

there should be source zone id as well



test/integration/component/test_templates.py
<https://reviews.apache.org/r/14076/#comment52029>

Is this a blocking call ? Have you tested this ? Does it return success



test/integration/component/test_templates.py
<https://reviews.apache.org/r/14076/#comment52035>

Why are these assertions required when we repeat them in the loop ?



test/integration/component/test_templates.py
<https://reviews.apache.org/r/14076/#comment52031>

change the comment



test/integration/component/test_templates.py
<https://reviews.apache.org/r/14076/#comment52032>

Change this comment...this confused me...
Say something like "check template downloaded by polling, then delete it 
finally"



test/integration/component/test_templates.py
<https://reviews.apache.org/r/14076/#comment52034>

timeout is generally is not a count...what is the value typically u will 
keep ? 




test/integration/component/test_templates.py
<https://reviews.apache.org/r/14076/#comment52033>

    how long will the sleep will be for ? 


- Nitin Mehta


On Sept. 18, 2013, 2:29 p.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14076/
> ---
> 
> (Updated Sept. 18, 2013, 2:29 p.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar, Harikrishna Patnala, and 
> Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Added one missing test for test_templates.py from old QA repo to Cloudstack   
>   
> 
> def test_02_copy_template
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_templates.py e4599d4 
> 
> Diff: https://reviews.apache.org/r/14076/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>



Re: Review Request 14199: Adding missing test cases: Snapshots Improvement

2013-10-07 Thread Nitin Mehta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14199/#review26715
---



test/integration/component/test_snapshots_improvement.py
<https://reviews.apache.org/r/14199/#comment52037>

Do check the state of the snapshot as well.



test/integration/component/test_snapshots_improvement.py
<https://reviews.apache.org/r/14199/#comment52045>

step 6 is happening before step 5


- Nitin Mehta


On Sept. 18, 2013, 11:25 a.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14199/
> ---
> 
> (Updated Sept. 18, 2013, 11:25 a.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Adding 5 missing test cases.
> Change in asyncJobMgr.py >> the method "make_request" in cloudstackConnection 
> does not exist now. Replaced it by "marvin_request". Checked running async 
> jobs with this change. Works correctly.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_snapshots_improvement.py PRE-CREATION 
>   tools/marvin/marvin/asyncJobMgr.py 25818a6 
> 
> Diff: https://reviews.apache.org/r/14199/diff/
> 
> 
> Testing
> ---
> 
> Tested locally.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>



Re: Review Request 14199: Adding missing test cases: Snapshots Improvement

2013-10-07 Thread Nitin Mehta


> On Oct. 7, 2013, 5:18 p.m., Nitin Mehta wrote:
> >

It would be great if you could show logs of a sample run. Please also let me 
know if all the 5 cases are tested as well


- Nitin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14199/#review26715
---


On Sept. 18, 2013, 11:25 a.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14199/
> ---
> 
> (Updated Sept. 18, 2013, 11:25 a.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Adding 5 missing test cases.
> Change in asyncJobMgr.py >> the method "make_request" in cloudstackConnection 
> does not exist now. Replaced it by "marvin_request". Checked running async 
> jobs with this change. Works correctly.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_snapshots_improvement.py PRE-CREATION 
>   tools/marvin/marvin/asyncJobMgr.py 25818a6 
> 
> Diff: https://reviews.apache.org/r/14199/diff/
> 
> 
> Testing
> ---
> 
> Tested locally.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>



Re: questions about registerIso API and updateIsoPermissions API

2013-10-08 Thread Nitin Mehta
Answers inline.

From: Jessica Wang mailto:jessica.w...@citrix.com>>
Date: Tuesday 8 October 2013 5:10 PM
To: "mailto:dev@cloudstack.apache.org>>" 
mailto:dev@cloudstack.apache.org>>
Cc: Alena Prokharchyk 
mailto:alena.prokharc...@citrix.com>>, Nitin 
Mehta mailto:nitin.me...@citrix.com>>, Shweta Agarwal 
mailto:shweta.agar...@citrix.com>>
Subject: questions about registerIso API and updateIsoPermissions API

Hi,

I have questions about registerIso API and updateIsoPermissions API.

(1) A normal user is allowed to specify isextractable property when registering 
an ISO (through registerIso API),
but NOT allowed to update isextractable property when updating an ISO (through 
updateIsoPermissions API).
Is this by design or it's just an API bug?

Nitin>> This is a grey area. This was done for templates (Isos just inherited 
it) because derived templates may or may not belong to the same user and we 
want to follow the principle of least privilege.
At the moment, I think that for Isos we should allow to edit it so would call 
it an API bug.

(2) A normal user is NOT allowed to specify isfeatured property when 
registering an ISO (through registerIso API),
but allowed to update isfeatured property when updating an ISO (through 
updateIsoPermissions API)?
Is this by design or it's just an API bug?

Nitin>> Register Iso does provide an option to mark an ISO featured. I see that 
in the latest master.

Jessica


Re: questions about registerIso API and updateIsoPermissions API

2013-10-09 Thread Nitin Mehta
I think (1) is the right way to go.

From: Jessica Wang mailto:jessica.w...@citrix.com>>
Date: Wednesday 9 October 2013 12:47 PM
To: Nitin Mehta mailto:nitin.me...@citrix.com>>, 
"mailto:dev@cloudstack.apache.org>>" 
mailto:dev@cloudstack.apache.org>>, Alena 
Prokharchyk mailto:alena.prokharc...@citrix.com>>
Cc: Shweta Agarwal mailto:shweta.agar...@citrix.com>>
Subject: RE: questions about registerIso API and updateIsoPermissions API

Currently, at API level, a normal user is not allowed to specify “isfeatured” 
when registering ISO (API will ignore “isfeatured” parameter when a normal user 
passes it),
but a normal user is allowed to specify “isfeatured” when updating ISO.

Should we fix API to:
(1) allow a normal user to specify “isfeatured” when registering ISO (API won’t 
ignore “isfeatured” parameter when a normal user passes it)

OR

(2) disallow a normal user to specify “isfeatured” when updating ISO

?


p.s. I’ll do corresponding UI change after API is fixed.


From: Jessica Wang
Sent: Wednesday, October 09, 2013 11:01 AM
To: Nitin Mehta; mailto:dev@cloudstack.apache.org>>
Cc: Alena Prokharchyk; Shweta Agarwal
Subject: RE: questions about registerIso API and updateIsoPermissions API

Nitin,

>  At the moment, I think that for Isos we should allow to edit it so would 
> call it an API bug.
Thanks.

> Register Iso does provide an option to mark an ISO featured. I see that in 
> the latest master.
That only works for admin, but NOT normal user.

If you log in as a normal user, then pass “isfeatured=true” to registerIso API, 
API will ignore it.
The newly registered template will have “isfeatured: false”.

e.g.
http://10.215.3.26:8080/client/api?command=registerIso&response=json&sessionkey=u%2FVIHPJuPohidGKFd0lh6csG%2BfM%3D&name=normalUserIso1&displayText=normalUserIso1&url=http%3A%2F%2F10.223.110.231%2Fisos_64bit%2Fdummy.iso&zoneid=6bcd3bd9-591c-4d99-a164-d05b87df1b04&isfeatured=true&isextractable=false&bootable=true&osTypeId=b8cbfd6c-2d40-11e3-86aa-3c970e739c3e&ispublic=false&_=1381340961641
{
"registerisoresponse": {
"count": 1,
"iso": [
{
"id": "9b903876-f17c-4634-8463-8e3025259956",
"name": "normalUserIso1",
"displaytext": "normalUserIso1",
"ispublic": false,
"created": "2013-10-09T10:52:38-0700",
"isready": false,
"bootable": true,
"isfeatured": false,
"crossZones": false,
"ostypeid": "b8cbfd6c-2d40-11e3-86aa-3c970e739c3e",
"ostypename": "Apple Mac OS X 10.6 (32-bit)",
"account": "aaa_user",
"zoneid": "6bcd3bd9-591c-4d99-a164-d05b87df1b04",
"zonename": "jw-adv",
"status": "",
"domain": "aaa",
"domainid": "47b09d73-84ef-48dc-9b73-1720bad600cb",
"isextractable": false,
"tags": []
}
]
}
}

Jessica

From: Nitin Mehta
Sent: Tuesday, October 08, 2013 5:27 PM
To: Jessica Wang; mailto:dev@cloudstack.apache.org>>
Cc: Alena Prokharchyk; Shweta Agarwal
Subject: Re: questions about registerIso API and updateIsoPermissions API

Answers inline.

From: Jessica Wang mailto:jessica.w...@citrix.com>>
Date: Tuesday 8 October 2013 5:10 PM
To: "mailto:dev@cloudstack.apache.org>>" 
mailto:dev@cloudstack.apache.org>>
Cc: Alena Prokharchyk 
mailto:alena.prokharc...@citrix.com>>, Nitin 
Mehta mailto:nitin.me...@citrix.com>>, Shweta Agarwal 
mailto:shweta.agar...@citrix.com>>
Subject: questions about registerIso API and updateIsoPermissions API

Hi,

I have questions about registerIso API and updateIsoPermissions API.

(1) A normal user is allowed to specify isextractable property when registering 
an ISO (through registerIso API),
but NOT allowed to update isextractable property when updating an ISO (through 
updateIsoPermissions API).
Is this by design or it's just an API bug?

Nitin>> This is a grey area. This was done for templates (Isos just inherited 
it) because derived templates may or may not belong to the same user and we 
want to follow the principle of least privilege.
At the moment, I think that for Isos we should allow to edit it so would call 
it an API bug.

(2) A normal user is NOT allowed to specify isfeatured property when 
registering an ISO (through registerIso API),
but allowed to update isfeatured property when updating an ISO (through 
updateIsoPermissions API)?
Is this by design or it's just an API bug?

Nitin>> Register Iso does provide an option to mark an ISO featured. I see that 
in the latest master.

Jessica


Re: Review Request 14076: New test added for template copy feature

2013-10-09 Thread Nitin Mehta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14076/#review26851
---

Ship it!


Ship It!

- Nitin Mehta


On Oct. 8, 2013, 1:45 p.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14076/
> ---
> 
> (Updated Oct. 8, 2013, 1:45 p.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar, Harikrishna Patnala, and 
> Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Added one missing test for test_templates.py from old QA repo to Cloudstack   
>   
> 
> def test_02_copy_template
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_templates.py ea4b277 
>   tools/marvin/marvin/integration/lib/base.py 0d52224 
> 
> Diff: https://reviews.apache.org/r/14076/diff/
> 
> 
> Testing
> ---
> 
> Run log:
> ==> client.log <==
> 2013-10-08 00:23:44,306 - DEBUG - test_02_copy_template 
> (test_templates_fixed.TestTemplates) - Copying template from zone: 
> 79ed0a9e-469c-460d-b674-0a2
> to 10c91f7e-06ed-47e4-a1fd-26d9102e9d6f
> 
> ==> result.log <==
> skipped 'Skip'
> test_01_create_template_volume (test_templates_fixed.TestTemplates)
> Test Create template from volume ... skipped 'Skip'
> test_02_copy_template (test_templates_fixed.TestTemplates)
> Test for copy template from one zone to another ... ok
> test_03_delete_template (test_templates_fixed.TestTemplates)
> Test Delete template ... skipped 'Skip'
> test_04_template_from_snapshot (test_templates_fixed.TestTemplates)
> Create Template from snapshot ... skipped 'Skip'
> 
> --
> Ran 5 tests in 567.935s
> 
> OK (skipped=4)
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>



Re: Review Request 14076: New test added for template copy feature

2013-10-09 Thread Nitin Mehta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14076/#review26852
---

Ship it!


Ship It!

- Nitin Mehta


On Oct. 8, 2013, 1:45 p.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14076/
> ---
> 
> (Updated Oct. 8, 2013, 1:45 p.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar, Harikrishna Patnala, and 
> Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Added one missing test for test_templates.py from old QA repo to Cloudstack   
>   
> 
> def test_02_copy_template
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_templates.py ea4b277 
>   tools/marvin/marvin/integration/lib/base.py 0d52224 
> 
> Diff: https://reviews.apache.org/r/14076/diff/
> 
> 
> Testing
> ---
> 
> Run log:
> ==> client.log <==
> 2013-10-08 00:23:44,306 - DEBUG - test_02_copy_template 
> (test_templates_fixed.TestTemplates) - Copying template from zone: 
> 79ed0a9e-469c-460d-b674-0a2
> to 10c91f7e-06ed-47e4-a1fd-26d9102e9d6f
> 
> ==> result.log <==
> skipped 'Skip'
> test_01_create_template_volume (test_templates_fixed.TestTemplates)
> Test Create template from volume ... skipped 'Skip'
> test_02_copy_template (test_templates_fixed.TestTemplates)
> Test for copy template from one zone to another ... ok
> test_03_delete_template (test_templates_fixed.TestTemplates)
> Test Delete template ... skipped 'Skip'
> test_04_template_from_snapshot (test_templates_fixed.TestTemplates)
> Create Template from snapshot ... skipped 'Skip'
> 
> --
> Ran 5 tests in 567.935s
> 
> OK (skipped=4)
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>



Re: Review Request 14076: New test added for template copy feature

2013-10-09 Thread Nitin Mehta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14076/#review26854
---


Can you give me a bug number to submit this test against ? 

- Nitin Mehta


On Oct. 8, 2013, 1:45 p.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14076/
> ---
> 
> (Updated Oct. 8, 2013, 1:45 p.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar, Harikrishna Patnala, and 
> Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Added one missing test for test_templates.py from old QA repo to Cloudstack   
>   
> 
> def test_02_copy_template
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_templates.py ea4b277 
>   tools/marvin/marvin/integration/lib/base.py 0d52224 
> 
> Diff: https://reviews.apache.org/r/14076/diff/
> 
> 
> Testing
> ---
> 
> Run log:
> ==> client.log <==
> 2013-10-08 00:23:44,306 - DEBUG - test_02_copy_template 
> (test_templates_fixed.TestTemplates) - Copying template from zone: 
> 79ed0a9e-469c-460d-b674-0a2
> to 10c91f7e-06ed-47e4-a1fd-26d9102e9d6f
> 
> ==> result.log <==
> skipped 'Skip'
> test_01_create_template_volume (test_templates_fixed.TestTemplates)
> Test Create template from volume ... skipped 'Skip'
> test_02_copy_template (test_templates_fixed.TestTemplates)
> Test for copy template from one zone to another ... ok
> test_03_delete_template (test_templates_fixed.TestTemplates)
> Test Delete template ... skipped 'Skip'
> test_04_template_from_snapshot (test_templates_fixed.TestTemplates)
> Create Template from snapshot ... skipped 'Skip'
> 
> --
> Ran 5 tests in 567.935s
> 
> OK (skipped=4)
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>



Re: Global setting "host" is not set to MS IP anymore on master

2013-10-10 Thread Nitin Mehta
If my memory serves me right this was fixed in 4.2. Maybe the fixer forgot
to port it to master ?

On 10/10/13 2:46 PM, "Min Chen"  wrote:

>Hi there,
>
>Not sure if others experience the same issue. In 4.2, when MS starts, it
>will discover the IP address of MS and automatically set global setting
>"host" to that IP address. Now it seems broken on master, MS started but
>"host" is still set to "localhost", which caused my system vm cannot ping
>back MS and thus no agent status cannot be found for system vm, thus this
>message on my console
>"INFO  [o.a.c.s.e.DefaultEndPointSelector] (StatsCollector-3:null) No
>running ssvm is found, so command will be sent to LocalHostEndPoint".
>Anybody has any idea on this?
>
>Thanks
>-min



Re: Why Secondarystroage resourcelimit contains volumes

2013-10-11 Thread Nitin Mehta
One of the use case where volume is on secondary storage is for the
uploaded volumes. 
Until they are attached to the vm they reside on secondary storage and
hence should be counted for secondary storage usage.

On 11/10/13 1:15 AM, "sx chen"  wrote:

>Hi,all:
>In 4.2,We can limit the secondarystorage usage for a user or a domain.
>But when I refer to source code ,I find
>
>public long calculateSecondaryStorageForAccount(long accountId) {
>long totalVolumesSize =
>_volumeDao.secondaryStorageUsedForAccount(accountId);
>long totalSnapshotsSize =
>_snapshotDao.secondaryStorageUsedForAccount(accountId);
>long totalTemplatesSize = 0;
>
>SearchCriteria sc = templateSizeSearch.create();
>sc.setParameters("downloadState", Status.DOWNLOADED);
>sc.setParameters("destroyed", false);
>sc.setJoinParameters("templates", "accountId", accountId);
>List templates = _vmTemplateStoreDao.customSearch(sc,
>null);
>if (templates != null) {
>totalTemplatesSize = templates.get(0).sum;
>}
>
>return totalVolumesSize + totalSnapshotsSize + totalTemplatesSize;
>}
>
>Templates and snapshots are certainly belong to secondarystorage,
>The volumes which sql is :
>select sum(size) from volumes where account_id=? and path is null and
>removed is null and state not in ("ALLOCATED").
>
>So my question is why volumes is counted as secondarystorage?



Re: Why Secondarystroage resourcelimit contains volumes

2013-10-12 Thread Nitin Mehta
No, once attach volume is called for uploaded volumes they are moved into
primary storage and then on they should be counted for primary storage
only, and not for sec. storage.
If that¹s not happening I would think that¹s a bug. Please do let us know.

On 11/10/13 6:31 PM, "sx chen"  wrote:

>Thanks,Nitin
>For Upload volume It's OK.
>Then I have another question;
>If I destroy a vm,the root disk will be romoved too,but data disk is still
>on the primary storage,
>and state is not "Allocated",So these volumes will be counted as
>secondarystorage and they
>are actually in the primary storage?
>
>
>2013/10/12 Nitin Mehta 
>
>> One of the use case where volume is on secondary storage is for the
>> uploaded volumes.
>> Until they are attached to the vm they reside on secondary storage and
>> hence should be counted for secondary storage usage.
>>
>> On 11/10/13 1:15 AM, "sx chen"  wrote:
>>
>> >Hi,all:
>> >In 4.2,We can limit the secondarystorage usage for a user or a
>>domain.
>> >But when I refer to source code ,I find
>> >
>> >public long calculateSecondaryStorageForAccount(long accountId) {
>> >long totalVolumesSize =
>> >_volumeDao.secondaryStorageUsedForAccount(accountId);
>> >long totalSnapshotsSize =
>> >_snapshotDao.secondaryStorageUsedForAccount(accountId);
>> >long totalTemplatesSize = 0;
>> >
>> >SearchCriteria sc = templateSizeSearch.create();
>> >sc.setParameters("downloadState", Status.DOWNLOADED);
>> >sc.setParameters("destroyed", false);
>> >sc.setJoinParameters("templates", "accountId", accountId);
>> >List templates = _vmTemplateStoreDao.customSearch(sc,
>> >null);
>> >if (templates != null) {
>> >totalTemplatesSize = templates.get(0).sum;
>> >}
>> >
>> >return totalVolumesSize + totalSnapshotsSize +
>>totalTemplatesSize;
>> >}
>> >
>> >Templates and snapshots are certainly belong to secondarystorage,
>> >The volumes which sql is :
>> >select sum(size) from volumes where account_id=? and path is null and
>> >removed is null and state not in ("ALLOCATED").
>> >
>> >So my question is why volumes is counted as secondarystorage?
>>
>>



Re: XenServer Memory Increase Problem

2013-10-16 Thread Nitin Mehta
Soheil - I guess this is a bug that addition of new memory isn't detected.
File it if not already done.
I would suggest you to change the DB as of now. Right tables are host and
op_host_capacity (capacity_type=0).
You might have to keep in mind the over provisioning factors you have
kept. See if changing it works.


On 16/10/13 11:56 AM, "Soheil Eizadi"  wrote:

>I am running on CloudStack Master 4.3.
>
>I had a use case where my XenServer ran out of memory and I could not
>create any more instances on CloudStack.
>I shutdown the XenServer and increased the memory on XenServer and
>brought up the Management Server again, but the Management Server still
>sees the old values. How is this suppose to work?
>
>As a workaround I assume I could find the database entry for the old RAM
>value and update with the new Memory Total.
>
>Here is some more detailed logs:
>
>The stats for the XenServer from CloudStack:
>
>Total CPU   2 x 2.67 GHz
>CPU Utilized0.08%
>CPU Allocated for VMs   0%
>Memory Total7.03 GB
>Memory Allocated2.50 GB
>Memory Used 3.60 MB
>Network Read558.23 MB
>Network Write   23.20 MB
>
>
>The log of memory problem:
>WARN  [o.a.c.alerts] (Job-Executor-5:ctx-3b5b1c95)  alertType:: 8 //
>dataCenterId:: 1 // podId:: null // clusterId:: null // message:: Failed
>to deploy Vm with Id: 27, on Host wi
>th Id: null
>INFO  [o.a.c.a.c.u.v.DeployVMCmd] (Job-Executor-5:ctx-3b5b1c95)
>com.cloud.exception.InsufficientServerCapacityException: Unable to create
>a deployment for VM[User|test-2]Scope=in
>terface com.cloud.dc.DataCenter; id=1
>INFO  [o.a.c.a.c.u.v.DeployVMCmd] (Job-Executor-5:ctx-3b5b1c95) Unable to
>create a deployment for VM[User|test-2]
>com.cloud.exception.InsufficientServerCapacityException: Unable to create
>a deployment for VM[User|test-2]Scope=interface com.cloud.dc.DataCenter;
>id=1
>at 
>org.apache.cloudstack.engine.cloud.entity.api.VMEntityManagerImpl.reserveV
>irtualMachine(VMEntityManagerImpl.java:210)
>at 
>org.apache.cloudstack.engine.cloud.entity.api.VirtualMachineEntityImpl.res
>erve(VirtualMachineEntityImpl.java:198)
>at 
>com.cloud.vm.UserVmManagerImpl.startVirtualMachine(UserVmManagerImpl.java:
>3372)
>at 
>com.cloud.vm.UserVmManagerImpl.startVirtualMachine(UserVmManagerImpl.java:
>2954)
>at 
>com.cloud.vm.UserVmManagerImpl.startVirtualMachine(UserVmManagerImpl.java:
>2940)
>at 
>com.cloud.utils.component.ComponentInstantiationPostProcessor$InterceptorD
>ispatcher.intercept(ComponentInstantiationPostProcessor.java:125)
>at 
>org.apache.cloudstack.api.command.user.vm.DeployVMCmd.execute(DeployVMCmd.
>java:421)
>at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:161)
>at 
>com.cloud.api.ApiAsyncJobDispatcher.runJob(ApiAsyncJobDispatcher.java:97)
>at 
>org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$1.run(AsyncJ
>obManagerImpl.java:526)
>at 
>java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
>at 
>java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
>at java.util.concurrent.FutureTask.run(FutureTask.java:166)
>at 
>java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:
>1110)
>at 
>java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java
>:603)
>at java.lang.Thread.run(Thread.java:679)
>INFO  [o.a.c.f.j.i.AsyncJobMonitor] (Job-Executor-5:null) Remove job-62
>from job monitoring
>



Re: [ANNOUNCE] New PMC member: Animesh Chaturvedi

2013-10-21 Thread Nitin Mehta

Congrats Animesh.

On 21/10/13 12:51 PM, "La Motta, David"  wrote:

>Awesome! Congrats, Animesh.
>
>
>David La Motta
>Technical Marketing Engineer - Citrix Solutions | NetApp
>Direct: 1.919.476.5042
>
>
>
>On 10/21/13 3:01 PM, "Chip Childers"  wrote:
>
>>The Project Management Committee (PMC) for Apache CloudStack has asked
>>Animesh Chaturvedi to join the PMC and we are pleased to announce that
>>they
>>have accepted.
>>
>>Join me in congratulating Animesh!
>>
>>-The CloudStack PMC
>



Re: issues with storage capacity on mgmt restart

2013-10-22 Thread Nitin Mehta
Hi Darren,
Please find my reply inline.

On 22/10/13 12:47 AM, "Darren Shepherd" 
wrote:

>I've noticed that when I bring up my mgmt server theres a period of
>time in which the storage capacity numbers are wrong.  When the mgmt
>server starts I deploy a VM and it fails because the below message
>indicates storage is at 124% used
>
>Checking pool 2 for storage, totalSize: 33808039936, usedBytes:
>41965518848, usedPct: 1.24128813523181, disable threshold: 0.85
>
>After waiting a minute or so and deploying a VM it will work and print
>the following.
>
>Checking pool 2 for storage, totalSize: 33808039936, usedBytes:
>4969705472, usedPct: 0.14699774022415543, disable threshold: 0.85
>
>Notice the used bytes drastically decreased.  So I debugged this and
>got to this strange code in
>StorageManagerImpl.checkUsageSpace(StoragePool pool)
>
>StorageStats stats = sc.getStoragePoolStats(pool.getId());
>if (stats == null) {
>stats = sc.getStorageStats(pool.getId());
>}
>
>So it looks for stats for the storage pool, and if it doesn't find it
>it calls getStorageStats().  But I believe getStorageStats() is for
>secondary.  So what is happening is that my primary and secondary
>storage happen to have the same IDs.  So when the primary storage
>stats haven't been cached its getting the secondary storage stats
>which are wrong.  So something needs to change here.

You are right. This seems to be a bug. It should be calling
getStoragePoolStats instead of getStorageStats. That should fix it.

>
>Darren



Re: haPlanners error in fresh 4.2 checkout

2013-10-28 Thread Nitin Mehta
Probably cleaning up you workspace might help.

On 28/10/13 10:51 AM, "Prachi Damle"  wrote:

>I had encountered this sometime back ... you need to check if your
>componentContext.xml or its equivalent has following defined. However I
>do see it is present in the 4.2 branch
>
>  
>   
> 
> 
> 
>   
> 
>
>-Original Message-
>From: sebgoa [mailto:run...@gmail.com]
>Sent: Monday, October 28, 2013 6:43 AM
>To: dev@cloudstack.apache.org
>Subject: haPlanners error in fresh 4.2 checkout
>
>Hi,
>
>I just checked out the latest from 4.2 and I get this:
>
>INFO  [factory.annotation.AutowiredAnnotationBeanPostProcessor] (main:)
>JSR-330 'javax.inject.Inject' annotation found and supported for
>autowiring INFO  
>[factory.annotation.AutowiredAnnotationBeanPostProcessor] (main:) JSR-330
>'javax.inject.Inject' annotation found and supported for autowiring INFO
>[factory.annotation.AutowiredAnnotationBeanPostProcessor] (main:) JSR-330
>'javax.inject.Inject' annotation found and supported for autowiring
>2013-10-28 14:41:36.018:INFO::Started SelectChannelConnector@0.0.0.0:8080
>[INFO] Started Jetty Server
>Exception in thread "Timer-2"
>org.springframework.beans.factory.BeanExpressionException: Expression
>parsing failed; nested exception is
>org.springframework.expression.spel.SpelEvaluationException: EL1008E:(pos
>0): Field or property 'haPlanners' cannot be found on object of type
>'org.springframework.beans.factory.config.BeanExpressionContext'
>   at 
>org.springframework.context.expression.StandardBeanExpressionResolver.eval
>uate(StandardBeanExpressionResolver.java:142)
>   at 
>org.springframework.beans.factory.support.AbstractBeanFactory.evaluateBean
>DefinitionString(AbstractBeanFactory.java:1299)
>   at 
>org.springframework.beans.factory.support.BeanDefinitionValueResolver.eval
>uate(BeanDefinitionValueResolver.java:210)
>   at 
>org.springframework.beans.factory.support.BeanDefinitionValueResolver.reso
>lveValueIfNecessary(BeanDefinitionValueResolver.java:182)
>   at 
>org.springframework.beans.factory.support.AbstractAutowireCapableBeanFacto
>ry.applyPropertyValues(AbstractAutowireCapableBeanFactory.java:1360)
>   at 
>org.springframework.beans.factory.support.AbstractAutowireCapableBeanFacto
>ry.populateBean(AbstractAutowireCapableBeanFactory.java:1118)
>   at 
>org.springframework.beans.factory.support.AbstractAutowireCapableBeanFacto
>ry.configureBean(AbstractAutowireCapableBeanFactory.java:314)
>   at 
>com.cloud.utils.component.ComponentContext.initComponentsLifeCycle(Compone
>ntContext.java:71)
>   at 
>com.cloud.servlet.CloudStartupServlet$1.run(CloudStartupServlet.java:54)
>   at java.util.TimerThread.mainLoop(Timer.java:555)
>   at java.util.TimerThread.run(Timer.java:505)
>Caused by: org.springframework.expression.spel.SpelEvaluationException:
>EL1008E:(pos 0): Field or property 'haPlanners' cannot be found on object
>of type 'org.springframework.beans.factory.config.BeanExpressionContext'
>   at 
>org.springframework.expression.spel.ast.PropertyOrFieldReference.readPrope
>rty(PropertyOrFieldReference.java:208)
>   at 
>org.springframework.expression.spel.ast.PropertyOrFieldReference.getValueI
>nternal(PropertyOrFieldReference.java:72)
>   at 
>org.springframework.expression.spel.ast.CompoundExpression.getValueInterna
>l(CompoundExpression.java:52)
>   at 
>org.springframework.expression.spel.ast.SpelNodeImpl.getValue(SpelNodeImpl
>.java:93)
>   at 
>org.springframework.expression.spel.standard.SpelExpression.getValue(SpelE
>xpression.java:88)
>   at 
>org.springframework.context.expression.StandardBeanExpressionResolver.eval
>uate(StandardBeanExpressionResolver.java:139)
>   ... 10 more
>
>
>Any thoughts ?
>
>-sebastien



Re: Wiki access

2013-10-28 Thread Nitin Mehta
Please grant me edit access.
Email - nitin.me...@citrix.com

On 28/10/13 5:17 AM, "Gaurav Aradhye"  wrote:

>Hi,
>
>My username is gauravaradhye.
>Can anyone grant me edit permission?
>
>I need to update test plan automation columns.
>
>
>Regards,
>Gaurav
>
>
>On Fri, Oct 18, 2013 at 5:26 PM, Kishan Kavala
>wrote:
>
>> Thanks Hugo.
>>
>> > -Original Message-
>> > From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers
>> > Sent: Friday, 18 October 2013 4:39 PM
>> > To: dev@cloudstack.apache.org
>> > Subject: Re: Wiki access
>> >
>> > Hey Kishan,
>> >
>> > I've granted you permissions. There apparently is another Kishan with
>> edit
>> > permission as well, so i got confused.
>> >
>> > Cheers,
>> >
>> > Hugo
>> >
>> > On 18 okt. 2013, at 12:38, Kishan Kavala 
>> wrote:
>> >
>> > > Hugo,
>> > > I've checked again. My account doesn't have edit permission.
>> > >
>> > >> -Original Message-
>> > >> From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo
>>Trippaers
>> > >> Sent: Wednesday, 16 October 2013 7:59 PM
>> > >> To: dev@cloudstack.apache.org
>> > >> Subject: Re: Wiki access
>> > >>
>> > >> Kishan,
>> > >>
>> > >> look like you have the permissions already on account kishan. Can
>>you
>> check?
>> > >>
>> > >> Cheers,
>> > >>
>> > >> Hugo
>> > >>
>> > >>
>> > >> On Oct 16, 2013, at 3:45 PM, Kishan Kavala
>>
>> > wrote:
>> > >>
>> > >>> Please grant me edit access.
>> > >>> Email: kis...@cloud.com
>> > >>>
>> > >>> ~kishan
>> > >>>
>> >  -Original Message-
>> >  From: Radhika Puthiyetath [mailto:radhika.puthiyet...@citrix.com]
>> >  Sent: Wednesday, 16 October 2013 3:22 PM
>> >  To: dev@cloudstack.apache.org
>> >  Subject: RE: Wiki access
>> > 
>> >  Hi,
>> > 
>> >  I do not have the edit permissions. My username is radhikap.
>> > 
>> >  Kindly provide me with the necessary permissions.
>> > 
>> >  Thanks
>> >  -Radhika
>> > 
>> >  -Original Message-
>> >  From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
>> >  Sent: Friday, October 04, 2013 3:26 PM
>> >  To: dev
>> >  Subject: Re: Wiki access
>> > 
>> >  anshulg is in
>> > 
>> > 
>> >  On Fri, Oct 4, 2013 at 11:51 AM, Anshul Gangwar
>> >  wrote:
>> > 
>> > > need edit permissions , username: anshulg
>> > >
>> > > Regards,
>> > > Anshul
>> > >
>> > > On Friday 04 October 2013 02:47 PM, Saksham Srivastava wrote:
>> > >> Please provide me edit permissions, username: saksham
>> > >>
>> > >> Regards,
>> > >> Saksham
>> > >>
>> > >> -Original Message-
>> > >> From: Chiradeep Vittal [mailto:chiradeep.vit...@citrix.com]
>> > >> Sent: Friday, October 04, 2013 10:46 AM
>> > >> To: dev@cloudstack.apache.org
>> > >> Subject: Re: Wiki access
>> > >>
>> > >> Mike, Tuna, Srinivas, Go, done.
>> > >>
>> > >> On 10/3/13 9:12 PM, "Mike Tutkowski"
>> > >> 
>> > > wrote:
>> > >>
>> > >>> I seem to need edit access, as well.
>> > >>>
>> > >>> I'm usually logged in by default, but I believe my username is
>> > >>> mike-tutkowski (else please try mtutkowski).
>> > >>>
>> > >>> Thanks!
>> > >>>
>> > >>>
>> > >>> On Thu, Oct 3, 2013 at 7:07 PM, Go Chiba 
>> > wrote:
>> > >>>
>> >  Hi Chip,
>> > 
>> >  Please grant me to edit pages. My id is "gochiba".
>> > 
>> > 
>> >  On Thu, Oct 3, 2013 at 6:01 AM, Chip Childers
>> >  > > > wrote:
>> > > Not all committers were easy to find, but those that I did
>> > > should be
>> >  all
>> > > set.
>> > >
>> > > So committers / contributors = provide your confluence ID's
>>if
>> > > you
>> >  can't
>> > > add / edit pages.  PMC folks - help add them please.
>> > >
>> > >
>> > > On Wed, Oct 2, 2013 at 4:48 PM, Chip Childers
>> >  > > >> wrote:
>> > >> There were major issues with Spam on the wiki, so infra
>> > >> changed the permissions.
>> > >>
>> > >> I've just gone and added all PMC members to the space as
>> > >> space
>> >  admins.
>> > >> That means all PMC members can help deal with this issue
>>(or
>> > >> at
>> >  least
>> > >> those that I could find in the wiki user list).
>> > >>
>> > >> I'm going to deal with committers next.  That permission
>> > >> level
>> >  needs to
>> > >> exclude space admin.  I'm using alena1108 as the example
>>for
>> >  committer
>> >  /
>> > >> contributor permissions.
>> > >>
>> > >> So if you are not a committer, give your confluence ID in
>> > >> this
>> >  thread
>> >  and
>> > >> PMC folks can help get them added (make them look like
>> > >>>

Re: listVolumes pool id

2013-10-29 Thread Nitin Mehta
I guess it should be fine. Adding a parameter shouldn't break the
compatibility and if it does then it should be corrected from the client
side.

On 29/10/13 7:21 AM, "Marcus Sorensen"  wrote:

>I almost can't believe this doesn't already exist, but I noticed that
>listing a volume doesn't show you the id of the storage pool the
>volume belongs to. It shows the pool name, but it seems that doesn't
>have to be unique.  Does anyone have a problem with me adding that to
>the listVolumes response?  Are there any tests that might fail due to
>hardcoded response expectations?



Re: haPlanners error in fresh 4.2 checkout

2013-10-29 Thread Nitin Mehta
Yeah, that should have cleaned the workspace. Did you see what Prachi
recommended below ?

On 29/10/13 2:02 AM, "sebgoa"  wrote:

>
>On Oct 28, 2013, at 7:14 PM, Nitin Mehta  wrote:
>
>> Probably cleaning up you workspace might help.
>
>Dummy question of the day then, how do I do that ?
>I did compile with `mvn clean install`
>
>
>> 
>> On 28/10/13 10:51 AM, "Prachi Damle"  wrote:
>> 
>>> I had encountered this sometime back ... you need to check if your
>>> componentContext.xml or its equivalent has following defined. However I
>>> do see it is present in the 4.2 branch
>>> 
>>> 
>>>  
>>>
>>>
>>>
>>>  
>>> 
>>> 
>>> -Original Message-
>>> From: sebgoa [mailto:run...@gmail.com]
>>> Sent: Monday, October 28, 2013 6:43 AM
>>> To: dev@cloudstack.apache.org
>>> Subject: haPlanners error in fresh 4.2 checkout
>>> 
>>> Hi,
>>> 
>>> I just checked out the latest from 4.2 and I get this:
>>> 
>>> INFO  [factory.annotation.AutowiredAnnotationBeanPostProcessor] (main:)
>>> JSR-330 'javax.inject.Inject' annotation found and supported for
>>> autowiring INFO
>>> [factory.annotation.AutowiredAnnotationBeanPostProcessor] (main:)
>>>JSR-330
>>> 'javax.inject.Inject' annotation found and supported for autowiring
>>>INFO
>>> [factory.annotation.AutowiredAnnotationBeanPostProcessor] (main:)
>>>JSR-330
>>> 'javax.inject.Inject' annotation found and supported for autowiring
>>> 2013-10-28 14:41:36.018:INFO::Started
>>>SelectChannelConnector@0.0.0.0:8080
>>> [INFO] Started Jetty Server
>>> Exception in thread "Timer-2"
>>> org.springframework.beans.factory.BeanExpressionException: Expression
>>> parsing failed; nested exception is
>>> org.springframework.expression.spel.SpelEvaluationException:
>>>EL1008E:(pos
>>> 0): Field or property 'haPlanners' cannot be found on object of type
>>> 'org.springframework.beans.factory.config.BeanExpressionContext'
>>> at 
>>> 
>>>org.springframework.context.expression.StandardBeanExpressionResolver.ev
>>>al
>>> uate(StandardBeanExpressionResolver.java:142)
>>> at 
>>> 
>>>org.springframework.beans.factory.support.AbstractBeanFactory.evaluateBe
>>>an
>>> DefinitionString(AbstractBeanFactory.java:1299)
>>> at 
>>> 
>>>org.springframework.beans.factory.support.BeanDefinitionValueResolver.ev
>>>al
>>> uate(BeanDefinitionValueResolver.java:210)
>>> at 
>>> 
>>>org.springframework.beans.factory.support.BeanDefinitionValueResolver.re
>>>so
>>> lveValueIfNecessary(BeanDefinitionValueResolver.java:182)
>>> at 
>>> 
>>>org.springframework.beans.factory.support.AbstractAutowireCapableBeanFac
>>>to
>>> ry.applyPropertyValues(AbstractAutowireCapableBeanFactory.java:1360)
>>> at 
>>> 
>>>org.springframework.beans.factory.support.AbstractAutowireCapableBeanFac
>>>to
>>> ry.populateBean(AbstractAutowireCapableBeanFactory.java:1118)
>>> at 
>>> 
>>>org.springframework.beans.factory.support.AbstractAutowireCapableBeanFac
>>>to
>>> ry.configureBean(AbstractAutowireCapableBeanFactory.java:314)
>>> at 
>>> 
>>>com.cloud.utils.component.ComponentContext.initComponentsLifeCycle(Compo
>>>ne
>>> ntContext.java:71)
>>> at 
>>> 
>>>com.cloud.servlet.CloudStartupServlet$1.run(CloudStartupServlet.java:54)
>>> at java.util.TimerThread.mainLoop(Timer.java:555)
>>> at java.util.TimerThread.run(Timer.java:505)
>>> Caused by: org.springframework.expression.spel.SpelEvaluationException:
>>> EL1008E:(pos 0): Field or property 'haPlanners' cannot be found on
>>>object
>>> of type 
>>>'org.springframework.beans.factory.config.BeanExpressionContext'
>>> at 
>>> 
>>>org.springframework.expression.spel.ast.PropertyOrFieldReference.readPro
>>>pe
>>> rty(PropertyOrFieldReference.java:208)
>>> at 
>>> 
>>>org.springframework.expression.spel.ast.PropertyOrFieldReference.getValu
>>>eI
>>> nternal(PropertyOrFieldReference.java:72)
>>> at 
>>> 
>>>org.springframework.expression.spel.ast.CompoundExpression.getValueInter
>>>na
>>> l(CompoundExpression.java:52)
>>> at 
>>> 
>>>org.springframework.expression.spel.ast.SpelNodeImpl.getValue(SpelNodeIm
>>>pl
>>> .java:93)
>>> at 
>>> 
>>>org.springframework.expression.spel.standard.SpelExpression.getValue(Spe
>>>lE
>>> xpression.java:88)
>>> at 
>>> 
>>>org.springframework.context.expression.StandardBeanExpressionResolver.ev
>>>al
>>> uate(StandardBeanExpressionResolver.java:139)
>>> ... 10 more
>>> 
>>> 
>>> Any thoughts ?
>>> 
>>> -sebastien
>> 
>



Router requires upgrade. Unable to send command to router Error

2013-11-07 Thread Nitin Mehta
Unable to deploy vms in the latest master because of the commit below. Is 
anyone noticing this on the latest master.
I checked the code  and there was a commit made recently 3f5b8f which is where 
the exception points to.

WARN  [o.a.c.alerts] (CapacityChecker:ctx-4f1ef01f)  alertType:: 2 // 
dataCenterId:: 3 // podId:: 3 // clusterId:: null // message:: System Alert: 
Low Available Storage in cluster c3 pod p of availability zone z3
INFO  [o.a.c.f.j.i.AsyncJobMonitor] (Job-Executor-1:ctx-f118d6dc) Add job-44 
into job monitoring
WARN  [c.c.h.x.r.CitrixResourceBase] (DirectAgent-26:ctx-3e786331) Detecting a 
change in xstoolsversion for r-6-VM
ERROR [c.c.v.VirtualMachineManagerImpl] (Job-Executor-1:ctx-f118d6dc 
ctx-d9a00f18) Failed to start instance 
VM[User|VM-4d5d5db2-e5ba-4bbd-b1dc-e749ac42a74c]
com.cloud.utils.exception.CloudRuntimeException: Router requires upgrade. 
Unable to send command to router:6
at 
com.cloud.network.router.VirtualNetworkApplianceManagerImpl.sendCommandsToRouter(VirtualNetworkApplianceManagerImpl.java:3567)
at 
com.cloud.network.router.VirtualNetworkApplianceManagerImpl$7.execute(VirtualNetworkApplianceManagerImpl.java:3003)
at 
com.cloud.network.router.VirtualNetworkApplianceManagerImpl.applyRules(VirtualNetworkApplianceManagerImpl.java:3848)
at 
com.cloud.network.router.VirtualNetworkApplianceManagerImpl.applyDhcpEntry(VirtualNetworkApplianceManagerImpl.java:2995)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)


Re: Storage overprovisioning for RBD / disable threshold?

2013-11-07 Thread Nitin Mehta
Please find answers inline

On 07/11/13 3:32 AM, "Indra Pramana"  wrote:

>Dear all,
>
>I am using CloudStack 4.2.0, KVM hypervisors, Ceph RBD primary storage and
>NFS secondary storage.
>
>I tried to change the storage.overprovisioning.factor from 1 to 2 under
>Global Settings, and it doesn't seem to work on my primary storage. The
>total amount of disk space seems to be remain the same, unlike the
>secondary storage which increases by double. Is there a way how I can
>enable overprovisioning on my RBD primary storage?

Last I recall storage over provisioning was for NFS and VMFS only. You
might want to check documentation and open an improvement bug as well.

>
>Is it possible for us to disable the threshold of
>pool.storage.allocated.capacity.disablethreshold? At the moment we can set
>an amount between 0 and 1 but we cannot disable it.

Setting it to 1 in a way disables it.

>
>Looking forward to your reply, thank you.
>
>Cheers.



Re: Review Request 15349: Overprivisoning changes needed

2013-11-08 Thread Nitin Mehta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15349/#review28602
---



engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java
<https://reviews.apache.org/r/15349/#comment55463>

Do we have a way to correct it for folks already on 4.2 ?




server/src/com/cloud/configuration/Config.java
<https://reviews.apache.org/r/15349/#comment55462>

This needs to have corresponding upgrade fix as well.


- Nitin Mehta


On Nov. 9, 2013, 12:11 a.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15349/
> ---
> 
> (Updated Nov. 9, 2013, 12:11 a.m.)
> 
> 
> Review request for cloudstack and Nitin Mehta.
> 
> 
> Bugs: Cloudstack-5077.
> https://issues.apache.org/jira/browse/Cloudstack-5077.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> 
> 1.) This includes the change to reserve cpu and memory only when 
> vmware.reserve.cpu/mem is true, regardless of overcommit. 
> 2.) populate the default value of the cpu overcommit at cluster level form 
> the global setting when up grading. 
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 646b406 
>   
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
>  4921925 
>   server/src/com/cloud/configuration/Config.java f3cb919 
> 
> Diff: https://reviews.apache.org/r/15349/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> bharat kumar
> 
>



Re: Review Request 15349: Overprivisoning changes needed

2013-11-11 Thread Nitin Mehta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15349/#review28667
---



server/src/com/cloud/configuration/Config.java
<https://reviews.apache.org/r/15349/#comment55585>

4.2 --> 4.2.1 upgrading folks will not see this text change


- Nitin Mehta


On Nov. 11, 2013, 10:03 a.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15349/
> ---
> 
> (Updated Nov. 11, 2013, 10:03 a.m.)
> 
> 
> Review request for cloudstack and Nitin Mehta.
> 
> 
> Bugs: Cloudstack-5077.
> https://issues.apache.org/jira/browse/Cloudstack-5077.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> 
> 1.) This includes the change to reserve cpu and memory only when 
> vmware.reserve.cpu/mem is true, regardless of overcommit. 
> 2.) populate the default value of the cpu overcommit at cluster level form 
> the global setting when up grading. 
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 646b406 
>   engine/schema/src/com/cloud/upgrade/dao/Upgrade420to421.java d37c0a1 
>   server/src/com/cloud/configuration/Config.java f06b463 
> 
> Diff: https://reviews.apache.org/r/15349/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> bharat kumar
> 
>



Re: Review Request 15349: Overprivisoning changes needed

2013-11-12 Thread Nitin Mehta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15349/#review28745
---



engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java
<https://reviews.apache.org/r/15349/#comment55729>

Why are the changes to VmwareResource gone ?
Otherwise its a Ship it !!


- Nitin Mehta


On Nov. 12, 2013, 12:26 p.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15349/
> ---
> 
> (Updated Nov. 12, 2013, 12:26 p.m.)
> 
> 
> Review request for cloudstack and Nitin Mehta.
> 
> 
> Bugs: Cloudstack-5077.
> https://issues.apache.org/jira/browse/Cloudstack-5077.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> 
> 1.) This includes the change to reserve cpu and memory only when 
> vmware.reserve.cpu/mem is true, regardless of overcommit. 
> 2.) populate the default value of the cpu overcommit at cluster level form 
> the global setting when up grading. 
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 646b406 
>   engine/schema/src/com/cloud/upgrade/dao/Upgrade420to421.java d37c0a1 
>   server/src/com/cloud/configuration/Config.java f06b463 
>   setup/db/db/schema-420to421.sql baadbda 
> 
> Diff: https://reviews.apache.org/r/15349/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> bharat kumar
> 
>



Re: resource count table in 4.2, primary_storage

2013-11-12 Thread Nitin Mehta
I guess you are referring to the bug
https://issues.apache.org/jira/browse/CLOUDSTACK-4716


On 12/11/13 3:57 PM, "Marcus Sorensen"  wrote:

>I'm wondering if someone can quickly help me figure out an issue with
>4.1 to 4.2 upgrade. I seem to be missing a bunch of types on existing
>accounts for my resource_count table. In particular, I'm missing rows
>for pre-4.2 accounts for resource types:
>
>cpu
>memory
>primary_storage
>secondary_storage
>
>Does anyone know what's supposed to upgrade existing accounts with
>these? I'm getting SQL syntax errors because resource lookups return
>no results.
>
>
>new account:
>
>| 646684 |   NULL | 17806 | user_vm   |   0 |
>| 646687 |   NULL | 17806 | public_ip |   0 |
>| 646690 |   NULL | 17806 | volume|   0 |
>| 646693 |   NULL | 17806 | snapshot  |   0 |
>| 646696 |   NULL | 17806 | template  |   0 |
>| 646699 |   NULL | 17806 | project   |   0 |
>| 646702 |   NULL | 17806 | network   |   0 |
>| 646705 |   NULL | 17806 | vpc   |   0 |
>| 646708 |   NULL | 17806 | cpu   |   0 |
>| 646711 |   NULL | 17806 | memory|   0 |
>| 646714 |   NULL | 17806 | primary_storage   |   0 |
>| 646717 |   NULL | 17806 | secondary_storage |   0 |
>
>old account:
>
>| 639760 |   NULL | 17653 | user_vm   |   1 |
>| 639763 |   NULL | 17653 | public_ip |   0 |
>| 639766 |   NULL | 17653 | volume|   1 |
>| 639769 |   NULL | 17653 | snapshot  |   0 |
>| 639772 |   NULL | 17653 | template  |   0 |
>| 639775 |   NULL | 17653 | project   |   0 |
>| 639778 |   NULL | 17653 | network   |   1 |
>| 639781 |   NULL | 17653 | vpc   |   1 |



Re: Review Request 15349: Overprivisoning changes needed

2013-11-12 Thread Nitin Mehta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15349/#review28786
---

Ship it!


Ship It!

- Nitin Mehta


On Nov. 13, 2013, 5:35 a.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15349/
> ---
> 
> (Updated Nov. 13, 2013, 5:35 a.m.)
> 
> 
> Review request for cloudstack and Nitin Mehta.
> 
> 
> Bugs: Cloudstack-5077.
> https://issues.apache.org/jira/browse/Cloudstack-5077.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> 
> 1.) This includes the change to reserve cpu and memory only when 
> vmware.reserve.cpu/mem is true, regardless of overcommit. 
> 2.) populate the default value of the cpu overcommit at cluster level form 
> the global setting when up grading. 
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 646b406 
>   engine/schema/src/com/cloud/upgrade/dao/Upgrade420to421.java d37c0a1 
>   
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
>  4921925 
>   server/src/com/cloud/configuration/Config.java f06b463 
>   setup/db/db/schema-420to421.sql 302d44a 
> 
> Diff: https://reviews.apache.org/r/15349/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> bharat kumar
> 
>



Re: New Committer: Sanjeev Neelarapu

2013-11-14 Thread Nitin Mehta
Congrats Sanjeev !!

On 14/11/13 7:30 AM, "Somesh Naidu"  wrote:

>Congratulations Sanjeev!
>
>Regards,
>Somesh
>
>
>-Original Message-
>From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
>Sent: Thursday, November 14, 2013 4:15 PM
>To: dev
>Subject: Re: New Committer: Sanjeev Neelarapu
>
>welcome Sanjeev and good luck.
>
>On Thu, Nov 14, 2013 at 10:26 AM, Rajani Karuturi
> wrote:
>> Congratulations Sanjeev.
>>
>> --
>> - Rajani
>>
>>
>> -Original Message-
>> From: Sateesh Chodapuneedi
>>mailto:Sateesh%20Chodapuneedi%20%3csatee
>>sh.chodapune...@citrix.com%3e>>
>> Reply-to: 
>> To: dev@cloudstack.apache.org
>>mailto:%22...@cloudstack.apache.org%22%20%3cde
>>v...@cloudstack.apache.org%3e>>
>> Subject: RE: New Committer: Sanjeev Neelarapu
>> Date: Thu, 14 Nov 2013 07:40:29 +
>>
>>
>>
>> Sanjeev, Hearty Congratulations, great job.
>>
>> Regards,
>> Sateesh
>>
>>> -Original Message-
>>> From: Du Jun [mailto:dj199...@gmail.com]
>>> Sent: 14 November 2013 12:27
>>> To: dev@cloudstack.apache.org
>>> Subject: Re: New Committer: Sanjeev Neelarapu
>>>
>>> Congratulations!
>>>
>>> --
>>> Best regards.
>>> Frank
>>>
>>>
>>> 2013/11/14 Koushik Das
>>>mailto:koushik@citrix.com>>
>>>
>>> > Congrats Sanjeev
>>> >
>>> > On 14-Nov-2013, at 11:29 AM, Prasanna Santhanam
>>>mailto:t...@apache.org>> wrote:
>>> >
>>> > > The Project Management Committee (PMC) for Apache CloudStack has
>>> > > asked
>>> > Sanjeev
>>> > > Neelarapu to become a committer and we are pleased to announce that
>>> > > they
>>> > have
>>> > > accepted.
>>> > >
>>> > > Being a committer allows many contributors to contribute more
>>> > autonomously. For
>>> > > developers, it makes it easier to submit changes and eliminates the
>>> > > need
>>> > to
>>> > > have contributions reviewed via the patch submission process.
>>> > > Whether contributions are development-related or otherwise, it is a
>>> > > recognition
>>> > of a
>>> > > contributor's participation in the project and commitment to the
>>> > > project
>>> > and
>>> > > the Apache Way.
>>> > >
>>> > > Please join me in congratulating Sanjeev!
>>> > >
>>> > > --
>>> > > Prasanna.,
>>> > > on behalf of the Apache CloudStack PMC
>>> > >
>>> > > 
>>> > > Powered by BigRock.com
>>> > >
>>> >
>>> >
>>



Re: [VOTE] Release Apache CloudStack 4.2.1

2013-11-15 Thread Nitin Mehta
+1.

Did some basic testing like creating vms, attaching volume, creating
snapshots etc. and they all worked fine.

Thanks,
-Nitin


On 14/11/13 8:40 AM, "Daan Hoogland"  wrote:

>+1 binding (I had not been clear on this in this thread it seems)
>
>On Thu, Nov 14, 2013 at 6:05 AM, Abhinandan Prateek
> wrote:
>> Marcus,
>>
>>   Just summarising your concerns so that they can be followed upon:
>> 1. Due to a VR script change a restart of VR is required. This should be
>> noted down in upgrade instructions in RN. (Radhika to note)
>> 2. For a maintenance release we should limit the scope to only
>>blockers. I
>> guess what is done is done probably for better as the main release had
>>so
>> many new features that a whole lot fixes were expected in the
>>maintenance
>> release. But again for further maintenance releases scope should be
>> restricted to important fixes.
>>
>> Any other thing that has been missed ?
>>
>> -abhi
>>
>>
>> On 14/11/13 12:06 am, "Marcus Sorensen"  wrote:
>>
>>>I'm unable to deploy virtual machines after upgrading an existing
>>>4.2.0 to this release.
>>>
>>>It looks like the file savepassword.sh was added at the end of October
>>>as a virtual router script. This would likely mean that people
>>>upgrading to 4.2.1 will need to upgrade/redeploy their routers. I can
>>>verify that deploy works if I reboot the router.
>>>
>>>Looking over the current state of 4.2, I'm actually pretty surprised
>>>at how much has changed. I'm seeing lots of whitespace fixes, changes
>>>to interfaces, etc. My impression was that we'd only commit fixes for
>>>blocker bugs once a release has gone production, only touching it if
>>>we had to. This went pretty well with 4.1, I thought, but everything
>>>was going through the RM that round.
>>>
>>>2013-11-13 11:25:24,917 DEBUG
>>>[resource.virtualnetwork.VirtualRoutingResource]
>>>(agentRequest-Handler-2:null) Executing:
>>>/usr/share/cloudstack-common/scripts/network/domr/router_proxy.sh
>>>savepassword.sh 169.254.1.163 -v 10.2.4.116 -p fnirq_cnffjbeq
>>>
>>>2013-11-13 11:25:25,000 DEBUG
>>>[resource.virtualnetwork.VirtualRoutingResource]
>>>(agentRequest-Handler-2:null) Exit value is 127
>>>
>>>2013-11-13 11:25:25,001 DEBUG
>>>[resource.virtualnetwork.VirtualRoutingResource]
>>>(agentRequest-Handler-2:null) bash: /opt/cloud/bin/savepassword.sh: No
>>>such file or directory
>>>
>>>2013-11-13 11:25:25,002 DEBUG [cloud.agent.Agent]
>>>(agentRequest-Handler-2:null) Seq 21-289734823:  { Ans: , MgmtId:
>>>90520732090445, via: 21, Ver: v1, Flags: 110,
>>>[{"com.cloud.agent.api.Answer":{"result":false,"details":"Unable to
>>>save password to
>>>DomR.","wait":0}},{"com.cloud.agent.api.Answer":{"result":false,"details
>>>":
>>>"Stopped
>>>by previous failure","wait":0}}] }
>>>
>>>On Wed, Nov 13, 2013 at 10:26 AM, Chip Childers
>>>
>>>wrote:
 On Tue, Nov 12, 2013 at 10:52 AM, Abhinandan Prateek
  wrote:
>
>This vote is to approve the current RC build for 4.2.1 maintenance
>release.
> For this particular release various upgrade paths have been tested
>apart from regression tests and BVTs.
> Around 175 bugs have been fixed some new features added (see
>CHANGES).
>
> Following are the particulars for this release:
>
>
>https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=
>re
>fs/heads/4.2
> commit: 0b9eadaf14513f5c72de672963b0e2f12ee7206f
>
> List of changes:
>
>https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blob_plain;
>f=
>CHANGES;hb=4.2.1
>
> Source release revision 3492 (checksums and signatures are available
>at the same location):
> https://dist.apache.org/repos/dist/dev/cloudstack/4.2.1/
>
> PGP release keys (signed using RSA Key ID = 42443AA1):
> https://dist.apache.org/repos/dist/release/cloudstack/KEYS
>
> Vote will be open for 72 hours (until 11/15 End of day PST).
>
> For sanity in tallying the vote, can PMC members please be sure to
>indicate "(binding)" with their vote?
>
> [ ] +1  approve
> [ ] +0  no opinion
> [ ] -1  disapprove (and reason why)

 +1 (binding)

 I only performed very rudimentary functional testing, but the
 artifact's look legit.

 Thanks for doing this Abhi!



Re: Review Request: CLOUDSTACK-2305: [Automation] NPE: not able to create volume from snapshot

2013-05-20 Thread Nitin Mehta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11296/#review20818
---



server/src/com/cloud/storage/VolumeManagerImpl.java
<https://reviews.apache.org/r/11296/#comment42938>

Can you please put the check above the if (cmd.getSnapshotId() == null) 
else block because this should be working for both volume created from 
snapshot or a fresh volume.


- Nitin Mehta


On May 21, 2013, 5:24 a.m., Sanjay Tripathi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11296/
> ---
> 
> (Updated May 21, 2013, 5:24 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Nitin Mehta.
> 
> 
> Description
> ---
> 
> CLOUDSTACK-2305: [Automation] NPE: not able to create volume from snapshot 
> 
> 
> This addresses bug CLOUDSTACK-2305.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/storage/VolumeManagerImpl.java 55e20cf 
> 
> Diff: https://reviews.apache.org/r/11296/diff/
> 
> 
> Testing
> ---
> 
> Verified on my local CloudStack setup.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>



Re: Review Request: CLOUDSTACK-2305: [Automation] NPE: not able to create volume from snapshot

2013-05-20 Thread Nitin Mehta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11296/#review20822
---

Ship it!


Ship It!

- Nitin Mehta


On May 21, 2013, 5:24 a.m., Sanjay Tripathi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11296/
> ---
> 
> (Updated May 21, 2013, 5:24 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Nitin Mehta.
> 
> 
> Description
> ---
> 
> CLOUDSTACK-2305: [Automation] NPE: not able to create volume from snapshot 
> 
> 
> This addresses bug CLOUDSTACK-2305.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/storage/VolumeManagerImpl.java 55e20cf 
> 
> Diff: https://reviews.apache.org/r/11296/diff/
> 
> 
> Testing
> ---
> 
> Verified on my local CloudStack setup.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>



Re: Review Request: CLOUDSTACK-2305: [Automation] NPE: not able to create volume from snapshot

2013-05-20 Thread Nitin Mehta


> On May 21, 2013, 5:45 a.m., Nitin Mehta wrote:
> > server/src/com/cloud/storage/VolumeManagerImpl.java, line 920
> > <https://reviews.apache.org/r/11296/diff/1/?file=295144#file295144line920>
> >
> > Can you please put the check above the if (cmd.getSnapshotId() == null) 
> > else block because this should be working for both volume created from 
> > snapshot or a fresh volume.
> 
> Sanjay Tripathi wrote:
> Nitin,
> I have moved the fix outside the if (cmd.getSnapshotId() == null) else 
> block, so it is working for both volume creation (fresh and from snapshot).
> Does it matter if it is above or below the if else block?

Oops. My bad. No it doesnt matter. Your fix is fine


- Nitin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11296/#review20818
---


On May 21, 2013, 5:24 a.m., Sanjay Tripathi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11296/
> ---
> 
> (Updated May 21, 2013, 5:24 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Nitin Mehta.
> 
> 
> Description
> ---
> 
> CLOUDSTACK-2305: [Automation] NPE: not able to create volume from snapshot 
> 
> 
> This addresses bug CLOUDSTACK-2305.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/storage/VolumeManagerImpl.java 55e20cf 
> 
> Diff: https://reviews.apache.org/r/11296/diff/
> 
> 
> Testing
> ---
> 
> Verified on my local CloudStack setup.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>



Re: Review Request: when comparing scopes, compare scope ids by value, not reference.

2013-05-20 Thread Nitin Mehta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11246/#review20824
---

Ship it!


Ship It!

- Nitin Mehta


On May 20, 2013, 7:49 p.m., Dave Brosius wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11246/
> ---
> 
> (Updated May 20, 2013, 7:49 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> ---
> 
> code compares Long values with == which will work for Long cached values, but 
> not others 
> 
> switched to use .equals
> 
> 
> Diffs
> -
> 
>   
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/AbstractScope.java
>  c94db66 
> 
> Diff: https://reviews.apache.org/r/11246/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dave Brosius
> 
>



Re: Review Request: remove bogus self assign to parent

2013-05-20 Thread Nitin Mehta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11247/#review20826
---

Ship it!


Ship It!

- Nitin Mehta


On May 20, 2013, 7:50 p.m., Dave Brosius wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11247/
> ---
> 
> (Updated May 20, 2013, 7:50 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> ---
> 
> code assigns 
> 
> this.parent = parent; 
> 
> even tho there isn't any non-field parent in the constructor... 
> removed.
> 
> 
> Diffs
> -
> 
>   core/src/com/cloud/agent/api/storage/CreateEntityDownloadURLCommand.java 
> d928e0c 
> 
> Diff: https://reviews.apache.org/r/11247/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dave Brosius
> 
>



Re: Review Request: CLOUDSTACK-2642 : [XenServer] Add support for XenServer 6.2.0

2013-05-23 Thread Nitin Mehta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11341/#review20935
---


Thanks for this but probably needs more testing - maybe even running the BVT 
against this.
I see that CitrixHelper should be changed for this...maybe more places as well, 
depending on what has changed in this version

- Nitin Mehta


On May 23, 2013, 9:45 a.m., venkata swamy babu  budumuru wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11341/
> ---
> 
> (Updated May 23, 2013, 9:45 a.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Description
> ---
> 
> Steps to reproduce : 
> 
> 1. Have a CloudStack 4.2 setup 
> 2. Try to create an advanced zone using the XenServer 6.2.0 
> 
> Observations : 
> 
> (i) Adding host fails because XcpDiscoverer.java is currently allowing only 
> till XenServer 6.1.0 release. 
> 
> 
> This addresses bug CLOUDSTACK-2642.
> 
> 
> Diffs
> -
> 
>   
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java
>  fd49836 
> 
> Diff: https://reviews.apache.org/r/11341/diff/
> 
> 
> Testing
> ---
> 
> With the above mentioned fix, tried to add the XenServer 6.2 build and it 
> went fine without any issues.
> 
> 
> Thanks,
> 
> venkata swamy babu  budumuru
> 
>



Re: [ANNOUNCE] New committer: Venkata Swamy

2013-05-23 Thread Nitin Mehta
Congrats Swamy.

On 24/05/13 2:59 AM, "Chip Childers"  wrote:

>The Project Management Committee (PMC) for Apache CloudStack
>has asked Venkata Swamy to become a committer and we are pleased to
>announce that they have accepted.
>
>Being a committer allows many contributors to contribute more
>autonomously. For developers, it makes it easier to submit changes and
>eliminates the need to have contributions reviewed via the patch
>submission process. Whether contributions are development-related or
>otherwise, it is a recognition of a contributor's participation in the
>project and commitment to the project and the Apache Way.
>
>Please join me in congratulating Venkata!
>
>-chip
>on behalf of the CloudStack PMC



Re: [ANNOUNCE] New committer: Wei Zhou

2013-05-23 Thread Nitin Mehta
Congrats Wei

On 24/05/13 2:53 AM, "Chip Childers"  wrote:

>The Project Management Committee (PMC) for Apache CloudStack
>has asked Wei Zhou to become a committer and we are pleased to
>announce that they have accepted.
>
>Being a committer allows many contributors to contribute more
>autonomously. For developers, it makes it easier to submit changes and
>eliminates the need to have contributions reviewed via the patch
>submission process. Whether contributions are development-related or
>otherwise, it is a recognition of a contributor's participation in the
>project and commitment to the project and the Apache Way.
>
>Please join me in congratulating Wei!
>
>-chip
>on behalf of the CloudStack PMC



Re: [ANNOUNCE] New committer: Sailaja Mada

2013-05-23 Thread Nitin Mehta
Congrats Sailaja. Well done

On 24/05/13 10:52 AM, "Bharat Kumar"  wrote:

>Congrats Sailaja.
>
>On May 24, 2013, at 2:50 AM, Chip Childers 
>wrote:
>
>> The Project Management Committee (PMC) for Apache CloudStack
>> has asked Sailaja Mada to become a committer and we are pleased to
>> announce that they have accepted.
>> 
>> Being a committer allows many contributors to contribute more
>> autonomously. For developers, it makes it easier to submit changes and
>> eliminates the need to have contributions reviewed via the patch
>> submission process. Whether contributions are development-related or
>> otherwise, it is a recognition of a contributor's participation in the
>> project and commitment to the project and the Apache Way.
>> 
>> Please join me in congratulating Sailaja!
>> 
>> -chip
>> on behalf of the CloudStack PMC
>



Re: Convention on UUID column

2013-05-23 Thread Nitin Mehta
Agree with Koushik. Lets enforce the not null constraint on all the UUID
fields now that we are populating it.

Also wanted to ask why we are populating it with the ID and not a
generated UUID ? Doesn't break the backward compatibilty going either ways
but the later is more consistent right and can be used in future as they
are always unique across the system - say for storing templates directly
under UUID of the template/vol/snapshot on sec. storage than using the
folder structure of templates/account_id/template_id/real_template ?
Clients who have hardcoded against CS for system vm ids, service offering
ids etc. will break definitely though - is that ok ?

Thanks,
-Nitin

On 24/05/13 9:26 AM, "Koushik Das"  wrote:

>
>It is better to add constraints in the db for all uuid fields. That way
>uuid field will never get missed out. I see that for some tables there is
>a NOT NULL constraint.
>
>-Koushik
>
>> -Original Message-
>> From: Min Chen [mailto:min.c...@citrix.com]
>> Sent: Friday, May 24, 2013 4:09 AM
>> To: dev@cloudstack.apache.org
>> Subject: Convention on UUID column
>> 
>> Hi there,
>> 
>> During API refactoring efforts, Rohit and I run into several issues due
>>to
>> empty UUID column for existing DB entries. Since UUID was introduced
>>later
>> in 3.0.x, we have to always conditionally handle existing customers with
>> empty UUID columns for different entities, causing much headache for
>> various upgrade cases. To make sure that we have a consistent upgrade
>>base
>> for all 4.1 customers later, in schema-410to420.sql, we have added sql
>>scripts
>> to populate UUID column of all pre-4.1 schema tables with values from
>>their
>> ID column if UUID column is NULL. To make this work properly, we require
>> that all UUID columns should be populated with values when you add new
>> data into both pre-4.1 schema or post-4.1 schema. I just noticed that
>>this
>> assumption may not be well known to community, since I am seeing this
>>sql
>> in schema-410to420.sql:
>> 
>> 
>> INSERT INTO `cloud`.`vm_template` (id, unique_name, name, public,
>> created, type, hvm, bits, account_id, url, checksum, enable_password,
>> display_text, format, guest_os_id, featured, cross_zones,
>>hypervisor_type)
>> 
>>  VALUES (10, 'routing-10', 'SystemVM Template (LXC)', 0, now(),
>>'SYSTEM',
>> 0, 64, 1, 'http://download.cloud.com/templates/acton/acton-systemvm-
>> 02062012.qcow2.bz2', '2755de1f9ef2ce4d6f2bee2efbb4da92', 0, 'SystemVM
>> Template (LXC)', 'QCOW2', 15, 0, 1, 'LXC');
>> 
>> 
>> Instead, this should be modified as:
>> 
>> 
>> INSERT INTO `cloud`.`vm_template` (id, uuid, unique_name, name, public,
>> created, type, hvm, bits, account_id, url, checksum, enable_password,
>> display_text, format, guest_os_id, featured, cross_zones,
>>hypervisor_type)
>> 
>>  VALUES (10, UUID(), 'routing-10', 'SystemVM Template (LXC)', 0,
>>now(),
>> 'SYSTEM', 0, 64, 1, 'http://download.cloud.com/templates/acton/acton-
>> systemvm-02062012.qcow2.bz2', '2755de1f9ef2ce4d6f2bee2efbb4da92', 0,
>> 'SystemVM Template (LXC)', 'QCOW2', 15, 0, 1, 'LXC');
>> 
>> I have made this fix in master, but want to raise this topic to get
>>community's
>> attention on this.
>> 
>> Thanks
>> -min
>> 
>



Re: [ANNOUNCE] New committer: Sangeetha Hariharan

2013-05-24 Thread Nitin Mehta
Congrats Sangeetha :)

On 24/05/13 1:04 PM, "Prachi Damle"  wrote:

>Congratulations Sangeetha!!
>
>-Original Message-
>From: Sowmya Krishnan [mailto:sowmya.krish...@citrix.com]
>Sent: Friday, May 24, 2013 12:22 AM
>To: dev@cloudstack.apache.org
>Subject: RE: [ANNOUNCE] New committer: Sangeetha Hariharan
>
>Congratulations Sangeetha!
>
>> -Original Message-
>> From: Alex Huang [mailto:alex.hu...@citrix.com]
>> Sent: Friday, May 24, 2013 11:49 AM
>> To: dev@cloudstack.apache.org
>> Subject: [ANNOUNCE] New committer: Sangeetha Hariharan
>> 
>> The Project Management Committee (PMC) for Apache CloudStack has asked
>> Sangeetha Hariharan  to become a committer and we are pleased to
>> announce that they have accepted.
>> 
>> Being a committer allows many contributors to contribute more
>>autonomously.
>> For developers, it makes it easier to submit changes and eliminates
>> the need to have contributions reviewed via the patch submission
>> process. Whether contributions are development-related or otherwise,
>> it is a recognition of a contributor's participation in the project
>> and commitment to the project and the Apache Way.
>> 
>> Please join me in congratulating Sangeetha!
>> 
>> --Alex
>> on behalf of the CloudStack PMC



Re: Convention on UUID column

2013-05-24 Thread Nitin Mehta
Agreed with Koushik. Now that the UUId is going to be populated for every
table lets keep it as not null else we will keep running into these issues.

Also whats the reason for populating the UUID column with ID ? Is it for
clients who have hardcoded values for system vms, service offerings etc.
or do we really break some backward compatibility ? I would have still
preferred populating it with UUID else  you call the api with Ids (for
preexisting resources) and UUIds which is confusing. Also since UUIds are
unique across the board we wouldn't have to keep folder structures like
template/account_id/template_id or snapshots/volume_id etc. This is just
an example. 

Thanks,
Nitin

On 24/05/13 9:26 AM, "Koushik Das"  wrote:

>
>It is better to add constraints in the db for all uuid fields. That way
>uuid field will never get missed out. I see that for some tables there is
>a NOT NULL constraint.
>
>-Koushik
>
>> -Original Message-
>> From: Min Chen [mailto:min.c...@citrix.com]
>> Sent: Friday, May 24, 2013 4:09 AM
>> To: dev@cloudstack.apache.org
>> Subject: Convention on UUID column
>> 
>> Hi there,
>> 
>> During API refactoring efforts, Rohit and I run into several issues due
>>to
>> empty UUID column for existing DB entries. Since UUID was introduced
>>later
>> in 3.0.x, we have to always conditionally handle existing customers with
>> empty UUID columns for different entities, causing much headache for
>> various upgrade cases. To make sure that we have a consistent upgrade
>>base
>> for all 4.1 customers later, in schema-410to420.sql, we have added sql
>>scripts
>> to populate UUID column of all pre-4.1 schema tables with values from
>>their
>> ID column if UUID column is NULL. To make this work properly, we require
>> that all UUID columns should be populated with values when you add new
>> data into both pre-4.1 schema or post-4.1 schema. I just noticed that
>>this
>> assumption may not be well known to community, since I am seeing this
>>sql
>> in schema-410to420.sql:
>> 
>> 
>> INSERT INTO `cloud`.`vm_template` (id, unique_name, name, public,
>> created, type, hvm, bits, account_id, url, checksum, enable_password,
>> display_text, format, guest_os_id, featured, cross_zones,
>>hypervisor_type)
>> 
>>  VALUES (10, 'routing-10', 'SystemVM Template (LXC)', 0, now(),
>>'SYSTEM',
>> 0, 64, 1, 'http://download.cloud.com/templates/acton/acton-systemvm-
>> 02062012.qcow2.bz2', '2755de1f9ef2ce4d6f2bee2efbb4da92', 0, 'SystemVM
>> Template (LXC)', 'QCOW2', 15, 0, 1, 'LXC');
>> 
>> 
>> Instead, this should be modified as:
>> 
>> 
>> INSERT INTO `cloud`.`vm_template` (id, uuid, unique_name, name, public,
>> created, type, hvm, bits, account_id, url, checksum, enable_password,
>> display_text, format, guest_os_id, featured, cross_zones,
>>hypervisor_type)
>> 
>>  VALUES (10, UUID(), 'routing-10', 'SystemVM Template (LXC)', 0,
>>now(),
>> 'SYSTEM', 0, 64, 1, 'http://download.cloud.com/templates/acton/acton-
>> systemvm-02062012.qcow2.bz2', '2755de1f9ef2ce4d6f2bee2efbb4da92', 0,
>> 'SystemVM Template (LXC)', 'QCOW2', 15, 0, 1, 'LXC');
>> 
>> I have made this fix in master, but want to raise this topic to get
>>community's
>> attention on this.
>> 
>> Thanks
>> -min
>> 
>



Re: Review Request: (CLOUDSTACK-528) fix some mistakes in configuration table which cause addSecondaryStorage failed when upgrade from 3.0.* to 4.*

2013-05-24 Thread Nitin Mehta
Would this not be a problem for folks who are already on 4.0 ?

On 13/05/13 9:22 PM, "Chip Childers"  wrote:

>
>---
>This is an automatically generated e-mail. To reply, visit:
>https://reviews.apache.org/r/11088/#review20489
>---
>
>Ship it!
>
>
>In 4.1:
>
>commit 5ccdf7dc4ad86145633124b9540aadfbfc423f6f
>Author: Wei Zhou 
>Date:   Mon May 13 16:50:29 2013 +0100
>
>CLOUDSTACK-528: Correct a bunch of mistakes in the 3.0.x to 4.0 db
>script
>Signed-off-by: Chip Childers 
>
>- Chip Childers
>
>
>On May 13, 2013, 3:38 p.m., Wei Zhou wrote:
>> 
>> ---
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/11088/
>> ---
>> 
>> (Updated May 13, 2013, 3:38 p.m.)
>> 
>> 
>> Review request for cloudstack and Chip Childers.
>> 
>> 
>> Description
>> ---
>> 
>> There are some mistakes in configuration table.
>> fixed them by this patch.
>> 
>> 
>> This addresses bug CLOUDSTACK-528.
>> 
>> 
>> Diffs
>> -
>> 
>>   setup/db/db/schema-302to40.sql a947ac1
>> 
>> Diff: https://reviews.apache.org/r/11088/diff/
>> 
>> 
>> Testing
>> ---
>> 
>> Nicolas has tested it.
>> We also need an additional patch for the following new issue (Advanced
>>Network with Security Groups).
>> 
>> 
>> Thanks,
>> 
>> Wei Zhou
>> 
>>
>



Re: Review Request: (CLOUDSTACK-528) fix some mistakes in configuration table which cause addSecondaryStorage failed when upgrade from 3.0.* to 4.*

2013-05-25 Thread Nitin Mehta


On 24/05/13 7:19 PM, "Chip Childers"  wrote:

>It would indeed, but since we are not going to release a 4.0.3, I fixed
>it in the 4.1 and master branches.
>
>At a minimum, this "fix" doesn't regress anything...  so while I'm
>surprised that we didn't run into this issue as reported, I don't see
>that it's an issue to correct the syntax moving forward.
>
>Do you think we should have another corrective update that strips the
>extra space characters that may be there on 4.0 installations?


Yes, if someone is currently on CS 4.0 and say upgrades to 4.1 then
schema-302to40.sql won't be executed for him but instead schema-40to41.sql
would be executed,
so in a nutshell the same changes need to be present in schema-40to41.sql

>
>-chip
>
>On Fri, May 24, 2013 at 09:49:12AM +, Nitin Mehta wrote:
>> Would this not be a problem for folks who are already on 4.0 ?
>> 
>> On 13/05/13 9:22 PM, "Chip Childers"  wrote:
>> 
>> >
>> >---
>> >This is an automatically generated e-mail. To reply, visit:
>> >https://reviews.apache.org/r/11088/#review20489
>> >---
>> >
>> >Ship it!
>> >
>> >
>> >In 4.1:
>> >
>> >commit 5ccdf7dc4ad86145633124b9540aadfbfc423f6f
>> >Author: Wei Zhou 
>> >Date:   Mon May 13 16:50:29 2013 +0100
>> >
>> >CLOUDSTACK-528: Correct a bunch of mistakes in the 3.0.x to 4.0 db
>> >script
>> >Signed-off-by: Chip Childers 
>> >
>> >- Chip Childers
>> >
>> >
>> >On May 13, 2013, 3:38 p.m., Wei Zhou wrote:
>> >> 
>> >> ---
>> >> This is an automatically generated e-mail. To reply, visit:
>> >> https://reviews.apache.org/r/11088/
>> >> ---
>> >> 
>> >> (Updated May 13, 2013, 3:38 p.m.)
>> >> 
>> >> 
>> >> Review request for cloudstack and Chip Childers.
>> >> 
>> >> 
>> >> Description
>> >> ---
>> >> 
>> >> There are some mistakes in configuration table.
>> >> fixed them by this patch.
>> >> 
>> >> 
>> >> This addresses bug CLOUDSTACK-528.
>> >> 
>> >> 
>> >> Diffs
>> >> -
>> >> 
>> >>   setup/db/db/schema-302to40.sql a947ac1
>> >> 
>> >> Diff: https://reviews.apache.org/r/11088/diff/
>> >> 
>> >> 
>> >> Testing
>> >> ---
>> >> 
>> >> Nicolas has tested it.
>> >> We also need an additional patch for the following new issue
>>(Advanced
>> >>Network with Security Groups).
>> >> 
>> >> 
>> >> Thanks,
>> >> 
>> >> Wei Zhou
>> >> 
>> >>
>> >
>> 
>> 



Re: Review Request: Fix for CLOUDSTACK-2672: Adding isVolatile parameter in service offering response object

2013-05-27 Thread Nitin Mehta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11373/#review21060
---



server/src/com/cloud/api/query/dao/ServiceOfferingJoinDaoImpl.java
<https://reviews.apache.org/r/11373/#comment43564>

Can offering.getVolatileVm() be null ? If yes then we should set false.


- Nitin Mehta


On May 24, 2013, 12:22 p.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11373/
> ---
> 
> (Updated May 24, 2013, 12:22 p.m.)
> 
> 
> Review request for cloudstack and Koushik Das.
> 
> 
> Description
> ---
> 
> Missing isVolatile parameter in the response of service offering.
> Need to add this in service offering response object. 
> 
> 
> This addresses bug CLOUDSTACK-2672.
> 
> 
> Diffs
> -
> 
>   api/src/org/apache/cloudstack/api/response/ServiceOfferingResponse.java 
> 08ebbb0 
>   server/src/com/cloud/api/query/dao/ServiceOfferingJoinDaoImpl.java ce20562 
>   server/src/com/cloud/api/query/vo/ServiceOfferingJoinVO.java 598e1d1 
>   setup/db/db/schema-410to420.sql 442a544 
> 
> Diff: https://reviews.apache.org/r/11373/diff/
> 
> 
> Testing
> ---
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>



Re: Review Request: Fix for CLOUDSTACK-2672: Adding isVolatile parameter in service offering response object

2013-05-27 Thread Nitin Mehta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11373/#review21063
---

Ship it!


Ship It!

- Nitin Mehta


On May 24, 2013, 12:22 p.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11373/
> ---
> 
> (Updated May 24, 2013, 12:22 p.m.)
> 
> 
> Review request for cloudstack and Koushik Das.
> 
> 
> Description
> ---
> 
> Missing isVolatile parameter in the response of service offering.
> Need to add this in service offering response object. 
> 
> 
> This addresses bug CLOUDSTACK-2672.
> 
> 
> Diffs
> -
> 
>   api/src/org/apache/cloudstack/api/response/ServiceOfferingResponse.java 
> 08ebbb0 
>   server/src/com/cloud/api/query/dao/ServiceOfferingJoinDaoImpl.java ce20562 
>   server/src/com/cloud/api/query/vo/ServiceOfferingJoinVO.java 598e1d1 
>   setup/db/db/schema-410to420.sql 442a544 
> 
> Diff: https://reviews.apache.org/r/11373/diff/
> 
> 
> Testing
> ---
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>



Re: FirewallRuleResponse vs FirewallResponse

2013-05-28 Thread Nitin Mehta
But, this will break backward compatibility no ?
Maybe change it in the next big release.

On 28/05/13 2:50 PM, "Prasanna Santhanam" 
wrote:

>When I createFirewallRule I recieve a FirewallResponse but when I
>deleteFirewallRule I am expected to pass in an id I recieved as a
>FirewallRuleResponse?
>
>What are these two response types? They look very similar. Is this
>legacy? Can we clean it up and standardize to a single
>FirewallRuleResponse?
>
>Thanks,
>
>-- 
>Prasanna.,



Re: [MERGE]object_store branch into master

2013-05-28 Thread Nitin Mehta
Agree with Wido. This would be a great feature to have in 4.2. Yes, its a
lot of change and probably needs more education from Edison and Min maybe
through code walkthroughs, documentation, IRC meetings but I am +1 for
this to make it to 4.2 and would go as far to say that I would even
volunteer for any bug fixes required.

I would say its not too bad to merge it now as most of the features for
4.2 are merged by now and not a lot of them would be blocked because of
this. Yes, the master would be unstable but it would be even if we merge
it post cutting 4.2 branch. I would rather see this coming in 4.2 than
wait for another 6 months or so for it. Yes, this is an architectural
change and we are learning as a community to time these kind of changes.
We should also try and raise alarms for these changes much early when the
FS was proposed rather than when its done, probably a learning for all of
us :)

Thanks,
-Nitin

On 28/05/13 4:23 PM, "Wido den Hollander"  wrote:

>
>
>On 05/23/2013 06:35 PM, Chip Childers wrote:
>> On Wed, May 22, 2013 at 09:25:10PM +, Edison Su wrote:
>>>
>>>
 -Original Message-
 From: Chip Childers [mailto:chip.child...@sungard.com]
 Sent: Wednesday, May 22, 2013 1:26 PM
 To: dev@cloudstack.apache.org
 Subject: Re: [MERGE]object_store branch into master

 On Wed, May 22, 2013 at 08:15:41PM +, Animesh Chaturvedi wrote:
>
>
>> -Original Message-
>> From: Chip Childers [mailto:chip.child...@sungard.com]
>> Sent: Wednesday, May 22, 2013 12:08 PM
>> To: dev@cloudstack.apache.org
>> Subject: Re: [MERGE]object_store branch into master
>>
>> On Wed, May 22, 2013 at 07:00:51PM +, Animesh Chaturvedi wrote:
>>>
>>>
 -Original Message-
 From: John Burwell [mailto:jburw...@basho.com]
 Sent: Tuesday, May 21, 2013 8:51 AM
 To: dev@cloudstack.apache.org
 Subject: Re: [MERGE]object_store branch into master

 Edison,

 Thanks, I will start going through it today.  Based on other
 $dayjob responsibilities, it may take me a couple of days.

 Thanks,
 -John
>>> [Animesh>] John we are just a few days away  from 4.2 feature
>>> freeze, can
>> you provide your comments by Friday 5/24.   I would like all feature
 threads
>> to be resolved sooner so that we don't have last minute rush.
>>
>> I'm just going to comment on this, but not take it much further...
>> this type of change is an "architectural" change.  We had previously
>> discussed (on several
>> threads) that the appropriate time for this sort of thing to hit
>> master was
>> *early* in the release cycle.  Any reason that that consensus
>> doesn't apply here?
> [Animesh>] Yes it is an architectural change and discussion on this
>started a
 few weeks back already, Min and Edison wanted to get it in sooner by
4/30
 but it took longer than anticipated in  preparing for merge and
testing on
 feature branch.
>
>

 You're not following me I think.  See this thread on the Javelin
merge:

 http://markmail.org/message/e6peml5ddkqa6jp4

 We have discussed that our preference is for architectural changes to
hit
 master shortly after a feature branch is cut.  Why are we not doing
that here?
>>>
>>> This kind of refactor takes time, a lot of time. I think I worked on
>>>the merge of primary storage refactor into master and bug fixes during
>>>March(http://comments.gmane.org/gmane.comp.apache.cloudstack.devel/14469
>>>), then started to work on the secondary storage refactor in
>>>April(http://markmail.org/message/cspb6xweeupfvpit). Min and I finished
>>>the coding at end of April, then tested for two weeks, send out the
>>>merge request at middle of May.
>>> With the refactor, the  storage code will be much cleaner, and the
>>>performance of S3 will be improved, and integration with other storage
>>>vendor will be much easier, and the quality is ok(33 bugs fired, only 5
>>>left: 
>>>https://issues.apache.org/jira/issues/?jql=text%20~%20%22Object_Store_Re
>>>factor%22). Anyway, it's up to the community to decide, merge it or
>>>not, we already tried our best to get it done ASAP.
>>>
>>>
>>
>> I'm absolutely not questioning the time and effort here.  I know that
>> you have been working hard, and that testing is happening!
>>
>> I'm only asking if we, as a community, want to follow the practice of
>> bringing changes like this in early or late in a cycle.  I thought we
>> had agreed on doing it early.
>>
>
>So I tried reviewing the code, but I have to say that it is a lot of
>code. Reviewing such a large piece of code isn't easy.
>
>Now, let me be honest, I'd love to see this in 4.2 since it would make
>the Ceph integration a lot better. We can get rid of NFS as Secondary
>Storage and use Ceph as the only storage for CS.
>
>Yes, it m

Re: [GSOC] Five projects accepted for 2013 Google Summer of Code

2013-05-28 Thread Nitin Mehta
Yes, congrats all and welcome onboard.
While working on these projects please do not hesitate to ask questions.
Please add/correct documentation, ask questions on coding practices and
logic, fix/file bugs if you see any.
Hope you guys have a lot of fun :)

On 28/05/13 12:53 PM, "Venkata SwamyBabu Budumuru"
 wrote:

>Congrats all!
>
>On 28/05/13 12:53 AM, "Sebastien Goasguen"  wrote:
>
>>Hi,
>>
>>I am pleased to report that the following projects have been accepted by
>>the 2013 Google Summer of Code:
>>
>>"CloudStack: LDAP user provisioning", Ian Duffy
>>
>>"Improving CloudStack support in Apache Whirr and Apache Provisionr
>>incubating", Meng Han
>>
>>"Integration project to deploy and use Apache Mesos on a CloudStack based
>>Cloud" Dharmesh Kakadia
>>
>>"A New Modular UI for Apache CloudStack" Shiva Teja Reddy
>>
>>"Add Xen/XCP support for GRE SDN Controller" Nguyen Anh Tu
>>
>>Join me in congratulating all five and welcoming them to the Apache
>>CloudStack community this summer.
>>
>>Abhi, Kelcey, Hugo and Myself will be their mentors but if you see
>>questions from any of these five students feel free to jump in and help
>>them out.
>>
>>Happy coding,
>>
>>Cheers,
>>
>>-Sebastien
>



Re: 4.2 snapshot: setting up ISOs - no go

2013-05-30 Thread Nitin Mehta
I don¹t know the UI doesn't show the status of the agent running on SSVM ?
This would greatly help the admin understand why the SSVM related
functionalities (like template, volume etc.) are not working.

I have created a UI bug - CLOUDSTACK-2760. Feel free to vote for this and
even bump the priority.


Thanks,
-Nitin

On 30/05/13 10:32 AM, "Prasanna Santhanam"  wrote:

>And everything in the 'by-far' most popular wiki on our project :)
>
>https://cwiki.apache.org/CLOUDSTACK/ssvm-troubleshooting.html
>
>On Wed, May 29, 2013 at 04:09:56PM -0700, Ahmad Emneina wrote:
>> also, when trying to add the iso, can you capture the output in the
>>ssvms'
>> cloud.out or cloud.log (cant remember which). It would be interesting to
>> see whats happening on the ssvm side of things.
>> 
>> 
>> On Wed, May 29, 2013 at 2:41 PM, Edison Su  wrote:
>> 
>> > Can you try:
>> > select status from host where type = 'SecondaryStorageVM';
>> > in db?
>> >
>> > Make sure the agent in ssvm can connect back to mgt serer.
>> >
>> > > -Original Message-
>> > > From: La Motta, David [mailto:david.lamo...@netapp.com]
>> > > Sent: Wednesday, May 29, 2013 2:28 PM
>> > > To: 
>> > > Subject: 4.2 snapshot: setting up ISOs - no go
>> > >
>> > > So my 4.2 instance is up and running, system VMs are running
>>(secondary
>> > > storage VM and console proxy VM), primary and secondary storage are
>>up
>> > > on NFS... all things considered and at a glance, things look good.
>> >  However,
>> > > when I try to add an ISO so that I can provision a VM, I am getting:
>> > >
>> > > WARN  [storage.download.DownloadMonitorImpl] (1018141210@qtp-
>> > > 2013781391-38:) There is no secondary storage VM for secondary
>>storage
>> > > host nfs://172.20.39.74/SnapCreator_secondary
>> > >
>> > > Which is throwing me off, because the secondary storage VM seems to
>>be
>> > > up and happy.  I can see it on XenCenter alive and well, too.  When
>>I go
>> > > through the ISO registration wizard, registration seems to be
>>successful
>> > in
>> > > the UI, since the ISOs get added to the templates table--except I
>>get the
>> > > warning in the console above.
>> > >
>> > > If I try to add another secondary storage, I get:
>> > >
>> > > ERROR [cloud.api.ApiServer] (126087@qtp-2013781391-40:)
>>unhandled
>> > > exception executing api command: addSecondaryStorage
>> > > com.cloud.utils.exception.CloudRuntimeException: Cannot transit
>>agent
>> > > status with event AgentDisconnected for host 9, mangement server id
>>is
>> > > 271423992217301,Unable to transition to a new state from Creating
>>via
>> > > AgentDisconnected at
>> > > com.cloud.agent.manager.AgentManagerImpl.agentStatusTransitTo(Agent
>> > > ManagerImpl.java:1436)
>> > >
>> > >
>> > > When in doubt, reboot, right?  So I shutdown my CS mgmt server and
>> > > XenServer host and tried again.  I even added more secondary storage
>> > > without anything in it (the first NFS volume had the system VM
>>template
>> > on
>> > > it).  Still, I get the same behavior as described above:  the UI
>>says
>> > the ISO was
>> > > added, but the log file warns about the lack of a secondary storage
>>VM.
>> > >
>> > > If I attempt to go through the instance provisioning wizard, long
>>and
>> > behold,
>> > > the ISO is not listed in the "My ISOs" tab.
>> > >
>> > >
>> > > There is also something strange that I've noticed (slightly off
>>topic):
>> > if I have
>> > > primary storage allocated and resize the underlying volume on the
>>storage
>> > > controller, CS doesn't see the new size.  Is there any way to force
>>that
>> > to take
>> > > place from the UI?  Clicking on refresh did nothing about it.
>> > >
>> > > Thanks!
>> > >
>> > >
>> > >
>> > > David La Motta
>> > > Technical Marketing Engineer - Citrix
>> > >
>> > > NetApp
>> > > 919.476.5042
>> > > dlamo...@netapp.com
>> > >
>> > >
>> >
>> >
>
>-- 
>Prasanna.,
>
>
>Powered by BigRock.com
>



Re: 4.2 snapshot: setting up ISOs - no go

2013-05-30 Thread Nitin Mehta
David - Can you please follow
https://cwiki.apache.org/CLOUDSTACK/ssvm-troubleshooting.html to
troubleshoot the issues ?
Let us know how it goes ?

On 30/05/13 7:02 PM, "La Motta, David"  wrote:

>Hi EdisonŠ
>
>The table is empty, which would indicate the error message I see on the
>console is accurate.  However, that I see the VM running in XenServer and
>I have it listed in the Infrastructure area in CS doesn't make much sense.
>
>
>
>David La Motta
>Technical Marketing Engineer
>Citrix Solutions
>
>NetApp
>919.476.5042
>dlamo...@netapp.com
>
>
>
>On May 29, 2013, at 5:41 PM, Edison Su
>mailto:edison...@citrix.com>>
> wrote:
>
>Can you try:
>select status from host where type = 'SecondaryStorageVM';
>in db?
>
>Make sure the agent in ssvm can connect back to mgt serer.
>
>-Original Message-
>From: La Motta, David [mailto:david.lamo...@netapp.com]
>Sent: Wednesday, May 29, 2013 2:28 PM
>To: mailto:dev@cloudstack.apache.org>>
>Subject: 4.2 snapshot: setting up ISOs - no go
>
>So my 4.2 instance is up and running, system VMs are running (secondary
>storage VM and console proxy VM), primary and secondary storage are up
>on NFS... all things considered and at a glance, things look good.
>However,
>when I try to add an ISO so that I can provision a VM, I am getting:
>
>WARN  [storage.download.DownloadMonitorImpl] (1018141210@qtp-
>2013781391-38:) There is no secondary storage VM for secondary storage
>host nfs://172.20.39.74/SnapCreator_secondary
>
>Which is throwing me off, because the secondary storage VM seems to be
>up and happy.  I can see it on XenCenter alive and well, too.  When I go
>through the ISO registration wizard, registration seems to be successful
>in
>the UI, since the ISOs get added to the templates table--except I get the
>warning in the console above.
>
>If I try to add another secondary storage, I get:
>
>ERROR [cloud.api.ApiServer] (126087@qtp-2013781391-40:) unhandled
>exception executing api command: addSecondaryStorage
>com.cloud.utils.exception.CloudRuntimeException: Cannot transit agent
>status with event AgentDisconnected for host 9, mangement server id is
>271423992217301,Unable to transition to a new state from Creating via
>AgentDisconnected at
>com.cloud.agent.manager.AgentManagerImpl.agentStatusTransitTo(Agent
>ManagerImpl.java:1436)
>
>
>When in doubt, reboot, right?  So I shutdown my CS mgmt server and
>XenServer host and tried again.  I even added more secondary storage
>without anything in it (the first NFS volume had the system VM template on
>it).  Still, I get the same behavior as described above:  the UI says the
>ISO was
>added, but the log file warns about the lack of a secondary storage VM.
>
>If I attempt to go through the instance provisioning wizard, long and
>behold,
>the ISO is not listed in the "My ISOs" tab.
>
>
>There is also something strange that I've noticed (slightly off topic):
>if I have
>primary storage allocated and resize the underlying volume on the storage
>controller, CS doesn't see the new size.  Is there any way to force that
>to take
>place from the UI?  Clicking on refresh did nothing about it.
>
>Thanks!
>
>
>
>David La Motta
>Technical Marketing Engineer - Citrix
>
>NetApp
>919.476.5042
>dlamo...@netapp.com>
>
>
>
>



Re: Create View Question

2013-05-30 Thread Nitin Mehta
Sorry for missing the mail. I would need the new volume view for my
feature to work.

On 24/05/13 1:45 AM, "Min Chen"  wrote:

>It is related to this commit d1642a489ce76e055d60b2caf3ccfe4bb136b745.
>Schema-410to420.sql should have one section to define the new volume_view
>for 4.2.0. 
>CC Nitin here to see if his new volume_view should be used or the one
>before his commit in this file.
>
>THanks
>-min
>
>
>On 5/23/13 12:50 PM, "Mike Tutkowski" 
>wrote:
>
>>Hi,
>>
>>I've added a few fields (min, max, burst IOPS) to two tables and - in the
>>process - noticed the following view is dropped and created twice:
>>
>>DROP VIEW IF EXISTS `cloud`.`volume_view`;
>>CREATE VIEW `cloud`.`volume_view` AS
>>
>>I assume this is a bug and have removed (in my sandbox) the
>>first occurrence.
>>
>>If anyone knows of a reason why we want to keep this code as is, please
>>let
>>me know as this change will otherwise be submitted when I submit my code
>>for review tomorrow or early next week.
>>
>>Thanks!
>>
>>-- 
>>*Mike Tutkowski*
>>*Senior CloudStack Developer, SolidFire Inc.*
>>e: mike.tutkow...@solidfire.com
>>o: 303.746.7302
>>Advancing the way the world uses the
>>cloud
>>**
>



Re: maintenance mode for secondary storage?

2013-05-30 Thread Nitin Mehta
Not that I have heard of. You can at best replace the sec. storage (there
is a manual procedure for that), but since generally there is a single
sec. storage how can you implement maintenance mode ?
Can you please explain is your use case ?

On 30/05/13 7:32 PM, "Daan Hoogland"  wrote:

>LS,
>
>Has there ever been discussion about implementing maintenance mode for
>secondary storage? And are people thinking about this?
>
>thanks
>Daan Hoogland



Re: Inconsistent error while creating instances

2013-06-02 Thread Nitin Mehta
Refer to this - 
http://mail-archives.apache.org/mod_mbox/incubator-cloudstack-dev/201303.mb
ox/%3c67ef18fdca335f489b366120481ab6c5f6be740...@banpmailbox01.citrite.net%
3E 

On 01/06/13 4:18 AM, "Ahmad Emneina"  wrote:

>I've hit this in the past when there was a mismatch between the actual
>guest os and what i provided as the guest os type (in cloudstack).
>
>
>On Fri, May 31, 2013 at 8:30 AM, Pranav Saxena
>wrote:
>
>> Are your systemVms up and running fine ? Is your XS host a brand new
>>setup
>> ? Do you have the vhd-util file present at /opt/xensource/bin in your
>>host ?
>>
>> -Original Message-
>> From: Gaurav Aradhye [mailto:gaurav.arad...@clogeny.com]
>> Sent: Friday, May 31, 2013 7:11 PM
>> To: dev@cloudstack.apache.org
>> Subject: Inconsistent error while creating instances
>>
>> Hi,
>>
>> I am getting following error while creating instances through test
>>cases.
>> The error is not reproducible each time, but the typical scenario is
>>while
>> creating two or more instances consecutively.
>>
>> Error info says "*Bootloader.Bad_error*"
>>
>> The error is produced for each available host, eventually adding that
>>host
>> to "Avoid Set" and finally it fails to create the instance because every
>> host is in avoid set and the management log gives exception -
>> "InsufficientServerCapacityException".
>>
>> Has anybody encountered this error before? It will be great if someone
>>can
>> provide directions on this.
>>
>> *Error details:*
>> *
>> *
>> WARN [xen.resource.CitrixResourceBase] (DirectAgent-155:null) Unable to
>> start i-553-469-QA due to
>> com.cloud.utils.exception.CloudRuntimeException: Unable to start
>> VM(i-553-469-QA) on host(35d9b483-9a19-4a91-a0a6-bfe138e79db4) due to
>>Task
>> failed! Task record:
>>  uuid: 9e350b27-f9a5-30c0-bad8-d23bc7f80568
>>nameLabel: Async.VM.start_on
>>  nameDescription:
>>allowedOperations: []
>>currentOperations: {}
>>  created: Sun May 12 17:58:14 PDT 2013
>> finished: Sun May 12 17:58:19 PDT 2013
>>   status: failure
>>   residentOn: com.xensource.xenapi.Host@5848f813
>> progress: 1.0
>> type: 
>>   result:
>>errorInfo: [INTERNAL_ERROR, xenopsd internal error: VM =
>> 1110c003-1d45-5ab5-226f-952aa95630a0; domid = 393; Bootloader.Bad_error
>> Traceback (most rece nt call last):
>>   File "/usr/bin/pygrub", line 900, in ?
>> fs = fsimage.open(file, part_offs[0], bootfsoptions)
>> IOError: [Errno 95] Operation not supported ]
>>  otherConfig: {}
>>subtaskOf: com.xensource.xenapi.Task@aaf13f6f
>> subtasks: []
>>
>>
>> Regards,
>> Gaurav Aradhye
>>



Re: secondary storage questions

2013-06-03 Thread Nitin Mehta
All the public templates will be replicated to all the secondary storage
for redundancy but private templates and uploaded volumes should be kept
in one of the randomly chosen secondary storage. Snapshots will be
randomly copied to one of the secondary storage (the chain of incremental
snapshots are kept on the same secondary storage.). Currently these
algorithms are hardcoded and so in case you need flexibility please open
an enhancement for the same.


On 04/06/13 2:57 AM, "Marcus Sorensen"  wrote:

>Anyone?
>
>We are also noticing that if we register a template, that template is
>registered and ready, but becomes unusable if the URL for the template
>stops working at any time. Seems like we attempt to red download it every
>so often. So no one-time registration. Is this by design?

Whenever there is a handshake between MS and the agent running on the SSVM
there is a template sync which syncs the template status on the MS DB and
the template's physical Location and triggers the download if its not
complete or retries in case there was some error. (This handshake happens
on ssvm re/start, agent on SSVM re/start and MS re/start).


>On May 31, 2013 2:35 PM, "Marcus Sorensen"  wrote:
>
>> Sort of embarrassed to ask this, but I'm unclear on a few of the
>> aspects of secondary storage.
>>
>> 1) I can see that if I add multiple secondary storage locations, they
>> each get a copy of the registered templates. Are these copied from one
>> secondary storage to another, or from the url of the registered
>> template?

>From the url of the template. Should happen only for public templates. If
you see otherwise please file a bug.

>>
>> 2) It seems that the intent is to mirror templates across all
>> secondary storages, zone-wide, correct? But no copies are made for the
>> snapshots or volumes dirs. This may point to the idea that templates
>> are always downloaded via URLs

Multiple sec. storage are added for adding more storage and making public
templates highly available.
Templates are downloaded via URLs but can also be created from snapshots
and volumes

>>
>> 3) It sounds like the total size of secondary storage is somewhat
>> limited by templates, e.g. if all of you secondary storage is in
>> templates, adding another secondary storage server won't increase my
>> capacity, correct?

Not correct, as per explanation above.

>>



Re: [VOTE] Pushback 4.2.0 Feature Freeze

2013-06-03 Thread Nitin Mehta
+1, but hopefully only those features already proposed are allowed.
In future lets move the code freeze date before the freeze date :), makes
life easier for folks scrambling to get their feature in.

Thanks,
-Nitin

On 04/06/13 10:47 AM, "Prasanna Santhanam"  wrote:

>+0 - similar concerns as Sebastien. I hope that we also don't
>introduce any new unproposed features, or architectural changes to 4.2
>at the end of the cycle, which this extension still is.
>
>Also - it's probably worth discussing a time based release with
>milestones beyond which feature proposals are frozen and ones after
>which the code is frozen.
>
>-- 
>Prasanna.,
>
>On Mon, Jun 03, 2013 at 05:33:10PM -0400, Sebastien Goasguen wrote:
>> -0 [binding]
>> 
>> I am torn between sticking to the schedule and delay to make sure we
>>can merge things cleanly.
>> Would rather not merge and release on-time, but it would be a pitty.
>> 
>> On Jun 3, 2013, at 5:09 PM, Kevin Kluge  wrote:
>> 
>> > +1 [ binding ]
>> > 
>> > I've been concerned that releases every four months were too
>> > aggressive for people to absorb given the complexity of some
>> > deployments and upgrades.  With the current 4.1 delay and 4.2 plan
>> > we would expect two major releases within two months of each
>> > other.  I'd prefer a bigger date shift for 4.2, but I see little
>> > appetite for that in these discussions.  So I will +1 this
>> > proposal as a reasonable compromise.
>> > 
>> > FWIW I doubt we'll get many more features in 4.2 with this.  As
>> > Animesh noted the feature proposal date has passed so we have an
>> > upper bound on the additional changes for this four weeks.  I
>> > believe this proposal will improve the quality of 4.2 on its
>> > planned release date as a result.
>> > 
>> > -kevin
>> > 
>
>
>Powered by BigRock.com
>



Re: [GSoC] Accounts vs User

2013-06-09 Thread Nitin Mehta
In addition, please refer to the wiki below. Feel free to add
https://cwiki.apache.org/CLOUDSTACK/accounts-domains-and-admin-explained.ht
ml

Thanks,
-Nitin

On 09/06/13 10:03 PM, "Abhinandan Prateek"  wrote:

>Ian,
>
>In cloudstack a "Domain" is a unit of isolation that represents a
>customer org, business unit or a reseller.
>A domain can have arbitrary level of sub-domains.
>
>A domain can have one or more accounts. A account is the basic unit of
>isolation. Multiple users can exists in an account.
>Users are like aliases for the account. Users in the same account are not
>isolated from the other users. To access the account you should have at
>least one user that is why you create a user when you create a account.
>
>The resource limits can be set at account or at domain levels by the
>admin.
>
>I don't think we can get account resource limits directly from LDAP, but
>we can have the admin set these up later. We need to figure out the most
>efficient way to map ldap users to domains/accounts/users.
>
>
>-abhi
>
>On 09/06/13 5:30 PM, "Ian Duffy"  wrote:
>
>>Hi,
>>
>>I was just wondering about the difference between an "account" and a
>>"user", the naming of and layout to me seems unclear.
>>
>>When you navigate to Accounts and click "Add Account" it creates an
>>account with the given information and a user.
>>
>>When you open up the Account you have just created you are able to add
>>multiple users to it, each with a different username, firstname,
>>lastname, email, firstname and timezone. They have the same domain I
>>am unsure about network domain as it is left unshown.
>>
>>Am I correct in thinking:
>>1) An account is more like a group.
>>2) An account/group can not exist without one user (Why does this
>>limitation exist? Surely we should be able to provision groups without
>>having users to assign to them just yet)
>>3) An account/group outlines limits for its user
>>4) A user must be part of an account
>>
>>For the sake of LDAP intergration how should this be done? LDAP
>>wouldn't really contain the neccessary information to populate an
>>"account/group" i.e. limits.
>>
>>Thanks!
>
>



Re: StoragePoolForMigrationResponse and StoragePoolResponse

2013-06-09 Thread Nitin Mehta
Ideally, we shouldn't be muddling the storage pool response here for this
attribute. We should try and move away from including all the various
attributes for the resource and make it one huge monolithic response. We
should include only the first class attributes, say the name, URI etc. in
the storagePoolResponse.

Also to list other attributes which do not make it in the first class
attribute list, we should design a new response which is generic enough to
take in additional attributes added, may be something like
storagePoolDetailsResponse.

Thanks,
-Nitin

On 07/06/13 10:35 PM, "Min Chen"  wrote:

>Maybe attribute is not accurate in this sense, but it is just some
>metadata related to a storage pool. Just like tags, or statistics (For
>example, AccountResponse), display to user flag (for example, displayVm in
>UserVMResponse) we have created for any other CloudStack Entity. We didn't
>need to create a different Response class just to include or exclude this
>information to make it over complicated.
>
>Thanks
>-min
>
>On 6/6/13 11:33 PM, "Devdeep Singh"  wrote:
>
>>suitableformigration isn't an attribute of the storage pool. It just
>>tells whether a particular pool is suitable for migrating a particular
>>volume. For example, if volume A has to be migrated to another pool, then
>>the pools available are listed and if the tags on the pool and volume do
>>not match then it is flagged as unsuitable. For another volume it may be
>>flagged suitable. So it really isn't an attribute of a storage pool and I
>>believe it doesn't belong in the StoragePoolResponse object.
>>
>>Regards,
>>Devdeep
>>
>>> -Original Message-
>>> From: Min Chen [mailto:min.c...@citrix.com]
>>> Sent: Friday, June 07, 2013 2:20 AM
>>> To: dev@cloudstack.apache.org
>>> Subject: Re: StoragePoolForMigrationResponse and StoragePoolResponse
>>> 
>>> I agree with Prasanna on this. We don't need to introduce several
>>>Storage
>>> pool related responses just for some specific apis. In some way,
>>> suitableFormigration is some kind of attribute that can be set on a
>>>storage
>>> pool or not. If you don't want to show it to listStoragePool call, you
>>>can set that
>>> as null so that json serialization will ignore it.
>>> 
>>> Just my two cents.
>>> -min
>>> 
>>> On 6/6/13 5:07 AM, "Devdeep Singh"  wrote:
>>> 
>>> >Hi,
>>> >
>>> >StoragePoolResponse should really only be used for listing storage
>>>pools.
>>> >Putting a suitableformigration flag etc. makes it weird for other
>>>apis.
>>> >If tomorrow the response object is updated to include more statistics
>>> >for admin user to make a better decision, then such information gets
>>> >pushed in there which makes it unnatural for apis that just need the
>>> >list of storage pools. I am planning to update
>>> >StoragePoolForMigrationResponse to include the StoragePoolResponse
>>> >object and any other flag; suitableformigration in this case. I'll
>>>file a bug for
>>> the same.
>>> >
>>> >Regards,
>>> >Devdeep
>>> >
>>> >> -Original Message-
>>> >> From: Prasanna Santhanam [mailto:t...@apache.org]
>>> >> Sent: Tuesday, June 04, 2013 2:28 PM
>>> >> To: dev@cloudstack.apache.org
>>> >> Subject: Re: StoragePoolForMigrationResponse and StoragePoolResponse
>>> >>
>>> >> On Fri, May 31, 2013 at 06:28:39PM +0530, Prasanna Santhanam wrote:
>>> >> > On Fri, May 31, 2013 at 12:24:20PM +, Pranav Saxena wrote:
>>> >> > > Hey Prasanna ,
>>> >> > >
>>> >> > > I see that the response  object name is
>>> >> > > findstoragepoolsformigrationresponse , which is correct as shown
>>> >> > > below .  Are you referring to this API or something else  ?
>>> >> > >
>>> >> > > http://MSIP:8096/client/api?command=findStoragePoolsForMigration
>>> >> > >
>>> >> > > >> >> > > cloud-stack-version="4.2.0-SNAPSHOT">
>>> >> > >
>>> >> > >  
>>> >> > >
>>> >> >
>>> >> > No that's what is shown to the user. I meant the class within
>>> >> > org.apache.cloudstack.api.response
>>> >> >
>>> >> Fixed with 0401774a09483354f5b8532a30943351755da93f
>>> >>
>>> >> --
>>> >> Prasanna.,
>>> >>
>>> >> 
>>> >> Powered by BigRock.com
>>> >
>>
>



Re: Object_Store storage refactor GoToMeeting Tomorrow

2013-06-10 Thread Nitin Mehta
Hi Min,
When you say tomorrow, what date is it 11th June or 12th ? Can the time be
preponed by an hour please - its too late here ?

Thanks,
-Nitin

On 11/06/13 11:06 AM, "Min Chen"  wrote:

>Hi there,
>
>To reach consensus on some remaining NFS cache issues on object_store
>storage refactor work in a more effective manner, John, Edison and I have
>scheduled a GoToMeeting tomorrow to discuss them over the phone, any
>interested parties are welcome to join and brainstorm. Here are detailed
>GTM information:
>
>Meeting Time: 10:30 AM ­ 12:30 PM PST
>
>Meeting Details:
>
>1.  Please join my meeting.
>https://www1.gotomeeting.com/join/188620897
>
>2.  Use your microphone and speakers (VoIP) - a headset is recommended.
>Or, call in using your telephone.
>
>United States: +1 (626) 521-0017
>United States (toll-free): 1 877 309 2070
>
>Access Code: 188-620-897
>Audio PIN: Shown after joining the meeting
>
>Meeting ID: 188-620-897
>
>GoToMeeting®
>Online Meetings Made Easy®
>
>Not at your computer? Click the link to join this meeting from your
>iPhone®, iPad® or Android® device via the GoToMeeting app.
>
>Thanks
>-min



Re: if anybody know how to restrict access to a specific zone

2013-06-11 Thread Nitin Mehta
William - good use case, CS has the ability to dedicate resources to an
account domain, but not restrict them. You can read about that here -
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Dedicated+Resources+
-+Private+zone%2C+pod%2C+cluster%2C+host+Functional+Spec

Do you want to raise an enhancement for restricting a domain/account to a
zone ?

Thanks,
-Nitin

On 12/06/13 3:47 AM, "William Jiang"  wrote:

>Hi,
>
>if anybody know how to restrict access to a specific zone? We have
>multiple zone in our cloudstack 3.0 and I want to give access to a user
>to see only a specific zone.
>
>Thanks,
>William
>This e-mail may be privileged and/or confidential, and the sender does
>not waive any related rights and obligations. Any distribution, use or
>copying of this e-mail or the information it contains by other than an
>intended recipient is unauthorized. If you received this e-mail in error,
>please advise me (by return e-mail or otherwise) immediately. Ce courrier
>?lectronique est confidentiel et prot?g?. L'exp?diteur ne renonce pas aux
>droits et obligations qui s'y rapportent. Toute diffusion, utilisation ou
>copie de ce message ou des renseignements qu'il contient par une personne
>autre que le (les) destinataire(s) d?sign?(s) est interdite. Si vous
>recevez ce courrier ?lectronique par erreur, veuillez m'en aviser
>imm?diatement, par retour de courrier ?lectronique ou par un autre moyen.



Re: Review Request: fix for CLOUDSTACK-2347: Zone filter for listSnapshots API

2013-06-12 Thread Nitin Mehta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11820/#review21783
---

Ship it!


Ship It!

- Nitin Mehta


On June 12, 2013, 7:12 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11820/
> ---
> 
> (Updated June 12, 2013, 7:12 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, Nitin Mehta, and Koushik 
> Das.
> 
> 
> Description
> ---
> 
> CLOUDSTACK-2347:  Zone filter for listSnapshots API 
> 
> Added new optional parameter zone id in listSnapshots API which allows to 
> list snapshots with additional criteria.
> 
> 
> This addresses bug CLOUDSTACK-2347.
> 
> 
> Diffs
> -
> 
>   
> api/src/org/apache/cloudstack/api/command/user/snapshot/ListSnapshotsCmd.java 
> d7e6bc8 
>   api/src/org/apache/cloudstack/api/response/SnapshotResponse.java 7484ac9 
>   server/src/com/cloud/api/ApiResponseHelper.java 0c98abc 
>   server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java 92d80ee 
> 
> Diff: https://reviews.apache.org/r/11820/diff/
> 
> 
> Testing
> ---
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>



Re: Review Request: Fix a logging issue in my previsous hypervisor template code.

2013-06-13 Thread Nitin Mehta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11052/#review21898
---



server/src/com/cloud/template/HypervisorTemplateAdapter.java
<https://reviews.apache.org/r/11052/#comment45190>

Why put this log for the cmd when its going to be logged by default ?



server/src/com/cloud/template/HypervisorTemplateAdapter.java
<https://reviews.apache.org/r/11052/#comment45191>

I would expect atleast logging or throwing the same exception...else we are 
just hiding the exception.
Same for the commented statement below.


- Nitin Mehta


On June 13, 2013, 10:55 p.m., Fang Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11052/
> ---
> 
> (Updated June 13, 2013, 10:55 p.m.)
> 
> 
> Review request for cloudstack, edison su and Kelven Yang.
> 
> 
> Description
> ---
> 
> As Alex pointed out, I need not to log the stacktrace in the 
> hypervisorTemplateAdapter method to obtain the OVA packing. Fix it and remove 
> the logging. 
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/template/HypervisorTemplateAdapter.java 322f32e 
> 
> Diff: https://reviews.apache.org/r/11052/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Fang Wang
> 
>



Re: Regarding ssvm-check script

2013-06-13 Thread Nitin Mehta
Hi Rajesh,
Please find my comments inline

On 13/06/13 10:40 PM, "Rajesh Battala"  wrote:

>Hi All,
>While fixing an issue ( https://reviews.apache.org/r/11862/ )in
>ssvm-check script I figured out some issues.
>
>1.There are two ssvm_check scripts(duplicates).
>
>./services/console-proxy/server/scripts/ssvm-check.sh
>./services/secondary-storage/scripts/ssvm-check.sh
>
>When building the code, these scripts will go to systemvm.zip,
>systemvm.zip will be packaged into systemvm.iso.
>
>systemvm-descriptor.xml will define what all the scripts should package.
>As per the descriptor xml,  the ssvm-check script under console-proxy is
>getting into systemvm.zip.

Shouldn't it be the other way round ? I mean the ssvm script under
secondary-storage should have come in ?

>
>I had verified the ssvm-check script with the fix under console-proxy.
>The systemvm.zip is getting update properly and making into systemvm.iso.
>And ssvm is getting the right script now.
>
>Changes made in script under
>./services/secondary-storage/scripts/ssvm-check.sh is not getting into
>systemvm.iso
>
>I feel the script is redundant and creating confusion.
>Can we remove the script in one location?

I would remove it from console-proxy for the sake of consistency and make
sure the one under secondary-storage gets in. Also while doing so
hopefully the final location (folder structure) of the script is not
disturbed in the ssvm

>
>Thanks
>Rajesh Battala



Re: Object_Store storage refactor Meeting Notes

2013-06-14 Thread Nitin Mehta


On 13/06/13 10:08 PM, "John Burwell"  wrote:

>All,
>
>Edison Su, Min Chen, Animesh Chaturvedi, and myself met via
>teleconference on 11 June 2013 @ 1:30 PM EDT.  The goal of the meeting
>was determine the path forward for merging the object_store branch by the
>4.2 freeze date, 30 June 2013.  The conversation focused on the following
>topics:
>
>   * Staging area mechanism
>   * Removing dependencies from the Storage to the Hypervisor layer
>   * Dependencies of other patches on object_store
>   * QA's desire to start testing the patch ASAP
>
>Min, Edison, and I agreed that the staging mechanism must age out files
>and use a reference count to ensure that file in-use are not prematurely
>purged.  While we agree that some form of reservation system is required,
>Edison is concerned that it will be too conservative and create
>bottlenecks.  

Can you please elaborate on the fact that it is too conservative - we just
can't purge the files when they are still in use correct ? We can use a
combination of LRU + reference count, trying to purge the LRU files if
their reference count <= 0 as a start ?

>
>As we delved deeper into the subject of the storage to hypervisor
>dependencies and the reservation mechanism, we determined that NFS
>storage would still need to be the size of the secondary storage data
>set.  Since the hypervisor layer has not been completely fitted to the
>new storage layer, NFS would be still required for a number of
>operations.  Based on this realization, we decided to de-scope the
>staging mechanism, and leave the 4.2 object store functionality the same
>as 4.1.  Therefore, NFS will remain the secondary storage of record, and
>object storage will serve as backup/multi-zone sync.

I am not sure how we can comment its going to be the same as 4.1 - is it
from the end user perspective ? The internal semantics and their flow have
changed. This needs to be elaborated and properly documented. Also I am
not sure if the feature is supported on the upgrade path or is it ? Need
more documentation here.


>In 4.3, we will fit the hypervisor layer for the new storage layer which
>will allow object stores to server as secondary storage.  This work will
>include removing the storage to hypervisor dependencies.  For 4.2, Edison
>and Min have implemented the critical foundation necessary to establish
>our next generation storage layer.  There simply was not enough time in
>this development cycle to make these changes and fit the hypervisor layer.
>
>Due to the size of the patch, Animesh voiced QA's concerned regarding
>test scope and impact.  As such, we want to get the merge completed as
>soon as possible to allow testing to begin.  We discussed breaking up the
>patch, but we could not devise a reasonable set of chunks there were both
>isolated and significantly testable.  Therefore, the patch can only be
>delivered in its current state.  We also walked through potential
>dependencies between the storage framework changes and the solidfire
>branch.  It was determined that these two merges could occur
>independently.
>
>Finally, Animesh is going to setup a meeting at Citrix's Santa Clara
>office on 26 June 2013 (the day after Collab ends) to discuss the path
>forward for 4.3 and work through a high-level design/approach to fitting
>the hypervisor layer to exploit the new storage capabilities.  Details
>will be published to the dev mailing list.
>
>Thanks,
>-John
>
>On Jun 11, 2013, at 2:08 AM, Min Chen  wrote:
>
>> It is 11th June. John is not free between 9:15am to 10am, that is why we
>> schedule it at 10:30am.
>> 
>> Thanks
>> -min
>> 
>> On 6/10/13 10:52 PM, "Nitin Mehta"  wrote:
>> 
>>> Hi Min,
>>> When you say tomorrow, what date is it 11th June or 12th ? Can the
>>>time be
>>> preponed by an hour please - its too late here ?
>>> 
>>> Thanks,
>>> -Nitin
>>> 
>>> On 11/06/13 11:06 AM, "Min Chen"  wrote:
>>> 
>>>> Hi there,
>>>> 
>>>> To reach consensus on some remaining NFS cache issues on object_store
>>>> storage refactor work in a more effective manner, John, Edison and I
>>>>have
>>>> scheduled a GoToMeeting tomorrow to discuss them over the phone, any
>>>> interested parties are welcome to join and brainstorm. Here are
>>>>detailed
>>>> GTM information:
>>>> 
>>>> Meeting Time: 10:30 AM ­ 12:30 PM PST
>>>> 
>>>> Meeting Details:
>>>> 
>>>> 1.  Please join my meeting.
>>>> https://www1.gotomeeting.com/join/188620897
>>>> 
>>>> 2.  Use your microphone and speakers (VoIP) - a headset is
>>>>recommended.
>>>> Or, call in using your telephone.
>>>> 
>>>> United States: +1 (626) 521-0017
>>>> United States (toll-free): 1 877 309 2070
>>>> 
>>>> Access Code: 188-620-897
>>>> Audio PIN: Shown after joining the meeting
>>>> 
>>>> Meeting ID: 188-620-897
>>>> 
>>>> GoToMeeting®
>>>> Online Meetings Made Easy®
>>>> 
>>>> Not at your computer? Click the link to join this meeting from your
>>>> iPhone®, iPad® or Android® device via the GoToMeeting app.
>>>> 
>>>> Thanks
>>>> -min
>>> 
>> 
>



Re: Review Request: Fixed CLOUDSTACK-3004 [script] ssvm_check remove the duplicate file from consoleproxy and include the script from secondary storage folder while packing iso

2013-06-14 Thread Nitin Mehta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11874/#review21905
---

Ship it!


Ship It!

- Nitin Mehta


On June 14, 2013, 10:09 a.m., Rajesh Battala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11874/
> ---
> 
> (Updated June 14, 2013, 10:09 a.m.)
> 
> 
> Review request for cloudstack and Chip Childers.
> 
> 
> Description
> ---
> 
> Issue: .There are two ssvm_check scripts(duplicates).
> 
> ./services/console-proxy/server/scripts/ssvm-check.sh
> ./services/secondary-storage/scripts/ssvm-check.sh
> 
> When building the code, these scripts will go to systemvm.zip, systemvm.zip 
> will be packaged into systemvm.iso. 
> 
> systemvm-descriptor.xml will define what all the scripts should package.
> As per the descriptor xml,  the ssvm-check script under console-proxy is 
> getting into systemvm.zip.
> 
> I had verified the ssvm-check script with the fix under console-proxy. The 
> systemvm.zip is getting update properly and making into systemvm.iso.
> And ssvm is getting the right script now.
> 
> Changes made in script under 
> ./services/secondary-storage/scripts/ssvm-check.sh is not getting into 
> systemvm.iso
> 
> Fixed:
> Modified systemvm-descriptor.xml to pick the ssvm-check.sh form 
> ./services/secondary-storage/scripts/ssvm-check.sh
> removed the duplicate file which is creating confusion 
> (./services/console-proxy/server/scripts/ssvm-check.sh)
> 
> 
> This addresses bug CLOUDSTACK-3004.
> 
> 
> Diffs
> -
> 
>   services/console-proxy/server/scripts/ssvm-check.sh 7b83c98 
>   services/console-proxy/server/systemvm-descriptor.xml e34026b 
> 
> Diff: https://reviews.apache.org/r/11874/diff/
> 
> 
> Testing
> ---
> 
> Tested by generating the systemvm.zip , the ssvm-check file is getting copied 
> into the zip from the ./services/secondary-storage/scripts/ssvm-check.sh
> 
> 
> Thanks,
> 
> Rajesh Battala
> 
>



Re: Review Request: Fixed CLOUDSTACK-3004 [script] ssvm_check remove the duplicate file from consoleproxy and include the script from secondary storage folder while packing iso

2013-06-14 Thread Nitin Mehta


> On June 14, 2013, 2:44 p.m., Nitin Mehta wrote:
> > Ship It!

Hi Rajesh - I get the error below while trying to apply your fix. Could you 
please correct and resubmit ?
 
Nitins-MacBook-Air:cloudstack nitinmehta$ git apply --whitespace=fix 
../0001-CLOUDSTACK-3004-\[script\]-ssvm_check-remove-the-duplicate-file-from-consoleproxy-and-include-the-script-from-secondary-storage-folder-while-packing-iso.patch
 
error: patch failed: services/console-proxy/server/scripts/ssvm-check.sh:1
error: services/console-proxy/server/scripts/ssvm-check.sh: patch does not apply


- Nitin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11874/#review21905
---


On June 14, 2013, 10:09 a.m., Rajesh Battala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11874/
> ---
> 
> (Updated June 14, 2013, 10:09 a.m.)
> 
> 
> Review request for cloudstack and Chip Childers.
> 
> 
> Description
> ---
> 
> Issue: .There are two ssvm_check scripts(duplicates).
> 
> ./services/console-proxy/server/scripts/ssvm-check.sh
> ./services/secondary-storage/scripts/ssvm-check.sh
> 
> When building the code, these scripts will go to systemvm.zip, systemvm.zip 
> will be packaged into systemvm.iso. 
> 
> systemvm-descriptor.xml will define what all the scripts should package.
> As per the descriptor xml,  the ssvm-check script under console-proxy is 
> getting into systemvm.zip.
> 
> I had verified the ssvm-check script with the fix under console-proxy. The 
> systemvm.zip is getting update properly and making into systemvm.iso.
> And ssvm is getting the right script now.
> 
> Changes made in script under 
> ./services/secondary-storage/scripts/ssvm-check.sh is not getting into 
> systemvm.iso
> 
> Fixed:
> Modified systemvm-descriptor.xml to pick the ssvm-check.sh form 
> ./services/secondary-storage/scripts/ssvm-check.sh
> removed the duplicate file which is creating confusion 
> (./services/console-proxy/server/scripts/ssvm-check.sh)
> 
> 
> This addresses bug CLOUDSTACK-3004.
> 
> 
> Diffs
> -
> 
>   services/console-proxy/server/scripts/ssvm-check.sh 7b83c98 
>   services/console-proxy/server/systemvm-descriptor.xml e34026b 
> 
> Diff: https://reviews.apache.org/r/11874/diff/
> 
> 
> Testing
> ---
> 
> Tested by generating the systemvm.zip , the ssvm-check file is getting copied 
> into the zip from the ./services/secondary-storage/scripts/ssvm-check.sh
> 
> 
> Thanks,
> 
> Rajesh Battala
> 
>



Re: Review Request: Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status

2013-06-17 Thread Nitin Mehta
Roxanne/Abhi - Thanks for following up. I guess this should be resolved by
the Object Store work going on.
Edison/Min - Would we still be having an entry for the secondary storage
in the host table ?

Thanks,
-Nitin

On 17/06/13 12:01 PM, "Abhinandan Prateek"  wrote:

>
>
>> On June 17, 2013, 5:06 a.m., Abhinandan Prateek wrote:
>> > This is a old patch, is it still valid ?
>> 
>> Prasanna Santhanam wrote:
>> Hmm - quite embarrassing it is over 3 months old. We may have
>>missed a contributor :(
>> 
>> However should be valid still because the secondary storage host
>>still shows 'Alert' on all installs.
>> 
>> roxanne chang wrote:
>> It will be nice if the changes can help. And.. Is the new design
>>finished ?
>
>Roxanne,  you may have to redo the patch on the current master and
>resubmit as it fails to apply now.
>
>
>- Abhinandan
>
>
>---
>This is an automatically generated e-mail. To reply, visit:
>https://reviews.apache.org/r/9818/#review21971
>---
>
>
>On May 31, 2013, 1:01 a.m., roxanne chang wrote:
>> 
>> ---
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/9818/
>> ---
>> 
>> (Updated May 31, 2013, 1:01 a.m.)
>> 
>> 
>> Review request for cloudstack, Abhinandan Prateek and edison su.
>> 
>> 
>> Description
>> ---
>> 
>> Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert
>>status
>> [https://issues.apache.org/jira/browse/CLOUDSTACK-1594]
>> 
>> In file SecondarySotrageManagerImpl.java, function
>>generateSetupCommand, if the host type is Secondary storage VM, the
>>logic is to set secondarystorage host, at this time, secondarystorage
>>host stauts should become Up.
>> 
>> The secondary storage host always remains Alert status, because before
>>the secondary storage vm is deployed, the secondary storage host is
>>created. The tricky way (in the end of file AgentManagerImpl.java,
>>function NotifiMonitorsOfConnection) will try to disconnect secondary
>>storage, therefore the secondary storage host becomes Alert status. The
>>code should take SSVM into consider, not only Answer reponse.
>> 
>> File ResourceManagerImpl.java, function discoverHostsFull, in the end
>>will call discoverer.postDiscovery, in file
>>SecondarySotrageDiscover.postDiscovery, the condition _userServiceVM is
>>not needed since its use to make secondary storage host wait for SSVM is
>>already done in SecondaryStorageManagerImpl. This makes why secondary
>>storage host always remains Alert status.
>> 
>> 
>> This addresses bug
>>https://issues.apache.org/jira/browse/CLOUDSTACK-1594.
>> 
>> 
>> Diffs
>> -
>> 
>>   server/src/com/cloud/agent/manager/AgentManagerImpl.java c1bbb58
>>   
>>server/src/com/cloud/storage/secondary/SecondaryStorageDiscoverer.java
>>3ca74a3 
>>   
>>server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java
>>46ac7af 
>> 
>> Diff: https://reviews.apache.org/r/9818/diff/
>> 
>> 
>> Testing
>> ---
>> 
>> Test 4.0.0, 4.2.0 in basic mode, works well.
>> 
>> 
>> Thanks,
>> 
>> roxanne chang
>> 
>>
>



Re: Review Request: remove dead allocations

2013-06-17 Thread Nitin Mehta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11324/#review22040
---



api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java
<https://reviews.apache.org/r/11324/#comment45376>

Can the result returned be null ?


- Nitin Mehta


On June 17, 2013, 1:40 p.m., Dave Brosius wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11324/
> ---
> 
> (Updated June 17, 2013, 1:40 p.m.)
> 
> 
> Review request for cloudstack and Devdeep Singh.
> 
> 
> Description
> ---
> 
> code allocates a collection, and then immediately overwrites the reference 
> variable holding that collection. That original collection is just a dead 
> allocation, and is not needed - patch removes.
> 
> 
> Diffs
> -
> 
>   
> api/src/org/apache/cloudstack/api/command/admin/host/FindHostsForMigrationCmd.java
>  b2d77b8 
>   api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java 
> 69c6980 
>   
> api/src/org/apache/cloudstack/api/command/admin/region/ListPortableIpRangesCmd.java
>  75bcce0 
>   api/src/org/apache/cloudstack/api/command/user/iso/ListIsosCmd.java f872c12 
>   
> api/src/org/apache/cloudstack/api/command/user/template/ListTemplatesCmd.java 
> f0fc241 
> 
> Diff: https://reviews.apache.org/r/11324/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dave Brosius
> 
>



Re: [ANNOUNCE] New committer: Jayapal Reddy Uradi

2013-06-17 Thread Nitin Mehta
Congrats Jayapal :)

On 18/06/13 10:52 AM, "Sanjay Tripathi"  wrote:

>Congratulations Jayapal :)
>
>--Sanjay
>
>> -Original Message-
>> From: Chip Childers [mailto:chip.child...@sungard.com]
>> Sent: Monday, June 17, 2013 9:00 PM
>> To: dev@cloudstack.apache.org
>> Subject: [ANNOUNCE] New committer: Jayapal Reddy Uradi
>> 
>> The Project Management Committee (PMC) for Apache CloudStack has
>> asked Jayapal Reddy Uradi to become a committer and we are pleased to
>> announce that they have accepted.
>> 
>> Being a committer allows many contributors to contribute more
>> autonomously. For developers, it makes it easier to submit changes and
>> eliminates the need to have contributions reviewed via the patch
>>submission
>> process. Whether contributions are development-related or otherwise, it
>>is a
>> recognition of a contributor's participation in the project and
>>commitment to
>> the project and the Apache Way.
>> 
>> Please join me in congratulating Jayapal!
>> 
>> -chip
>> on behalf of the CloudStack PMC



Re: Review Request: CLOUDSTACK-1047: tracking in logs using job id

2013-06-17 Thread Nitin Mehta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11906/#review22043
---



server/src/com/cloud/async/AsyncJobManagerImpl.java
<https://reviews.apache.org/r/11906/#comment45380>

it would help if you just keep it as job-id because thats how we log it in 
the logs...would be consistent for someone grepping for logs using job-id



server/src/com/cloud/async/AsyncJobManagerImpl.java
<https://reviews.apache.org/r/11906/#comment45379>

can this be put in the check above starting with 
if (job != null) {



server/src/com/cloud/async/AsyncJobManagerImpl.java
<https://reviews.apache.org/r/11906/#comment45381>

As said above please keep it as job-id



server/src/com/cloud/async/AsyncJobManagerImpl.java
<https://reviews.apache.org/r/11906/#comment45382>

what if jobuuid = null


- Nitin Mehta


On June 17, 2013, 11:41 a.m., Sanjay Tripathi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11906/
> ---
> 
> (Updated June 17, 2013, 11:41 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh, Nitin Mehta, and Sateesh 
> Chodapuneedi.
> 
> 
> Description
> ---
> 
> CLOUDSTACK-1047: tracking in logs using job id
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-1047
> 
> 
> This addresses bug CLOUDSTACK-1047.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/async/AsyncJobManagerImpl.java 0101a8a 
>   server/src/com/cloud/storage/VolumeManagerImpl.java 4297efb 
> 
> Diff: https://reviews.apache.org/r/11906/diff/
> 
> 
> Testing
> ---
> 
> Tests:
> 1. Deploy an Instance.
> 2. In the Management server logs, check the async job description, it should 
> be somthing like: job-[ 22 ] = [ 1075d499-03a8-44c3-ac9e-348dc5b32ba1 ]
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>



Re: Review Request: Updated the user permission to acquire ip

2013-06-17 Thread Nitin Mehta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10727/#review19622
---



server/src/com/cloud/network/NetworkServiceImpl.java
<https://reviews.apache.org/r/10727/#comment40532>

Can we not use @ACL annotation for this ? 


- Nitin Mehta


On April 25, 2013, 8:43 a.m., Jayapal Reddy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10727/
> ---
> 
> (Updated April 25, 2013, 8:43 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Murali Reddy.
> 
> 
> Description
> ---
> 
> Updated the user permissions check
> 
> 
> This addresses bug CLOUDSTACK-2134.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/network/NetworkServiceImpl.java 7653a08 
> 
> Diff: https://reviews.apache.org/r/10727/diff/
> 
> 
> Testing
> ---
> 
> Unit tested on basic and advanced zone
> 
> 
> Thanks,
> 
> Jayapal Reddy
> 
>



Re: starting VM and get error of "unable to create a deployment for VM[user|i-2-107-VM]"

2013-06-18 Thread Nitin Mehta
Can you check the hypervisor admin guide to see if this version of guest
os is supported ?
Also can u please paste the complete logs (grep for job-626 would work as
well) 

On 18/06/13 8:15 PM, "William Jiang"  wrote:

>Hi,
>
>We have a Ubuntu 12.04 VM with one disk on shared storage, it was working
>well before but now we saw the error of "unable to create a deployment
>for VM[user|i-2-107-VM]" during starting.
>We saw this kind of issue happened on a windows server 2008 VM before.
>
>In /var/log/cloud/management/management-server.log
>We got following errors:
>
>2013-06-14 12:28:34,362 DEBUG [cloud.capacity.CapacityManagerImpl]
>(Job-Executor-16:job-626) We need to allocate to the last host again, so
>checking if there is enough reserved capacity
>2013-06-14 12:28:34,362 DEBUG [cloud.capacity.CapacityManagerImpl]
>(Job-Executor-16:job-626) Reserved CPU: 0 , Requested CPU: 1000
>2013-06-14 12:28:34,362 DEBUG [cloud.capacity.CapacityManagerImpl]
>(Job-Executor-16:job-626) Reserved RAM: 0 , Requested RAM: 1073741824
>2013-06-14 12:28:34,362 DEBUG [cloud.capacity.CapacityManagerImpl]
>(Job-Executor-16:job-626) STATS: Failed to alloc resource from host: 9
>reservedCpu: 0, requested cpu: 1000, reservedMem: 0, requested mem:
>1073741824
>2013-06-14 12:28:34,362 DEBUG [cloud.capacity.CapacityManagerImpl]
>(Job-Executor-16:job-626) Host does not have enough reserved CPU
>available, cannot allocate to this host.
>2013-06-14 12:28:34,362 DEBUG [cloud.deploy.FirstFitPlanner]
>(Job-Executor-16:job-626) The last host of this VM does not have enough
>capacity
>2013-06-14 12:28:34,362 DEBUG [cloud.deploy.FirstFitPlanner]
>(Job-Executor-16:job-626) Cannot choose the last host to deploy this VM
>
>Any ideas about this issue?
>
>Thanks,
>William
>This e-mail may be privileged and/or confidential, and the sender does
>not waive any related rights and obligations. Any distribution, use or
>copying of this e-mail or the information it contains by other than an
>intended recipient is unauthorized. If you received this e-mail in error,
>please advise me (by return e-mail or otherwise) immediately. Ce courrier
>?lectronique est confidentiel et prot?g?. L'exp?diteur ne renonce pas aux
>droits et obligations qui s'y rapportent. Toute diffusion, utilisation ou
>copie de ce message ou des renseignements qu'il contient par une personne
>autre que le (les) destinataire(s) d?sign?(s) est interdite. Si vous
>recevez ce courrier ?lectronique par erreur, veuillez m'en aviser
>imm?diatement, par retour de courrier ?lectronique ou par un autre moyen.



Re: Review Request: Fix for CLOUDSTACK-2987 Ensure XStools to be there in template inorder to enable dynamic scaling of vm

2013-06-18 Thread Nitin Mehta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11910/#review22110
---



api/src/com/cloud/agent/api/to/VirtualMachineTO.java
<https://reviews.apache.org/r/11910/#comment45509>

is this not the same attribute ?



api/src/org/apache/cloudstack/api/BaseUpdateTemplateOrIsoCmd.java
<https://reviews.apache.org/r/11910/#comment45510>

is this only for template or isos as well ? if both change the comment



api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java
<https://reviews.apache.org/r/11910/#comment45511>

change the comment



engine/schema/src/com/cloud/storage/VMTemplateVO.java
<https://reviews.apache.org/r/11910/#comment45513>

dynamically scalable instead of scalable?



engine/storage/src/org/apache/cloudstack/storage/image/TemplateEntityImpl.java
<https://reviews.apache.org/r/11910/#comment45514>

TODO ?



plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java
<https://reviews.apache.org/r/11910/#comment45515>

vmSpec.isEnableDynamicallyScaleVm() && 
details.get("isscalable").equals("true"))

Just one of them should do



server/src/com/cloud/vm/VirtualMachineManagerImpl.java
<https://reviews.apache.org/r/11910/#comment45516>

can u write a small utility function which fetches it from details table 
and does all this logic instead of muddling this function


- Nitin Mehta


On June 18, 2013, 7:05 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11910/
> ---
> 
> (Updated June 18, 2013, 7:05 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
> 
> 
> Description
> ---
> 
> CLOUDSTACK-2987 Ensure XStools to be there in template inorder to enable 
> dynamic scaling of vm 
> 
> CLOUDSTACK-3042 - handle Scaling up of vm memory/CPU based on the presence of 
> XS tools in the template
> This should also take care of updation of VM after XS tools are installed in 
> the vm and set memory values accordingly to support dynamic scaling after 
> stop start of VM
> 
> 
> This addresses bugs CLOUDSTACK-2987 and CLOUDSTACK-3042.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/agent/api/to/VirtualMachineTO.java 46ee01b 
>   api/src/com/cloud/template/VirtualMachineTemplate.java cedc793 
>   api/src/org/apache/cloudstack/api/ApiConstants.java ab1402c 
>   api/src/org/apache/cloudstack/api/BaseUpdateTemplateOrIsoCmd.java 6fd9773 
>   api/src/org/apache/cloudstack/api/command/user/iso/RegisterIsoCmd.java 
> 284d553 
>   
> api/src/org/apache/cloudstack/api/command/user/template/RegisterTemplateCmd.java
>  c9da0c2 
>   api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java 2860283 
>   api/src/org/apache/cloudstack/api/response/TemplateResponse.java 896154a 
>   api/src/org/apache/cloudstack/api/response/UserVmResponse.java 1f9eb1a 
>   core/src/com/cloud/agent/api/ScaleVmCommand.java b361485 
>   engine/schema/src/com/cloud/storage/VMTemplateVO.java e643d75 
>   engine/schema/src/com/cloud/vm/VMInstanceVO.java fbe03dc 
>   
> engine/storage/src/org/apache/cloudstack/storage/image/TemplateEntityImpl.java
>  4d162bb 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/XenServerGuru.java 8c38a69 
>   
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
>  5e8283a 
>   
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java
>  8e37809 
>   server/src/com/cloud/api/ApiResponseHelper.java 94c5d6c 
>   server/src/com/cloud/api/query/dao/UserVmJoinDaoImpl.java dbfe94d 
>   server/src/com/cloud/api/query/vo/UserVmJoinVO.java 8ad0fdd 
>   server/src/com/cloud/hypervisor/HypervisorGuruBase.java 1ad9a1f 
>   server/src/com/cloud/server/ManagementServerImpl.java 96c72e4 
>   server/src/com/cloud/storage/TemplateProfile.java 0b55f1f 
>   server/src/com/cloud/template/TemplateAdapter.java 9a2d877 
>   server/src/com/cloud/template/TemplateAdapterBase.java 0940d3e 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 1c8ab75 
>   server/src/com/cloud/vm/VirtualMachineManagerImpl.java f946cd1 
>   server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 8715c9e 
>   setup/db/db/schema-410to420.sql 272fc42 
> 
> Diff: https://reviews.apache.org/r/11910/diff/
> 
> 
> Testing
> ---
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>



Re: NFS Cache storage query

2013-06-19 Thread Nitin Mehta
Agree with Min. How about CRUD operations on staging - all apis available ?

Thanks,
-Nitin

On 19/06/13 6:44 AM, "Min Chen"  wrote:

>Edison, we can just add a parameter in listImageStoreCmd to show cache
>store.
>
>Thanks
>-min
>
>On 6/18/13 6:06 PM, "Edison Su"  wrote:
>
>>Currently, no, I can add an API for it.
>>
>>> -Original Message-
>>> From: Jessica Wang [mailto:jessica.w...@citrix.com]
>>> Sent: Tuesday, June 18, 2013 4:24 PM
>>> To: Min Chen
>>> Cc: dev@cloudstack.apache.org
>>> Subject: RE: NFS Cache storage query
>>> 
>>> Min,
>>> 
>>> > We may need to provide a way from UI to allow users to configure and
>>> display their NFS cache.
>>> Is there an API that list NFS cache?
>>> 
>>> Jessica
>>> 
>>> -Original Message-
>>> From: Min Chen
>>> Sent: Friday, June 14, 2013 9:26 AM
>>> To: dev@cloudstack.apache.org
>>> Cc: Jessica Wang
>>> Subject: Re: NFS Cache storage query
>>> 
>>> Hi Sanjeev,
>>> 
>>> In 4.2 release, we require that a NFS cache storage has to be added if
>>> you choose S3 as the storage provider since we haven't refactored
>>> hypervisor side code to handle s3 directly by bypassing NFS caching,
>>>which is
>>> the goal for 4.3 release. I see an issue with current UI, where user
>>>can only
>>> add cache storage when he/she adds a S3 storage. We may need to provide
>>> a way from UI to allow users to configure and display their NFS cache.
>>>You
>>> can file a JIRA ticket for this UI enhancement.
>>> 
>>> Thanks
>>> -min
>>> 
>>> On 6/14/13 6:35 AM, "Chip Childers"  wrote:
>>> 
>>> >On Fri, Jun 14, 2013 at 01:06:30PM +, Sanjeev Neelarapu wrote:
>>> >> Hi,
>>> >>
>>> >> I have a query on how to add NFS Cache storage.
>>> >> Before creating a zone if we create a secondary storage with s3 as
>>> >>the storage provider and don't select NFS Cache Storage then we treat
>>> >>it as
>>> >>S3 at region level.
>>> >> Later I create a zone and at "add secondary storage" creation wizard
>>> >>in UI if I select NFS as secondary storage provider will it be
>>>treated
>>> >>as NFS Cache Storage? If not is there a way to add NFS cache storage
>>> >>for that zone?
>>> >>
>>> >> Thanks,
>>> >> Sanjeev
>>> >>
>>> >
>>> >Based on the thread talking about this [1], I'm not sure that it will
>>> >be implemented this way anymore.
>>> >
>>> >-chip
>>> >
>>> >[1] http://markmail.org/message/c73nagj45q6iktfh
>>
>



Re: Review Request: Fix for CLOUDSTACK-2181: Scale down is allowed, which is not expected

2013-06-20 Thread Nitin Mehta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11936/#review22158
---

Ship it!


Ship It!

- Nitin Mehta


On June 18, 2013, 2:38 p.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11936/
> ---
> 
> (Updated June 18, 2013, 2:38 p.m.)
> 
> 
> Review request for cloudstack and Nitin Mehta.
> 
> 
> Description
> ---
> 
> CLOUDSTACK-2181: Scale down is allowed when one resource(say cpu) is being 
> scale up and other resource (say ram) is
>  being scale down ;but not allowed when both resources are being scaledown
> 
> 
> This addresses bug CLOUDSTACK-2181.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/vm/UserVmManagerImpl.java e8ea024 
> 
> Diff: https://reviews.apache.org/r/11936/diff/
> 
> 
> Testing
> ---
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>



Re: starting VM and get error of "unable to create a deployment for VM[user|i-2-107-VM]"

2013-06-20 Thread Nitin Mehta
uot;type":"ISO","storagePoolType":"ISO","deviceId":3}],
>> "nics":[{"deviceId":0,"networkRateMbps":200,"defaultNic":true,"ip":"10
>> .4.16.121","netmask":"255.255.255.192","gateway":"10.4.16.65","mac":"0
>> 6:48:2e:00:00:a4","dns1":"10.4.16.21","broadcastType":"Vlan","type":"G
>> uest","broadcastUri":"vlan://untagged","isolationUri":"ec2://untagged"
>> ,"isSecurityGroupEnabled":false}]},"wait":0}}]
>> }
>> 2013-06-14 12:28:59,317 DEBUG [agent.transport.Request]
>> (Job-Executor-16:job-626) Seq 9-1193017840: Received:  { Ans: , MgmtId:
>> 110492071566, via: 9, Ver: v1, Flags: 110, { StartAnswer } }
>> 2013-06-14 12:28:59,318 WARN  [cloud.vm.VirtualMachineManagerImpl]
>> (Job-Executor-16:job-626) Cleanup failed due to Unable to start
>> i-2-107-VM due to
>> 2013-06-14 12:28:59,321 INFO  [cloud.vm.VirtualMachineManagerImpl]
>> (Job-Executor-16:job-626) Unable to start VM on Host[-9-Routing] due
>> to Unable to start i-2-107-VM due to
>> 2013-06-14 12:28:59,322 DEBUG [cloud.vm.VirtualMachineManagerImpl]
>> (Job-Executor-16:job-626) Cleaning up resources for the vm
>> VM[User|i-2-107-VM] in Starting state
>> 2013-06-14 12:28:59,323 DEBUG [agent.transport.Request]
>> (Job-Executor-16:job-626) Seq 9-1193017841: Sending  { Cmd , MgmtId:
>> 110492071566, via: 9, Ver: v1, Flags: 100111,
>> [{"StopCommand":{"isProxy":false,"vmName":"i-2-107-VM","wait":0}}] }
>> 2013-06-14 12:28:59,323 DEBUG [agent.transport.Request]
>> (Job-Executor-16:job-626) Seq 9-1193017841: Executing:  { Cmd , MgmtId:
>> 110492071566, via: 9, Ver: v1, Flags: 100111,
>> [{"StopCommand":{"isProxy":false,"vmName":"i-2-107-VM","wait":0}}] }
>> 2013-06-14 12:28:59,747 DEBUG [agent.transport.Request]
>> (Job-Executor-16:job-626) Seq 9-1193017841: Received:  { Ans: , MgmtId:
>> 110492071566, via: 9, Ver: v1, Flags: 110, { StopAnswer } }
>> 2013-06-14 12:28:59,747 DEBUG [cloud.vm.VirtualMachineManagerImpl]
>> (Job-Executor-16:job-626) Cleanup succeeded. Details VM does not exist
>> 2013-06-14 12:28:59,751 DEBUG [cloud.network.NetworkManagerImpl]
>> (Job-Executor-16:job-626) Service SecurityGroup is not supported in
>> the network id=214
>> 2013-06-14 12:28:59,754 DEBUG [cloud.network.NetworkManagerImpl]
>> (Job-Executor-16:job-626) Changing active number of nics for network
>> id=214 on -1
>> 2013-06-14 12:28:59,755 DEBUG [cloud.vm.VirtualMachineManagerImpl]
>> (Job-Executor-16:job-626) Successfully cleanued up resources for the
>> vm VM[User|i-2-107-VM] in Starting state
>> 2013-06-14 12:28:59,757 DEBUG [cloud.vm.VirtualMachineManagerImpl]
>> (Job-Executor-16:job-626) Root volume is ready, need to place VM in
>> volume's cluster
>> 2013-06-14 12:28:59,757 DEBUG [cloud.vm.VirtualMachineManagerImpl]
>> (Job-Executor-16:job-626) Vol[129|vm=107|ROOT] is READY, changing
>> deployment plan to use this pool's dcId: 3 , podId: 3 , and clusterId:
>> 3
>> 2013-06-14 12:28:59,757 DEBUG [cloud.deploy.FirstFitPlanner]
>> (Job-Executor-16:job-626) DeploymentPlanner allocation algorithm:
>> random
>> 2013-06-14 12:28:59,758 DEBUG [cloud.deploy.FirstFitPlanner]
>> (Job-Executor-16:job-626) Trying to allocate a host and storage pools
>> from dc:3, pod:3,cluster:3, requested cpu: 1000, requested ram:
>> 1073741824
>> 2013-06-14 12:28:59,758 DEBUG [cloud.deploy.FirstFitPlanner]
>> (Job-Executor-16:job-626) Is ROOT volume READY (pool already
>>allocated)?:
>> Yes
>> 2013-06-14 12:28:59,758 DEBUG [cloud.deploy.FirstFitPlanner]
>> (Job-Executor-16:job-626) This VM has last host_id specified, trying
>> to choose the same host: 9
>> 2013-06-14 12:28:59,759 DEBUG [cloud.deploy.FirstFitPlanner]
>> (Job-Executor-16:job-626) The last host of this VM is in avoid set
>> 2013-06-14 12:28:59,759 DEBUG [cloud.deploy.FirstFitPlanner]
>> (Job-Executor-16:job-626) Cannot choose the last host to deploy this
>> VM
>> 2013-06-14 12:28:59,759 DEBUG [cloud.deploy.FirstFitPlanner]
>> (Job-Executor-16:job-626) Searching resources only under specified
>>Cluster:
>> 3
>> 2013-06-14 12:28:59,762 DEBUG [cloud.deploy.FirstFitPlanner]
>> (Job-Executor-16:job-626) Checking resources in Cluster: 3 under Pod:
>> 3
>> 2013-06-14 12:28:59,762 DEBUG [cloud.deploy.FirstFitP

Re: Review Request: Fix for CLOUDSTACK-2916, CLOUDSTACK-2457: validation for weight based configuration parameters

2013-06-20 Thread Nitin Mehta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11989/#review22161
---

Ship it!


Ship It!

- Nitin Mehta


On June 20, 2013, 9:42 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11989/
> ---
> 
> (Updated June 20, 2013, 9:42 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
> 
> 
> Description
> ---
> 
> CLOUDSTACK-2916: admin is not able to login through UI after setting GP 
> "cluster.cpu.allocated.capacity.notificationthreshold" to some string 
> CLOUDSTACK-2457:  No check for input values,special character,-ive values can 
> be assigne to GLobal parameter 
> "cluster.cpu.allocated.capacity.disablethreshold"
> 
> Added validation for float values and checking limit for weight based 
> parameters by creating a set of parameters.
> 
> 
> This addresses bugs CLOUDSTACK-2457 and CLOUDSTACK-2916.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java 131d340 
> 
> Diff: https://reviews.apache.org/r/11989/diff/
> 
> 
> Testing
> ---
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>



Re: Review Request: Fix for CLOUDSTACK-2916, CLOUDSTACK-2457: validation for weight based configuration parameters

2013-06-23 Thread Nitin Mehta


> On June 20, 2013, 10:12 a.m., Nitin Mehta wrote:
> > Ship It!

Please rebase

Nitins-MacBook-Air:cloudstack nitinmehta$ git apply 
../0001-CLOUDSTACK-2916-admin-is-not-able-to-login-through-U.patch 
error: patch failed: 
server/src/com/cloud/configuration/ConfigurationManagerImpl.java:336
error: server/src/com/cloud/configuration/ConfigurationManagerImpl.java: patch 
does not apply


- Nitin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11989/#review22161
---


On June 20, 2013, 9:42 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11989/
> ---
> 
> (Updated June 20, 2013, 9:42 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
> 
> 
> Description
> ---
> 
> CLOUDSTACK-2916: admin is not able to login through UI after setting GP 
> "cluster.cpu.allocated.capacity.notificationthreshold" to some string 
> CLOUDSTACK-2457:  No check for input values,special character,-ive values can 
> be assigne to GLobal parameter 
> "cluster.cpu.allocated.capacity.disablethreshold"
> 
> Added validation for float values and checking limit for weight based 
> parameters by creating a set of parameters.
> 
> 
> This addresses bugs CLOUDSTACK-2457 and CLOUDSTACK-2916.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java 131d340 
> 
> Diff: https://reviews.apache.org/r/11989/diff/
> 
> 
> Testing
> ---
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>



Re: Master broken on systemVM start

2013-06-24 Thread Nitin Mehta
After object store merge did you guys built the systemvm to get the new
systemvm iso ? I haven't tried it myself but contemplating that.

On 25/06/13 12:15 PM, "Pranav Saxena"  wrote:

>+1 , I am getting it too !
>
>-Original Message-
>From: Sanjay Tripathi [mailto:sanjay.tripa...@citrix.com]
>Sent: Tuesday, June 25, 2013 12:03 PM
>To: dev@cloudstack.apache.org
>Subject: RE: Master broken on systemVM start
>
>I am also getting this exception on latest master:
>
>WARN  [utils.nio.Task] (AgentManager-Handler-2:) Caught the following
>exception but pushing on
>com.google.gson.JsonParseException: The JsonDeserializer
>com.cloud.agent.transport.ArrayTypeAdaptor@18e6ae2 failed to deserialize
>json object 
>[{"StartupSecondaryStorageCommand":{"type":"SecondaryStorage","dataCenter"
>:"1","pod":"1","guid":"s-3-VM-NfsSecondaryStorageResource","name":"s-3-VM"
>,"version":"4.2.0-SNAPSHOT","iqn":"NoIqn","publicIpAddress":"10.102.196.13
>0","publicNetmask":"255.255.255.0","publicMacAddress":"06:a3:68:00:00:15",
>"privateIpAddress":"10.102.192.91","privateMacAddress":"06:f5:18:00:00:02"
>,"privateNetmask":"255.255.252.0","storageIpAddress":"10.102.192.91","stor
>ageNetmask":"255.255.252.0","storageMacAddress":"06:f5:18:00:00:02","resou
>rceName":"NfsSecondaryStorageResource","contextMap":{},"wait":0}}] given
>the type class [Lcom.cloud.agent.api.Command;
>   at 
>com.google.gson.JsonDeserializerExceptionWrapper.deserialize(JsonDeseriali
>zerExceptionWrapper.java:64)
>   at 
>com.google.gson.JsonDeserializationVisitor.invokeCustomDeserializer(JsonDe
>serializationVisitor.java:92)
>   at 
>com.google.gson.JsonDeserializationVisitor.visitUsingCustomHandler(JsonDes
>erializationVisitor.java:80)
>   at com.google.gson.ObjectNavigator.accept(ObjectNavigator.java:101)
>   at 
>com.google.gson.JsonDeserializationContextDefault.fromJsonArray(JsonDeseri
>alizationContextDefault.java:67)
>   at 
>com.google.gson.JsonDeserializationContextDefault.deserialize(JsonDeserial
>izationContextDefault.java:52)
>   at com.google.gson.Gson.fromJson(Gson.java:551)
>   at com.google.gson.Gson.fromJson(Gson.java:498)
>   at com.cloud.agent.transport.Request.getCommands(Request.java:235)
>   at 
>com.cloud.agent.manager.AgentManagerImpl$AgentHandler.processRequest(Agent
>ManagerImpl.java:1193)
>   at 
>com.cloud.agent.manager.AgentManagerImpl$AgentHandler.doTask(AgentManagerI
>mpl.java:1346)
>   at 
>com.cloud.agent.manager.ClusteredAgentManagerImpl$ClusteredAgentHandler.do
>Task(ClusteredAgentManagerImpl.java:659)
>   at com.cloud.utils.nio.Task.run(Task.java:83)
>   at 
>java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:
>1145)
>   at 
>java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java
>:615)
>   at java.lang.Thread.run(Thread.java:722)
>Caused by: com.cloud.utils.exception.CloudRuntimeException: can't find
>StartupSecondaryStorageCommand
>   at 
>com.cloud.agent.transport.ArrayTypeAdaptor.deserialize(ArrayTypeAdaptor.ja
>va:77)
>   at 
>com.cloud.agent.transport.ArrayTypeAdaptor.deserialize(ArrayTypeAdaptor.ja
>va:37)
>   at 
>com.google.gson.JsonDeserializerExceptionWrapper.deserialize(JsonDeseriali
>zerExceptionWrapper.java:51)
>   ... 15 more
>
>--Sanjay
>
>> -Original Message-
>> From: Prasanna Santhanam [mailto:t...@apache.org]
>> Sent: Saturday, June 22, 2013 10:49 PM
>> To: CloudStack Dev
>> Subject: Master broken on systemVM start
>> 
>> Unable to bring up the systemVMs on latest master. There is very
>> little detail in the logs: posted CLOUDSTACK-3137
>> 
>> Can someone please take a look? The regression tests running on the
>> weekend were blocked because of this.
>> 
>> --
>> Prasanna.,
>> 
>> 
>> Powered by BigRock.com
>



Re: Config Setting for S3 without NFS Caching

2013-06-27 Thread Nitin Mehta
I thought we don¹t even call it cache but staging area :)

On 27/06/13 12:31 PM, "Prasanna Santhanam"  wrote:

>It looks like Tom tried something similar and filed CLOUDSTACK-3221.
>Is object store without the NFS cache a supported configuration? I
>thought the cache was a reqd.
>
>On Tue, Jun 25, 2013 at 09:54:58PM +, Min Chen wrote:
>> Current code does not have that, that may be a good suggestion. You can
>>file a ticket for that.
>> 
>> -min
>> 
>> Sent from my iPhone
>> 
>> On Jun 25, 2013, at 1:12 PM, "Sebastien Goasguen" 
>>wrote:
>> 
>> > S3.nfs.caching = false
>> > 
>> > :)
>> > 
>> > ... No clue
>> > 
>> > -Sebastien
>> > 
>> > On 25 Jun 2013, at 13:07, Donal Lafferty 
>>wrote:
>> > 
>> >> Is there a config setting to indicate that S3 is operating without
>>NFS Caching?
>> >> 
>> >> DL
>> >> 
>
>-- 
>Prasanna.,
>
>
>Powered by BigRock.com
>



vmware help for dynamic scaling

2013-06-27 Thread Nitin Mehta
Hi All,
I have been working on dynamic scaling vm memory and cpu and trying to tune it 
for vmware hypervisor, but being a novice need some assistance.
Vmware publishes a list for  vmware guest os and their supported capabilities 
for each vmware release. Example for guest OS Ubuntu 10.04 and ESX some release 
4.x we only support hot add of vcpu (and not hot add memory)

GuestOS Release

Ubuntu 10.04 Desktop

Supported Releases

ESX 4.1 U31, 2, 3, 4, 5, 6, 4.1 U21, 2, 3, 4, 5, 6, 4.1 U11, 2, 3, 4, 5, 6, 
4.12, 1, 6, 5, 4, 3

Support Details

Hot Add vCPU etc….

More info @ 
http://partnerweb.vmware.com/comp_guide2/pdf/VMware_GOS_Compatibility_Guide.pdf

Vmware says that the attributes hot add cpu and memory should be turned on 
during deployment of vm (i.e. As part of deployvm api) so that in future the 
user can dynamically scale cpu and memory(scale vm api). Now I wanted to 
understand how to enforce this check in Cloudstack. The best would be Vmware 
providing a method to check whether hot add cpu and memory is enabled for the 
current GuestOS version in the vmware releae. Is there an api available for the 
same ? If not, we have to go down the path of maintaining this list in CS of  
vmware guest os and their supported capabilities for each vmware release which 
is going to be extremely hard to maintain and error prone.

Thanks,
-Nitin


Re: Review Request 12263: CLOUDSTACK-3354: [automation] scale up VM is failing

2013-07-04 Thread Nitin Mehta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12263/#review22757
---



setup/db/db/schema-410to420.sql
<https://reviews.apache.org/r/12263/#comment46453>

only for XS ?


You need to also update templates.sql for fresh installs correct ?

- Nitin Mehta


On July 4, 2013, 8:33 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12263/
> ---
> 
> (Updated July 4, 2013, 8:33 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
> 
> 
> Bugs: CLOUDSTACK-3354
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-3354: [automation] scale up VM is failing 
> 
> Marking default centos template as dynamically_scalable template.
> 
> 
> Diffs
> -
> 
>   setup/db/db/schema-410to420.sql 11204c7 
> 
> Diff: https://reviews.apache.org/r/12263/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>



Re: Review Request 12264: CLOUDSTACK-3351: Fix add cluster API to set right hypervisor type

2013-07-04 Thread Nitin Mehta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12264/#review22759
---


Since we have already put it to be case insensitive will this be causing issues 
for upgrade or anywhere else we are comparing. This is concerning

- Nitin Mehta


On July 4, 2013, 8:40 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12264/
> ---
> 
> (Updated July 4, 2013, 8:40 a.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Bugs: CLOUDSTACK-3351
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-3351: Fix add cluster API to set right hypervisor type
> In AddCluster API we validate Hypervisor type parameter even if it is case 
> insensitive. We should not put this case insensitive value in the DB which 
> may lead to mismatch with hypervisor type with other tables in DB leading to 
> failure of various DB queries.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/resource/ResourceManagerImpl.java c6e8d7d 
> 
> Diff: https://reviews.apache.org/r/12264/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>



Re: [Query] dynamic scaling of a virtual machine

2013-07-04 Thread Nitin Mehta
I guess there is a need for documentation here. Please open a doc bug as
well if you haven't already

On 04/07/13 10:50 AM, "Srikanteswararao Talluri"
 wrote:

>I see the same error even after installing xen pv drivers. Filed a bug for
>this https://issues.apache.org/jira/browse/CLOUDSTACK-3354
>
>Thanks,
>~Talluri
>
>On 04/07/13 10:02 AM, "Prasanna Santhanam" 
>wrote:
>
>>On Thu, Jul 04, 2013 at 01:49:47AM +, Srikanteswararao Talluri wrote:
>>> Is there a change in behaviour of dynamic scaling of a virtual
>>> machine feature recently? I am hitting the following exception (vm
>>> does not have xs tools to support dynamic scaling)
>>
>>Yes - the implementation verifies if pv tools are installed if not it
>>will prevent scaling the VM. I know this breaks the test in the bvt,
>>but the fix is not very clear to me either. We'll have to do some
>>messy installation of the iso after mounting it within the VM.
>>
>>> 
>>> 
>>> Done executing 
>>>org.apache.cloudstack.api.command.user.volume.ResizeVolumeCmd for
>>>job-183
>>> 2013-07-04 03:50:40,393 WARN  [cloud.vm.UserVmManagerImpl]
>>>(Job-Executor-37:job-170) Received exception while scaling
>>> com.cloud.utils.exception.CloudRuntimeException: Unable to scale vm
>>> due to Unable to upgrade i-22-36-QA due to Unable to Scale the vm:
>>> i-22-36-QAas vm does not have xs tools to support dynamic scaling
>>> at 
>>>com.cloud.vm.VirtualMachineManagerImpl.reConfigureVm(VirtualMachineManag
>>>e
>>>rImpl.java:3265)
>>> at 
>>>com.cloud.vm.UserVmManagerImpl.upgradeVirtualMachine(UserVmManagerImpl.j
>>>a
>>>va:1217)
>>> at 
>>>com.cloud.vm.UserVmManagerImpl.upgradeVirtualMachine(UserVmManagerImpl.j
>>>a
>>>va:1090)
>>> at 
>>>com.cloud.utils.component.ComponentInstantiationPostProcessor$Intercepto
>>>r
>>>Dispatcher.intercept(ComponentInstantiationPostProcessor.java:125)
>>> at 
>>>org.apache.cloudstack.api.command.user.vm.ScaleVMCmd.execute(ScaleVMCmd.
>>>j
>>>ava:92)
>>> at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:155)
>>> at 
>>>com.cloud.async.AsyncJobManagerImpl$1.run(AsyncJobManagerImpl.java:437)
>>> at 
>>>java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
>>> at 
>>>java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
>>> at java.util.concurrent.FutureTask.run(FutureTask.java:166)
>>> at 
>>>java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.jav
>>>a
>>>:1110)
>>> at 
>>>java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.ja
>>>v
>>>a:603)
>>> at java.lang.Thread.run(Thread.java:679)
>>> 2013-07-04 03:50:40,424 WARN  [xen.resource.XenServer56FP1Resource]
>>> (DirectAgent-8:null) Host Rack1Pod1Host15 does not support dynamic
>>> scaling
>>> 2013-07-04 03:50:40,444 DEBUG [cloud.async.AsyncJobManagerImpl]
>>> (Job-Executor-37:job-170) Complete async job-170, jobStatus: 2,
>>> resultCode: 530, result: Error Code: 530 Error text: Failed to scale
>>> vm
>>> 
>>> Thanks,
>>> ~Talluri
>>
>>-- 
>>Prasanna.,
>



Re: master not perfect:(

2013-07-05 Thread Nitin Mehta
Shouldn't we have a better mechanism of pushing systemvm.iso onto XS ? Why
does it have to be manually done by clearing the tags ?

Thanks,
-Nitin

On 05/07/13 3:43 PM, "Rajesh Battala"  wrote:

>After the new systemvm.iso is generated and tags/systemvm.iso are removed
>on xenserver host , when mgmt. server starts, it will copy the new
>systemvm.iso to the Host.
>Then the issue will be resolved.
>
>> -Original Message-
>> From: Likitha Shetty [mailto:likitha.she...@citrix.com]
>> Sent: Friday, July 5, 2013 3:38 PM
>> To: dev@cloudstack.apache.org
>> Subject: RE: master not perfect:(
>> 
>> In my case the discussed steps didn't resolve the issue (removing all
>>the tags
>> from the host , cleaning up systemvm.iso from the codebase , ensuring
>>the
>> systemvm profile is enabled during maven build and also ensuring the
>>host
>> has the newly generated systemvm.iso).
>> Only once I rebooted the host was the issue resolved.
>> 
>> Thanks,
>> Likitha
>> 
>> >-Original Message-
>> >From: Hugo Trippaers [mailto:htrippa...@schubergphilis.com]
>> >Sent: Friday, July 05, 2013 3:23 PM
>> >To: dev@cloudstack.apache.org
>> >Subject: RE: master not perfect:(
>> >
>> >Hey guys,
>> >
>> >Did you use the latest systemvm.iso on the systemvm? This error might
>> >occur when the classes on the secondary storage vm are out of sync with
>> >the classes on the management server.
>> >
>> >If you are running from a maven build make sure that the systemvm
>> >profile is enabled to generate the systemvm.iso and that the file is
>> >properly uploaded/copied.
>> >
>> >Cheers,
>> >
>> >
>> >Hugo
>> >
>> >> -Original Message-
>> >> From: Abhinav Roy [mailto:abhinav@citrix.com]
>> >> Sent: Friday, July 05, 2013 11:44 AM
>> >> To: dev@cloudstack.apache.org
>> >> Subject: RE: master not perfect:(
>> >>
>> >> I faced the same issue, then I logged on to the xenserver host and
>> >> deleted the tags, restarted the MS but even after that i could see
>> >> these errors. Finally I rebooted the Xen Host and after that the
>> >> error was not seen. Filed a bug for the same,
>> >> https://issues.apache.org/jira/browse/CLOUDSTACK-3377
>> >>
>> >> Thanks and regards,
>> >> Abhinav
>> >> -Original Message-
>> >> From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com]
>> >> Sent: Friday, July 05, 2013 2:56 PM
>> >> To: dev@cloudstack.apache.org
>> >> Subject: master not perfect:(
>> >>
>> >> H,
>> >>
>> >> I get a repetition of the following sequence of logging when running
>> master.
>> >> Anybody knows what happened?
>> >>
>> >> INFO  [agent.manager.AgentManagerImpl] (AgentManager-Handler-11:)
>> >> Connection from /127.0.0.1 closed but no cleanup was done.
>> >> WARN  [utils.nio.Link] (AgentManager-Selector:) SSL: Fail to find the
>> >> generated keystore. Loading fail-safe one to continue.
>> >> ERROR [agent.transport.Request] (AgentManager-Handler-13:) Caught
>> >> problem with
>> >>
>> [{"StartupSecondaryStorageCommand":{"type":"SecondaryStorage","dataCe
>> >> nter":"1","pod":"1","guid":"s-1-VM-
>> >> NfsSecondaryStorageResource","name":"s-1-VM","version":"4.2.0-
>> >> SNAPSHOT","iqn":"NoIqn","publicIpAddress":"195.66.90.212","publicNetm
>> >> a
>> >> s
>> >> k":"255.255.255.224","publicMacAddress":"06:fb:ca:00:00:01","privateI
>> >> p
>> >> Addr
>> >> ess":"10.200.23.62","privateMacAddress":"06:ad:58:00:00:08","privateN
>> >> e
>> >> tma
>> >> 
>>sk":"255.255.255.0","storageIpAddress":"10.200.23.62","storageNetmask"
>> >> :"2
>> >> 
>>55.255.255.0","storageMacAddress":"06:ad:58:00:00:08","resourceName":"
>> >> N fsSecondaryStorageResource","contextMap":{},"wait":0}}]
>> >> com.google.gson.JsonParseException: The JsonDeserializer
>> >> com.cloud.agent.transport.ArrayTypeAdaptor@7db106d failed to
>> >> deserialize json object
>> >>
>> [{"StartupSecondaryStorageCommand":{"type":"SecondaryStorage","dataCe
>> >> nter":"1","pod":"1","guid":"s-1-VM-
>> >> NfsSecondaryStorageResource","name":"s-1-VM","version":"4.2.0-
>> >> SNAPSHOT","iqn":"NoIqn","publicIpAddress":"195.66.90.212","publicNetm
>> >> a
>> >> s
>> >> k":"255.255.255.224","publicMacAddress":"06:fb:ca:00:00:01","privateI
>> >> p
>> >> Addr
>> >> ess":"10.200.23.62","privateMacAddress":"06:ad:58:00:00:08","privateN
>> >> e
>> >> tma
>> >> 
>>sk":"255.255.255.0","storageIpAddress":"10.200.23.62","storageNetmask"
>> >> :"2
>> >> 
>>55.255.255.0","storageMacAddress":"06:ad:58:00:00:08","resourceName":"
>> >> N fsSecondaryStorageResource","contextMap":{},"wait":0}}] given the
>> >> type class [Lcom.cloud.agent.api.Command;
>> >>at
>> >> com.google.gson.JsonDeserializerExceptionWrapper.deserialize(JsonDese
>> >> r
>> >> ial
>> >> izerExceptionWrapper.java:64)
>> >>at
>> >> com.google.gson.JsonDeserializationVisitor.invokeCustomDeserializer(J
>> >> s
>> >> onD
>> >> eserializationVisitor.java:92)
>> >>at
>> >> com.google.gson.JsonDeserializationVisitor.visitUsingCustomHandler(Js
>> >> o
>> >> nDe
>> >> serializationVisitor.java:80)
>> >

Re: master not perfect:(

2013-07-05 Thread Nitin Mehta
Good solution Hugo.
Can we also not embed md5sum in the tag ? In that case it would push the
iso if the md5sum doesn't match
Will it break more things than it will solve :) ?

Thanks,
-Nitin

On 05/07/13 5:45 PM, "Hugo Trippaers" 
wrote:

>Heya,
>
>It will be done automagically once you upgrade the version number. The
>tag lists the version number and checks that against the current version
>you are running.
>
>This is probably good for users who only want to update the systemvm
>once, when they upgrade to a new version. For developers who generally
>work on the same version its more troublesome, just like database
>upgrades. A developer typically recompiles regularly and needs the latest
>version of both database and systemvm.
>
>A solution could be to ignore the tag when developer is set to true in
>the global config. Any better ideas?
>
>Cheers,
>
>Hugo
>
>> -Original Message-
>> From: Nitin Mehta [mailto:nitin.me...@citrix.com]
>> Sent: Friday, July 05, 2013 12:48 PM
>> To: dev@cloudstack.apache.org
>> Subject: Re: master not perfect:(
>> 
>> Shouldn't we have a better mechanism of pushing systemvm.iso onto XS ?
>> Why does it have to be manually done by clearing the tags ?
>> 
>> Thanks,
>> -Nitin
>> 
>> On 05/07/13 3:43 PM, "Rajesh Battala"  wrote:
>> 
>> >After the new systemvm.iso is generated and tags/systemvm.iso are
>> >removed on xenserver host , when mgmt. server starts, it will copy the
>> >new systemvm.iso to the Host.
>> >Then the issue will be resolved.
>> >
>> >> -Original Message-
>> >> From: Likitha Shetty [mailto:likitha.she...@citrix.com]
>> >> Sent: Friday, July 5, 2013 3:38 PM
>> >> To: dev@cloudstack.apache.org
>> >> Subject: RE: master not perfect:(
>> >>
>> >> In my case the discussed steps didn't resolve the issue (removing all
>> >>the tags  from the host , cleaning up systemvm.iso from the codebase ,
>> >>ensuring the  systemvm profile is enabled during maven build and also
>> >>ensuring the host  has the newly generated systemvm.iso).
>> >> Only once I rebooted the host was the issue resolved.
>> >>
>> >> Thanks,
>> >> Likitha
>> >>
>> >> >-Original Message-
>> >> >From: Hugo Trippaers [mailto:htrippa...@schubergphilis.com]
>> >> >Sent: Friday, July 05, 2013 3:23 PM
>> >> >To: dev@cloudstack.apache.org
>> >> >Subject: RE: master not perfect:(
>> >> >
>> >> >Hey guys,
>> >> >
>> >> >Did you use the latest systemvm.iso on the systemvm? This error
>> >> >might occur when the classes on the secondary storage vm are out of
>> >> >sync with the classes on the management server.
>> >> >
>> >> >If you are running from a maven build make sure that the systemvm
>> >> >profile is enabled to generate the systemvm.iso and that the file is
>> >> >properly uploaded/copied.
>> >> >
>> >> >Cheers,
>> >> >
>> >> >
>> >> >Hugo
>> >> >
>> >> >> -Original Message-
>> >> >> From: Abhinav Roy [mailto:abhinav@citrix.com]
>> >> >> Sent: Friday, July 05, 2013 11:44 AM
>> >> >> To: dev@cloudstack.apache.org
>> >> >> Subject: RE: master not perfect:(
>> >> >>
>> >> >> I faced the same issue, then I logged on to the xenserver host and
>> >> >> deleted the tags, restarted the MS but even after that i could see
>> >> >> these errors. Finally I rebooted the Xen Host and after that the
>> >> >> error was not seen. Filed a bug for the same,
>> >> >> https://issues.apache.org/jira/browse/CLOUDSTACK-3377
>> >> >>
>> >> >> Thanks and regards,
>> >> >> Abhinav
>> >> >> -Original Message-
>> >> >> From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com]
>> >> >> Sent: Friday, July 05, 2013 2:56 PM
>> >> >> To: dev@cloudstack.apache.org
>> >> >> Subject: master not perfect:(
>> >> >>
>> >> >> H,
>> >> >>
>> >> >> I get a repetition of the following sequence of logging when
>> >> >> running
>> >> master.
>> >&

Re: Review Request 12358: CLOUDSTACK-3228: system vms are not comming up in zone with two cluster xen and kvm

2013-07-16 Thread Nitin Mehta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12358/#review23238
---



plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java
<https://reviews.apache.org/r/12358/#comment47125>

you are logging warn n checing debug enabled ? Dont have to check that



server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java
<https://reviews.apache.org/r/12358/#comment47129>

Ideally, I would have liked it to be a separate function like 
getReadySystemTemplate(zoneId)

Also this should be a SQL query rather than embedding logic in Java



server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java
<https://reviews.apache.org/r/12358/#comment47126>

log it in warn



server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java
<https://reviews.apache.org/r/12358/#comment47128>

In logs try to put in as much information. Put zone id and list of 
hypervisors you tried.



server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java
<https://reviews.apache.org/r/12358/#comment47130>

    Boiler plate code. 


- Nitin Mehta


On July 10, 2013, 10:56 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12358/
> ---
> 
> (Updated July 10, 2013, 10:56 a.m.)
> 
> 
> Review request for cloudstack and Nitin Mehta.
> 
> 
> Bugs: CLOUDSTACK-3228
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-3228: system vms are not comming up in zone with two cluster xen 
> and kvm;Zone host is ready, but secondary storage vm template: 3 is not ready 
> on secondary storage: 2
> 
> Shuffling the hypervisors list before getting the first hypervisor in list so 
> that on every retry of system vm deployment it chooses different hypervisor 
> and checking whether template is downloaded or not.
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 9e75990 
>   
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java
>  407f069 
>   server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java 5983aa7 
>   server/src/com/cloud/resource/ResourceManager.java e35e89a 
>   server/src/com/cloud/resource/ResourceManagerImpl.java 41c6ad7 
>   server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 
> 05256a8 
>   server/test/com/cloud/resource/MockResourceManagerImpl.java 18cff80 
> 
> Diff: https://reviews.apache.org/r/12358/diff/
> 
> 
> Testing
> ---
> 
> tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>



Re: Review Request 12427: Fix for CLOUDSTACK-3365 and CLOUDSTACK-2536

2013-07-16 Thread Nitin Mehta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12427/#review23239
---



server/src/com/cloud/alert/AlertManagerImpl.java
<https://reviews.apache.org/r/12427/#comment47131>

Write a function getOverProvisioningFactor(clusterId, capacityType)



server/src/com/cloud/alert/AlertManagerImpl.java
<https://reviews.apache.org/r/12427/#comment47132>

capacityValue is misleading  call it threshhold



server/src/com/cloud/configuration/Config.java
<https://reviews.apache.org/r/12427/#comment47133>

Please clarify - Are they not at cluster level anymore ?



server/src/com/cloud/vm/VirtualMachineManagerImpl.java
<https://reviews.apache.org/r/12427/#comment47135>

What was wrong here...why not taking it from Config ?


- Nitin Mehta


On July 10, 2013, 10:56 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12427/
> ---
> 
> (Updated July 10, 2013, 10:56 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, Koushik Das, and Nitin 
> Mehta.
> 
> 
> Bugs: CLOUDSTACK-2536 and CLOUDSTACK-3365
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-3365: cluster level parameters 
> cluster.(cpu/memory).allocated.capacity.notificationthreshold is not 
> considering overcommit value
> 
> CLOUDSTACK-2536:  parameters (cpu/memory)overcommit ratio and 
> (cpu/memory).overprosioning.factor are redundant(cluster level)
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/alert/AlertManagerImpl.java 9b7cd27 
>   server/src/com/cloud/configuration/Config.java d3ed718 
>   server/src/com/cloud/vm/VirtualMachineManagerImpl.java 30ee2d7 
>   server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 44e22e2 
> 
> Diff: https://reviews.apache.org/r/12427/diff/
> 
> 
> Testing
> ---
> 
> Tested locally both with actual usage and over committed values for memory. 
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>



Re: Review Request 12324: CLOUDSTACK-3358: create template from a volume/snapshot should also take input from User/Admin whether xstools / vmware tools installed in the VM

2013-07-16 Thread Nitin Mehta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12324/#review23242
---



api/src/org/apache/cloudstack/api/command/user/template/CreateTemplateCmd.java
<https://reviews.apache.org/r/12324/#comment47138>

No, they should inherit the attribute from parent template. It shouldnt be 
available through UI. It should be done similar to extractable attribute which 
is inherited from parent template


- Nitin Mehta


On July 15, 2013, 12:10 p.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12324/
> ---
> 
> (Updated July 15, 2013, 12:10 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
> 
> 
> Bugs: CLOUDSTACK-3358
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-3358: create template from a volume/snapshot should also take 
> input from User/Admin whether xstools / vmware tools installed in the VM
> 
> 
> Diffs
> -
> 
>   
> api/src/org/apache/cloudstack/api/command/user/template/CreateTemplateCmd.java
>  07aeb0a 
>   server/src/com/cloud/hypervisor/HypervisorGuruBase.java 769648a 
>   server/src/com/cloud/template/TemplateManagerImpl.java 18a69ca 
> 
> Diff: https://reviews.apache.org/r/12324/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>



Re: Review Request 12632: CLOUDSTACK-3551: Fix value over flow due to type conversion

2013-07-17 Thread Nitin Mehta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12632/#review23356
---

Ship it!


Ship It!

- Nitin Mehta


On July 17, 2013, 6:09 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12632/
> ---
> 
> (Updated July 17, 2013, 6:09 a.m.)
> 
> 
> Review request for cloudstack and Nitin Mehta.
> 
> 
> Bugs: CLOUDSTACK-3551
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-3551: scaling up VM to service offering with 2gbram 
> Fixed the type overflow of Ram value.
> 
> 
> Diffs
> -
> 
>   
> plugins/hypervisors/baremetal/src/com/cloud/baremetal/manager/BareMetalPlanner.java
>  97b2840 
>   server/src/com/cloud/capacity/CapacityManagerImpl.java d54624d 
>   server/src/com/cloud/vm/VirtualMachineManagerImpl.java 827e233 
> 
> Diff: https://reviews.apache.org/r/12632/diff/
> 
> 
> Testing
> ---
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>



Meet up on July 20th - Hyderabad, India

2013-07-18 Thread Nitin Mehta
There is an upcoming meet up on July 20th at Hyderabad, India
There will be talks on CS architecture and hacking with devcloud.
Detailed info @ 
http://www.meetup.com/CloudStack-Hyderabad-Group/events/125208462/

Thanks,
-Nitin



Re: Review Request 12324: CLOUDSTACK-3358: create template from a volume/snapshot should also take input from User/Admin whether xstools / vmware tools installed in the VM

2013-07-18 Thread Nitin Mehta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12324/#review23483
---

Ship it!


Ship It!

- Nitin Mehta


On July 15, 2013, 12:10 p.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12324/
> ---
> 
> (Updated July 15, 2013, 12:10 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
> 
> 
> Bugs: CLOUDSTACK-3358
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-3358: create template from a volume/snapshot should also take 
> input from User/Admin whether xstools / vmware tools installed in the VM
> 
> 
> Diffs
> -
> 
>   
> api/src/org/apache/cloudstack/api/command/user/template/CreateTemplateCmd.java
>  07aeb0a 
>   server/src/com/cloud/hypervisor/HypervisorGuruBase.java 769648a 
>   server/src/com/cloud/template/TemplateManagerImpl.java 18a69ca 
> 
> Diff: https://reviews.apache.org/r/12324/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>



Re: Review Request 12324: CLOUDSTACK-3358: create template from a volume/snapshot should also take input from User/Admin whether xstools / vmware tools installed in the VM

2013-07-18 Thread Nitin Mehta


> On July 17, 2013, 5:58 a.m., Harikrishna Patnala wrote:
> > api/src/org/apache/cloudstack/api/command/user/template/CreateTemplateCmd.java,
> >  line 103
> > <https://reviews.apache.org/r/12324/diff/4/?file=321760#file321760line103>
> >
> > This will be inconsistent at some times when we create template from 
> > snapshot.
> > Lets consider this case.
> > 1) Template1: does not have xstools
> > 2) install XS tools on the VM.
> > 3) create vm and take snapshot of that volume.
> > 4) now create template from snapshot created in step(3)
> > 
> > We don't know whether tools are installed in the VM or not at the time 
> > of creation of snapshot. Steps 2 and 3 may occur many times. We cannot 
> > decide whether snapshot have XS tools are not?
> > 
> > Please let me know if I'm missing anything.
> > 
> > Thankyou
> > 
> >

Agreed. Please do open a UI bug then


- Nitin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12324/#review23243
---


On July 15, 2013, 12:10 p.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12324/
> -------
> 
> (Updated July 15, 2013, 12:10 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
> 
> 
> Bugs: CLOUDSTACK-3358
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-3358: create template from a volume/snapshot should also take 
> input from User/Admin whether xstools / vmware tools installed in the VM
> 
> 
> Diffs
> -
> 
>   
> api/src/org/apache/cloudstack/api/command/user/template/CreateTemplateCmd.java
>  07aeb0a 
>   server/src/com/cloud/hypervisor/HypervisorGuruBase.java 769648a 
>   server/src/com/cloud/template/TemplateManagerImpl.java 18a69ca 
> 
> Diff: https://reviews.apache.org/r/12324/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>



Re: New user - Introduction

2013-07-19 Thread Nitin Mehta
Welcome aboard Rene. Feel free to browse the wiki, JIRA bugs, code and ask
us questions :)

On 19/07/13 3:04 PM, "Wido den Hollander"  wrote:

>Hi Rene!
>
>For everybody here: Rene works for the company I work for to as well. I
>encouraged him to start working on CloudStack. Fix what's broken as you
>encounter things :)
>
>Wido
>
>On 07/19/2013 10:19 AM, René Diepstraten wrote:
>> Hi everyone.
>>
>> Since I have joined the mailing list, I'd like to say hello and
>>introduce
>> myself.
>> My name is Rene Diepstraten, am a system administrator and the company I
>> work for ( PCextreme ) uses Apache CloudStack.
>>
>> I'd like to contribute here and there with my skills in python and bash,
>> and perhaps learn some java.
>> A few small patches that I wrote have been accepted into Master, and I'd
>> like to contribute more to this great project in the future.
>>
>> Best regards,
>>
>> Rene Diepstraten
>>



Re: Review Request 12809: Fix for CLOUDSTACK-3703: change service offering of stopped vm on kvm is failing

2013-07-22 Thread Nitin Mehta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12809/#review23625
---

Ship it!


Ship It!

- Nitin Mehta


On July 22, 2013, 11:20 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12809/
> ---
> 
> (Updated July 22, 2013, 11:20 a.m.)
> 
> 
> Review request for cloudstack, Koushik Das and Nitin Mehta.
> 
> 
> Bugs: CLOUDSTACK-3703
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-3703: change service offering of stopped vm on kvm is failing
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/vm/UserVmManagerImpl.java adcf475 
> 
> Diff: https://reviews.apache.org/r/12809/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>



Re: secondary storage questions

2013-07-22 Thread Nitin Mehta


On 19/07/13 8:47 AM, "Mike Tutkowski"  wrote:

>When we use the word "template" here, do we mean both templates (like
>OVAs)
>and ISOs?

Yes, that¹s correct.

>
>Thanks!
>
>
>On Wed, Jun 5, 2013 at 5:07 PM, Marcus Sorensen 
>wrote:
>
>> Thanks, I have one follow-up:
>>
>> On Tue, Jun 4, 2013 at 12:10 AM, Nitin Mehta 
>> wrote:
>> > All the public templates will be replicated to all the secondary
>>storage
>> > for redundancy but private templates and uploaded volumes should be
>>kept
>> > in one of the randomly chosen secondary storage. Snapshots will be
>> > randomly copied to one of the secondary storage (the chain of
>>incremental
>> > snapshots are kept on the same secondary storage.). Currently these
>> > algorithms are hardcoded and so in case you need flexibility please
>>open
>> > an enhancement for the same.
>> >
>> >
>> > On 04/06/13 2:57 AM, "Marcus Sorensen"  wrote:
>> >
>> >>Anyone?
>> >>
>> >>We are also noticing that if we register a template, that template is
>> >>registered and ready, but becomes unusable if the URL for the template
>> >>stops working at any time. Seems like we attempt to red download it
>>every
>> >>so often. So no one-time registration. Is this by design?
>> >
>> > Whenever there is a handshake between MS and the agent running on the
>> SSVM
>> > there is a template sync which syncs the template status on the MS DB
>>and
>> > the template's physical Location and triggers the download if its not
>> > complete or retries in case there was some error. (This handshake
>>happens
>> > on ssvm re/start, agent on SSVM re/start and MS re/start).
>>
>> This implies that once the template is downloaded and is ready, the
>> URL doesn't need to stick around. We have some instances where we may
>> be downloading templates via one-time URLs. We had seen some things
>> that made us think that the template URLs are checked and possibly
>> redownloaded on occasion, so I wanted to clarify this, perhaps our
>> interpretations were wrong. Obviously if the URLs are checked and a
>> redownload is attempted for any reason, it will fail.
>>
>> >
>> >
>> >>On May 31, 2013 2:35 PM, "Marcus Sorensen" 
>>wrote:
>> >>
>> >>> Sort of embarrassed to ask this, but I'm unclear on a few of the
>> >>> aspects of secondary storage.
>> >>>
>> >>> 1) I can see that if I add multiple secondary storage locations,
>>they
>> >>> each get a copy of the registered templates. Are these copied from
>>one
>> >>> secondary storage to another, or from the url of the registered
>> >>> template?
>> >
>> > From the url of the template. Should happen only for public
>>templates. If
>> > you see otherwise please file a bug.
>> >
>> >>>
>> >>> 2) It seems that the intent is to mirror templates across all
>> >>> secondary storages, zone-wide, correct? But no copies are made for
>>the
>> >>> snapshots or volumes dirs. This may point to the idea that templates
>> >>> are always downloaded via URLs
>> >
>> > Multiple sec. storage are added for adding more storage and making
>>public
>> > templates highly available.
>> > Templates are downloaded via URLs but can also be created from
>>snapshots
>> > and volumes
>> >
>> >>>
>> >>> 3) It sounds like the total size of secondary storage is somewhat
>> >>> limited by templates, e.g. if all of you secondary storage is in
>> >>> templates, adding another secondary storage server won't increase my
>> >>> capacity, correct?
>> >
>> > Not correct, as per explanation above.
>> >
>> >>>
>> >
>>
>
>
>
>-- 
>*Mike Tutkowski*
>*Senior CloudStack Developer, SolidFire Inc.*
>e: mike.tutkow...@solidfire.com
>o: 303.746.7302
>Advancing the way the world uses the
>cloud<http://solidfire.com/solution/overview/?video=play>
>**



  1   2   3   4   >