Roxanne/Abhi - Thanks for following up. I guess this should be resolved by the Object Store work going on. Edison/Min - Would we still be having an entry for the secondary storage in the host table ?
Thanks, -Nitin On 17/06/13 12:01 PM, "Abhinandan Prateek" <aprat...@apache.org> wrote: > > >> On June 17, 2013, 5:06 a.m., Abhinandan Prateek wrote: >> > This is a old patch, is it still valid ? >> >> Prasanna Santhanam wrote: >> Hmm - quite embarrassing it is over 3 months old. We may have >>missed a contributor :( >> >> However should be valid still because the secondary storage host >>still shows 'Alert' on all installs. >> >> roxanne chang wrote: >> It will be nice if the changes can help. And.. Is the new design >>finished ? > >Roxanne, you may have to redo the patch on the current master and >resubmit as it fails to apply now. > > >- Abhinandan > > >----------------------------------------------------------- >This is an automatically generated e-mail. To reply, visit: >https://reviews.apache.org/r/9818/#review21971 >----------------------------------------------------------- > > >On May 31, 2013, 1:01 a.m., roxanne chang wrote: >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.apache.org/r/9818/ >> ----------------------------------------------------------- >> >> (Updated May 31, 2013, 1:01 a.m.) >> >> >> Review request for cloudstack, Abhinandan Prateek and edison su. >> >> >> Description >> ------- >> >> Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert >>status >> [https://issues.apache.org/jira/browse/CLOUDSTACK-1594] >> >> In file SecondarySotrageManagerImpl.java, function >>generateSetupCommand, if the host type is Secondary storage VM, the >>logic is to set secondarystorage host, at this time, secondarystorage >>host stauts should become Up. >> >> The secondary storage host always remains Alert status, because before >>the secondary storage vm is deployed, the secondary storage host is >>created. The tricky way (in the end of file AgentManagerImpl.java, >>function NotifiMonitorsOfConnection) will try to disconnect secondary >>storage, therefore the secondary storage host becomes Alert status. The >>code should take SSVM into consider, not only Answer reponse. >> >> File ResourceManagerImpl.java, function discoverHostsFull, in the end >>will call discoverer.postDiscovery, in file >>SecondarySotrageDiscover.postDiscovery, the condition _userServiceVM is >>not needed since its use to make secondary storage host wait for SSVM is >>already done in SecondaryStorageManagerImpl. This makes why secondary >>storage host always remains Alert status. >> >> >> This addresses bug >>https://issues.apache.org/jira/browse/CLOUDSTACK-1594. >> >> >> Diffs >> ----- >> >> server/src/com/cloud/agent/manager/AgentManagerImpl.java c1bbb58 >> >>server/src/com/cloud/storage/secondary/SecondaryStorageDiscoverer.java >>3ca74a3 >> >>server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java >>46ac7af >> >> Diff: https://reviews.apache.org/r/9818/diff/ >> >> >> Testing >> ------- >> >> Test 4.0.0, 4.2.0 in basic mode, works well. >> >> >> Thanks, >> >> roxanne chang >> >> >
