----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11906/#review22043 -----------------------------------------------------------
server/src/com/cloud/async/AsyncJobManagerImpl.java <https://reviews.apache.org/r/11906/#comment45380> it would help if you just keep it as job-id because thats how we log it in the logs...would be consistent for someone grepping for logs using job-id server/src/com/cloud/async/AsyncJobManagerImpl.java <https://reviews.apache.org/r/11906/#comment45379> can this be put in the check above starting with if (job != null) { server/src/com/cloud/async/AsyncJobManagerImpl.java <https://reviews.apache.org/r/11906/#comment45381> As said above please keep it as job-id server/src/com/cloud/async/AsyncJobManagerImpl.java <https://reviews.apache.org/r/11906/#comment45382> what if jobuuid = null - Nitin Mehta On June 17, 2013, 11:41 a.m., Sanjay Tripathi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11906/ > ----------------------------------------------------------- > > (Updated June 17, 2013, 11:41 a.m.) > > > Review request for cloudstack, Devdeep Singh, Nitin Mehta, and Sateesh > Chodapuneedi. > > > Description > ------- > > CLOUDSTACK-1047: tracking in logs using job id > > https://issues.apache.org/jira/browse/CLOUDSTACK-1047 > > > This addresses bug CLOUDSTACK-1047. > > > Diffs > ----- > > server/src/com/cloud/async/AsyncJobManagerImpl.java 0101a8a > server/src/com/cloud/storage/VolumeManagerImpl.java 4297efb > > Diff: https://reviews.apache.org/r/11906/diff/ > > > Testing > ------- > > Tests: > 1. Deploy an Instance. > 2. In the Management server logs, check the async job description, it should > be somthing like: job-[ 22 ] = [ 1075d499-03a8-44c3-ac9e-348dc5b32ba1 ] > > > Thanks, > > Sanjay Tripathi > >
