On 24/05/13 7:19 PM, "Chip Childers" <chip.child...@sungard.com> wrote:
>It would indeed, but since we are not going to release a 4.0.3, I fixed >it in the 4.1 and master branches. > >At a minimum, this "fix" doesn't regress anything... so while I'm >surprised that we didn't run into this issue as reported, I don't see >that it's an issue to correct the syntax moving forward. > >Do you think we should have another corrective update that strips the >extra space characters that may be there on 4.0 installations? Yes, if someone is currently on CS 4.0 and say upgrades to 4.1 then schema-302to40.sql won't be executed for him but instead schema-40to41.sql would be executed, so in a nutshell the same changes need to be present in schema-40to41.sql > >-chip > >On Fri, May 24, 2013 at 09:49:12AM +0000, Nitin Mehta wrote: >> Would this not be a problem for folks who are already on 4.0 ? >> >> On 13/05/13 9:22 PM, "Chip Childers" <chipchild...@apache.org> wrote: >> >> > >> >----------------------------------------------------------- >> >This is an automatically generated e-mail. To reply, visit: >> >https://reviews.apache.org/r/11088/#review20489 >> >----------------------------------------------------------- >> > >> >Ship it! >> > >> > >> >In 4.1: >> > >> >commit 5ccdf7dc4ad86145633124b9540aadfbfc423f6f >> >Author: Wei Zhou <w.z...@leaseweb.com> >> >Date: Mon May 13 16:50:29 2013 +0100 >> > >> > CLOUDSTACK-528: Correct a bunch of mistakes in the 3.0.x to 4.0 db >> > script >> > Signed-off-by: Chip Childers <chip.child...@gmail.com> >> > >> >- Chip Childers >> > >> > >> >On May 13, 2013, 3:38 p.m., Wei Zhou wrote: >> >> >> >> ----------------------------------------------------------- >> >> This is an automatically generated e-mail. To reply, visit: >> >> https://reviews.apache.org/r/11088/ >> >> ----------------------------------------------------------- >> >> >> >> (Updated May 13, 2013, 3:38 p.m.) >> >> >> >> >> >> Review request for cloudstack and Chip Childers. >> >> >> >> >> >> Description >> >> ------- >> >> >> >> There are some mistakes in configuration table. >> >> fixed them by this patch. >> >> >> >> >> >> This addresses bug CLOUDSTACK-528. >> >> >> >> >> >> Diffs >> >> ----- >> >> >> >> setup/db/db/schema-302to40.sql a947ac1 >> >> >> >> Diff: https://reviews.apache.org/r/11088/diff/ >> >> >> >> >> >> Testing >> >> ------- >> >> >> >> Nicolas has tested it. >> >> We also need an additional patch for the following new issue >>(Advanced >> >>Network with Security Groups). >> >> >> >> >> >> Thanks, >> >> >> >> Wei Zhou >> >> >> >> >> > >> >>
