----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14076/#review26713 -----------------------------------------------------------
test/integration/component/test_templates.py <https://reviews.apache.org/r/14076/#comment52028> there should be source zone id as well test/integration/component/test_templates.py <https://reviews.apache.org/r/14076/#comment52029> Is this a blocking call ? Have you tested this ? Does it return success test/integration/component/test_templates.py <https://reviews.apache.org/r/14076/#comment52035> Why are these assertions required when we repeat them in the loop ? test/integration/component/test_templates.py <https://reviews.apache.org/r/14076/#comment52031> change the comment test/integration/component/test_templates.py <https://reviews.apache.org/r/14076/#comment52032> Change this comment...this confused me... Say something like "check template downloaded by polling, then delete it finally" test/integration/component/test_templates.py <https://reviews.apache.org/r/14076/#comment52034> timeout is generally is not a count...what is the value typically u will keep ? test/integration/component/test_templates.py <https://reviews.apache.org/r/14076/#comment52033> how long will the sleep will be for ? - Nitin Mehta On Sept. 18, 2013, 2:29 p.m., Ashutosh Kelkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14076/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2013, 2:29 p.m.) > > > Review request for cloudstack, Girish Shilamkar, Harikrishna Patnala, and > Prasanna Santhanam. > > > Repository: cloudstack-git > > > Description > ------- > > Added one missing test for test_templates.py from old QA repo to Cloudstack > > > def test_02_copy_template > > > Diffs > ----- > > test/integration/component/test_templates.py e4599d4 > > Diff: https://reviews.apache.org/r/14076/diff/ > > > Testing > ------- > > > Thanks, > > Ashutosh Kelkar > >
