RE: [VOTE] Apache CloudStack 4.3.0 (fourth round) UPDATE

2014-02-13 Thread Alex Hitchins
Animesh,

As I understand it the API isn't causing breaking changes where I thought it 
was, so I revert my -1 on the issue.


Regards

Alex Hitchins

D: +44 1892 523 587 | S: +44 2036 030 540 | M: +44 7788 423 969

alex.hitch...@shapeblue.com

-Original Message-
From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com]
Sent: 13 February 2014 05:29
To: dev@cloudstack.apache.org
Cc: daan Hoogland; Murali Reddy; Kishan Kavala; Sudha Ponnaganti; Jayapal Reddy 
Uradi; Paul Angus; n...@li.nux.ro; Jayapal Reddy Uradi
Subject: [VOTE] Apache CloudStack 4.3.0 (fourth round) UPDATE


While the official 72 hours or rather 3 weekdays for this VOTE has passed and 
we have required +1 (binding) votes following issues have been called out:

1. CLOUDSTACK-6083 : Missing CIDRs in firewall rules after upgrade  => Waiting 
on Jayapal to confirm and update the list with findings 2. CLOUDSTACK-6069: VPC 
with private gateway not working called out by Daan => No change was expected 
in this area, I am following up with some folks (Murali, Kishan, Daan, Sudha) 
on if this is a setup specific issue or not. Daan has a put a -1 but has 
indicated will continue to use 4.3 if VOTE passes 3. CLOUDSTACK-6065: KVM HA 
not working for shutdown VMs => While an issue but my understanding is it is a 
corner scenario only affecting KVM and can be released  as a known issue 4. API 
compatibility broken => As per the discussion thread [4] and response from 
Devdeep and Min the compatibility is not broken. So not an issue



I would wait to  hear on 1) and 2)  before deciding moving on to release or 
respin, folks associated with 1,2 please provide your inputs.

Counting the votes so far:
+1: Marcus*, Animesh*, Edison*, Santhosh, Talluri, Amogh
-1: Paul Angus, Nux, Alex Hitchins, Daan*

* indicated binding votes.


[1] https://issues.apache.org/jira/browse/CLOUDSTACK-6083
[2] https://issues.apache.org/jira/browse/CLOUDSTACK-6069
[3] https://issues.apache.org/jira/browse/CLOUDSTACK-6065
[4] http://markmail.org/message/xy3pwve7u52wgzmr
Need Enterprise Grade Support for Apache CloudStack?
Our CloudStack Infrastructure 
Support offers the 
best 24/7 SLA for CloudStack Environments.

Apache CloudStack Bootcamp training courses

**NEW!** CloudStack 4.2.1 training
18th-19th February 2014, Brazil. 
Classroom
17th-23rd March 2014, Region A. Instructor led, 
On-line
24th-28th March 2014, Region B. Instructor led, 
On-line
16th-20th June 2014, Region A. Instructor led, 
On-line
23rd-27th June 2014, Region B. Instructor led, 
On-line

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue is a registered trademark.


RE: [PROPOSAL] List VM API enhancement

2014-02-13 Thread Daan Hoogland
Koushik,

I am afraid I am not. Using English for identifiers there is a semantic
differnce of using +'s' or just . it is the same difference as
using String or Collection. For the sake of quality assurance and
maintainability I call upon you to add a parameter for the use with
multiple instances. Nomenclature matters a lot. There are more of these
little 'English' rules implied in using a programming language, like the
use of adjectives. They matter in Westerns languages and unless we define a
system wide set of different rules let's stick with English.

kind regards,

Daan Hoogland


Op 13 feb. 2014 08:32 schreef "Koushik Das" :

> I see that there are 2 different opinions
>
> 1. Use 'id' for multiple ids as well. This is simple and compact and
> nothing breaks.
> 2. Have both 'id' and 'ids'. This can lead to confusion if 'id' is not
> deprecated (breaking change and would require a version change).
>
> Daan,
> Is it ok to move ahead with #1 for now? Later on when there is a version
> change required, this can be revisited.
>
> -Original Message-
> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> Sent: Monday, 10 February 2014 5:11 PM
> To: dev
> Subject: Re: [PROPOSAL] List VM API enhancement
>
> I don't like the id that id will be used for a list of ids. I would like
> to see the two both added to the api. They don't even need to bee mutually
> exclusive. the (human) semantics of id and ids is (in
> english) quite different and should be honored.
>
> regards,
> Daan
>
> On Fri, Feb 7, 2014 at 11:24 PM, Min Chen  wrote:
> > Yes.
> >
> > -min
> >
> > Sent from my iPhone
> >
> >> On Feb 7, 2014, at 11:10 AM, "Alena Prokharchyk" <
> alena.prokharc...@citrix.com> wrote:
> >>
> >> We can just agree from now on to use the ³id" for handling multiple ids.
> >> And of course, we can never delete the ³ID² parameter just to satisfy
> >> the old convention, as this is the most used parameter :)
> >>
> >> I can see that several existing commands - archive/deleteAlerts are
> >> using ApiConstants.IDs parameter. We can mark IDs as deprecated, so
> >> its no longer used by new commands.
> >>
> >> -Alena.
> >>
> >>> On 2/7/14, 11:03 AM, "Koushik Das"  wrote:
> >>>
> >>> Good point Min.
> >>> I also thought about it but looking at some of the existing APIs
> >>> thought of keeping both.
> >>>
> >>> For e.g. in deploy VM api there is a parameter called 'networkids'
> >>> which can take an array of network IDs. Note that the naming
> >>> convention of ending in 's'. Now by this logic we should name the
> >>> parameter 'ids' and remove the existing parameter 'id' which will be
> >>> a breaking change. In case the existing 'id' parameter is used for
> >>> multiple IDs that breaks the parameter naming convention.
> >>>
> >>> I am all in favour of using the existing 'id' parameter if there is
> >>> no issues with breaking the naming convention.
> >>>
> >>>
>  On 07-Feb-2014, at 11:25 PM, Min Chen  wrote:
> 
>  Hi Koushik,
> 
> I agree with the idea of supporting multiple IDs. But I may not
>  like the idea of introducing another different query parameter
>  "ids" for this purpose. Why cannot we just change current "id"
>  parameter to take a list of values? This way, user will not need to
>  use two different parameters for single or multiple cases.
>  Maintaining two different parameters for similar purpose is
>  error-prone. If you look at Amazon EC2 api, you will notice that
>  they are also using the similar convention, id parameter can be one
>  or more.
> 
> Thanks
> -min
> 
> > On 2/6/14 3:24 AM, "Koushik Das"  wrote:
> >
> > Yes it will be like a findByIds() and the one id case is just a
> > special case for this.
> >
> > On 06-Feb-2014, at 4:24 PM, Daan Hoogland
> > 
> > wrote:
> >
> >> looks nice, it will be backed by the current query for one id? or
> >> will you write a findByIds()?
> >>
> >> On Thu, Feb 6, 2014 at 9:35 AM, Abhinandan Prateek
> >>  wrote:
> >>> +1, The listVM call is one of the most resource intensive call.
> >>> +Any
> >>> step
> >>> to optimise it are welcome.
> >>>
>  On 06/02/14 2:01 pm, "Koushik Das" 
> wrote:
> 
>  Currently list VM can only be called using a single VM ID. So
>  if there is a need to query a set of VMs using ID then either
>  multiple list VM calls need to be made or all VMs needs to be
>  fetched and then do a client side filtering. Both approaches
>  are sub-optimal - the former results in multiple queries to
>  database and the latter will be an overkill if you need a small
>  subset from a very large number of VMs.
> 
>  The proposal is to have an additional parameter to specify a
>  list of VM IDs for which the data needs to be fetched. Using
>  this the required VMs can be queried in an efficient mann

devcloud vagrant minimal environment - ready for testing

2014-02-13 Thread chris snow
The devcloud vagrant minimal box is ready for testing.

The instructions are here: https://github.com/snowch/devcloud

Can you please raise any issues on the github project site?

I'll be working on the devcloud vagrant desktop box over the weekend
and will report back when that environment is also available.

Many thanks,

Chris


RE: [VOTE] Apache CloudStack 4.3.0 (fourth round)

2014-02-13 Thread Daan Hoogland
I can confirm that it also exists in master. Unfortunately it is not high on my 
prio list right now. We have a pressing bug hurting us in our production 
systems that I will get out of the way first.

What I can say is that I am puzzled that my test works in 4.2 and before as I 
instantiate a private gateway with associated network, while the system network 
offering for private gateways has no tags and I have two guest networks.

I will return to this issue when given time.

Regards,
Daan

-Original Message-
From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com] 
Sent: woensdag 12 februari 2014 11:52
To: dev@cloudstack.apache.org
Cc: Kishan Kavala; Murali Reddy; Daan Hoogland; daan Hoogland
Subject: RE: [VOTE] Apache CloudStack 4.3.0 (fourth round)

Adding Murali as well.

Daan I am not sure if there was any specific work done on this during 4.3 to 
cause it to regress.  Did you debug this further? 

Thanks
Animesh



> -Original Message-
> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> Sent: Monday, February 10, 2014 11:42 AM
> To: dev
> Cc: Kishan Kavala
> Subject: Re: [VOTE] Apache CloudStack 4.3.0 (fourth round)
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-6069
> 
> I will try in master as well. And look for a solution there.
> 
> On Mon, Feb 10, 2014 at 8:13 PM, Animesh Chaturvedi 
>  wrote:
> > Daan
> >
> > Can you create a tracking bug for this issue? Adding Kishan for his 
> > input
> >
> > Animesh
> >
> >> -Original Message-
> >> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> >> Sent: Monday, February 10, 2014 10:25 AM
> >> To: dev
> >> Subject: Re: [VOTE] Apache CloudStack 4.3.0 (fourth round)
> >>
> >> H,
> >>
> >> -1 (binding)
> >>
> >> I have a backwards compatibility issue with 4.3. It might turn out 
> >> to be a setup thing but I have verified that 4.2.1 works with my setup.
> >> I have four basic test cases|:
> >> 1. create network and vm on top - works 2. create bridged network 
> >> and create vm on it - works 3. create a vpc with private gateway 
> >> (and
> >> ...) - fails 4. create a vpc with nicira based private gateway - 
> >> works
> >>
> >> I haven't actually tried 1,2 and 4 on this rc because 3 was always 
> >> giving me the most problems. The others worked on the previous rc.
> >> Having discussed this with Hugo, we'll probably not stop using 4.3 
> >> if it passes but it needs fixing asap.
> >>
> >> setup
> >> 1 zone
> >> 1 pod
> >> 1 cluster
> >> 2 hosts (xen 6.0.2)
> >>
> >> 2 physnets
> >> - physnet 1 vlan based (Public, Guest(tagged "vlan-based"), 
> >> Management,
> >> Storage)
> >> - physnet 2 nicira based (Guest (tagged "nicira-based"))
> >>
> >> Now creating a private gateway on the vpc using marvin I get a 530 
> >> server error. I dare to put a -1 here as it is a majority vote. One 
> >> of the things that makes me hesitate is
> >> 4.2.1 code (succeeding):
> >> 2014-02-10 15:43:45,621 DEBUG [xen.resource.CitrixResourceBase]
> >> (DirectAgent-4:null) Creating VLAN 322 on host 10.200.23.41 on 
> >> device
> >> tunnel0
> >> 4.3.0 code (failing)
> >> 2014-02-10 17:33:51,083 DEBUG [c.c.h.x.r.CitrixResourceBase]
> >> (DirectAgent-4:ctx-6d5f0cd4) Creating VLAN 322 on host 10.200.23.42 
> >> on device tunnel0
> >>
> >>
> >> On Mon, Feb 10, 2014 at 12:28 PM, Nux!  wrote:
> >> > On 08.02.2014 10:56, Nux! wrote:
> >> >>
> >> >> On 08.02.2014 00:51, Animesh Chaturvedi wrote:
> >> >>>
> >> >>> Hi All,
> >> >>>
> >> >>>
> >> >>> I've created a 4.3.0 release, with the following artifacts up 
> >> >>> for a
> >> >>> vote:
> >> >>
> >> >>
> >> >> +1 from me, upgrade from 4.2.1 works fine. Tested with CentOS, 
> >> >> +KVM,
> >> >> NFS, CLVM, Adv+SG.
> >> >
> >> >
> >> > There might be a problem with the HA engine, please see
> >> > https://issues.apache.org/jira/browse/CLOUDSTACK-6065
> >> >
> >> >
> >> > --
> >> > Sent from the Delta quadrant using Borg technology!
> >> >
> >> > Nux!
> >> > www.nux.ro
> >>
> >>
> >>
> >> --
> >> Daan
> 
> 
> 
> --
> Daan


[Proposal] Virtual Router service failure alerting

2014-02-13 Thread Harikrishna Patnala
Hi,

Currently in CS we can monitor the running services on Virtual Router and 
ensure they are running through the lifetime of VR. Upon failure of any service 
in VR, monitoring service logs the alerts in VR logs.
These alerts need to be pushed to management server to notify admin.

For this I’d like to introduce the feature Virtual Router service failure 
alerting.

[1] https://issues.apache.org/jira/browse/CLOUDSTACK-6090
[2] 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Virtual+Router+Service+Failure+Alerting


Comments/feedback are welcome

Thank you,
Harikrishna


cherry pick commit to 4.3

2014-02-13 Thread Jayapal Reddy Uradi
Hi Animesh,

Please cherry pick the below commit to 4.3 from 4.3-forward.

e8f93f28fc424c73156723d9b65b13c05dafc5a8

Bug-id: CLOUDSTACK-6083

Thanks,
Jayapal


Re: Review Request 17702: CLOUDSTACK-2232: Adding automation test cases for Persistent Networks feature

2014-02-13 Thread Ashutosh Kelkar


> On Feb. 12, 2014, 5:23 p.m., Santhosh Edukulla wrote:
> > test/integration/component/test_persistent_networks.py, line 670
> > 
> >
> > This step is not visible in test code, is it like enable\disable flag 
> > to create network? or offeringid we are passing?

The network offering is created according to the value passed to the test case 
(LB through VR or LB through Netscaler) and isolated persistent network is 
created in the next step using that network offering. Please check line 560 
(Network creation).


> On Feb. 12, 2014, 5:23 p.m., Santhosh Edukulla wrote:
> > test/integration/component/test_persistent_networks.py, line 304
> > 
> >
> > Not clear with break here, what to do post break. In the tests, we are 
> > not checking these cases of return?

We are checking if the VM is expunged or not. When the vm list is empty, that 
means vm is expunged hence we are breaking and returning. But yes, it is not 
clearly understandable, I will modify the code to make it lucid.


> On Feb. 12, 2014, 5:23 p.m., Santhosh Edukulla wrote:
> > test/integration/component/test_persistent_networks.py, line 690
> > 
> >
> > Please empty the clean up list after every case in tear down post after 
> > cleanup

Done


> On Feb. 12, 2014, 5:23 p.m., Santhosh Edukulla wrote:
> > test/integration/component/test_persistent_networks.py, line 708
> > 
> >
> > We dont check the return of function here.

The function checks if router is accessible or not. We are not returning 
anything. If router is not accessible, assertion error will be thrown.


> On Feb. 12, 2014, 5:23 p.m., Santhosh Edukulla wrote:
> > test/integration/component/test_persistent_networks.py, line 741
> > 
> >
> > This step is not visible in steps though.

Network is created in the test case. Adding comment to make it more readable. 


> On Feb. 12, 2014, 5:23 p.m., Santhosh Edukulla wrote:
> > test/integration/component/test_persistent_networks.py, line 818
> > 
> >
> > Lot of places this code is repeated, may be we can use a small utility 
> > function to keep it simple.

Done


> On Feb. 12, 2014, 5:23 p.m., Santhosh Edukulla wrote:
> > test/integration/component/test_persistent_networks.py, line 848
> > 
> >
> > why this code is used two times before and after router list?

It is checking the router accessibility for two different networks. Same 
variable was used for both the lists that's why confusion. I have changed the 
names so that it is clear.


> On Feb. 12, 2014, 5:23 p.m., Santhosh Edukulla wrote:
> > test/integration/component/test_persistent_networks.py, line 1072
> > 
> >
> > If it fails here, account wont be deleted? Dont we add to clean up in 
> > case if it fails and during teardown account gets cleaned up?

Account is already added in the cleanup list.


> On Feb. 12, 2014, 5:23 p.m., Santhosh Edukulla wrote:
> > tools/marvin/marvin/integration/lib/base.py, line 125
> > 
> >
> > May be we can control the behavior or true\false using one function 
> > only. We don't need both disable and lock i believe

I created two functions just to keep it simple, without adding flags in the 
same function. So that it is clear what operation we are performing. We can 
club into same function but then the name of the function will not be that 
clear as exactly what operation it is performing.


- Ashutosh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17702/#review34292
---


On Feb. 4, 2014, 12:08 p.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17702/
> ---
> 
> (Updated Feb. 4, 2014, 12:08 p.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-2232
> https://issues.apache.org/jira/browse/CLOUDSTACK-2232
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Adding automation test cases for Persistent Networks feature.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_persistent_networks.py f61ccaa 
>   tools/marvin/marvin/config

RE: Hyper-v via the UI drops the password

2014-02-13 Thread Paul Angus
I picked up the agent from Jenkins yesterday, looking today I see that the job 
hadn't been run for a couple of weeks. I'd assumed that it ran on a regular 
basis and that it would have be run automatically whenever new code was checked 
in.

I got Jenkins to do a new build and now I can add the primary storage.

Regards

Paul Angus
Cloud Architect
S: +44 20 3603 0540 | M: +447711418784 | T: CloudyAngus
paul.an...@shapeblue.com

From: Rajesh Battala [mailto:rajesh.batt...@citrix.com]
Sent: 13 February 2014 02:10
To: Paul Angus; dev@cloudstack.apache.org
Cc: Devdeep Singh
Subject: RE: Hyper-v via the UI drops the password

We don't log the password as it is sensitive. As Devdeep told can you update 
the agent and try it.

From: Paul Angus [mailto:paul.an...@shapeblue.com]
Sent: Wednesday, February 12, 2014 9:46 PM
To: dev@cloudstack.apache.org
Cc: Rajesh Battala; Devdeep Singh
Subject: Hyper-v via the UI drops the password

Hi,

So trying to add storage to hyper-v via the ui as I can't figure out how to do 
it via cloudmonkey - the password appears to get dropped when the api call is 
made - details[2] is truncated to just .

I assume this is why I can't add primary storage via the UI.


2014-02-12 16:08:27,458 DEBUG [c.c.a.ApiServlet] 
(catalina-exec-25:ctx-875ce97f) ===START===  10.0.0.28 -- GET  
command=createStoragePool&scope=cluster&zoneid=dfe5c3fa-cbfc-4d18-a978-5f8dfcfc39b8&podid=367cdf41-f2fd-431c-97f8-4df30601c8d0&clusterid=d94e2346-7e93-4501-8a25-b3706b8639ae&name=hyperv-pri&details[0].user=hyperv&details[1].&details[2].domain=angusnet.local&url=cifs%3A%2F%2F10.0.1.27%2FhypervPri%2Fstor%2FPrimary&response=json&sessionkey=nBZHGWLcZWehJSQRX3rEznDFnBc%3D&_=1392221298237
2014-02-12 16:08:27,469 DEBUG 
[o.a.c.s.d.l.CloudStackPrimaryDataStoreLifeCycleImpl] 
(catalina-exec-25:ctx-875ce97f ctx-bd4cc9d0) createPool Params @ scheme - cifs 
storageHost - 10.0.1.27 hostPath - /hypervPri/stor/Primary port - -1
2014-02-12 16:08:27,483 DEBUG 
[o.a.c.s.d.l.CloudStackPrimaryDataStoreLifeCycleImpl] 
(catalina-exec-25:ctx-875ce97f ctx-bd4cc9d0) creating pool null on  host 2
2014-02-12 16:08:27,487 DEBUG [c.c.a.t.Request] (catalina-exec-25:ctx-875ce97f 
ctx-bd4cc9d0) Seq 2-48889885: Sending  { Cmd , MgmtId: 345049353548, via: 
2(10.0.0.24), Ver: v1, Flags: 100011, 
[{"com.cloud.agent.api.CreateStoragePoolCommand":{"add":true,"pool":{"id":5,"uuid":"522b4ee5-8398-3255-976d-206505fcf0bb","host":"10.0.1.27","path":"/hypervPri/stor/Primary?user=hyperv&domain=angusnet.local","port":445,"type":"SMB"},"localPath":"/mnt//fab86018-8819-32c6-9c98-3a28c378442a","wait":0}}]
 }
2014-02-12 16:08:27,487 DEBUG [c.c.a.t.Request] (catalina-exec-25:ctx-875ce97f 
ctx-bd4cc9d0) Seq 2-48889885: Executing:  { Cmd , MgmtId: 345049353548, via: 
2(10.0.0.24), Ver: v1, Flags: 100011, 
[{"com.cloud.agent.api.CreateStoragePoolCommand":{"add":true,"pool":{"id":5,"uuid":"522b4ee5-8398-3255-976d-206505fcf0bb","host":"10.0.1.27","path":"/hypervPri/stor/Primary?user=hyperv&domain=angusnet.local","port":445,"type":"SMB"},"localPath":"/mnt//fab86018-8819-32c6-9c98-3a28c378442a","wait":0}}]
 }
2014-02-12 16:08:27,488 DEBUG [c.c.a.m.DirectAgentAttache] 
(DirectAgent-140:ctx-64f8ef58) Seq 2-48889885: Executing request
2014-02-12 16:08:27,488 DEBUG [c.c.h.h.r.HypervDirectConnectResource] 
(DirectAgent-140:ctx-64f8ef58) POST request to 
https://10.0.0.24:8250/api/HypervResource/com.cloud.agent.api.CreateStoragePoolCommand
 with contents 
{"add":true,"pool":{"id":5,"uuid":"522b4ee5-8398-3255-976d-206505fcf0bb","host":"10.0.1.27","path":"/hypervPri/stor/Primary?user=hyperv&domain=angusnet.local","port":445,"type":"SMB"},"localPath":"/mnt//fab86018-8819-32c6-9c98-3a28c378442a","contextMap":{},"wait":0}
2014-02-12 16:08:27,498 DEBUG [c.c.h.h.r.HypervDirectConnectResource] 
(DirectAgent-140:ctx-64f8ef58) Sending cmd to 
https://10.0.0.24:8250/api/HypervResource/com.cloud.agent.api.CreateStoragePoolCommand
 cmd 
data:{"add":true,"pool":{"id":5,"uuid":"522b4ee5-8398-3255-976d-206505fcf0bb","host":"10.0.1.27","path":"/hypervPri/stor/Primary?user=hyperv&domain=angusnet.local","port":445,"type":"SMB"},"localPath":"/mnt//fab86018-8819-32c6-9c98-3a28c378442a","contextMap":{},"wait":0}
2014-02-12 16:08:27,572 DEBUG [c.c.h.h.r.HypervDirectConnectResource] 
(DirectAgent-140:ctx-64f8ef58) POST response is 
[{"com.cloud.agent.api.Answer":{"result":true,"details":"success - 
NOP","contextMap":{}}}]
2014-02-12 16:08:27,573 DEBUG [c.c.h.h.r.HypervDirectConnectResource] 
(DirectAgent-140:ctx-64f8ef58) executeRequest received response 
[Lcom.cloud.agent.api.Answer;@7756d39
2014-02-12 16:08:27,573 DEBUG [c.c.a.m.DirectAgentAttache] 
(DirectAgent-140:ctx-64f8ef58) Seq 2-48889885: Response Received:
2014-02-12 16:08:27,573 DEBUG [c.c.a.t.Request] (DirectAgent-140:ctx-64f8ef58) 
Seq 2-48889885: Processing:  { Ans: , MgmtId: 345049353548, via: 2, Ver: v1, 
Flags: 10, [{"com.cloud.agent.api.Answer":{"result":true,"deta

RE: [VOTE] Apache CloudStack 4.3.0 (fourth round)

2014-02-13 Thread Kishan Kavala
Daan,
 I couldn't repo CLOUDSTACK-6069 in my regular VPC setup.  Does this happen 
only when using mixed setup with Nicira?

> -Original Message-
> From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com]
> Sent: Thursday, 13 February 2014 2:29 PM
> To: Animesh Chaturvedi; dev@cloudstack.apache.org
> Cc: Kishan Kavala; Murali Reddy; daan Hoogland
> Subject: RE: [VOTE] Apache CloudStack 4.3.0 (fourth round)
> 
> I can confirm that it also exists in master. Unfortunately it is not high on 
> my
> prio list right now. We have a pressing bug hurting us in our production
> systems that I will get out of the way first.
> 
> What I can say is that I am puzzled that my test works in 4.2 and before as I
> instantiate a private gateway with associated network, while the system
> network offering for private gateways has no tags and I have two guest
> networks.
> 
> I will return to this issue when given time.
> 
> Regards,
> Daan
> 
> -Original Message-
> From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com]
> Sent: woensdag 12 februari 2014 11:52
> To: dev@cloudstack.apache.org
> Cc: Kishan Kavala; Murali Reddy; Daan Hoogland; daan Hoogland
> Subject: RE: [VOTE] Apache CloudStack 4.3.0 (fourth round)
> 
> Adding Murali as well.
> 
> Daan I am not sure if there was any specific work done on this during 4.3 to
> cause it to regress.  Did you debug this further?
> 
> Thanks
> Animesh
> 
> 
> 
> > -Original Message-
> > From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> > Sent: Monday, February 10, 2014 11:42 AM
> > To: dev
> > Cc: Kishan Kavala
> > Subject: Re: [VOTE] Apache CloudStack 4.3.0 (fourth round)
> >
> > https://issues.apache.org/jira/browse/CLOUDSTACK-6069
> >
> > I will try in master as well. And look for a solution there.
> >
> > On Mon, Feb 10, 2014 at 8:13 PM, Animesh Chaturvedi
> >  wrote:
> > > Daan
> > >
> > > Can you create a tracking bug for this issue? Adding Kishan for his
> > > input
> > >
> > > Animesh
> > >
> > >> -Original Message-
> > >> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> > >> Sent: Monday, February 10, 2014 10:25 AM
> > >> To: dev
> > >> Subject: Re: [VOTE] Apache CloudStack 4.3.0 (fourth round)
> > >>
> > >> H,
> > >>
> > >> -1 (binding)
> > >>
> > >> I have a backwards compatibility issue with 4.3. It might turn out
> > >> to be a setup thing but I have verified that 4.2.1 works with my setup.
> > >> I have four basic test cases|:
> > >> 1. create network and vm on top - works 2. create bridged network
> > >> and create vm on it - works 3. create a vpc with private gateway
> > >> (and
> > >> ...) - fails 4. create a vpc with nicira based private gateway -
> > >> works
> > >>
> > >> I haven't actually tried 1,2 and 4 on this rc because 3 was always
> > >> giving me the most problems. The others worked on the previous rc.
> > >> Having discussed this with Hugo, we'll probably not stop using 4.3
> > >> if it passes but it needs fixing asap.
> > >>
> > >> setup
> > >> 1 zone
> > >> 1 pod
> > >> 1 cluster
> > >> 2 hosts (xen 6.0.2)
> > >>
> > >> 2 physnets
> > >> - physnet 1 vlan based (Public, Guest(tagged "vlan-based"),
> > >> Management,
> > >> Storage)
> > >> - physnet 2 nicira based (Guest (tagged "nicira-based"))
> > >>
> > >> Now creating a private gateway on the vpc using marvin I get a 530
> > >> server error. I dare to put a -1 here as it is a majority vote. One
> > >> of the things that makes me hesitate is
> > >> 4.2.1 code (succeeding):
> > >> 2014-02-10 15:43:45,621 DEBUG [xen.resource.CitrixResourceBase]
> > >> (DirectAgent-4:null) Creating VLAN 322 on host 10.200.23.41 on
> > >> device
> > >> tunnel0
> > >> 4.3.0 code (failing)
> > >> 2014-02-10 17:33:51,083 DEBUG [c.c.h.x.r.CitrixResourceBase]
> > >> (DirectAgent-4:ctx-6d5f0cd4) Creating VLAN 322 on host 10.200.23.42
> > >> on device tunnel0
> > >>
> > >>
> > >> On Mon, Feb 10, 2014 at 12:28 PM, Nux!  wrote:
> > >> > On 08.02.2014 10:56, Nux! wrote:
> > >> >>
> > >> >> On 08.02.2014 00:51, Animesh Chaturvedi wrote:
> > >> >>>
> > >> >>> Hi All,
> > >> >>>
> > >> >>>
> > >> >>> I've created a 4.3.0 release, with the following artifacts up
> > >> >>> for a
> > >> >>> vote:
> > >> >>
> > >> >>
> > >> >> +1 from me, upgrade from 4.2.1 works fine. Tested with CentOS,
> > >> >> +KVM,
> > >> >> NFS, CLVM, Adv+SG.
> > >> >
> > >> >
> > >> > There might be a problem with the HA engine, please see
> > >> > https://issues.apache.org/jira/browse/CLOUDSTACK-6065
> > >> >
> > >> >
> > >> > --
> > >> > Sent from the Delta quadrant using Borg technology!
> > >> >
> > >> > Nux!
> > >> > www.nux.ro
> > >>
> > >>
> > >>
> > >> --
> > >> Daan
> >
> >
> >
> > --
> > Daan


RE: [VOTE] Apache CloudStack 4.3.0 (fourth round)

2014-02-13 Thread Daan Hoogland
Yes it does,

Two guest networks both tagged. system net offer isn't tagged. that's why it is 
strange it used to work.

-Original Message-
From: Kishan Kavala [mailto:kishan.kav...@citrix.com] 
Sent: donderdag 13 februari 2014 11:59
To: Daan Hoogland; Animesh Chaturvedi; dev@cloudstack.apache.org
Cc: Murali Reddy; daan Hoogland
Subject: RE: [VOTE] Apache CloudStack 4.3.0 (fourth round)

Daan,
 I couldn't repo CLOUDSTACK-6069 in my regular VPC setup.  Does this happen 
only when using mixed setup with Nicira?

> -Original Message-
> From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com]
> Sent: Thursday, 13 February 2014 2:29 PM
> To: Animesh Chaturvedi; dev@cloudstack.apache.org
> Cc: Kishan Kavala; Murali Reddy; daan Hoogland
> Subject: RE: [VOTE] Apache CloudStack 4.3.0 (fourth round)
> 
> I can confirm that it also exists in master. Unfortunately it is not 
> high on my prio list right now. We have a pressing bug hurting us in 
> our production systems that I will get out of the way first.
> 
> What I can say is that I am puzzled that my test works in 4.2 and 
> before as I instantiate a private gateway with associated network, 
> while the system network offering for private gateways has no tags and 
> I have two guest networks.
> 
> I will return to this issue when given time.
> 
> Regards,
> Daan
> 
> -Original Message-
> From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com]
> Sent: woensdag 12 februari 2014 11:52
> To: dev@cloudstack.apache.org
> Cc: Kishan Kavala; Murali Reddy; Daan Hoogland; daan Hoogland
> Subject: RE: [VOTE] Apache CloudStack 4.3.0 (fourth round)
> 
> Adding Murali as well.
> 
> Daan I am not sure if there was any specific work done on this during 
> 4.3 to cause it to regress.  Did you debug this further?
> 
> Thanks
> Animesh
> 
> 
> 
> > -Original Message-
> > From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> > Sent: Monday, February 10, 2014 11:42 AM
> > To: dev
> > Cc: Kishan Kavala
> > Subject: Re: [VOTE] Apache CloudStack 4.3.0 (fourth round)
> >
> > https://issues.apache.org/jira/browse/CLOUDSTACK-6069
> >
> > I will try in master as well. And look for a solution there.
> >
> > On Mon, Feb 10, 2014 at 8:13 PM, Animesh Chaturvedi 
> >  wrote:
> > > Daan
> > >
> > > Can you create a tracking bug for this issue? Adding Kishan for 
> > > his input
> > >
> > > Animesh
> > >
> > >> -Original Message-
> > >> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> > >> Sent: Monday, February 10, 2014 10:25 AM
> > >> To: dev
> > >> Subject: Re: [VOTE] Apache CloudStack 4.3.0 (fourth round)
> > >>
> > >> H,
> > >>
> > >> -1 (binding)
> > >>
> > >> I have a backwards compatibility issue with 4.3. It might turn 
> > >> out to be a setup thing but I have verified that 4.2.1 works with my 
> > >> setup.
> > >> I have four basic test cases|:
> > >> 1. create network and vm on top - works 2. create bridged network 
> > >> and create vm on it - works 3. create a vpc with private gateway 
> > >> (and
> > >> ...) - fails 4. create a vpc with nicira based private gateway - 
> > >> works
> > >>
> > >> I haven't actually tried 1,2 and 4 on this rc because 3 was 
> > >> always giving me the most problems. The others worked on the previous rc.
> > >> Having discussed this with Hugo, we'll probably not stop using 
> > >> 4.3 if it passes but it needs fixing asap.
> > >>
> > >> setup
> > >> 1 zone
> > >> 1 pod
> > >> 1 cluster
> > >> 2 hosts (xen 6.0.2)
> > >>
> > >> 2 physnets
> > >> - physnet 1 vlan based (Public, Guest(tagged "vlan-based"), 
> > >> Management,
> > >> Storage)
> > >> - physnet 2 nicira based (Guest (tagged "nicira-based"))
> > >>
> > >> Now creating a private gateway on the vpc using marvin I get a 
> > >> 530 server error. I dare to put a -1 here as it is a majority 
> > >> vote. One of the things that makes me hesitate is
> > >> 4.2.1 code (succeeding):
> > >> 2014-02-10 15:43:45,621 DEBUG [xen.resource.CitrixResourceBase]
> > >> (DirectAgent-4:null) Creating VLAN 322 on host 10.200.23.41 on 
> > >> device
> > >> tunnel0
> > >> 4.3.0 code (failing)
> > >> 2014-02-10 17:33:51,083 DEBUG [c.c.h.x.r.CitrixResourceBase]
> > >> (DirectAgent-4:ctx-6d5f0cd4) Creating VLAN 322 on host 
> > >> 10.200.23.42 on device tunnel0
> > >>
> > >>
> > >> On Mon, Feb 10, 2014 at 12:28 PM, Nux!  wrote:
> > >> > On 08.02.2014 10:56, Nux! wrote:
> > >> >>
> > >> >> On 08.02.2014 00:51, Animesh Chaturvedi wrote:
> > >> >>>
> > >> >>> Hi All,
> > >> >>>
> > >> >>>
> > >> >>> I've created a 4.3.0 release, with the following artifacts up 
> > >> >>> for a
> > >> >>> vote:
> > >> >>
> > >> >>
> > >> >> +1 from me, upgrade from 4.2.1 works fine. Tested with CentOS, 
> > >> >> +KVM,
> > >> >> NFS, CLVM, Adv+SG.
> > >> >
> > >> >
> > >> > There might be a problem with the HA engine, please see
> > >> > https://issues.apache.org/jira/browse/CLOUDSTACK-6065
> > >> >
> > >> >
> > >> > --
> > >> > Sent from the Delta quadrant using Borg technology!
> > >

Re: [VOTE] Apache CloudStack 4.3.0 (fourth round) UPDATE

2014-02-13 Thread Nux!

On 13.02.2014 05:28, Animesh Chaturvedi wrote:


1. CLOUDSTACK-6083 : Missing CIDRs in firewall rules after upgrade
 => Waiting on Jayapal to confirm and update the list with findings


Jayapal's fix works for me.


3. CLOUDSTACK-6065: KVM HA not working for shutdown VMs
=> While an issue but my understanding is it is a corner scenario
only affecting KVM and can be released  as a known issue


Well, it's effectively breaking HA as defined in the docs for a main hv 
type and as it is I can't use 4.3 in production. Is there a fix in 
sight?


Lucian

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro


Review Request 18066: Fixing troubling issues on contrail plugin found by FindBugs

2014-02-13 Thread Wilder Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18066/
---

Review request for cloudstack, daan Hoogland and Hugo Trippaers.


Repository: cloudstack-git


Description
---

Fixing troubling issues on contrail plugin related to dereference nullpoint; 
adding unit tests to cover changes on the compare method on the 
VirtualNetworkModel


Diffs
-

  
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java
 b25de48 
  
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObject.java
 1b048ed 
  
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java
 0ce22ad 
  
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java
 4d0218c 
  
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java
 b0505b1 
  
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/model/VirtualMachineModelTest.java
 f85beb6 
  
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/model/VirtualNetworkModelTest.java
 b1b5ae1 

Diff: https://reviews.apache.org/r/18066/diff/


Testing
---

Build successful + 3 unit tests added in order to cover compare methods cases.


Thanks,

Wilder Rodrigues



Review Request 18068: Adding fixes and unit tests for cloud-engine-api scariest bugs found by FindBugs

2014-02-13 Thread Wilder Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18068/
---

Review request for cloudstack, daan Hoogland and Hugo Trippaers.


Repository: cloudstack-git


Description
---

Adding fixes and unit tests for cloud-engine-api scariest bugs found by FindBugs


Diffs
-

  
engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/type/VolumeTypeBase.java
 78ac8e2 
  
engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/type/VolumeTypeHelper.java
 5057203 
  
engine/api/test/org/apache/cloudstack/engine/subsystem/api/storage/type/VolumeTypeHelperTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/18068/diff/


Testing
---

Build successful + 8 unit tests added to cover the changes


Thanks,

Wilder Rodrigues



Review Request 18069: Fixing FindBugs scariest for replaceFirst() method call that does not assign the return value

2014-02-13 Thread Wilder Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18069/
---

Review request for cloudstack, daan Hoogland and Hugo Trippaers.


Repository: cloudstack-git


Description
---

Fixing FindBugs scariest for replaceFirst() method call that  does not assign 
the return value


Diffs
-

  
plugins/storage/volume/default/src/org/apache/cloudstack/storage/datastore/lifecycle/CloudStackPrimaryDataStoreLifeCycleImpl.java
 37861b4 
  
plugins/storage/volume/default/src/org/apache/cloudstack/storage/datastore/provider/CloudStackPrimaryDataStoreProviderImpl.java
 410416c 

Diff: https://reviews.apache.org/r/18069/diff/


Testing
---

Build ran successfully


Thanks,

Wilder Rodrigues



Review Request 18067: Fixed "scary bug" according to find bugs. (SBP find bugs hackaton)

2014-02-13 Thread Sander Botman

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18067/
---

Review request for cloudstack, daan Hoogland and Hugo Trippaers.


Repository: cloudstack-git


Description
---

Used FindBugs to find some possible scary bugs and wrote some unit tests for 
them.


Diffs
-

  plugins/hypervisors/xen/src/com/cloud/ha/XenServerFencer.java 5604db8 
  
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
 cf5c6d6 
  plugins/hypervisors/xen/test/com/cloud/ha/XenServerFencerTest.java 
PRE-CREATION 
  
plugins/hypervisors/xen/test/com/cloud/hypervisor/xen/resource/CitrixResourceBaseTest.java
 c56cc6d 

Diff: https://reviews.apache.org/r/18067/diff/


Testing
---

Refactored some code and wrote unit tests


Thanks,

Sander Botman



RE: Hyper-v via the UI drops the password

2014-02-13 Thread Rajesh Battala
Great to see Paul the issue is resolved.

Thanks
Rajesh Battala

From: Paul Angus [mailto:paul.an...@shapeblue.com]
Sent: Thursday, February 13, 2014 4:10 PM
To: Rajesh Battala; dev@cloudstack.apache.org
Cc: Devdeep Singh; Alex Hitchins
Subject: RE: Hyper-v via the UI drops the password

I picked up the agent from Jenkins yesterday, looking today I see that the job 
hadn't been run for a couple of weeks. I'd assumed that it ran on a regular 
basis and that it would have be run automatically whenever new code was checked 
in.

I got Jenkins to do a new build and now I can add the primary storage.

Regards

Paul Angus
Cloud Architect
S: +44 20 3603 0540 | M: +447711418784 | T: CloudyAngus
paul.an...@shapeblue.com

From: Rajesh Battala [mailto:rajesh.batt...@citrix.com]
Sent: 13 February 2014 02:10
To: Paul Angus; dev@cloudstack.apache.org
Cc: Devdeep Singh
Subject: RE: Hyper-v via the UI drops the password

We don't log the password as it is sensitive. As Devdeep told can you update 
the agent and try it.

From: Paul Angus [mailto:paul.an...@shapeblue.com]
Sent: Wednesday, February 12, 2014 9:46 PM
To: dev@cloudstack.apache.org
Cc: Rajesh Battala; Devdeep Singh
Subject: Hyper-v via the UI drops the password

Hi,

So trying to add storage to hyper-v via the ui as I can't figure out how to do 
it via cloudmonkey - the password appears to get dropped when the api call is 
made - details[2] is truncated to just .

I assume this is why I can't add primary storage via the UI.


2014-02-12 16:08:27,458 DEBUG [c.c.a.ApiServlet] 
(catalina-exec-25:ctx-875ce97f) ===START===  10.0.0.28 -- GET  
command=createStoragePool&scope=cluster&zoneid=dfe5c3fa-cbfc-4d18-a978-5f8dfcfc39b8&podid=367cdf41-f2fd-431c-97f8-4df30601c8d0&clusterid=d94e2346-7e93-4501-8a25-b3706b8639ae&name=hyperv-pri&details[0].user=hyperv&details[1].&details[2].domain=angusnet.local&url=cifs%3A%2F%2F10.0.1.27%2FhypervPri%2Fstor%2FPrimary&response=json&sessionkey=nBZHGWLcZWehJSQRX3rEznDFnBc%3D&_=1392221298237
2014-02-12 16:08:27,469 DEBUG 
[o.a.c.s.d.l.CloudStackPrimaryDataStoreLifeCycleImpl] 
(catalina-exec-25:ctx-875ce97f ctx-bd4cc9d0) createPool Params @ scheme - cifs 
storageHost - 10.0.1.27 hostPath - /hypervPri/stor/Primary port - -1
2014-02-12 16:08:27,483 DEBUG 
[o.a.c.s.d.l.CloudStackPrimaryDataStoreLifeCycleImpl] 
(catalina-exec-25:ctx-875ce97f ctx-bd4cc9d0) creating pool null on  host 2
2014-02-12 16:08:27,487 DEBUG [c.c.a.t.Request] (catalina-exec-25:ctx-875ce97f 
ctx-bd4cc9d0) Seq 2-48889885: Sending  { Cmd , MgmtId: 345049353548, via: 
2(10.0.0.24), Ver: v1, Flags: 100011, 
[{"com.cloud.agent.api.CreateStoragePoolCommand":{"add":true,"pool":{"id":5,"uuid":"522b4ee5-8398-3255-976d-206505fcf0bb","host":"10.0.1.27","path":"/hypervPri/stor/Primary?user=hyperv&domain=angusnet.local","port":445,"type":"SMB"},"localPath":"/mnt//fab86018-8819-32c6-9c98-3a28c378442a","wait":0}}]
 }
2014-02-12 16:08:27,487 DEBUG [c.c.a.t.Request] (catalina-exec-25:ctx-875ce97f 
ctx-bd4cc9d0) Seq 2-48889885: Executing:  { Cmd , MgmtId: 345049353548, via: 
2(10.0.0.24), Ver: v1, Flags: 100011, 
[{"com.cloud.agent.api.CreateStoragePoolCommand":{"add":true,"pool":{"id":5,"uuid":"522b4ee5-8398-3255-976d-206505fcf0bb","host":"10.0.1.27","path":"/hypervPri/stor/Primary?user=hyperv&domain=angusnet.local","port":445,"type":"SMB"},"localPath":"/mnt//fab86018-8819-32c6-9c98-3a28c378442a","wait":0}}]
 }
2014-02-12 16:08:27,488 DEBUG [c.c.a.m.DirectAgentAttache] 
(DirectAgent-140:ctx-64f8ef58) Seq 2-48889885: Executing request
2014-02-12 16:08:27,488 DEBUG [c.c.h.h.r.HypervDirectConnectResource] 
(DirectAgent-140:ctx-64f8ef58) POST request to 
https://10.0.0.24:8250/api/HypervResource/com.cloud.agent.api.CreateStoragePoolCommand
 with contents 
{"add":true,"pool":{"id":5,"uuid":"522b4ee5-8398-3255-976d-206505fcf0bb","host":"10.0.1.27","path":"/hypervPri/stor/Primary?user=hyperv&domain=angusnet.local","port":445,"type":"SMB"},"localPath":"/mnt//fab86018-8819-32c6-9c98-3a28c378442a","contextMap":{},"wait":0}
2014-02-12 16:08:27,498 DEBUG [c.c.h.h.r.HypervDirectConnectResource] 
(DirectAgent-140:ctx-64f8ef58) Sending cmd to 
https://10.0.0.24:8250/api/HypervResource/com.cloud.agent.api.CreateStoragePoolCommand
 cmd 
data:{"add":true,"pool":{"id":5,"uuid":"522b4ee5-8398-3255-976d-206505fcf0bb","host":"10.0.1.27","path":"/hypervPri/stor/Primary?user=hyperv&domain=angusnet.local","port":445,"type":"SMB"},"localPath":"/mnt//fab86018-8819-32c6-9c98-3a28c378442a","contextMap":{},"wait":0}
2014-02-12 16:08:27,572 DEBUG [c.c.h.h.r.HypervDirectConnectResource] 
(DirectAgent-140:ctx-64f8ef58) POST response is 
[{"com.cloud.agent.api.Answer":{"result":true,"details":"success - 
NOP","contextMap":{}}}]
2014-02-12 16:08:27,573 DEBUG [c.c.h.h.r.HypervDirectConnectResource] 
(DirectAgent-140:ctx-64f8ef58) executeRequest received response 
[Lcom.cloud.agent.api.Answer;@7756d39
2014-02-12 16:08:27,573

Review Request 18070: Fixing 12 scary from the engine-storage-volume module found by FindBugs

2014-02-13 Thread Wilder Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18070/
---

Review request for cloudstack, daan Hoogland and Hugo Trippaers.


Repository: cloudstack-git


Description
---

Fixing 12 scary from the engine-storage-volume module. All the issues were 
related to passing null to methods that expect a non-null parameter and also 
methods passing wrong types.


Diffs
-

  
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
 3e315da 

Diff: https://reviews.apache.org/r/18070/diff/


Testing
---

Build passed succesfully


Thanks,

Wilder Rodrigues



Review Request 18072: Fixing 11 scary and 1 of concern issues found by findBugs. Adding 13 unit tests and also 1 validate method in the UuidUtils class.l

2014-02-13 Thread Wilder Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18072/
---

Review request for cloudstack, daan Hoogland and Hugo Trippaers.


Repository: cloudstack-git


Description
---

Fixing 11 scary and 1 of concern issues found by FindBugs. Adding 13 unit tests 
and also 1 validate method in the UuidUtils class.


Diffs
-

  
plugins/event-bus/inmemory/src/org/apache/cloudstack/mom/inmemory/InMemoryEventBus.java
 99d0a12 
  
plugins/event-bus/inmemory/test/org/apache/cloudstack/mom/inmemory/InMemoryEventBusTest.java
 PRE-CREATION 
  utils/src/com/cloud/utils/UuidUtils.java 7831bea 
  utils/test/com/cloud/utils/UuidUtilsTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/18072/diff/


Testing
---

Build successfully and added 13 unit tests


Thanks,

Wilder Rodrigues



Re: Review Request 18070: Fixing 12 scary from the engine-storage-volume module found by FindBugs

2014-02-13 Thread Wilder Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18070/
---

(Updated Feb. 13, 2014, 12:07 p.m.)


Review request for cloudstack, daan Hoogland and Hugo Trippaers.


Changes
---

Adding branch


Repository: cloudstack-git


Description
---

Fixing 12 scary from the engine-storage-volume module. All the issues were 
related to passing null to methods that expect a non-null parameter and also 
methods passing wrong types.


Diffs
-

  
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
 3e315da 

Diff: https://reviews.apache.org/r/18070/diff/


Testing
---

Build passed succesfully


Thanks,

Wilder Rodrigues



Re: Review Request 18069: Fixing FindBugs scariest for replaceFirst() method call that does not assign the return value

2014-02-13 Thread Wilder Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18069/
---

(Updated Feb. 13, 2014, 12:07 p.m.)


Review request for cloudstack, daan Hoogland and Hugo Trippaers.


Changes
---

Adding branch


Repository: cloudstack-git


Description
---

Fixing FindBugs scariest for replaceFirst() method call that  does not assign 
the return value


Diffs
-

  
plugins/storage/volume/default/src/org/apache/cloudstack/storage/datastore/lifecycle/CloudStackPrimaryDataStoreLifeCycleImpl.java
 37861b4 
  
plugins/storage/volume/default/src/org/apache/cloudstack/storage/datastore/provider/CloudStackPrimaryDataStoreProviderImpl.java
 410416c 

Diff: https://reviews.apache.org/r/18069/diff/


Testing
---

Build ran successfully


Thanks,

Wilder Rodrigues



Re: Review Request 18068: Adding fixes and unit tests for cloud-engine-api scariest bugs found by FindBugs

2014-02-13 Thread Wilder Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18068/
---

(Updated Feb. 13, 2014, 12:08 p.m.)


Review request for cloudstack, daan Hoogland and Hugo Trippaers.


Changes
---

Adding branch


Repository: cloudstack-git


Description
---

Adding fixes and unit tests for cloud-engine-api scariest bugs found by FindBugs


Diffs
-

  
engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/type/VolumeTypeBase.java
 78ac8e2 
  
engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/type/VolumeTypeHelper.java
 5057203 
  
engine/api/test/org/apache/cloudstack/engine/subsystem/api/storage/type/VolumeTypeHelperTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/18068/diff/


Testing
---

Build successful + 8 unit tests added to cover the changes


Thanks,

Wilder Rodrigues



Review Request 18074: Added few changes for CLOUDSTACK-5674

2014-02-13 Thread Santhosh Edukulla

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18074/
---

Review request for cloudstack and Girish Shilamkar.


Bugs: CLOUDSTACK-5674
https://issues.apache.org/jira/browse/CLOUDSTACK-5674


Repository: cloudstack-git


Description
---

Added few changes and clean up for 5674


Diffs
-

  tools/marvin/marvin/cloudstackTestClient.py 4d05eaf 
  tools/marvin/marvin/config/test_data.py PRE-CREATION 
  tools/marvin/marvin/marvinPlugin.py 3a97404 

Diff: https://reviews.apache.org/r/18074/diff/


Testing
---


Thanks,

Santhosh Edukulla



[4.3]

2014-02-13 Thread Daan Hoogland
Animesh,

Can you please cherry-pick 5af163ff7f658c30c6d93b50ac17c9cc0c5eb8c1 onto 4.3?

thanks,
-- 
Daan


Review Request 18077: Findbugs Fixes

2014-02-13 Thread Alexander Hitchins

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18077/
---

Review request for cloudstack, daan Hoogland and Hugo Trippaers.


Repository: cloudstack-git


Description
---

Findbugs Patches


Diffs
-

  
plugins/dedicated-resources/src/org/apache/cloudstack/dedicated/DedicatedResourceManagerImpl.java
 b82b361 
  server/src/com/cloud/network/NetworkModelImpl.java 52a08e1 
  server/src/com/cloud/network/guru/ControlNetworkGuru.java a6e2180 

Diff: https://reviews.apache.org/r/18077/diff/


Testing
---


Thanks,

Alexander Hitchins



Review Request 18078: Findbugs Fixes

2014-02-13 Thread Alexander Hitchins

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18078/
---

Review request for cloudstack, daan Hoogland and Hugo Trippaers.


Repository: cloudstack-git


Description
---

Findbugs Changes


Diffs
-

  
plugins/dedicated-resources/src/org/apache/cloudstack/dedicated/DedicatedResourceManagerImpl.java
 b82b361 
  server/src/com/cloud/network/guru/ControlNetworkGuru.java a6e2180 

Diff: https://reviews.apache.org/r/18078/diff/


Testing
---


Thanks,

Alexander Hitchins



Review Request 18079: Findbugs Fixes

2014-02-13 Thread Alexander Hitchins

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18079/
---

Review request for cloudstack, DrinnaPopopixOJ DrinnaPopopixOJ and Hugo 
Trippaers.


Repository: cloudstack-git


Description
---

Findbugs Fixes


Diffs
-

  
plugins/dedicated-resources/src/org/apache/cloudstack/dedicated/DedicatedResourceManagerImpl.java
 b82b361 

Diff: https://reviews.apache.org/r/18079/diff/


Testing
---


Thanks,

Alexander Hitchins



CLOUDSTACK-6096

2014-02-13 Thread Francois Gaudreault

Hi,

https://issues.apache.org/jira/browse/CLOUDSTACK-6096
I filed this today. This impact 4.2.1, but I would like to know if it 
also impact 4.3. Does anyone have an environment with 4.3 that would be 
able/willing to test?


Thanks!

--
Francois Gaudreault
Architecte de Solution Cloud | Cloud Solutions Architect
fgaudrea...@cloudops.com
514-629-6775
- - -
CloudOps
420 rue Guy
Montréal QC  H3J 1S6
www.cloudops.com
@CloudOps_



Re: CLOUDSTACK-6096

2014-02-13 Thread Tanner Danzey
Hi Francois,

I can potentially test this tonight for you. We're deploying 4.3 to see if
it alleviates some of our issues with S3, but thats a few hours from now in
case someine wants to test it sooner.

Regards,

Tanner
On Feb 13, 2014 7:50 AM, "Francois Gaudreault" 
wrote:

> Hi,
>
> https://issues.apache.org/jira/browse/CLOUDSTACK-6096
> I filed this today. This impact 4.2.1, but I would like to know if it also
> impact 4.3. Does anyone have an environment with 4.3 that would be
> able/willing to test?
>
> Thanks!
>
> --
> Francois Gaudreault
> Architecte de Solution Cloud | Cloud Solutions Architect
> fgaudrea...@cloudops.com
> 514-629-6775
> - - -
> CloudOps
> 420 rue Guy
> Montréal QC  H3J 1S6
> www.cloudops.com
> @CloudOps_
>
>


Re: CLOUDSTACK-6096

2014-02-13 Thread Francois Gaudreault

Thanks Tanner :) Keep us posted please :)

FG

On 2/13/2014, 8:54 AM, Tanner Danzey wrote:

Hi Francois,

I can potentially test this tonight for you. We're deploying 4.3 to see if
it alleviates some of our issues with S3, but thats a few hours from now in
case someine wants to test it sooner.

Regards,

Tanner
On Feb 13, 2014 7:50 AM, "Francois Gaudreault" 
wrote:


Hi,

https://issues.apache.org/jira/browse/CLOUDSTACK-6096
I filed this today. This impact 4.2.1, but I would like to know if it also
impact 4.3. Does anyone have an environment with 4.3 that would be
able/willing to test?

Thanks!

--
Francois Gaudreault
Architecte de Solution Cloud | Cloud Solutions Architect
fgaudrea...@cloudops.com
514-629-6775
- - -
CloudOps
420 rue Guy
Montréal QC  H3J 1S6
www.cloudops.com
@CloudOps_





--
Francois Gaudreault
Architecte de Solution Cloud | Cloud Solutions Architect
fgaudrea...@cloudops.com
514-629-6775
- - -
CloudOps
420 rue Guy
Montréal QC  H3J 1S6
www.cloudops.com
@CloudOps_



Error Message - Agent Disconnected.

2014-02-13 Thread Mo

Hello,

Can someone assist me in informing me as to what this is telling me?

 * Something went wrong; please correct the following:
   Cannot transit agent status with event AgentDisconnected for host 1,
   mangement server id is 161344192609,Unable to transition to a new
   state from Creating via AgentDisconnected


=


2014-02-12 23:25:03,365 DEBUG [agent.manager.AgentManagerImpl] 
(catalina-exec-12:null) Sending Disconnect to listener: 
com.cloud.consoleproxy.ConsoleProxyListener
2014-02-12 23:25:03,366 DEBUG [cloud.host.Status] 
(catalina-exec-12:null) Transition:[Resource state = Enabled, Agent 
event = AgentDisconnected, Host id = 1, name = node1.domain.com]
2014-02-12 23:25:03,447 DEBUG [cloud.host.Status] 
(catalina-exec-12:null) Agent status update: [id = 1; name = 
node1.domain.com; old status = Connecting; event = AgentDisconnected; 
new status = Alert; old update count = 1; new update count = 2]
2014-02-12 23:25:03,448 DEBUG [agent.manager.ClusteredAgentManagerImpl] 
(catalina-exec-12:null) Notifying other nodes of to disconnect
2014-02-12 23:25:03,449 WARN  [cloud.resource.ResourceManagerImpl] 
(catalina-exec-12:null) Unable to connect due to

com.cloud.utils.exception.CloudRuntimeException: Unable to connect 1
at 
com.cloud.agent.manager.AgentManagerImpl.notifyMonitorsOfConnection(AgentManagerImpl.java:606)
at 
com.cloud.agent.manager.AgentManagerImpl.handleDirectConnectAgent(AgentManagerImpl.java:1482)
at 
com.cloud.resource.ResourceManagerImpl.createHostAndAgentDeferred(ResourceManagerImpl.java:1872)
at 
com.cloud.resource.ResourceManagerImpl.discoverHostsFull(ResourceManagerImpl.java:778)
at 
com.cloud.resource.ResourceManagerImpl.discoverHosts(ResourceManagerImpl.java:590)
at 
org.apache.cloudstack.api.command.admin.host.AddHostCmd.execute(AddHostCmd.java:143)

at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:158)
at com.cloud.api.ApiServer.queueCommand(ApiServer.java:514)
at com.cloud.api.ApiServer.handleRequest(ApiServer.java:372)
at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:305)
at com.cloud.api.ApiServlet.doPost(ApiServlet.java:71)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:637)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
at 
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
at 
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
at 
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
at 
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
at 
org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:555)
at 
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
at 
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:298)
at 
org.apache.coyote.http11.Http11NioProcessor.process(Http11NioProcessor.java:889)
at 
org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:721)
at 
org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:2274)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1146)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)

at java.lang.Thread.run(Thread.java:701)
Caused by: java.lang.ClassCastException: com.cloud.agent.api.Answer 
cannot be cast to com.cloud.agent.api.SetupAnswer
at 
com.cloud.hypervisor.xen.discoverer.XcpServerDiscoverer.processConnect(XcpServerDiscoverer.java:646)
at 
com.cloud.agent.manager.AgentManagerImpl.notifyMonitorsOfConnection(AgentManagerImpl.java:587)

... 27 more
2014-02-12 23:25:03,450 DEBUG [cloud.host.Status] 
(catalina-exec-12:null) Transition:[Resource state = Enabled, Agent 
event = AgentDisconnected, Host id = 1, name = node1.domain.com]
2014-02-12 23:25:03,450 DEBUG [cloud.host.Status] 
(catalina-exec-12:null) Cannot transit agent status with event 
AgentDisconnected for host 1, name=node1.domain.com, mangement server id 
is 161344192609
2014-02-12 23:25:03,450 ERROR [cloud.api.ApiServer] 
(catalina-exec-12:null) unhandled exception executing api command: addHost
com.cloud.utils.exception.CloudRuntimeException: Cannot transit agent 
status with event AgentDisconnected for host 1, mangement server id is 
161344192609,Unable to transition to a new state from Creating via 
AgentDisconnected





RE: Exposing PCIe capabilities to the Cloud Scheduler

2014-02-13 Thread 高野了成
Dear Edison Su and Malini Bhandaru,

I am the mentor of Pawit, who has submitted PCI passthrough patch last year.
We have been developing this feature for operating our private cloud based
on
CloudStack 4.2.1.
Now our users can deploy and migrate a VM instance with an InfiniBand
interface.

We hope to improve our patch and merge into CloudStack.
Your comments and suggestions are welcome.

Best regards,
Ryousei

> Welcome, my dear Intel friends:)
> Last year, community has contributed code regarding to add PCI
passthrough into CloudStack, see the patch:
https://reviews.apache.org/r/12098/, but unfortunately, this patch doesn't
get checked in, due to lack of support from committer:
http://markmail.org/message/ux2ojhxfqwdvz2uc.
> If you guys want to pick it up, either work from scratch, or based on the
original patch, that will be great.
>
>> -Original Message-
>> From: Bhandaru, Malini K [mailto:malini.k.bhand...@intel.com]
>> Sent: Wednesday, February 12, 2014 12:48 PM
>> To: dev@cloudstack.apache.org
>> Cc: Dugger, Donald D; Jiang, Yunhong; Meshkin, Omid; Manan Shah; Bob
Ball;
>> Hoban, Adrian
>> Subject: Exposing PCIe capabilities to the Cloud Scheduler
>>
>> Hello CloudStack-ers!
>>
>> PCIe (Peripheral Component Interconnect Express) devices exist for
graphics
>> processing, storage, digital signal processing, accelerating
>> encryption/decryption, and more. Further, within a function class,
devices
>> can exhibit different capability levels. Exposing such platform hardware
>> capabilities to the cloud scheduler allows Virtual Machines (VMs) to
explicitly
>> request them for improved performance and for the cloud vendor the
>> opportunity to offer services at different price points. facilitate
differentiated
>> revenur opportunities to the cloud vendor.
>>
>> CloudStack already exposes GPU
>> acceleration> U+and+vGPU+support+for+CloudStack+Guest+Vms>. Along these lines
>> PCIe capabilities, including SR-IOV (Single Root IO virtualization) can
be
>> exposed.
>> OpenStack has a set of blueprints for the same. The implementation spans
>> tracking the PCIe devices associated with a host, their use, VM
association,
>> and requesting PCIe features. libvirt has been modified to accommodate
>> PCIe discovery. Intel and Mirantis contributed a lot of the code.
>> https://blueprints.launchpad.net/nova/+spec/epa-for-pcie-devices
>> https://blueprints.launchpad.net/nova/+spec/pci-passthrough-libvirt
>>
>> Should you have an interest in supporting such functionality and have
>> technical questions, please get in touch.
>>
>> Regards
>> Malini Bhandaru, Intel


[GitHub] cloudstack-docs-admin pull request: Update provisioning.rst

2014-02-13 Thread sedukull
GitHub user sedukull opened a pull request:

https://github.com/apache/cloudstack-docs-admin/pull/1

Update provisioning.rst

Edited a link

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/cloudstack-docs-admin patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack-docs-admin/pull/1.patch


commit b0d7b4d3543aacac934eb56cae803a4dca8a3d50
Author: sedukull 
Date:   2014-02-13T12:02:08Z

Update provisioning.rst





[GitHub] cloudstack-docs-install pull request: Fixed code block formatting

2014-02-13 Thread geoffhigginbottom
GitHub user geoffhigginbottom opened a pull request:

https://github.com/apache/cloudstack-docs-install/pull/2

Fixed code block formatting

Various code blocks were not formatted correctly

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/cloudstack-docs-install master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack-docs-install/pull/2.patch


commit 9ed34d2a6ff54859283efba7045b1c97fda52ea8
Author: Geoff Higginbottom 
Date:   2014-02-13T11:48:13Z

Fixed code block formatting

Various code blocks were not formatted correctly





[GitHub] cloudstack-docs-install pull request: Fixed code block formatting

2014-02-13 Thread runseb
Github user runseb commented on the pull request:


https://github.com/apache/cloudstack-docs-install/pull/2#issuecomment-34991399
  
thanks, applied. I just need to figure out how to close this pr.
Maybe you can close it yourself ?



[INFO] Github notifications for docs

2014-02-13 Thread sebgoa
Hi,

As part of our new docs workflow we are starting to receive github 
notifications through dev@ (pr, comments etc..).

As we work through this new setup please be patient :) with us. If it becomes 
too traffic heavy we will redirect github notifications to another email 
address.

thanks,

-sebastien



[GitHub] cloudstack-docs-rn pull request: Update rnotes.rst

2014-02-13 Thread sedukull
GitHub user sedukull opened a pull request:

https://github.com/apache/cloudstack-docs-rn/pull/1

Update rnotes.rst

Added few changes to alignments.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/cloudstack-docs-rn patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack-docs-rn/pull/1.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1


commit 4f7df21c779e51183e7ca675af5785b267362f2b
Author: sedukull 
Date:   2014-02-13T16:19:58Z

Update rnotes.rst

Added few changes to alignments.





Jenkins build is back to normal : build-systemvm64-4.2 #172

2014-02-13 Thread jenkins
See 



[GitHub] cloudstack-docs-install pull request: Fixed code block formatting

2014-02-13 Thread geoffhigginbottom
Github user geoffhigginbottom commented on the pull request:


https://github.com/apache/cloudstack-docs-install/pull/2#issuecomment-34995371
  
Closing PR as it has new been merged with master



[GitHub] cloudstack-docs-install pull request: Fixed code block formatting

2014-02-13 Thread geoffhigginbottom
Github user geoffhigginbottom closed the pull request at:

https://github.com/apache/cloudstack-docs-install/pull/2



RE: [4.3]

2014-02-13 Thread Animesh Chaturvedi
What is this fix for? Is this for CLOUDSTACK-6069?

> -Original Message-
> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> Sent: Thursday, February 13, 2014 5:25 AM
> To: Animesh Chaturvedi
> Cc: dev
> Subject: [4.3]
> 
> Animesh,
> 
> Can you please cherry-pick 5af163ff7f658c30c6d93b50ac17c9cc0c5eb8c1
> onto 4.3?
> 
> thanks,
> --
> Daan


[GitHub] cloudstack-docs-install pull request: Update optional_installation...

2014-02-13 Thread sedukull
GitHub user sedukull opened a pull request:

https://github.com/apache/cloudstack-docs-install/pull/3

Update optional_installation.rst

Fixed Few alignment issues

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/cloudstack-docs-install patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack-docs-install/pull/3.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3


commit 25b643439b6f222728779f50c498e478257b6cd9
Author: sedukull 
Date:   2014-02-13T17:23:10Z

Update optional_installation.rst

Fixed Few alignment issues





[GitHub] cloudstack-docs-install pull request: Update optional_installation...

2014-02-13 Thread sedukull
Github user sedukull commented on the pull request:


https://github.com/apache/cloudstack-docs-install/pull/3#issuecomment-35002947
  
Fixed Few alignment issues.



[GitHub] cloudstack-docs-install pull request: Update optional_installation...

2014-02-13 Thread sedukull
Github user sedukull closed the pull request at:

https://github.com/apache/cloudstack-docs-install/pull/3



[GitHub] cloudstack-docs-install pull request: Update optional_installation...

2014-02-13 Thread sedukull
Github user sedukull commented on the pull request:


https://github.com/apache/cloudstack-docs-install/pull/3#issuecomment-35003054
  
Not yet applied



[GitHub] cloudstack-docs-install pull request: Update optional_installation...

2014-02-13 Thread sedukull
GitHub user sedukull reopened a pull request:

https://github.com/apache/cloudstack-docs-install/pull/3

Update optional_installation.rst

Fixed Few alignment issues

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/cloudstack-docs-install patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack-docs-install/pull/3.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3


commit 25b643439b6f222728779f50c498e478257b6cd9
Author: sedukull 
Date:   2014-02-13T17:23:10Z

Update optional_installation.rst

Fixed Few alignment issues





[GitHub] cloudstack-docs-install pull request: Update optional_installation...

2014-02-13 Thread runseb
Github user runseb commented on the pull request:


https://github.com/apache/cloudstack-docs-install/pull/3#issuecomment-35003657
  
the right way to fix this, is to use a .. literalinclude: statement and 
stick the python scripts in separate files outside the .rst see 
https://libcloud.readthedocs.org/en/latest/_sources/compute/drivers/cloudstack.txt
 as an example



[GitHub] cloudstack-docs-rn pull request: Update rnotes.rst

2014-02-13 Thread sedukull
Github user sedukull closed the pull request at:

https://github.com/apache/cloudstack-docs-rn/pull/1



Re: UI Latency

2014-02-13 Thread John Kinsella
Just posted http://theresnomon.co/2014/improving-cloudstack-ui-performance/ - 
open to any comments.

John

On Feb 10, 2014, at 12:47 AM, Alex Hitchins 
mailto:alex.hitch...@shapeblue.com>> wrote:

Sounds interesting, I look forward to your write-up.



Regards

Alex Hitchins

D: +44 1892 523 587 | S: +44 20 3603 0540 | M: +44 7788 423 969

alex.hitch...@shapeblue.com

-Original Message-
From: John Kinsella [mailto:j...@stratosec.co]
Sent: 10 February 2014 01:05
To: 
Subject: Re: UI Latency

I've been tinkering with httpd proxying the UI via mod_proxy_ajp, then using 
mod_deflate to compress on the httpd side. That gets me about a 2.5x decrease 
in loading the login screen. system.js, which is the largest item downloaded by 
default is around 980k, with gzip that drops to 68k.

I wanna see if I can squeeze a little more performance out by caching the 
static stuff...once I get some stats out of that I'll turn it into a blog post 
later this week.

John

On Feb 9, 2014, at 3:27 PM, Alex Hitchins  wrote:

One of the things that I want to look in to is generating a Gruntfile so we can 
'uglify' and reduce the size of css, js and image sprites. This should help 
reduce the initial payload and make a big difference to VPN/low b/w connections.


Regards

Alex Hitchins

D: +44 1892 523 587 | S: +44 20 3603 0540 | M: +44 7788 423 969

alex.hitch...@shapeblue.com

-Original Message-
From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
Sent: 09 February 2014 19:51
To: dev@cloudstack.apache.org
Subject: Re: UI Latency

I could be wrong, but I believe the idea of zipping the content for the UI 
start page was discussed, but has not yet been implemented.

As far as I know (and have experienced), every time you go to the start page, 
it does seem to take a while to load if you are not over a particularly fast 
connection (if I'm in the office, it loads quickly; if I'm over a VPN 
connection from, say, home, it tends to be noticeably slower).


On Sun, Feb 9, 2014 at 8:46 AM, Mo  wrote:

Hello,

>From my understanding going to the UI at first start-up takes awhile
to load due to the way it is configured, I believe I was previously
told it was gzip for the website. However, I thought this would a one
time thing; it seems to take quite awhile to load UI each time I
visit, unlike versions gone by.

Any advice? Suggestions?

- Maurice




--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*(tm)*
Need Enterprise Grade Support for Apache CloudStack?
Our CloudStack Infrastructure 
Support offers the 
best 24/7 SLA for CloudStack Environments.

Apache CloudStack Bootcamp training courses

**NEW!** CloudStack 4.2.1
training
18th-19th February 2014, Brazil.
Classroom
17th-23rd March 2014, Region A. Instructor led,
On-line
24th-28th March 2014, Region B. Instructor led,
On-line
16th-20th June 2014, Region A. Instructor led,
On-line
23rd-27th June 2014, Region B. Instructor led,
On-line

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue is a registered trademark.


This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Cons

[GitHub] cloudstack-docs-install pull request: Update hypervisor_installati...

2014-02-13 Thread sedukull
GitHub user sedukull opened a pull request:

https://github.com/apache/cloudstack-docs-install/pull/4

Update hypervisor_installation.rst

Fixed few alignment issues

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/cloudstack-docs-install patch-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack-docs-install/pull/4.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4


commit e7c99899edb61154f821771140d16acb5e43757c
Author: sedukull 
Date:   2014-02-13T18:07:41Z

Update hypervisor_installation.rst

Fixed few alignment issues





Re: [4.3]

2014-02-13 Thread Daan Hoogland
no, it is for a bug in the nicira base private gateways. unrelated.

On Thu, Feb 13, 2014 at 6:16 PM, Animesh Chaturvedi
 wrote:
> What is this fix for? Is this for CLOUDSTACK-6069?
>
>> -Original Message-
>> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
>> Sent: Thursday, February 13, 2014 5:25 AM
>> To: Animesh Chaturvedi
>> Cc: dev
>> Subject: [4.3]
>>
>> Animesh,
>>
>> Can you please cherry-pick 5af163ff7f658c30c6d93b50ac17c9cc0c5eb8c1
>> onto 4.3?
>>
>> thanks,
>> --
>> Daan



-- 
Daan


Re: UI Latency

2014-02-13 Thread Laszlo Hornyak
Hi,

I have a patch for the UI compression, it is on review for a while...
But I hope I will be able to resolve the comments in...days.

I measured the download size dropped from 3.5 MB to somewhere around 0.5 MB

https://reviews.apache.org/r/12228/

Adding javascript compression could also help a lot.

That 3.5 M is a lot even on LAN :-)



On Thu, Feb 13, 2014 at 7:04 PM, John Kinsella  wrote:

> Just posted
> http://theresnomon.co/2014/improving-cloudstack-ui-performance/ - open to
> any comments.
>
> John
>
> On Feb 10, 2014, at 12:47 AM, Alex Hitchins  > wrote:
>
> Sounds interesting, I look forward to your write-up.
>
>
>
> Regards
>
> Alex Hitchins
>
> D: +44 1892 523 587 | S: +44 20 3603 0540 | M: +44 7788 423 969
>
> alex.hitch...@shapeblue.com
>
> -Original Message-
> From: John Kinsella [mailto:j...@stratosec.co]
> Sent: 10 February 2014 01:05
> To: 
> Subject: Re: UI Latency
>
> I've been tinkering with httpd proxying the UI via mod_proxy_ajp, then
> using mod_deflate to compress on the httpd side. That gets me about a 2.5x
> decrease in loading the login screen. system.js, which is the largest item
> downloaded by default is around 980k, with gzip that drops to 68k.
>
> I wanna see if I can squeeze a little more performance out by caching the
> static stuff...once I get some stats out of that I'll turn it into a blog
> post later this week.
>
> John
>
> On Feb 9, 2014, at 3:27 PM, Alex Hitchins 
> wrote:
>
> One of the things that I want to look in to is generating a Gruntfile so
> we can 'uglify' and reduce the size of css, js and image sprites. This
> should help reduce the initial payload and make a big difference to VPN/low
> b/w connections.
>
>
> Regards
>
> Alex Hitchins
>
> D: +44 1892 523 587 | S: +44 20 3603 0540 | M: +44 7788 423 969
>
> alex.hitch...@shapeblue.com
>
> -Original Message-
> From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
> Sent: 09 February 2014 19:51
> To: dev@cloudstack.apache.org
> Subject: Re: UI Latency
>
> I could be wrong, but I believe the idea of zipping the content for the UI
> start page was discussed, but has not yet been implemented.
>
> As far as I know (and have experienced), every time you go to the start
> page, it does seem to take a while to load if you are not over a
> particularly fast connection (if I'm in the office, it loads quickly; if
> I'm over a VPN connection from, say, home, it tends to be noticeably
> slower).
>
>
> On Sun, Feb 9, 2014 at 8:46 AM, Mo  wrote:
>
> Hello,
>
> From my understanding going to the UI at first start-up takes awhile
> to load due to the way it is configured, I believe I was previously
> told it was gzip for the website. However, I thought this would a one
> time thing; it seems to take quite awhile to load UI each time I
> visit, unlike versions gone by.
>
> Any advice? Suggestions?
>
> - Maurice
>
>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the
> cloud
> *(tm)*
> Need Enterprise Grade Support for Apache CloudStack?
> Our CloudStack Infrastructure Support<
> http://shapeblue.com/cloudstack-infrastructure-support/> offers the best
> 24/7 SLA for CloudStack Environments.
>
> Apache CloudStack Bootcamp training courses
>
> **NEW!** CloudStack 4.2.1
> training
> 18th-19th February 2014, Brazil.
> Classroom
> 17th-23rd March 2014, Region A. Instructor led,
> On-line
> 24th-28th March 2014, Region B. Instructor led,
> On-line
> 16th-20th June 2014, Region A. Instructor led,
> On-line
> 23rd-27th June 2014, Region B. Instructor led,
> On-line
>
> This email and any attachments to it may be confidential and are intended
> solely for the use of the individual to whom it is addressed. Any views or
> opinions expressed are solely those of the author and do not necessarily
> represent those of Shape Blue Ltd or related companies. If you are not the
> intended recipient of this email, you must neither take any action based
> upon its contents, nor copy or show it to anyone. Please contact the sender
> if you believe you have received this email in error. Shape Blue Ltd is a
> company incorporated in England & Wales. ShapeBlue Services India LLP is a
> company incorporated in India and is operated under license from Shape Blue
> Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil
> and is operated under license from Shape Blue Ltd. ShapeBlue is a
> registered trademark.
>
>
> This email and any attachments to it may be confidential and are intended
> solely for the use of the indivi

Re: UI Latency

2014-02-13 Thread John Kinsella
Looks like Daan had a few issues with the patch for you to resolve regarding 
tabs and headers...

On Feb 13, 2014, at 10:14 AM, Laszlo Hornyak 
mailto:laszlo.horn...@gmail.com>> wrote:

Hi,

I have a patch for the UI compression, it is on review for a while...
But I hope I will be able to resolve the comments in...days.

I measured the download size dropped from 3.5 MB to somewhere around 0.5 MB

https://reviews.apache.org/r/12228/

Adding javascript compression could also help a lot.

That 3.5 M is a lot even on LAN :-)



On Thu, Feb 13, 2014 at 7:04 PM, John Kinsella  wrote:

Just posted
http://theresnomon.co/2014/improving-cloudstack-ui-performance/ - open to
any comments.

John

On Feb 10, 2014, at 12:47 AM, Alex Hitchins mailto:alex.hitch...@shapeblue.com>> wrote:

Sounds interesting, I look forward to your write-up.



Regards

Alex Hitchins

D: +44 1892 523 587 | S: +44 20 3603 0540 | M: +44 7788 423 969

alex.hitch...@shapeblue.com

-Original Message-
From: John Kinsella [mailto:j...@stratosec.co]
Sent: 10 February 2014 01:05
To: 
Subject: Re: UI Latency

I've been tinkering with httpd proxying the UI via mod_proxy_ajp, then
using mod_deflate to compress on the httpd side. That gets me about a 2.5x
decrease in loading the login screen. system.js, which is the largest item
downloaded by default is around 980k, with gzip that drops to 68k.

I wanna see if I can squeeze a little more performance out by caching the
static stuff...once I get some stats out of that I'll turn it into a blog
post later this week.

John

On Feb 9, 2014, at 3:27 PM, Alex Hitchins 
wrote:

One of the things that I want to look in to is generating a Gruntfile so
we can 'uglify' and reduce the size of css, js and image sprites. This
should help reduce the initial payload and make a big difference to VPN/low
b/w connections.


Regards

Alex Hitchins

D: +44 1892 523 587 | S: +44 20 3603 0540 | M: +44 7788 423 969

alex.hitch...@shapeblue.com

-Original Message-
From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
Sent: 09 February 2014 19:51
To: dev@cloudstack.apache.org
Subject: Re: UI Latency

I could be wrong, but I believe the idea of zipping the content for the UI
start page was discussed, but has not yet been implemented.

As far as I know (and have experienced), every time you go to the start
page, it does seem to take a while to load if you are not over a
particularly fast connection (if I'm in the office, it loads quickly; if
I'm over a VPN connection from, say, home, it tends to be noticeably
slower).


On Sun, Feb 9, 2014 at 8:46 AM, Mo  wrote:

Hello,

>From my understanding going to the UI at first start-up takes awhile
to load due to the way it is configured, I believe I was previously
told it was gzip for the website. However, I thought this would a one
time thing; it seems to take quite awhile to load UI each time I
visit, unlike versions gone by.

Any advice? Suggestions?

- Maurice




--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*(tm)*
Need Enterprise Grade Support for Apache CloudStack?
Our CloudStack Infrastructure Support<
http://shapeblue.com/cloudstack-infrastructure-support/> offers the best
24/7 SLA for CloudStack Environments.

Apache CloudStack Bootcamp training courses

**NEW!** CloudStack 4.2.1
training
18th-19th February 2014, Brazil.
Classroom
17th-23rd March 2014, Region A. Instructor led,
On-line
24th-28th March 2014, Region B. Instructor led,
On-line
16th-20th June 2014, Region A. Instructor led,
On-line
23rd-27th June 2014, Region B. Instructor led,
On-line

This email and any attachments to it may be confidential and are intended
solely for the use of the individual to whom it is addressed. Any views or
opinions expressed are solely those of the author and do not necessarily
represent those of Shape Blue Ltd or related companies. If you are not the
intended recipient of this email, you must neither take any action based
upon its contents, nor copy or show it to anyone. Please contact the sender
if you believe you have received this email in error. Shape Blue Ltd is a
company incorporated in England & Wales. ShapeBlue Services India LLP is a
company incorporated in India and is operated under license from Shape Blue
Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil
and is operated under license from Shape Blue Ltd. ShapeBlue is a
registered trademark.


This email and any attachments to it may be confidential and are intended
solely for the use of the individual to whom it is addressed. Any view

Re: Review Request 8294: Store NetworkServiceProvider connectivity service configuration in database.

2014-02-13 Thread Amogh Vasekar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8294/#review34388
---


Reminder-
Hi,
The review has been pending for long. Hugo / Hiroaki - can you please update if 
this is still necessary, or needs to be discarded?
Thanks

- Amogh Vasekar


On Nov. 30, 2012, 12:17 p.m., Hiroaki Kawai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8294/
> ---
> 
> (Updated Nov. 30, 2012, 12:17 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> There are 13 services defined in com.cloud.network.Network.Service , but db 
> schema has 12 services with connecitivity missing in 
> `cloud`.`physical_network_service_providers` . This patch will fix this. In 
> the cloudstack api response, we'll see Connectivity service is enabled in 
> NiciraNvp network service provider servicelist like this:
> 
> {
> "listnetworkserviceprovidersresponse": {
> "count": 1,
> "networkserviceprovider": [
> {
> "physicalnetworkid": "80bf64a1-c5ca-4eb1-810e-76917a317d59",
> "servicelist": [
> "Connectivity"
> ],
> "name": "NiciraNvp",
> "destinationphysicalnetworkid": "0",
> "state": "Disabled",
> "id": "efb45f75-9fd7-43aa-9937-b5c871971c00"
> }
> ]
> }
> }
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/PhysicalNetworkServiceProvider.java 1b91311 
>   packaging/centos63/package.sh 83c0e5e 
>   server/src/com/cloud/network/dao/PhysicalNetworkServiceProviderVO.java 
> 12b08af 
>   server/src/com/cloud/upgrade/dao/Upgrade40to41.java 5067f39 
>   setup/db/create-schema.sql fff084e 
>   setup/db/db/schema-40to41.sql PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/8294/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Hiroaki Kawai
> 
>



Re: Review Request 15349: Overprivisoning changes needed

2014-02-13 Thread Amogh Vasekar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15349/#review34389
---


Reminder - 
Hi,
This review has been pending for long. Please take the time to address the 
raised issues.
Thanks!

- Amogh Vasekar


On Dec. 16, 2013, 12:32 p.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15349/
> ---
> 
> (Updated Dec. 16, 2013, 12:32 p.m.)
> 
> 
> Review request for cloudstack and Nitin Mehta.
> 
> 
> Bugs: Cloudstack-5077.
> https://issues.apache.org/jira/browse/Cloudstack-5077.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> 
> 1.) This includes the change to reserve cpu and memory only when 
> vmware.reserve.cpu/mem is true, regardless of overcommit. 
> 2.) populate the default value of the cpu overcommit at cluster level form 
> the global setting when up grading. 
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 80497d4 
>   engine/schema/src/com/cloud/upgrade/dao/Upgrade420to421.java 51fb0de 
>   
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
>  71894a8 
>   setup/db/db/schema-420to421.sql fe1e0d4 
> 
> Diff: https://reviews.apache.org/r/15349/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> bharat kumar
> 
>



Re: Review Request 15633: Bugfix CS-5079: Add guard against null pointer exception for listConfigurations API call, and set value to NULL if the pointer is null

2014-02-13 Thread Amogh Vasekar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15633/#review34390
---


Reminder - 
This review has been pending for long. Request the submitter to please add 
relevant reviewers or seek volunteers from the community.
Thanks!



- Amogh Vasekar


On Nov. 17, 2013, 10:29 p.m., Yichi Lu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15633/
> ---
> 
> (Updated Nov. 17, 2013, 10:29 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Bugs: 5079
> https://issues.apache.org/jira/browse/5079
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-5079. When using api call, listConfigurations, and specifying 
> clusterid, some keys may not have values. this causes a null pointer to be 
> returned.
> Add guard against null pointer in 
> server/src/com/cloud/server/ConfigurationServerImpl.java::getConfigListByScope().
>  If a null pointer is returned from 
> framework/config/src/org/apache/cloudstack/framework/config/impl/ConfigDepotImpl.java::get(),
>  set value to 'NULL'.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/server/ConfigurationServerImpl.java 8459ada 
> 
> Diff: https://reviews.apache.org/r/15633/diff/
> 
> 
> Testing
> ---
> 
> tested api calls for &listConfigurations, &listConfigurations&clusterid=xxx, 
> &listConfigurations&zoneid=xxx,  &listConfigurations&category=Advanced
> 
> 
> Thanks,
> 
> Yichi Lu
> 
>



Re: Review Request 16461: CLOUDSTACK-5642 - Add else if connidition for identify direct nic type

2014-02-13 Thread Amogh Vasekar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16461/#review34391
---


Reminder -
Hi,
This review has been pending for long. Request the reviewers to please provide 
the comments.
Thanks!

- Amogh Vasekar


On Dec. 25, 2013, 3:47 a.m., Howie YU wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16461/
> ---
> 
> (Updated Dec. 25, 2013, 3:47 a.m.)
> 
> 
> Review request for cloudstack, Wei Zhou and Wido den Hollander.
> 
> 
> Bugs: CLOUDSTACK-5642
> https://issues.apache.org/jira/browse/CLOUDSTACK-5642
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Libvirt supports direct attachment of the guest VM's network to a physical 
> interface.
> But I found the following code may cause some problem, when the nic interface 
> type is direct
> If type is direct , then this nic will be ignore.
> 
> String type = nic.getAttribute("type");
> String mac = getAttrValue("mac", "address", nic);
> String dev = getAttrValue("target", "dev", nic);
> String model = getAttrValue("model", "type", nic);
> InterfaceDef def = new InterfaceDef();
> NodeList bandwidth = nic.getElementsByTagName("bandwidth");
> Integer networkRateKBps = 0;
> if ((bandwidth != null) && (bandwidth.getLength() != 0)) {
> Integer inbound = Integer.valueOf(getAttrValue("inbound", 
> "average", (Element)bandwidth.item(0)));
> Integer outbound = 
> Integer.valueOf(getAttrValue("outbound", "average", 
> (Element)bandwidth.item(0)));
> if (inbound == outbound)
> networkRateKBps = inbound;
> }
> if (type.equalsIgnoreCase("network")) {
> String network = getAttrValue("source", "network", nic);
> def.defPrivateNet(network, dev, mac, 
> nicModel.valueOf(model.toUpperCase()), networkRateKBps);
> } else if (type.equalsIgnoreCase("bridge")) {
> String bridge = getAttrValue("source", "bridge", nic);
> def.defBridgeNet(bridge, dev, mac, 
> nicModel.valueOf(model.toUpperCase()), networkRateKBps);
> } else if (type.equalsIgnoreCase("ethernet")) {
> String scriptPath = getAttrValue("script", "path", nic);
> def.defEthernet(dev, mac, 
> nicModel.valueOf(model.toUpperCase()), scriptPath, networkRateKBps);
> }
> interfaces.add(def); 
> 
> 
> Diffs
> -
> 
>   
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParser.java
>  127f648 
>   
> plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParserTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16461/diff/
> 
> 
> Testing
> ---
> 
> I add a unit test LibvirtDomainXMLParserTest in test directory , and add a 
> direct nic type domain xml for test
> 
> 
> ubuntu
>  77919cf3-b2a7-994f-5f3c-0a91fb9bcbe8
> 1048576
>   1048576
> 1
> 
> hvm
>  
>   
>
>
>   
>  
>  
>  destroy
>   restart
>  restart
>  
>  /usr/libexec/qemu-kvm
> 
>   
>  
>  
>   
>   
> 
>  
>   
>  
> 
> 
>   
>  
> 
> 
>  
> 
>  
>  
>  
>  
> 
> 
>  
>  
> 
> 
>   
>   
>   
> 
> 
> 
>   
> 
> 
>   
>   
> 
>  
>   
>   
>   
>  
>  
> 
>  
>  
> 
>  
>  
> 
> 
> Thanks,
> 
> Howie YU
> 
>



Re: copying a template from random zone

2014-02-13 Thread Min Chen
Edison has already fixed this in ACS 4.3 and master, See commit
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=1b06451
5ac9c7f87e1780ab2210e60723f9d541c.

Thanks
-min

On 2/12/14 8:16 AM, "Daan Hoogland"  wrote:

>LS,
>
>It seems that when instantiating a vm from a template cloudstack tries
>to copy the template from a random secondary storage
>https://issues.apache.org/jira/browse/CLOUDSTACK-6024
>
>the result is that the copy from secondary storage to primary fails
>and thus instantiation of the vm.
>
>This is in 4.2.1 but I looked into the master code and it seems to
>still call code that uses a random result for the origin of the
>template. Any of the storage guru's know if my analysis is correct and
>how to handle this?
>
>-- 
>Daan



Re: copying a template from random zone

2014-02-13 Thread Daan Hoogland
I saw in code that my first analysis that this would still be a
problem was wrong. I have not devised a way to verify yet. thanks for
the confirmation, Min

On Thu, Feb 13, 2014 at 7:47 PM, Min Chen  wrote:
> Edison has already fixed this in ACS 4.3 and master, See commit
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=1b06451
> 5ac9c7f87e1780ab2210e60723f9d541c.
>
> Thanks
> -min
>
> On 2/12/14 8:16 AM, "Daan Hoogland"  wrote:
>
>>LS,
>>
>>It seems that when instantiating a vm from a template cloudstack tries
>>to copy the template from a random secondary storage
>>https://issues.apache.org/jira/browse/CLOUDSTACK-6024
>>
>>the result is that the copy from secondary storage to primary fails
>>and thus instantiation of the vm.
>>
>>This is in 4.2.1 but I looked into the master code and it seems to
>>still call code that uses a random result for the origin of the
>>template. Any of the storage guru's know if my analysis is correct and
>>how to handle this?
>>
>>--
>>Daan
>



-- 
Daan


Re: Review Request 17872: remove nic in network with dhcp

2014-02-13 Thread Alena Prokharchyk

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17872/#review34397
---

Ship it!


Ship It!

- Alena Prokharchyk


On Feb. 8, 2014, 2:49 p.m., daan Hoogland wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17872/
> ---
> 
> (Updated Feb. 8, 2014, 2:49 p.m.)
> 
> 
> Review request for cloudstack and Alena Prokharchyk.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> remove nic in network with dhcp plus tests to make sure it is not called for 
> domainrouter or when dhcp not supported
> 
> 
> Diffs
> -
> 
>   
> engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
>  ce40762 
>   
> engine/orchestration/test/org/apache/cloudstack/engine/orchestration/NetworkOrchestratorTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/17872/diff/
> 
> 
> Testing
> ---
> 
> unit tests added. no extensive integration testing done.
> 
> 
> Thanks,
> 
> daan Hoogland
> 
>



Re: [VOTE] Apache CloudStack 4.3.0 (fourth round) UPDATE

2014-02-13 Thread Daan Hoogland
Guys `n' dolls,

while i detected some changed behavure in using the api I am still
retracting my -1. The code that worked before  was not intended to
work. I managed to execute my fourth test successfully

regards

On Thu, Feb 13, 2014 at 12:11 PM, Nux!  wrote:
> On 13.02.2014 05:28, Animesh Chaturvedi wrote:
>>
>>
>> 1. CLOUDSTACK-6083 : Missing CIDRs in firewall rules after upgrade
>>  => Waiting on Jayapal to confirm and update the list with findings
>
>
> Jayapal's fix works for me.
>
>
>> 3. CLOUDSTACK-6065: KVM HA not working for shutdown VMs
>> => While an issue but my understanding is it is a corner scenario
>> only affecting KVM and can be released  as a known issue
>
>
> Well, it's effectively breaking HA as defined in the docs for a main hv type
> and as it is I can't use 4.3 in production. Is there a fix in sight?
>
> Lucian
>
> --
> Sent from the Delta quadrant using Borg technology!
>
> Nux!
> www.nux.ro



-- 
Daan


RE: [jira] [Resolved] (CLOUDSTACK-5967) Virtual router in OVS network fails to start with error from XenServer: VM_REQUIRES_NETWORK

2014-02-13 Thread Paul Angus
Hi,

Using 4.3 RC4 I can now create an instance on an OVS but if I try to migrate 
the instance to another VM it fails with the VM_REQUIRES_NETWORK error.  
Attempting to manually using XenCenter says "Cannot see required Network" 
although OVSTunel517 appears to be on both servers.

m.cloud.utils.exception.CloudRuntimeException: Unable to migrate VM(i-2-7-VM) 
from host(05b443f9-8f69-4855-a6e0-8018afe5a551) due to Task failed! Task 
record: uuid: c4682573-5c30-ae62-6163-32cda5ae75f5
   nameLabel: Async.VM.pool_migrate
 nameDescription:
   allowedOperations: []
   currentOperations: {}
 created: Thu Feb 13 17:25:39 GMT 2014
finished: Thu Feb 13 17:25:39 GMT 2014
  status: failure
  residentOn: com.xensource.xenapi.Host@ad885ef9
progress: 1.0
type: 
  result:
   errorInfo: [VM_REQUIRES_NETWORK, 
OpaqueRef:754c9612-d1be-1c26-7096-bc71b423c652, 
OpaqueRef:20d04b69-b3f7-3590-25da-85d547d3327c]
 otherConfig: {}
   subtaskOf: com.xensource.xenapi.Task@aaf13f6f
subtasks: []


Regards,

Paul Angus
Cloud Architect
S: +44 20 3603 0540 | M: +447711418784 | T: @CloudyAngus
paul.an...@shapeblue.com

-Original Message-
From: Murali Reddy (JIRA) [mailto:j...@apache.org]
Sent: 10 February 2014 10:47
To: Paul Angus
Subject: [jira] [Resolved] (CLOUDSTACK-5967) Virtual router in OVS network 
fails to start with error from XenServer: VM_REQUIRES_NETWORK


 [ 
https://issues.apache.org/jira/browse/CLOUDSTACK-5967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Murali Reddy resolved CLOUDSTACK-5967.
--

Resolution: Fixed

Commit, fixes two aspects.

- Ignore exception caused on VIF.Plug into Dom0.
- introduce OVS as provider for 'Connectivity' service

> Virtual router in OVS network fails to start with error from
> XenServer: VM_REQUIRES_NETWORK
> --
> -
>
> Key: CLOUDSTACK-5967
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5967
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the default.)
>  Components: Network Controller
>Affects Versions: 4.3.0
> Environment: CloudStack 4.3 with XenServer 6.2 GRE tunnel
> based advanced network
>Reporter: Paul Angus
>Assignee: Murali Reddy
>Priority: Blocker
> Fix For: 4.3.0
>
>
> Virtual Router start fails with error VM_REQUIRES_NETWORK when using GRE 
> tunnel encapsulation.
> Tunnel is created on XenServer (OVSTunnel194) virtual router appears
> briefly then dissappears and insufficient capacity error is returned
> by cloudstack
> 2014-01-28 16:17:09,829 DEBUG [c.c.n.r.VirtualNetworkApplianceManagerImpl] 
> (Job-Executor-12:ctx-3a256248 ctx-58300764) Creating  monitoring services on 
> VM[DomainRouter|r-12-VM] start...
> 2014-01-28 16:17:09,842 DEBUG [c.c.a.t.Request]
> (Job-Executor-12:ctx-3a256248 ctx-58300764) Seq 2-232063002: Sending
> { Cmd , MgmtId: 345049362040, via: 2(localhost.localdomain), Ver: v1,
> Flags: 100011,
> [{"com.cloud.agent.api.StartCommand":{"vm":{"id":12,"name":"r-12-VM","
> bootloader":"PyGrub","type":"DomainRouter","cpus":1,"minSpeed":125,"ma
> xSpeed":500,"minRam":134217728,"maxRam":134217728,"arch":"x86_64","os"
> :"Debian GNU/Linux 7(32-bit)","bootArgs":" template=domP name=r-12-VM
> eth2ip=192.168.1.53 eth2mask=255.255.255.0 gateway=192.168.1.254
> eth0ip=10.1.1.1 eth0mask=255.255.255.0 domain=cs2cloud.internal
> dhcprange=10.1.1.1 eth1ip=169.254.0.255 eth1mask=255.255.0.0
> type=router disable_rp_filter=true
> dns1=10.0.1.2","rebootOnCrash":false,"enableHA":true,"limitCpuUse":fal
> se,"enableDynamicallyScaleVm":false,"vncPassword":"eb2e57fde93e6d68","
> params":{"memoryOvercommitRatio":"1.0","cpuOvercommitRatio":"4.0"},"uu
> id":"dc796b13-8cb8-405b-9080-fb9480ce3c2e","disks":[{"data":{"org.apac
> he.cloudstack.storage.to.VolumeObjectTO":{"uuid":"d36e3503-ecf9-4f79-8
> e8c-02c3032d4051","volumeType":"ROOT","dataStore":{"org.apache.cloudst
> ack.storage.to.PrimaryDataStoreTO":{"uuid":"6fbe4014-a031-3443-82ea-4c
> f1459bedd5","id":1,"poolType":"NetworkFilesystem","host":"10.0.100.5",
> "path":"/volumes/stor/Cloud/Primary/ACS43/XEN1","port":2049,"url":"Net
> workFilesystem://10.0.100.5//volumes/stor/Cloud/Primary/ACS43/XEN1/?RO
> LE=Primary&STOREUUID=6fbe4014-a031-3443-82ea-4cf1459bedd5"}},"name":"R
> OOT-12","size":2097152000,"path":"2f26c084-e597-43d2-a4ec-acdafe3790c7
> ","volumeId":12,"vmName":"r-12-VM","accountId":2,"format":"VHD","id":1
> 2,"deviceId":0,"hypervisorType":"XenServer"}},"diskSeq":0,"path":"2f26
> c084-e597-43d2-a4ec-acdafe3790c7","type":"ROOT","_details":{"managed":
> "false","storagePort":"2049","storageHost":"10.0.100.5","volumeSize":"
> 2097152000"

Re: Review Request 15633: Bugfix CS-5079: Add guard against null pointer exception for listConfigurations API call, and set value to NULL if the pointer is null

2014-02-13 Thread Yichi Lu
I discarded my review request, based on this:
Harikrishna Patnala commented on CLOUDSTACK-5079:
-

Hi Yichi Lu,
This was fixed on NOV 15th and the fix is to use the configDepot class to
populate the scoped variables. This class was introduced as part of new
configuration parameters framework added in 4.3.

Thanks,
Harikrishna

and this:
Srikanteswararao Talluri (JIRA)
Jan 31 (13 days ago)
to me
 [ https://issues.apache.org/jira/browse/CLOUDSTACK-5079
?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Srikanteswararao Talluri closed CLOUDSTACK-5079.


On Thu, Feb 13, 2014 at 12:33 PM, Amogh Vasekar wrote:

>This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15633/
>
> Reminder -
> This review has been pending for long. Request the submitter to please add 
> relevant reviewers or seek volunteers from the community.
> Thanks!
>
>
>
> - Amogh Vasekar
>
> On November 17th, 2013, 10:29 p.m. UTC, Yichi Lu wrote:
>   Review request for cloudstack.
> By Yichi Lu.
>
> *Updated Nov. 17, 2013, 10:29 p.m.*
>  *Bugs: * 5079 
>  *Repository: * cloudstack-git
> Description
>
> CLOUDSTACK-5079. When using api call, listConfigurations, and specifying 
> clusterid, some keys may not have values. this causes a null pointer to be 
> returned.
> Add guard against null pointer in 
> server/src/com/cloud/server/ConfigurationServerImpl.java::getConfigListByScope().
>  If a null pointer is returned from 
> framework/config/src/org/apache/cloudstack/framework/config/impl/ConfigDepotImpl.java::get(),
>  set value to 'NULL'.
>
>   Testing
>
> tested api calls for &listConfigurations, &listConfigurations&clusterid=xxx, 
> &listConfigurations&zoneid=xxx,  &listConfigurations&category=Advanced
>
>   Diffs
>
>- server/src/com/cloud/server/ConfigurationServerImpl.java (8459ada)
>
> View Diff 
>


RE: [4.3]

2014-02-13 Thread Animesh Chaturvedi
Can you log a separate bug then? At this point all commits to 4.3-forward 
should have a bug id associated with it.

> -Original Message-
> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> Sent: Thursday, February 13, 2014 10:07 AM
> To: Animesh Chaturvedi
> Cc: dev
> Subject: Re: [4.3]
> 
> no, it is for a bug in the nicira base private gateways. unrelated.
> 
> On Thu, Feb 13, 2014 at 6:16 PM, Animesh Chaturvedi
>  wrote:
> > What is this fix for? Is this for CLOUDSTACK-6069?
> >
> >> -Original Message-
> >> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> >> Sent: Thursday, February 13, 2014 5:25 AM
> >> To: Animesh Chaturvedi
> >> Cc: dev
> >> Subject: [4.3]
> >>
> >> Animesh,
> >>
> >> Can you please cherry-pick 5af163ff7f658c30c6d93b50ac17c9cc0c5eb8c1
> >> onto 4.3?
> >>
> >> thanks,
> >> --
> >> Daan
> 
> 
> 
> --
> Daan


Re: copying a template from random zone

2014-02-13 Thread Min Chen
One correction, fix is not present in master, Edison will cherry-pick it
there soon.

Thanks
-min

On 2/13/14 10:47 AM, "Min Chen"  wrote:

>Edison has already fixed this in ACS 4.3 and master, See commit
>https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=1b0645
>1
>5ac9c7f87e1780ab2210e60723f9d541c.
>
>Thanks
>-min
>
>On 2/12/14 8:16 AM, "Daan Hoogland"  wrote:
>
>>LS,
>>
>>It seems that when instantiating a vm from a template cloudstack tries
>>to copy the template from a random secondary storage
>>https://issues.apache.org/jira/browse/CLOUDSTACK-6024
>>
>>the result is that the copy from secondary storage to primary fails
>>and thus instantiation of the vm.
>>
>>This is in 4.2.1 but I looked into the master code and it seems to
>>still call code that uses a random result for the origin of the
>>template. Any of the storage guru's know if my analysis is correct and
>>how to handle this?
>>
>>-- 
>>Daan
>



Re: copying a template from random zone

2014-02-13 Thread Min Chen
Daan, just noticed that you are reading code from master, then your
analysis is not wrong. Edison hasn't cherry-pick his commit to master yet.

Thanks
-min

On 2/13/14 10:53 AM, "Daan Hoogland"  wrote:

>I saw in code that my first analysis that this would still be a
>problem was wrong. I have not devised a way to verify yet. thanks for
>the confirmation, Min
>
>On Thu, Feb 13, 2014 at 7:47 PM, Min Chen  wrote:
>> Edison has already fixed this in ACS 4.3 and master, See commit
>> 
>>https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=1b064
>>51
>> 5ac9c7f87e1780ab2210e60723f9d541c.
>>
>> Thanks
>> -min
>>
>> On 2/12/14 8:16 AM, "Daan Hoogland"  wrote:
>>
>>>LS,
>>>
>>>It seems that when instantiating a vm from a template cloudstack tries
>>>to copy the template from a random secondary storage
>>>https://issues.apache.org/jira/browse/CLOUDSTACK-6024
>>>
>>>the result is that the copy from secondary storage to primary fails
>>>and thus instantiation of the vm.
>>>
>>>This is in 4.2.1 but I looked into the master code and it seems to
>>>still call code that uses a random result for the origin of the
>>>template. Any of the storage guru's know if my analysis is correct and
>>>how to handle this?
>>>
>>>--
>>>Daan
>>
>
>
>
>-- 
>Daan



RE: [VOTE] Apache CloudStack 4.3.0 (fourth round)

2014-02-13 Thread Animesh Chaturvedi
Daan

So what is the final status on CLOUDSTACK-6069? I will respin another RC and 
looks like Kishan/Murali cannot reproduce it 

Animesh

> -Original Message-
> From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com]
> Sent: Thursday, February 13, 2014 3:09 AM
> To: Kishan Kavala; Animesh Chaturvedi; dev@cloudstack.apache.org
> Cc: Murali Reddy; daan Hoogland
> Subject: RE: [VOTE] Apache CloudStack 4.3.0 (fourth round)
> 
> Yes it does,
> 
> Two guest networks both tagged. system net offer isn't tagged. that's why it
> is strange it used to work.
> 
> -Original Message-
> From: Kishan Kavala [mailto:kishan.kav...@citrix.com]
> Sent: donderdag 13 februari 2014 11:59
> To: Daan Hoogland; Animesh Chaturvedi; dev@cloudstack.apache.org
> Cc: Murali Reddy; daan Hoogland
> Subject: RE: [VOTE] Apache CloudStack 4.3.0 (fourth round)
> 
> Daan,
>  I couldn't repo CLOUDSTACK-6069 in my regular VPC setup.  Does this
> happen only when using mixed setup with Nicira?
> 
> > -Original Message-
> > From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com]
> > Sent: Thursday, 13 February 2014 2:29 PM
> > To: Animesh Chaturvedi; dev@cloudstack.apache.org
> > Cc: Kishan Kavala; Murali Reddy; daan Hoogland
> > Subject: RE: [VOTE] Apache CloudStack 4.3.0 (fourth round)
> >
> > I can confirm that it also exists in master. Unfortunately it is not
> > high on my prio list right now. We have a pressing bug hurting us in
> > our production systems that I will get out of the way first.
> >
> > What I can say is that I am puzzled that my test works in 4.2 and
> > before as I instantiate a private gateway with associated network,
> > while the system network offering for private gateways has no tags and
> > I have two guest networks.
> >
> > I will return to this issue when given time.
> >
> > Regards,
> > Daan
> >
> > -Original Message-
> > From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com]
> > Sent: woensdag 12 februari 2014 11:52
> > To: dev@cloudstack.apache.org
> > Cc: Kishan Kavala; Murali Reddy; Daan Hoogland; daan Hoogland
> > Subject: RE: [VOTE] Apache CloudStack 4.3.0 (fourth round)
> >
> > Adding Murali as well.
> >
> > Daan I am not sure if there was any specific work done on this during
> > 4.3 to cause it to regress.  Did you debug this further?
> >
> > Thanks
> > Animesh
> >
> >
> >
> > > -Original Message-
> > > From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> > > Sent: Monday, February 10, 2014 11:42 AM
> > > To: dev
> > > Cc: Kishan Kavala
> > > Subject: Re: [VOTE] Apache CloudStack 4.3.0 (fourth round)
> > >
> > > https://issues.apache.org/jira/browse/CLOUDSTACK-6069
> > >
> > > I will try in master as well. And look for a solution there.
> > >
> > > On Mon, Feb 10, 2014 at 8:13 PM, Animesh Chaturvedi
> > >  wrote:
> > > > Daan
> > > >
> > > > Can you create a tracking bug for this issue? Adding Kishan for
> > > > his input
> > > >
> > > > Animesh
> > > >
> > > >> -Original Message-
> > > >> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> > > >> Sent: Monday, February 10, 2014 10:25 AM
> > > >> To: dev
> > > >> Subject: Re: [VOTE] Apache CloudStack 4.3.0 (fourth round)
> > > >>
> > > >> H,
> > > >>
> > > >> -1 (binding)
> > > >>
> > > >> I have a backwards compatibility issue with 4.3. It might turn
> > > >> out to be a setup thing but I have verified that 4.2.1 works with my
> setup.
> > > >> I have four basic test cases|:
> > > >> 1. create network and vm on top - works 2. create bridged network
> > > >> and create vm on it - works 3. create a vpc with private gateway
> > > >> (and
> > > >> ...) - fails 4. create a vpc with nicira based private gateway -
> > > >> works
> > > >>
> > > >> I haven't actually tried 1,2 and 4 on this rc because 3 was
> > > >> always giving me the most problems. The others worked on the
> previous rc.
> > > >> Having discussed this with Hugo, we'll probably not stop using
> > > >> 4.3 if it passes but it needs fixing asap.
> > > >>
> > > >> setup
> > > >> 1 zone
> > > >> 1 pod
> > > >> 1 cluster
> > > >> 2 hosts (xen 6.0.2)
> > > >>
> > > >> 2 physnets
> > > >> - physnet 1 vlan based (Public, Guest(tagged "vlan-based"),
> > > >> Management,
> > > >> Storage)
> > > >> - physnet 2 nicira based (Guest (tagged "nicira-based"))
> > > >>
> > > >> Now creating a private gateway on the vpc using marvin I get a
> > > >> 530 server error. I dare to put a -1 here as it is a majority
> > > >> vote. One of the things that makes me hesitate is
> > > >> 4.2.1 code (succeeding):
> > > >> 2014-02-10 15:43:45,621 DEBUG [xen.resource.CitrixResourceBase]
> > > >> (DirectAgent-4:null) Creating VLAN 322 on host 10.200.23.41 on
> > > >> device
> > > >> tunnel0
> > > >> 4.3.0 code (failing)
> > > >> 2014-02-10 17:33:51,083 DEBUG [c.c.h.x.r.CitrixResourceBase]
> > > >> (DirectAgent-4:ctx-6d5f0cd4) Creating VLAN 322 on host
> > > >> 10.200.23.42 on device tunnel0
> > > >>
> > > >>
> > > >> On Mon, Feb 10, 2014 at 12:28 PM, Nux!  wrote:

Re: UI Latency

2014-02-13 Thread Laszlo Hornyak
Ah yes we are playing space-wars, I will fix it as soon as I get there. I
was not that much interested in space/tabs but what it already does:
- at build time it generates .gz files from static resources, like css,
html and js files
- during runtime it checks if there is a gz file for the resource and
silently serves the gz file and sets the headers, only if the client
browser accepts gz of course
- respects Etag since you do not want to download even "just" 500 Kb each
time you hit ctrl-r.

TODO other than the space-war:
- it uses a maven plugin I have built for home use, it is in my maven repo
and it would not be great to give my unreliable repository to everyone, so
it should be either moved to the ACS source or uploaded to the central repo
- Some a would not like to make the build even longer. It is quite short
compared to the full time of the build, but for a CI build it is completely
useless. So it must be moved to a profile and profile should be active
during release process, maybe not anyway unless you manually enable it.




On Thu, Feb 13, 2014 at 7:23 PM, John Kinsella  wrote:

> Looks like Daan had a few issues with the patch for you to resolve
> regarding tabs and headers...
>
> On Feb 13, 2014, at 10:14 AM, Laszlo Hornyak  > wrote:
>
> Hi,
>
> I have a patch for the UI compression, it is on review for a while...
> But I hope I will be able to resolve the comments in...days.
>
> I measured the download size dropped from 3.5 MB to somewhere around 0.5 MB
>
> https://reviews.apache.org/r/12228/
>
> Adding javascript compression could also help a lot.
>
> That 3.5 M is a lot even on LAN :-)
>
>
>
> On Thu, Feb 13, 2014 at 7:04 PM, John Kinsella  wrote:
>
> Just posted
> http://theresnomon.co/2014/improving-cloudstack-ui-performance/ - open to
> any comments.
>
> John
>
> On Feb 10, 2014, at 12:47 AM, Alex Hitchins  > wrote:
>
> Sounds interesting, I look forward to your write-up.
>
>
>
> Regards
>
> Alex Hitchins
>
> D: +44 1892 523 587 | S: +44 20 3603 0540 | M: +44 7788 423 969
>
> alex.hitch...@shapeblue.com
>
> -Original Message-
> From: John Kinsella [mailto:j...@stratosec.co]
> Sent: 10 February 2014 01:05
> To: 
> Subject: Re: UI Latency
>
> I've been tinkering with httpd proxying the UI via mod_proxy_ajp, then
> using mod_deflate to compress on the httpd side. That gets me about a 2.5x
> decrease in loading the login screen. system.js, which is the largest item
> downloaded by default is around 980k, with gzip that drops to 68k.
>
> I wanna see if I can squeeze a little more performance out by caching the
> static stuff...once I get some stats out of that I'll turn it into a blog
> post later this week.
>
> John
>
> On Feb 9, 2014, at 3:27 PM, Alex Hitchins 
> wrote:
>
> One of the things that I want to look in to is generating a Gruntfile so
> we can 'uglify' and reduce the size of css, js and image sprites. This
> should help reduce the initial payload and make a big difference to VPN/low
> b/w connections.
>
>
> Regards
>
> Alex Hitchins
>
> D: +44 1892 523 587 | S: +44 20 3603 0540 | M: +44 7788 423 969
>
> alex.hitch...@shapeblue.com
>
> -Original Message-
> From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
> Sent: 09 February 2014 19:51
> To: dev@cloudstack.apache.org
> Subject: Re: UI Latency
>
> I could be wrong, but I believe the idea of zipping the content for the UI
> start page was discussed, but has not yet been implemented.
>
> As far as I know (and have experienced), every time you go to the start
> page, it does seem to take a while to load if you are not over a
> particularly fast connection (if I'm in the office, it loads quickly; if
> I'm over a VPN connection from, say, home, it tends to be noticeably
> slower).
>
>
> On Sun, Feb 9, 2014 at 8:46 AM, Mo  wrote:
>
> Hello,
>
> From my understanding going to the UI at first start-up takes awhile
> to load due to the way it is configured, I believe I was previously
> told it was gzip for the website. However, I thought this would a one
> time thing; it seems to take quite awhile to load UI each time I
> visit, unlike versions gone by.
>
> Any advice? Suggestions?
>
> - Maurice
>
>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the
> cloud
> *(tm)*
> Need Enterprise Grade Support for Apache CloudStack?
> Our CloudStack Infrastructure Support<
> http://shapeblue.com/cloudstack-infrastructure-support/> offers the best
> 24/7 SLA for CloudStack Environments.
>
> Apache CloudStack Bootcamp training courses
>
> **NEW!** CloudStack 4.2.1
> training
> 18th-19th February 2014, Brazil.
> Classroom
> 17th-23rd March 2014, Region A. Instructor led,
> On-line

Re: Working on CloudStack Jira-764:nTier Apps 2.0 : Redundant Virtual Router for VPC email 2 of 2

2014-02-13 Thread Sheng Yang
Hi Karl,

>From Network Guru part of view, there is no VPC or isolated network guru.
Guru is per network type, e.g. public network, guest network, control
network, mgmt network. So VPC contained one public and multiple guest
network, which would be created by each guru accordingly. By this means,
VPC or isolated network is not a guru.

The configuration of VR is done in VirtualNetworkApplianceManager and
VPCVirtualNetworkApplianceManager, which would be called by Virtual Router
element and VPC virtual router element. And they've already passed all the
information VR needed for VPC. I think every information you needed to
configure keepalived and conntrackd should be already there, except
redundant_router=1 parameter.

For original redundant router implementation, there are two major parts of
code I've heavily modified: how to start two routers in one network(through
findOrDeployVirtualRouterInGuestNetwork()), and how to program them(through
cmdline parameter in the VR). I think the VPC implementation would face the
same issues as well. You can take a look at current implementation and
follow the code flow, to see if it would help you.

--Sheng

On Wed, Feb 12, 2014 at 11:15 AM, Karl Harris wrote:

> On Wed, Feb 12, 2014 at 9:38 AM, Karl Harris  >wrote:
>
> > Would implementing a VPC Redundant Router Network Guru using the an
> > extension of the NetworkGuru interface be an appropriate way to create a
> > VPC network with redundant routers. It seems that extending Network Guru
> > interface or extending one of it's children eg the abstract class
> > GuestNetworkGuru would be a appropriate design path.
> >
> > Comments?
> >
> > Karl
> >
> I know the configuration of the VM which implement the redundant routers
> are handled via BASH scripts and the environment variables int the VM
> images are used to configure the conntrackd and keepalived applications via
> SED in bash scripts. I am looking for a clean way to pass the variable
> number of NIC's and then generate the LINK and IGNORE configuration
> commands for conntrackd.
>
> The Network Guru mentioned above seemed like an interesting place to look,
> even though it's used to work with the DAO's for the NetworkElements.
>
> Karl
>
>
> >
> > On Mon, Feb 3, 2014 at 2:58 PM, Daan Hoogland  >wrote:
> >
> >> On Mon, Feb 3, 2014 at 8:50 PM, Sheng Yang  wrote:
> >> > On Mon, Feb 3, 2014 at 11:27 AM, Karl Harris  >> >wrote:
> >> >
> >> >> On Mon, Feb 3, 2014 at 2:03 PM, Daan Hoogland <
> daan.hoogl...@gmail.com
> >> >> >wrote:
> >> >>
> >> >> >
> >> >> > On 03 Feb 2014, at 19:45, Karl Harris 
> >> wrote:
> >> >> >
> >> >> > > On Mon, Feb 3, 2014 at 12:54 PM, Daan Hoogland <
> >> >> daan.hoogl...@gmail.com
> >> >> > >wrote:
> >> >> > >
> >> >> > >>
> >> >> > >> On 03 Feb 2014, at 18:03, Karl Harris 
> >> >> wrote:
> >> >> > >>
> >> >> > >>> After discussion with my colleagues  questions about initial
> >> >> > >>> configuration of the open network redundant routers and the
> >> >> > >>> applicability of the existing bash scripts (cloud-early-config)
> >> to
> >> >> the
> >> >> > >>> setup of VPC redundant routers have generated.
> >> >> > >>>
> >> >> > >>>
> >> >> > >>> Some setup first: In the bash script cloud-early-config there
> is
> >> a
> >> >> > >>> function named setup_redundant_router which makes copies of
> >> several
> >> >> > >>> template files. The template files are used to configure
> >> keepalived
> >> >> > >>> and conntrackd. The template copies are edited, via sed editor,
> >> using
> >> >> > >>> environment variables ($ROUTER_PR, $ETH0_IP,$NAME, etc.)  which
> >> are
> >> >> > >>> obtained from the kernel of the current running linux image
> >> using the
> >> >> > >>> virtual file system /proc/cmdline.
> >> >> > >>>
> >> >> > >>> I'm sure keepalived and conntrackd  can be used for starting
> and
> >> >> > >>> control of VPC redundant routers. However the setup of
> >> keepalived and
> >> >> > >>> conntrackd for VPC needs setup parameters which are dynamic
> >> because a
> >> >> > >>> VPC can have N number of redundant router pairs, not just the
> >> fixed
> >> >> > >>> number parsed from proc/cmdline in the running kernel.
> >> >> > >>>
> >> >> > >>> Am I correct in this analysis?
> >> >> > >> Karl, I think not. There is only one router in a vac, it routes
> >> for
> >> >> all
> >> >> > >> networks in the virtual private cloud. Am I misreading your
> >> >> description.
> >> >> > >
> >> >> > > Ok then a VPC should contain a single router containing N+1 (N+2
> if
> >> >> > using a
> >> >> > > VPN connection) nic's? Where N is the number of private networks.
> >> >> > And I would like to see N+3 as it will allocate another when a
> >> private
> >> >> > gateway is defined. That is why I proposed to pre-allocate this nic
> >> to be
> >> >> > able to predict mic-ids, i.e. eth<#>.
> >> >> >
> >> >> > >
> >> >> > > If so then my original question still holds in the sense that the
> >> nic's
> >> >> > > need to be created in the VM kernel based on the num

RE: Exposing PCIe capabilities to the Cloud Scheduler

2014-02-13 Thread Edison Su
Hi Ryousei,
 The patch sounds good to me, don’t know why it’s not got checked into 4.2 
or 4.3. Is it ok for you to rebase to master? After that, I’ll check it into 
master.


From: 高野了成 [mailto:takano-ryou...@aist.go.jp]
Sent: Thursday, February 13, 2014 4:08 AM
To: dev@cloudstack.apache.org
Cc: malini.k.bhand...@intel.com; Edison Su; Dugger, Donald D; 
yunhong.ji...@intel.com; Meshkin, Omid; Manan Shah; Bob Ball; Hoban, Adrian
Subject: RE: Exposing PCIe capabilities to the Cloud Scheduler

Dear Edison Su and Malini Bhandaru,

I am the mentor of Pawit, who has submitted PCI passthrough patch last year.
We have been developing this feature for operating our private cloud based on
CloudStack 4.2.1.
Now our users can deploy and migrate a VM instance with an InfiniBand interface.

We hope to improve our patch and merge into CloudStack.
Your comments and suggestions are welcome.

Best regards,
Ryousei

> Welcome, my dear Intel friends:)
> Last year, community has contributed code regarding to add PCI passthrough 
> into CloudStack, see the patch: https://reviews.apache.org/r/12098/, but 
> unfortunately, this patch doesn't get checked in, due to lack of support from 
> committer: http://markmail.org/message/ux2ojhxfqwdvz2uc.
> If you guys want to pick it up, either work from scratch, or based on the 
> original patch, that will be great.
>
>> -Original Message-
>> From: Bhandaru, Malini K 
>> [mailto:malini.k.bhand...@intel.com]
>> Sent: Wednesday, February 12, 2014 12:48 PM
>> To: dev@cloudstack.apache.org
>> Cc: Dugger, Donald D; Jiang, Yunhong; Meshkin, Omid; Manan Shah; Bob Ball;
>> Hoban, Adrian
>> Subject: Exposing PCIe capabilities to the Cloud Scheduler
>>
>> Hello CloudStack-ers!
>>
>> PCIe (Peripheral Component Interconnect Express) devices exist for graphics
>> processing, storage, digital signal processing, accelerating
>> encryption/decryption, and more. Further, within a function class, devices
>> can exhibit different capability levels. Exposing such platform hardware
>> capabilities to the cloud scheduler allows Virtual Machines (VMs) to 
>> explicitly
>> request them for improved performance and for the cloud vendor the
>> opportunity to offer services at different price points. facilitate 
>> differentiated
>> revenur opportunities to the cloud vendor.
>>
>> CloudStack already exposes GPU
>> acceleration> U+and+vGPU+support+for+CloudStack+Guest+Vms>. Along these lines
>> PCIe capabilities, including SR-IOV (Single Root IO virtualization) can be
>> exposed.
>> OpenStack has a set of blueprints for the same. The implementation spans
>> tracking the PCIe devices associated with a host, their use, VM association,
>> and requesting PCIe features. libvirt has been modified to accommodate
>> PCIe discovery. Intel and Mirantis contributed a lot of the code.
>> https://blueprints.launchpad.net/nova/+spec/epa-for-pcie-devices
>> https://blueprints.launchpad.net/nova/+spec/pci-passthrough-libvirt
>>
>> Should you have an interest in supporting such functionality and have
>> technical questions, please get in touch.
>>
>> Regards
>> Malini Bhandaru, Intel



Re: [Proposal] Virtual Router service failure alerting

2014-02-13 Thread Sheng Yang
Hi Hari,

+1. Getting log from VR is a long awaited feature.

One correction: VR does have mgmt network nic, but it doesn't have direct
communcation with mgmt server(in the most case except VMware). So polling
is still needed.

And another comment: you can reuse CheckRouterTask() for the purpose. It
already has been used for s2s vpn connection status update and redundant
router checking, and "router.check.interval" would be used as interval for
checking. You can improve and reuse that rather than introduce another
polling thread for VR.

How can you define "new alart"? Did the file would be deleted/archived
after poll? Or you simply just looking after a certain point? I guess a
diff works better than search for timestamp. More details in implementation
would be helpful.

--Sheng


On Thu, Feb 13, 2014 at 1:56 AM, Harikrishna Patnala <
harikrishna.patn...@citrix.com> wrote:

> Hi,
>
> Currently in CS we can monitor the running services on Virtual Router and
> ensure they are running through the lifetime of VR. Upon failure of any
> service in VR, monitoring service logs the alerts in VR logs.
> These alerts need to be pushed to management server to notify admin.
>
> For this I'd like to introduce the feature Virtual Router service failure
> alerting.
>
> [1] https://issues.apache.org/jira/browse/CLOUDSTACK-6090
> [2]
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Virtual+Router+Service+Failure+Alerting
>
>
> Comments/feedback are welcome
>
> Thank you,
> Harikrishna
>


Re: [Proposal] Virtual Router service failure alerting

2014-02-13 Thread Alena Prokharchyk
Hari, 

You say that ³Virtual router does not have NIC for the management network
so VR cannot send alerts directly to management server and so it should be
polling process from management server to VR²
But there is a way to public an alert via CS WEB API. I¹ve added this
feature exactly to support the case when alert is generated by CS Service
running on a diff host. Please take a look, that might work for your
feature:


https://cwiki.apache.org/confluence/display/CLOUDSTACK/Alert+publishing+via
+Web+ROOT+admin+API



Thanks,
Alena.



On 2/13/14, 12:23 PM, "Sheng Yang"  wrote:

>Hi Hari,
>
>+1. Getting log from VR is a long awaited feature.
>
>One correction: VR does have mgmt network nic, but it doesn't have direct
>communcation with mgmt server(in the most case except VMware). So polling
>is still needed.
>
>And another comment: you can reuse CheckRouterTask() for the purpose. It
>already has been used for s2s vpn connection status update and redundant
>router checking, and "router.check.interval" would be used as interval for
>checking. You can improve and reuse that rather than introduce another
>polling thread for VR.
>
>How can you define "new alart"? Did the file would be deleted/archived
>after poll? Or you simply just looking after a certain point? I guess a
>diff works better than search for timestamp. More details in
>implementation
>would be helpful.
>
>--Sheng
>
>
>On Thu, Feb 13, 2014 at 1:56 AM, Harikrishna Patnala <
>harikrishna.patn...@citrix.com> wrote:
>
>> Hi,
>>
>> Currently in CS we can monitor the running services on Virtual Router
>>and
>> ensure they are running through the lifetime of VR. Upon failure of any
>> service in VR, monitoring service logs the alerts in VR logs.
>> These alerts need to be pushed to management server to notify admin.
>>
>> For this I'd like to introduce the feature Virtual Router service
>>failure
>> alerting.
>>
>> [1] https://issues.apache.org/jira/browse/CLOUDSTACK-6090
>> [2]
>> 
>>https://cwiki.apache.org/confluence/display/CLOUDSTACK/Virtual+Router+Ser
>>vice+Failure+Alerting
>>
>>
>> Comments/feedback are welcome
>>
>> Thank you,
>> Harikrishna
>>



Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions

2014-02-13 Thread Alex Ough
Hi Daan,
Does it look good to you?

Thanks
Alex Ough


On Mon, Feb 10, 2014 at 1:07 PM, Alex Ough  wrote:

>This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17790/
>   Review request for cloudstack.
> By Alex Ough.
>
> *Updated Feb. 10, 2014, 7:06 p.m.*
> Changes
>
> Updates for Daan's request.
>
>   *Repository: * cloudstack-git
> Description
>
> Currently, under the environment of cloudstack with multiple regions, each 
> region has its own management server running with a separate database, which 
> will cause data discrepancies when users create/update/delete 
> domain/account/user data independently in each management server. So to 
> support multiple regions and provide one point of entry for each customer, 
> this implementation duplicates domain/account/user information of customers 
> in one region to all of the regions independently whenever there is any 
> change.
> https://issues.apache.org/jira/browse/CLOUDSTACK-4992https://cwiki.apache.org/confluence/display/CLOUDSTACK/Domain-Account-User+Sync+Up+Among+Multiple+Regions
>
>   Testing
>
> 1. Successfully tested real time synchronization as soon as resources are 
> created/deleted/modified in one region.
> 2. Successfully tested full scans to synchronize resources that were missed 
> during real time synchronization because of any reasons like network 
> connection issues.
> 3. The tests were done manually and also automatically by randomly generating 
> changes each region.
>
>   Diffs (updated)
>
>- api/src/com/cloud/domain/Domain.java (befed07)
>- api/src/com/cloud/event/EventTypes.java (77d2fab)
>- api/src/com/cloud/user/Account.java (940a0eb)
>- api/src/com/cloud/user/AccountService.java (8153a3f)
>- api/src/com/cloud/user/User.java (dcf27a0)
>- api/src/com/cloud/user/UserAccount.java (0cb0f69)
>- api/src/org/apache/cloudstack/api/ApiConstants.java (68abf8d)
>- api/src/org/apache/cloudstack/api/BaseCmd.java (acc1568)
>- api/src/org/apache/cloudstack/api/response/AccountResponse.java
>(957936b)
>- api/src/org/apache/cloudstack/api/response/DomainResponse.java
>(736a96c)
>- api/src/org/apache/cloudstack/api/response/UserResponse.java
>(e70a310)
>- api/src/org/apache/cloudstack/region/Region.java (c696fb2)
>- 
> engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml
>(ea0bad9)
>- engine/schema/src/com/cloud/domain/DomainVO.java (a87bedc)
>- engine/schema/src/com/cloud/rmap/RmapVO.java (PRE-CREATION)
>- engine/schema/src/com/cloud/rmap/dao/RmapDao.java (PRE-CREATION)
>- engine/schema/src/com/cloud/rmap/dao/RmapDaoImpl.java (PRE-CREATION)
>- engine/schema/src/com/cloud/user/AccountVO.java (4a7e73b)
>- engine/schema/src/com/cloud/user/UserAccountVO.java (cfad617)
>- engine/schema/src/com/cloud/user/UserVO.java (2a85758)
>- engine/schema/src/org/apache/cloudstack/region/RegionVO.java
>(36db8dd)
>- framework/db/src/com/cloud/utils/db/Attribute.java (22fd969)
>- framework/db/src/com/cloud/utils/db/GenericDao.java (ef25d7f)
>- framework/db/src/com/cloud/utils/db/GenericDaoBase.java (177cd5b)
>- framework/db/src/com/cloud/utils/db/SqlGenerator.java (473e839)
>- 
> plugins/event-bus/rabbitmq/src/org/apache/cloudstack/mom/rabbitmq/AccountSubscriber.java
>(PRE-CREATION)
>- 
> plugins/event-bus/rabbitmq/src/org/apache/cloudstack/mom/rabbitmq/DomainSubscriber.java
>(PRE-CREATION)
>- 
> plugins/event-bus/rabbitmq/src/org/apache/cloudstack/mom/rabbitmq/MultiRegionEventBus.java
>(PRE-CREATION)
>- 
> plugins/event-bus/rabbitmq/src/org/apache/cloudstack/mom/rabbitmq/MultiRegionSubscriber.java
>(PRE-CREATION)
>- 
> plugins/event-bus/rabbitmq/src/org/apache/cloudstack/mom/rabbitmq/UserSubscriber.java
>(PRE-CREATION)
>- 
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java
>(195e932)
>- server/resources/META-INF/cloudstack/core/spring-event-bus-context.xml
>(PRE-CREATION)
>- server/src/com/cloud/api/ApiDispatcher.java (9624c61)
>- server/src/com/cloud/api/ApiResponseHelper.java (5bd8241)
>- server/src/com/cloud/api/query/dao/AccountJoinDaoImpl.java (edbd3ae)
>- server/src/com/cloud/api/query/dao/UserAccountJoinDaoImpl.java
>(4ad8a8f)
>- server/src/com/cloud/api/query/vo/AccountJoinVO.java (2ec45d3)
>- server/src/com/cloud/api/query/vo/UserAccountJoinVO.java (c020c01)
>- server/src/com/cloud/event/ActionEventUtils.java (00122de)
>- server/src/com/cloud/projects/ProjectManagerImpl.java (22e2020)
>- server/src/com/cloud/region/api_interface/AccountInterface.java
>(PRE-CREATION)
>- server/src/com/cloud/region/api_interface/BaseInterface.java
>(PRE-CREATION)
>- server/src/com/cloud/region/api_interface/DomainInterface.java
>(PRE-CREATION)
>- server/src/com/cloud/region/api_interface/

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions

2014-02-13 Thread Daan Hoogland
h Alex,

 looks alright (i did mean with newlines but I don't know if this is
actually caught by our checkstyle run) I was wondering if you have any unit
tests for your code. I can see you did take testing seriously and I would
like to see this formalized for future reference and repetition on updates.
Can you add some stuff in this line?

thanks,
Daan


On Thu, Feb 13, 2014 at 9:52 PM, Alex Ough  wrote:

> Hi Daan,
> Does it look good to you?
>
> Thanks
> Alex Ough
>
>
> On Mon, Feb 10, 2014 at 1:07 PM, Alex Ough  wrote:
>
>>This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/17790/
>>   Review request for cloudstack.
>> By Alex Ough.
>>
>> *Updated Feb. 10, 2014, 7:06 p.m.*
>> Changes
>>
>> Updates for Daan's request.
>>
>>   *Repository: * cloudstack-git
>> Description
>>
>> Currently, under the environment of cloudstack with multiple regions, each 
>> region has its own management server running with a separate database, which 
>> will cause data discrepancies when users create/update/delete 
>> domain/account/user data independently in each management server. So to 
>> support multiple regions and provide one point of entry for each customer, 
>> this implementation duplicates domain/account/user information of customers 
>> in one region to all of the regions independently whenever there is any 
>> change.
>> https://issues.apache.org/jira/browse/CLOUDSTACK-4992https://cwiki.apache.org/confluence/display/CLOUDSTACK/Domain-Account-User+Sync+Up+Among+Multiple+Regions
>>
>>   Testing
>>
>> 1. Successfully tested real time synchronization as soon as resources are 
>> created/deleted/modified in one region.
>> 2. Successfully tested full scans to synchronize resources that were missed 
>> during real time synchronization because of any reasons like network 
>> connection issues.
>> 3. The tests were done manually and also automatically by randomly 
>> generating changes each region.
>>
>>   Diffs (updated)
>>
>>- api/src/com/cloud/domain/Domain.java (befed07)
>>- api/src/com/cloud/event/EventTypes.java (77d2fab)
>>- api/src/com/cloud/user/Account.java (940a0eb)
>>- api/src/com/cloud/user/AccountService.java (8153a3f)
>>- api/src/com/cloud/user/User.java (dcf27a0)
>>- api/src/com/cloud/user/UserAccount.java (0cb0f69)
>>- api/src/org/apache/cloudstack/api/ApiConstants.java (68abf8d)
>>- api/src/org/apache/cloudstack/api/BaseCmd.java (acc1568)
>>- api/src/org/apache/cloudstack/api/response/AccountResponse.java
>>(957936b)
>>- api/src/org/apache/cloudstack/api/response/DomainResponse.java
>>(736a96c)
>>- api/src/org/apache/cloudstack/api/response/UserResponse.java
>>(e70a310)
>>- api/src/org/apache/cloudstack/region/Region.java (c696fb2)
>>- 
>> engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml
>>(ea0bad9)
>>- engine/schema/src/com/cloud/domain/DomainVO.java (a87bedc)
>>- engine/schema/src/com/cloud/rmap/RmapVO.java (PRE-CREATION)
>>- engine/schema/src/com/cloud/rmap/dao/RmapDao.java (PRE-CREATION)
>>- engine/schema/src/com/cloud/rmap/dao/RmapDaoImpl.java (PRE-CREATION)
>>- engine/schema/src/com/cloud/user/AccountVO.java (4a7e73b)
>>- engine/schema/src/com/cloud/user/UserAccountVO.java (cfad617)
>>- engine/schema/src/com/cloud/user/UserVO.java (2a85758)
>>- engine/schema/src/org/apache/cloudstack/region/RegionVO.java
>>(36db8dd)
>>- framework/db/src/com/cloud/utils/db/Attribute.java (22fd969)
>>- framework/db/src/com/cloud/utils/db/GenericDao.java (ef25d7f)
>>- framework/db/src/com/cloud/utils/db/GenericDaoBase.java (177cd5b)
>>- framework/db/src/com/cloud/utils/db/SqlGenerator.java (473e839)
>>- 
>> plugins/event-bus/rabbitmq/src/org/apache/cloudstack/mom/rabbitmq/AccountSubscriber.java
>>(PRE-CREATION)
>>- 
>> plugins/event-bus/rabbitmq/src/org/apache/cloudstack/mom/rabbitmq/DomainSubscriber.java
>>(PRE-CREATION)
>>- 
>> plugins/event-bus/rabbitmq/src/org/apache/cloudstack/mom/rabbitmq/MultiRegionEventBus.java
>>(PRE-CREATION)
>>- 
>> plugins/event-bus/rabbitmq/src/org/apache/cloudstack/mom/rabbitmq/MultiRegionSubscriber.java
>>(PRE-CREATION)
>>- 
>> plugins/event-bus/rabbitmq/src/org/apache/cloudstack/mom/rabbitmq/UserSubscriber.java
>>(PRE-CREATION)
>>- 
>> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java
>>(195e932)
>>- server/resources/META-INF/cloudstack/core/spring-event-bus-context.xml
>>(PRE-CREATION)
>>- server/src/com/cloud/api/ApiDispatcher.java (9624c61)
>>- server/src/com/cloud/api/ApiResponseHelper.java (5bd8241)
>>- server/src/com/cloud/api/query/dao/AccountJoinDaoImpl.java (edbd3ae)
>>- server/src/com/cloud/api/query/dao/UserAccountJoinDaoImpl.java
>>(4ad8a8f)
>>- server/src/com/cloud/api/query/vo/AccountJoinVO.java (2ec45d3)
>>- server

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions

2014-02-13 Thread Alex Ough
We're just about to add unit tests, so I'll add them once completed.

Thanks
Alex Ough


On Thu, Feb 13, 2014 at 3:12 PM, Daan Hoogland wrote:

> h Alex,
>
>  looks alright (i did mean with newlines but I don't know if this is
> actually caught by our checkstyle run) I was wondering if you have any unit
> tests for your code. I can see you did take testing seriously and I would
> like to see this formalized for future reference and repetition on updates.
> Can you add some stuff in this line?
>
> thanks,
> Daan
>
>
> On Thu, Feb 13, 2014 at 9:52 PM, Alex Ough  wrote:
>
>> Hi Daan,
>> Does it look good to you?
>>
>> Thanks
>> Alex Ough
>>
>>
>> On Mon, Feb 10, 2014 at 1:07 PM, Alex Ough  wrote:
>>
>>>This is an automatically generated e-mail. To reply, visit:
>>> https://reviews.apache.org/r/17790/
>>>   Review request for cloudstack.
>>> By Alex Ough.
>>>
>>> *Updated Feb. 10, 2014, 7:06 p.m.*
>>> Changes
>>>
>>> Updates for Daan's request.
>>>
>>>   *Repository: * cloudstack-git
>>> Description
>>>
>>> Currently, under the environment of cloudstack with multiple regions, each 
>>> region has its own management server running with a separate database, 
>>> which will cause data discrepancies when users create/update/delete 
>>> domain/account/user data independently in each management server. So to 
>>> support multiple regions and provide one point of entry for each customer, 
>>> this implementation duplicates domain/account/user information of customers 
>>> in one region to all of the regions independently whenever there is any 
>>> change.
>>> https://issues.apache.org/jira/browse/CLOUDSTACK-4992https://cwiki.apache.org/confluence/display/CLOUDSTACK/Domain-Account-User+Sync+Up+Among+Multiple+Regions
>>>
>>>   Testing
>>>
>>> 1. Successfully tested real time synchronization as soon as resources are 
>>> created/deleted/modified in one region.
>>> 2. Successfully tested full scans to synchronize resources that were missed 
>>> during real time synchronization because of any reasons like network 
>>> connection issues.
>>> 3. The tests were done manually and also automatically by randomly 
>>> generating changes each region.
>>>
>>>   Diffs (updated)
>>>
>>>- api/src/com/cloud/domain/Domain.java (befed07)
>>>- api/src/com/cloud/event/EventTypes.java (77d2fab)
>>>- api/src/com/cloud/user/Account.java (940a0eb)
>>>- api/src/com/cloud/user/AccountService.java (8153a3f)
>>>- api/src/com/cloud/user/User.java (dcf27a0)
>>>- api/src/com/cloud/user/UserAccount.java (0cb0f69)
>>>- api/src/org/apache/cloudstack/api/ApiConstants.java (68abf8d)
>>>- api/src/org/apache/cloudstack/api/BaseCmd.java (acc1568)
>>>- api/src/org/apache/cloudstack/api/response/AccountResponse.java
>>>(957936b)
>>>- api/src/org/apache/cloudstack/api/response/DomainResponse.java
>>>(736a96c)
>>>- api/src/org/apache/cloudstack/api/response/UserResponse.java
>>>(e70a310)
>>>- api/src/org/apache/cloudstack/region/Region.java (c696fb2)
>>>- 
>>> engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml
>>>(ea0bad9)
>>>- engine/schema/src/com/cloud/domain/DomainVO.java (a87bedc)
>>>- engine/schema/src/com/cloud/rmap/RmapVO.java (PRE-CREATION)
>>>- engine/schema/src/com/cloud/rmap/dao/RmapDao.java (PRE-CREATION)
>>>- engine/schema/src/com/cloud/rmap/dao/RmapDaoImpl.java
>>>(PRE-CREATION)
>>>- engine/schema/src/com/cloud/user/AccountVO.java (4a7e73b)
>>>- engine/schema/src/com/cloud/user/UserAccountVO.java (cfad617)
>>>- engine/schema/src/com/cloud/user/UserVO.java (2a85758)
>>>- engine/schema/src/org/apache/cloudstack/region/RegionVO.java
>>>(36db8dd)
>>>- framework/db/src/com/cloud/utils/db/Attribute.java (22fd969)
>>>- framework/db/src/com/cloud/utils/db/GenericDao.java (ef25d7f)
>>>- framework/db/src/com/cloud/utils/db/GenericDaoBase.java (177cd5b)
>>>- framework/db/src/com/cloud/utils/db/SqlGenerator.java (473e839)
>>>- 
>>> plugins/event-bus/rabbitmq/src/org/apache/cloudstack/mom/rabbitmq/AccountSubscriber.java
>>>(PRE-CREATION)
>>>- 
>>> plugins/event-bus/rabbitmq/src/org/apache/cloudstack/mom/rabbitmq/DomainSubscriber.java
>>>(PRE-CREATION)
>>>- 
>>> plugins/event-bus/rabbitmq/src/org/apache/cloudstack/mom/rabbitmq/MultiRegionEventBus.java
>>>(PRE-CREATION)
>>>- 
>>> plugins/event-bus/rabbitmq/src/org/apache/cloudstack/mom/rabbitmq/MultiRegionSubscriber.java
>>>(PRE-CREATION)
>>>- 
>>> plugins/event-bus/rabbitmq/src/org/apache/cloudstack/mom/rabbitmq/UserSubscriber.java
>>>(PRE-CREATION)
>>>- 
>>> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java
>>>(195e932)
>>>- server/resources/META-INF/cloudstack/core/spring-event-bus-context.xml
>>>(PRE-CREATION)
>>>- server/src/com/cloud/api/ApiDispatcher.java (9624c61)
>>>- server/src/com/cloud/api/ApiResponse

Re: UI Latency

2014-02-13 Thread John Kinsella
Seems a bit like wheel-reinventing, no? Wouldn’t it be cleaner to get Tomcat’s 
built-in compression[1] working? What I don’t see in your code is any ability 
to negotiate if the end-client supports gzip compression...

John
1:http://viralpatel.net/blogs/enable-gzip-compression-in-tomcat/

On Feb 13, 2014, at 12:09 PM, Laszlo Hornyak 
mailto:laszlo.horn...@gmail.com>> wrote:

Ah yes we are playing space-wars, I will fix it as soon as I get there. I
was not that much interested in space/tabs but what it already does:
- at build time it generates .gz files from static resources, like css,
html and js files
- during runtime it checks if there is a gz file for the resource and
silently serves the gz file and sets the headers, only if the client
browser accepts gz of course
- respects Etag since you do not want to download even "just" 500 Kb each
time you hit ctrl-r.

TODO other than the space-war:
- it uses a maven plugin I have built for home use, it is in my maven repo
and it would not be great to give my unreliable repository to everyone, so
it should be either moved to the ACS source or uploaded to the central repo
- Some a would not like to make the build even longer. It is quite short
compared to the full time of the build, but for a CI build it is completely
useless. So it must be moved to a profile and profile should be active
during release process, maybe not anyway unless you manually enable it.




On Thu, Feb 13, 2014 at 7:23 PM, John Kinsella 
mailto:j...@stratosec.co>> wrote:

Looks like Daan had a few issues with the patch for you to resolve
regarding tabs and headers...

On Feb 13, 2014, at 10:14 AM, Laszlo Hornyak 
mailto:laszlo.horn...@gmail.com>
> wrote:

Hi,

I have a patch for the UI compression, it is on review for a while...
But I hope I will be able to resolve the comments in...days.

I measured the download size dropped from 3.5 MB to somewhere around 0.5 MB

https://reviews.apache.org/r/12228/

Adding javascript compression could also help a lot.

That 3.5 M is a lot even on LAN :-)



On Thu, Feb 13, 2014 at 7:04 PM, John Kinsella  wrote:

Just posted
http://theresnomon.co/2014/improving-cloudstack-ui-performance/ - open to
any comments.

John

On Feb 10, 2014, at 12:47 AM, Alex Hitchins mailto:alex.hitch...@shapeblue.com>> wrote:

Sounds interesting, I look forward to your write-up.



Regards

Alex Hitchins

D: +44 1892 523 587 | S: +44 20 3603 0540 | M: +44 7788 423 969

alex.hitch...@shapeblue.com

-Original Message-
From: John Kinsella [mailto:j...@stratosec.co]
Sent: 10 February 2014 01:05
To: 
Subject: Re: UI Latency

I've been tinkering with httpd proxying the UI via mod_proxy_ajp, then
using mod_deflate to compress on the httpd side. That gets me about a 2.5x
decrease in loading the login screen. system.js, which is the largest item
downloaded by default is around 980k, with gzip that drops to 68k.

I wanna see if I can squeeze a little more performance out by caching the
static stuff...once I get some stats out of that I'll turn it into a blog
post later this week.

John

On Feb 9, 2014, at 3:27 PM, Alex Hitchins 
wrote:

One of the things that I want to look in to is generating a Gruntfile so
we can 'uglify' and reduce the size of css, js and image sprites. This
should help reduce the initial payload and make a big difference to VPN/low
b/w connections.


Regards

Alex Hitchins

D: +44 1892 523 587 | S: +44 20 3603 0540 | M: +44 7788 423 969

alex.hitch...@shapeblue.com

-Original Message-
From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
Sent: 09 February 2014 19:51
To: dev@cloudstack.apache.org
Subject: Re: UI Latency

I could be wrong, but I believe the idea of zipping the content for the UI
start page was discussed, but has not yet been implemented.

As far as I know (and have experienced), every time you go to the start
page, it does seem to take a while to load if you are not over a
particularly fast connection (if I'm in the office, it loads quickly; if
I'm over a VPN connection from, say, home, it tends to be noticeably
slower).


On Sun, Feb 9, 2014 at 8:46 AM, Mo  wrote:

Hello,

>From my understanding going to the UI at first start-up takes awhile
to load due to the way it is configured, I believe I was previously
told it was gzip for the website. However, I thought this would a one
time thing; it seems to take quite awhile to load UI each time I
visit, unlike versions gone by.

Any advice? Suggestions?

- Maurice




--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*(tm)*
Need Enterprise Grade Support for Apache CloudStack?
Our CloudStack Infrastructure Support<
http://shapeblue.com/cloudstack-infrastructure-support/> offers the best
24/7 SLA for CloudStack Environments.

Apache CloudStack Bootcamp training cour

Re: [4.3]

2014-02-13 Thread Daan Hoogland
coming up, just a moment


On Thu, Feb 13, 2014 at 8:44 PM, Animesh Chaturvedi
 wrote:
> Can you log a separate bug then? At this point all commits to 4.3-forward 
> should have a bug id associated with it.
>
>> -Original Message-
>> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
>> Sent: Thursday, February 13, 2014 10:07 AM
>> To: Animesh Chaturvedi
>> Cc: dev
>> Subject: Re: [4.3]
>>
>> no, it is for a bug in the nicira base private gateways. unrelated.
>>
>> On Thu, Feb 13, 2014 at 6:16 PM, Animesh Chaturvedi
>>  wrote:
>> > What is this fix for? Is this for CLOUDSTACK-6069?
>> >
>> >> -Original Message-
>> >> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
>> >> Sent: Thursday, February 13, 2014 5:25 AM
>> >> To: Animesh Chaturvedi
>> >> Cc: dev
>> >> Subject: [4.3]
>> >>
>> >> Animesh,
>> >>
>> >> Can you please cherry-pick 5af163ff7f658c30c6d93b50ac17c9cc0c5eb8c1
>> >> onto 4.3?
>> >>
>> >> thanks,
>> >> --
>> >> Daan
>>
>>
>>
>> --
>> Daan



-- 
Daan


Re: Exposing PCIe capabilities to the Cloud Scheduler

2014-02-13 Thread Marcus
I think it's interesting, the PCI discovery that was mentioned, it
would alleviate the manual agent.properties config that the patch
requires.  I imagine it will be available in the Ubuntu 14.04 release
as well, assuming they're targeting current versions.

On Thu, Feb 13, 2014 at 1:21 PM, Edison Su  wrote:
> Hi Ryousei,
>  The patch sounds good to me, don’t know why it’s not got checked into 
> 4.2 or 4.3. Is it ok for you to rebase to master? After that, I’ll check it 
> into master.
>
>
> From: 高野了成 [mailto:takano-ryou...@aist.go.jp]
> Sent: Thursday, February 13, 2014 4:08 AM
> To: dev@cloudstack.apache.org
> Cc: malini.k.bhand...@intel.com; Edison Su; Dugger, Donald D; 
> yunhong.ji...@intel.com; Meshkin, Omid; Manan Shah; Bob Ball; Hoban, Adrian
> Subject: RE: Exposing PCIe capabilities to the Cloud Scheduler
>
> Dear Edison Su and Malini Bhandaru,
>
> I am the mentor of Pawit, who has submitted PCI passthrough patch last year.
> We have been developing this feature for operating our private cloud based on
> CloudStack 4.2.1.
> Now our users can deploy and migrate a VM instance with an InfiniBand 
> interface.
>
> We hope to improve our patch and merge into CloudStack.
> Your comments and suggestions are welcome.
>
> Best regards,
> Ryousei
>
>> Welcome, my dear Intel friends:)
>> Last year, community has contributed code regarding to add PCI passthrough 
>> into CloudStack, see the patch: https://reviews.apache.org/r/12098/, but 
>> unfortunately, this patch doesn't get checked in, due to lack of support 
>> from committer: http://markmail.org/message/ux2ojhxfqwdvz2uc.
>> If you guys want to pick it up, either work from scratch, or based on the 
>> original patch, that will be great.
>>
>>> -Original Message-
>>> From: Bhandaru, Malini K 
>>> [mailto:malini.k.bhand...@intel.com]
>>> Sent: Wednesday, February 12, 2014 12:48 PM
>>> To: dev@cloudstack.apache.org
>>> Cc: Dugger, Donald D; Jiang, Yunhong; Meshkin, Omid; Manan Shah; Bob Ball;
>>> Hoban, Adrian
>>> Subject: Exposing PCIe capabilities to the Cloud Scheduler
>>>
>>> Hello CloudStack-ers!
>>>
>>> PCIe (Peripheral Component Interconnect Express) devices exist for graphics
>>> processing, storage, digital signal processing, accelerating
>>> encryption/decryption, and more. Further, within a function class, devices
>>> can exhibit different capability levels. Exposing such platform hardware
>>> capabilities to the cloud scheduler allows Virtual Machines (VMs) to 
>>> explicitly
>>> request them for improved performance and for the cloud vendor the
>>> opportunity to offer services at different price points. facilitate 
>>> differentiated
>>> revenur opportunities to the cloud vendor.
>>>
>>> CloudStack already exposes GPU
>>> acceleration>> U+and+vGPU+support+for+CloudStack+Guest+Vms>. Along these lines
>>> PCIe capabilities, including SR-IOV (Single Root IO virtualization) can be
>>> exposed.
>>> OpenStack has a set of blueprints for the same. The implementation spans
>>> tracking the PCIe devices associated with a host, their use, VM association,
>>> and requesting PCIe features. libvirt has been modified to accommodate
>>> PCIe discovery. Intel and Mirantis contributed a lot of the code.
>>> https://blueprints.launchpad.net/nova/+spec/epa-for-pcie-devices
>>> https://blueprints.launchpad.net/nova/+spec/pci-passthrough-libvirt
>>>
>>> Should you have an interest in supporting such functionality and have
>>> technical questions, please get in touch.
>>>
>>> Regards
>>> Malini Bhandaru, Intel
>


Re: [4.3]

2014-02-13 Thread Daan Hoogland
CLOUDSTACK-6100

On Thu, Feb 13, 2014 at 10:32 PM, Daan Hoogland  wrote:
> coming up, just a moment
>
>
> On Thu, Feb 13, 2014 at 8:44 PM, Animesh Chaturvedi
>  wrote:
>> Can you log a separate bug then? At this point all commits to 4.3-forward 
>> should have a bug id associated with it.
>>
>>> -Original Message-
>>> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
>>> Sent: Thursday, February 13, 2014 10:07 AM
>>> To: Animesh Chaturvedi
>>> Cc: dev
>>> Subject: Re: [4.3]
>>>
>>> no, it is for a bug in the nicira base private gateways. unrelated.
>>>
>>> On Thu, Feb 13, 2014 at 6:16 PM, Animesh Chaturvedi
>>>  wrote:
>>> > What is this fix for? Is this for CLOUDSTACK-6069?
>>> >
>>> >> -Original Message-
>>> >> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
>>> >> Sent: Thursday, February 13, 2014 5:25 AM
>>> >> To: Animesh Chaturvedi
>>> >> Cc: dev
>>> >> Subject: [4.3]
>>> >>
>>> >> Animesh,
>>> >>
>>> >> Can you please cherry-pick 5af163ff7f658c30c6d93b50ac17c9cc0c5eb8c1
>>> >> onto 4.3?
>>> >>
>>> >> thanks,
>>> >> --
>>> >> Daan
>>>
>>>
>>>
>>> --
>>> Daan
>
>
>
> --
> Daan



-- 
Daan


[CANCELLED] [VOTE] Apache CloudStack 4.3.0 (fourth round)

2014-02-13 Thread Animesh Chaturvedi
Formally canceling this VOTE out and building another RC. 

> -Original Message-
> From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com]
> Sent: Friday, February 07, 2014 4:52 PM
> To: dev@cloudstack.apache.org
> Subject: [VOTE] Apache CloudStack 4.3.0 (fourth round)
> 
> 
> 
> Hi All,
> 
> 
> 
> I've created a 4.3.0 release, with the following artifacts up for a
> 
> vote:
> 
> 
> 
> Git Branch and Commit SH:
> 
> https://git-wip-
> us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.3
> Commit: c1af92fcbbc183873d6519f0660b68acfb33bd44
> 
> 
> List of changes:
> 
>  here for now>
> 
> New Features in 4.3: https://issues.apache.org/jira/issues/?filter=12325248
> 
> Improvement in 4.3: https://issues.apache.org/jira/issues/?filter=12325249
> 
> Issues fixed in 4.3 https://issues.apache.org/jira/issues/?filter=12326161
> 
> Known Issues in 4.3: https://issues.apache.org/jira/issues/?filter=12326162
> 
> 
> 
> 
> 
> 
> 
> Source release (checksums and signatures are available at the same
> 
> location):
> 
> https://dist.apache.org/repos/dist/dev/cloudstack/4.3.0/
> 
> 
> 
> PGP release keys (signed using 94BE0D7C):
> 
> https://dist.apache.org/repos/dist/release/cloudstack/KEYS
> 
> 
> 
> Testing instructions are here:
> 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Release+test+pro
> cedure
> 
> 
> 
> Vote will be open for 3 working days and will close on Wednesday 2/12
> 5:00PM PST.
> 
> 
> 
> For sanity in tallying the vote, can PMC members please be sure to indicate
> "(binding)" with their vote?
> 
> 
> 
> [ ] +1  approve
> 
> [ ] +0  no opinion
> 
> [ ] -1  disapprove (and reason why)
> 



Re: copying a template from random zone

2014-02-13 Thread Daan Hoogland
ok that explains that I first thought it wouldn't and then that it
would work. I started at master and today looked at 4.3. As soon as we
have a 4.3 in one of our multi-zone envs I will verify.

On Thu, Feb 13, 2014 at 8:45 PM, Min Chen  wrote:
> Daan, just noticed that you are reading code from master, then your
> analysis is not wrong. Edison hasn't cherry-pick his commit to master yet.
>
> Thanks
> -min
>
> On 2/13/14 10:53 AM, "Daan Hoogland"  wrote:
>
>>I saw in code that my first analysis that this would still be a
>>problem was wrong. I have not devised a way to verify yet. thanks for
>>the confirmation, Min
>>
>>On Thu, Feb 13, 2014 at 7:47 PM, Min Chen  wrote:
>>> Edison has already fixed this in ACS 4.3 and master, See commit
>>>
>>>https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=1b064
>>>51
>>> 5ac9c7f87e1780ab2210e60723f9d541c.
>>>
>>> Thanks
>>> -min
>>>
>>> On 2/12/14 8:16 AM, "Daan Hoogland"  wrote:
>>>
LS,

It seems that when instantiating a vm from a template cloudstack tries
to copy the template from a random secondary storage
https://issues.apache.org/jira/browse/CLOUDSTACK-6024

the result is that the copy from secondary storage to primary fails
and thus instantiation of the vm.

This is in 4.2.1 but I looked into the master code and it seems to
still call code that uses a random result for the origin of the
template. Any of the storage guru's know if my analysis is correct and
how to handle this?

--
Daan
>>>
>>
>>
>>
>>--
>>Daan
>



-- 
Daan


Re: [Proposal] Virtual Router service failure alerting

2014-02-13 Thread Sheng Yang
Alena,

Mgmt server may not be accessible by VR directly, and there is no way for
VR to communicate with the host it's running on directly...

--Sheng


On Thu, Feb 13, 2014 at 12:45 PM, Alena Prokharchyk <
alena.prokharc...@citrix.com> wrote:

> Hari,
>
> You say that ³Virtual router does not have NIC for the management network
> so VR cannot send alerts directly to management server and so it should be
> polling process from management server to VR²
> But there is a way to public an alert via CS WEB API. I¹ve added this
> feature exactly to support the case when alert is generated by CS Service
> running on a diff host. Please take a look, that might work for your
> feature:
>
>
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Alert+publishing+via
> +Web+ROOT+admin+API
>
>
>
> Thanks,
> Alena.
>
>
>
> On 2/13/14, 12:23 PM, "Sheng Yang"  wrote:
>
> >Hi Hari,
> >
> >+1. Getting log from VR is a long awaited feature.
> >
> >One correction: VR does have mgmt network nic, but it doesn't have direct
> >communcation with mgmt server(in the most case except VMware). So polling
> >is still needed.
> >
> >And another comment: you can reuse CheckRouterTask() for the purpose. It
> >already has been used for s2s vpn connection status update and redundant
> >router checking, and "router.check.interval" would be used as interval for
> >checking. You can improve and reuse that rather than introduce another
> >polling thread for VR.
> >
> >How can you define "new alart"? Did the file would be deleted/archived
> >after poll? Or you simply just looking after a certain point? I guess a
> >diff works better than search for timestamp. More details in
> >implementation
> >would be helpful.
> >
> >--Sheng
> >
> >
> >On Thu, Feb 13, 2014 at 1:56 AM, Harikrishna Patnala <
> >harikrishna.patn...@citrix.com> wrote:
> >
> >> Hi,
> >>
> >> Currently in CS we can monitor the running services on Virtual Router
> >>and
> >> ensure they are running through the lifetime of VR. Upon failure of any
> >> service in VR, monitoring service logs the alerts in VR logs.
> >> These alerts need to be pushed to management server to notify admin.
> >>
> >> For this I'd like to introduce the feature Virtual Router service
> >>failure
> >> alerting.
> >>
> >> [1] https://issues.apache.org/jira/browse/CLOUDSTACK-6090
> >> [2]
> >>
> >>
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Virtual+Router+Ser
> >>vice+Failure+Alerting
> >>
> >>
> >> Comments/feedback are welcome
> >>
> >> Thank you,
> >> Harikrishna
> >>
>
>


Re: [Proposal] Virtual Router service failure alerting

2014-02-13 Thread Sheng Yang
I meant, host can access VR, but VR can't access host(e.g. ssh into host),
which is in the control network.

--Sheng


On Thu, Feb 13, 2014 at 1:55 PM, Sheng Yang  wrote:

> Alena,
>
> Mgmt server may not be accessible by VR directly, and there is no way for
> VR to communicate with the host it's running on directly...
>
> --Sheng
>
>
> On Thu, Feb 13, 2014 at 12:45 PM, Alena Prokharchyk <
> alena.prokharc...@citrix.com> wrote:
>
>> Hari,
>>
>> You say that ³Virtual router does not have NIC for the management network
>> so VR cannot send alerts directly to management server and so it should be
>> polling process from management server to VR²
>> But there is a way to public an alert via CS WEB API. I¹ve added this
>> feature exactly to support the case when alert is generated by CS Service
>> running on a diff host. Please take a look, that might work for your
>> feature:
>>
>>
>>
>> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Alert+publishing+via
>> +Web+ROOT+admin+API
>>
>>
>>
>> Thanks,
>> Alena.
>>
>>
>>
>> On 2/13/14, 12:23 PM, "Sheng Yang"  wrote:
>>
>> >Hi Hari,
>> >
>> >+1. Getting log from VR is a long awaited feature.
>> >
>> >One correction: VR does have mgmt network nic, but it doesn't have direct
>> >communcation with mgmt server(in the most case except VMware). So polling
>> >is still needed.
>> >
>> >And another comment: you can reuse CheckRouterTask() for the purpose. It
>> >already has been used for s2s vpn connection status update and redundant
>> >router checking, and "router.check.interval" would be used as interval
>> for
>> >checking. You can improve and reuse that rather than introduce another
>> >polling thread for VR.
>> >
>> >How can you define "new alart"? Did the file would be deleted/archived
>> >after poll? Or you simply just looking after a certain point? I guess a
>> >diff works better than search for timestamp. More details in
>> >implementation
>> >would be helpful.
>> >
>> >--Sheng
>> >
>> >
>> >On Thu, Feb 13, 2014 at 1:56 AM, Harikrishna Patnala <
>> >harikrishna.patn...@citrix.com> wrote:
>> >
>> >> Hi,
>> >>
>> >> Currently in CS we can monitor the running services on Virtual Router
>> >>and
>> >> ensure they are running through the lifetime of VR. Upon failure of any
>> >> service in VR, monitoring service logs the alerts in VR logs.
>> >> These alerts need to be pushed to management server to notify admin.
>> >>
>> >> For this I'd like to introduce the feature Virtual Router service
>> >>failure
>> >> alerting.
>> >>
>> >> [1] https://issues.apache.org/jira/browse/CLOUDSTACK-6090
>> >> [2]
>> >>
>> >>
>> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Virtual+Router+Ser
>> >>vice+Failure+Alerting
>> >>
>> >>
>> >> Comments/feedback are welcome
>> >>
>> >> Thank you,
>> >> Harikrishna
>> >>
>>
>>
>


Cherry pick confirmation needed

2014-02-13 Thread Animesh Chaturvedi
Marcus

I see your commits in 4.3-forward for CLOUDSTACK-6089. Do you want it to be 
picked up for RC?

Animesh


Re: [Proposal] Virtual Router service failure alerting

2014-02-13 Thread Alena Prokharchyk
Yea, it would work only if:

* MS Web services ip (or its LB ip) is accessible via internet, and VR can
access internet as well


Btw, its not ssh-ing to MS host, but sending http request to API CS web
server.

-Alena.

On 2/13/14, 1:57 PM, "Sheng Yang"  wrote:

>I meant, host can access VR, but VR can't access host(e.g. ssh into host),
>which is in the control network.
>
>--Sheng
>
>
>On Thu, Feb 13, 2014 at 1:55 PM, Sheng Yang  wrote:
>
>> Alena,
>>
>> Mgmt server may not be accessible by VR directly, and there is no way
>>for
>> VR to communicate with the host it's running on directly...
>>
>> --Sheng
>>
>>
>> On Thu, Feb 13, 2014 at 12:45 PM, Alena Prokharchyk <
>> alena.prokharc...@citrix.com> wrote:
>>
>>> Hari,
>>>
>>> You say that ³Virtual router does not have NIC for the management
>>>network
>>> so VR cannot send alerts directly to management server and so it
>>>should be
>>> polling process from management server to VR²
>>> But there is a way to public an alert via CS WEB API. I¹ve added this
>>> feature exactly to support the case when alert is generated by CS
>>>Service
>>> running on a diff host. Please take a look, that might work for your
>>> feature:
>>>
>>>
>>>
>>> 
>>>https://cwiki.apache.org/confluence/display/CLOUDSTACK/Alert+publishing+
>>>via
>>> +Web+ROOT+admin+API
>>>
>>>
>>>
>>> Thanks,
>>> Alena.
>>>
>>>
>>>
>>> On 2/13/14, 12:23 PM, "Sheng Yang"  wrote:
>>>
>>> >Hi Hari,
>>> >
>>> >+1. Getting log from VR is a long awaited feature.
>>> >
>>> >One correction: VR does have mgmt network nic, but it doesn't have
>>>direct
>>> >communcation with mgmt server(in the most case except VMware). So
>>>polling
>>> >is still needed.
>>> >
>>> >And another comment: you can reuse CheckRouterTask() for the purpose.
>>>It
>>> >already has been used for s2s vpn connection status update and
>>>redundant
>>> >router checking, and "router.check.interval" would be used as interval
>>> for
>>> >checking. You can improve and reuse that rather than introduce another
>>> >polling thread for VR.
>>> >
>>> >How can you define "new alart"? Did the file would be deleted/archived
>>> >after poll? Or you simply just looking after a certain point? I guess
>>>a
>>> >diff works better than search for timestamp. More details in
>>> >implementation
>>> >would be helpful.
>>> >
>>> >--Sheng
>>> >
>>> >
>>> >On Thu, Feb 13, 2014 at 1:56 AM, Harikrishna Patnala <
>>> >harikrishna.patn...@citrix.com> wrote:
>>> >
>>> >> Hi,
>>> >>
>>> >> Currently in CS we can monitor the running services on Virtual
>>>Router
>>> >>and
>>> >> ensure they are running through the lifetime of VR. Upon failure of
>>>any
>>> >> service in VR, monitoring service logs the alerts in VR logs.
>>> >> These alerts need to be pushed to management server to notify admin.
>>> >>
>>> >> For this I'd like to introduce the feature Virtual Router service
>>> >>failure
>>> >> alerting.
>>> >>
>>> >> [1] https://issues.apache.org/jira/browse/CLOUDSTACK-6090
>>> >> [2]
>>> >>
>>> >>
>>> 
>>>https://cwiki.apache.org/confluence/display/CLOUDSTACK/Virtual+Router+Se
>>>r
>>> >>vice+Failure+Alerting
>>> >>
>>> >>
>>> >> Comments/feedback are welcome
>>> >>
>>> >> Thank you,
>>> >> Harikrishna
>>> >>
>>>
>>>
>>



RE: [VOTE] Apache CloudStack 4.3.0 (fourth round) UPDATE

2014-02-13 Thread Animesh Chaturvedi


> -Original Message-
> From: Nux! [mailto:n...@li.nux.ro]
> Sent: Thursday, February 13, 2014 3:12 AM
> To: dev@cloudstack.apache.org
> Subject: Re: [VOTE] Apache CloudStack 4.3.0 (fourth round) UPDATE
> 
> On 13.02.2014 05:28, Animesh Chaturvedi wrote:
> >
> > 1. CLOUDSTACK-6083 : Missing CIDRs in firewall rules after upgrade  =>
> > Waiting on Jayapal to confirm and update the list with findings
> 
> Jayapal's fix works for me.
> 
> > 3. CLOUDSTACK-6065: KVM HA not working for shutdown VMs => While an
> > issue but my understanding is it is a corner scenario only affecting
> > KVM and can be released  as a known issue
> 
> Well, it's effectively breaking HA as defined in the docs for a main hv type
> and as it is I can't use 4.3 in production. Is there a fix in sight?
> 
[Animesh]  Following up with Kelven if he can check on it
> Lucian
> 
> --
> Sent from the Delta quadrant using Borg technology!
> 
> Nux!
> www.nux.ro


Re: XEN | CentOS | Cloud 4.2 | Error Message - Agent Disconnected.

2014-02-13 Thread Daan Hoogland
Maurice,

what version are you running on what kind of environment?

thanks,
Daan

On Thu, Feb 13, 2014 at 5:32 AM, Mo  wrote:
> Hello,
>
> Can someone shed some light on this error message?
>
>  * Something went wrong; please correct the following:
>Cannot transit agent status with event AgentDisconnected for host 1,
>mangement server id is 161344192609,Unable to transition to a new
>state from Creating via AgentDisconnected
>
>
> =
>
>
> 2014-02-12 23:25:03,365 DEBUG [agent.manager.AgentManagerImpl]
> (catalina-exec-12:null) Sending Disconnect to listener:
> com.cloud.consoleproxy.ConsoleProxyListener
> 2014-02-12 23:25:03,366 DEBUG [cloud.host.Status] (catalina-exec-12:null)
> Transition:[Resource state = Enabled, Agent event = AgentDisconnected, Host
> id = 1, name = node1.domain.com]
> 2014-02-12 23:25:03,447 DEBUG [cloud.host.Status] (catalina-exec-12:null)
> Agent status update: [id = 1; name = node1.domain.com; old status =
> Connecting; event = AgentDisconnected; new status = Alert; old update count
> = 1; new update count = 2]
> 2014-02-12 23:25:03,448 DEBUG [agent.manager.ClusteredAgentManagerImpl]
> (catalina-exec-12:null) Notifying other nodes of to disconnect
> 2014-02-12 23:25:03,449 WARN  [cloud.resource.ResourceManagerImpl]
> (catalina-exec-12:null) Unable to connect due to
> com.cloud.utils.exception.CloudRuntimeException: Unable to connect 1
> at
> com.cloud.agent.manager.AgentManagerImpl.notifyMonitorsOfConnection(AgentManagerImpl.java:606)
> at
> com.cloud.agent.manager.AgentManagerImpl.handleDirectConnectAgent(AgentManagerImpl.java:1482)
> at
> com.cloud.resource.ResourceManagerImpl.createHostAndAgentDeferred(ResourceManagerImpl.java:1872)
> at
> com.cloud.resource.ResourceManagerImpl.discoverHostsFull(ResourceManagerImpl.java:778)
> at
> com.cloud.resource.ResourceManagerImpl.discoverHosts(ResourceManagerImpl.java:590)
> at
> org.apache.cloudstack.api.command.admin.host.AddHostCmd.execute(AddHostCmd.java:143)
> at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:158)
> at com.cloud.api.ApiServer.queueCommand(ApiServer.java:514)
> at com.cloud.api.ApiServer.handleRequest(ApiServer.java:372)
> at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:305)
> at com.cloud.api.ApiServlet.doPost(ApiServlet.java:71)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:637)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
> at
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
> at
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
> at
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
> at
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
> at
> org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:555)
> at
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
> at
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:298)
> at
> org.apache.coyote.http11.Http11NioProcessor.process(Http11NioProcessor.java:889)
> at
> org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:721)
> at
> org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:2274)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1146)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:701)
> Caused by: java.lang.ClassCastException: com.cloud.agent.api.Answer cannot
> be cast to com.cloud.agent.api.SetupAnswer
> at
> com.cloud.hypervisor.xen.discoverer.XcpServerDiscoverer.processConnect(XcpServerDiscoverer.java:646)
> at
> com.cloud.agent.manager.AgentManagerImpl.notifyMonitorsOfConnection(AgentManagerImpl.java:587)
> ... 27 more
> 2014-02-12 23:25:03,450 DEBUG [cloud.host.Status] (catalina-exec-12:null)
> Transition:[Resource state = Enabled, Agent event = AgentDisconnected, Host
> id = 1, name = node1.domain.com]
> 2014-02-12 23:25:03,450 DEBUG [cloud.host.Status] (catalina-exec-12:null)
> Cannot transit agent status with event AgentDisconnected for host 1,
> name=node1.domain.com, mangement server id is 161344192609
> 2014-02-12 23:25:03,450 ERROR [cloud.api.ApiServer] (catalina-exec-12:null)
> unhandled exception executing api command: addHost
> com.cloud.utils.exception.CloudRuntimeException: Cannot transit agent status
> with event AgentDisconnected for host 1, mangement server id is
> 161344192609,Unable to transition to a new state from Creating via
> AgentDisconnected
>
>



-- 
Daan


Re: XEN | CentOS | Cloud 4.2 | Error Message - Agent Disconnected.

2014-02-13 Thread Mo
Cloudstack 4.2 (CentOS) , Xen Sever 6.2. Two servers.
On Feb 13, 2014 5:41 PM, "Daan Hoogland"  wrote:

> Maurice,
>
> what version are you running on what kind of environment?
>
> thanks,
> Daan
>
> On Thu, Feb 13, 2014 at 5:32 AM, Mo  wrote:
> > Hello,
> >
> > Can someone shed some light on this error message?
> >
> >  * Something went wrong; please correct the following:
> >Cannot transit agent status with event AgentDisconnected for host 1,
> >mangement server id is 161344192609,Unable to transition to a new
> >state from Creating via AgentDisconnected
> >
> >
> > =
> >
> >
> > 2014-02-12 23:25:03,365 DEBUG [agent.manager.AgentManagerImpl]
> > (catalina-exec-12:null) Sending Disconnect to listener:
> > com.cloud.consoleproxy.ConsoleProxyListener
> > 2014-02-12 23:25:03,366 DEBUG [cloud.host.Status] (catalina-exec-12:null)
> > Transition:[Resource state = Enabled, Agent event = AgentDisconnected,
> Host
> > id = 1, name = node1.domain.com]
> > 2014-02-12 23:25:03,447 DEBUG [cloud.host.Status] (catalina-exec-12:null)
> > Agent status update: [id = 1; name = node1.domain.com; old status =
> > Connecting; event = AgentDisconnected; new status = Alert; old update
> count
> > = 1; new update count = 2]
> > 2014-02-12 23:25:03,448 DEBUG [agent.manager.ClusteredAgentManagerImpl]
> > (catalina-exec-12:null) Notifying other nodes of to disconnect
> > 2014-02-12 23:25:03,449 WARN  [cloud.resource.ResourceManagerImpl]
> > (catalina-exec-12:null) Unable to connect due to
> > com.cloud.utils.exception.CloudRuntimeException: Unable to connect 1
> > at
> >
> com.cloud.agent.manager.AgentManagerImpl.notifyMonitorsOfConnection(AgentManagerImpl.java:606)
> > at
> >
> com.cloud.agent.manager.AgentManagerImpl.handleDirectConnectAgent(AgentManagerImpl.java:1482)
> > at
> >
> com.cloud.resource.ResourceManagerImpl.createHostAndAgentDeferred(ResourceManagerImpl.java:1872)
> > at
> >
> com.cloud.resource.ResourceManagerImpl.discoverHostsFull(ResourceManagerImpl.java:778)
> > at
> >
> com.cloud.resource.ResourceManagerImpl.discoverHosts(ResourceManagerImpl.java:590)
> > at
> >
> org.apache.cloudstack.api.command.admin.host.AddHostCmd.execute(AddHostCmd.java:143)
> > at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:158)
> > at com.cloud.api.ApiServer.queueCommand(ApiServer.java:514)
> > at com.cloud.api.ApiServer.handleRequest(ApiServer.java:372)
> > at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:305)
> > at com.cloud.api.ApiServlet.doPost(ApiServlet.java:71)
> > at javax.servlet.http.HttpServlet.service(HttpServlet.java:637)
> > at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
> > at
> >
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
> > at
> >
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
> > at
> >
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
> > at
> >
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
> > at
> >
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
> > at
> >
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
> > at
> > org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:555)
> > at
> >
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
> > at
> >
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:298)
> > at
> >
> org.apache.coyote.http11.Http11NioProcessor.process(Http11NioProcessor.java:889)
> > at
> >
> org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:721)
> > at
> >
> org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:2274)
> > at
> >
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1146)
> > at
> >
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> > at java.lang.Thread.run(Thread.java:701)
> > Caused by: java.lang.ClassCastException: com.cloud.agent.api.Answer
> cannot
> > be cast to com.cloud.agent.api.SetupAnswer
> > at
> >
> com.cloud.hypervisor.xen.discoverer.XcpServerDiscoverer.processConnect(XcpServerDiscoverer.java:646)
> > at
> >
> com.cloud.agent.manager.AgentManagerImpl.notifyMonitorsOfConnection(AgentManagerImpl.java:587)
> > ... 27 more
> > 2014-02-12 23:25:03,450 DEBUG [cloud.host.Status] (catalina-exec-12:null)
> > Transition:[Resource state = Enabled, Agent event = AgentDisconnected,
> Host
> > id = 1, name = node1.domain.com]
> > 2014-02-12 23:25:03,450 DEBUG [cloud.host.Status] (catalina-exec-12:null)
> > Cannot transit agent status with event AgentDisconnected for host 1,
> > name=node1.domain.com, mangement server id is 161344192609
> > 2014-02-12 23:25:03,450 ERROR [cloud

RE: [VOTE] Apache CloudStack 4.3.0 (fourth round) UPDATE

2014-02-13 Thread Animesh Chaturvedi


> > > 3. CLOUDSTACK-6065: KVM HA not working for shutdown VMs => While
> an
> > > issue but my understanding is it is a corner scenario only affecting
> > > KVM and can be released  as a known issue
> >
> > Well, it's effectively breaking HA as defined in the docs for a main
> > hv type and as it is I can't use 4.3 in production. Is there a fix in sight?
> >
> [Animesh]  Following up with Kelven if he can check on it
[Animesh] Nux Kelven fixed this particular issues in 4.3-forward branch. Can 
you test it out?


Re: Review Request 15633: Bugfix CS-5079: Add guard against null pointer exception for listConfigurations API call, and set value to NULL if the pointer is null

2014-02-13 Thread Amogh Vasekar
Thanks for closing it!

Amogh

From: Yichi Lu mailto:yichi...@sungard.com>>
Date: Thursday, February 13, 2014 11:22 AM
To: Amogh Vasekar mailto:amogh.vase...@citrix.com>>
Cc: cloudstack mailto:dev@cloudstack.apache.org>>
Subject: Re: Review Request 15633: Bugfix CS-5079: Add guard against null 
pointer exception for listConfigurations API call, and set value to NULL if the 
pointer is null

I discarded my review request, based on this:
Harikrishna Patnala commented on CLOUDSTACK-5079:
-

Hi Yichi Lu,
This was fixed on NOV 15th and the fix is to use the configDepot class to 
populate the scoped variables. This class was introduced as part of new 
configuration parameters framework added in 4.3.

Thanks,
Harikrishna

and this:
Srikanteswararao Talluri (JIRA)


Jan 31 (13 days ago)
[https://mail.google.com/mail/u/0/images/cleardot.gif]

[https://mail.google.com/mail/u/0/images/cleardot.gif]
[https://mail.google.com/mail/u/0/images/cleardot.gif]

to me
[https://mail.google.com/mail/u/0/images/cleardot.gif]


 [ 
https://issues.apache.org/jira/browse/CLOUDSTACK-5079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Srikanteswararao Talluri closed CLOUDSTACK-5079.


On Thu, Feb 13, 2014 at 12:33 PM, Amogh Vasekar 
mailto:amogh.vase...@citrix.com>> wrote:
This is an automatically generated e-mail. To reply, visit: 
https://reviews.apache.org/r/15633/


Reminder -
This review has been pending for long. Request the submitter to please add 
relevant reviewers or seek volunteers from the community.
Thanks!




- Amogh Vasekar


On November 17th, 2013, 10:29 p.m. UTC, Yichi Lu wrote:

Review request for cloudstack.
By Yichi Lu.

Updated Nov. 17, 2013, 10:29 p.m.

Bugs: 5079
Repository: cloudstack-git
Description

CLOUDSTACK-5079. When using api call, listConfigurations, and specifying 
clusterid, some keys may not have values. this causes a null pointer to be 
returned.
Add guard against null pointer in 
server/src/com/cloud/server/ConfigurationServerImpl.java::getConfigListByScope().
 If a null pointer is returned from 
framework/config/src/org/apache/cloudstack/framework/config/impl/ConfigDepotImpl.java::get(),
 set value to 'NULL'.


Testing

tested api calls for &listConfigurations, &listConfigurations&clusterid=xxx, 
&listConfigurations&zoneid=xxx,  &listConfigurations&category=Advanced


Diffs

  *   server/src/com/cloud/server/ConfigurationServerImpl.java (8459ada)

View Diff




RE: What does this UI thing do? "Root disk size"

2014-02-13 Thread Animesh Chaturvedi
Ok with the new RC this will get addressed

> -Original Message-
> From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com]
> Sent: Monday, February 10, 2014 10:38 AM
> To: dev@cloudstack.apache.org
> Subject: RE: What does this UI thing do? "Root disk size"
> 
> I have asked JessicaW to check on this issue
> 
> > -Original Message-
> > From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
> > Sent: Saturday, February 08, 2014 4:14 PM
> > To: dev@cloudstack.apache.org
> > Subject: Re: What does this UI thing do? "Root disk size"
> >
> > It does seem like a usability problem waiting to happen (having that
> > field in there, but it doesn't actually work in 4.3).
> >
> >
> > On Sat, Feb 8, 2014 at 6:30 AM, Nux!  wrote:
> >
> > > On 20.01.2014 23:11, Mike Tutkowski wrote:
> > >
> > >> So, is this GUI field going to be in 4.3, but not functional? If
> > >> so, that seems a little strange. Perhaps it should be removed.
> > >>
> > >
> > > BTW, guys, this thing still shows up in the UI. Should be removed,
> > > creates confusion and false hope. :-)
> > >
> > >
> > > --
> > > Sent from the Delta quadrant using Borg technology!
> > >
> > > Nux!
> > > www.nux.ro
> > >
> >
> >
> >
> > --
> > *Mike Tutkowski*
> > *Senior CloudStack Developer, SolidFire Inc.*
> > e: mike.tutkow...@solidfire.com
> > o: 303.746.7302
> > Advancing the way the world uses the
> > cloud
> > *(tm)*


RE: [VOTE] Apache CloudStack 4.3.0 (fourth round) UPDATE

2014-02-13 Thread Nux!

On 13.02.2014 23:01, Animesh Chaturvedi wrote:

3. CLOUDSTACK-6065: KVM HA not working for shutdown VMs => While

an
issue but my understanding is it is a corner scenario only 
affecting

KVM and can be released  as a known issue


Well, it's effectively breaking HA as defined in the docs for a main
hv type and as it is I can't use 4.3 in production. Is there a fix 
in sight?



[Animesh]  Following up with Kelven if he can check on it

[Animesh] Nux Kelven fixed this particular issues in 4.3-forward
branch. Can you test it out?


Wunderbar! I'll test it tomorrow.

Lucian

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro


Build failed in Jenkins: cloudstack-4.3-maven-build #477

2014-02-13 Thread jenkins
See 

--
[...truncated 97 lines...]
remote: Compressing objects:  72% (605/840)   
remote: Compressing objects:  73% (614/840)   
remote: Compressing objects:  74% (622/840)   
remote: Compressing objects:  75% (630/840)   
remote: Compressing objects:  76% (639/840)   
remote: Compressing objects:  77% (647/840)   
remote: Compressing objects:  78% (656/840)   
remote: Compressing objects:  79% (664/840)   
remote: Compressing objects:  80% (672/840)   
remote: Compressing objects:  81% (681/840)   
remote: Compressing objects:  82% (689/840)   
remote: Compressing objects:  83% (698/840)   
remote: Compressing objects:  84% (706/840)   
remote: Compressing objects:  85% (714/840)   
remote: Compressing objects:  86% (723/840)   
remote: Compressing objects:  87% (731/840)   
remote: Compressing objects:  88% (740/840)   
remote: Compressing objects:  89% (748/840)   
remote: Compressing objects:  90% (756/840)   
remote: Compressing objects:  91% (765/840)   
remote: Compressing objects:  92% (773/840)   
remote: Compressing objects:  93% (782/840)   
remote: Compressing objects:  94% (790/840)   
remote: Compressing objects:  95% (798/840)   
remote: Compressing objects:  96% (807/840)   
remote: Compressing objects:  97% (815/840)   
remote: Compressing objects:  98% (824/840)   
remote: Compressing objects:  99% (832/840)   
remote: Compressing objects: 100% (840/840)   
remote: Compressing objects: 100% (840/840), done.
Receiving objects:   0% (1/1387)   
Receiving objects:   1% (14/1387)   
Receiving objects:   2% (28/1387)   
Receiving objects:   3% (42/1387)   
Receiving objects:   4% (56/1387)   
Receiving objects:   5% (70/1387)   
Receiving objects:   6% (84/1387)   
Receiving objects:   7% (98/1387)   
Receiving objects:   8% (111/1387)   
Receiving objects:   9% (125/1387)   
Receiving objects:  10% (139/1387)   
Receiving objects:  11% (153/1387)   
Receiving objects:  12% (167/1387)   
Receiving objects:  13% (181/1387)   
Receiving objects:  14% (195/1387)   
Receiving objects:  15% (209/1387)   
Receiving objects:  16% (222/1387)   
Receiving objects:  17% (236/1387)   
Receiving objects:  18% (250/1387)   
Receiving objects:  19% (264/1387)   
Receiving objects:  20% (278/1387)   
Receiving objects:  21% (292/1387)   
Receiving objects:  22% (306/1387)   
Receiving objects:  23% (320/1387)   
Receiving objects:  24% (333/1387)   
Receiving objects:  25% (347/1387)   
Receiving objects:  26% (361/1387)   
Receiving objects:  27% (375/1387)   
Receiving objects:  28% (389/1387)   
Receiving objects:  29% (403/1387)   
Receiving objects:  30% (417/1387)   
Receiving objects:  31% (430/1387)   
Receiving objects:  32% (444/1387)   
Receiving objects:  33% (458/1387)   
Receiving objects:  34% (472/1387)   
Receiving objects:  35% (486/1387)   
Receiving objects:  36% (500/1387)   
Receiving objects:  37% (514/1387)   
Receiving objects:  38% (528/1387), 324.00 KiB | 637 KiB/s   
Receiving objects:  39% (541/1387), 324.00 KiB | 637 KiB/s   
Receiving objects:  40% (555/1387), 324.00 KiB | 637 KiB/s   
Receiving objects:  41% (569/1387), 324.00 KiB | 637 KiB/s   
Receiving objects:  42% (583/1387), 324.00 KiB | 637 KiB/s   
Receiving objects:  43% (597/1387), 324.00 KiB | 637 KiB/s   
Receiving objects:  44% (611/1387), 324.00 KiB | 637 KiB/s   
Receiving objects:  45% (625/1387), 324.00 KiB | 637 KiB/s   
Receiving objects:  46% (639/1387), 324.00 KiB | 637 KiB/s   
Receiving objects:  47% (652/1387), 324.00 KiB | 637 KiB/s   
Receiving objects:  48% (666/1387), 324.00 KiB | 637 KiB/s   
Receiving objects:  49% (680/1387), 324.00 KiB | 637 KiB/s   
Receiving objects:  50% (694/1387), 324.00 KiB | 637 KiB/s   
Receiving objects:  51% (708/1387), 324.00 KiB | 637 KiB/s   
Receiving objects:  52% (722/1387), 324.00 KiB | 637 KiB/s   
Receiving objects:  53% (736/1387), 324.00 KiB | 637 KiB/s   
Receiving objects:  54% (749/1387), 324.00 KiB | 637 KiB/s   
Receiving objects:  55% (763/1387), 324.00 KiB | 637 KiB/s   
Receiving objects:  56% (777/1387), 324.00 KiB | 637 KiB/s   
Receiving objects:  57% (791/1387), 324.00 KiB | 637 KiB/s   
Receiving objects:  58% (805/1387), 324.00 KiB | 637 KiB/s   
Receiving objects:  59% (819/1387), 324.00 KiB | 637 KiB/s   
Receiving objects:  60% (833/1387), 324.00 KiB | 637 KiB/s   
Receiving objects:  61% (847/1387), 324.00 KiB | 637 KiB/s   
Receiving objects:  62% (860/1387), 324.00 KiB | 637 KiB/s   
Receiving objects:  63% (874/1387), 324.00 KiB | 637 KiB/s   
Receiving objects:  64% (888/1387), 324.00 KiB | 637 KiB/s   
Receiving objects:  65% (902/1387), 324.00 KiB | 637 KiB/s   
Receiving objects:  66% (916/1387), 324.00 KiB | 637 KiB/s   
Receiving objects:  67% (930/1387), 324.00 KiB | 637 KiB/s   
Receiving objects:  68% (944/1387), 324.00 KiB | 637 KiB

RE: Exposing PCIe capabilities to the Cloud Scheduler

2014-02-13 Thread Edison Su


> -Original Message-
> From: Marcus [mailto:shadow...@gmail.com]
> Sent: Thursday, February 13, 2014 1:34 PM
> To: dev@cloudstack.apache.org
> Cc: ; malini.k.bhand...@intel.com; Dugger, Donald D;
> yunhong.ji...@intel.com; Meshkin, Omid; Manan Shah; Bob Ball; Hoban,
> Adrian
> Subject: Re: Exposing PCIe capabilities to the Cloud Scheduler
> 
> I think it's interesting, the PCI discovery that was mentioned, it would
> alleviate the manual agent.properties config that the patch requires.  I

Curious, if libvirt auto discover a bunch of pci devices on the host, should 
agent report all of them to user/admin? If not, based on what kind of criteria 
to filter pci devices? 

> imagine it will be available in the Ubuntu 14.04 release as well, assuming
> they're targeting current versions.
> 
> On Thu, Feb 13, 2014 at 1:21 PM, Edison Su  wrote:
> > Hi Ryousei,
> >  The patch sounds good to me, don’t know why it’s not got checked into
> 4.2 or 4.3. Is it ok for you to rebase to master? After that, I’ll check it 
> into
> master.
> >
> >
> > From: 高野了成 [mailto:takano-ryou...@aist.go.jp]
> > Sent: Thursday, February 13, 2014 4:08 AM
> > To: dev@cloudstack.apache.org
> > Cc: malini.k.bhand...@intel.com; Edison Su; Dugger, Donald D;
> > yunhong.ji...@intel.com; Meshkin, Omid; Manan Shah; Bob Ball; Hoban,
> > Adrian
> > Subject: RE: Exposing PCIe capabilities to the Cloud Scheduler
> >
> > Dear Edison Su and Malini Bhandaru,
> >
> > I am the mentor of Pawit, who has submitted PCI passthrough patch last
> year.
> > We have been developing this feature for operating our private cloud
> > based on CloudStack 4.2.1.
> > Now our users can deploy and migrate a VM instance with an InfiniBand
> interface.
> >
> > We hope to improve our patch and merge into CloudStack.
> > Your comments and suggestions are welcome.
> >
> > Best regards,
> > Ryousei
> >
> >> Welcome, my dear Intel friends:)
> >> Last year, community has contributed code regarding to add PCI
> passthrough into CloudStack, see the patch:
> https://reviews.apache.org/r/12098/, but unfortunately, this patch doesn't
> get checked in, due to lack of support from committer:
> http://markmail.org/message/ux2ojhxfqwdvz2uc.
> >> If you guys want to pick it up, either work from scratch, or based on the
> original patch, that will be great.
> >>
> >>> -Original Message-
> >>> From: Bhandaru, Malini K
> >>> [mailto:malini.k.bhand...@intel.com >>> om>]
> >>> Sent: Wednesday, February 12, 2014 12:48 PM
> >>> To: dev@cloudstack.apache.org
> >>> Cc: Dugger, Donald D; Jiang, Yunhong; Meshkin, Omid; Manan Shah; Bob
> >>> Ball; Hoban, Adrian
> >>> Subject: Exposing PCIe capabilities to the Cloud Scheduler
> >>>
> >>> Hello CloudStack-ers!
> >>>
> >>> PCIe (Peripheral Component Interconnect Express) devices exist for
> >>> graphics processing, storage, digital signal processing,
> >>> accelerating encryption/decryption, and more. Further, within a
> >>> function class, devices can exhibit different capability levels.
> >>> Exposing such platform hardware capabilities to the cloud scheduler
> >>> allows Virtual Machines (VMs) to explicitly request them for
> >>> improved performance and for the cloud vendor the opportunity to
> >>> offer services at different price points. facilitate differentiated 
> >>> revenur
> opportunities to the cloud vendor.
> >>>
> >>> CloudStack already exposes GPU
> >>>
> acceleration >>> GP
> >>> U+and+vGPU+support+for+CloudStack+Guest+Vms>. Along these lines
> >>> PCIe capabilities, including SR-IOV (Single Root IO virtualization)
> >>> can be exposed.
> >>> OpenStack has a set of blueprints for the same. The implementation
> >>> spans tracking the PCIe devices associated with a host, their use,
> >>> VM association, and requesting PCIe features. libvirt has been
> >>> modified to accommodate PCIe discovery. Intel and Mirantis contributed
> a lot of the code.
> >>> https://blueprints.launchpad.net/nova/+spec/epa-for-pcie-devices
> >>> https://blueprints.launchpad.net/nova/+spec/pci-passthrough-libvirt
> >>>
> >>> Should you have an interest in supporting such functionality and
> >>> have technical questions, please get in touch.
> >>>
> >>> Regards
> >>> Malini Bhandaru, Intel
> >


Build failed in Jenkins: cloudstack-4.3-maven-build #478

2014-02-13 Thread jenkins
See 

--
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on rpmbuilder in workspace 

Fetching changes from the remote Git repository
Fetching upstream changes from git://git.apache.org/cloudstack.git
FATAL: Failed to fetch from git://git.apache.org/cloudstack.git
hudson.plugins.git.GitException: Failed to fetch from 
git://git.apache.org/cloudstack.git
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:625)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:847)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:872)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1415)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:652)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:88)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:561)
at hudson.model.Run.execute(Run.java:1678)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:46)
at hudson.model.ResourceController.execute(ResourceController.java:88)
at hudson.model.Executor.run(Executor.java:231)
Caused by: hudson.plugins.git.GitException: Command "git fetch --tags 
--progress git://git.apache.org/cloudstack.git 
+refs/heads/*:refs/remotes/origin/*" returned status code 1:
stdout: 
stderr: error: Unable to append to .git/logs/refs/remotes/origin/4.3-forward: 
Permission denied
>From git://git.apache.org/cloudstack
 ! 713240b..40d069a  4.3-forward -> origin/4.3-forward  (unable to update local 
ref)
error: Unable to append to .git/logs/refs/remotes/origin/marvin: Permission 
denied
 ! df58f51..f3364ca  marvin -> origin/marvin  (unable to update local ref)

at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1086)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:968)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$200(CliGitAPIImpl.java:71)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:197)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:152)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:145)
at hudson.remoting.UserRequest.perform(UserRequest.java:118)
at hudson.remoting.UserRequest.perform(UserRequest.java:48)
at hudson.remoting.Request$2.run(Request.java:326)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at hudson.remoting.Engine$1$1.run(Engine.java:63)
at java.lang.Thread.run(Thread.java:744)


Build failed in Jenkins: cloudstack-4.3-maven-build #479

2014-02-13 Thread jenkins
See 

--
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on rpmbuilder in workspace 

Fetching changes from the remote Git repository
Fetching upstream changes from git://git.apache.org/cloudstack.git
FATAL: Failed to fetch from git://git.apache.org/cloudstack.git
hudson.plugins.git.GitException: Failed to fetch from 
git://git.apache.org/cloudstack.git
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:625)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:847)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:872)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1415)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:652)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:88)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:561)
at hudson.model.Run.execute(Run.java:1678)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:46)
at hudson.model.ResourceController.execute(ResourceController.java:88)
at hudson.model.Executor.run(Executor.java:231)
Caused by: hudson.plugins.git.GitException: Command "git fetch --tags 
--progress git://git.apache.org/cloudstack.git 
+refs/heads/*:refs/remotes/origin/*" returned status code 1:
stdout: 
stderr: error: Unable to append to .git/logs/refs/remotes/origin/4.3-forward: 
Permission denied
>From git://git.apache.org/cloudstack
 ! 713240b..40d069a  4.3-forward -> origin/4.3-forward  (unable to update local 
ref)
error: Unable to append to .git/logs/refs/remotes/origin/marvin: Permission 
denied
 ! df58f51..f3364ca  marvin -> origin/marvin  (unable to update local ref)

at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1086)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:968)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$200(CliGitAPIImpl.java:71)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:197)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:152)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:145)
at hudson.remoting.UserRequest.perform(UserRequest.java:118)
at hudson.remoting.UserRequest.perform(UserRequest.java:48)
at hudson.remoting.Request$2.run(Request.java:326)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at hudson.remoting.Engine$1$1.run(Engine.java:63)
at java.lang.Thread.run(Thread.java:744)


Build failed in Jenkins: cloudstack-4.3-maven-build #480

2014-02-13 Thread jenkins
See 

Changes:

[animesh] CLOUDSTACK-6068: set display flag to true in 
service/disk_offering_details tables

[animesh] CLOUDSTACK-6068: set display flag to true in 
service/disk_offering_details tables

[animesh] pass isSourceNat to second ip on the same network(cherry picked from 
commit 5af163ff7f658c30c6d93b50ac17c9cc0c5eb8c1)

[animesh] CLOUDSTACK-6089: Implement equals() method for ResourceTagResponse

[animesh] CLOUDSTACK-6089: Use resource tag's key to determine match in

[animesh] CLOUDSTACK-6083 corrected firewall rule cidr load issue

[animesh] CLOUDSTACK-6065: Fix NPE problem caused by the lack of context setup 
in threads from agent manager thread pool

--
[...truncated 918 lines...]
---
 T E S T S
---

Results :

Tests run: 0, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Server 4.3.0
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloud-server ---
[INFO] Deleting 

 (includes = [**/*], excludes = [])
[INFO] Deleting 
 
(includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ cloud-server 
---
[INFO] 
[INFO] --- maven-antrun-plugin:1.7:run (generate-resource) @ cloud-server ---
[INFO] Executing tasks

main:
 [copy] Copying 3 files to 

 [copy] Copying 1 file to 

[INFO] Executed tasks
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-server ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 30 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ cloud-server 
---
[INFO] Compiling 358 source files to 

[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-server ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 29 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-server ---
[INFO] Compiling 75 source files to 

[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ cloud-server ---
[INFO] Surefire report directory: 


---
 T E S T S
---
Running 
org.apache.cloudstack.region.gslb.GlobalLoadBalancingRulesServiceImplTest
log4j:WARN No appenders could be found for logger 
(org.apache.cloudstack.region.gslb.GlobalLoadBalancingRulesServiceImplTest).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more 
info.
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.307 sec
Running org.apache.cloudstack.region.RegionManagerTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.041 sec
Running org.apache.cloudstack.service.ServiceOfferingVOTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.038 sec
Running org.apache.cloudstack.affinity.AffinityApiUnitTest
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.844 sec
Running org.apache.cloudstack.privategw.AclOnPrivateGwTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.27 sec
Running org.apache.cloudstack.network.lb.CertServiceTest
Tests run: 15, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.155 sec
Running org.apache.cloudstack.network.lb.ApplicationLoadBalancerTest
Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.381 sec
Running org.apache.cloudstack.networkoffering.CreateNetworkOfferingTest
Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 9.174 sec
Running com.cloud.keystore.KeystoreTest
org.apache.cloudstack.api.response.UserVmResponse/null/{"id":"3","securitygroup":[],"nic":[],"tags":[],"affinitygroup":[]}
org.apache.cloudstack.api.response.AlertResponse/null/{"id":"100","des

Re: What does this UI thing do? "Root disk size"

2014-02-13 Thread Mike Tutkowski
Excellent :)


On Thu, Feb 13, 2014 at 4:42 PM, Animesh Chaturvedi <
animesh.chaturv...@citrix.com> wrote:

> Ok with the new RC this will get addressed
>
> > -Original Message-
> > From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com]
> > Sent: Monday, February 10, 2014 10:38 AM
> > To: dev@cloudstack.apache.org
> > Subject: RE: What does this UI thing do? "Root disk size"
> >
> > I have asked JessicaW to check on this issue
> >
> > > -Original Message-
> > > From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
> > > Sent: Saturday, February 08, 2014 4:14 PM
> > > To: dev@cloudstack.apache.org
> > > Subject: Re: What does this UI thing do? "Root disk size"
> > >
> > > It does seem like a usability problem waiting to happen (having that
> > > field in there, but it doesn't actually work in 4.3).
> > >
> > >
> > > On Sat, Feb 8, 2014 at 6:30 AM, Nux!  wrote:
> > >
> > > > On 20.01.2014 23:11, Mike Tutkowski wrote:
> > > >
> > > >> So, is this GUI field going to be in 4.3, but not functional? If
> > > >> so, that seems a little strange. Perhaps it should be removed.
> > > >>
> > > >
> > > > BTW, guys, this thing still shows up in the UI. Should be removed,
> > > > creates confusion and false hope. :-)
> > > >
> > > >
> > > > --
> > > > Sent from the Delta quadrant using Borg technology!
> > > >
> > > > Nux!
> > > > www.nux.ro
> > > >
> > >
> > >
> > >
> > > --
> > > *Mike Tutkowski*
> > > *Senior CloudStack Developer, SolidFire Inc.*
> > > e: mike.tutkow...@solidfire.com
> > > o: 303.746.7302
> > > Advancing the way the world uses the
> > > cloud
> > > *(tm)*
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*(tm)*


RE: Build failed in Jenkins: cloudstack-4.3-maven-build #480

2014-02-13 Thread Animesh Chaturvedi
Folks 

I need help with in fixing this test  failure. I did not run into it in my 
local setup. Can someone familiar with that code check on this?


---
Test set: com.cloud.vpc.NetworkACLServiceTest
---
Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.12 sec <<< 
FAILURE!
testDeleteACLItem(com.cloud.vpc.NetworkACLServiceTest)  Time elapsed: 0.109 sec 
 <<< ERROR!
java.lang.NullPointerException
at 
com.cloud.network.vpc.NetworkACLServiceImpl.revokeNetworkACLItem(NetworkACLServiceImpl.java:596)
at 
com.cloud.vpc.NetworkACLServiceTest.testDeleteACLItem(NetworkACLServiceTest.java:181)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)

Thanks
Animesh

> -Original Message-
> From: jenk...@cloudstack.org [mailto:jenk...@cloudstack.org]
> Sent: Thursday, February 13, 2014 5:31 PM
> To: dev@cloudstack.apache.org
> Subject: Build failed in Jenkins: cloudstack-4.3-maven-build #480
> 
> See  build/480/changes>
> 
> Changes:
> 
> [animesh] CLOUDSTACK-6068: set display flag to true in
> service/disk_offering_details tables
> 
> [animesh] CLOUDSTACK-6068: set display flag to true in
> service/disk_offering_details tables
> 
> [animesh] pass isSourceNat to second ip on the same network(cherry picked
> from commit 5af163ff7f658c30c6d93b50ac17c9cc0c5eb8c1)
> 
> [animesh] CLOUDSTACK-6089: Implement equals() method for
> ResourceTagResponse
> 
> [animesh] CLOUDSTACK-6089: Use resource tag's key to determine match in
> 
> [animesh] CLOUDSTACK-6083 corrected firewall rule cidr load issue
> 
> [animesh] CLOUDSTACK-6065: Fix NPE problem caused by the lack of context
> setup in threads from agent manager thread pool
> 
> --
> [...truncated 918 lines...]
> ---
>  T E S T S
> ---
> 
> Results :
> 
> Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
> 
> [INFO]
> [INFO] 
> 
> [INFO] Building Apache CloudStack Server 4.3.0 [INFO] 
> 
> 
> [INFO]
> [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloud-server ---
> [INFO] Deleting  build/ws/server/target> (includes = [**/*], excludes = []) [INFO] Deleting
> 
> (includes = [target, dist], excludes = []) [INFO] [INFO] --- maven-remote-
> resources-plugin:1.3:process (default) @ cloud-server --- [INFO] [INFO] ---
> maven-antrun-plugin:1.7:run (generate-resource) @ cloud-server --- [INFO]
> Executing tasks
> 
> main:
>  [copy] Copying 3 files to  4.3-maven-build/ws/server/target/conf>
>  [copy] Copying 1 file to  4.3-maven-build/ws/server/target/conf>
> [INFO] Executed tasks
> [INFO]
> [INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ cloud-
> server --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to
> copy filtered resources.
> [INFO] Copying 30 resources
> [INFO] Copying 3 resources
> [INFO]
> [INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ cloud-
> server --- [INFO] Compiling 358 source files to
>  build/ws/server/target/classes>
> [INFO]
> [INFO] --- maven-resources-plugin:2.5:testResources (default-testResources)
> @ cloud-server --- [debug] execute contextualize [INFO] Using 'UTF-8'
> encoding to copy filtered resources.
> [INFO] Copying 29 resources
> [INFO] Copying 3 resources
> [INFO]
> [INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @
> cloud-server --- [INFO] Compiling 75 source files to
>  build/ws/server/target/test-classes>
> [INFO]
> [INFO] --- maven-surefire-plugin:2.12:test (default-test) @ cloud-server ---
> [INFO] Surefire report directory:
>  build/ws/server/target/surefire-reports>
> 
> ---
>  T E S T S
> ---
> Running
> org.apache.cloudstack.region.gslb.GlobalLoadBalancingRulesServiceImplTest
> log4j:WARN No appenders could be found for logger
> (org.apache.cloudstack.region.gslb.GlobalLoadBalancingRulesServiceImplTest
> ).
> log4j:WARN Please initialize the log4j system properly.
> log4j:WARN See http://logging.apache.org/log4j/1.2/

Build failed in Jenkins: cloudstack-4.3-maven-build #481

2014-02-13 Thread jenkins
See 

--
[...truncated 96 lines...]
remote: Compressing objects:  68% (349/512)   
remote: Compressing objects:  69% (354/512)   
remote: Compressing objects:  70% (359/512)   
remote: Compressing objects:  71% (364/512)   
remote: Compressing objects:  72% (369/512)   
remote: Compressing objects:  73% (374/512)   
remote: Compressing objects:  74% (379/512)   
remote: Compressing objects:  75% (384/512)   
remote: Compressing objects:  75% (385/512)   
remote: Compressing objects:  76% (390/512)   
remote: Compressing objects:  77% (395/512)   
remote: Compressing objects:  78% (400/512)   
remote: Compressing objects:  79% (405/512)   
remote: Compressing objects:  80% (410/512)   
remote: Compressing objects:  81% (415/512)   
remote: Compressing objects:  82% (420/512)   
remote: Compressing objects:  83% (425/512)   
remote: Compressing objects:  84% (431/512)   
remote: Compressing objects:  85% (436/512)   
remote: Compressing objects:  86% (441/512)   
remote: Compressing objects:  87% (446/512)   
remote: Compressing objects:  88% (451/512)   
remote: Compressing objects:  89% (456/512)   
remote: Compressing objects:  90% (461/512)   
remote: Compressing objects:  91% (466/512)   
remote: Compressing objects:  91% (468/512)   
remote: Compressing objects:  92% (472/512)   
remote: Compressing objects:  93% (477/512)   
remote: Compressing objects:  94% (482/512)   
remote: Compressing objects:  95% (487/512)   
remote: Compressing objects:  96% (492/512)   
remote: Compressing objects:  97% (497/512)   
remote: Compressing objects:  98% (502/512)   
remote: Compressing objects:  99% (507/512)   
remote: Compressing objects: 100% (512/512)   
remote: Compressing objects: 100% (512/512), done.
Receiving objects:   0% (1/871)   
Receiving objects:   1% (9/871)   
Receiving objects:   2% (18/871)   
Receiving objects:   3% (27/871)   
Receiving objects:   4% (35/871)   
Receiving objects:   5% (44/871)   
Receiving objects:   6% (53/871)   
Receiving objects:   7% (61/871)   
Receiving objects:   8% (70/871)   
Receiving objects:   9% (79/871)   
Receiving objects:  10% (88/871)   
Receiving objects:  11% (96/871)   
Receiving objects:  12% (105/871)   
Receiving objects:  13% (114/871)   
Receiving objects:  14% (122/871)   
Receiving objects:  15% (131/871)   
Receiving objects:  16% (140/871)   
Receiving objects:  17% (149/871)   
Receiving objects:  18% (157/871)   
Receiving objects:  19% (166/871)   
Receiving objects:  20% (175/871)   
Receiving objects:  21% (183/871)   
Receiving objects:  22% (192/871)   
Receiving objects:  23% (201/871)   
Receiving objects:  24% (210/871)   
Receiving objects:  25% (218/871)   
Receiving objects:  26% (227/871)   
Receiving objects:  27% (236/871)   
Receiving objects:  28% (244/871)   
Receiving objects:  29% (253/871)   
Receiving objects:  30% (262/871)   
Receiving objects:  31% (271/871)   
Receiving objects:  32% (279/871)   
Receiving objects:  33% (288/871)   
Receiving objects:  34% (297/871)   
Receiving objects:  35% (305/871)   
Receiving objects:  36% (314/871)   
Receiving objects:  37% (323/871)   
Receiving objects:  38% (331/871)   
Receiving objects:  39% (340/871)   
Receiving objects:  40% (349/871)   
Receiving objects:  41% (358/871)   
Receiving objects:  42% (366/871)   
Receiving objects:  43% (375/871)   
Receiving objects:  44% (384/871)   
Receiving objects:  45% (392/871)   
Receiving objects:  46% (401/871)   
Receiving objects:  47% (410/871)   
Receiving objects:  48% (419/871)   
Receiving objects:  49% (427/871)   
Receiving objects:  50% (436/871)   
Receiving objects:  51% (445/871)   
Receiving objects:  52% (453/871)   
Receiving objects:  53% (462/871)   
Receiving objects:  54% (471/871)   
Receiving objects:  55% (480/871)   
Receiving objects:  56% (488/871)   
Receiving objects:  57% (497/871)   
Receiving objects:  58% (506/871)   
Receiving objects:  59% (514/871)   
Receiving objects:  60% (523/871)   
Receiving objects:  61% (532/871)   
Receiving objects:  62% (541/871)   
Receiving objects:  63% (549/871)   
Receiving objects:  64% (558/871)   
Receiving objects:  65% (567/871)   
Receiving objects:  66% (575/871)   
Receiving objects:  67% (584/871)   
Receiving objects:  68% (593/871)   
Receiving objects:  69% (601/871)   
Receiving objects:  70% (610/871)   
Receiving objects:  71% (619/871)   
Receiving objects:  72% (628/871)   
Receiving objects:  73% (636/871)   
Receiving objects:  74% (645/871)   
Receiving objects:  75% (654/871)   
Receiving objects:  76% (662/871), 340.00 KiB | 502 KiB/s   
Receiving objects:  77% (671/871), 340.00 KiB | 502 KiB/s   
Receiving objects:  78% (680/871), 340.00 KiB | 502 KiB/s   
Receiving objects:  79% (689/871), 340.00 KiB | 502 KiB/s   
Receiving

Re: UI Latency

2014-02-13 Thread Rajani Karuturi
I agree with John. We should enable gzip compression on tomcat/apache and let 
it handle.
What we should be doing in the application is minification of CSS/JS and trying 
to reduce the number of static files/static get requests..

Thanks,
~Rajani



On 14-Feb-2014, at 2:50 am, John Kinsella 
mailto:j...@stratosec.co>> wrote:

Seems a bit like wheel-reinventing, no? Wouldn’t it be cleaner to get Tomcat’s 
built-in compression[1] working? What I don’t see in your code is any ability 
to negotiate if the end-client supports gzip compression...

John
1:http://viralpatel.net/blogs/enable-gzip-compression-in-tomcat/

On Feb 13, 2014, at 12:09 PM, Laszlo Hornyak 
mailto:laszlo.horn...@gmail.com>>
 wrote:

Ah yes we are playing space-wars, I will fix it as soon as I get there. I
was not that much interested in space/tabs but what it already does:
- at build time it generates .gz files from static resources, like css,
html and js files
- during runtime it checks if there is a gz file for the resource and
silently serves the gz file and sets the headers, only if the client
browser accepts gz of course
- respects Etag since you do not want to download even "just" 500 Kb each
time you hit ctrl-r.

TODO other than the space-war:
- it uses a maven plugin I have built for home use, it is in my maven repo
and it would not be great to give my unreliable repository to everyone, so
it should be either moved to the ACS source or uploaded to the central repo
- Some a would not like to make the build even longer. It is quite short
compared to the full time of the build, but for a CI build it is completely
useless. So it must be moved to a profile and profile should be active
during release process, maybe not anyway unless you manually enable it.




On Thu, Feb 13, 2014 at 7:23 PM, John Kinsella 
mailto:j...@stratosec.co>> wrote:

Looks like Daan had a few issues with the patch for you to resolve
regarding tabs and headers...

On Feb 13, 2014, at 10:14 AM, Laszlo Hornyak 
mailto:laszlo.horn...@gmail.com>
> wrote:

Hi,

I have a patch for the UI compression, it is on review for a while...
But I hope I will be able to resolve the comments in...days.

I measured the download size dropped from 3.5 MB to somewhere around 0.5 MB

https://reviews.apache.org/r/12228/

Adding javascript compression could also help a lot.

That 3.5 M is a lot even on LAN :-)



On Thu, Feb 13, 2014 at 7:04 PM, John Kinsella  wrote:

Just posted
http://theresnomon.co/2014/improving-cloudstack-ui-performance/ - open to
any comments.

John

On Feb 10, 2014, at 12:47 AM, Alex Hitchins mailto:alex.hitch...@shapeblue.com>> wrote:

Sounds interesting, I look forward to your write-up.



Regards

Alex Hitchins

D: +44 1892 523 587 | S: +44 20 3603 0540 | M: +44 7788 423 969

alex.hitch...@shapeblue.com

-Original Message-
From: John Kinsella [mailto:j...@stratosec.co]
Sent: 10 February 2014 01:05
To: 
Subject: Re: UI Latency

I've been tinkering with httpd proxying the UI via mod_proxy_ajp, then
using mod_deflate to compress on the httpd side. That gets me about a 2.5x
decrease in loading the login screen. system.js, which is the largest item
downloaded by default is around 980k, with gzip that drops to 68k.

I wanna see if I can squeeze a little more performance out by caching the
static stuff...once I get some stats out of that I'll turn it into a blog
post later this week.

John

On Feb 9, 2014, at 3:27 PM, Alex Hitchins 
wrote:

One of the things that I want to look in to is generating a Gruntfile so
we can 'uglify' and reduce the size of css, js and image sprites. This
should help reduce the initial payload and make a big difference to VPN/low
b/w connections.


Regards

Alex Hitchins

D: +44 1892 523 587 | S: +44 20 3603 0540 | M: +44 7788 423 969

alex.hitch...@shapeblue.com

-Original Message-
From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
Sent: 09 February 2014 19:51
To: dev@cloudstack.apache.org
Subject: Re: UI Latency

I could be wrong, but I believe the idea of zipping the content for the UI
start page was discussed, but has not yet been implemented.

As far as I know (and have experienced), every time you go to the start
page, it does seem to take a while to load if you are not over a
particularly fast connection (if I'm in the office, it loads quickly; if
I'm over a VPN connection from, say, home, it tends to be noticeably
slower).


On Sun, Feb 9, 2014 at 8:46 AM, Mo  wrote:

Hello,

>From my understanding going to the UI at first start-up takes awhile
to load due to the way it is configured, I believe I was previously
told it was gzip for the website. However, I thought this would a one
time thing; it seems to take quite awhile to load UI each time I
visit, unlike versions gone by.

Any advice? Suggestions?

- Maurice




--
*Mike Tutkowski*
*Senior CloudStack 

  1   2   >