----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18068/ -----------------------------------------------------------
Review request for cloudstack, daan Hoogland and Hugo Trippaers. Repository: cloudstack-git Description ------- Adding fixes and unit tests for cloud-engine-api scariest bugs found by FindBugs Diffs ----- engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/type/VolumeTypeBase.java 78ac8e2 engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/type/VolumeTypeHelper.java 5057203 engine/api/test/org/apache/cloudstack/engine/subsystem/api/storage/type/VolumeTypeHelperTest.java PRE-CREATION Diff: https://reviews.apache.org/r/18068/diff/ Testing ------- Build successful + 8 unit tests added to cover the changes Thanks, Wilder Rodrigues
