----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17872/#review34397 -----------------------------------------------------------
Ship it! Ship It! - Alena Prokharchyk On Feb. 8, 2014, 2:49 p.m., daan Hoogland wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17872/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2014, 2:49 p.m.) > > > Review request for cloudstack and Alena Prokharchyk. > > > Repository: cloudstack-git > > > Description > ------- > > remove nic in network with dhcp plus tests to make sure it is not called for > domainrouter or when dhcp not supported > > > Diffs > ----- > > > engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java > ce40762 > > engine/orchestration/test/org/apache/cloudstack/engine/orchestration/NetworkOrchestratorTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/17872/diff/ > > > Testing > ------- > > unit tests added. no extensive integration testing done. > > > Thanks, > > daan Hoogland > >
