----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15633/#review34390 -----------------------------------------------------------
Reminder - This review has been pending for long. Request the submitter to please add relevant reviewers or seek volunteers from the community. Thanks! - Amogh Vasekar On Nov. 17, 2013, 10:29 p.m., Yichi Lu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15633/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2013, 10:29 p.m.) > > > Review request for cloudstack. > > > Bugs: 5079 > https://issues.apache.org/jira/browse/5079 > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-5079. When using api call, listConfigurations, and specifying > clusterid, some keys may not have values. this causes a null pointer to be > returned. > Add guard against null pointer in > server/src/com/cloud/server/ConfigurationServerImpl.java::getConfigListByScope(). > If a null pointer is returned from > framework/config/src/org/apache/cloudstack/framework/config/impl/ConfigDepotImpl.java::get(), > set value to 'NULL'. > > > Diffs > ----- > > server/src/com/cloud/server/ConfigurationServerImpl.java 8459ada > > Diff: https://reviews.apache.org/r/15633/diff/ > > > Testing > ------- > > tested api calls for &listConfigurations, &listConfigurations&clusterid=xxx, > &listConfigurations&zoneid=xxx, &listConfigurations&category=Advanced > > > Thanks, > > Yichi Lu > >
