----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18066/ -----------------------------------------------------------
Review request for cloudstack, daan Hoogland and Hugo Trippaers. Repository: cloudstack-git Description ------- Fixing troubling issues on contrail plugin related to dereference nullpoint; adding unit tests to cover changes on the compare method on the VirtualNetworkModel Diffs ----- plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java b25de48 plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObject.java 1b048ed plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java 0ce22ad plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java 4d0218c plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java b0505b1 plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/model/VirtualMachineModelTest.java f85beb6 plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/model/VirtualNetworkModelTest.java b1b5ae1 Diff: https://reviews.apache.org/r/18066/diff/ Testing ------- Build successful + 3 unit tests added in order to cover compare methods cases. Thanks, Wilder Rodrigues
