On Thu, Apr 18, 2019 at 04:06:31PM +0200, David Marchand wrote:
> Hey Adrien,
Hey David!
> On Thu, Apr 18, 2019 at 3:12 PM Adrien Mazarguil
> wrote:
>
> > When passed to the application, Rx packets retain the port ID value
> > originally set by slave devices. Unfortunately these IDs have no mea
On 4/19/2019 12:37 AM, Stephen Hemminger wrote:
> This driver defines lots of functions (like init_rss) which are intended
> to only be used in this device. But when doing static linking these
> global functions cause link failures when similar function name is
> used in application.
>
> This patc
There are some variables declared in the middle of the function,
and one (i) is declared twice with two different types.
Tomasz and Tomasz, are you working on it urgently please?
19/04/2019 00:42, Yongseok Koh:
> Hi,
>
> I'm seeing compile error.
> Isn't it due to this patch?
>
> $ gcc --versi
On Fri, Apr 19, 2019 at 11:08 AM Thomas Monjalon
wrote:
> There are some variables declared in the middle of the function,
> and one (i) is declared twice with two different types.
>
> Tomasz and Tomasz, are you working on it urgently please?
>
Found out that this test is not built by default.
I
Fixes: 04868e5bfddd ("net/cxgbe: add support to run Chelsio T6 cards")
Cc: sta...@dpdk.org
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/base/t4_pci_id_tbl.h | 52 +-
1 file changed, 51 insertions(+), 1 deletion(-)
diff --git a/drivers/net/cxgbe/base/t4_pci_id_tb
19/04/2019 11:25, David Marchand:
> On Fri, Apr 19, 2019 at 11:08 AM Thomas Monjalon
> wrote:
>
> > There are some variables declared in the middle of the function,
> > and one (i) is declared twice with two different types.
> >
> > Tomasz and Tomasz, are you working on it urgently please?
> >
>
On 4/19/2019 10:22 AM, Rahul Lakkireddy wrote:
> Fixes: 04868e5bfddd ("net/cxgbe: add support to run Chelsio T6 cards")
Why this is a fix, isn't this just adding new device ids?
> Cc: sta...@dpdk.org
What about keeping 'stable' tag to request the backport but remove the fix?
>
> Signed-off-by
Hi all,
I'm preparing the patch and will send it in 10 minutes
Thx, Tomek
> -Original Message-
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Friday, April 19, 2019 11:30 AM
> To: David Marchand
> Cc: Cel, TomaszX ; Jozwiak, TomaszX
> ; Yongseok Koh ;
> dev@dpdk.org; Trahe
On Fri, Apr 19, 2019 at 11:32 AM Jozwiak, TomaszX
wrote:
> Hi all,
>
> I'm preparing the patch and will send it in 10 minutes
>
Ok, dropping mine.
--
David Marchand
On 9/4/2019 10:54 AM, Lukasz Krakowiak wrote:
Removed dependency to mac_list from policies:
* BRANCH_RATIO,
* WORKLOAD,
* TIME
in function update_policy.
Fixes: 1b897991473f ("power: update error handling")
Signed-off-by: Lukasz Krakowiak
---
examples/vm_power_manager/channel_monitor.c | 1
On 4/18/2019 11:57 PM, Chas Williams wrote:
>
>
> On 4/18/19 2:41 PM, Ferruh Yigit wrote:
>> On 4/17/2019 3:36 PM, Radu Nicolau wrote:
>>> Add validation to pointer constructed from the IPv4 header length
>>> in order to prevent malformed packets from generating a potential
>>> out of bounds memo
On Thu, Apr 18, 2019 at 5:27 PM Xiaolong Ye wrote:
> Naming the buf_ring dynamically allows to create multiple af_xdp vdevs.
>
> Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD")
>
> Reported-by: Markus Theil
> Signed-off-by: Xiaolong Ye
> ---
> drivers/net/af_xdp/rte_eth_af_xdp.c | 9 +
On Thu, Apr 18, 2019 at 5:27 PM Xiaolong Ye wrote:
> Naming the umem memzone dynamically allows to create multiple af_xdp vdevs.
>
> Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD")
>
> Reported-by: Markus Theil
> Signed-off-by: Xiaolong Ye
> ---
> drivers/net/af_xdp/rte_eth_af_xdp.c |
Hi Ferruh,
On Friday, April 04/19/19, 2019 at 15:00:32 +0530, Ferruh Yigit wrote:
> On 4/19/2019 10:22 AM, Rahul Lakkireddy wrote:
> > Fixes: 04868e5bfddd ("net/cxgbe: add support to run Chelsio T6 cards")
>
> Why this is a fix, isn't this just adding new device ids?
>
>
> > Cc: sta...@dpdk.org
Fixed the compilation error on gcc (GCC)
4.8.5 20150623 (Red Hat 4.8.5-28)
Fixes: 355b02eedc65 ("test/compress: add max mbuf size test case")
Cc: sta...@dpdk.org
Signed-off-by: Tomasz Jozwiak
---
app/test/test_compressdev.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git
Hi Yongseok,
Could you check my fix is ok now on gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28)
Thx, Tomek
> -Original Message-
> From: Yongseok Koh [mailto:ys...@mellanox.com]
> Sent: Friday, April 19, 2019 12:43 AM
> To: Cel, TomaszX ; Thomas Monjalon
> ; Jozwiak, TomaszX
> Cc: dev@dpdk.
The version check for the IPSec_MB library present in the aesni_gcm
library's meson.build file is a little cleaner than that given here,
so update this one so that both work identically.
While one could use the checks done in the other right now, potentially in
future they may have different versi
The aesni_mb driver and the aesni_gcm driver both require the same version
of the IPSec_MB library, but only the former has a check of the library
found to see if it's the correct version. Add a similar check to the
aesni_gcm library's meson.build file, so that the auto-detection of
dependencies wo
On Fri, Apr 19, 2019 at 11:57:07AM +0200, Tomasz Jozwiak wrote:
> Fixed the compilation error on gcc (GCC)
> 4.8.5 20150623 (Red Hat 4.8.5-28)
>
> Fixes: 355b02eedc65 ("test/compress: add max mbuf size test case")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Tomasz Jozwiak
> ---
> app/test/test_com
On Friday, April 04/19/19, 2019 at 05:07:02 +0530, Stephen Hemminger wrote:
> This driver defines lots of functions (like init_rss) which are intended
> to only be used in this device. But when doing static linking these
> global functions cause link failures when similar function name is
> used in
On Friday, April 04/19/19, 2019 at 13:45:12 +0530, Ferruh Yigit wrote:
> On 4/19/2019 12:37 AM, Stephen Hemminger wrote:
> > This driver defines lots of functions (like init_rss) which are intended
> > to only be used in this device. But when doing static linking these
> > global functions cause li
On 4/18/2019 9:59 PM, Eduard Serra Miralles wrote:
> From: Eduard Serra
>
> This patch introduces:
> - VMxnet3 v4 negotiation and,
> - entirely guest-driven UDP RSS support.
>
> VMxnet3 v3 already has UDP RSS support, however it
> depends on hypervisor provisioning on the VM through
> ESX specif
Please check my comments below:
19/04/2019 11:57, Tomasz Jozwiak:
> Fixed the compilation error on gcc (GCC)
> 4.8.5 20150623 (Red Hat 4.8.5-28)
It is seen with more compilers:
https://build.opensuse.org/project/show/home:bluca:dpdk
Please add the log of the error.
> Fixes: 355b02eedc65 ("test/
09/04/2019 19:59, Rami Rosen:
> On Mon, Apr 08, 2019 at 03:22:26PM +0100, Ferruh Yigit wrote:
> > Build error seen with Linux kernel 5.1 and
> > when CONFIG_RTE_KNI_KMOD_ETHTOOL is enabled.
> >
> > Build error:
> > .../dpdk/build/build/kernel/linux/kni/igb_main.c:2352:18:
> > error: initializatio
A sucessfull call to rte_mp_request_sync does not guarantee that there
are any messages in the buffer, and this should be checked for before
accessing data in the message. Buffer can be empty if IPC is disabled or
if we deciede to ignore replies.
Fixes: c9aa56edec8e ("net/tap: access primary proce
12/04/2019 16:52, Ferruh Yigit:
> On 4/10/2019 11:30 AM, Igor Ryzhov wrote:
> > It allows applications running packet sockets over KNI interfaces to get
> > source Ethernet addresses of packets received using recvfrom function.
> >
> > Signed-off-by: Igor Ryzhov
>
> Acked-by: Ferruh Yigit
Appl
Hi,
16/04/2019 06:55, kirankum...@marvell.com:
> From: Kiran Kumar K
>
> With current KNI implementation kernel module will work only in
> IOVA=PA mode. This patch will add support for kernel module to work
> with IOVA=VA mode.
>
> The idea is to get the physical address from iova address using
On Fri, Apr 19, 2019 at 11:57 AM Tomasz Jozwiak
wrote:
> Fixed the compilation error on gcc (GCC)
> 4.8.5 20150623 (Red Hat 4.8.5-28)
>
> Fixes: 355b02eedc65 ("test/compress: add max mbuf size test case")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Tomasz Jozwiak
> ---
> app/test/test_compressdev.
> -Original Message-
> From: Carrillo, Erik G
> Sent: Friday, April 19, 2019 3:17 AM
> To: Jerin Jacob Kollanukkaran ; dev@dpdk.org; Thomas
> Monjalon ; Mattias Rönnblom
> ; Van Haaren, Harry
> ; Gujjar, Abhinandan S
> ; Rao, Nikhil
> Cc: Pavan Nikhilesh Bhagavatula ;
> hemant.agra...@nxp
On 4/19/2019 10:49 AM, Rahul Lakkireddy wrote:
> Hi Ferruh,
>
> On Friday, April 04/19/19, 2019 at 15:00:32 +0530, Ferruh Yigit wrote:
>> On 4/19/2019 10:22 AM, Rahul Lakkireddy wrote:
>>> Fixes: 04868e5bfddd ("net/cxgbe: add support to run Chelsio T6 cards")
>>
>> Why this is a fix, isn't this ju
19/04/2019 12:57, Jozwiak, TomaszX:
> > What is supposed to be "i"?
> > It is initialized at 0 and never touched.
> >
> It's touched inside test_deflate_comp_decomp function.
What do you mean?
It's a local variable and its address is referenced:
int_data.buf_idx = &i;
It looks really wrong
test_deflate_comp_decomp function is common for all test cases.
The options for this function are inside struct interim_data_params,
which is passed to test_deflate_comp_decomp function as a pointer.
The field buf_idx should be initialized because is used inside
test_deflate_comp_decomp
That's t
On 4/19/2019 11:04 AM, Rahul Lakkireddy wrote:
> On Friday, April 04/19/19, 2019 at 05:07:02 +0530, Stephen Hemminger wrote:
>> This driver defines lots of functions (like init_rss) which are intended
>> to only be used in this device. But when doing static linking these
>> global functions cause l
From: Stephen Hemminger
This driver defines lots of functions (like init_rss) which are intended
to only be used in this device. But when doing static linking these
global functions cause link failures when similar function name is
used in application.
This patch prefixes all functions defined i
Fixed the compilation error:
../app/test/test_compressdev.c:1949:11: note: previous
definition of 'i' was here
../app/test/test_compressdev.c:1992:2: error: 'for' loop
initial declarations are only allowed in C99 mode
../app/test/test_compressdev.c:1992:2: note: use option
-std=c99 or -std=gnu99
Please stop top-posting, and read again below:
19/04/2019 13:36, Jozwiak, TomaszX:
> test_deflate_comp_decomp function is common for all test cases.
> The options for this function are inside struct interim_data_params,
> which is passed to test_deflate_comp_decomp function as a pointer.
>
> The
Build of test_compressdev.c fails on FreeBSD due to the missing
include of unistd.h, to provide the function usleep.
Fixes: b06aa643cac4 ("test/compress: add initial unit tests")
Cc: pablo.de.lara.gua...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Bruce Richardson
---
I sent this previously, bu
The pipefail option is not supported in /bin/sh, just in bash/ksh and
similar shells - which means it's there by default on most Linux distros
but not on e.g. FreeBSD. Therefore we check for it's presence before
setting the option, and if it's missing, we upgrade verbosity level if
needed to ensure
On Friday, April 04/19/19, 2019 at 17:14:25 +0530, Ferruh Yigit wrote:
> From: Stephen Hemminger
>
> This driver defines lots of functions (like init_rss) which are intended
> to only be used in this device. But when doing static linking these
> global functions cause link failures when similar f
nit: "test/compress:" for the title prefix ?
On Fri, Apr 19, 2019 at 2:03 PM Bruce Richardson
wrote:
> Build of test_compressdev.c fails on FreeBSD due to the missing
> include of unistd.h, to provide the function usleep.
>
> Fixes: b06aa643cac4 ("test/compress: add initial unit tests")
> Cc: pa
From: Jerin Jacob
Promote the adapter functions and rte_event_port_unlinks_in_progress()
as stable as it's been added for a while now and multiple drivers and
test application like test-eventdev has been tested using the adapter APIs.
Cc: nikhil@intel.com
Cc: erik.g.carri...@intel.com
Cc: ab
On Fri, Apr 19, 2019 at 02:09:51PM +0200, David Marchand wrote:
>nit: "test/compress:" for the title prefix ?
maybe so, half the time I never know what to prefix autotest stuff like
this with! :-) Thomas, please fix on apply, if possible.
>On Fri, Apr 19, 2019 at 2:03 PM Bruce Richardson
> Moreover I don't know how the pointer of a local variable can be used.
That usage is in all test cases in this file - so probably should be fixed
first.
May be I'm not an expert but what's wrong with usage of a pointer of local
variable inside the function?
> -Original Message-
> Fr
On Friday, April 04/19/19, 2019 at 16:48:55 +0530, Ferruh Yigit wrote:
> On 4/19/2019 10:49 AM, Rahul Lakkireddy wrote:
> > Hi Ferruh,
> >
> > On Friday, April 04/19/19, 2019 at 15:00:32 +0530, Ferruh Yigit wrote:
> >> On 4/19/2019 10:22 AM, Rahul Lakkireddy wrote:
> >>> Fixes: 04868e5bfddd ("net/
On 4/10/2019 7:20 AM, Jie Pan wrote:
> The type for MAC address should be unsigned.
>
> Fixes: 1cfe212ed17a ("kni: support MAC address change")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Jie Pan
Acked-by: Ferruh Yigit
On 4/19/2019 1:03 PM, Rahul Lakkireddy wrote:
> On Friday, April 04/19/19, 2019 at 17:14:25 +0530, Ferruh Yigit wrote:
>> From: Stephen Hemminger
>>
>> This driver defines lots of functions (like init_rss) which are intended
>> to only be used in this device. But when doing static linking these
>>
On 4/19/2019 10:22 AM, Rahul Lakkireddy wrote:
> Fixes: 04868e5bfddd ("net/cxgbe: add support to run Chelsio T6 cards")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Rahul Lakkireddy
Applied to dpdk-next-net/master, thanks.
(Dropped the fixes line while merging)
On 4/19/2019 10:47 AM, David Marchand wrote:
> On Thu, Apr 18, 2019 at 5:27 PM Xiaolong Ye wrote:
>
>> Naming the umem memzone dynamically allows to create multiple af_xdp vdevs.
>>
>> Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD")
>>
>> Reported-by: Markus Theil
>> Signed-off-by: Xiao
On Fri, 2019-04-19 at 13:04 +0100, Bruce Richardson wrote:
> The pipefail option is not supported in /bin/sh, just in bash/ksh and
> similar shells - which means it's there by default on most Linux
> distros
> but not on e.g. FreeBSD. Therefore we check for it's presence before
> setting the option
From: Xiaolong Ye
Naming the buf_ring and umem memzone dynamically allows
to create multiple af_xdp vdevs.
Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD")
Reported-by: Markus Theil
Signed-off-by: Xiaolong Ye
Reviewed-by: David Marchand
---
v2:
* squashed buf_ring & memzone patches
*
On 4/19/2019 1:47 PM, Ferruh Yigit wrote:
> From: Xiaolong Ye
>
> Naming the buf_ring and umem memzone dynamically allows
> to create multiple af_xdp vdevs.
>
> Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD")
>
> Reported-by: Markus Theil
> Signed-off-by: Xiaolong Ye
> Reviewed-by: D
On 04/19, Ferruh Yigit wrote:
>On 4/19/2019 10:47 AM, David Marchand wrote:
>> On Thu, Apr 18, 2019 at 5:27 PM Xiaolong Ye wrote:
>>
>>> Naming the umem memzone dynamically allows to create multiple af_xdp vdevs.
>>>
>>> Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD")
>>>
>>> Reported-by
On 4/10/2019 7:20 AM, Jie Pan wrote:
> The type for MAC address should be unsigned.
>
> Fixes: 1cfe212ed17a ("kni: support MAC address change")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Jie Pan
Acked-by: Ferruh Yigit
Reviewed-by: Rami Rosen
On 4/18/2019 7:13, Ferruh Yigit worte:
> On 4/18/2019 6:19 PM, Herakliusz Lipiec wrote:
> > A sucessfull call to rte_mp_request_sync does not guarantee that there
> > are valid messages in the buffer, and this should be checked for
> > before accessing data in the message.
> >
> > Fixes: c9aa56edec
Fixed the compilation error:
../app/test/test_compressdev.c:1949:11: note: previous
definition of 'i' was here
../app/test/test_compressdev.c:1992:2: error: 'for' loop
initial declarations are only allowed in C99 mode
../app/test/test_compressdev.c:1992:2: note: use option
-std=c99 or -std=gnu99
https://bugs.dpdk.org/show_bug.cgi?id=257
Bug ID: 257
Summary: ipc: rte_mp_request_sync return 0 on error.
Product: DPDK
Version: 18.11
Hardware: All
OS: All
Status: CONFIRMED
Severity: normal
Pr
Hi Thomas et al,
> -Original Message-
> From: Jozwiak, TomaszX
> Sent: Friday, April 19, 2019 1:14 PM
> To: Thomas Monjalon
> Cc: dev@dpdk.org; Richardson, Bruce ;
> david.march...@redhat.com;
> Trahe, Fiona ; ys...@mellanox.com; Cel, TomaszX
>
> Subject: RE: [dpdk-dev] [PATCH] test/co
On 4/19/2019 5:39 PM, Lipiec, Herakliusz wrote:
> On 4/18/2019 7:13, Ferruh Yigit worte:
>> On 4/18/2019 6:19 PM, Herakliusz Lipiec wrote:
>>> A sucessfull call to rte_mp_request_sync does not guarantee that there
>>> are valid messages in the buffer, and this should be checked for
>>> before acces
On 4/19/2019 11:28 AM, Herakliusz Lipiec wrote:
> A sucessfull call to rte_mp_request_sync does not guarantee that there
> are any messages in the buffer, and this should be checked for before
> accessing data in the message. Buffer can be empty if IPC is disabled or
> if we deciede to ignore repli
08/04/2019 09:16, Olivier Matz:
> On Tue, Apr 02, 2019 at 06:09:46PM +0100, Ferruh Yigit wrote:
> > Currently PKT_TX_VLAN and PKT_TX_QINQ mbuf flags are documented as
> > they are to say packet contains VLAN or QINQ information.
> >
> > Updating the definition as they are requests from application
19/04/2019 17:29, Rami Rosen:
> On 4/10/2019 7:20 AM, Jie Pan wrote:
> > The type for MAC address should be unsigned.
> >
> > Fixes: 1cfe212ed17a ("kni: support MAC address change")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Jie Pan
>
> Acked-by: Ferruh Yigit
>
> Reviewed-by: Rami Rosen
A
19/04/2019 18:52, Fiona Trahe:
> Fixed the compilation error:
>
> ../app/test/test_compressdev.c:1949:11: note: previous
> definition of 'i' was here
>
> ../app/test/test_compressdev.c:1992:2: error: 'for' loop
> initial declarations are only allowed in C99 mode
>
> ../app/test/test_compressdev.
19/04/2019 14:12, Bruce Richardson:
> On Fri, Apr 19, 2019 at 02:09:51PM +0200, David Marchand wrote:
> >nit: "test/compress:" for the title prefix ?
>
> maybe so, half the time I never know what to prefix autotest stuff like
> this with! :-) Thomas, please fix on apply, if possible.
In this
19/04/2019 14:42, Luca Boccassi:
> On Fri, 2019-04-19 at 13:04 +0100, Bruce Richardson wrote:
> > The pipefail option is not supported in /bin/sh, just in bash/ksh and
> > similar shells - which means it's there by default on most Linux
> > distros
> > but not on e.g. FreeBSD. Therefore we check fo
Make rte_rand() multi-thread safe, go faster and produce
better-quality pseudo-random numbers.
v2:
* Removed 32-bit version of rte_rand() and rte_rand_max().
* Switched from a four-sequence LFSR (producing a 32-bit number)
to a five-sequence LFSR (producing a 64-bit number).
* Added a note on ge
This commit replaces rte_rand()'s use of lrand48() with a DPDK-native
combined Linear Feedback Shift Register (LFSR) (also known as
Tausworthe) pseudo-number generator, with five sequences.
This generator is faster and produces better quality random numbers
than libc's lrand48() implementation. Th
Add a function rte_rand_max() which generates an uniformly distributed
pseudo-random number less than a user-specified upper bound.
The commonly used pattern rte_rand() % SOME_VALUE, in addition to
being slow, also creates biased results if SOME_VALUE is not a power
of 2. This bias is very small f
All the library calls must be called via the glue layer.
Fixes: b2177648b8de ("net/mlx5: add Direct Rules flow data alloc/free routines")
Fixes: 79e35d0d5979 ("net/mlx5: share Direct Rules/Verbs flow related
structures")
Cc: viachesl...@mellanox.com
Signed-off-by: Yongseok Koh
---
drivers/net/
68 matches
Mail list logo
