milanisvet commented on code in PR #49518: URL: https://github.com/apache/spark/pull/49518#discussion_r1925291147
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/cteOperators.scala: ########## @@ -100,12 +100,14 @@ case class CTERelationDef( override def output: Seq[Attribute] = if (resolved) child.output else Nil - lazy val recursive: Boolean = child.exists{ - // If the reference is found inside the child, referencing to this CTE definition, - // and already marked as recursive, then this CTE definition is recursive. + lazy val hasRecursiveCTERelationRef: Boolean = child.exists{ Review Comment: Renamed, very good names, did not come to my mind previously :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org