cloud-fan commented on code in PR #49518:
URL: https://github.com/apache/spark/pull/49518#discussion_r1924741615


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveWithCTE.scala:
##########
@@ -183,4 +184,52 @@ object ResolveWithCTE extends Rule[LogicalPlan] {
         columnNames.map(UnresolvedSubqueryColumnAliases(_, ref)).getOrElse(ref)
     }
   }
+
+  /**
+   * Checks if data types of anchor and recursive terms of a recursive CTE 
definition match.
+   */
+  def checkDataTypesAnchorAndRecursiveTerm(unionLoop: UnionLoop): Unit = {
+    val anchorOutputDatatypes = unionLoop.anchor.output.map(_.dataType)
+    val recursiveTermOutputDatatypes = 
unionLoop.recursion.output.map(_.dataType)
+
+    if (!anchorOutputDatatypes.zip(recursiveTermOutputDatatypes).forall {

Review Comment:
   is it really needed? The type check for Union will report error anyway, 
right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to