cloud-fan commented on code in PR #49518:
URL: https://github.com/apache/spark/pull/49518#discussion_r1926567235
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CTESubstitution.scala:
##########
@@ -313,6 +319,11 @@ object CTESubstitution extends Rule[LogicalPlan] {
} else {
None
}
+ // Also, if recursion is allowed, we should check that there is no
self-reference within
+ // subqueries inside the CTE definition.
+ if (allowRecursion) {
+ checkForSelfReferenceInSubquery(name, relation)
Review Comment:
Actually we should do the check in `CheckAnalysis` because refs can be
lazily resolved due to `PlanWithUnresolvedIdentifier`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
