cloud-fan commented on code in PR #49518:
URL: https://github.com/apache/spark/pull/49518#discussion_r1924740592
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CTESubstitution.scala:
##########
@@ -423,4 +429,20 @@ object CTESubstitution extends Rule[LogicalPlan] {
case _ => WithCTE(p, cteDefs)
}
}
+
+ /**
+ * Counts number of self-references in a recursive CTE definition and throws
an error
+ * if that number is bigger than 1.
+ */
+ private def checkNumberOfSelfReferences(cteDef: CTERelationDef): Unit = {
+ val numOfSelfRef = cteDef.map[Boolean] {
+ case CTERelationRef(cteDef.id, _, _, _, _, true) => true
+ case other => false
+ }.count(_ == true)
Review Comment:
or use .collect
```
val numOfSelfRef = cteDef.collectWithSubqueries {
case ref: CTERelationRef red.cteId = cteDef.id => ref
}.length
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
