cloud-fan commented on code in PR #49518:
URL: https://github.com/apache/spark/pull/49518#discussion_r1924739240
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CTESubstitution.scala:
##########
@@ -151,7 +157,7 @@ object CTESubstitution extends Rule[LogicalPlan] {
plan.resolveOperatorsUp {
case cte @ UnresolvedWith(child, relations, allowRecursion) =>
if (allowRecursion) {
- cte.failAnalysis(
+ throw new AnalysisException(
Review Comment:
why this change?
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CTESubstitution.scala:
##########
@@ -210,7 +216,7 @@ object CTESubstitution extends Rule[LogicalPlan] {
// allowRecursion flag is set to `True` by the parser if the `RECURSIVE`
keyword is used.
case cte @ UnresolvedWith(child: LogicalPlan, relations, allowRecursion)
=>
if (allowRecursion && forceInline) {
- cte.failAnalysis(
+ throw new AnalysisException(
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
