milanisvet commented on code in PR #49518: URL: https://github.com/apache/spark/pull/49518#discussion_r1925294587
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CTESubstitution.scala: ########## @@ -151,7 +157,7 @@ object CTESubstitution extends Rule[LogicalPlan] { plan.resolveOperatorsUp { case cte @ UnresolvedWith(child, relations, allowRecursion) => if (allowRecursion) { - cte.failAnalysis( + throw new AnalysisException( Review Comment: Because in `ResolveWithCTE.scala` all exceptions are written in this way, so I thought it is better to rewrite it also like that in `CTESubstitution.scala`. Should I turn them back to `cte.failAnalysis..`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org