milanisvet commented on PR #49518: URL: https://github.com/apache/spark/pull/49518#issuecomment-2605067854
As discussed offline, `checkIfSelfReferenceIsPlacedCorrectly` and `checkDataTypesAnchorAndRecursiveTerm` definitions left in `resolveWithCTE` singleton, but invoked in `checkAnalysis` to be invoked only once during analysis and not multiple times as if it would have been if we had invoked them in `resolveWithCTE` as well. `checkNumberOfSelfReferences` is moved earlier to CTESubstitution stage following the "fail early" approach -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
