davidm-db commented on code in PR #49427:
URL: https://github.com/apache/spark/pull/49427#discussion_r1916430329
##########
sql/core/src/main/scala/org/apache/spark/sql/scripting/SqlScriptingExecutionNode.scala:
##########
@@ -965,3 +970,17 @@ class ForStatementExec(
body.reset()
}
}
+
+/**
+ * Executable node for ErrorHandlerStatement.
+ * @param body Executable CompoundBody of the error handler.
+ */
+class ErrorHandlerExec(
+ val body: CompoundBodyExec,
+ val handlerType: HandlerType,
+ val scopeToExit: Option[String]) extends NonLeafStatementExec {
Review Comment:
nit: should we rename `scopeToExit` to something else here, like
`handlerScope` or `scopeLabel` maybe, since it looks like this will be used for
both `CONTINUE` and `EXIT` handlers.
##########
sql/core/src/main/scala/org/apache/spark/sql/scripting/SqlScriptingExecutionNode.scala:
##########
@@ -965,3 +970,17 @@ class ForStatementExec(
body.reset()
}
}
+
+/**
+ * Executable node for ErrorHandlerStatement.
+ * @param body Executable CompoundBody of the error handler.
+ */
+class ErrorHandlerExec(
+ val body: CompoundBodyExec,
+ val handlerType: HandlerType,
+ val scopeToExit: Option[String]) extends NonLeafStatementExec {
Review Comment:
nit: should we rename `scopeToExit` to something else here, like
`handlerScope` or `scopeLabel` maybe, since it looks like this will be used for
both `CONTINUE` and `EXIT` handlers?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
